inline_forms 7.2.11 → 7.5.2

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_versions_turbo_test.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+class ExampleAppApartmentVersionsTurboTest < ExampleAppIntegrationTestCase
+  setup do
+    @apartment = Apartment.first || Apartment.create!(name: "Versions Turbo", title: "T")
+    @versions_frame = "apartment_#{@apartment.id}_versions"
+    @headers = { "Turbo-Frame" => @versions_frame, "Accept" => "text/html" }
+  end
+
+  test "versions list opens inside matching turbo-frame" do
+    get list_versions_apartment_path(@apartment, update: @versions_frame), headers: @headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@versions_frame}">)
+    assert_includes @response.body, "Changeset"
+    refute_includes @response.body, 'data-remote="true"'
+  end
+
+  test "versions list close returns panel header inside turbo-frame" do
+    get list_versions_apartment_path(@apartment, update: @versions_frame, close: true),
+        headers: @headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@versions_frame}">)
+    refute_includes @response.body, "Changeset"
+  end
+end

data/lib/installer_templates/example_app_tests/test/models/example_app_plain_text_rich_text_edge_cases_test.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class ExampleAppPlainTextRichTextEdgeCasesTest < ActiveSupport::TestCase
+  def with_temporary_inline_forms_attribute_list(klass, temporary_list)
+    original = klass.instance_method(:inline_forms_attribute_list)
+    klass.define_method(:inline_forms_attribute_list) { temporary_list }
+    yield
+  ensure
+    klass.define_method(:inline_forms_attribute_list, original)
+  end
+
+  test "plain_text mapped to actiontext-backed attribute raises configuration error" do
+    with_temporary_inline_forms_attribute_list(
+      Apartment,
+      [[:description, "description", :plain_text]]
+    ) do
+      error = assert_raises(InlineForms::PlainTextColumnMissingError) do
+        InlineForms.validate_plain_text_configuration_for!(Apartment)
+      end
+      assert_includes(error.message, "description")
+      assert_includes(error.message, ":rich_text")
+    end
+  end
+
+  test "plain_text runtime guard raises before assigning unknown DB attribute" do
+    apartment = Apartment.create!(name: "Mismatch", title: "Check")
+    assert_raises(InlineForms::PlainTextColumnMissingError) do
+      InlineForms.assert_plain_text_column!(
+        object: apartment,
+        attribute: :description,
+        form_element: :plain_text
+      )
+    end
+  end
+
+  test "switching text column field from plain_text to rich_text does not raise" do
+    with_temporary_inline_forms_attribute_list(
+      Role,
+      [[:description, "description", :rich_text]]
+    ) do
+      InlineForms.validate_plain_text_configuration_for!(Role)
+    end
+  end
+end

data/lib/installer_templates/example_app_views/apartments/name_list.html.erb

@@ -0,0 +1,26 @@
+<% @inline_forms_turbo_field = true %>
+<div class="row">
+  <div class="small-12 columns">
+    <h2>Apartment names (first 10)</h2>
+    <p>
+      <%= link_to "Back to full apartment list", apartments_path %>
+    </p>
+    <p class="help-text">
+      Each name is an inline edit via <code>text_field_show</code> — no stock
+      <code>_show</code> panel. Click a name to edit it in place.
+    </p>
+  </div>
+</div>
+
+<% @apartments.each do |apartment| %>
+  <div class="row">
+    <div class="small-2 columns">
+      <%= apartment.id %>
+    </div>
+    <div class="small-10 columns">
+      <turbo-frame id="apartment_<%= apartment.id %>_name">
+        <%= text_field_show(apartment, :name) %>
+      </turbo-frame>
+    </div>
+  </div>
+<% end %>

data/lib/installer_templates/example_app_views/inline_forms/_header.html.erb

@@ -0,0 +1,45 @@
+<div class="contain-to-grid fixed">
+  <nav id='inline_forms_application_top_bar' class="top-bar">
+    <div class="top-bar-left">
+      <ul class="menu">
+        <li class="menu-text">
+          <h1 style="margin: 0; font-size: inherit;"><a href="/"><%= application_name %> v<%= inline_forms_version %> <%= current_user.name %></a></h1>
+        </li>
+      </ul>
+    </div>
+    <div class="top-bar-right">
+      <ul class="dropdown menu" data-dropdown-menu>
+        <% if current_user.role?(:admin) || current_user.role?(:superadmin) %>
+          <li>
+            <a href="#"><%= t 'common.more' %></a>
+            <ul class="menu">
+              <% MODEL_TABS.each do |m| %>
+                <% model = m.singularize.camelcase.constantize rescue nil %>
+                  <% unless model.nil? || model.not_accessible_through_html? %>
+                  <% if can? :update, model %>
+                  <li>
+                    <%= link_to model.model_name.human, '/' +  m %>
+                  </li>
+                  <% end %>
+                <% end %>
+              <% end %>
+              <% if can? :read, Apartment %>
+              <li>
+                <%= link_to "Apartment names (first 10)", apartment_name_list_path %>
+              </li>
+              <% end %>
+            </ul>
+          </li>
+        <% end %>
+        <li>
+          <a href="#"><%= current_user.name %></a>
+          <ul class="menu">
+            <li>
+              <%= link_to( t("common.logout"), destroy_user_session_path, :method => :delete) if current_user  %>
+            </li>
+          </ul>
+        </li>
+      </ul>
+    </div>
+  </nav>
+</div>

data/test/inline_forms_generator_test.rb

@@ -100,6 +100,16 @@ class InlineFormsGeneratorTest < Minitest::Test
     refute_includes(migration, "t.text :content")
   end
 
+  def test_plain_text_generates_text_column_and_plain_text_form_element
+    run_generator("Note", "title:string", "description:plain_text")
+
+    model = read("app/models/note.rb")
+    migration = read_single_migration_for("notes")
+
+    assert_includes(model, "[ :description , \"description\", :plain_text ]")
+    assert_includes(migration, "t.text :description")
+  end
+
   private
 
   def build_destination_skeleton!

data/test/plain_text_configuration_test.rb

@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+
+require_relative "test_helper"
+require "rails"
+require "inline_forms"
+
+class PlainTextConfigurationTest < Minitest::Test
+  class PlainTextModelWithColumn
+    def self.table_exists?
+      true
+    end
+
+    def self.column_names
+      %w[id description]
+    end
+
+    def self.table_name
+      "plain_text_model_with_columns"
+    end
+
+    def inline_forms_attribute_list
+      [
+        [:description, "description", :plain_text]
+      ]
+    end
+  end
+
+  class PlainTextModelWithoutColumn
+    def self.table_exists?
+      true
+    end
+
+    def self.column_names
+      %w[id]
+    end
+
+    def self.table_name
+      "plain_text_model_without_columns"
+    end
+
+    def inline_forms_attribute_list
+      [
+        [:description, "description", :plain_text]
+      ]
+    end
+  end
+
+  class RichTextModelWithoutColumn
+    def self.table_exists?
+      true
+    end
+
+    def self.column_names
+      %w[id]
+    end
+
+    def inline_forms_attribute_list
+      [
+        [:description, "description", :rich_text]
+      ]
+    end
+  end
+
+  def test_plain_text_column_check_passes_when_column_exists
+    model = PlainTextModelWithColumn.new
+    InlineForms.assert_plain_text_column!(object: model, attribute: :description, form_element: :plain_text)
+  end
+
+  def test_plain_text_column_check_raises_when_column_missing
+    model = PlainTextModelWithoutColumn.new
+    error = assert_raises(InlineForms::PlainTextColumnMissingError) do
+      InlineForms.assert_plain_text_column!(object: model, attribute: :description, form_element: :plain_text)
+    end
+    assert_includes(error.message, "has no DB column")
+  end
+
+  def test_configuration_check_raises_for_plain_text_without_column
+    assert_raises(InlineForms::PlainTextColumnMissingError) do
+      InlineForms.validate_plain_text_configuration_for!(PlainTextModelWithoutColumn)
+    end
+  end
+
+  def test_configuration_check_allows_rich_text_without_column
+    InlineForms.validate_plain_text_configuration_for!(RichTextModelWithoutColumn)
+  end
+
+  def test_text_area_alias_is_not_treated_as_plain_text_column_requirement
+    refute InlineForms.plain_text_form_element?(:text_area)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: inline_forms
 version: !ruby/object:Gem::Version
-  version: 7.2.11
+  version: 7.5.2
 platform: ruby
 authors:
 - Ace Suares
@@ -504,6 +504,7 @@ files:
 - app/helpers/form_elements/move.rb
 - app/helpers/form_elements/multi_image_field.rb
 - app/helpers/form_elements/pdf_link.rb
+- app/helpers/form_elements/plain_text.rb
 - app/helpers/form_elements/plain_text_area.rb
 - app/helpers/form_elements/question_list.rb
 - app/helpers/form_elements/radio_button.rb
@@ -550,17 +551,23 @@ files:
 - app/views/inline_forms/_versions.html.erb
 - app/views/inline_forms/_versions_list.html.erb
 - app/views/inline_forms/close.js.erb
-- app/views/inline_forms/edit.js.erb
+- app/views/inline_forms/create_list_frame.html.erb
 - app/views/inline_forms/extract_translations.erb
+- app/views/inline_forms/field_edit.html.erb
+- app/views/inline_forms/field_show.html.erb
 - app/views/inline_forms/list.js.erb
 - app/views/inline_forms/new.js.erb
+- app/views/inline_forms/new_record.html.erb
 - app/views/inline_forms/record_destroyed.js.erb
+- app/views/inline_forms/row_close.html.erb
+- app/views/inline_forms/row_destroyed.html.erb
+- app/views/inline_forms/row_show.html.erb
 - app/views/inline_forms/show.js.erb
-- app/views/inline_forms/show_element.js.erb
 - app/views/inline_forms/show_undo.js.erb
-- app/views/inline_forms/update.js.erb
 - app/views/inline_forms/versions.js.erb
 - app/views/inline_forms/versions_list.js.erb
+- app/views/inline_forms/versions_list_panel.html.erb
+- app/views/inline_forms/versions_panel.html.erb
 - app/views/layouts/application.html.erb
 - app/views/layouts/devise.html.erb
 - app/views/layouts/inline_forms.html.erb
@@ -569,9 +576,9 @@ files:
 - bin/inline_forms_installer_core.rb
 - docs/prompt/.gitignore
 - docs/prompt/test-the-example-app.md
+- docs/ujs-to-turbo.md
 - inline_forms.gemspec
 - lib/generators/USAGE
-- lib/generators/assets/javascripts/ckeditor/config.js
 - lib/generators/assets/stylesheets/inline_forms.scss
 - lib/generators/assets/stylesheets/inline_forms_devise.css
 - lib/generators/inline_forms_generator.rb
@@ -592,13 +599,21 @@ files:
 - lib/installer_templates/dartsass/inline_forms_dartsass_builds.rb
 - lib/installer_templates/dartsass/inline_forms_main.scss
 - lib/installer_templates/example_app_tests/test/example_app/example_integration_test_case.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_apartment_field_turbo_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_apartment_name_list_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_apartment_photos_pagination_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_apartment_row_turbo_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_apartment_top_level_new_test.rb
+- lib/installer_templates/example_app_tests/test/integration/example_app_apartment_versions_turbo_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_guest_access_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_photos_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_routing_test.rb
 - lib/installer_templates/example_app_tests/test/integration/example_app_turbo_layout_test.rb
 - lib/installer_templates/example_app_tests/test/models/example_app_apartment_photo_test.rb
 - lib/installer_templates/example_app_tests/test/models/example_app_paper_trail_changeset_test.rb
+- lib/installer_templates/example_app_tests/test/models/example_app_plain_text_rich_text_edge_cases_test.rb
+- lib/installer_templates/example_app_views/apartments/name_list.html.erb
+- lib/installer_templates/example_app_views/inline_forms/_header.html.erb
 - lib/locales/inline_forms.en.yml
 - lib/locales/inline_forms.nl.yml
 - lib/otherstuff/20120310065554_inline_forms_create_view_for_translations.rb
@@ -610,6 +625,7 @@ files:
 - test/form_element_from_callee_test.rb
 - test/inline_edit_polymorphic_path_test.rb
 - test/inline_forms_generator_test.rb
+- test/plain_text_configuration_test.rb
 - test/test_helper.rb
 homepage: http://github.com/acesuares/inline_forms
 licenses:

data/app/views/inline_forms/edit.js.erb

@@ -1 +0,0 @@
-$('#<%= @update_span %>').html('<%= escape_javascript(render(:partial => 'inline_forms/edit' ))%>')

data/app/views/inline_forms/show_element.js.erb

@@ -1 +0,0 @@
-$('#<%= @update_span %>').html('<%= escape_javascript(send("#{@form_element}_show", @object, @attribute))%>')

data/app/views/inline_forms/update.js.erb

@@ -1 +0,0 @@
-$('#<%= @update_span %>').html('<%= escape_javascript(send("#{@form_element.to_s}_show", @object, @attribute))%>')

data/lib/generators/assets/javascripts/ckeditor/config.js

@@ -1,72 +0,0 @@
-/*
-Copyright (c) 2003-2011, CKSource - Frederico Knabben. All rights reserved.
-For licensing, see LICENSE.html or http://ckeditor.com/license
-*/
-
-CKEDITOR.editorConfig = function( config )
-{
-    // Define changes to default configuration here. For example:
-    // config.language = 'fr';
-    // config.uiColor = '#AADC6E';
-
-    /* Filebrowser routes */
-    // The location of an external file browser, that should be launched when "Browse Server" button is pressed.
-    config.filebrowserBrowseUrl = "/ckeditor/attachment_files";
-
-    // The location of an external file browser, that should be launched when "Browse Server" button is pressed in the Flash dialog.
-    config.filebrowserFlashBrowseUrl = "/ckeditor/attachment_files";
-
-    // The location of a script that handles file uploads in the Flash dialog.
-    config.filebrowserFlashUploadUrl = "/ckeditor/attachment_files";
-
-    // The location of an external file browser, that should be launched when "Browse Server" button is pressed in the Link tab of Image dialog.
-    config.filebrowserImageBrowseLinkUrl = "/ckeditor/pictures";
-
-    // The location of an external file browser, that should be launched when "Browse Server" button is pressed in the Image dialog.
-    config.filebrowserImageBrowseUrl = "/ckeditor/pictures";
-
-    // The location of a script that handles file uploads in the Image dialog.
-    var token = $('meta[name=csrf-token]').attr('content');
-    var param = $('meta[name=csrf-param]').attr('content');
-    config.filebrowserImageUploadUrl = "/ckeditor/pictures" + "?" + token + "=" + param;
-    // The location of a script that handles file uploads.
-    config.filebrowserUploadUrl = "/ckeditor/attachment_files";
-
-    // Rails CSRF token
-    config.filebrowserParams = function(){
-        var csrf_token = $('meta[name=csrf-token]').attr('content'),
-        csrf_param = $('meta[name=csrf-param]').attr('content'),
-        params = new Object();
-
-        if (csrf_param !== undefined && csrf_token !== undefined) {
-            params[csrf_param] = csrf_token;
-        }
-
-        return params;
-    };
-
-    config.height = 400;
-    config.width = 600;
-
-		config.language = 'nl';
-
-		// these two lines needed for spellchecking in the browser!
-		config.disableNativeSpellChecker = false;
-		config.removePlugins = 'contextmenu,liststyle,tabletools';
-
-		/* Toolbars */
-
-		config.toolbarCanCollapse = false;
-
-		config.toolbar_Minimal =
-		[
-			['Format','-','Bold','Italic','Underline','-','NumberedList','BulletedList','-','Link'],
-			['PasteFromWord','RemoveFormat','Source','-','Undo','Redo','-','Maximize']
-		];
-
-		config.toolbar_None =
-		[ '-' ];
-
-		config.toolbar = 'Minimal';
-
-};