inline_forms 7.2.11 → 7.5.2

data/lib/inline_forms.rb

@@ -4,6 +4,8 @@ require_relative ('inline_forms/form_element_from_callee')
 # InlineForms is a Rails Engine that let you setup an admin interface quick and
 # easy. Please install it as a gem or include it in your Gemfile.
 module InlineForms
+  class PlainTextColumnMissingError < StandardError; end
+
   # DEFAULT_COLUMN_TYPES holds the standard ActiveRecord::Migration column types.
   # This list provides compatability with the standard types, but we add our own
   # later in 'Special Column Types'.
@@ -62,7 +64,7 @@ module InlineForms
   #
   DEFAULT_FORM_ELEMENTS = {
     :string     => :text_field,
-    :text       => :text_area,
+    :text       => :plain_text,
     :integer    => :text_field,
     :float      => :text_field,
     :decimal    => :text_field,
@@ -93,6 +95,45 @@ module InlineForms
     :associated => :no_migration
   }
 
+  PLAIN_TEXT_FORM_ELEMENTS = %i[
+    plain_text
+    plain_text_area
+    text_area_without_ckeditor
+  ].freeze
+
+  def self.plain_text_form_element?(form_element)
+    PLAIN_TEXT_FORM_ELEMENTS.include?(form_element.to_sym)
+  rescue NoMethodError
+    false
+  end
+
+  def self.assert_plain_text_column!(object:, attribute:, form_element:)
+    return unless plain_text_form_element?(form_element)
+    return if object.class.column_names.include?(attribute.to_s)
+
+    raise PlainTextColumnMissingError,
+      "#{object.class.name}##{attribute} uses #{form_element} but has no DB column `#{attribute}`. " \
+      "Use :rich_text for ActionText-backed attributes, or add a text column for :plain_text."
+  end
+
+  def self.validate_plain_text_configuration_for!(klass)
+    return unless klass.respond_to?(:table_exists?) &&
+                  klass.respond_to?(:column_names) &&
+                  klass.instance_methods.include?(:inline_forms_attribute_list)
+    return unless klass.table_exists?
+
+    attributes = klass.new.inline_forms_attribute_list
+    attributes.each do |attribute, _label, form_element|
+      next unless plain_text_form_element?(form_element)
+      next if klass.column_names.include?(attribute.to_s)
+
+      raise PlainTextColumnMissingError,
+        "#{klass.name} inline_forms_attribute_list declares #{attribute}:#{form_element}, " \
+        "but table `#{klass.table_name}` has no `#{attribute}` column. " \
+        "Use :rich_text for ActionText-backed attributes."
+    end
+  end
+
   # RELATIONS defines a mapping between AR::Migrations columns and the Model.
   #
   # When a column has the type of :references or :belongs_to, then
@@ -144,7 +185,6 @@ module InlineForms
         inline_forms/inline_forms.css
         inline_forms/devise.css
         inline_forms/inline_forms.js
-        inline_forms/ckeditor/config.js
         inline_forms/glass_plate.gif
       )
     end
@@ -159,6 +199,22 @@ module InlineForms
       app.config.assets.paths << path unless app.config.assets.paths.include?(path)
     end
 
+    config.to_prepare do
+      next unless defined?(ActiveRecord::Base)
+
+      ActiveRecord::Base.descendants.each do |klass|
+        begin
+          InlineForms.validate_plain_text_configuration_for!(klass)
+        rescue InlineForms::PlainTextColumnMissingError
+          raise
+        rescue StandardError
+          # Some descendants might be abstract or temporarily unresolved while
+          # the app boots/reloads; runtime checks in controllers still enforce
+          # plain_text column presence for active resources.
+        end
+      end
+    end
+
     I18n.load_path << Dir[File.join(File.expand_path(File.dirname(__FILE__) + '/locales'), '*.yml')]
     I18n.load_path.flatten!
   end

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_field_turbo_test.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# Stock _show partial: scalar fields are wrapped in <turbo-frame> and use HTML
+# edit/update/cancel (no UJS on field links/forms). Same contract as name_list.
+class ExampleAppApartmentFieldTurboTest < ExampleAppIntegrationTestCase
+  setup do
+    @apartment = Apartment.find_or_create_by!(name: "Turbo Field Apt") do |a|
+      a.title = "Turbo Field Title"
+    end
+    @frame_id = "apartment_#{@apartment.id}_name"
+    @turbo_headers = { "Turbo-Frame" => @frame_id }
+  end
+
+  test "show panel partial wraps scalar fields in turbo-frame" do
+    get apartment_path(@apartment, update: "apartment_#{@apartment.id}"),
+        headers: {
+          "Accept" => "text/javascript, application/javascript",
+          "X-Requested-With" => "XMLHttpRequest"
+        }
+
+    assert_response :success
+    assert_includes @response.body, "turbo-frame",
+      "UJS show.js.erb should embed _show with turbo-frame field wrappers"
+    assert_includes @response.body, @frame_id
+  end
+
+  test "stock scalar field edit update and cancel via turbo-frame" do
+    get edit_apartment_path(
+      @apartment,
+      attribute: "name",
+      form_element: "text_field",
+      update: @frame_id
+    ), headers: @turbo_headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@frame_id}">)
+    refute_includes @response.body, 'data-remote="true"'
+
+    put apartment_path(
+      @apartment,
+      attribute: "name",
+      form_element: "text_field",
+      update: @frame_id
+    ), params: { name: "Stock Turbo Name" }, headers: @turbo_headers
+    assert_response :success
+    assert_includes @response.body, "Stock Turbo Name"
+    assert_equal "Stock Turbo Name", @apartment.reload.name
+
+    get apartment_path(
+      @apartment,
+      attribute: "name",
+      form_element: "text_field",
+      update: @frame_id
+    ), headers: @turbo_headers
+    assert_response :success
+    assert_includes @response.body, "Stock Turbo Name"
+    refute_includes @response.body, 'name="name"',
+      "cancel returns read-only field, not edit form"
+  end
+
+  test "field show cancel responds to html even without Turbo-Frame header" do
+    get apartment_path(
+      @apartment,
+      attribute: "name",
+      form_element: "text_field",
+      update: @frame_id
+    ), headers: { "Accept" => "text/html, application/xhtml+xml" }
+
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@frame_id}">)
+    assert_includes @response.body, @apartment.name
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_name_list_test.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# Custom page demo: same turbo-field contract as stock _show, without opening the panel.
+class ExampleAppApartmentNameListTest < ExampleAppIntegrationTestCase
+  setup do
+    @apartments = 10.times.map do |i|
+      Apartment.find_or_create_by!(name: "NameList Apt #{i}") do |a|
+        a.title = "Title #{i}"
+      end
+    end
+  end
+
+  test "name list page is reachable and renders turbo-frame inline-edit targets for first 10 apartments" do
+    get apartment_name_list_path
+    assert_response :success
+
+    Apartment.order(:id).limit(10).each do |apartment|
+      assert_includes @response.body, %(<turbo-frame id="apartment_#{apartment.id}_name">),
+        "expected turbo-frame wrapper for apartment #{apartment.id}"
+      assert_includes @response.body, apartment.name,
+        "expected apartment name on page"
+    end
+  end
+
+  test "more menu links to apartment name list" do
+    get apartments_path
+    assert_response :success
+    assert_includes @response.body, apartment_name_list_path,
+      "expected More menu link to name list"
+    assert_includes @response.body, "Apartment names (first 10)"
+  end
+
+  test "name list field links use turbo-frame navigation not UJS remote" do
+    apartment = @apartments.first
+    get apartment_name_list_path
+    assert_response :success
+
+    frame_html = @response.body[%r{<turbo-frame id="apartment_#{apartment.id}_name">.*?</turbo-frame>}m]
+    assert frame_html, "expected turbo-frame for apartment #{apartment.id}"
+    assert_match(
+      %r/href="[^"]*\/apartments\/#{apartment.id}\/edit[^"]*update=apartment_#{apartment.id}_name[^"]*"/,
+      frame_html,
+      "expected edit link with update= matching turbo-frame id"
+    )
+    refute_includes frame_html, 'data-remote="true"',
+      "field edits use Turbo frames, not UJS"
+  end
+
+  test "name list reuses stock turbo field edit update cycle" do
+    apartment = @apartments.first
+    frame_id = "apartment_#{apartment.id}_name"
+    turbo_headers = { "Turbo-Frame" => frame_id }
+
+    get edit_apartment_path(
+      apartment,
+      attribute: "name",
+      form_element: "text_field",
+      update: frame_id
+    ), headers: turbo_headers
+    assert_response :success
+
+    put apartment_path(
+      apartment,
+      attribute: "name",
+      form_element: "text_field",
+      update: frame_id
+    ), params: { name: "Name List Turbo" }, headers: turbo_headers
+    assert_response :success
+    assert_equal "Name List Turbo", apartment.reload.name
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_photos_pagination_test.rb

@@ -197,7 +197,7 @@ class ExampleAppApartmentPhotosPaginationTest < ExampleAppIntegrationTestCase
     )
   end
 
-  test "row container opts out of Turbo so swapped-in UJS forms (replace photo etc.) keep working" do
+  test "nested photo rows are turbo-framed with Turbo presentation links (no data-turbo false on row)" do
     get photos_path(
       parent_class: "Apartment",
       parent_id: @apartment.id,
@@ -206,23 +206,207 @@ class ExampleAppApartmentPhotosPaginationTest < ExampleAppIntegrationTestCase
     )
     assert_response :success
 
-    # The container-level opt-out is what protects the inline-edit /
-    # replace-photo flow: when a user replaces a photo, show.js.erb /
-    # edit.js.erb does $('#<row_id>').html(<form>), so the multipart
-    # form that submits the upload is a descendant of this row. With
-    # data-turbo="false" on the row, Turbo doesn't intercept that
-    # submission -- jquery-ujs + remotipart do, the request goes out
-    # with Accept: text/javascript, and the controller's format.js
-    # branch handles it. Without this, Turbo Frames would send
-    # Accept: text/html and the update action (no format.html for
-    # not_accessible_through_html? models like Photo) raises
-    # UnknownFormat AFTER the DB write -- a 406 with a corrupted UI.
     sample_row_id = "apartment_#{@apartment.id}_photo_#{@apartment.photos.first.id}"
     assert_match(
-      %r{<div[^>]+id="#{Regexp.escape(sample_row_id)}"[^>]*data-turbo="false"|<div[^>]+data-turbo="false"[^>]*id="#{Regexp.escape(sample_row_id)}"},
+      %r{<turbo-frame[^>]*\bid="#{Regexp.escape(sample_row_id)}"},
       @response.body,
-      "expected the per-row container (id=\"#{sample_row_id}\") to carry data-turbo=\"false\" " \
-      "so swapped-in UJS forms inherit the Turbo opt-out"
+      "expected each nested photo row to be a <turbo-frame id=\"#{sample_row_id}\">"
     )
+    refute_match(
+      %r{<turbo-frame[^>]*id="#{Regexp.escape(sample_row_id)}"[^>]*data-turbo="false"},
+      @response.body,
+      "nested turbo-frame rows must not opt out of Turbo (field cancel / pagination live inside frames)"
+    )
+    assert_select %(turbo-frame##{sample_row_id} a[data-turbo='true'][data-turbo-frame='#{sample_row_id}']), minimum: 1
+  end
+
+  test "nested Photo row opens and closes via Turbo HTML (not_accessible_through_html model)" do
+    photo = @apartment.photos.first!
+    row_id = "apartment_#{@apartment.id}_photo_#{photo.id}"
+    row_headers = { "Turbo-Frame" => row_id, "Accept" => "text/html" }
+
+    get photo_path(photo, update: row_id), headers: row_headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{row_id}">)
+    assert_includes @response.body, "object_presentation"
+
+    get photo_path(photo, update: row_id, close: true), headers: row_headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{row_id}">)
+    refute_includes @response.body, "object_presentation"
+  end
+
+  test "nested Photo name field cancel returns field show HTML (Turbo)" do
+    photo = @apartment.photos.first!
+    frame_id = "apartment_#{@apartment.id}_photo_#{photo.id}_name"
+    turbo_headers = { "Turbo-Frame" => frame_id, "Accept" => "text/html" }
+
+    get edit_photo_path(
+      photo,
+      attribute: "name",
+      form_element: "text_field",
+      update: frame_id
+    ), headers: turbo_headers
+    assert_response :success
+
+    get photo_path(
+      photo,
+      attribute: "name",
+      form_element: "text_field",
+      update: frame_id
+    ), headers: turbo_headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{frame_id}">)
+    refute_includes @response.body, 'name="name"',
+      "cancel must return read-only field, not the edit form"
+  end
+
+  # Step 3 (ujs-to-turbo.md): nested `not_accessible_through_html?` Photo + CarrierWave
+  # `image` must accept Turbo-driven multipart PUT inside the field `<turbo-frame>`
+  # (no `UnknownFormat` / 406 after DB write — regression class from 7.2.0).
+  test "nested Photo image field updates via Turbo multipart PUT inside field frame" do
+    photo = @apartment.photos.first!
+    frame_id = "apartment_#{@apartment.id}_photo_#{photo.id}_image"
+    turbo_headers = { "Turbo-Frame" => frame_id, "Accept" => "text/html" }
+
+    get edit_photo_path(
+      photo,
+      attribute: "image",
+      form_element: "image_field",
+      update: frame_id
+    ), headers: turbo_headers
+    assert_response :success
+    assert_includes @response.body, %(enctype="multipart/form-data"),
+      "image edit form must stay multipart when Turbo omits remote: true"
+    assert_includes @response.body, %(<turbo-frame id="#{frame_id}">)
+
+    seed_dir = Rails.root.join("db", "seed_images")
+    jpgs = Dir.glob(seed_dir.join("*.{jpg,jpeg}"), File::FNM_CASEFOLD).sort
+    assert_operator jpgs.size, :>=, 2,
+      "need at least two seed jpgs so replacement can differ from current mount"
+
+    replacement = jpgs.find { |abs| File.basename(abs) != photo.name } || jpgs.last
+    uploaded = Rack::Test::UploadedFile.new(replacement, "image/jpeg")
+
+    put photo_path(
+      photo,
+      attribute: "image",
+      form_element: "image_field",
+      update: frame_id
+    ),
+        params: { image: uploaded },
+        headers: turbo_headers
+
+    assert_response :success,
+      "multipart image update must respond with HTML (not 406 UnknownFormat)"
+    assert_includes @response.body, %(<turbo-frame id="#{frame_id}">)
+    refute_match(/UnknownFormat|406/, @response.body)
+
+    photo.reload
+    assert photo.image.present?, "expected CarrierWave mount after Turbo multipart PUT"
+  end
+
+  # 7.5.2 regression: after cancel / update on a field, the swapped
+  # `<turbo-frame id="…">` must contain a Turbo link
+  # (`data-turbo="true" data-turbo-frame="_self"`) so the user can re-open
+  # the editor. 7.5.1 emitted `data-remote="true"`, which jquery_ujs
+  # intercepts as a JS request the controller does not register, so the
+  # second click silently fails (no swap, no edit form).
+  test "nested Photo image field show after update has Turbo (not data-remote) link" do
+    photo = @apartment.photos.first!
+    frame_id = "apartment_#{@apartment.id}_photo_#{photo.id}_image"
+    turbo_headers = { "Turbo-Frame" => frame_id, "Accept" => "text/html" }
+
+    seed_dir = Rails.root.join("db", "seed_images")
+    jpgs = Dir.glob(seed_dir.join("*.{jpg,jpeg}"), File::FNM_CASEFOLD).sort
+    replacement = jpgs.find { |abs| File.basename(abs) != photo.name } || jpgs.last
+    uploaded = Rack::Test::UploadedFile.new(replacement, "image/jpeg")
+
+    put photo_path(
+      photo,
+      attribute: "image",
+      form_element: "image_field",
+      update: frame_id
+    ),
+        params: { image: uploaded },
+        headers: turbo_headers
+    assert_response :success
+    refute_match(
+      /data-remote="true"/,
+      @response.body,
+      "field_show after Turbo update must use Turbo data attributes; " \
+      "data-remote=\"true\" hits jquery_ujs (no JS responder) and the " \
+      "second click silently fails."
+    )
+    assert_match(
+      /data-turbo="true"/,
+      @response.body,
+      "expected Turbo data attribute on the inline-edit link inside the swapped field frame"
+    )
+  end
+
+  # Same regression on the cancel path (no DB write): clicking the field
+  # cancel returns the read-only field; the link inside must be a Turbo link
+  # so the user can re-open the editor.
+  test "nested Photo image field show after cancel has Turbo (not data-remote) link" do
+    photo = @apartment.photos.first!
+    frame_id = "apartment_#{@apartment.id}_photo_#{photo.id}_image"
+    turbo_headers = { "Turbo-Frame" => frame_id, "Accept" => "text/html" }
+
+    get photo_path(
+      photo,
+      attribute: "image",
+      form_element: "image_field",
+      update: frame_id
+    ), headers: turbo_headers
+    assert_response :success
+    refute_match(/data-remote="true"/, @response.body,
+      "cancel-side field_show must not regress to UJS data-remote=\"true\"")
+    assert_match(/data-turbo="true"/, @response.body)
+  end
+
+  test "nested Photo new cancel and create via Turbo inside associated list frame" do
+    frame = "apartment_#{@apartment.id}_photos"
+    headers = { "Turbo-Frame" => frame, "Accept" => "text/html" }
+
+    get new_photo_path(update: frame, parent_class: "Apartment", parent_id: @apartment.id),
+        headers: headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{frame}">)
+    assert_includes @response.body, "stylesheet", "new form must use inline_forms layout (styled)"
+    assert_includes @response.body, %(enctype="multipart/form-data")
+    assert_includes @response.body, 'class="edit_form"'
+    assert_includes @response.body, 'name="name"'
+
+    get photos_path(
+      parent_class: "Apartment",
+      parent_id: @apartment.id,
+      update: frame,
+      ul_needed: true
+    ), headers: headers
+    assert_response :success
+    assert_match %r{<turbo-frame id="#{frame}"}, @response.body
+    assert_match %r{<turbo-frame id="#{@update_span}"}, @response.body
+
+    seed = Rails.root.join("db/seed_images/dsc00099.jpg")
+    uploaded = Rack::Test::UploadedFile.new(seed, "image/jpeg")
+
+    assert_difference("Photo.count", 1) do
+      post photos_path(
+        update: frame,
+        parent_class: "Apartment",
+        parent_id: @apartment.id
+      ),
+           params: {
+             name: "curl_new_photo.jpg",
+             caption: "from turbo test",
+             image: uploaded
+           },
+           headers: headers
+    end
+    assert_response :success
+    assert_match %r{<turbo-frame id="#{frame}"}, @response.body
+    assert_match %r{<turbo-frame id="#{@update_span}"}, @response.body
+    assert_includes @response.body, "curl_new_photo.jpg"
   end
 end

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_row_turbo_test.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# Stock `/apartments` index: each row is `<turbo-frame id="apartment_<id>">`;
+# opening/closing the inline panel uses Turbo GET `show` + `close` (HTML), not UJS.
+class ExampleAppApartmentRowTurboTest < ExampleAppIntegrationTestCase
+  setup do
+    @apartment = Apartment.first || Apartment.create!(name: "Row Turbo Apt", title: "T")
+    @row_frame = "apartment_#{@apartment.id}"
+    @row_headers = { "Turbo-Frame" => @row_frame, "Accept" => "text/html" }
+  end
+
+  test "apartments index wraps each row in a turbo-frame" do
+    get apartments_path
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@row_frame}">),
+      "expected top-level list row inside turbo-frame"
+  end
+
+  test "row presentation link uses turbo navigation not UJS remote" do
+    get apartments_path
+    assert_response :success
+    assert_select "turbo-frame##{@row_frame} div.small-11.column > a", count: 1 do |elements|
+      el = elements.first
+      assert_equal "true", el["data-turbo"]
+      assert_equal @row_frame, el["data-turbo-frame"]
+      assert_nil el["data-remote"]
+    end
+  end
+
+  test "row open show returns full panel inside matching turbo-frame" do
+    get apartment_path(@apartment, update: @row_frame), headers: @row_headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@row_frame}">)
+    assert_includes @response.body, "object_presentation",
+      "expected expanded _show panel"
+  end
+
+  test "row close returns collapsed row inside matching turbo-frame" do
+    get apartment_path(@apartment, update: @row_frame, close: true), headers: @row_headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@row_frame}">)
+    refute_includes @response.body, "object_presentation",
+      "expected _close row, not full panel"
+  end
+
+  test "row close responds to html without Turbo-Frame header" do
+    get apartment_path(
+      @apartment,
+      update: @row_frame,
+      close: true
+    ), headers: { "Accept" => "text/html, application/xhtml+xml" }
+
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{@row_frame}">)
+  end
+
+  test "row toolbar trash and destroy links use Turbo not UJS remote" do
+    get apartments_path
+    assert_response :success
+    assert_select "turbo-frame##{@row_frame} a[data-turbo='true'][data-turbo-frame='#{@row_frame}']", minimum: 1
+    refute_select "turbo-frame##{@row_frame} a[data-remote='true']"
+  end
+
+  test "destroy via Turbo DELETE returns undo inside matching turbo-frame" do
+    doomed = Apartment.create!(name: "Turbo Destroy Me", title: "X")
+    frame = "apartment_#{doomed.id}"
+    headers = { "Turbo-Frame" => frame, "Accept" => "text/html" }
+
+    delete apartment_path(doomed, update: frame), headers: headers
+    assert_response :success
+    assert_includes @response.body, %(<turbo-frame id="#{frame}">)
+    assert_includes @response.body, "undo"
+    assert_not Apartment.exists?(doomed.id)
+  end
+
+  test "revert via Turbo POST restores row as collapsed turbo-frame" do
+    doomed = Apartment.create!(name: "Turbo Revert Me", title: "Y")
+    apt_id = doomed.id
+    frame = "apartment_#{apt_id}"
+    headers = { "Turbo-Frame" => frame, "Accept" => "text/html" }
+
+    delete apartment_path(doomed, update: frame), headers: headers
+    assert_response :success
+
+    destroy_version = PaperTrail::Version.where(item_type: "Apartment", item_id: apt_id).order(:id).last
+    post revert_apartment_path(destroy_version.id, update: frame), headers: headers
+    assert_response :success
+    assert Apartment.where(name: "Turbo Revert Me").exists?
+    assert_includes @response.body, %(<turbo-frame id="#{frame}">)
+    refute_includes @response.body, "object_presentation"
+  end
+end

data/lib/installer_templates/example_app_tests/test/integration/example_app_apartment_top_level_new_test.rb

@@ -0,0 +1,100 @@
+# frozen_string_literal: true
+
+require_relative "../example_app/example_integration_test_case"
+
+# 7.5.2: top-level Apartment +new+ / +cancel+ / +create+ keep the legacy UJS
+# (+remote: true+) contract. 7.5.1 emitted +data-turbo-frame="apartments_list"+
+# on the +"+ new"+ link, but the index page wraps the list in a plain
+# +<div id="apartments_list">+ (not a +<turbo-frame>+) -- so:
+#
+# * +cancel+ / +create+ targeted a frame the page did not have, and Turbo
+#   logged "Content missing" and dropped the response;
+# * the +"+ new"+ click itself either fell back to a full-page navigation or
+#   landed in that broken state.
+#
+# Wrapping the top-level list in a real +<turbo-frame>+ regresses layout
+# (the frame collapses inside +position: absolute+ +#outer_container+), so
+# the fix keeps top-level behind UJS: +link_to_new_record+ omits Turbo data
+# attributes when no +parent_class+ is provided, and +new.js.erb+ /
+# +list.js.erb+ swap +#apartments_list+ contents in place.
+class ExampleAppApartmentTopLevelNewTest < ExampleAppIntegrationTestCase
+  setup do
+    @frame = "apartments_list"
+  end
+
+  test "top-level apartments index keeps the legacy <div> wrapper (no <turbo-frame> for the list root)" do
+    get apartments_path
+    assert_response :success
+    assert_match(
+      %r{<div[^>]+class="list_container"[^>]+id="#{Regexp.escape(@frame)}"},
+      @response.body,
+      "top-level list must stay a <div id=\"apartments_list\"> for UJS swaps; " \
+      "wrapping in a <turbo-frame> at this position breaks layout"
+    )
+    refute_match(
+      %r{<turbo-frame\s+id="#{Regexp.escape(@frame)}"},
+      @response.body,
+      "top-level list root should NOT be a <turbo-frame> -- doing so regresses " \
+      "layout (frame collapses under fixed top bars) and orphans cancel/create"
+    )
+  end
+
+  test "top-level + new link uses UJS (data-remote), not Turbo" do
+    get apartments_path
+    assert_response :success
+    assert_match(
+      %r{<a [^>]*class="button new_button"[^>]*data-remote="true"[^>]*href="/apartments/new\?update=apartments_list"},
+      @response.body,
+      "top-level + must POST via UJS (no <turbo-frame> on the page to target); " \
+      "data-turbo* on this link causes 'Content missing' on cancel/create"
+    )
+    refute_match(
+      %r{<a [^>]*class="button new_button"[^>]*data-turbo-frame="#{Regexp.escape(@frame)}"},
+      @response.body,
+      "top-level + must NOT carry data-turbo-frame=apartments_list (no matching frame)"
+    )
+  end
+
+  test "top-level new returns JS that swaps #apartments_list with the form (UJS)" do
+    get new_apartment_path(update: @frame), xhr: true
+    assert_response :success
+    assert_includes @response.content_type, "javascript",
+      "UJS XHR must hit format.js"
+    assert_match(
+      %r{\$\('#apartments_list'\)\.html\(},
+      @response.body,
+      "UJS new.js.erb must swap #apartments_list with the rendered form"
+    )
+    assert_includes @response.body, 'name=\"name\"'
+    assert_includes @response.body, 'class=\"edit_form\"'
+  end
+
+  test "top-level cancel returns JS that swaps #apartments_list back to the list (UJS)" do
+    get apartments_path(update: @frame, ul_needed: true), xhr: true
+    assert_response :success
+    assert_includes @response.content_type, "javascript",
+      "UJS XHR must hit format.js"
+    assert_match(
+      %r{\$\('#apartments_list'\)\.html\(},
+      @response.body,
+      "UJS list.js.erb must swap #apartments_list back to the list"
+    )
+  end
+
+  test "top-level create via UJS persists and returns the list swap" do
+    name = "TopLevelNewApt-#{SecureRandom.hex(4)}"
+    assert_difference("Apartment.count", 1) do
+      post apartments_path(update: @frame),
+        params: { name: name, title: "Top level new test" },
+        xhr: true
+    end
+    assert_response :success
+    assert_includes @response.content_type, "javascript"
+    assert_match(
+      %r{\$\('#apartments_list'\)\.html\(},
+      @response.body
+    )
+    assert_includes @response.body, name,
+      "expected the newly-created Apartment to appear in the swapped list"
+  end
+end