ibm_db 5.6.1 → 5.7.0

data/test/cases/connection_adapters/connection_handler_test.rb

@@ -6,17 +6,27 @@ require "models/person"
 module ActiveRecord
   module ConnectionAdapters
     class ConnectionHandlerTest < ActiveRecord::TestCase
-      self.use_transactional_tests = false
-
       fixtures :people
 
       def setup
         @handler = ConnectionHandler.new
-        @owner_name = "ActiveRecord::Base"
+        @connection_name = "ActiveRecord::Base"
         db_config = ActiveRecord::Base.configurations.configs_for(env_name: "arunit", name: "primary")
         @pool = @handler.establish_connection(db_config)
       end
 
+      def teardown
+        clean_up_connection_handler
+      end
+
+      def skip_unless_sqlite3_gem_available
+        @prev_configs ||= ActiveRecord::Base.configurations
+
+        return if Gem::Specification.find_all_by_name("sqlite3", ">= 2.1").any?
+
+        skip "requires sqlite3 gem (>= 2.1)"
+      end
+
       def test_default_env_fall_back_to_default_env_when_rails_env_or_rack_env_is_empty_string
         original_rails_env = ENV["RAILS_ENV"]
         original_rack_env  = ENV["RACK_ENV"]
@@ -29,6 +39,8 @@ module ActiveRecord
       end
 
       def test_establish_connection_using_3_levels_config
+        skip_unless_sqlite3_gem_available
+
         previous_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "default_env"
 
         config = {
@@ -61,41 +73,71 @@ module ActiveRecord
         ENV["RAILS_ENV"] = previous_env
       end
 
+      def test_validates_db_configuration_and_raises_on_invalid_adapter
+        config = {
+          "development" => { "adapter" => "ridiculous" },
+        }
+
+        @prev_configs, ActiveRecord::Base.configurations = ActiveRecord::Base.configurations, config
+
+        assert_raises(ActiveRecord::AdapterNotFound) do
+          ActiveRecord::Base.establish_connection(:development)
+        end
+      ensure
+        ActiveRecord::Base.configurations = @prev_configs
+      end
+
       unless in_memory_db?
         def test_not_setting_writing_role_while_using_another_named_role_raises
           connection_handler = ActiveRecord::Base.connection_handler
           ActiveRecord::Base.connection_handler = ActiveRecord::ConnectionAdapters::ConnectionHandler.new
 
-          ActiveRecord::Base.connects_to(shards: { default: { all: :arunit }, one: { all: :arunit } })
+          ActiveRecord::Base.connects_to(shards: { default: { also_writing: :arunit }, one: { also_writing: :arunit } })
 
           assert_raises(ArgumentError) { setup_shared_connection_pool }
         ensure
           ActiveRecord::Base.connection_handler = connection_handler
-          ActiveRecord::Base.establish_connection :arunit
+        end
+
+        def test_fixtures_dont_raise_if_theres_no_writing_pool_config
+          connection_handler = ActiveRecord::Base.connection_handler
+          ActiveRecord::Base.connection_handler = ActiveRecord::ConnectionAdapters::ConnectionHandler.new
+
+          assert_nothing_raised do
+            ActiveRecord::Base.connects_to(database: { reading: :arunit, writing: :arunit })
+          end
+
+          rw_conn = ActiveRecord::Base.connection_handler.retrieve_connection("ActiveRecord::Base", role: :writing)
+          ro_conn = ActiveRecord::Base.connection_handler.retrieve_connection("ActiveRecord::Base", role: :reading)
+
+          assert_equal rw_conn, ro_conn
+        ensure
+          ActiveRecord::Base.connection_handler = connection_handler
         end
 
         def test_setting_writing_role_while_using_another_named_role_does_not_raise
           connection_handler = ActiveRecord::Base.connection_handler
           ActiveRecord::Base.connection_handler = ActiveRecord::ConnectionAdapters::ConnectionHandler.new
-          old_role, ActiveRecord::Base.writing_role = ActiveRecord::Base.writing_role, :all
+          old_role, ActiveRecord.writing_role = ActiveRecord.writing_role, :also_writing
 
-          ActiveRecord::Base.connects_to(shards: { default: { all: :arunit }, one: { all: :arunit } })
+          ActiveRecord::Base.connects_to(shards: { default: { also_writing: :arunit }, one: { also_writing: :arunit } })
 
           assert_nothing_raised { setup_shared_connection_pool }
         ensure
-          ActiveRecord::Base.writing_role = old_role
+          ActiveRecord.writing_role = old_role
           ActiveRecord::Base.connection_handler = connection_handler
-          ActiveRecord::Base.establish_connection :arunit
         end
 
         def test_establish_connection_with_primary_works_without_deprecation
           old_config = ActiveRecord::Base.configurations
+          skip_unless_sqlite3_gem_available
+
           config = { "primary" => { "adapter" => "sqlite3", "database" => "test/db/primary.sqlite3" } }
           ActiveRecord::Base.configurations = config
 
           @handler.establish_connection(:primary)
 
-          assert_not_deprecated do
+          assert_not_deprecated(ActiveRecord.deprecator) do
             @handler.retrieve_connection("primary")
             @handler.remove_connection_pool("primary")
           end
@@ -103,21 +145,9 @@ module ActiveRecord
           ActiveRecord::Base.configurations = old_config
         end
 
-        def test_retrieve_connection_shows_primary_deprecation_warning_when_established_on_active_record_base
-          old_config = ActiveRecord::Base.configurations
-          config = { "primary" => { "adapter" => "sqlite3", "database" => "test/db/primary.sqlite3" } }
-          ActiveRecord::Base.configurations = config
-
-          ActiveRecord::Base.establish_connection(:primary)
-
-          assert_deprecated { @handler.retrieve_connection("primary") }
-          assert_deprecated { @handler.remove_connection_pool("primary") }
-        ensure
-          ActiveRecord::Base.configurations = old_config
-          ActiveRecord::Base.establish_connection(:arunit)
-        end
-
         def test_establish_connection_using_3_level_config_defaults_to_default_env_primary_db
+          skip_unless_sqlite3_gem_available
+
           previous_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "default_env"
 
           config = {
@@ -134,7 +164,7 @@ module ActiveRecord
 
           ActiveRecord::Base.establish_connection
 
-          assert_match "test/db/primary.sqlite3", ActiveRecord::Base.connection.pool.db_config.database
+          assert_match "test/db/primary.sqlite3", ActiveRecord::Base.lease_connection.pool.db_config.database
         ensure
           ActiveRecord::Base.configurations = @prev_configs
           ENV["RAILS_ENV"] = previous_env
@@ -142,6 +172,8 @@ module ActiveRecord
         end
 
         def test_establish_connection_using_2_level_config_defaults_to_default_env_primary_db
+          skip_unless_sqlite3_gem_available
+
           previous_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "default_env"
 
           config = {
@@ -156,39 +188,32 @@ module ActiveRecord
 
           ActiveRecord::Base.establish_connection
 
-          assert_match "test/db/primary.sqlite3", ActiveRecord::Base.connection.pool.db_config.database
+          assert_match "test/db/primary.sqlite3", ActiveRecord::Base.lease_connection.pool.db_config.database
         ensure
           ActiveRecord::Base.configurations = @prev_configs
           ENV["RAILS_ENV"] = previous_env
           ActiveRecord::Base.establish_connection(:arunit)
         end
-
-        def test_remove_connection_is_deprecated
-          expected = @handler.retrieve_connection_pool(@owner_name).db_config.configuration_hash
-
-          config_hash = assert_deprecated do
-            @handler.remove_connection(@owner_name)
-          end
-
-          assert_equal expected, config_hash
-        ensure
-          ActiveRecord::Base.establish_connection(:arunit)
-        end
       end
 
       def test_establish_connection_using_two_level_configurations
+        skip_unless_sqlite3_gem_available
+
         config = { "development" => { "adapter" => "sqlite3", "database" => "test/db/primary.sqlite3" } }
         @prev_configs, ActiveRecord::Base.configurations = ActiveRecord::Base.configurations, config
 
         @handler.establish_connection(:development)
 
         assert_not_nil pool = @handler.retrieve_connection_pool("development")
+        assert_not_predicate pool.lease_connection, :preventing_writes?
         assert_equal "test/db/primary.sqlite3", pool.db_config.database
       ensure
         ActiveRecord::Base.configurations = @prev_configs
       end
 
       def test_establish_connection_using_top_level_key_in_two_level_config
+        skip_unless_sqlite3_gem_available
+
         config = {
           "development" => { "adapter" => "sqlite3", "database" => "test/db/primary.sqlite3" },
           "development_readonly" => { "adapter" => "sqlite3", "database" => "test/db/readonly.sqlite3" }
@@ -198,6 +223,25 @@ module ActiveRecord
         @handler.establish_connection(:development_readonly)
 
         assert_not_nil pool = @handler.retrieve_connection_pool("development_readonly")
+        assert_not_predicate pool.lease_connection, :preventing_writes?
+        assert_equal "test/db/readonly.sqlite3", pool.db_config.database
+      ensure
+        ActiveRecord::Base.configurations = @prev_configs
+      end
+
+      def test_establish_connection_with_string_owner_name
+        skip_unless_sqlite3_gem_available
+
+        config = {
+          "development" => { "adapter" => "sqlite3", "database" => "test/db/primary.sqlite3" },
+          "development_readonly" => { "adapter" => "sqlite3", "database" => "test/db/readonly.sqlite3" }
+        }
+        @prev_configs, ActiveRecord::Base.configurations = ActiveRecord::Base.configurations, config
+
+        @handler.establish_connection(:development_readonly, owner_name: "custom_connection")
+
+        assert_not_nil pool = @handler.retrieve_connection_pool("custom_connection")
+        assert_not_predicate pool.lease_connection, :preventing_writes?
         assert_equal "test/db/readonly.sqlite3", pool.db_config.database
       ensure
         ActiveRecord::Base.configurations = @prev_configs
@@ -209,13 +253,13 @@ module ActiveRecord
           development: {
             primary: {
               adapter: "sqlite3",
-              database: "test/db/development.sqlite3",
+              database: "test/storage/development.sqlite3",
             },
           },
           test: {
             primary: {
               adapter: "sqlite3",
-              database: "test/db/test.sqlite3",
+              database: "test/storage/test.sqlite3",
             },
           },
         }
@@ -234,19 +278,19 @@ module ActiveRecord
       end
 
       def test_retrieve_connection
-        assert @handler.retrieve_connection(@owner_name)
+        assert @handler.retrieve_connection(@connection_name)
       end
 
       def test_active_connections?
-        assert_not_predicate @handler, :active_connections?
-        assert @handler.retrieve_connection(@owner_name)
-        assert_predicate @handler, :active_connections?
-        @handler.clear_active_connections!
-        assert_not_predicate @handler, :active_connections?
+        assert_not @handler.active_connections?(:all)
+        assert @handler.retrieve_connection(@connection_name)
+        assert @handler.active_connections?(:all)
+        @handler.clear_active_connections!(:all)
+        assert_not @handler.active_connections?(:all)
       end
 
       def test_retrieve_connection_pool
-        assert_not_nil @handler.retrieve_connection_pool(@owner_name)
+        assert_not_nil @handler.retrieve_connection_pool(@connection_name)
       end
 
       def test_retrieve_connection_pool_with_invalid_id
@@ -260,15 +304,15 @@ module ActiveRecord
       def test_a_class_using_custom_pool_and_switching_back_to_primary
         klass2 = Class.new(Base) { def self.name; "klass2"; end }
 
-        assert_same klass2.connection, ActiveRecord::Base.connection
+        assert_same klass2.lease_connection, ActiveRecord::Base.lease_connection
 
         pool = klass2.establish_connection(ActiveRecord::Base.connection_pool.db_config.configuration_hash)
-        assert_same klass2.connection, pool.connection
-        assert_not_same klass2.connection, ActiveRecord::Base.connection
+        assert_same klass2.lease_connection, pool.lease_connection
+        assert_not_same klass2.lease_connection, ActiveRecord::Base.lease_connection
 
         klass2.remove_connection
 
-        assert_same klass2.connection, ActiveRecord::Base.connection
+        assert_same klass2.lease_connection, ActiveRecord::Base.lease_connection
       end
 
       class ApplicationRecord < ActiveRecord::Base
@@ -297,6 +341,7 @@ module ActiveRecord
         ActiveRecord::Base.connection_specification_name = "readonly"
         assert_equal "readonly", klassC.connection_specification_name
       ensure
+        ApplicationRecord.remove_connection
         Object.send :remove_const, :ApplicationRecord
         ActiveRecord::Base.connection_specification_name = "ActiveRecord::Base"
       end
@@ -304,18 +349,18 @@ module ActiveRecord
       def test_remove_connection_should_not_remove_parent
         klass2 = Class.new(Base) { def self.name; "klass2"; end }
         klass2.remove_connection
-        assert_not_nil ActiveRecord::Base.connection
-        assert_same klass2.connection, ActiveRecord::Base.connection
+        assert_not_nil ActiveRecord::Base.lease_connection
+        assert_same klass2.lease_connection, ActiveRecord::Base.lease_connection
       end
 
       def test_default_handlers_are_writing_and_reading
-        assert_equal :writing, ActiveRecord::Base.writing_role
-        assert_equal :reading, ActiveRecord::Base.reading_role
+        assert_equal :writing, ActiveRecord.writing_role
+        assert_equal :reading, ActiveRecord.reading_role
       end
 
       if Process.respond_to?(:fork)
         def test_connection_pool_per_pid
-          object_id = ActiveRecord::Base.connection.object_id
+          object_id = ActiveRecord::Base.lease_connection.object_id
 
           rd, wr = IO.pipe
           rd.binmode
@@ -323,7 +368,7 @@ module ActiveRecord
 
           pid = fork {
             rd.close
-            wr.write Marshal.dump ActiveRecord::Base.connection.object_id
+            wr.write Marshal.dump ActiveRecord::Base.lease_connection.object_id
             wr.close
             exit!
           }
@@ -336,8 +381,8 @@ module ActiveRecord
         end
 
         def test_forked_child_doesnt_mangle_parent_connection
-          object_id = ActiveRecord::Base.connection.object_id
-          assert_predicate ActiveRecord::Base.connection, :active?
+          object_id = ActiveRecord::Base.lease_connection.object_id
+          assert_predicate ActiveRecord::Base.lease_connection, :active?
 
           rd, wr = IO.pipe
           rd.binmode
@@ -345,9 +390,9 @@ module ActiveRecord
 
           pid = fork {
             rd.close
-            if ActiveRecord::Base.connection.active?
-              wr.write Marshal.dump ActiveRecord::Base.connection.object_id
-            end
+            wr.write Marshal.dump [
+              ActiveRecord::Base.lease_connection.object_id,
+            ]
             wr.close
 
             exit # allow finalizers to run
@@ -356,31 +401,32 @@ module ActiveRecord
           wr.close
 
           Process.waitpid pid
-          assert_not_equal object_id, Marshal.load(rd.read)
+          child_id = Marshal.load(rd.read)
+          assert_not_equal object_id, child_id
           rd.close
 
-          assert_equal 3, ActiveRecord::Base.connection.select_value("SELECT COUNT(*) FROM people")
+          assert_equal 3, ActiveRecord::Base.lease_connection.select_value("SELECT COUNT(*) FROM people")
         end
 
         unless in_memory_db?
           def test_forked_child_recovers_from_disconnected_parent
-            object_id = ActiveRecord::Base.connection.object_id
-            assert_predicate ActiveRecord::Base.connection, :active?
+            object_id = ActiveRecord::Base.lease_connection.object_id
+            assert_predicate ActiveRecord::Base.lease_connection, :active?
 
             rd, wr = IO.pipe
             rd.binmode
             wr.binmode
 
             outer_pid = fork {
-              ActiveRecord::Base.connection.disconnect!
+              ActiveRecord::Base.lease_connection.disconnect!
 
               pid = fork {
                 rd.close
-                if ActiveRecord::Base.connection.active?
-                  pair = [ActiveRecord::Base.connection.object_id,
-                          ActiveRecord::Base.connection.select_value("SELECT COUNT(*) FROM people")]
-                  wr.write Marshal.dump pair
-                end
+                wr.write Marshal.dump [
+                  !!ActiveRecord::Base.lease_connection.active?,
+                  ActiveRecord::Base.lease_connection.object_id,
+                  ActiveRecord::Base.lease_connection.select_value("SELECT COUNT(*) FROM people"),
+                ]
                 wr.close
 
                 exit # allow finalizers to run
@@ -392,20 +438,20 @@ module ActiveRecord
             wr.close
 
             Process.waitpid outer_pid
-            child_id, child_count = Marshal.load(rd.read)
+            active, child_id, child_count = Marshal.load(rd.read)
 
+            assert_equal false, active
             assert_not_equal object_id, child_id
             rd.close
 
             assert_equal 3, child_count
 
             # Outer connection is unaffected
-            assert_equal 6, ActiveRecord::Base.connection.select_value("SELECT 2 * COUNT(*) FROM people")
+            assert_equal 6, ActiveRecord::Base.lease_connection.select_value("SELECT 2 * COUNT(*) FROM people")
           end
         end
 
         def test_retrieve_connection_pool_copies_schema_cache_from_ancestor_pool
-          @pool.schema_cache = @pool.connection.schema_cache
           @pool.schema_cache.add("posts")
 
           rd, wr = IO.pipe
@@ -414,7 +460,7 @@ module ActiveRecord
 
           pid = fork {
             rd.close
-            pool = @handler.retrieve_connection_pool(@owner_name)
+            pool = @handler.retrieve_connection_pool(@connection_name)
             wr.write Marshal.dump pool.schema_cache.size
             wr.close
             exit!
@@ -427,38 +473,38 @@ module ActiveRecord
           rd.close
         end
 
-        def test_pool_from_any_process_for_uses_most_recent_spec
-          skip unless current_adapter?(:SQLite3Adapter)
+        if current_adapter?(:SQLite3Adapter)
+          def test_pool_from_any_process_for_uses_most_recent_spec
+            file = Tempfile.new "lol.sqlite3"
 
-          file = Tempfile.new "lol.sqlite3"
+            rd, wr = IO.pipe
+            rd.binmode
+            wr.binmode
 
-          rd, wr = IO.pipe
-          rd.binmode
-          wr.binmode
+            pid = fork do
+              config_hash = ActiveRecord::Base.configurations.configs_for(env_name: "arunit", name: "primary").configuration_hash.merge(database: file.path)
+              ActiveRecord::Base.establish_connection(config_hash)
 
-          pid = fork do
-            config_hash = ActiveRecord::Base.configurations.configs_for(env_name: "arunit", name: "primary").configuration_hash.merge(database: file.path)
-            ActiveRecord::Base.establish_connection(config_hash)
+              pid2 = fork do
+                wr.write ActiveRecord::Base.connection_db_config.database
+                wr.close
+              end
 
-            pid2 = fork do
-              wr.write ActiveRecord::Base.connection_db_config.database
-              wr.close
+              Process.waitpid pid2
             end
 
-            Process.waitpid pid2
-          end
+            Process.waitpid pid
 
-          Process.waitpid pid
-
-          wr.close
+            wr.close
 
-          assert_equal file.path, rd.read
+            assert_equal file.path, rd.read
 
-          rd.close
-        ensure
-          if file
-            file.close
-            file.unlink
+            rd.close
+          ensure
+            if file
+              file.close
+              file.unlink
+            end
           end
         end
       end