ibm_db 5.6.1 → 5.7.0

data/test/cases/transaction_instrumentation_test.rb

@@ -0,0 +1,453 @@
+# frozen_string_literal: true
+
+require "cases/helper"
+require "models/topic"
+
+class TransactionInstrumentationTest < ActiveRecord::TestCase
+  self.use_transactional_tests = false
+  fixtures :topics
+
+  def test_start_transaction_is_triggered_when_the_transaction_is_materialized
+    transactions = []
+    subscriber = ActiveSupport::Notifications.subscribe("start_transaction.active_record") do |event|
+      assert event.payload[:connection]
+      transactions << event.payload[:transaction]
+    end
+
+    Topic.transaction do |transaction|
+      assert_empty transactions # A transaction call, per se, does not trigger the event.
+      topics(:first).touch
+      assert_equal [transaction], transactions
+    end
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber)
+  end
+
+  def test_start_transaction_is_not_triggered_for_ordinary_nested_calls
+    transactions = []
+    subscriber = ActiveSupport::Notifications.subscribe("start_transaction.active_record") do |event|
+      assert event.payload[:connection]
+      transactions << event.payload[:transaction]
+    end
+
+    Topic.transaction do |t1|
+      topics(:first).touch
+      assert_equal [t1], transactions
+
+      Topic.transaction do |_t2|
+        topics(:first).touch
+        assert_equal [t1], transactions
+      end
+    end
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber)
+  end
+
+  def test_start_transaction_is_triggered_for_requires_new
+    transactions = []
+    subscriber = ActiveSupport::Notifications.subscribe("start_transaction.active_record") do |event|
+      assert event.payload[:connection]
+      transactions << event.payload[:transaction]
+    end
+
+    Topic.transaction do |t1|
+      topics(:first).touch
+      assert_equal [t1], transactions
+
+      Topic.transaction(requires_new: true) do |t2|
+        topics(:first).touch
+        assert_equal [t1, t2], transactions
+      end
+    end
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber)
+  end
+
+  def test_transaction_instrumentation_on_commit
+    topic = topics(:fifth)
+
+    notified = false
+    expected_transaction = nil
+
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      assert event.payload[:connection]
+      assert_same expected_transaction, event.payload[:transaction]
+      assert_equal :commit, event.payload[:outcome]
+      notified = true
+    end
+
+    ActiveRecord::Base.transaction do |transaction|
+      expected_transaction = transaction
+      topic.update(title: "Ruby on Rails")
+    end
+
+    assert notified
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_on_rollback
+    topic = topics(:fifth)
+
+    notified = false
+    expected_transaction = nil
+
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      assert event.payload[:connection]
+      assert_same expected_transaction, event.payload[:transaction]
+      assert_equal :rollback, event.payload[:outcome]
+      notified = true
+    end
+
+    ActiveRecord::Base.transaction do |transaction|
+      expected_transaction = transaction
+      topic.update(title: "Ruby on Rails")
+      raise ActiveRecord::Rollback
+    end
+
+    assert notified
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_with_savepoints
+    topic = topics(:fifth)
+
+    events = []
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      events << event
+    end
+
+    real_transaction = savepoint_transaction = nil
+    ActiveRecord::Base.transaction do |transaction|
+      real_transaction = transaction
+      topic.update(title: "Sinatra")
+      ActiveRecord::Base.transaction(requires_new: true) do |transaction|
+        savepoint_transaction = transaction
+        topic.update(title: "Ruby on Rails")
+      end
+    end
+
+    assert_equal 2, events.count
+    savepoint_event, real_event = events
+
+    assert_same savepoint_transaction, savepoint_event.payload[:transaction]
+    assert_equal :commit, savepoint_event.payload[:outcome]
+
+    assert_same real_transaction, real_event.payload[:transaction]
+    assert_equal :commit, real_event.payload[:outcome]
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_with_restart_parent_transaction_on_commit
+    topic = topics(:fifth)
+
+    events = []
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      events << event
+    end
+
+    ActiveRecord::Base.transaction do
+      ActiveRecord::Base.transaction(requires_new: true) do
+        topic.update(title: "Ruby on Rails")
+      end
+    end
+
+    assert_equal 1, events.count
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_with_restart_parent_transaction_on_rollback
+    topic = topics(:fifth)
+
+    events = []
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      events << event
+    end
+
+    ActiveRecord::Base.transaction do
+      ActiveRecord::Base.transaction(requires_new: true) do
+        topic.update(title: "Ruby on Rails")
+        raise ActiveRecord::Rollback
+      end
+      raise ActiveRecord::Rollback
+    end
+
+    assert_equal 2, events.count
+    restart, real = events
+    assert_equal :restart, restart.payload[:outcome]
+    assert_equal :rollback, real.payload[:outcome]
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_with_unmaterialized_restart_parent_transactions
+    events = []
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      events << event
+    end
+
+    ActiveRecord::Base.transaction do
+      ActiveRecord::Base.transaction(requires_new: true) do
+        raise ActiveRecord::Rollback
+      end
+    end
+
+    assert_equal 0, events.count
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_with_materialized_restart_parent_transactions
+    topic = topics(:fifth)
+    events = []
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      events << event
+    end
+
+    ActiveRecord::Base.transaction do
+      topic.update(title: "Sinatra")
+      ActiveRecord::Base.transaction(requires_new: true) do
+        raise ActiveRecord::Rollback
+      end
+    end
+
+    assert_equal 1, events.count
+    event = events.first
+    assert_equal :commit, event.payload[:outcome]
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_with_restart_savepoint_parent_transactions
+    topic = topics(:fifth)
+
+    events = []
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      events << event
+    end
+
+    ActiveRecord::Base.transaction do
+      topic.update(title: "Sinatry")
+      ActiveRecord::Base.transaction(requires_new: true) do
+        ActiveRecord::Base.transaction(requires_new: true) do
+          topic.update(title: "Ruby on Rails")
+          raise ActiveRecord::Rollback
+        end
+      end
+    end
+
+    assert_equal 3, events.count
+    restart, savepoint, real = events
+    assert_equal :restart, restart.payload[:outcome]
+    assert_equal :commit, savepoint.payload[:outcome]
+    assert_equal :commit, real.payload[:outcome]
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_with_restart_savepoint_parent_transactions_on_commit
+    topic = topics(:fifth)
+
+    events = []
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      events << event
+    end
+
+    ActiveRecord::Base.transaction do
+      topic.update(title: "Sinatra")
+      ActiveRecord::Base.transaction(requires_new: true) do
+      end
+    end
+
+    assert_equal 1, events.count
+    event = events.first
+    assert_equal :commit, event.payload[:outcome]
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_only_fires_if_materialized
+    notified = false
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      notified = true
+    end
+
+    ActiveRecord::Base.transaction do
+    end
+
+    assert_not notified
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_only_fires_on_rollback_if_materialized
+    notified = false
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      notified = true
+    end
+
+    ActiveRecord::Base.transaction do
+      raise ActiveRecord::Rollback
+    end
+
+    assert_not notified
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_reconnecting_after_materialized_transaction_starts_new_event
+    events = []
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      events << event
+    end
+    Topic.transaction do
+      Topic.lease_connection.materialize_transactions
+      Topic.lease_connection.reconnect!(restore_transactions: true)
+    end
+
+    assert_equal 2, events.count
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_fires_before_after_commit_callbacks
+    notified = false
+    after_commit_triggered = false
+
+    topic_model = Class.new(ActiveRecord::Base) do
+      self.table_name = "topics"
+
+      after_commit do
+        after_commit_triggered = true
+      end
+    end
+
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      assert_not after_commit_triggered, "Transaction notification fired after the after_commit callback"
+      notified = true
+    end
+
+    topic_model.create!
+
+    assert notified
+    assert after_commit_triggered
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_fires_before_after_rollback_callbacks
+    notified = false
+    after_rollback_triggered = false
+
+    topic_model = Class.new(ActiveRecord::Base) do
+      self.table_name = "topics"
+
+      after_rollback do
+        after_rollback_triggered = true
+      end
+    end
+
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      assert_not after_rollback_triggered, "Transaction notification fired after the after_rollback callback"
+      notified = true
+    end
+
+    topic_model.transaction do
+      topic_model.create!
+      raise ActiveRecord::Rollback
+    end
+
+    assert notified
+    assert after_rollback_triggered
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  def test_transaction_instrumentation_on_failed_commit
+    topic = topics(:fifth)
+
+    notified = false
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      notified = true
+    end
+
+    error = Class.new(StandardError)
+    assert_raises error do
+      ActiveRecord::Base.lease_connection.stub(:commit_db_transaction, -> (*) { raise error }) do
+        ActiveRecord::Base.transaction do
+          topic.update(title: "Ruby on Rails")
+        end
+      end
+    end
+
+    assert notified
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+
+  unless in_memory_db?
+    def test_transaction_instrumentation_on_failed_rollback
+      topic = topics(:fifth)
+
+      notified = false
+      subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+        assert_equal :incomplete, event.payload[:outcome]
+        notified = true
+      end
+
+      error = Class.new(StandardError)
+      assert_raises error do
+        ActiveRecord::Base.lease_connection.stub(:rollback_db_transaction, -> (*) { raise error }) do
+          ActiveRecord::Base.transaction do
+            topic.update(title: "Ruby on Rails")
+            raise ActiveRecord::Rollback
+          end
+        end
+      end
+
+      assert notified
+    ensure
+      ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+    end
+
+    def test_transaction_instrumentation_on_failed_rollback_when_unmaterialized
+      notified = false
+      subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+        notified = true
+      end
+
+      error = Class.new(StandardError)
+      assert_raises error do
+        # Stubbing this method simulates an error that occurs when the transaction is still unmaterilized.
+        Topic.lease_connection.transaction_manager.stub(:rollback_transaction, -> (*) { raise error }) do
+          Topic.transaction do
+            raise ActiveRecord::Rollback
+          end
+        end
+      end
+      assert_not notified
+    ensure
+      ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+    end
+  end
+
+  def test_transaction_instrumentation_on_broken_subscription
+    topic = topics(:fifth)
+
+    error = Class.new(StandardError)
+    subscriber = ActiveSupport::Notifications.subscribe("transaction.active_record") do |event|
+      raise error
+    end
+
+    assert_raises(error) do
+      ActiveRecord::Base.transaction do
+        topic.update(title: "Ruby on Rails")
+      end
+    end
+  ensure
+    ActiveSupport::Notifications.unsubscribe(subscriber) if subscriber
+  end
+end

data/test/cases/transaction_isolation_test.rb

@@ -2,8 +2,8 @@
 
 require "cases/helper"
 
-unless ActiveRecord::Base.connection.supports_transaction_isolation? && !current_adapter?(:SQLite3Adapter)
-  class TransactionIsolationUnsupportedTest < ActiveRecord::TestCase
+class TransactionIsolationUnsupportedTest < ActiveRecord::TestCase
+  unless ActiveRecord::Base.lease_connection.supports_transaction_isolation? && !current_adapter?(:SQLite3Adapter)
     self.use_transactional_tests = false
 
     class Tag < ActiveRecord::Base
@@ -11,12 +11,14 @@ unless ActiveRecord::Base.connection.supports_transaction_isolation? && !current
 
     test "setting the isolation level raises an error" do
       assert_raises(ActiveRecord::TransactionIsolationError) do
-        Tag.transaction(isolation: :serializable) { Tag.connection.materialize_transactions }
+        Tag.transaction(isolation: :serializable) { Tag.lease_connection.materialize_transactions }
       end
     end
   end
-else
-  class TransactionIsolationTest < ActiveRecord::TestCase
+end
+
+class TransactionIsolationTest < ActiveRecord::TestCase
+  if ActiveRecord::Base.lease_connection.supports_transaction_isolation? && !current_adapter?(:SQLite3Adapter)
     self.use_transactional_tests = false
 
     class Tag < ActiveRecord::Base
@@ -36,7 +38,7 @@ else
     # It is impossible to properly test read uncommitted. The SQL standard only
     # specifies what must not happen at a certain level, not what must happen. At
     # the read uncommitted level, there is nothing that must not happen.
-    if ActiveRecord::Base.connection.transaction_isolation_levels.include?(:read_uncommitted)
+    if ActiveRecord::Base.lease_connection.transaction_isolation_levels.include?(:read_uncommitted)
       test "read uncommitted" do
         Tag.transaction(isolation: :read_uncommitted) do
           assert_equal 0, Tag.count
@@ -61,7 +63,7 @@ else
     end
 
     # We are testing that a nonrepeatable read does not happen
-    if ActiveRecord::Base.connection.transaction_isolation_levels.include?(:repeatable_read)
+    if ActiveRecord::Base.lease_connection.transaction_isolation_levels.include?(:repeatable_read)
       test "repeatable read" do
         tag = Tag.create(name: "jon")
 
@@ -83,7 +85,9 @@ else
     # constraint.
     test "serializable" do
       Tag.transaction(isolation: :serializable) do
-        Tag.create
+        assert_nothing_raised do
+          Tag.create
+        end
       end
     end