hyrax 3.0.0.pre.rc1 → 3.0.0.pre.rc2

data/spec/features/actor_stack_spec.rb

@@ -1,112 +0,0 @@
-require 'rails_helper'
-
-# Integration tests for the full midddleware stack
-RSpec.describe Hyrax::DefaultMiddlewareStack, :clean_repo do
-  subject(:actor)  { stack.build(Hyrax::Actors::Terminator.new) }
-  let(:ability)    { ::Ability.new(user) }
-  let(:attributes) { {} }
-  let(:stack)      { described_class.build_stack }
-  let(:terminator) { Hyrax::Actors::Terminator.new }
-  let(:user)       { FactoryBot.create(:user) }
-  let(:work)       { FactoryBot.build(:work) }
-  let(:env)        { Hyrax::Actors::Environment.new(work, ability, attributes) }
-
-  let(:delayed_failure_actor) do
-    Class.new(Hyrax::Actors::AbstractActor) do
-      def create(env)
-        next_actor.create(env) && raise('ALWAYS RAISE')
-      end
-    end
-  end
-
-  describe '#create' do
-    it 'persists the work' do
-      expect { actor.create(env) }
-        .to change { work.persisted? }
-        .to true
-    end
-
-    context 'when adding to a work' do
-      let(:other_work) { FactoryBot.create(:work, user: user) }
-      let(:attributes) { { 'in_works_ids' => [other_work.id] } }
-
-      context 'when the user cannot edit the parent work' do
-        let(:other_work) { FactoryBot.create(:work, user: other_user) }
-        let(:other_user) { FactoryBot.create(:user) }
-
-        it 'fails' do
-          expect { actor.create(env) }
-            .not_to change { other_work.reload.members.to_a }
-            .from be_empty
-        end
-
-        it 'does not create the work' do
-          expect { actor.create(env) }
-            .not_to change { work.persisted? }
-            .from false
-        end
-      end
-
-      it 'adds the work to the parent' do
-        expect { actor.create(env) }
-          .to change { other_work.reload.members.to_a }
-          .from(be_empty)
-          .to contain_exactly(work)
-      end
-    end
-
-    context 'when adding permissions' do
-      before do
-        work.permissions.build(name: 'discover_user', type: 'person', access: 'discover')
-      end
-
-      it 'persists arbitrary ACL permissions' do
-        expect { actor.create(env) }
-          .to change { env.curation_concern.permissions }
-          .to include(grant_permission(:discover).to_user('discover_user'))
-      end
-    end
-
-    context 'when noids are disabled' do
-      let(:uuid_regex) { /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/ }
-
-      it 'uses the fedora assigned uuids' do
-        expect { actor.create(env) }
-          .to change { env.curation_concern.id }
-          .to uuid_regex
-      end
-    end
-
-    context 'when noids are enabled' do
-      before(:context) { Hyrax.config.enable_noids = true }
-      after(:context)  { Hyrax.config.enable_noids = false }
-
-      let(:noid_regex) { /^[0-9a-z]+$/ }
-
-      it 'assigns noids' do
-        expect { actor.create(env) }
-          .to change { env.curation_concern.id }
-          .to noid_regex
-      end
-    end
-
-    context 'when failing on the way back up the actor stack' do
-      before { stack.insert_before(Hyrax::Actors::ModelActor, delayed_failure_actor) }
-
-      before(:context) do
-        Hyrax.config.enable_noids = true
-        # we need to mint once to set the `rand` database column and
-        # make minter behavior predictable
-        ::Noid::Rails.config.minter_class.new.mint
-      end
-
-      after(:context) { Hyrax.config.enable_noids = false }
-
-      it 'leaves a valid minter state', :aggregate_failures do
-        expect { actor.create(env) }.to raise_error 'ALWAYS RAISE'
-
-        expect(GenericWork.new.assign_id).not_to eq work.id
-      end
-    end
-  end
-end

data/spec/features/admin_spec.rb

@@ -1,30 +0,0 @@
-RSpec.describe "The admin dashboard", :clean_repo do
-  let(:user) { create :admin }
-  let(:admin_set_1) do
-    create(:admin_set, title: ["First Admin Set"],
-                       description: ["A description"],
-                       edit_users: [user.user_key])
-  end
-  let(:admin_set_2) do
-    create(:admin_set, title: ["Second Admin Set"],
-                       description: ["A description"],
-                       edit_users: [user.user_key])
-  end
-
-  before do
-    create(:work_with_files, title: ["Work A"], admin_set_id: admin_set_1.id, edit_users: [user])
-    create(:work_with_one_file, title: ["Work B"], admin_set_id: admin_set_2.id, edit_users: [user])
-    create(:work_with_file_and_work, title: ["Work C"], admin_set_id: admin_set_2.id, edit_users: [user])
-  end
-
-  it 'renders the counts of Works and Files in all AdminSets' do
-    login_as(user, scope: :user)
-    visit '/dashboard'
-
-    expect(find('tr', text: 'First Admin Set').find('td:eq(2)')).to have_content(1)
-    expect(find('tr', text: 'First Admin Set').find('td:eq(3)')).to have_content(2)
-
-    expect(find('tr', text: 'Second Admin Set').find('td:eq(2)')).to have_content(2)
-    expect(find('tr', text: 'Second Admin Set').find('td:eq(3)')).to have_content(2)
-  end
-end

data/spec/features/batch_create_spec.rb

@@ -1,74 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe 'Batch creation of works', type: :feature do
-  let(:user) { create(:user) }
-  let!(:default_admin_set) do
-    build(:admin_set,
-          id: AdminSet::DEFAULT_ID,
-          title: ["Default Admin Set"],
-          description: ["A description"],
-          with_permission_template: { deposit_groups: [::Ability.registered_group_name] })
-  end
-
-  before { sign_in user }
-
-  it "renders the batch create form" do
-    visit hyrax.new_batch_upload_path
-    expect(page).to have_content "Add New Works by Batch"
-    within("li.active") do
-      expect(page).to have_content("Files")
-    end
-    expect(page).to have_content("Each file will be uploaded to a separate new work resulting in one work per uploaded file.")
-  end
-
-  context 'when the user is a proxy', :js, :workflow, :perform_enqueued do
-    let(:second_user) { create(:user) }
-
-    before do
-      allow(CharacterizeJob).to receive(:perform_later).and_return(true)
-      allow(CreateDerivativesJob).to receive(:perform_later).and_return(true)
-
-      ProxyDepositRights.create!(grantor: second_user, grantee: user)
-      sign_in user
-      click_link 'Works'
-      click_link "Create batch of works"
-      choose "payload_concern", option: "GenericWork"
-      click_button 'Create work'
-    end
-
-    it "allows on-behalf-of batch deposit", :js do
-      click_link "Files" # switch tab
-      expect(page).to have_content "Add files"
-      within('div#add-files') do
-        # two arbitrary files that aren't actually related, but should be
-        # small enough to require minimal processessing.
-        attach_file("files[]", "#{Hyrax::Engine.root}/spec/fixtures/small_file.txt", visible: false)
-        attach_file("files[]", "#{Hyrax::Engine.root}/spec/fixtures/png_fits.xml", visible: false)
-      end
-      click_link "Descriptions" # switch tab
-      fill_in('Creator', with: 'Doe, Jane')
-      select('In Copyright', from: 'Rights statement')
-      # With selenium and the chrome driver, focus remains on the
-      # select box. Click outside the box so the next line can't find
-      # its element
-      find('body').click
-
-      choose('batch_upload_item_visibility_open')
-      expect(page).to have_content('Please note, making something visible to the world (i.e. marking this as Public) may be viewed as publishing which could impact your ability to')
-      select(second_user.user_key, from: 'On behalf of')
-      check('agreement')
-      click_on('Save')
-
-      # Expect the proxy depositor (grantor) to be able to see both uploaded files.
-      expect(page).to have_content 'small_file.txt'
-      expect(page).to have_content 'png_fits.xml'
-
-      # Sign in with the grantee user, and expect to see the works deposited
-      # on their behalf.
-      sign_in second_user
-      click_link 'Works'
-      expect(page).to have_content 'small_file.txt'
-      expect(page).to have_content 'png_fits.xml'
-    end
-  end
-end

data/spec/features/batch_edit_spec.rb

@@ -1,119 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe 'batch', type: :feature, clean_repo: true, js: true do
-  let(:current_user) { create(:user) }
-  let(:admin_set) { create(:admin_set) }
-  let(:permission_template) { create(:permission_template, source_id: admin_set.id) }
-  let!(:workflow) { create(:workflow, allows_access_grant: true, active: true, permission_template_id: permission_template.id) }
-
-  let!(:work1)       { create(:public_work, admin_set_id: admin_set.id, user: current_user, members: [file_set]) }
-  let!(:work2)       { create(:public_work, admin_set_id: admin_set.id, user: current_user) }
-  let!(:file_set)    { create(:file_set) }
-
-  before do
-    RoleMapper.byname[current_user.user_key] << 'donor'
-    sign_in current_user
-    visit '/dashboard/my/works'
-    check 'check_all'
-  end
-
-  describe 'editing' do
-    it 'changes the value of each field for all selected works' do
-      click_on 'batch-edit'
-      fill_in_batch_edit_fields_and_verify!
-      work1.reload
-      work2.reload
-      batch_edit_fields.each do |field|
-        expect(work1.send(field)).to match_array("NEW #{field}")
-        expect(work2.send(field)).to match_array("NEW #{field}")
-      end
-
-      # Reload the form and verify
-      visit '/dashboard/my/works'
-      check 'check_all'
-      find('#batch-edit').click
-      expect(page).to have_content('Batch Edit Descriptions')
-      batch_edit_expand("creator") do
-        page.find("input#generic_work_creator[value='NEW creator']")
-      end
-      batch_edit_expand("contributor") do
-        page.find("input#generic_work_contributor[value='NEW contributor']")
-      end
-      batch_edit_expand("description") do
-        page.find("textarea#generic_work_description", text: 'NEW description')
-      end
-      batch_edit_expand("keyword") do
-        page.find("input#generic_work_keyword[value='NEW keyword']")
-      end
-      batch_edit_expand("publisher") do
-        page.find "input#generic_work_publisher[value='NEW publisher']"
-      end
-      batch_edit_expand("date_created") do
-        page.find("input#generic_work_date_created[value='NEW date_created']")
-      end
-      batch_edit_expand("subject") do
-        page.find("input#generic_work_subject[value='NEW subject']")
-      end
-      batch_edit_expand("language") do
-        page.find("input#generic_work_language[value='NEW language']")
-      end
-      batch_edit_expand("identifier") do
-        page.find("input#generic_work_identifier[value='NEW identifier']")
-      end
-      # batch_edit_expand("based_near")
-      # expect(page).to have_css "input#generic_work_based_near[value*='NEW based_near']"
-      batch_edit_expand("related_url") do
-        page.find("input#generic_work_related_url[value='NEW related_url']")
-      end
-    end
-
-    it 'updates permissions and roles' do
-      click_on 'batch-edit'
-      find('#edit_permissions_link').click
-      expect(page).to have_content('Batch Edit Descriptions')
-
-      # Set visibility to private
-      within "#form_permissions_visibility" do
-        batch_edit_expand('permissions_visibility')
-        find('#generic_work_visibility_authenticated').click
-        find('#permissions_visibility_save').click
-        # This was `expect(page).to have_content 'Changes Saved'`, however in debugging,
-        # the `have_content` check was ignoring the `within` scoping and finding
-        # "Changes Saved" for other field areas
-        find('.status', text: 'Changes Saved', wait: 5)
-      end
-
-      within "#form_permissions" do
-        batch_edit_expand('permissions_sharing')
-        page.select('donor', from: 'new_group_name_skel')
-        page.select('View/Download', from: 'new_group_permission_skel')
-        page.find('#add_new_group_skel').click
-        find('#collapse_permissions_sharing table', text: 'View/Download')
-        find('#collapse_permissions_sharing table', text: 'donor')
-        find('#permissions_sharing_save').click
-        # This was `expect(page).to have_content 'Changes Saved'`, however in debugging,
-        # the `have_content` check was ignoring the `within` scoping and finding
-        # "Changes Saved" for other field areas
-        find('.status', text: 'Changes Saved', wait: 5)
-      end
-
-      # Visit work permissions and verify
-      visit "/concern/generic_works/#{work1.id}/edit#share"
-      page.find('#generic_work_visibility_authenticated:checked')
-      page.find('#share table', text: 'donor')
-
-      # Visit file permissions and verify
-      visit "concern/file_sets/#{work1.file_sets.first.id}/edit#permissions_display"
-      page.find('#file_set_visibility_authenticated:checked')
-      page.find('#permissions_display table', text: 'donor')
-    end
-  end
-
-  describe 'deleting' do
-    it 'destroys the selected works' do
-      accept_confirm { click_button 'Delete Selected' }
-      expect(page).to have_content('Batch delete complete')
-      expect(GenericWork.count).to be_zero
-    end
-  end
-end

data/spec/features/browse_catalog_spec.rb

@@ -1,59 +0,0 @@
-RSpec.describe "Browse catalog:", type: :feature, clean_repo: true do
-  let!(:jills_work) do
-    GenericWork.new do |work|
-      work.title = ["Jill's Research"]
-      (1..25).each do |i|
-        work.keyword << ["keyword#{format('%02d', i)}"]
-      end
-      work.apply_depositor_metadata('jilluser')
-      work.read_groups = ['public']
-      work.save!
-    end
-  end
-
-  let!(:jacks_work) do
-    GenericWork.new do |work|
-      work.title = ["Jack's Research"]
-      work.keyword = ['jacks_keyword']
-      work.apply_depositor_metadata('jackuser')
-      work.read_groups = ['public']
-      work.save!
-    end
-  end
-
-  before do
-    visit '/'
-  end
-
-  describe 'when not logged in' do
-    it 'using facet pagination to browse by keywords' do
-      click_button "search-submit-header"
-
-      expect(page).to have_content 'Search Results'
-      expect(page).to have_content jills_work.title.first
-      expect(page).to have_content jacks_work.title.first
-
-      click_link "Keyword"
-      click_link "more Keywords »"
-      within('.bottom') do
-        click_link 'Next »'
-      end
-
-      within(".modal-body") do
-        expect(page).not_to have_content 'keyword05'
-        expect(page).to have_content 'keyword21'
-
-        click_link 'keyword21'
-      end
-
-      expect(page).to have_content jills_work.title.first
-      expect(page).not_to have_content jacks_work.title.first
-
-      # TODO:  After the _generic_work.html.erb view is finished
-      #
-      #      click_link jills_work.title.first
-      #      expect(page).to     have_content "Download"
-      #      expect(page).not_to have_content "Edit"
-    end
-  end
-end

data/spec/features/browse_dashboard_works_spec.rb

@@ -1,56 +0,0 @@
-RSpec.describe "Browse Dashboard", type: :feature do
-  let(:user) { create(:user) }
-  let!(:dissertation) do
-    create(:public_work, user: user, title: ["Fake PDF Title"], subject: %w[lorem ipsum dolor sit amet])
-  end
-  let!(:mp3_work) do
-    create(:public_work, user: user, title: ["Test Document MP3"], subject: %w[consectetur adipisicing elit])
-  end
-
-  before do
-    # Grant the user access to deposit into an admin set.
-    create(:permission_template_access,
-           :deposit,
-           permission_template: create(:permission_template, with_admin_set: true),
-           agent_type: 'user',
-           agent_id: user.user_key)
-
-    sign_in user
-    create(:public_work, user: user, title: ["Fake Wav Files"], subject: %w[sed do eiusmod tempor incididunt ut labore])
-    visit "/dashboard/my/works"
-  end
-
-  it "lets the user search and display their files" do
-    fill_in "q", with: "PDF"
-    click_button "search-submit-header"
-    expect(page).to have_content("Fake PDF Title")
-    within(".constraints-container") do
-      expect(page).to have_content("Filtering by:")
-      expect(page).to have_css("span.glyphicon-remove")
-      find(".dropdown-toggle").click
-    end
-    expect(page).to have_content("Fake Wav File")
-
-    # Browse facets
-    click_button "Status"
-    click_link "Published"
-    within("#document_#{mp3_work.id}") do
-      expect(page).to have_link("Display all details of Test Document MP3",
-                                href: hyrax_generic_work_path(mp3_work, locale: 'en'))
-    end
-    click_link("Remove constraint Status: Published")
-
-    within("#document_#{dissertation.id}") do
-      click_button("Select")
-      expect(page).to have_content("Edit Work")
-    end
-  end
-
-  it "allows me to delete works in upload_sets", js: true do
-    first('input#check_all').click
-    expect do
-      accept_confirm { click_button('Delete Selected') }
-      expect(page).to have_content('Batch delete complete')
-    end.to change { GenericWork.count }.by(-3)
-  end
-end