hyrax 3.0.0.pre.rc1 → 3.0.0.pre.rc2

data/spec/models/hyrax/permission_template_spec.rb

@@ -1,291 +0,0 @@
-RSpec.describe Hyrax::PermissionTemplate, :clean_repo do
-  let(:admin_set) { create(:admin_set) }
-  let(:collection) { create(:collection) }
-  let(:permission_template) { described_class.new(attributes) }
-  let(:attributes) { { source_id: admin_set.id } }
-
-  subject { permission_template }
-
-  it { is_expected.to have_many(:available_workflows).dependent(:destroy) }
-  it { is_expected.to have_one(:active_workflow).conditions(active: true).dependent(nil) }
-  it { is_expected.to have_many(:access_grants).dependent(:destroy) }
-
-  describe 'factories' do
-    context 'with_admin_set parameter' do
-      it 'will create an AdminSet when true' do
-        permission_template = create(:permission_template, with_admin_set: true)
-        expect(permission_template.admin_set).to be_persisted
-      end
-      it 'will not persist an AdminSet when false (or not given)' do
-        permission_template = create(:permission_template, with_admin_set: false)
-        expect { permission_template.admin_set }.to raise_error(Hyrax::ObjectNotFoundError)
-      end
-    end
-
-    context 'with_collection parameter' do
-      it 'will create an Collection when true' do
-        permission_template = create(:permission_template, with_collection: true)
-        expect(permission_template.collection).to be_persisted
-      end
-      it 'will not persist an Collection when false (or not given)' do
-        permission_template = create(:permission_template, with_collection: false)
-        expect { permission_template.collection }.to raise_error(Hyrax::ObjectNotFoundError)
-      end
-    end
-
-    context 'with_workflows parameter' do
-      it 'will create the workflow when set true' do
-        expect { create(:permission_template, with_workflows: true) }.to change { Sipity::Workflow.count }
-      end
-      it 'will not create the workflow when false (or not given)' do
-        expect { create(:permission_template, with_workflows: false) }.not_to change { Sipity::Workflow.count }
-      end
-    end
-
-    context 'with_active_workflow parameter' do
-      it 'will create the workflow when set true' do
-        expect { create(:permission_template, with_active_workflow: true) }.to change { Sipity::Workflow.count }.by(1)
-      end
-      it 'will not create the workflow when false (or not given)' do
-        expect { create(:permission_template, with_active_workflow: false) }.not_to change { Sipity::Workflow.count }
-      end
-    end
-  end
-
-  describe '#agent_ids_for' do
-    it 'queries the underlying access_grants' do
-      template = create(:permission_template)
-      to_find = template.access_grants.create!(agent_type: 'user', access: 'manage', agent_id: '123')
-      template.access_grants.create!(agent_type: 'user', access: 'view', agent_id: '456')
-      template.access_grants.create!(agent_type: 'group', access: 'manage', agent_id: '789')
-
-      expect(template.agent_ids_for(agent_type: 'user', access: 'manage')).to eq([to_find.agent_id])
-    end
-  end
-
-  describe "#source_model" do
-    context 'when source is an AdminSet' do
-      let(:as_permission_template) { described_class.new(as_attributes) }
-      let(:as_attributes) { { source_id: admin_set.id } }
-
-      before do
-        allow(AdminSet).to receive(:find).with(as_permission_template.source_id).and_return(admin_set)
-      end
-
-      it 'returns an AdminSet if the source_type is admin_set for the given permission_template' do
-        expect(as_permission_template.source_model).to be_kind_of(AdminSet)
-        expect(as_permission_template.source_model).to eq(admin_set)
-      end
-    end
-
-    context 'when source is a Collection' do
-      let(:col_permission_template) { described_class.new(col_attributes) }
-      let(:col_attributes) { { source_id: collection.id } }
-
-      before do
-        allow(Collection).to receive(:find).with(col_permission_template.source_id).and_return(collection)
-      end
-
-      it 'returns a Collection if the source_type is collection for the given permission_template' do
-        expect(col_permission_template.source_model).to be_kind_of(Collection)
-        expect(col_permission_template.source_model).to eq(collection)
-      end
-    end
-  end
-
-  describe "#admin_set" do
-    it 'leverages AdminSet.find for the given permission_template' do
-      expect(AdminSet).to receive(:find).with(permission_template.source_id).and_return(admin_set)
-      expect(permission_template.admin_set).to eq(admin_set)
-    end
-  end
-
-  describe "#collection" do
-    let(:col_permission_template) { described_class.new(col_attributes) }
-    let(:col_attributes) { { source_id: collection.id } }
-
-    before do
-      allow(Collection).to receive(:find).with(col_permission_template.source_id).and_return(collection)
-    end
-
-    it 'leverages Collection.find for the given permission_template' do
-      expect(col_permission_template.collection).to be_kind_of(Collection)
-      expect(col_permission_template.collection).to eq(collection)
-    end
-  end
-
-  describe "#release_fixed_date?" do
-    subject { permission_template.release_fixed_date? }
-
-    context "with release_period='fixed'" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_FIXED } }
-
-      it { is_expected.to be true }
-    end
-    context "with other release_period" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_NO_DELAY } }
-
-      it { is_expected.to be false }
-    end
-  end
-
-  describe "#release_no_delay?" do
-    subject { permission_template.release_no_delay? }
-
-    context "with release_period='now'" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_NO_DELAY } }
-
-      it { is_expected.to be true }
-    end
-    context "with other release_period" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_FIXED } }
-
-      it { is_expected.to be false }
-    end
-  end
-
-  describe "#release_before_date?" do
-    subject { permission_template.release_before_date? }
-
-    context "with release_period='before'" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_BEFORE_DATE } }
-
-      it { is_expected.to be true }
-    end
-    context "with maximum embargo period (release_period of 1 year)" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_1_YEAR } }
-
-      it { is_expected.to be true }
-    end
-    context "with other release_period" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_FIXED } }
-
-      it { is_expected.to be false }
-    end
-  end
-
-  describe "#release_max_embargo?" do
-    subject { permission_template.release_max_embargo? }
-
-    context "with release_period of 1 year" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_1_YEAR } }
-
-      it { is_expected.to be true }
-    end
-    context "with release_period of 2 years" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_2_YEARS } }
-
-      it { is_expected.to be true }
-    end
-    context "with other release_period" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_FIXED } }
-
-      it { is_expected.to be false }
-    end
-  end
-
-  describe "#release_date" do
-    subject { permission_template.release_date }
-
-    let(:today) { Time.zone.today }
-
-    context "with today and release_fixed_date?" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_FIXED, release_date: today } }
-
-      it { is_expected.to eq today }
-    end
-    context "with today and release_before_date?" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_BEFORE_DATE, release_date: today } }
-
-      it { is_expected.to eq today }
-    end
-    context "with release_period of 6 months" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_6_MONTHS } }
-
-      it { is_expected.to eq today + 6.months }
-    end
-    context "with release_period of 1 year" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_1_YEAR } }
-
-      it { is_expected.to eq today + 1.year }
-    end
-    context "with release_no_delay?" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_NO_DELAY } }
-
-      it { is_expected.to eq today }
-    end
-  end
-
-  describe "#valid_release_date?" do
-    let(:date) { Time.zone.today + 6.months }
-
-    subject { permission_template.valid_release_date?(date) }
-
-    context "with any release date and one is not required" do
-      let(:attributes) { { source_id: admin_set.id } }
-
-      it { is_expected.to eq true }
-    end
-    context "with matching date and release_fixed_date?" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_FIXED, release_date: date } }
-
-      it { is_expected.to eq true }
-    end
-    context "with non-matching date and release_fixed_date?" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_FIXED, release_date: date + 1.day } }
-
-      it { is_expected.to eq false }
-    end
-    context "with exact match date and release_before_date?" do
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_BEFORE_DATE, release_date: date } }
-
-      it { is_expected.to eq true }
-    end
-    context "with future, valid date and release_before_date?" do
-      let(:date) { Time.zone.today + 1.day }
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_BEFORE_DATE, release_date: Time.zone.today + 1.month } }
-
-      it { is_expected.to eq true }
-    end
-    context "with future, invalid date and release_before_date?" do
-      let(:date) { Time.zone.today + 1.year }
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_BEFORE_DATE, release_date: Time.zone.today + 1.month } }
-
-      it { is_expected.to eq false }
-    end
-    context "with today release and release_no_delay?" do
-      let(:date) { Time.zone.today }
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_NO_DELAY } }
-
-      it { is_expected.to eq true }
-    end
-    context "with tomorrow release and release_no_delay?" do
-      let(:date) { Time.zone.today + 1.day }
-      let(:attributes) { { source_id: admin_set.id, release_period: Hyrax::PermissionTemplate::RELEASE_TEXT_VALUE_NO_DELAY } }
-
-      it { is_expected.to eq false }
-    end
-  end
-
-  describe "#valid_visibility?" do
-    let(:visibility) { Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC }
-
-    subject { permission_template.valid_visibility?(visibility) }
-
-    context "with matching visibility" do
-      let(:attributes) { { source_id: admin_set.id, visibility: Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC } }
-
-      it { is_expected.to eq true }
-    end
-    context "with non-matching visibility" do
-      let(:attributes) { { source_id: admin_set.id, visibility: Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED } }
-
-      it { is_expected.to eq false }
-    end
-    context "with visibility when none required" do
-      let(:attributes) { { source_id: admin_set.id } }
-
-      it { is_expected.to eq true }
-    end
-  end
-end

data/spec/models/hyrax/permissions/readable_permissions_spec.rb

@@ -1,52 +0,0 @@
-RSpec.describe Hyrax::Permissions::Readable do
-  class SubjectClass
-    include Hyrax::Permissions::Readable
-    attr_accessor :read_groups
-  end
-  let(:subject) { SubjectClass.new }
-
-  describe '#public?' do
-    it 'returns true for public items' do
-      subject.read_groups = %w[public othergroup]
-      expect(subject).to be_public
-    end
-    it 'returns fale for non-public items' do
-      subject.read_groups = %w[notpublic othergroup]
-      expect(subject).not_to be_public
-    end
-  end
-
-  describe '#registered?' do
-    it 'returns true for registered items' do
-      subject.read_groups = %w[registered othergroup]
-      expect(subject).to be_registered
-    end
-    it 'returns fale for non-registered items' do
-      subject.read_groups = ['othergroup']
-      expect(subject).not_to be_registered
-    end
-  end
-
-  describe '#private?' do
-    context 'is true' do
-      specify 'when there are no groups defined' do
-        subject.read_groups = []
-        expect(subject).to be_private
-      end
-      specify "when groups do not include 'public' or 'registered'" do
-        subject.read_groups = ['othergroup']
-        expect(subject).to be_private
-      end
-    end
-    context 'is false' do
-      specify "when 'registered' group is present" do
-        subject.read_groups = ['registered']
-        expect(subject).not_to be_private
-      end
-      specify "when 'public' group is present" do
-        subject.read_groups = ['public']
-        expect(subject).not_to be_private
-      end
-    end
-  end
-end

data/spec/models/hyrax/permissions/writable_permissions_spec.rb

@@ -1,12 +0,0 @@
-RSpec.describe Hyrax::Permissions::Writable do
-  class SampleModel < ActiveFedora::Base
-    include Hyrax::Permissions::Writable
-  end
-  let(:subject) { SampleModel.new }
-
-  describe '#permissions' do
-    it 'initializes with nothing specified' do
-      expect(subject.permissions).to be_empty
-    end
-  end
-end

data/spec/models/hyrax/resource_spec.rb

@@ -1,60 +0,0 @@
-# frozen_string_literal: true
-
-require 'valkyrie/specs/shared_specs'
-
-RSpec.describe Hyrax::Resource do
-  subject(:resource) { described_class.new }
-  let(:adapter)      { Valkyrie::Persistence::Memory::MetadataAdapter.new }
-
-  it_behaves_like 'a Valkyrie::Resource' do
-    let(:resource_klass) { described_class }
-  end
-
-  describe '#alternate_ids' do
-    let(:id) { Valkyrie::ID.new('fake_identifier') }
-
-    it 'has an attribute for alternate ids' do
-      expect { resource.alternate_ids = id }
-        .to change { resource.alternate_ids }
-        .to contain_exactly id
-    end
-  end
-
-  describe '#embargo' do
-    subject(:resource) { described_class.new(embargo: embargo) }
-    let(:embargo)      { FactoryBot.build(:hyrax_embargo) }
-
-    it 'saves the embargo' do
-      expect(Hyrax.persister.save(resource: resource).embargo)
-        .to have_attributes(embargo_release_date: embargo.embargo_release_date)
-    end
-  end
-
-  describe '#lease' do
-    subject(:resource) { described_class.new(lease: lease) }
-    let(:lease)        { FactoryBot.build(:hyrax_lease) }
-
-    it 'saves the lease' do
-      expect(Hyrax.persister.save(resource: resource).lease)
-        .to have_attributes(lease_expiration_date: lease.lease_expiration_date)
-    end
-  end
-
-  describe '#visibility' do
-    let(:open) { Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC }
-
-    it 'round trips' do
-      expect { resource.visibility = open }
-        .to change { resource.visibility }
-        .to open
-    end
-
-    context 'when setting to public' do
-      it 'adds public read group' do
-        expect { resource.visibility = open }
-          .to change { resource.read_groups }
-          .to contain_exactly(Hydra::AccessControls::AccessRight::PERMISSION_TEXT_VALUE_PUBLIC)
-      end
-    end
-  end
-end

data/spec/models/hyrax/uploaded_file_spec.rb

@@ -1,10 +0,0 @@
-RSpec.describe Hyrax::UploadedFile do
-  let(:file1) { File.open(fixture_path + '/world.png') }
-
-  subject { described_class.create(file: file1) }
-
-  it "is not in the public directory" do
-    temp_dir = Rails.root + 'tmp'
-    expect(subject.file.path).to start_with temp_dir.to_s
-  end
-end

data/spec/models/hyrax/user_usage_stats_spec.rb

@@ -1,43 +0,0 @@
-RSpec.describe Hyrax::UserUsageStats do
-  subject { create(:user) }
-
-  describe 'with cached stats' do
-    let!(:stat_1_day_ago) { UserStat.create!(user_id: subject.id, date: 1.day.ago, file_views: 3, file_downloads: 2, work_views: 5) }
-    let!(:stat_2_days_ago) { UserStat.create!(user_id: subject.id, date: 2.days.ago, file_views: 2, file_downloads: 1, work_views: 7) }
-
-    let!(:someone_elses_user_id) { subject.id + 1 }
-    let!(:not_my_stat) { UserStat.create!(user_id: someone_elses_user_id, date: 2.days.ago, file_views: 10, file_downloads: 11) }
-
-    describe '#total_file_views' do
-      it 'returns the total file views for that user' do
-        expect(subject.total_file_views).to eq 5
-      end
-    end
-
-    describe '#total_file_downloads' do
-      it 'returns the total file downloads for that user' do
-        expect(subject.total_file_downloads).to eq 3
-      end
-    end
-
-    describe '#total_work_views' do
-      it 'returns the total work views for that user' do
-        expect(subject.total_work_views).to eq 12
-      end
-    end
-  end
-
-  describe 'with empty cache' do
-    describe '#total_file_views' do
-      it 'returns the total file views for that user' do
-        expect(subject.total_file_views).to eq 0
-      end
-    end
-
-    describe '#total_file_downloads' do
-      it 'returns the total file downloads for that user' do
-        expect(subject.total_file_downloads).to eq 0
-      end
-    end
-  end
-end