hyrax 3.0.0.pre.beta2 → 3.0.0.pre.beta3

data/spec/actors/hyrax/actors/file_set_actor_spec.rb

@@ -293,7 +293,7 @@ RSpec.describe Hyrax::Actors::FileSetActor do
       let(:work_v1) { create(:generic_work) } # this version of the work has no members
 
       before do # another version of the same work is saved with a member
-        work_v2 = ActiveFedora::Base.find(work_v1.id)
+        work_v2 = Hyrax.query_service.find_by_alternate_identifier(alternate_identifier: work_v1.id, use_valkyrie: false)
         work_v2.ordered_members << create(:file_set)
         work_v2.save!
       end

data/spec/actors/hyrax/actors/generic_work_actor_spec.rb

@@ -39,13 +39,9 @@ RSpec.describe Hyrax::Actors::GenericWorkActor do
     end
 
     context 'failure' do
-      before do
-        allow(middleware).to receive(:attach_files).and_return(true)
-      end
+      before { allow_any_instance_of(described_class).to receive(:save).and_return(false) }
 
-      # The clean is here because this test depends on the repo not having an AdminSet/PermissionTemplate created yet
-      it 'returns false', :clean_repo do
-        expect(curation_concern).to receive(:save).and_return(false)
+      it 'returns false' do
         expect(middleware.create(env)).to be false
       end
     end

data/spec/actors/hyrax/actors/interpret_visibility_actor_spec.rb

@@ -439,7 +439,7 @@ RSpec.describe Hyrax::Actors::InterpretVisibilityActor do
 
         it 'sets error on curation_concern and return false' do
           expect(subject.create(env)).to be false
-          expect(curation_concern.errors[:lease_expiration_date].first).to eq 'Must be a future date'
+          expect(env.curation_concern.errors[:lease_expiration_date].first).to eq 'Must be a future date'
         end
       end
     end

data/spec/actors/hyrax/actors/ordered_members_actor_spec.rb

@@ -38,7 +38,7 @@ RSpec.describe Hyrax::Actors::OrderedMembersActor do
       let(:work_v1) { create(:generic_work) } # this version of the work has no members
 
       before do # another version of the same work is saved with a member
-        work_v2 = ActiveFedora::Base.find(work_v1.id)
+        work_v2 = Hyrax.query_service.find_by_alternate_identifier(alternate_identifier: work_v1.id, use_valkyrie: false)
         work_v2.ordered_members << create(:file_set)
         work_v2.save!
       end

data/spec/actors/hyrax/actors/valkyrie_to_active_fedora_spec.rb

@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+RSpec.describe Hyrax::Actors::ValkyrieToActiveFedora do
+  let(:ability)    { :FAKE_ABILITY }
+  let(:attrs)      { {} }
+  let(:env)        { Hyrax::Actors::Environment.new(work, ability, attrs) }
+  let(:spy)        { middleware.next_actor }
+  let(:terminator) { Hyrax::Actors::Terminator.new }
+  let(:work)       { FactoryBot.build(:work).valkyrie_resource }
+
+  subject(:middleware) do
+    stack = ActionDispatch::MiddlewareStack.new.tap do |middleware|
+      middleware.use described_class
+      middleware.use FakeActor
+    end
+
+    stack.build(terminator)
+  end
+
+  shared_examples 'casts to ActiveFedora' do |method|
+    it 'returns true' do
+      expect(middleware.public_send(method, env)).to be true
+    end
+
+    it 'casts to ActiveFedora' do
+      expect { middleware.public_send(method, env) }
+        .to change { env.curation_concern }
+        .to be_a GenericWork
+    end
+
+    context 'when concern is not a valkyrie resource' do
+      let(:work) { :FAKE_WORK }
+
+      it 'is a no-op' do
+        expect { middleware.public_send(method, env) }
+          .not_to change { env.curation_concern }
+      end
+    end
+  end
+
+  describe '#create' do
+    include_examples 'casts to ActiveFedora', :create
+
+    it 'calls create on next actor' do
+      expect { middleware.create(env) }
+        .to change { spy.created }
+        .from be_falsey
+    end
+  end
+
+  describe '#update' do
+    include_examples 'casts to ActiveFedora', :update
+
+    it 'calls update on next actor' do
+      expect { middleware.update(env) }
+        .to change { spy.updated }
+        .from be_falsey
+    end
+  end
+
+  describe '#destroy' do
+    include_examples 'casts to ActiveFedora', :destroy
+
+    it 'calls update on next actor' do
+      expect { middleware.destroy(env) }
+        .to change { spy.destroyed }
+        .from be_falsey
+    end
+  end
+end

data/spec/controllers/catalog_controller_spec.rb

@@ -18,8 +18,8 @@ RSpec.describe CatalogController, type: :controller do
     end
 
     before do
-      objects.each { |obj| ActiveFedora::SolrService.add(obj.to_solr) }
-      ActiveFedora::SolrService.commit
+      objects.each { |obj| Hyrax::SolrService.add(obj.to_solr) }
+      Hyrax::SolrService.commit
     end
 
     context 'with a non-work file' do

data/spec/controllers/hyrax/api/items_controller_spec.rb

@@ -71,7 +71,7 @@ RSpec.describe Hyrax::API::ItemsController, type: :controller do
 
       before do
         allow(Hyrax::WorkRelation).to receive(:new).and_return(relation)
-        allow(relation).to receive(:find).with(default_work.id).and_raise(ActiveFedora::ObjectNotFoundError)
+        allow(relation).to receive(:find).with(default_work.id).and_raise(Hyrax::ObjectNotFoundError)
         get :show, params: { format: :json, id: default_work.id, token: token }
       end
 
@@ -198,8 +198,7 @@ RSpec.describe Hyrax::API::ItemsController, type: :controller do
 
       it 'calls the arkivo actor to update the work' do
         expect(arkivo_actor).to receive(:update_work_from_item)
-        request.env['RAW_POST_DATA'] = put_item
-        put :update, params: { id: gw.id, format: :json }
+        put :update, params: { id: gw.id, format: :json }, body: put_item
       end
     end
 
@@ -216,8 +215,7 @@ RSpec.describe Hyrax::API::ItemsController, type: :controller do
         allow(relation).to receive(:find).with(non_arkivo_gw.id).and_return(non_arkivo_gw)
 
         # Post an update to a work with a nil arkivo_checksum
-        request.env['RAW_POST_DATA'] = put_item
-        put :update, params: { id: non_arkivo_gw.id, format: :json }
+        put :update, params: { id: non_arkivo_gw.id, format: :json }, body: put_item
       end
 
       it "is forbidden" do
@@ -233,10 +231,9 @@ RSpec.describe Hyrax::API::ItemsController, type: :controller do
       before do
         allow(Hyrax::WorkRelation).to receive(:new).and_return(relation)
         allow(relation).to receive(:find).with(gw.id) do
-          raise(ActiveFedora::ObjectNotFoundError)
+          raise(Hyrax::ObjectNotFoundError)
         end
-        request.env['RAW_POST_DATA'] = put_item
-        put :update, params: { id: gw.id, format: :json }
+        put :update, params: { id: gw.id, format: :json }, body: put_item
       end
 
       it "is not found" do
@@ -251,8 +248,7 @@ RSpec.describe Hyrax::API::ItemsController, type: :controller do
         allow(controller).to receive(:user).and_return(user)
         allow(user).to receive(:can?).and_return(false)
         # Post an update with an resource unauthorized for the user
-        request.env['RAW_POST_DATA'] = put_item
-        put :update, params: { id: gw.id, format: :json }
+        put :update, params: { id: gw.id, format: :json }, body: put_item
       end
 
       it "is unauthorized" do
@@ -268,8 +264,7 @@ RSpec.describe Hyrax::API::ItemsController, type: :controller do
       let(:bad_token_item) { FactoryBot.json(:put_item, token: bad_token) }
 
       before do
-        request.env['RAW_POST_DATA'] = bad_token_item
-        put :update, params: { id: gw.id, format: :json }
+        put :update, params: { id: gw.id, format: :json }, body: bad_token_item
       end
 
       it "is unauthorized" do
@@ -283,8 +278,7 @@ RSpec.describe Hyrax::API::ItemsController, type: :controller do
       let(:invalid_item) { { foo: 'bar' }.to_json }
 
       before do
-        request.env['RAW_POST_DATA'] = invalid_item
-        put :update, params: { id: gw.id, format: :json }
+        put :update, params: { id: gw.id, format: :json }, body: invalid_item
       end
 
       it "is a bad request" do
@@ -374,7 +368,7 @@ RSpec.describe Hyrax::API::ItemsController, type: :controller do
       before do
         # Mock ActiveFedora
         allow(Hyrax::WorkRelation).to receive(:new).and_return(relation)
-        allow(relation).to receive(:find).with(not_found_id).and_raise(ActiveFedora::ObjectNotFoundError)
+        allow(relation).to receive(:find).with(not_found_id).and_raise(Hyrax::ObjectNotFoundError)
         delete :destroy, params: { format: :json, id: not_found_id, token: token }
       end
 

data/spec/controllers/hyrax/collections_controller_spec.rb

@@ -32,7 +32,9 @@ RSpec.describe Hyrax::CollectionsController do
 
       it "returns the collection and its members" do # rubocop:disable RSpec/ExampleLength
         expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
-        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('My collection', collection_path(collection.id, locale: 'en'), "aria-current" => "page")
         get :show, params: { id: collection }
         expect(response).to be_successful
         expect(response).to render_template("layouts/hyrax/1_column")
@@ -68,7 +70,9 @@ RSpec.describe Hyrax::CollectionsController do
       context "without a referer" do
         it "sets breadcrumbs" do
           expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
-          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('My collection', collection_path(collection.id, locale: 'en'), "aria-current" => "page")
           get :show, params: { id: collection }
           expect(response).to be_successful
         end

data/spec/controllers/hyrax/dashboard/collections_controller_spec.rb

@@ -82,7 +82,7 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
         }
 
         expect(assigns[:collection].member_objects).to eq [asset1]
-        asset_results = ActiveFedora::SolrService.instance.conn.get "select", params: { fq: ["id:\"#{asset1.id}\""], fl: ['id', ActiveFedora.index_field_mapper.solr_name(:collection)] }
+        asset_results = Hyrax::SolrService.get(fq: ["id:\"#{asset1.id}\""], fl: ['id', "collection_tesim"])
         expect(asset_results["response"]["numFound"]).to eq 1
         doc = asset_results["response"]["docs"].first
         expect(doc["id"]).to eq asset1.id
@@ -294,6 +294,49 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
 
         expect(CollectionBrandingInfo.where(collection_id: collection.id, role: "logo", alt_text: "Logo alt Text", target_url: "http://abc.com").where("local_path LIKE '%logo.gif'")).to exist
       end
+
+      context 'where the linkurl is not a valid http|http link' do
+        it "does not save linkurl containing html; target_url is empty" do
+          val = double(["/public/logo.gif"])
+          allow(val).to receive(:file_url).and_return("/public/logo.gif")
+          allow(Hyrax::UploadedFile).to receive(:find).with("1").and_return(val)
+
+          allow(File).to receive(:split).with(any_args).and_return(["logo.gif"])
+          allow(FileUtils).to receive(:cp).with(any_args).and_return(nil)
+
+          put :update, params: { id: collection, logo_files: [1], alttext: ["Logo alt Text"], linkurl: ["<script>remove_me</script>"], collection: { creator: ['Emily'] }, update_collection: true }
+          collection.reload
+
+          expect(
+            CollectionBrandingInfo.where(
+              collection_id: collection.id,
+              role: "logo",
+              alt_text: "Logo alt Text",
+              target_url: "<script>remove_me</script>"
+            ).where("target_url LIKE '%remove_me%)'")
+          ).not_to exist
+        end
+
+        it "does not save linkurl containing dodgy protocol; target_url is empty" do
+          val = double(["/public/logo.gif"])
+          allow(val).to receive(:file_url).and_return("/public/logo.gif")
+          allow(Hyrax::UploadedFile).to receive(:find).with("1").and_return(val)
+
+          allow(File).to receive(:split).with(any_args).and_return(["logo.gif"])
+          allow(FileUtils).to receive(:cp).with(any_args).and_return(nil)
+
+          put :update, params: { id: collection, logo_files: [1], alttext: ["Logo alt Text"], linkurl: ['javascript:alert("remove_me")'], collection: { creator: ['Emily'] }, update_collection: true }
+          collection.reload
+          expect(
+            CollectionBrandingInfo.where(
+              collection_id: collection.id,
+              role: "logo",
+              alt_text: "Logo alt Text",
+              target_url: 'javascript:alert("remove_me")'
+            ).where("target_url LIKE '%remove_me%)'")
+          ).not_to exist
+        end
+      end
     end
   end
 
@@ -309,7 +352,9 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
 
       it "returns the collection and its members" do
         expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
-        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('My collection', collection_path(collection.id, locale: 'en'), "aria-current" => "page")
         get :show, params: { id: collection }
         expect(response).to be_successful
         expect(assigns[:presenter]).to be_kind_of Hyrax::CollectionPresenter
@@ -344,7 +389,9 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
       context "without a referer" do
         it "sets breadcrumbs" do
           expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
-          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('My collection', collection_path(collection.id, locale: 'en'), "aria-current" => "page")
           get :show, params: { id: collection }
           expect(response).to be_successful
         end
@@ -442,7 +489,9 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
     context "without a referer" do
       it "sets breadcrumbs" do
         expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
-        expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with(I18n.t("hyrax.collection.browse_view"), collection_path(collection.id, locale: 'en'), "aria-current" => "page")
         get :edit, params: { id: collection }
         expect(response).to be_successful
       end

data/spec/controllers/hyrax/depositors_controller_spec.rb

@@ -51,10 +51,10 @@ RSpec.describe Hyrax::DepositorsController do
           post :create, params: grant_proxy_params.merge(grantee_id: user.user_key)
         end
 
-        it 'does not add the user, and returns a 200, with empty response body' do
+        it 'does not add the user, and returns an unsuccessful response, with an error message' do
           expect { redundant_request_to_grant_proxy }.to change { ProxyDepositRights.count }.by(0)
-          expect(response).to be_success
-          expect(response.body).to be_blank
+          expect(response).not_to be_success
+          expect(response.body).to have_content "You cannot make yourself a proxy"
         end
 
         it 'does not send a message to the user' do

data/spec/controllers/hyrax/downloads_controller_spec.rb

@@ -74,6 +74,15 @@ RSpec.describe Hyrax::DownloadsController do
             get :show, params: { id: file_set, file: 'thumbnail' }
           end
 
+          it 'sends 304 response when client has valid cached data' do
+            get :show, params: { id: file_set, file: 'thumbnail' }
+            expect(response).to have_http_status :success
+            request.env['HTTP_IF_MODIFIED_SINCE'] = response.headers['Last-Modified']
+            request.env['HTTP_IF_NONE_MATCH'] = response.headers['ETag']
+            get :show, params: { id: file_set, file: 'thumbnail' }
+            expect(response).to have_http_status :not_modified
+          end
+
           context "stream" do
             it "head request" do
               request.env["HTTP_RANGE"] = 'bytes=0-15'
@@ -121,7 +130,7 @@ RSpec.describe Hyrax::DownloadsController do
           it "raises an error if the requested file does not exist" do
             expect do
               get :show, params: { id: file_set, file: 'thumbnail' }
-            end.to raise_error ActiveFedora::ObjectNotFoundError
+            end.to raise_error Hyrax::ObjectNotFoundError
           end
         end
       end
@@ -129,7 +138,7 @@ RSpec.describe Hyrax::DownloadsController do
       it "raises an error if the requested association does not exist" do
         expect do
           get :show, params: { id: file_set, file: 'non-existant' }
-        end.to raise_error ActiveFedora::ObjectNotFoundError
+        end.to raise_error Hyrax::ObjectNotFoundError
       end
     end
   end

data/spec/controllers/hyrax/file_sets_controller_spec.rb

@@ -232,9 +232,24 @@ RSpec.describe Hyrax::FileSetsController do
       end
 
       context "without a referer" do
+        let(:work) do
+          create(:generic_work, :public,
+                 title: ['test title'],
+                 user: user)
+        end
+
+        before do
+          work.ordered_members << file_set
+          work.save!
+          file_set.save!
+        end
+
         it "shows me the file and set breadcrumbs" do
           expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
-          expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Works', Hyrax::Engine.routes.url_helpers.my_works_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('test title', main_app.hyrax_generic_work_path(work.id, locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('test file', main_app.hyrax_file_set_path(file_set, locale: 'en'))
           get :show, params: { id: file_set }
           expect(response).to be_successful
           expect(flash).to be_empty
@@ -275,7 +290,18 @@ RSpec.describe Hyrax::FileSetsController do
       let(:creator) { create(:user, email: 'archivist1@example.com') }
       let(:public_file_set) { create(:file_set, user: creator, read_groups: ['public']) }
 
-      before { sign_in user }
+      let(:work) do
+        create(:generic_work, :public,
+               title: ['test title'],
+               user: user)
+      end
+
+      before do
+        sign_in user
+        work.ordered_members << public_file_set
+        work.save!
+        public_file_set.save!
+      end
 
       describe '#edit' do
         it 'gives me the unauthorized page' do
@@ -299,6 +325,18 @@ RSpec.describe Hyrax::FileSetsController do
     let(:private_file_set) { create(:file_set) }
     let(:public_file_set) { create(:file_set, read_groups: ['public']) }
 
+    let(:work) do
+      create(:generic_work, :public,
+             title: ['test title'],
+             user: user)
+    end
+
+    before do
+      work.ordered_members << public_file_set
+      work.save!
+      public_file_set.save!
+    end
+
     describe '#edit' do
       it 'requires login' do
         get :edit, params: { id: public_file_set }

data/spec/controllers/hyrax/generic_works_controller_spec.rb

@@ -55,10 +55,14 @@ RSpec.describe Hyrax::GenericWorksController do
       before { sign_out user }
 
       context "without a referer" do
-        it "sets the default breadcrumbs" do
-          expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+        it "sets breadcrumbs with complete path" do
+          expect(controller).to receive(:add_breadcrumb).with('Home', main_app.root_path(locale: 'en'))
+          expect(controller).not_to receive(:add_breadcrumb).with('Dashboard', hyrax.dashboard_path(locale: 'en'))
+          expect(controller).not_to receive(:add_breadcrumb).with('Your Works', hyrax.my_works_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('public thing', main_app.hyrax_generic_work_path(work.id, locale: 'en'))
           get :show, params: { id: work }
           expect(response).to be_successful
+          expect(response).to render_template("layouts/hyrax/1_column")
         end
       end
 
@@ -91,7 +95,9 @@ RSpec.describe Hyrax::GenericWorksController do
       context "without a referer" do
         it "sets breadcrumbs" do
           expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
-          expect(controller).to receive(:add_breadcrumb).with("Dashboard", hyrax.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Dashboard', hyrax.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Works', hyrax.my_works_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('test title', main_app.hyrax_generic_work_path(work.id, locale: 'en'))
           get :show, params: { id: work }
           expect(response).to be_successful
         end
@@ -171,6 +177,7 @@ RSpec.describe Hyrax::GenericWorksController do
           allow(controller).to receive(:presenter).and_return(presenter)
           allow(presenter).to receive(:export_as_ttl).and_return("ttl graph")
           allow(presenter).to receive(:editor?).and_return(true)
+          allow(presenter).to receive(:to_model).and_return(stub_model(GenericWork))
         end
 
         it 'renders a turtle file' do
@@ -231,6 +238,9 @@ RSpec.describe Hyrax::GenericWorksController do
       end
 
       context 'with a user granted workflow permission' do
+        before do
+          allow(document).to receive(:hydra_model).and_return(GenericWork)
+        end
         let(:document_list) { [document] }
         let(:document) { instance_double(SolrDocument) }