hyrax 2.9.5 → 3.0.0.pre.beta1

data/spec/features/dashboard/display_admin_dashboard_spec.rb

@@ -0,0 +1,29 @@
+RSpec.describe "The dashboard as viewed by a admin user", type: :feature do
+  before do
+    sign_in create(:admin)
+  end
+
+  context "upon sign-in" do
+    it "shows the admin user's information" do
+      expect(page).to have_content "Dashboard"
+      expect(page).to have_content "Registered Users"
+      expect(page).to have_content "Total Visitors"
+      expect(page).to have_content "Returning Visitors"
+      expect(page).to have_content "New Visitors"
+      expect(page).to have_content "Administrative Sets"
+      expect(page).to have_content "Recent activity"
+      expect(page).to have_content "Administrative Set"
+      expect(page).to have_content "User Activity"
+      expect(page).to have_content "Repository Growth"
+      expect(page).to have_content "Repository Objects"
+
+      within '.sidebar' do
+        expect(page).to have_link "Works"
+        expect(page).to have_link "Collections"
+        expect(page).to have_content "Review Submissions"
+        expect(page).to have_content "Manage Embargoes"
+        expect(page).to have_content "Manage Leases"
+      end
+    end
+  end
+end

data/spec/features/dashboard/display_dashboard_spec.rb

@@ -0,0 +1,18 @@
+RSpec.describe "The dashboard as viewed by a regular user", type: :feature do
+  before do
+    sign_in
+  end
+
+  context "upon sign-in" do
+    it "shows the user's information" do
+      expect(page).to have_content "Dashboard"
+      expect(page).to have_content "User Activity"
+      expect(page).to have_content "User Notifications"
+
+      within '.sidebar' do
+        expect(page).to have_link "Works"
+        expect(page).to have_link "Collections"
+      end
+    end
+  end
+end

data/spec/features/delete_work_spec.rb

@@ -0,0 +1,23 @@
+RSpec.describe 'Deleting a work', type: :feature do
+  let(:user) { create(:user) }
+  let(:work) { build(:work, user: user) }
+  let(:file_set) { create(:file_set, user: user, title: ['ABC123xyz']) }
+  let(:file) { File.open(fixture_path + '/world.png') }
+
+  before do
+    sign_in user
+    Hydra::Works::AddFileToFileSet.call(file_set, file, :original_file)
+    work.ordered_members << file_set
+    work.read_groups = []
+    work.save!
+  end
+
+  context 'After deleting a work from the work show page' do
+    it 'redirects to my dashboard' do
+      visit hyrax_generic_work_path(work)
+      click_on('Delete', match: :first)
+      expect(page).to have_current_path(hyrax.my_works_path, only_path: true)
+      expect(page).to have_content 'Deleted Test title'
+    end
+  end
+end

data/spec/features/edit_content_block_admin_spec.rb

@@ -0,0 +1,62 @@
+RSpec.describe 'Editing content blocks as admin', :js do
+  let(:user) { create(:admin) }
+
+  context 'when user wants to change tabs' do
+    let!(:confirm_modal_text) { 'Are you sure you want to leave this tab?  Any unsaved data will be lost.' }
+
+    before do
+      sign_in user
+      visit '/dashboard'
+      click_link 'Settings'
+      click_link 'Content Blocks'
+    end
+
+    it "does not display a confirmation message when form data has not changed" do
+      expect(page).to have_content('Content Blocks')
+      expect(page).to have_content('Announcement')
+      click_link 'Marketing Text'
+      expect(page).not_to have_content(confirm_modal_text)
+    end
+
+    it "displays a confirmation message when form data has changed" do
+      expect(page).to have_content('Content Blocks')
+      expect(page).to have_content('Announcement')
+      expect(page).to have_selector('#content_block_announcement_ifr')
+      within_frame('content_block_announcement_ifr') do
+        find('body').set('Updated text.')
+      end
+      click_link 'Marketing Text'
+      within('#nav-safety-modal') do
+        expect(page).to have_content(confirm_modal_text)
+      end
+    end
+
+    it "does not change tab when user dismisses the confirmation" do
+      expect(page).to have_selector('#announcement_text', class: 'active')
+      expect(page).not_to have_selector('#marketing', class: 'active')
+      within_frame('content_block_announcement_ifr') do
+        find('body').set('Updated text.')
+      end
+      click_link 'Marketing Text'
+      within('#nav-safety-modal') do
+        click_button('OK')
+      end
+      expect(page).not_to have_selector('#marketing', class: 'active')
+      expect(page).to have_selector('#announcement_text', class: 'active')
+    end
+
+    it "does not redisplay the confirmation unless form data is changed" do
+      expect(page).to have_selector('#announcement_text', class: 'active')
+      expect(page).not_to have_selector('#marketing', class: 'active')
+      within_frame('content_block_announcement_ifr') do
+        find('body').set('Updated text.')
+      end
+      click_link 'Marketing Text'
+      within('#nav-safety-modal') do
+        click_button('OK')
+      end
+      click_link 'Marketing Text'
+      expect(page).not_to have_content(confirm_modal_text)
+    end
+  end
+end

data/spec/features/edit_file_spec.rb

@@ -0,0 +1,23 @@
+RSpec.describe "Editing a file:", type: :feature do
+  let(:user) { create(:user) }
+  let(:file_title) { 'Some kind of title' }
+  let(:work) { build(:work, user: user) }
+  let(:file_set) { create(:file_set, user: user, title: [file_title]) }
+  let(:file) { File.open(fixture_path + '/world.png') }
+
+  before do
+    sign_in user
+    Hydra::Works::AddFileToFileSet.call(file_set, file, :original_file)
+    work.ordered_members << file_set
+    work.save!
+  end
+
+  context 'when the user tries to update file content, but forgets to select a file:' do
+    it 'shows the edit page again' do
+      visit edit_hyrax_file_set_path(file_set)
+      click_link 'Versions'
+      click_button 'Upload New Version'
+      expect(page).to have_content "Edit #{file_title}"
+    end
+  end
+end

data/spec/features/edit_work_spec.rb

@@ -0,0 +1,61 @@
+RSpec.describe 'Editing a work', type: :feature do
+  let(:user) { create(:user) }
+  let(:work) { build(:work, user: user, admin_set: another_admin_set) }
+  let(:default_admin_set) do
+    create(:admin_set, id: AdminSet::DEFAULT_ID,
+                       title: ["Default Admin Set"],
+                       description: ["A description"],
+                       edit_users: [user.user_key])
+  end
+  let(:another_admin_set) do
+    create(:admin_set, title: ["Another Admin Set"],
+                       description: ["A description"],
+                       edit_users: [user.user_key])
+  end
+
+  before do
+    sign_in user
+    work.ordered_members << create(:file_set, user: user, title: ['ABC123xyz'])
+    work.read_groups = []
+    work.save!
+  end
+
+  context 'when the user changes permissions' do
+    let(:work) { create(:private_work, user: user, admin_set: default_admin_set) }
+
+    it 'confirms copying permissions to files using Hyrax layout and shows updated value', with_nested_reindexing: true do
+      # e.g. /concern/generic_works/jq085k20z/edit
+      visit edit_hyrax_generic_work_path(work)
+      choose('generic_work_visibility_open')
+      check('agreement')
+      click_on('Save')
+      expect(page).to have_content 'Apply changes to contents?'
+      expect(page).not_to have_content "Powered by Hyrax"
+      click_on("No. I'll update it manually.")
+      within(".work-title-wrapper") do
+        expect(page).to have_content('Public')
+      end
+    end
+  end
+
+  context 'when form loads' do
+    before do
+      create(:permission_template_access,
+             :deposit,
+             permission_template: create(:permission_template, source_id: default_admin_set.id, with_admin_set: true, with_active_workflow: true),
+             agent_type: 'user',
+             agent_id: user.user_key)
+      create(:permission_template_access,
+             :deposit,
+             permission_template: create(:permission_template, source_id: another_admin_set.id, with_admin_set: true, with_active_workflow: true),
+             agent_type: 'user',
+             agent_id: user.user_key)
+    end
+
+    it 'selects admin set already assigned' do
+      visit edit_hyrax_generic_work_path(work)
+      click_link "Relationships" # switch tab
+      expect(page).to have_select('generic_work_admin_set_id', selected: another_admin_set.title)
+    end
+  end
+end

data/spec/features/embargo_spec.rb

@@ -0,0 +1,90 @@
+RSpec.describe 'embargo' do
+  let(:user) { create(:user) }
+
+  before do
+    sign_in user
+  end
+  describe 'creating an embargoed object' do
+    let(:future_date) { 5.days.from_now }
+    let(:later_future_date) { 10.days.from_now }
+
+    it 'can be created, displayed and updated', :clean_repo, :workflow do
+      visit '/concern/generic_works/new'
+      fill_in 'Title', with: 'Embargo test'
+      choose 'Embargo'
+      fill_in 'generic_work_embargo_release_date', with: future_date
+      select 'Private', from: 'Restricted to'
+      select 'Public', from: 'then open it up to'
+      click_button 'Save'
+
+      # chosen embargo date is on the show page
+      expect(page).to have_content(future_date.to_date.to_formatted_s(:standard))
+
+      click_link 'Edit'
+      click_link 'Embargo Management Page'
+
+      expect(page).to have_content('This Generic Work is under embargo.')
+      expect(page).to have_xpath("//input[@name='generic_work[embargo_release_date]' and @value='#{future_date.to_datetime.iso8601}']") # current embargo date is pre-populated in edit field
+
+      fill_in 'until', with: later_future_date.to_s
+
+      click_button 'Update Embargo'
+      expect(page).to have_content(later_future_date.to_date.to_formatted_s(:standard))
+    end
+  end
+
+  describe 'updating embargoed object' do
+    let(:my_admin_set) do
+      create(:admin_set,
+             title: ['admin set with embargo range'],
+             with_permission_template: { release_period: "6mos", with_active_workflow: true })
+    end
+    let(:default_admin_set) do
+      create(:admin_set, id: AdminSet::DEFAULT_ID,
+                         title: ["Default Admin Set"],
+                         description: ["A description"],
+                         with_permission_template: {})
+    end
+    let(:future_date) { 5.days.from_now }
+    let(:later_future_date) { 10.days.from_now }
+    let(:invalid_future_date) { 185.days.from_now } # More than 6 months
+    let(:admin) { create(:admin) }
+    let(:work) do
+      create(:work, title: ['embargoed work1'],
+                    embargo_release_date: future_date.to_datetime.iso8601,
+                    admin_set_id: my_admin_set.id,
+                    edit_users: [user])
+    end
+
+    it 'can be updated with a valid date' do
+      visit "/concern/generic_works/#{work.id}"
+
+      click_link 'Edit'
+      click_link 'Embargo Management Page'
+
+      expect(page).to have_content('This Generic Work is under embargo.')
+      expect(page).to have_xpath("//input[@name='generic_work[embargo_release_date]' and @value='#{future_date.to_datetime.iso8601}']") # current embargo date is pre-populated in edit field
+
+      fill_in 'until', with: later_future_date.to_s
+
+      click_button 'Update Embargo'
+      expect(page).to have_content(later_future_date.to_date.to_formatted_s(:standard))
+      expect(page).to have_content(my_admin_set.title.first)
+    end
+
+    it 'cannot be updated with an invalid date' do
+      visit "/concern/generic_works/#{work.id}"
+
+      click_link 'Edit'
+      click_link 'Embargo Management Page'
+
+      expect(page).to have_content('This Generic Work is under embargo.')
+      expect(page).to have_xpath("//input[@name='generic_work[embargo_release_date]' and @value='#{future_date.to_datetime.iso8601}']") # current embargo date is pre-populated in edit field
+
+      fill_in 'until', with: invalid_future_date.to_s
+
+      click_button 'Update Embargo'
+      expect(page).to have_content('Release date specified does not match permission template release requirements for selected AdminSet.')
+    end
+  end
+end

data/spec/features/homepage_spec.rb

@@ -0,0 +1,43 @@
+RSpec.describe "The homepage", :clean_repo do
+  let(:work1) { create(:work, :public, title: ["Work 1"], date_uploaded: (DateTime.current - 1.day)) }
+  let(:work2) { create(:work, :public, title: ["Work 2"], date_uploaded: (DateTime.current - 1.year)) }
+
+  before do
+    create(:featured_work, work_id: work1.id)
+  end
+
+  it 'shows featured works' do
+    visit root_path
+    expect(page).to have_link work1.title.first
+  end
+
+  it 'shows recently uploaded' do
+    visit root_path
+    click_link("Recently Uploaded")
+    within '#recently_uploaded' do
+      # Expect to see the one with "date uploaded" of yesterday
+      expect(page).to have_link work1.title.first
+      # Do not expect to see the one with "date uploaded" of last year.
+      expect(page).not_to have_link work2.title.first
+      # Expect the system create of work2 to be later than that of work1.
+      # This helps verify that 'recently uploaded' is looking at
+      # 'date_uploaded_dtsi'  and not 'system_create_dtsi'.
+      expect(DateTime.parse(work2.to_solr['system_create_dtsi']).getlocal).to be >= DateTime.parse(work1.to_solr['system_create_dtsi']).getlocal
+    end
+  end
+
+  context "as an admin" do
+    let(:user) { create(:admin) }
+
+    before do
+      sign_in user
+    end
+
+    it 'shows featured works that I can sort' do
+      visit root_path
+      within '.dd-item' do
+        expect(page).to have_link work1.title.first
+      end
+    end
+  end
+end

data/spec/features/lease_spec.rb

@@ -0,0 +1,35 @@
+RSpec.describe 'leases' do
+  let(:user) { create(:user) }
+
+  before do
+    sign_in user
+  end
+  describe 'create a new leased object' do
+    let(:future_date) { 5.days.from_now }
+    let(:later_future_date) { 10.days.from_now }
+
+    it 'can be created, displayed and updated', :clean_repo, :workflow do
+      visit '/concern/generic_works/new'
+      fill_in 'Title', with: 'Lease test'
+      choose 'Lease'
+      fill_in 'generic_work_lease_expiration_date', with: future_date
+      select 'Public', from: 'Is available to'
+      select 'Private', from: 'then restrict it to'
+      click_button 'Save'
+
+      # chosen lease date is on the show page
+      expect(page).to have_content(future_date.to_date.to_formatted_s(:standard))
+
+      click_link 'Edit'
+      click_link 'Lease Management Page'
+
+      expect(page).to have_content('This Generic Work is under lease.')
+      expect(page).to have_xpath("//input[@name='generic_work[lease_expiration_date]' and @value='#{future_date.to_datetime.iso8601}']") # current lease date is pre-populated in edit field
+
+      fill_in 'until', with: later_future_date.to_s
+
+      click_button 'Update Lease'
+      expect(page).to have_content(later_future_date.to_date.to_formatted_s(:standard)) # new lease date is displayed in message
+    end
+  end
+end

data/spec/features/notifications_spec.rb

@@ -0,0 +1,20 @@
+RSpec.describe "Notifications page", type: :feature do
+  before do
+    sign_in create(:user_with_mail)
+    visit "/notifications"
+  end
+
+  it "lists notifications with date, subject and message" do
+    expect(page).to have_content "Notifications"
+    expect(page).to have_selector "table.datatable"
+    expect(page.find(:xpath, '//thead/tr')).to have_content "Date"
+    expect(page.find(:xpath, '//thead/tr')).to have_content "Subject"
+    expect(page.find(:xpath, '//thead/tr')).to have_content "Message"
+    expect(page).to have_content "These files could not be updated. You do not have sufficient privileges to edit them. "
+    expect(page).to have_content "These files have been saved"
+    expect(page).to have_content "File 1 could not be updated. You do not have sufficient privileges to edit it."
+    expect(page).to have_content "File 1 has been saved"
+    expect(page).to have_content "Batch upload permission denied  "
+    expect(page).to have_content "Batch upload complete"
+  end
+end

data/spec/features/ownership_transfer_spec.rb

@@ -0,0 +1,101 @@
+RSpec.describe 'Transferring work ownership:', type: :feature do
+  include Selectors::Dashboard
+  include Selectors::NewTransfers
+  include Selectors::Transfers
+
+  let(:original_owner) { create(:user) }
+  let(:new_owner) { create(:user) }
+  let!(:work) do
+    create(:public_work,
+           title: ['little_generic_work'],
+           creator: ['little_generic_work.creator'],
+           resource_type: ["stuff"],
+           user: original_owner)
+  end
+
+  describe 'When I request a work transfer:', :js do
+    before do
+      sign_in original_owner
+    end
+
+    context 'To myself' do
+      before { transfer_ownership_of_work work, original_owner }
+      it 'displays an appropriate error message' do
+        expect(page).to have_content 'specify a different user to receive the work'
+      end
+    end
+
+    context 'To someone else' do
+      before { transfer_ownership_of_work work, new_owner }
+
+      it 'Creates a transfer request' do
+        expect(page).to have_content 'Transfer request created'
+      end
+
+      context 'If the new owner accepts it' do
+        before do
+          expect(page).to have_content('Transfer request created')
+          new_owner.proxy_deposit_requests.last.transfer!
+          # refresh the page
+          visit '/dashboard'
+        end
+        it 'I should see it was accepted' do
+          expect(page.find('#outgoing-transfers')).to have_content 'Accepted'
+        end
+      end
+
+      context 'If I cancel it' do
+        before do
+          accept_confirm { first_sent_cancel_button.click }
+        end
+        it 'I should see it was cancelled' do
+          expect(page).to have_content 'Transfer canceled'
+        end
+      end
+    end
+  end
+
+  describe 'When someone requests a work transfer to me', :js do
+    before do
+      # As the original_owner, transfer a work to the new_owner
+      ProxyDepositRequest.create!(work_id: work.id,
+                                  sending_user: original_owner,
+                                  transfer_to: new_owner.user_key)
+
+      # Become the new_owner so we can manage transfers sent to us
+      sign_in new_owner
+      visit '/dashboard'
+      expect(page).to have_content 'Transfers of Ownership'
+    end
+
+    it 'I should be able to accept it' do
+      within('#notifications') do
+        expect(page).to have_content "#{original_owner.name} wants to transfer a work to you"
+      end
+      first_received_accept_dropdown.click
+      click_link 'Allow depositor to retain edit access'
+      expect(page).to have_content 'Transfer complete'
+    end
+
+    it 'I should be able to reject it' do
+      within('#notifications') do
+        expect(page).to have_content "#{original_owner.name} wants to transfer a work to you"
+      end
+      accept_confirm { first_received_reject_button.click }
+      expect(page).to have_content 'Transfer rejected'
+    end
+  end
+
+  def transfer_ownership_of_work(work, new_owner)
+    visit '/dashboard/my/works'
+
+    db_item_actions_toggle(work).click
+    click_link 'Transfer Ownership of Work'
+    expect(page).to have_content I18n.t(:'hyrax.transfers.new.sr_only_description', work_title: work.title.first)
+    new_owner_dropdown.click
+    new_owner_search_field.set new_owner.user_key
+    new_owner_search_result.click
+    fill_in 'proxy_deposit_request[sender_comment]', with: 'Work transfer comments'
+    accept_confirm { click_button "Transfer" }
+  end
+end