hyrax 2.9.5 → 3.0.0.pre.beta1

data/spec/features/collection_spec.rb

@@ -0,0 +1,122 @@
+RSpec.describe 'collection', type: :feature, clean_repo: true do
+  let(:user) { create(:user) }
+
+  let(:collection1) { create(:public_collection, user: user) }
+  let(:collection2) { create(:public_collection, user: user) }
+
+  describe 'collection show page' do
+    let(:collection) do
+      create(:public_collection, user: user, description: ['collection description'], collection_type_settings: :nestable)
+    end
+    let!(:work1) { create(:work, title: ["King Louie"], member_of_collections: [collection], user: user) }
+    let!(:work2) { create(:work, title: ["King Kong"], member_of_collections: [collection], user: user) }
+    let!(:col1) { create(:public_collection, title: ["Sub-collection 1"], member_of_collections: [collection], user: user) }
+    let!(:col2) { create(:public_collection, title: ["Sub-collection 2"], member_of_collections: [collection], user: user) }
+
+    before do
+      sign_in user
+      visit "/collections/#{collection.id}"
+    end
+
+    it "shows a collection with a listing of Descriptive Metadata and catalog-style search results" do
+      expect(page).to have_content(collection.title.first)
+      expect(page).to have_content(collection.description.first)
+      expect(page).to have_content("Collection Details")
+      # Should not show title and description a second time
+      expect(page).not_to have_css('.metadata-collections', text: collection.title.first)
+      expect(page).not_to have_css('.metadata-collections', text: collection.description.first)
+      # Should have search results / contents listing
+      expect(page).to have_content(work1.title.first)
+      expect(page).to have_content(work2.title.first)
+      expect(page).to have_content(col1.title.first)
+      expect(page).to have_content(col2.title.first)
+      expect(page).not_to have_css(".pagination")
+
+      click_link "Gallery"
+      expect(page).to have_content(work1.title.first)
+      expect(page).to have_content(work2.title.first)
+    end
+
+    it "hides collection descriptive metadata when searching a collection" do
+      expect(page).to have_content(collection.title.first)
+      expect(page).to have_content(collection.description.first)
+      expect(page).to have_content(work1.title.first)
+      expect(page).to have_content(work2.title.first)
+      fill_in('collection_search', with: work1.title.first)
+      click_button('collection_submit')
+      # Should not have Collection metadata table (only title and description)
+      expect(page).not_to have_content("Total works")
+      expect(page).to have_content(collection.title.first)
+      expect(page).to have_content(collection.description.first)
+      # Should have search results / contents listing
+      expect(page).to have_content("Search Results")
+      expect(page).to have_content(work1.title.first)
+      expect(page).not_to have_content(work2.title.first)
+    end
+
+    it "returns json results" do
+      visit "/collections/#{collection.id}.json"
+      expect(page).to have_http_status(:success)
+      json = JSON.parse(page.body)
+      expect(json['id']).to eq collection.id
+      expect(json['title']).to match_array collection.title
+    end
+
+    context "with a non-nestable collection type" do
+      let(:collection) do
+        build(:public_collection_lw, user: user, description: ['collection description'], collection_type_settings: :not_nestable, with_solr_document: true, with_permission_template: true)
+      end
+
+      it "displays basic information on its show page" do
+        expect(page).to have_content(collection.title.first)
+        expect(page).to have_content(collection.description.first)
+        expect(page).to have_content("Collection Details")
+      end
+    end
+  end
+
+  # TODO: this is just like the block above. Merge them.
+  describe 'show work pages of a collection' do
+    before do
+      docs = (0..12).map do |n|
+        { "has_model_ssim" => ["GenericWork"], :id => "zs25x871q#{n}",
+          "depositor_ssim" => [user.user_key],
+          "suppressed_bsi" => false,
+          "member_of_collection_ids_ssim" => [collection.id],
+          "nesting_collection__parent_ids_ssim" => [collection.id],
+          "edit_access_person_ssim" => [user.user_key] }
+      end
+      ActiveFedora::SolrService.add(docs, commit: true)
+
+      sign_in user
+    end
+    let(:collection) { create(:named_collection, user: user) }
+
+    it "shows a collection with a listing of Descriptive Metadata and catalog-style search results" do
+      visit "/collections/#{collection.id}"
+      expect(page).to have_css(".pagination")
+    end
+  end
+
+  describe 'show subcollection pages of a collection' do
+    before do
+      docs = (0..12).map do |n|
+        { "has_model_ssim" => ["Collection"], :id => "zs25x871q#{n}",
+          "depositor_ssim" => [user.user_key],
+          "suppressed_bsi" => false,
+          "member_of_collection_ids_ssim" => [collection.id],
+          "nesting_collection__parent_ids_ssim" => [collection.id],
+          "edit_access_person_ssim" => [user.user_key] }
+      end
+      ActiveFedora::SolrService.add(docs, commit: true)
+
+      sign_in user
+    end
+    let(:collection) { create(:named_collection, user: user) }
+
+    it "shows a collection with a listing of Descriptive Metadata and catalog-style search results" do
+      visit "/collections/#{collection.id}"
+      expect(page).to have_css(".pagination")
+    end
+  end
+end

data/spec/features/collection_type_spec.rb

@@ -0,0 +1,393 @@
+RSpec.describe 'collection_type', type: :feature, clean_repo: true do
+  let(:admin_user) { create(:admin) }
+  let(:exhibit_title) { 'Exhibit' }
+  let(:exhibit_description) { 'Description for exhibit collection type.' }
+  let(:exhibit_collection_type) { create(:collection_type, title: exhibit_title, description: exhibit_description, creator_user: admin_user) }
+  let(:user_collection_type) { create(:user_collection_type) }
+  let(:admin_set_type) { create(:admin_set_collection_type) }
+  let(:solr_gid) { Collection.collection_type_gid_document_field_name }
+
+  describe 'index' do
+    before do
+      exhibit_collection_type
+      user_collection_type
+      admin_set_type
+      sign_in admin_user
+      visit '/admin/collection_types'
+    end
+
+    it 'has page title and lists collection types' do
+      expect(page).to have_content 'Collection Types'
+
+      expect(page).to have_content 'Admin Set'
+      expect(page).to have_content 'User Collection'
+      expect(page).to have_content 'Collection Type'
+
+      expect(page).to have_link('Edit', count: 3)
+      expect(page).to have_link('Edit', href: hyrax.edit_admin_collection_type_path(admin_set_type.id, locale: 'en'))
+      expect(page).to have_link('Edit', href: hyrax.edit_admin_collection_type_path(user_collection_type.id, locale: 'en'))
+      expect(page).to have_link('Edit', href: hyrax.edit_admin_collection_type_path(exhibit_collection_type.id, locale: 'en'))
+      expect(page).to have_button('Delete', count: 2) # 1: Collection Type, 2: delete modal
+    end
+  end
+
+  describe 'create collection type' do
+    let(:title) { 'Test Type' }
+    let(:description) { 'Description for collection type we are testing.' }
+
+    before do
+      sign_in admin_user
+      visit '/admin/collection_types'
+    end
+
+    it 'makes a new collection type', :js do
+      click_link 'Create new collection type'
+
+      expect(page).to have_content 'Create New Collection Type'
+
+      # confirm only Description tab is visible
+      expect(page).to have_link('Description', href: '#metadata')
+      expect(page).not_to have_link('Settings', href: '#settings')
+      expect(page).not_to have_link('Participants', href: '#participants')
+
+      # confirm metadata fields exist
+      expect(page).to have_selector 'input#collection_type_title'
+      expect(page).to have_selector 'textarea#collection_type_description'
+
+      # set values and save
+      fill_in('Type name', with: title)
+      fill_in('Type description', with: description)
+
+      click_button('Save')
+
+      # confirm values were set
+      expect(page).to have_selector "input#collection_type_title[value='#{title}']"
+      expect(page).to have_selector 'textarea#collection_type_description', text: description
+
+      # confirm all edit tabs are now visible
+      expect(page).to have_link('Description', href: '#metadata')
+      expect(page).to have_link('Settings', href: '#settings')
+      expect(page).to have_link('Participants', href: '#participants')
+    end
+
+    it 'tries to make a collection type with existing title, and receives error message', :js do
+      click_link 'Create new collection type'
+
+      expect(page).to have_content 'Create New Collection Type'
+
+      # confirm only Description tab is visible
+      expect(page).to have_link('Description', href: '#metadata')
+      expect(page).not_to have_link('Settings', href: '#settings')
+      expect(page).not_to have_link('Participants', href: '#participants')
+
+      # confirm metadata fields exist
+      expect(page).to have_selector 'input#collection_type_title'
+      expect(page).to have_selector 'textarea#collection_type_description'
+
+      # set values and save
+      fill_in('Type name', with: title)
+      fill_in('Type description', with: description)
+
+      click_button('Save')
+
+      visit '/admin/collection_types'
+      click_link 'Create new collection type'
+
+      expect(page).to have_content 'Create New Collection Type'
+
+      # confirm only Description tab is visible
+      expect(page).to have_link('Description', href: '#metadata')
+      expect(page).not_to have_link('Settings', href: '#settings')
+      expect(page).not_to have_link('Participants', href: '#participants')
+
+      # confirm metadata fields exist
+      expect(page).to have_selector 'input#collection_type_title'
+      expect(page).to have_selector 'textarea#collection_type_description'
+
+      # set values and save
+      fill_in('Type name', with: title)
+      fill_in('Type description', with: description)
+
+      click_button('Save')
+
+      # Confirm error message is displayed.
+      expect(page).to have_content 'Save was not successful because title has already been taken, and machine_id has already been taken.'
+    end
+  end
+
+  describe 'edit collection type' do
+    context 'when there are no collections of this type' do
+      let(:title_old) { exhibit_title }
+      let(:description_old) { exhibit_description }
+      let(:title_new) { 'Exhibit modified' }
+      let(:description_new) { 'Change in description for exhibit collection type.' }
+
+      before do
+        exhibit_collection_type
+        sign_in admin_user
+        visit "/admin/collection_types/#{exhibit_collection_type.id}/edit"
+      end
+
+      it 'modifies metadata values of a collection type', :js do
+        expect(page).to have_content "Edit Collection Type: #{title_old}"
+
+        # confirm all tabs are visible
+        expect(page).to have_link('Description', href: '#metadata')
+        expect(page).to have_link('Settings', href: '#settings')
+        expect(page).to have_link('Participants', href: '#participants')
+
+        # confirm metadata fields have original values
+        expect(page).to have_selector "input#collection_type_title[value='#{title_old}']"
+        expect(page).to have_selector 'textarea#collection_type_description', text: description_old
+
+        # set values and save
+        fill_in('Type name', with: title_new)
+        fill_in('Type description', with: description_new)
+
+        click_button('Save changes')
+
+        expect(page).to have_content "Edit Collection Type: #{title_new}"
+
+        # confirm values were set
+        expect(page).to have_selector "input#collection_type_title[value='#{title_new}']"
+        expect(page).to have_selector 'textarea#collection_type_description', text: description_new
+
+        click_link('Settings', href: '#settings')
+
+        # confirm all non-admin_set checkboxes are on
+        expect(page).to have_checked_field('collection_type_nestable')
+        expect(page).to have_checked_field('collection_type_brandable')
+        expect(page).to have_checked_field('collection_type_discoverable')
+        expect(page).to have_checked_field('collection_type_sharable')
+        expect(page).to have_checked_field('collection_type_share_applies_to_new_works')
+        expect(page).to have_checked_field('collection_type_allow_multiple_membership')
+
+        # confirm all admin_set only checkboxes are off and disabled
+        expect(page).to have_unchecked_field('collection_type_require_membership', disabled: true)
+        expect(page).to have_unchecked_field('collection_type_assigns_workflow', disabled: true)
+        expect(page).to have_unchecked_field('collection_type_assigns_visibility', disabled: true)
+
+        # change settings
+        page.uncheck('NESTING')
+        page.uncheck('DISCOVERY')
+        page.check('APPLY TO NEW WORKS')
+        page.uncheck('MULTIPLE MEMBERSHIP')
+
+        # confirm all non-admin_set checkboxes are now off
+        expect(page).to have_unchecked_field('collection_type_nestable')
+        expect(page).to have_checked_field('collection_type_brandable')
+        expect(page).to have_unchecked_field('collection_type_discoverable')
+        expect(page).to have_checked_field('collection_type_sharable')
+        expect(page).to have_checked_field('collection_type_share_applies_to_new_works')
+        expect(page).to have_unchecked_field('collection_type_allow_multiple_membership')
+
+        # uncheck sharable should disable sharable options
+        page.uncheck('SHARING')
+
+        expect(page).to have_unchecked_field('collection_type_sharable')
+        expect(page).to have_unchecked_field('collection_type_share_applies_to_new_works', disabled: true)
+
+        # check sharable should enable sharable options
+        page.check('SHARING')
+
+        expect(page).to have_checked_field('collection_type_sharable')
+        expect(page).to have_unchecked_field('collection_type_share_applies_to_new_works', disabled: false)
+
+        click_link('Participants')
+
+        # TODO: Test adding participants
+      end
+
+      context 'when editing default user collection type' do
+        let(:title_old) { user_collection_type.title }
+        let(:description_old) { user_collection_type.description }
+        let(:title_new) { 'User Collection modified' }
+        let(:description_new) { 'Change in description for user collection type.' }
+
+        before do
+          user_collection_type
+          sign_in admin_user
+          visit "/admin/collection_types/#{user_collection_type.id}/edit"
+        end
+
+        it 'allows editing of metadata, but not settings', :js do
+          expect(page).to have_content "Edit Collection Type: #{title_old}"
+
+          # confirm metadata fields have original values
+          expect(page).to have_selector "input#collection_type_title[value='#{title_old}']"
+          expect(page).to have_selector 'textarea#collection_type_description', text: description_old
+
+          # set values and save
+          fill_in('Type name', with: title_new)
+          fill_in('Type description', with: description_new)
+
+          click_button('Save changes')
+
+          expect(page).to have_content "Edit Collection Type: #{title_new}"
+
+          # confirm values were set
+          expect(page).to have_selector "input#collection_type_title[value='#{title_new}']"
+          expect(page).to have_selector 'textarea#collection_type_description', text: description_new
+
+          click_link('Settings', href: '#settings')
+
+          # confirm default user collection checkboxes are set to appropriate values
+          expect(page).to have_checked_field('collection_type_nestable', disabled: true)
+          expect(page).to have_checked_field('collection_type_brandable', disabled: true)
+          expect(page).to have_checked_field('collection_type_discoverable', disabled: true)
+          expect(page).to have_checked_field('collection_type_sharable', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_share_applies_to_new_works', disabled: true)
+          expect(page).to have_checked_field('collection_type_allow_multiple_membership', disabled: true)
+
+          # confirm all admin_set only checkboxes are off and disabled
+          expect(page).to have_unchecked_field('collection_type_require_membership', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_assigns_workflow', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_assigns_visibility', disabled: true)
+        end
+      end
+
+      context 'when editing admin set collection type' do
+        let(:title_old) { admin_set_type.title }
+        let(:description_old) { admin_set_type.description }
+        let(:description_new) { 'Change in description for admin set collection type.' }
+
+        before do
+          admin_set_type
+          sign_in admin_user
+          visit "/admin/collection_types/#{admin_set_type.id}/edit"
+        end
+
+        it 'allows editing of metadata except title, but not settings', :js do
+          expect(page).to have_content "Edit Collection Type: #{title_old}"
+
+          # confirm metadata fields have original values
+          expect(page).to have_field("collection_type_title", disabled: true)
+          expect(page).to have_selector 'textarea#collection_type_description', text: description_old
+
+          # set values and save
+          fill_in('Type description', with: description_new)
+
+          click_button('Save changes')
+
+          expect(page).to have_content "Edit Collection Type: #{title_old}"
+
+          # confirm values were set
+          expect(page).to have_selector 'textarea#collection_type_description', text: description_new
+
+          click_link('Settings', href: '#settings')
+
+          # confirm default user collection checkboxes are set to appropriate values
+          expect(page).to have_unchecked_field('collection_type_nestable', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_discoverable', disabled: true)
+          expect(page).to have_checked_field('collection_type_sharable', disabled: true)
+          expect(page).to have_checked_field('collection_type_share_applies_to_new_works', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_allow_multiple_membership', disabled: true)
+
+          # confirm all admin_set only checkboxes are off and disabled
+          expect(page).to have_checked_field('collection_type_require_membership', disabled: true)
+          expect(page).to have_checked_field('collection_type_assigns_workflow', disabled: true)
+          expect(page).to have_checked_field('collection_type_assigns_visibility', disabled: true)
+        end
+      end
+    end
+
+    context 'when collections exist of this type' do
+      let!(:collection1) { create(:public_collection, user: build(:user), collection_type_gid: exhibit_collection_type.gid) }
+
+      before do
+        exhibit_collection_type
+        sign_in admin_user
+        visit "/admin/collection_types/#{exhibit_collection_type.id}/edit"
+      end
+
+      it 'all settings are disabled', :js do
+        expect(exhibit_collection_type.collections?).to be true
+
+        click_link('Settings', href: '#settings')
+
+        # confirm all checkboxes are disabled
+        expect(page).to have_field('collection_type_nestable', disabled: true)
+        expect(page).to have_field('collection_type_brandable', disabled: true)
+        expect(page).to have_field('collection_type_discoverable', disabled: true)
+        expect(page).to have_field('collection_type_sharable', disabled: true)
+        expect(page).to have_field('collection_type_share_applies_to_new_works', disabled: true)
+        expect(page).to have_field('collection_type_allow_multiple_membership', disabled: true)
+        expect(page).to have_field('collection_type_require_membership', disabled: true)
+        expect(page).to have_field('collection_type_assigns_workflow', disabled: true)
+        expect(page).to have_field('collection_type_assigns_visibility', disabled: true)
+      end
+    end
+  end
+
+  describe 'delete collection type' do
+    context 'when there are no collections of this type' do
+      let!(:empty_collection_type) { create(:collection_type, title: 'Empty Type', creator_user: admin_user) }
+      let!(:delete_modal_text) { 'Deleting this collection type will permanently remove the type and its settings from the repository.  Are you sure you want to delete this collection type?' }
+      let!(:deleted_flash_text) { "The collection type #{empty_collection_type.title} has been deleted." }
+
+      before do
+        sign_in admin_user
+        visit '/admin/collection_types'
+      end
+
+      it 'shows warning, deletes collection type, and shows flash message on success', :js do
+        expect(page).to have_content(empty_collection_type.title)
+
+        find(:xpath, "//tr[td[contains(.,'#{empty_collection_type.title}')]]/td/button", text: 'Delete').click
+
+        within('div#deleteModal') do
+          expect(page).to have_content(delete_modal_text)
+          click_button('Delete')
+        end
+
+        within('.alert-success') do
+          expect(page).to have_content(deleted_flash_text)
+        end
+
+        within('.collection-types-table') do
+          expect(page).not_to have_content(empty_collection_type.title)
+        end
+      end
+    end
+
+    context 'when collections exist of this type' do
+      let!(:not_empty_collection_type) { create(:collection_type, title: 'Not Empty Type', creator_user: admin_user) }
+      let!(:collection1) { create(:public_collection, user: admin_user, collection_type_gid: not_empty_collection_type.gid) }
+      let(:deny_delete_modal_text) do
+        'You cannot delete this collection type because one or more collections of this type have already been created. ' \
+        'To delete this collection type, first ensure that all collections of this type have been deleted.'
+      end
+
+      before do
+        sign_in admin_user
+        visit '/admin/collection_types'
+      end
+
+      it 'shows unable to delete dialog and forwards to All Collections with filter applied', :js do
+        expect(page).to have_content(not_empty_collection_type.title)
+
+        find(:xpath, "//tr[td[contains(.,'#{not_empty_collection_type.title}')]]/td/button", text: 'Delete').click
+
+        within('div#deleteDenyModal') do
+          expect(page).to have_content(deny_delete_modal_text)
+          click_link('View collections of this type')
+        end
+
+        # forwards to Dashboard -> Collections -> All Collections
+        within('li.active') do
+          expect(page).to have_link('All Collections')
+        end
+
+        # filter is applied
+        within('div#appliedParams') do
+          expect(page).to have_content('Filtering by:')
+          expect(page).to have_content('Type')
+          expect(page).to have_content(not_empty_collection_type.title)
+        end
+
+        # collection of this type is in the list of collections
+        expect(page).to have_content(collection1.title.first)
+      end
+    end
+  end
+end