hyrax 2.3.3 → 2.4.0

data/spec/views/hyrax/admin/admin_sets/index.html.erb_spec.rb

@@ -13,8 +13,12 @@ RSpec.describe "hyrax/admin/admin_sets/index.html.erb", type: :view do
   end
 
   context "when an admin set exists" do
-    let(:admin_set) { build(:admin_set, id: '123', title: ['Example Admin Set'], creator: ['jdoe@example.com']) }
-    let(:solr_doc) { SolrDocument.new(admin_set.to_solr) }
+    let(:solr_doc) do
+      SolrDocument.new(has_model_ssim: 'AdminSet',
+                       id: 123,
+                       title_tesim: ['Example Admin Set'],
+                       creator_ssim: ['jdoe@example.com'])
+    end
     let(:admin_sets) { [solr_doc] }
     let(:presenter_class) { Hyrax::AdminSetPresenter }
     let(:presenter) { instance_double(presenter_class, total_items: 99) }

data/spec/views/hyrax/admin/admin_sets/index.json.erb_spec.rb

@@ -8,8 +8,7 @@ RSpec.describe "hyrax/admin/admin_sets/index.json.jbuilder" do
   end
 
   context "when an admin set exists" do
-    let(:admin_set) { build(:admin_set, id: '123', title: ['Example Admin Set'], creator: ['jdoe@example.com'], description: ['Wat']) }
-    let(:solr_doc) { SolrDocument.new(admin_set.to_solr) }
+    let(:solr_doc) { SolrDocument.new(id: '123', title_tesim: ['Example Admin Set'], description_tesim: ['Wat']) }
     let(:admin_sets) { [solr_doc] }
     let(:presenter_class) { Hyrax::AdminSetPresenter }
     let(:presenter) { instance_double(presenter_class, total_items: 99) }

data/spec/views/hyrax/admin/collection_types/_form_metadata_admin_set.html.erb_spec.rb

@@ -1,5 +1,5 @@
 RSpec.describe 'hyrax/admin/collection_types/_form_metadata_admin_set.html.erb', type: :view do
-  let(:collection_type) { create(:admin_set_collection_type) }
+  let(:collection_type) { stub_model(Hyrax::CollectionType) }
   let(:collection_type_form) { Hyrax::Forms::Admin::CollectionTypeForm.new }
 
   let(:form) do

data/spec/views/hyrax/admin/collection_types/_form_settings.html.erb_spec.rb

@@ -14,6 +14,7 @@ RSpec.describe 'hyrax/admin/collection_types/_form_settings.html.erb', type: :vi
   ].freeze
 
   let(:collection_type_form) { Hyrax::Forms::Admin::CollectionTypeForm.new }
+  let(:collection_type) { stub_model(Hyrax::CollectionType) }
 
   let(:form) do
     view.simple_form_for(collection_type, url: '/update') do |fs_form|
@@ -22,16 +23,14 @@ RSpec.describe 'hyrax/admin/collection_types/_form_settings.html.erb', type: :vi
   end
 
   before do
+    collection_type_form.collection_type = collection_type
     allow(view).to receive(:f).and_return(form)
     allow(form).to receive(:object).and_return(collection_type_form)
   end
 
   context 'for non-special collection types' do
-    let(:collection_type) { create(:collection_type) }
-
     context "when collection_type.collections? is false" do
       before do
-        collection_type_form.collection_type = collection_type
         allow(collection_type).to receive(:collections?).and_return(false)
         render
       end
@@ -69,35 +68,15 @@ RSpec.describe 'hyrax/admin/collection_types/_form_settings.html.erb', type: :vi
     end
   end
 
-  context 'for admin set collection type' do
-    let(:collection_type) { create(:admin_set_collection_type) }
-
-    before do
-      collection_type_form.collection_type = collection_type
-      allow(collection_type).to receive(:collections?).and_return(false)
-      render
-    end
-
-    INPUT_IDS.each do |id|
-      it "renders the #{id} checkbox to be disabled" do
-        match = rendered.match(/(<input.*id="#{id}".*)/)
-        expect(match).not_to be_nil
-        expect(match[1].index('disabled="disabled"')).not_to be_nil
-      end
-    end
-  end
-
-  context 'for user collection type' do
-    let(:collection_type) { create(:user_collection_type) }
-
+  context 'when all_settings_disabled? is true (admin_set or user collection type)' do
     before do
-      collection_type_form.collection_type = collection_type
+      allow(collection_type_form).to receive(:all_settings_disabled?).and_return(true)
       allow(collection_type).to receive(:collections?).and_return(false)
       render
     end
 
     INPUT_IDS.each do |id|
-      it "renders the #{id} checkbox to be disabled" do
+      it "renders the disabled #{id} checkbox " do
         match = rendered.match(/(<input.*id="#{id}".*)/)
         expect(match).not_to be_nil
         expect(match[1].index('disabled="disabled"')).not_to be_nil

data/spec/views/hyrax/admin/collection_types/index.html.erb_spec.rb

@@ -1,12 +1,33 @@
 require 'spec_helper'
 
-RSpec.describe 'hyrax/admin/collection_types/index.html.erb', type: :view, clean_repo: true do
+RSpec.describe 'hyrax/admin/collection_types/index.html.erb', type: :view do
+  let(:user_collection_type) do
+    stub_model(Hyrax::CollectionType,
+               collections?: false,
+               title: 'User Collection')
+  end
+  let(:admin_set_collection_type) do
+    stub_model(Hyrax::CollectionType,
+               collections?: false,
+               title: 'Admin Set')
+  end
+  let(:custom1) do
+    stub_model(Hyrax::CollectionType,
+               collections?: false,
+               title: 'Test Title 1')
+  end
+  let(:custom2) do
+    stub_model(Hyrax::CollectionType,
+               collections?: false,
+               title: 'Test Title 2')
+  end
+
   before do
     assign(:collection_types, [
-             create(:user_collection_type),
-             create(:admin_set_collection_type),
-             FactoryBot.create(:collection_type, title: 'Test Title 1'),
-             FactoryBot.create(:collection_type, title: 'Test Title 2')
+             user_collection_type,
+             admin_set_collection_type,
+             custom1,
+             custom2
            ])
     render
   end

data/spec/views/hyrax/admin/stats/show.html.erb_spec.rb

@@ -12,6 +12,7 @@ RSpec.describe "hyrax/admin/stats/show.html.erb", type: :view do
 
   context 'locales' do
     before do
+      allow(presenter).to receive(:active_users).and_return([])
       render
     end
     it 'includes a default locale hidden input' do

data/spec/views/hyrax/base/_attribute_rows.html.erb_spec.rb

@@ -7,7 +7,11 @@ RSpec.describe 'hyrax/base/_attribute_rows.html.erb', type: :view do
                related_url: [url],
                rights_statement: [rights_statement_uri])
   end
-  let(:solr_document) { SolrDocument.new(work.to_solr) }
+  let(:solr_document) do
+    SolrDocument.new(has_model_ssim: 'GenericWork',
+                     rights_statement_tesim: [rights_statement_uri],
+                     related_url_tesim: [url])
+  end
   let(:presenter) { Hyrax::WorkShowPresenter.new(solr_document, ability) }
 
   let(:page) do

data/spec/views/hyrax/base/_attributes.html.erb_spec.rb

@@ -21,6 +21,7 @@ RSpec.describe 'hyrax/base/_attributes.html.erb' do
   let(:doc) { Nokogiri::HTML(rendered) }
 
   before do
+    allow(presenter).to receive(:member_of_collection_presenters).and_return([])
     allow(view).to receive(:dom_class) { '' }
 
     render 'hyrax/base/attributes', presenter: presenter

data/spec/views/hyrax/base/_form_rendering.html.erb_spec.rb

@@ -1,6 +1,6 @@
 RSpec.describe 'hyrax/base/_form_rendering.html.erb', type: :view do
   let(:ability) { double }
-  let(:work) { create(:work_with_one_file) }
+  let(:work) { stub_model(GenericWork, new_record?: false) }
   let(:form) do
     Hyrax::GenericWorkForm.new(work, ability, controller)
   end
@@ -12,6 +12,10 @@ RSpec.describe 'hyrax/base/_form_rendering.html.erb', type: :view do
     Capybara::Node::Simple.new(rendered)
   end
 
+  before do
+    allow(form).to receive(:select_files).and_return([{ '123' => 'File one' }])
+  end
+
   it 'has a rendering_ids field' do
     expect(page).to have_selector("select#generic_work_rendering_ids", count: 1)
   end

data/spec/views/hyrax/base/_items.html.erb_spec.rb

@@ -40,6 +40,8 @@ RSpec.describe 'hyrax/base/_items.html.erb', type: :view do
       expect(Flipflop).to receive(:hide_private_items?).and_return(:flipflop)
       allow(presenter).to receive(:list_of_item_ids_to_display).and_return(member_list)
       allow(presenter).to receive(:member_presenters_for).with(member_list).and_return(member_list)
+      allow(presenter).to receive(:ordered_ids).and_return([])
+
       allow(ability).to receive(:can?).with(:read, child1.id).and_return true
       allow(ability).to receive(:can?).with(:read, child2.id).and_return false
       allow(ability).to receive(:can?).with(:read, child3.id).and_return true

data/spec/views/hyrax/base/_relationships.html.erb_spec.rb

@@ -77,13 +77,14 @@ RSpec.describe 'hyrax/base/relationships', type: :view do
     it "renders using attribute_to_html" do
       allow(controller).to receive(:current_user).and_return(user)
       allow(solr_doc).to receive(:member_of_collection_ids).and_return([])
+      allow(presenter).to receive(:grouped_presenters).and_return({})
       expect(presenter).to receive(:attribute_to_html).with(:admin_set, render_as: :faceted, html_dl: true)
       render 'hyrax/base/relationships', presenter: presenter
     end
 
     it "skips admin sets if user not logged in" do
       allow(controller).to receive(:current_user).and_return(nil)
-      allow(solr_doc).to receive(:member_of_collection_ids).and_return([])
+      allow(presenter).to receive(:member_of_collection_presenters).and_return([])
       expect(presenter).not_to receive(:attribute_to_html).with(:admin_set, render_as: :faceted)
       render 'hyrax/base/relationships', presenter: presenter
     end

data/spec/views/hyrax/base/_show_actions.html.erb_spec.rb

@@ -13,6 +13,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
 
   context "as an unregistered user" do
     before do
+      allow(presenter).to receive(:show_deposit_for?).with(anything).and_return(false)
       allow(presenter).to receive(:editor?).and_return(false)
       render 'hyrax/base/show_actions.html.erb', presenter: presenter
     end
@@ -25,6 +26,7 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
 
   context "as an editor" do
     before do
+      allow(presenter).to receive(:show_deposit_for?).with(anything).and_return(true)
       allow(presenter).to receive(:editor?).and_return(true)
     end
     context "when the work does not contain children" do
@@ -75,4 +77,73 @@ RSpec.describe 'hyrax/base/_show_actions.html.erb', type: :view do
       end
     end
   end
+
+  context "when user CAN deposit to at least one collection" do
+    before do
+      allow(presenter).to receive(:show_deposit_for?).with(anything).and_return(true)
+      allow(presenter).to receive(:member_presenters).and_return([])
+    end
+
+    context "and user is editor" do
+      before do
+        allow(presenter).to receive(:editor?).and_return(true)
+        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+      end
+
+      it "shows editor related buttons" do
+        expect(rendered).not_to have_link 'File Manager'
+        expect(rendered).to have_link 'Edit'
+        expect(rendered).to have_link 'Delete'
+        expect(rendered).to have_button 'Add to collection'
+      end
+    end
+
+    context "and user is viewer" do
+      before do
+        allow(presenter).to receive(:editor?).and_return(false)
+        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+      end
+      it "shows only Add to collection link" do
+        expect(rendered).not_to have_link 'File Manager'
+        expect(rendered).not_to have_link 'Edit'
+        expect(rendered).not_to have_link 'Delete'
+        expect(rendered).to have_button 'Add to collection'
+      end
+    end
+  end
+
+  context "when user can NOT deposit to any collections" do
+    before do
+      allow(presenter).to receive(:show_deposit_for?).with(anything).and_return(false)
+      allow(presenter).to receive(:member_presenters).and_return([])
+    end
+
+    context "and user is editor" do
+      before do
+        allow(presenter).to receive(:editor?).and_return(true)
+        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+      end
+
+      it "shows editor related buttons" do
+        expect(rendered).not_to have_link 'File Manager'
+        expect(rendered).to have_link 'Edit'
+        expect(rendered).to have_link 'Delete'
+        expect(rendered).not_to have_button 'Add to collection'
+      end
+    end
+
+    context "and user is viewer" do
+      before do
+        allow(presenter).to receive(:editor?).and_return(false)
+        render 'hyrax/base/show_actions.html.erb', presenter: presenter
+      end
+
+      it "shows only Add to collection link" do
+        expect(rendered).not_to have_link 'File Manager'
+        expect(rendered).not_to have_link 'Edit'
+        expect(rendered).not_to have_link 'Delete'
+        expect(rendered).not_to have_button 'Add to collection'
+      end
+    end
+  end
 end

data/spec/views/hyrax/base/file_manager.html.erb_spec.rb

@@ -4,27 +4,24 @@ RSpec.describe "hyrax/base/file_manager.html.erb" do
   let(:member) { Hyrax::WorkShowPresenter.new(solr_doc_work, nil) }
   let(:solr_doc) do
     SolrDocument.new(
-      resource.to_solr.merge(
-        id: "test",
-        title_tesim: ["Test"],
-        thumbnail_path_ss: "/test/image/path.jpg",
-        label_tesim: ["file_name.tif"]
-      )
+      id: "test",
+      title_tesim: ["Test"],
+      thumbnail_path_ss: "/test/image/path.jpg",
+      label_tesim: ["file_name.tif"],
+      has_model_ssim: 'FileSet'
     )
   end
   let(:solr_doc_work) do
     SolrDocument.new(
-      resource.to_solr.merge(
-        id: "work",
-        title_tesim: ["Work"],
-        thumbnail_path_ss: "/test/image/path.jpg",
-        label_tesim: ["work"]
-      )
+      id: "work",
+      has_model_ssim: 'GenericWork',
+      title_tesim: ["Work"],
+      thumbnail_path_ss: "/test/image/path.jpg",
+      label_tesim: ["work"]
     )
   end
-  let(:resource) { build(:file_set) }
 
-  let(:parent) { build(:generic_work) }
+  let(:parent) { stub_model(GenericWork, title: ["Test title"]) }
 
   let(:form) do
     Hyrax::Forms::FileManagerForm.new(parent, nil)

data/spec/views/hyrax/base/show.html.erb_spec.rb

@@ -69,9 +69,9 @@ RSpec.describe 'hyrax/base/show.html.erb', type: :view do
     expect(page).to have_content 'Foobar'
   end
 
-  describe 'UniversalViewer integration' do
+  describe 'IIIF viewer integration' do
     before do
-      allow(presenter).to receive(:universal_viewer?).and_return(viewer_enabled)
+      allow(presenter).to receive(:iiif_viewer?).and_return(viewer_enabled)
       render template: 'hyrax/base/show.html.erb'
     end
 

data/spec/views/hyrax/base/show.json.jbuilder_spec.rb

@@ -1,5 +1,7 @@
 RSpec.describe 'hyrax/base/show.json.jbuilder' do
-  let(:curation_concern) { build(:generic_work) }
+  let(:curation_concern) do
+    stub_model(GenericWork, title: ['Test title'])
+  end
 
   before do
     allow(curation_concern).to receive(:etag).and_return('W/"87f79d2244ded4239ad1f0e822c8429b1e72b66c"')

data/spec/views/hyrax/collections/_show_document_list_row.html.erb_spec.rb

@@ -2,7 +2,12 @@ RSpec.describe 'hyrax/collections/_show_document_list_row.html.erb', type: :view
   let(:user) { create(:user) }
 
   let(:work) do
-    create(:work, user: user, creator: ["ggm"], title: ['One Hundred Years of Solitude'])
+    mock_model(GenericWork, label: 'One Hundred Years of Solitude', date_uploaded: '1999',
+                            collection?: true, visibility: 'open',
+                            title: ['One Hundred Years of Solitude'],
+                            depositor: user,
+                            edit_groups: [],
+                            creator: ["ggm"])
   end
 
   let(:collection) { mock_model(Collection, title: 'My awesome collection', members: [work]) }

data/spec/views/hyrax/collections/_show_parent_collections.html.erb_spec.rb

@@ -11,11 +11,11 @@ RSpec.describe 'hyrax/collections/_show_parent_collections.html.erb', type: :vie
   let(:ability) { double }
   let(:solr_document) { SolrDocument.new(collection_doc) }
   let(:presenter) { Hyrax::CollectionPresenter.new(solr_document, ability) }
-  let(:collection1) { build(:collection, id: 'col1', title: ['col1']) }
-  let(:collection2) { build(:collection, id: 'col2', title: ['col2']) }
-  let(:collection3) { build(:collection, id: 'col3', title: ['col3']) }
-  let(:collection4) { build(:collection, id: 'col4', title: ['col4']) }
-  let(:collection5) { build(:collection, id: 'col5', title: ['col5']) }
+  let(:collection1) { stub_model(Collection, id: 'col1', title: ['col1']) }
+  let(:collection2) { stub_model(Collection, id: 'col2', title: ['col2']) }
+  let(:collection3) { stub_model(Collection, id: 'col3', title: ['col3']) }
+  let(:collection4) { stub_model(Collection, id: 'col4', title: ['col4']) }
+  let(:collection5) { stub_model(Collection, id: 'col5', title: ['col5']) }
   let(:parent_collections) { double(Object, documents: parent_docs, response: { "numFound" => parent_docs.size }, total_pages: 1) }
 
   before do

data/spec/views/hyrax/collections/_subcollection_list.html.erb_spec.rb

@@ -1,6 +1,6 @@
 RSpec.describe 'hyrax/collections/_subcollection_list.html.erb', type: :view do
   let(:subject) { render('subcollection_list.html.erb', collection: subcollection) }
-  let(:collection) { build(:named_collection, id: '123') }
+  let(:collection) { stub_model(Collection, id: '123') }
 
   context 'when subcollection list is empty' do
     let(:subcollection) { nil }

data/spec/views/hyrax/collections/show.html.erb_spec.rb

@@ -16,11 +16,12 @@ RSpec.describe 'hyrax/collections/show.html.erb', type: :view do
     allow(view).to receive(:can?).with(:destroy, document).and_return(false)
     allow(presenter).to receive(:collection_type_is_nestable?).and_return(true)
     allow(presenter).to receive(:total_items).and_return(0)
+    allow(presenter).to receive(:total_viewable_items).and_return(0)
+    allow(presenter).to receive(:banner_file).and_return("banner.gif")
+    allow(presenter).to receive(:logo_record).and_return([{ linkurl: "logo link url", alttext: "logo alt text", file_location: "logo.gif" }])
     assign(:subcollection_count, 0)
     assign(:parent_collection_count, 0)
     assign(:members_count, 0)
-    allow(presenter).to receive(:banner_file).and_return("banner.gif")
-    allow(presenter).to receive(:logo_record).and_return([{ linkurl: "logo link url", alttext: "logo alt text", file_location: "logo.gif" }])
     allow(ability).to receive(:user_groups).and_return([])
     allow(ability).to receive(:current_user).and_return(build(:user, id: nil, email: ""))
     assign(:presenter, presenter)

data/spec/views/hyrax/dashboard/collections/_form_share.erb_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe 'hyrax/dashboard/collections/_form_share.html.erb', type: :view d
                     to_key: template.to_key,
                     access_grants: template.access_grants)
   end
-  let(:collection) { create(:collection, collection_type_settings: :sharable_no_work_permissions) }
+  let(:collection) { stub_model(Collection, share_applies_to_new_works?: false) }
 
   before do
     assign(:collection, collection)

data/spec/views/hyrax/dashboard/collections/_form_share_table.html.erb_spec.rb

@@ -2,7 +2,7 @@ RSpec.describe 'hyrax/dashboard/collections/_form_share_table.html.erb', type: :
   let(:template) { stub_model(Hyrax::PermissionTemplate) }
   let(:user) { create(:user) }
   let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
-  let(:collection) { create(:collection, collection_type_settings: :sharable_no_work_permissions) }
+  let(:collection) { stub_model(Collection, share_applies_to_new_works?: false) }
   let(:pt_form) do
     instance_double(Hyrax::Forms::PermissionTemplateForm,
                     model_name: template.model_name,

data/spec/views/hyrax/dashboard/collections/_show_document_list_row.html.erb_spec.rb

@@ -2,7 +2,12 @@ RSpec.describe 'hyrax/dashboard/collections/_show_document_list_row.html.erb', t
   let(:user) { create(:user) }
 
   let(:work) do
-    create(:work, user: user, creator: ["ggm"], title: ['One Hundred Years of Solitude'])
+    mock_model(GenericWork, label: 'One Hundred Years of Solitude', date_uploaded: '1999',
+                            collection?: true, visibility: 'open',
+                            title: ['One Hundred Years of Solitude'],
+                            depositor: user,
+                            edit_groups: [],
+                            creator: ["ggm"])
   end
 
   let(:collection) { mock_model(Collection, title: 'My awesome collection', members: [work]) }