hyrax 2.3.3 → 2.4.0

data/spec/hyrax/transactions/steps/ensure_admin_set_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'hyrax/transactions'
+
+RSpec.describe Hyrax::Transactions::Steps::EnsureAdminSet do
+  subject(:step) { described_class.new }
+  let(:work)     { build(:generic_work) }
+
+  describe '#call' do
+    context 'without an admin set' do
+      it 'is a failure' do
+        expect(step.call(work).failure).to eq :no_admin_set_id
+      end
+    end
+
+    context 'with an admin set' do
+      let(:admin_set) { create(:admin_set) }
+      let(:work)      { build(:generic_work, admin_set_id: admin_set.id) }
+
+      it 'is a success' do
+        expect(step.call(work)).to be_success
+      end
+    end
+  end
+end

data/spec/hyrax/transactions/steps/ensure_permission_template_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'hyrax/transactions'
+
+RSpec.describe Hyrax::Transactions::Steps::EnsurePermissionTemplate do
+  subject(:step) { described_class.new }
+  let(:work)     { build(:generic_work) }
+
+  describe '#call' do
+    context 'without an admin_set' do
+      it 'is a failure' do
+        expect(step.call(work).failure).to eq :no_permission_template
+      end
+    end
+
+    context 'with an admin_set' do
+      let(:work)      { build(:generic_work, admin_set: admin_set) }
+      let(:admin_set) { create(:admin_set, with_permission_template: true) }
+
+      it 'is success' do
+        expect(step.call(work)).to be_success
+      end
+
+      context 'missing PermissionTemplate' do
+        let(:admin_set) { create(:admin_set, with_permission_template: false) }
+
+        it 'fails with missing template' do
+          expect(step.call(work).failure).to eq :no_permission_template
+        end
+      end
+    end
+  end
+end

data/spec/hyrax/transactions/steps/save_work_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'hyrax/transactions'
+
+RSpec.describe Hyrax::Transactions::Steps::SaveWork do
+  subject(:step) { described_class.new }
+  let(:work)     { build(:generic_work) }
+
+  describe '#call' do
+    it 'is success' do
+      expect(step.call(work)).to be_success
+    end
+
+    it 'persists the work' do
+      expect { step.call(work) }
+        .to change { work.persisted? }
+        .to true
+    end
+
+    context 'if the work is invalid' do
+      let(:work) { build(:invalid_generic_work) }
+
+      it 'returns failure' do
+        expect(step.call(work)).to be_failure
+      end
+
+      it 'gives errors about the work' do
+        expect(step.call(work).failure).to eq work.errors
+      end
+    end
+  end
+end

data/spec/hyrax/transactions/steps/set_default_admin_set_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'hyrax/transactions'
+
+RSpec.describe Hyrax::Transactions::Steps::SetDefaultAdminSet do
+  subject(:step) { described_class.new }
+  let(:work)     { build(:generic_work) }
+
+  describe '#call' do
+    let(:admin_set_id) { AdminSet.find_or_create_default_admin_set_id }
+
+    it 'is success' do
+      expect(step.call(work)).to be_success
+    end
+
+    it 'sets the default admin_set' do
+      expect { step.call(work) }
+        .to change { work.admin_set&.id }
+        .from(nil)
+        .to(admin_set_id)
+    end
+
+    context 'when the work has an admin_set' do
+      let(:admin_set) { create(:admin_set) }
+      let(:work)      { build(:generic_work, admin_set: admin_set) }
+
+      it 'is success' do
+        expect(step.call(work)).to be_success
+      end
+
+      it 'does not change the admin_set' do
+        expect { step.call(work) }
+          .not_to change { work.admin_set&.id }
+          .from(admin_set.id)
+      end
+    end
+  end
+end

data/spec/hyrax/transactions/steps/set_modified_date_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'hyrax/transactions'
+
+RSpec.describe Hyrax::Transactions::Steps::SetModifiedDate do
+  subject(:step) { described_class.new }
+  let(:work)     { build(:generic_work) }
+
+  let(:xmas)     { DateTime.parse('2018-12-25 11:30').iso8601 }
+
+  before { allow(Hyrax::TimeService).to receive(:time_in_utc).and_return(xmas) }
+
+  describe '#call' do
+    it 'is success' do
+      expect(step.call(work)).to be_success
+    end
+
+    it 'sets the modified date' do
+      expect { step.call(work) }.to change { work.date_modified }.to xmas
+    end
+  end
+end

data/spec/hyrax/transactions/steps/set_uploaded_date_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'hyrax/transactions'
+
+RSpec.describe Hyrax::Transactions::Steps::SetUploadedDate do
+  subject(:step) { described_class.new }
+  let(:work)     { build(:generic_work) }
+  let(:xmas)     { DateTime.parse('2018-12-25 11:30').iso8601 }
+
+  before { allow(Hyrax::TimeService).to receive(:time_in_utc).and_return(xmas) }
+
+  describe '#call' do
+    it 'is success' do
+      expect(step.call(work)).to be_success
+    end
+
+    it 'sets the uploaded date' do
+      expect { step.call(work) }.to change { work.date_uploaded }.to xmas
+    end
+
+    context 'when a modified date exists' do
+      let(:work)      { build(:generic_work, date_modified: xmas_past) }
+      let(:xmas_past) { DateTime.parse('2009-12-25 11:30').iso8601 }
+
+      it 'sets the uploaded date to the modified date' do
+        expect { step.call(work) }
+          .to change { work.date_uploaded }
+          .to work.date_modified
+      end
+    end
+  end
+end

data/spec/jobs/attach_files_to_work_with_ordered_members_job_spec.rb

@@ -0,0 +1,13 @@
+RSpec.describe AttachFilesToWorkWithOrderedMembersJob, perform_enqueued: [AttachFilesToWorkWithOrderedMembersJob] do
+  let(:file1) { File.open(fixture_path + '/world.png') }
+  let(:file2) { File.open(fixture_path + '/image.jp2') }
+  let(:uploaded_file1) { build(:uploaded_file, file: file1) }
+  let(:uploaded_file2) { build(:uploaded_file, file: file2) }
+  let(:generic_work) { create(:public_generic_work) }
+
+  it "attaches files and passes ordered_members to OrderedMembersActor" do
+    expect(Hyrax::Actors::OrderedMembersActor).to receive(:new).with([FileSet, FileSet], User).and_return(Hyrax::Actors::OrderedMembersActor)
+    expect(Hyrax::Actors::OrderedMembersActor).to receive(:attach_ordered_members_to_work).with(generic_work)
+    described_class.perform_now(generic_work, [uploaded_file1, uploaded_file2])
+  end
+end

data/spec/presenters/hyrax/presenter_renderer_spec.rb

@@ -1,7 +1,9 @@
 RSpec.describe Hyrax::PresenterRenderer, type: :view do
-  let(:work) { GenericWork.new }
   let(:ability) { double }
-  let(:document) { SolrDocument.new(work.to_solr) }
+  let(:document) { SolrDocument.new(data) }
+  let(:data) do
+    { id: '123', date_created_tesim: 'foo', date_uploaded_tesim: 'bar', has_model_ssim: 'GenericWork' }
+  end
   let(:presenter) { Hyrax::WorkShowPresenter.new(document, ability) }
   let(:renderer) { described_class.new(presenter, view) }
 

data/spec/presenters/hyrax/work_show_presenter_spec.rb

@@ -45,7 +45,7 @@ RSpec.describe Hyrax::WorkShowPresenter do
     it { is_expected.to eq 'http://example.org/concern/generic_works/888888/manifest' }
   end
 
-  describe '#universal_viewer?' do
+  describe '#iiif_viewer?' do
     let(:id_present) { false }
     let(:representative_presenter) { double('representative', present?: false) }
     let(:image_boolean) { false }
@@ -64,7 +64,7 @@ RSpec.describe Hyrax::WorkShowPresenter do
       allow(Hyrax.config).to receive(:iiif_image_server?).and_return(iiif_enabled)
     end
 
-    subject { presenter.universal_viewer? }
+    subject { presenter.iiif_viewer? }
 
     context 'with no representative_id' do
       it { is_expected.to be false }
@@ -533,4 +533,48 @@ RSpec.describe Hyrax::WorkShowPresenter do
       end
     end
   end
+
+  describe "#show_deposit_for?" do
+    subject { presenter }
+
+    context "when user has depositable collections" do
+      let(:user_collections) { double }
+
+      it "returns true" do
+        expect(subject.show_deposit_for?(collections: user_collections)).to be true
+      end
+    end
+
+    context "when user does not have depositable collections" do
+      let(:user_collections) { nil }
+
+      context "and user can create a collection" do
+        before do
+          allow(ability).to receive(:can?).with(:create_any, Collection).and_return(true)
+        end
+
+        it "returns true" do
+          expect(subject.show_deposit_for?(collections: user_collections)).to be true
+        end
+      end
+
+      context "and user can NOT create a collection" do
+        before do
+          allow(ability).to receive(:can?).with(:create_any, Collection).and_return(false)
+        end
+
+        it "returns false" do
+          expect(subject.show_deposit_for?(collections: user_collections)).to be false
+        end
+      end
+    end
+  end
+
+  describe '#iiif_viewer' do
+    subject { presenter.iiif_viewer }
+
+    it 'defaults to universal viewer' do
+      expect(subject).to be :universal_viewer
+    end
+  end
 end

data/spec/services/hyrax/permission_template_applicator_spec.rb

@@ -0,0 +1,69 @@
+RSpec.describe Hyrax::PermissionTemplateApplicator do
+  subject(:applicator) { described_class.new(template: template) }
+  let(:manage_groups)  { ['edit_group_1', 'edit_group_2'] }
+  let(:manage_users)   { ['moomin', 'snork'] }
+  let(:template)       { :not_a_template }
+  let(:view_groups)    { ['read_group_1', 'read_group_2'] }
+  let(:view_users)     { ['snufkin', 'too-ticky'] }
+  let(:work)           { build(:work) }
+
+  describe '.apply' do
+    it 'initializes with template' do
+      expect(described_class.apply(template))
+        .to have_attributes(template: template)
+    end
+  end
+
+  describe '#apply_to' do
+    let(:template) do
+      create(:permission_template,
+             manage_groups: manage_groups,
+             manage_users:  manage_users,
+             view_groups:   view_groups,
+             view_users:    view_users)
+    end
+
+    it 'applies edit groups' do
+      edit_after_application = work.edit_groups + manage_groups
+
+      expect { applicator.apply_to(model: work) }
+        .to change { work.edit_groups }
+        .to contain_exactly(*edit_after_application)
+    end
+
+    it 'applies edit users' do
+      edit_after_application = work.edit_users + manage_users
+
+      expect { applicator.apply_to(model: work) }
+        .to change { work.edit_users }
+        .to contain_exactly(*edit_after_application)
+    end
+
+    it 'applies read groups' do
+      read_after_application = work.read_groups + view_groups
+
+      expect { applicator.apply_to(model: work) }
+        .to change { work.read_groups }
+        .to contain_exactly(*read_after_application)
+    end
+
+    it 'applies read users' do
+      read_after_application = work.read_users + view_users
+
+      expect { applicator.apply_to(model: work) }
+        .to change { work.read_users }
+        .to contain_exactly(*read_after_application)
+    end
+  end
+
+  describe '#template' do
+    let(:new_template) { :not_another_template }
+
+    it 'has a template attribute' do
+      expect { applicator.template = new_template }
+        .to change { applicator.template }
+        .from(template)
+        .to new_template
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -5,6 +5,10 @@ def coverage_needed?
   ENV['COVERAGE'] || ENV['TRAVIS']
 end
 
+def ci_build?
+  ENV['TRAVIS'] || ENV['CIRCLE']
+end
+
 if coverage_needed?
   require 'simplecov'
   require 'coveralls'
@@ -60,7 +64,7 @@ require 'webmock/rspec'
 WebMock.disable_net_connect!(allow_localhost: true)
 
 require 'i18n/debug' if ENV['I18N_DEBUG']
-require 'byebug' unless ENV['TRAVIS']
+require 'byebug' unless ci_build?
 
 # @note In January 2018, TravisCI disabled Chrome sandboxing in its Linux
 #       container build environments to mitigate Meltdown/Spectre
@@ -141,7 +145,7 @@ RSpec.configure do |config|
   config.include Shoulda::Matchers::ActiveRecord, type: :model
   config.include Shoulda::Matchers::ActiveModel, type: :form
   config.include Shoulda::Callback::Matchers::ActiveModel
-  config.full_backtrace = true if ENV['TRAVIS']
+  config.full_backtrace = true if ci_build?
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end
@@ -165,6 +169,13 @@ RSpec.configure do |config|
       DatabaseCleaner.start
     end
 
+    if example.metadata[:type] == :view
+      # View tests should not hit any services. This ensures the tests are unit
+      # testing only the views and run fast.
+      WebMock.disable_net_connect!(allow_localhost: false)
+    else
+      WebMock.disable_net_connect!(allow_localhost: true)
+    end
     # using :workflow is preferable to :clean_repo, use the former if possible
     # It's important that this comes after DatabaseCleaner.start
     ensure_deposit_available_for(user) if example.metadata[:workflow]

data/spec/views/catalog/index.html.erb_spec.rb

@@ -1,6 +1,9 @@
 RSpec.describe 'catalog/index.html.erb', type: :view do
-  let(:collection) { build(:collection, id: "abc123") }
-  let(:doc) { SolrDocument.new(collection.to_solr) }
+  let(:doc) do
+    SolrDocument.new(id: "abc123",
+                     has_model_ssim: ['Collection'],
+                     title_tesim: ['Collection Title 999'])
+  end
 
   before do
     view.extend Hyrax::CollectionsHelper
@@ -30,7 +33,7 @@ RSpec.describe 'catalog/index.html.erb', type: :view do
     before { allow(view).to receive(:can?).and_return(false) }
     it 'appears on page without error' do
       render
-      expect(rendered).to include(collection.title.first)
+      expect(rendered).to include('Collection Title 999')
       page = Capybara::Node::Simple.new(rendered)
       expect(page).to have_selector("span.fa.fa-cubes.collection-icon-search")
     end
@@ -39,7 +42,7 @@ RSpec.describe 'catalog/index.html.erb', type: :view do
     before { allow(view).to receive(:can?).and_return(true) }
     it 'appears on page without error' do
       render
-      expect(rendered).to include(collection.title.first)
+      expect(rendered).to include('Collection Title 999')
       page = Capybara::Node::Simple.new(rendered)
       expect(page).to have_selector("span.fa.fa-cubes.collection-icon-search")
     end

data/spec/views/hyrax/admin/admin_sets/_show_actions.html.erb_spec.rb

@@ -20,6 +20,7 @@ RSpec.describe 'hyrax/admin/admin_sets/_show_actions.html.erb', type: :view do
     context "when presenter has delete disabled" do
       before do
         allow(presenter).to receive(:disable_delete?).and_return(true)
+        allow(presenter).to receive(:disabled_message).and_return('')
         render
       end
       it "displays a disabled delete button" do
@@ -43,6 +44,7 @@ RSpec.describe 'hyrax/admin/admin_sets/_show_actions.html.erb', type: :view do
     context "with default admin set" do
       before do
         allow(presenter).to receive(:disable_delete?).and_return(true)
+        allow(presenter).to receive(:disabled_message).and_return('')
         render
       end
       it "displays a disabled delete button" do

data/spec/views/hyrax/admin/admin_sets/_show_document_list_row.html.erb_spec.rb

@@ -3,13 +3,16 @@ RSpec.describe 'hyrax/admin/admin_sets/_show_document_list_row.html.erb', type:
   let(:ability) { Ability.new(user) }
 
   let(:work) do
-    create(:work, user: user, creator: ["ggm"], title: ['One Hundred Years of Solitude'])
+    stub_model(GenericWork, title: ['One Hundred Years of Solitude'])
   end
 
   before do
     view.blacklight_config = Blacklight::Configuration.new
     allow(controller).to receive(:current_ability).and_return(ability)
     allow(view).to receive(:current_user).and_return(user)
+    allow(view).to receive(:render_collection_links).and_return('')
+    allow(view).to receive(:render_visibility_link).and_return('')
+
     allow(work).to receive(:title_or_label).and_return("One Hundred Years of Solitude")
     allow(work).to receive(:edit_groups).and_return([user])
     allow(work).to receive(:edit_people).and_return([user])