hyrax 2.1.0.beta1 → 2.1.0.beta2

data/hyrax.gemspec

@@ -49,7 +49,7 @@ SUMMARY
   spec.add_dependency 'hydra-editor', '~> 3.3'
   spec.add_dependency 'hydra-head', '>= 10.5.0'
   spec.add_dependency 'hydra-works', '~> 0.16'
-  spec.add_dependency 'iiif_manifest', '~> 0.3.0'
+  spec.add_dependency 'iiif_manifest', '>= 0.3', '< 0.5'
   spec.add_dependency 'jquery-datatables-rails', '~> 3.4'
   spec.add_dependency 'jquery-ui-rails', '~> 6.0'
   spec.add_dependency 'json-schema' # for Arkivo
@@ -83,7 +83,7 @@ SUMMARY
   spec.add_development_dependency 'database_cleaner', '~> 1.3'
   spec.add_development_dependency 'engine_cart', '~> 1.2'
   spec.add_development_dependency "equivalent-xml", '~> 0.5'
-  spec.add_development_dependency "factory_bot_rails", '~> 4.4'
+  spec.add_development_dependency "factory_bot", '~> 4.4'
   spec.add_development_dependency 'fcrepo_wrapper', '~> 0.5', '>= 0.5.1'
   spec.add_development_dependency "jasmine", '~> 2.3', '< 2.99'
   spec.add_development_dependency "jasmine-core", '~> 2.3', '< 2.99'
@@ -93,21 +93,11 @@ SUMMARY
   spec.add_development_dependency 'rspec-rails', '~> 3.1'
   spec.add_development_dependency "selenium-webdriver"
   spec.add_development_dependency 'solr_wrapper', '~> 1.1'
-  # Pin rubocop and rubocop-rspec tightly. Minor-level version bumps
-  # in these gems cause Rubocop violations, and those violations cause
-  # continuous integration builds to fail, and those failures prevent
-  # us from merging pull requests. As a community, we have decided
-  # that it is not reasonable to manage style violations to be dealt
-  # with in a pull request *unless* said pull request's intent is to
-  # bring the codebase in further alignment with community style
-  # conventions. This allows us to take a managed approach to code
-  # style -- we choose to update style when we wish, not when a
-  # minor-level version bump in a dependency comes out.
   spec.add_development_dependency 'i18n-debug' if ENV['I18N_DEBUG']
   spec.add_development_dependency 'i18n_yaml_sorter' unless ENV['TRAVIS']
   spec.add_development_dependency 'rails-controller-testing', '~> 1'
-  spec.add_development_dependency 'rubocop', '~> 0.51.0'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.20.1'
+  # the hyrax style guide is based on `bixby`. see `.rubocop.yml`
+  spec.add_development_dependency 'bixby', '~> 1.0.0'
   spec.add_development_dependency 'shoulda-callback-matchers', '~> 1.1.1'
   spec.add_development_dependency 'shoulda-matchers', '~> 3.1'
   spec.add_development_dependency 'webmock'
@@ -115,8 +105,7 @@ SUMMARY
   ########################################################
   # Temporarily pinned dependencies. INCLUDE EXPLANATIONS.
   #
-  # simple_form 3.5.1 broke local and Travis builds in bad ways for unknown reasons
-  spec.add_dependency 'simple_form', '=3.5.0'
-  # parser 2.5.0.0 broke local and Travis rubocop checks due to a change in parsing
-  spec.add_development_dependency 'parser', '< 2.5'
+  # simple_form 3.5.1 broke hydra-editor for certain model types;
+  #   see: https://github.com/plataformatec/simple_form/issues/1549
+  spec.add_dependency 'simple_form', '~> 3.2', '<= 3.5.0'
 end

data/lib/generators/hyrax/models_generator.rb

@@ -17,7 +17,6 @@ class Hyrax::ModelsGenerator < Rails::Generators::Base
   end
 
   # Add behaviors to the user model
-  # rubocop:disable Metrics/MethodLength
   def inject_user_behavior
     file_path = "app/models/#{model_name.underscore}.rb"
     if File.exist?(file_path)

data/lib/generators/hyrax/templates/db/migrate/20180302200051_add_branding_to_collection_type.rb.erb

@@ -0,0 +1,5 @@
+class AddBrandingToCollectionType < ActiveRecord::Migration<%= migration_version %>
+  def change
+    add_column :hyrax_collection_types, :brandable, :boolean, null: false, default: true
+  end
+end

data/lib/generators/hyrax/work/templates/feature_spec.rb.erb

@@ -13,7 +13,7 @@ RSpec.feature 'Create a <%= class_name %>', js: false do
       User.new(user_attributes) { |u| u.save(validate: false) }
     end
     let(:admin_set_id) { AdminSet.find_or_create_default_admin_set_id }
-    let(:permission_template) { Hyrax::PermissionTemplate.find_or_create_by!(admin_set_id: admin_set_id) }
+    let(:permission_template) { Hyrax::PermissionTemplate.find_or_create_by!(source_id: admin_set_id) }
     let(:workflow) { Sipity::Workflow.create!(active: true, name: 'test-workflow', permission_template: permission_template) }
 
     before do

data/lib/hyrax/configuration.rb

@@ -118,7 +118,7 @@ module Hyrax
 
     attr_writer :noid_minter_class
     def noid_minter_class
-      @noid_minter_class ||= Noid::Rails::Minter::Db
+      @noid_minter_class ||= ::Noid::Rails::Minter::Db
     end
 
     attr_writer :minter_statefile
@@ -206,9 +206,7 @@ module Hyrax
     # @param [Array<Symbol>,Symbol] curation_concern_types
     def register_curation_concern(*curation_concern_types)
       Array.wrap(curation_concern_types).flatten.compact.each do |cc_type|
-        unless @registered_concerns.include?(cc_type)
-          @registered_concerns << cc_type
-        end
+        @registered_concerns << cc_type unless @registered_concerns.include?(cc_type)
       end
     end
 

data/lib/hyrax/engine.rb

@@ -32,10 +32,28 @@ module Hyrax
     end
 
     config.after_initialize do
-      begin
+      # Attempt to establish a connection before trying to do anything with it. This has to rescue
+      # StandardError instead of, e.g., ActiveRecord::ConnectionNotEstablished or ActiveRecord::NoDatabaseError
+      # because we can't be absolutely sure what the specific database adapter will raise. pg, for example,
+      # raises PG::ConnectionBad. There's no good common ancestor to assume. That's why this test
+      # is in its own tiny chunk of code – so we know that whatever the StandardError is, it's coming
+      # from the attempt to connect.
+      can_connect = begin
+        ActiveRecord::Base.connection
+        true
+      rescue StandardError
+        false
+      end
+
+      can_persist = can_connect && begin
         Hyrax.config.persist_registered_roles!
         Rails.logger.info("Hyrax::Engine.after_initialize - persisting registered roles!")
+        true
       rescue ActiveRecord::StatementInvalid
+        false
+      end
+
+      unless can_persist
         message = "Hyrax::Engine.after_initialize - unable to persist registered roles.\n"
         message += "It is expected during the application installation - during integration tests, rails install.\n"
         message += "It is UNEXPECTED if you are booting up a Hyrax powered application via `rails server'"
@@ -72,9 +90,9 @@ module Hyrax
         ActiveFedora::Base.translate_uri_to_id = c.translate_uri_to_id
         ActiveFedora::Base.translate_id_to_uri = c.translate_id_to_uri
 
-        Noid::Rails.config.template = c.noid_template
-        Noid::Rails.config.minter_class = c.noid_minter_class
-        Noid::Rails.config.statefile = c.minter_statefile
+        ::Noid::Rails.config.template = c.noid_template
+        ::Noid::Rails.config.minter_class = c.noid_minter_class
+        ::Noid::Rails.config.statefile = c.minter_statefile
       end
     end
 

data/lib/hyrax/version.rb

@@ -1,3 +1,3 @@
 module Hyrax
-  VERSION = '2.1.0.beta1'.freeze
+  VERSION = '2.1.0.beta2'.freeze
 end

data/spec/actors/hyrax/actors/lease_actor_spec.rb

@@ -35,4 +35,20 @@ RSpec.describe Hyrax::Actors::LeaseActor do
       end
     end
   end
+
+  context 'deactivating an expired lease', clean_repo: true do
+    let(:lease_attributes) do
+      { lease_date: Date.tomorrow.to_s,
+        current_state: Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC,
+        future_state: Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED }
+    end
+    let(:leased_work) { create(:leased_work, with_lease_attributes: lease_attributes) }
+    let(:subject) { described_class.new(leased_work) }
+
+    it 'destroys and reindexes the new permission appropriately in solr', with_nested_reindexing: true do
+      allow(leased_work.lease).to receive(:active?).and_return false
+      subject.destroy
+      expect(::SolrDocument.find(leased_work.id)[:visibility_ssi]).to eq(Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED)
+    end
+  end
 end

data/spec/controllers/hyrax/admin/appearances_controller_spec.rb

@@ -20,7 +20,7 @@ RSpec.describe Hyrax::Admin::AppearancesController do
 
       it "is successful" do
         expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
-        expect(controller).to receive(:add_breadcrumb).with('Administration', dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
         expect(controller).to receive(:add_breadcrumb).with('Configuration', '#')
         expect(controller).to receive(:add_breadcrumb).with('Appearance', "/admin/appearance")
         get :show

data/spec/controllers/hyrax/admin/collection_types_controller_spec.rb

@@ -102,6 +102,7 @@ RSpec.describe Hyrax::Admin::CollectionTypesController, type: :controller, clean
         nestable: true,
         discoverable: true,
         sharable: true,
+        brandable: true,
         share_applies_to_new_works: true,
         allow_multiple_membership: true,
         require_membership: true,
@@ -241,6 +242,7 @@ RSpec.describe Hyrax::Admin::CollectionTypesController, type: :controller, clean
           nestable: false,
           discoverable: false,
           sharable: false,
+          brandable: false,
           share_applies_to_new_works: false,
           allow_multiple_membership: false,
           require_membership: true,

data/spec/controllers/hyrax/admin/features_controller_spec.rb

@@ -20,7 +20,7 @@ RSpec.describe Hyrax::Admin::FeaturesController do
 
       it "is successful" do
         expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
-        expect(controller).to receive(:add_breadcrumb).with('Administration', dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
         expect(controller).to receive(:add_breadcrumb).with('Configuration', '#')
         expect(controller).to receive(:add_breadcrumb).with('Features', admin_features_path)
         get :index

data/spec/controllers/hyrax/admin/workflow_roles_controller_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Hyrax::Admin::WorkflowRolesController do
 
       it "is successful" do
         expect(controller).to receive(:add_breadcrumb).with('Home', root_path(locale: 'en'))
-        expect(controller).to receive(:add_breadcrumb).with('Administration', dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path(locale: 'en'))
         expect(controller).to receive(:add_breadcrumb).with('Workflow Roles', admin_workflow_roles_path(locale: 'en'))
         get :index
         expect(response).to be_success

data/spec/controllers/hyrax/admin/workflows_controller_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Hyrax::Admin::WorkflowsController do
     end
     it "is successful" do
       expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
-      expect(controller).to receive(:add_breadcrumb).with('Administration', dashboard_path)
+      expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
       expect(controller).to receive(:add_breadcrumb).with('Tasks', '#')
       expect(controller).to receive(:add_breadcrumb).with('Review Submissions', "/admin/workflows")
 

data/spec/controllers/hyrax/batch_edits_controller_spec.rb

@@ -20,10 +20,12 @@ RSpec.describe Hyrax::BatchEditsController, type: :controller do
     end
 
     it "is successful" do
+      expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
       expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
       expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.my.works'), Hyrax::Engine.routes.url_helpers.my_works_path(locale: 'en'))
       get :edit
       expect(response).to be_successful
+      expect(response).to render_template('dashboard')
       expect(assigns[:form].model.creator).to match_array ["Fred", "Wilma"]
     end
   end
@@ -42,9 +44,16 @@ RSpec.describe Hyrax::BatchEditsController, type: :controller do
       create(:work, creator: ["Fred"], title: ["abc"], language: ['en'])
     end
 
+    let!(:file_set) do
+      create(:file_set, creator: ["Fred"])
+    end
+
     let(:mycontroller) { "hyrax/my/works" }
 
     before do
+      one.members << file_set
+      one.save!
+
       # TODO: why aren't we just submitting batch_document_ids[] as a parameter?
       controller.batch = [one.id, two.id, three.id]
       expect(controller).to receive(:can?).with(:edit, one.id).and_return(true)
@@ -76,7 +85,11 @@ RSpec.describe Hyrax::BatchEditsController, type: :controller do
     it "updates permissions" do
       put :update, params: { update_type: "update", visibility: "authenticated" }
       expect(response).to be_redirect
-      expect(GenericWork.find(one.id).visibility).to eq "authenticated"
+
+      work1 = GenericWork.find(one.id)
+      expect(work1.visibility).to eq "authenticated"
+      expect(work1.file_sets.map(&:visibility)).to eq ["authenticated"]
+
       expect(GenericWork.find(two.id).visibility).to eq "authenticated"
       expect(GenericWork.find(three.id).visibility).to eq "restricted"
     end

data/spec/controllers/hyrax/batch_uploads_controller_spec.rb

@@ -105,10 +105,10 @@ RSpec.describe Hyrax::BatchUploadsController do
         }
       end
 
-      it 'redirects to my shares page' do
+      it 'redirects to managed works page' do
         allow(BatchCreateJob).to receive(:perform_later)
         post :create, params: post_params
-        expect(response).to redirect_to Hyrax::Engine.routes.url_helpers.dashboard_shares_path(locale: 'en')
+        expect(response).to redirect_to Hyrax::Engine.routes.url_helpers.dashboard_works_path(locale: 'en')
       end
     end
   end

data/spec/controllers/hyrax/citations_controller_spec.rb

@@ -11,7 +11,8 @@ RSpec.describe Hyrax::CitationsController do
       end
 
       it "is successful" do
-        expect(controller).to receive(:add_breadcrumb).with('My Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
         get :work, params: { id: work }
         expect(response).to be_successful
         expect(response).to render_template('layouts/hyrax/1_column')
@@ -39,7 +40,8 @@ RSpec.describe Hyrax::CitationsController do
       end
 
       it "is successful" do
-        expect(controller).to receive(:add_breadcrumb).with('My Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
         get :file, params: { id: file_set }
         expect(response).to be_successful
         expect(response).to render_template('layouts/hyrax/1_column')

data/spec/controllers/hyrax/collections_controller_spec.rb

@@ -30,7 +30,8 @@ RSpec.describe Hyrax::CollectionsController do
         end
       end
 
-      it "returns the collection and its members", :with_nested_reindexing do # rubocop:disable RSpec/ExampleLength
+      it "returns the collection and its members" do # rubocop:disable RSpec/ExampleLength
+        expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
         expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
         get :show, params: { id: collection }
         expect(response).to be_successful
@@ -43,7 +44,7 @@ RSpec.describe Hyrax::CollectionsController do
         expect(assigns[:subcollection_count]).to eq(2)
       end
 
-      context "and searching", :with_nested_reindexing do
+      context "and searching" do
         it "returns some works and subcollections" do
           # "/collections/4m90dv529?utf8=%E2%9C%93&cq=King+Louie&sort="
           get :show, params: { id: collection, cq: "Second" }
@@ -66,6 +67,7 @@ RSpec.describe Hyrax::CollectionsController do
 
       context "without a referer" do
         it "sets breadcrumbs" do
+          expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
           expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
           get :show, params: { id: collection }
           expect(response).to be_successful
@@ -78,8 +80,9 @@ RSpec.describe Hyrax::CollectionsController do
         end
 
         it "sets breadcrumbs" do
-          expect(controller).to receive(:add_breadcrumb).with('My Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
-          expect(controller).to receive(:add_breadcrumb).with('Your Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
           expect(controller).to receive(:add_breadcrumb).with('My collection', collection_path(collection.id, locale: 'en'))
           get :show, params: { id: collection }
           expect(response).to be_successful
@@ -94,5 +97,30 @@ RSpec.describe Hyrax::CollectionsController do
         expect(assigns[:subcollection_docs].count).to eq 0
       end
     end
+
+    context "without a referer" do
+      it "sets breadcrumbs" do
+        expect(controller).not_to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).not_to receive(:add_breadcrumb).with('Your Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+        expect(controller).not_to receive(:add_breadcrumb).with('My collection', collection_path(collection.id, locale: 'en'))
+
+        get :show, params: { id: collection }
+        expect(response).to be_successful
+      end
+    end
+
+    context "with a referer" do
+      before do
+        request.env['HTTP_REFERER'] = 'http://test.host/foo'
+      end
+
+      it "sets breadcrumbs" do
+        expect(controller).not_to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).not_to receive(:add_breadcrumb).with('Your Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('My collection', collection_path(collection.id, locale: 'en'))
+        get :show, params: { id: collection }
+        expect(response).to be_successful
+      end
+    end
   end
 end

data/spec/controllers/hyrax/content_blocks_controller_spec.rb

@@ -37,7 +37,7 @@ RSpec.describe Hyrax::ContentBlocksController, type: :controller do
     describe "GET #edit" do
       it "renders breadcrumbs" do
         expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
-        expect(controller).to receive(:add_breadcrumb).with('Administration', dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
         expect(controller).to receive(:add_breadcrumb).with('Configuration', '#')
         expect(controller).to receive(:add_breadcrumb).with('Content Blocks', edit_content_blocks_path)
         get :edit

data/spec/controllers/hyrax/dashboard/collections_controller_spec.rb

@@ -305,7 +305,8 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
         end
       end
 
-      it "returns the collection and its members", :with_nested_reindexing do
+      it "returns the collection and its members" do
+        expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
         expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
         get :show, params: { id: collection }
         expect(response).to be_successful
@@ -317,7 +318,7 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
         expect(assigns[:subcollection_count]).to eq(2)
       end
 
-      context "and searching", :with_nested_reindexing do
+      context "and searching" do
         it "returns some works and collections" do
           # "/dashboard/collections/4m90dv529?utf8=%E2%9C%93&cq=King+Louie&sort="
           get :show, params: { id: collection, cq: "Second" }
@@ -340,6 +341,7 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
 
       context "without a referer" do
         it "sets breadcrumbs" do
+          expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
           expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
           get :show, params: { id: collection }
           expect(response).to be_successful
@@ -352,8 +354,9 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
         end
 
         it "sets breadcrumbs" do
-          expect(controller).to receive(:add_breadcrumb).with('My Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
-          expect(controller).to receive(:add_breadcrumb).with('Your Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+          expect(controller).to receive(:add_breadcrumb).with('Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
           expect(controller).to receive(:add_breadcrumb).with('My collection', collection_path(collection.id, locale: 'en'))
           get :show, params: { id: collection }
           expect(response).to be_successful
@@ -436,6 +439,7 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
 
     context "without a referer" do
       it "sets breadcrumbs" do
+        expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
         expect(controller).to receive(:add_breadcrumb).with(I18n.t('hyrax.dashboard.title'), Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
         get :edit, params: { id: collection }
         expect(response).to be_successful
@@ -448,8 +452,9 @@ RSpec.describe Hyrax::Dashboard::CollectionsController, :clean_repo do
       end
 
       it "sets breadcrumbs" do
-        expect(controller).to receive(:add_breadcrumb).with('My Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
-        expect(controller).to receive(:add_breadcrumb).with('Your Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Home', Hyrax::Engine.routes.url_helpers.root_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', Hyrax::Engine.routes.url_helpers.dashboard_path(locale: 'en'))
+        expect(controller).to receive(:add_breadcrumb).with('Collections', Hyrax::Engine.routes.url_helpers.my_collections_path(locale: 'en'))
         expect(controller).to receive(:add_breadcrumb).with(I18n.t("hyrax.collection.browse_view"), collection_path(collection.id, locale: 'en'))
         get :edit, params: { id: collection }
         expect(response).to be_successful

data/spec/controllers/hyrax/depositors_controller_spec.rb

@@ -68,6 +68,17 @@ RSpec.describe Hyrax::DepositorsController do
         expect { delete :destroy, params: revoke_proxy_params }.to change { ProxyDepositRights.count }.by(-1)
       end
     end
+
+    describe "index" do
+      it "renders the page with user proxy info" do
+        expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with('Manage Proxies', depositors_path)
+        get :index
+        expect(response).to be_successful
+        expect(response).to render_template('dashboard')
+      end
+    end
   end
 
   context "as a user without access" do