hyrax 1.1.1 → 2.0.0.beta1

data/spec/views/hyrax/dashboard/collections/_form_share.erb_spec.rb

@@ -0,0 +1,42 @@
+RSpec.describe 'hyrax/dashboard/collections/_form_share.html.erb', type: :view do
+  let(:collection) do
+    stub_model(Collection, id: '123', depositor: 'bob')
+  end
+
+  let(:form) do
+    view.simple_form_for(collection, url: '/update') do |fs_form|
+      return fs_form
+    end
+  end
+
+  before do
+    allow(controller).to receive(:current_user).and_return(stub_model(User))
+    allow(collection).to receive(:permissions).and_return(permissions)
+    allow(view).to receive(:f).and_return(form)
+    view.lookup_context.prefixes.push 'hyrax/base'
+    view.extend Hyrax::PermissionsHelper
+    render
+  end
+
+  context "without additional users" do
+    let(:permissions) { [] }
+
+    it "draws the permissions form without error" do
+      expect(rendered).to have_css("input#new_user_name_skel")
+      expect(rendered).not_to have_css("button.remove_perm")
+    end
+  end
+
+  context "with additional users" do
+    let(:depositor_permission) { Hydra::AccessControls::Permission.new(id: '123', name: 'bob', type: 'person', access: 'edit') }
+    let(:public_permission) { Hydra::AccessControls::Permission.new(id: '124', name: 'public', type: 'group', access: 'read') }
+    let(:other_permission) { Hydra::AccessControls::Permission.new(id: '125', name: 'joe@example.com', type: 'person', access: 'edit') }
+    let(:permissions) { [depositor_permission, public_permission, other_permission] }
+
+    it "draws the permissions form without error" do
+      expect(rendered).to have_css("input#new_user_name_skel")
+      expect(rendered).to have_css("button.remove_perm", count: 1) # depositor and public should be filtered out
+      expect(rendered).to have_css("button.remove_perm[data-index='2']")
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_descriptions.html.erb_spec.rb

@@ -0,0 +1,32 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_descriptions.html.erb', type: :view do
+  context 'displaying a custom collection' do
+    let(:collection_size) { 123_456_678 }
+    let(:collection) do
+      {
+        id: '999',
+        "has_model_ssim" => ["Collection"],
+        "title_tesim" => ["Title 1"],
+        'date_created_tesim' => '2000-01-01'
+      }
+    end
+    let(:ability) { double }
+    let(:solr_document) { SolrDocument.new(collection) }
+    let(:presenter) { Hyrax::CollectionPresenter.new(solr_document, ability) }
+
+    before do
+      allow(presenter).to receive(:total_items).and_return(2)
+      allow(presenter).to receive(:size).and_return("118 MB")
+      assign(:presenter, presenter)
+    end
+
+    it "draws the metadata fields for collection" do
+      render
+      expect(rendered).to have_content 'Date Created'
+      expect(rendered).to include('itemprop="dateCreated"')
+      expect(rendered).to have_content 'Total works'
+      expect(rendered).to have_content '2'
+      expect(rendered).to have_content 'Size'
+      expect(rendered).to have_content '118 MB'
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_document_list.html.erb_spec.rb

@@ -0,0 +1,24 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_document_list.html.erb', type: :view do
+  let(:documents) { ["Hello", "World"] }
+
+  before do
+    stub_template('hyrax/dashboard/collections/_show_document_list_row.html.erb' => "<%= document %>")
+  end
+  context 'when not logged in' do
+    it "renders the documents without an Action section" do
+      allow(view).to receive(:current_user).and_return(nil)
+      render('show_document_list.html.erb', documents: documents)
+      expect(rendered).to have_css('tbody', text: documents.join)
+      expect(rendered).not_to have_css('th', text: 'Action')
+    end
+  end
+
+  context 'when logged in' do
+    it "renders the documents with an Action section" do
+      allow(view).to receive(:current_user).and_return(true)
+      render('show_document_list.html.erb', documents: documents)
+      expect(rendered).to have_css('tbody', text: documents.join)
+      expect(rendered).to have_css('th', text: 'Action')
+    end
+  end
+end

data/spec/views/hyrax/{collections → dashboard/collections}/_show_document_list_menu.html.erb_spec.rb

@@ -1,9 +1,9 @@
-
-describe 'hyrax/collections/_show_document_list_menu.html.erb', type: :view do
+RSpec.describe 'hyrax/dashboard/collections/_show_document_list_menu.html.erb', type: :view do
   context 'when user is viewing a collection' do
     let(:user) { create :user }
     let(:ability) { instance_double("Ability") }
     let(:document) { SolrDocument.new(id: '1234') }
+
     before do
       view.extend Hyrax::TrophyHelper
       allow(document).to receive(:to_model).and_return(stub_model(GenericWork))
@@ -12,8 +12,8 @@ describe 'hyrax/collections/_show_document_list_menu.html.erb', type: :view do
 
     it "displays the action list in a drop down for an individual work the user can edit" do
       allow(ability).to receive(:can?).with(:edit, document).and_return(true)
-      render('hyrax/collections/show_document_list_menu.html.erb', document: document, current_user: user)
-      expect(rendered).to have_content 'Select an action'
+      render('show_document_list_menu', document: document, current_user: user)
+      expect(rendered).to have_content 'Select'
       expect(rendered).to have_content 'Edit'
       expect(rendered).not_to have_content 'Download File'
       expect(rendered).to have_content 'Highlight Work on Profile'
@@ -21,8 +21,8 @@ describe 'hyrax/collections/_show_document_list_menu.html.erb', type: :view do
 
     it "displays the action list in a drop down for an individual work the user cannot edit" do
       allow(ability).to receive(:can?).with(:edit, document).and_return(false)
-      render('hyrax/collections/show_document_list_menu', document: document, current_user: user)
-      expect(rendered).to have_content 'Select an action'
+      render('show_document_list_menu', document: document, current_user: user)
+      expect(rendered).to have_content 'Select'
       expect(rendered).not_to have_content 'Edit'
       expect(rendered).not_to have_content 'Download File'
       expect(rendered).to have_content 'Highlight Work on Profile'

data/spec/views/hyrax/dashboard/collections/_show_document_list_row.html.erb_spec.rb

@@ -0,0 +1,31 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_document_list_row.html.erb', type: :view do
+  let(:user) { create(:user) }
+
+  let(:work) do
+    GenericWork.create(creator: ["ggm"], title: ['One Hundred Years of Solitude']) do |gw|
+      gw.apply_depositor_metadata(user)
+    end
+  end
+
+  let(:collection) { mock_model(Collection, title: 'My awesome collection', members: [work]) }
+
+  context 'when not logged in' do
+    before do
+      view.blacklight_config = Blacklight::Configuration.new
+      allow(view).to receive(:current_user).and_return(nil)
+      allow(work).to receive(:title_or_label).and_return("One Hundred Years of Solitude")
+      allow(work).to receive(:edit_people).and_return([])
+      allow(view).to receive(:render_collection_links).and_return("collections: #{collection.title}")
+    end
+
+    it "renders collections links" do
+      render('show_document_list_row', document: work)
+      expect(rendered).to have_content 'My awesome collection'
+    end
+
+    it "renders works" do
+      render('show_document_list_row', document: work)
+      expect(rendered).to have_content 'One Hundred Years of Solitude'
+    end
+  end
+end

data/spec/views/hyrax/{collections → dashboard/collections}/edit.html.erb_spec.rb

@@ -1,6 +1,6 @@
-describe 'hyrax/collections/edit.html.erb', type: :view do
+RSpec.describe 'hyrax/dashboard/collections/edit.html.erb', type: :view do
   let(:collection) { stub_model(Collection, id: 'xyz123z4', title: ["Make Collections Great Again"]) }
-  let(:form) { Hyrax::Forms::CollectionForm.new(collection) }
+  let(:form) { Hyrax::Forms::CollectionForm.new(collection, double, double) }
   let(:solr_response) { double(response: { 'numFound' => 0 }) }
 
   before do
@@ -12,9 +12,9 @@ describe 'hyrax/collections/edit.html.erb', type: :view do
     stub_template 'hyrax/collections/_search_form.html.erb' => 'search form'
     stub_template 'hyrax/my/_did_you_mean.html.erb' => 'did you mean'
     stub_template 'hyrax/collections/_sort_and_per_page.html.erb' => 'sort and per page'
-    stub_template 'hyrax/collections/_document_list.html.erb' => 'document list'
+    stub_template '_document_list.html.erb' => 'document list'
     stub_template 'hyrax/collections/_paginate.html.erb' => 'paginate'
-    stub_template 'hyrax/collections/_form.html.erb' => 'form'
+    stub_template '_form.html.erb' => 'form'
 
     render
   end

data/spec/views/hyrax/dashboard/collections/show.html.erb_spec.rb

@@ -0,0 +1,37 @@
+RSpec.describe 'hyrax/dashboard/collections/show.html.erb', type: :view do
+  let(:document) do
+    SolrDocument.new(id: 'xyz123z4',
+                     'title_tesim' => ['Make Collections Great Again'],
+                     'rights_tesim' => ["http://creativecommons.org/licenses/by-sa/3.0/us/"])
+  end
+  let(:ability) { double }
+  let(:presenter) { Hyrax::CollectionPresenter.new(document, ability) }
+
+  before do
+    allow(document).to receive(:hydra_model).and_return(::Collection)
+    allow(controller).to receive(:current_user).and_return(stub_model(User))
+    allow(view).to receive(:can?).with(:edit, document).and_return(true)
+    allow(view).to receive(:can?).with(:destroy, document).and_return(true)
+    allow(presenter).to receive(:total_items).and_return(0)
+    assign(:presenter, presenter)
+
+    # Stub route because view specs don't handle engine routes
+    allow(view).to receive(:edit_dashboard_collection_path).and_return("/dashboard/collection/123/edit")
+    allow(view).to receive(:collection_path).and_return("/dashboard/collection/123")
+
+    stub_template 'hyrax/collections/_search_form.html.erb' => 'search form'
+    stub_template 'hyrax/dashboard/collections/_sort_and_per_page.html.erb' => 'sort and per page'
+    stub_template '_document_list.html.erb' => 'document list'
+    stub_template 'hyrax/collections/_paginate.html.erb' => 'paginate'
+    stub_template 'hyrax/collections/_media_display.html.erb' => '<span class="fa fa-cubes collection-icon-search"></span>'
+    render
+  end
+
+  it 'draws the page' do
+    expect(rendered).to have_selector 'h2', text: 'Actions'
+    expect(rendered).to have_link 'Edit'
+    expect(rendered).to have_link 'Delete'
+    expect(rendered).to have_link 'Add works'
+    expect(rendered).to match '<span class="fa fa-cubes collection-icon-search"></span>'
+  end
+end

data/spec/views/hyrax/{users → dashboard/profiles}/edit.html.erb_spec.rb

@@ -1,4 +1,4 @@
-describe 'hyrax/users/edit.html.erb', type: :view do
+RSpec.describe 'hyrax/dashboard/profiles/edit.html.erb', type: :view do
   let(:user) { stub_model(User, user_key: 'mjg') }
 
   before do
@@ -15,11 +15,12 @@ describe 'hyrax/users/edit.html.erb', type: :view do
 
   context "with trophy" do
     let(:solr_document) { SolrDocument.new(id: 'abc123', has_model_ssim: 'GenericWork', title_tesim: ['Title']) }
+    let(:page) { Capybara::Node::Simple.new(rendered) }
+
     before do
       assign(:trophies, [Hyrax::TrophyPresenter.new(solr_document)])
       render
     end
-    let(:page) { Capybara::Node::Simple.new(rendered) }
 
     it "has trophy" do
       expect(page).to have_selector("#remove_trophy_abc123")

data/spec/views/hyrax/dashboard/show_user_spec.rb

@@ -0,0 +1,34 @@
+RSpec.describe "hyrax/dashboard/show_user.html.erb", type: :view do
+  before do
+    allow(controller).to receive(:current_user).and_return(user)
+    assign(:presenter, presenter)
+  end
+  let(:user) { build(:user) }
+  let(:ability) { instance_double("Ability") }
+  let(:presenter) do
+    instance_double(Hyrax::Dashboard::UserPresenter,
+                    render_recent_activity: 'recent activity',
+                    render_recent_notifications: 'recent notifications',
+                    link_to_additional_notifications: 'additional notifications',
+                    transfers: transfer_presenter)
+  end
+  let(:transfer_presenter) do
+    instance_double(Hyrax::TransfersPresenter,
+                    render_sent_transfers: 'sent transfers',
+                    render_received_transfers: 'received transfers')
+  end
+
+  it "includes recent activities and notifications" do
+    render
+    expect(rendered).to have_content "User Activity"
+    expect(rendered).to have_content "recent activity"
+
+    expect(rendered).to have_content "User Notifications"
+    expect(rendered).to have_content "recent notifications"
+    expect(rendered).to have_content "additional notifications"
+
+    expect(rendered).to have_content "Select works to transfer"
+    expect(rendered).to have_content "sent transfers"
+    expect(rendered).to have_content "received transfers"
+  end
+end

data/spec/views/hyrax/embargoes/index.html.erb_spec.rb

@@ -0,0 +1,14 @@
+RSpec.describe "hyrax/embargoes/index.html.erb", type: :view do
+  before do
+    stub_template 'hyrax/embargoes/_list_deactivated_embargoes' => 'rendered list_deactivated_embargoes'
+    stub_template 'hyrax/embargoes/_list_expired_active_embargoes' => 'rendered list_expired_active_embargoes'
+    stub_template 'hyrax/embargoes/_list_active_embargoes' => 'rendered list_active_embargoes'
+  end
+
+  it "displays the page and renderes deactivated, expired, and active embargoes" do
+    render template: 'hyrax/embargoes/index'
+    expect(rendered).to have_css('.tab-pane#active', text: 'rendered list_active_embargoes')
+    expect(rendered).to have_css('.tab-pane#expired', text: 'rendered list_expired_active_embargoes')
+    expect(rendered).to have_css('.tab-pane#deactivated', text: 'rendered list_deactivated_embargoes')
+  end
+end

data/spec/views/hyrax/file_sets/_permission.html.erb_spec.rb

@@ -1,6 +1,4 @@
-require 'spec_helper'
-
-describe 'hyrax/file_sets/_permission.html.erb', type: :view do
+RSpec.describe 'hyrax/file_sets/_permission.html.erb', type: :view do
   let(:file_set) { stub_model(FileSet) }
 
   before do

data/spec/views/hyrax/file_sets/_permission_form.html.erb_spec.rb

@@ -1,6 +1,4 @@
-require 'spec_helper'
-
-describe 'hyrax/file_sets/_permission_form.html.erb', type: :view do
+RSpec.describe 'hyrax/file_sets/_permission_form.html.erb', type: :view do
   let(:file_set) do
     stub_model(FileSet, id: '123',
                         depositor: 'bob',

data/spec/views/hyrax/file_sets/_show_actions.html.erb_spec.rb

@@ -1,6 +1,4 @@
-require 'spec_helper'
-
-describe 'hyrax/file_sets/_show_actions.html.erb', type: :view do
+RSpec.describe 'hyrax/file_sets/_show_actions.html.erb', type: :view do
   let(:user) { create(:user) }
   let(:object_profile) { ["{\"id\":\"999\"}"] }
   let(:contributor) { ['Frodo'] }
@@ -21,6 +19,7 @@ describe 'hyrax/file_sets/_show_actions.html.erb', type: :view do
     Hyrax::WorkShowPresenter.new(solr_document, ability)
   end
   let(:page) { Capybara::Node::Simple.new(rendered) }
+
   describe 'citations' do
     before do
       Hyrax.config.citations = citations

data/spec/views/hyrax/file_sets/_show_characterization_details.html.erb_spec.rb

@@ -1,6 +1,4 @@
-require 'spec_helper'
-
-describe 'hyrax/file_sets/_show_characterization_details.html.erb', type: :view do
+RSpec.describe 'hyrax/file_sets/_show_characterization_details.html.erb', type: :view do
   let(:file) { build(:file_set).tap { |f| f.apply_depositor_metadata("user") } }
   let(:solr_document) { SolrDocument.new(file.to_solr) }
   let(:ability) { double "Ability" }
@@ -13,6 +11,7 @@ describe 'hyrax/file_sets/_show_characterization_details.html.erb', type: :view
       string_term: 'oops, I used a string instead of an array'
     }
   end
+  let(:page) { Capybara::Node::Simple.new(rendered) }
 
   before do
     allow(presenter).to receive(:characterization_metadata).and_return(mock_metadata)
@@ -20,8 +19,6 @@ describe 'hyrax/file_sets/_show_characterization_details.html.erb', type: :view
     render
   end
 
-  let(:page) { Capybara::Node::Simple.new(rendered) }
-
   it 'displays characterization terms' do
     expect(page).to have_content("oops, I used a string instead of an array")
     expect(page).to have_content("xxxxxxx...")

data/spec/views/hyrax/file_sets/_single_use_links.html.erb_spec.rb

@@ -1,6 +1,4 @@
-require 'spec_helper'
-
-describe 'hyrax/file_sets/_single_use_links.html.erb', type: :view do
+RSpec.describe 'hyrax/file_sets/_single_use_links.html.erb', type: :view do
   let(:user)          { create(:user) }
   let(:file_set)      { build(:file_set, user: user, id: "1234") }
   let(:solr_document) { SolrDocument.new(file_set.to_solr) }
@@ -20,6 +18,7 @@ describe 'hyrax/file_sets/_single_use_links.html.erb', type: :view do
   context "with single use links" do
     let(:link)           { SingleUseLink.create(itemId: "1234", downloadKey: "sha2hashb") }
     let(:link_presenter) { Hyrax::SingleUseLinkPresenter.new(link) }
+
     before do
       controller.params = { id: "1234" }
       allow(presenter).to receive(:single_use_links).and_return([link_presenter])

data/spec/views/hyrax/file_sets/_versioning.html.erb_spec.rb

@@ -1,4 +1,4 @@
-describe 'hyrax/file_sets/_versioning.html.erb', type: :view do
+RSpec.describe 'hyrax/file_sets/_versioning.html.erb', type: :view do
   let(:file_set) { stub_model(FileSet) }
 
   before do

data/spec/views/hyrax/file_sets/media_display/_default.html.erb_spec.rb

@@ -1,6 +1,4 @@
-require 'spec_helper'
-
-describe 'hyrax/file_sets/mdeia_display/_default.html.erb', type: :view do
+RSpec.describe 'hyrax/file_sets/mdeia_display/_default.html.erb', type: :view do
   let(:file_set) { stub_model(FileSet) }
   let(:config) { double }
   let(:link) { true }

data/spec/views/hyrax/file_sets/show.html.erb_spec.rb

@@ -1,10 +1,14 @@
-require 'spec_helper'
-
-describe 'hyrax/file_sets/show.html.erb', type: :view do
+RSpec.describe 'hyrax/file_sets/show.html.erb', type: :view do
   let(:user) { double(user_key: 'sarah', twitter_handle: 'test') }
-  let(:file_set) { build(:file_set, id: '123', depositor: user.user_key, title: ['My Title'], user: user, visibility: 'open') }
   let(:ability) { double }
-  let(:solr_doc) { SolrDocument.new(file_set.to_solr) }
+  let(:doc) do
+    {
+      "has_model_ssim" => ["FileSet"],
+      :id => "123",
+      "title_tesim" => ["My Title"]
+    }
+  end
+  let(:solr_doc) { SolrDocument.new(doc) }
   let(:presenter) { Hyrax::FileSetPresenter.new(solr_doc, ability) }
   let(:mock_metadata) do
     {
@@ -12,17 +16,18 @@ describe 'hyrax/file_sets/show.html.erb', type: :view do
       long_term: ["x" * 255],
       multi_term: ["1", "2", "3", "4", "5", "6", "7", "8"],
       string_term: 'oops, I used a string instead of an array',
-      logged_audit_status: "Audits have not yet been run on this file"
+      logged_fixity_status: "Fixity checks have not yet been run on this file"
     }
   end
+
   before do
     view.lookup_context.prefixes.push 'hyrax/base'
     allow(view).to receive(:can?).with(:edit, SolrDocument).and_return(false)
     allow(ability).to receive(:can?).with(:edit, SolrDocument).and_return(false)
-    allow(presenter).to receive(:audit_status).and_return(mock_metadata)
+    allow(presenter).to receive(:fixity_status).and_return(mock_metadata)
     assign(:presenter, presenter)
     assign(:document, solr_doc)
-    assign(:audit_status, "none")
+    assign(:fixity_status, "none")
   end
 
   describe 'title heading' do

data/spec/views/hyrax/file_sets/show.json.jbuilder_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 RSpec.describe 'hyrax/file_sets/show.json.jbuilder' do
   let(:presenter) do
     instance_double(Hyrax::FileSetPresenter,

data/spec/views/hyrax/homepage/_announcement.html.erb_spec.rb

@@ -1,7 +1,7 @@
-describe "hyrax/homepage/_announcement.html.erb", type: :view do
+RSpec.describe "hyrax/homepage/_announcement.html.erb", type: :view do
   let(:groups) { [] }
   let(:ability) { instance_double("Ability") }
-  let(:announcement) { ContentBlock.new(name: ContentBlock::ANNOUNCEMENT, value: announcement_value) }
+  let(:announcement) { ContentBlock.new(name: ContentBlock::NAME_REGISTRY[:announcement], value: announcement_value) }
 
   subject { rendered }
 
@@ -9,42 +9,19 @@ describe "hyrax/homepage/_announcement.html.erb", type: :view do
     view.extend Hyrax::ContentBlockHelper
     assign(:announcement_text, announcement)
     allow(controller).to receive(:current_ability).and_return(ability)
-    allow(ability).to receive(:can?).with(:update, ContentBlock).and_return(can_update_content_block)
     render
   end
 
   context "when there is an announcement" do
     let(:announcement_value) { "I have an announcement!" }
 
-    context "when the user can update content" do
-      let(:can_update_content_block) { true }
-
-      it { is_expected.to have_content announcement_value }
-      it { is_expected.to have_button("Edit") }
-    end
-
-    context "when the user can't update content" do
-      let(:can_update_content_block) { false }
-
-      it { is_expected.to have_content announcement_value }
-      it { is_expected.not_to have_button("Edit") }
-    end
+    it { is_expected.to have_content announcement_value }
+    it { is_expected.not_to have_button("Edit") }
   end
 
   context "when there is no announcement" do
     let(:announcement_value) { "" }
 
-    context "when the user can update content" do
-      let(:can_update_content_block) { true }
-
-      it { is_expected.to have_selector "#announcement" }
-      it { is_expected.to have_button("Edit") }
-    end
-
-    context "when the user can't update content" do
-      let(:can_update_content_block) { false }
-
-      it { is_expected.not_to have_selector "#announcement" }
-    end
+    it { is_expected.not_to have_selector "#announcement" }
   end
 end