hybrid_platforms_conductor 32.3.6

data/spec/hybrid_platforms_conductor_test/api/nodes_handler/common_spec.rb

@@ -0,0 +1,127 @@
+describe HybridPlatformsConductor::NodesHandler do
+
+  it 'initializes with no platform' do
+    with_platforms '' do
+      expect(test_nodes_handler.known_nodes).to eq []
+    end
+  end
+
+  it 'initializes with a platform having no node' do
+    with_test_platform do
+      expect(test_nodes_handler.known_nodes).to eq []
+    end
+  end
+
+  it 'iterates over defined nodes sequentially' do
+    with_test_platform(nodes: { 'node1' => {}, 'node2' => {}, 'node3' => {}, 'node4' => {} }) do
+      nodes_iterated = []
+      test_nodes_handler.for_each_node_in(['node2', 'node3', 'node4']) do |node|
+        nodes_iterated << node
+      end
+      expect(nodes_iterated.sort).to eq %w[node2 node3 node4].sort
+    end
+  end
+
+  it 'iterates over defined nodes in parallel' do
+    with_test_platform(nodes: { 'node1' => {}, 'node2' => {}, 'node3' => {}, 'node4' => {} }) do
+      nodes_iterated = []
+      test_nodes_handler.for_each_node_in(['node2', 'node3', 'node4'], parallel: true) do |node|
+        sleep(
+          case node
+          when 'node2'
+            2
+          when 'node3'
+            3
+          when 'node4'
+            1
+          end
+        )
+        nodes_iterated << node
+      end
+      expect(nodes_iterated).to eq %w[node4 node2 node3]
+    end
+  end
+
+  it 'iterates over defined nodes in parallel and handle errors correctly' do
+    with_test_platform(nodes: { 'node1' => {}, 'node2' => {}, 'node3' => {}, 'node4' => {} }) do
+      nodes_iterated = []
+      # Make sure we exit the test case even if the error is not handled correctly by using a timeout
+      Timeout.timeout(5) do
+        expect do
+          test_nodes_handler.for_each_node_in(['node2', 'node3', 'node4'], parallel: true) do |node|
+            case node
+            when 'node2'
+              sleep 2
+            when 'node3'
+              sleep 3
+              raise "Error iterating on #{node}"
+            when 'node4'
+              sleep 1
+            end
+            nodes_iterated << node
+          end
+        end.to raise_error 'Error iterating on node3'
+      end
+      expect(nodes_iterated).to eq %w[node4 node2]
+    end
+  end
+
+  it 'selects the correct configurations for a given node' do
+    with_test_platform(
+      nodes: { 'node1' => {}, 'node2' => {}, 'node3' => {}, 'node4' => {} },
+      nodes_lists: { 'nodeslist1' => %w[node1 node2], 'nodeslist2' => %w[node3 node4] }
+    ) do
+      expect(test_nodes_handler.select_confs_for_node('node2', [
+        {
+          conf: 'conf1',
+          nodes_selectors_stack: ['/node1/']
+        },
+        {
+          conf: 'conf2',
+          nodes_selectors_stack: ['/node2/']
+        },
+        {
+          conf: 'conf3',
+          nodes_selectors_stack: [[{ list: 'nodeslist1' }]]
+        },
+        {
+          conf: 'conf4',
+          nodes_selectors_stack: [[{ list: 'nodeslist2' }]]
+        }
+      ]).map { |config| config[:conf] }.sort).to eq %w[
+        conf2
+        conf3
+      ].sort
+    end
+  end
+
+  it 'selects the correct configurations for a given platform' do
+    with_test_platforms(
+      'platform1' => { nodes: { 'node11' => {}, 'node12' => {}, 'node13' => {}, 'node14' => {} } },
+      'platform2' => { nodes: { 'node21' => {}, 'node22' => {}, 'node23' => {}, 'node24' => {} } }
+    ) do
+      expect(test_nodes_handler.select_confs_for_platform('platform2', [
+        {
+          conf: 'conf1',
+          nodes_selectors_stack: ['/node1/']
+        },
+        {
+          conf: 'conf2',
+          nodes_selectors_stack: ['/node2/']
+        },
+        {
+          conf: 'conf3',
+          nodes_selectors_stack: [%w[node11 node13 node21 node22 node23 node24]]
+        },
+        {
+          conf: 'conf4',
+          nodes_selectors_stack: [%w[node11 node13 node21 node22 node24]]
+        }
+      ]).map { |config| config[:conf] }.sort).to eq %w[
+        conf2
+        conf3
+      ].sort
+    end
+  end
+
+end

data/spec/hybrid_platforms_conductor_test/api/nodes_handler/git_diff_impacts_spec.rb

@@ -0,0 +1,318 @@
+describe HybridPlatformsConductor::NodesHandler do
+
+  context 'checking computation of impacted nodes by a git diff' do
+
+    it 'returns all the impacted platform nodes by default' do
+      with_test_platforms(
+        {
+          'platform_1' => { nodes: { 'node11' => {}, 'node12' => {} } },
+          'platform_2' => { nodes: { 'node21' => {}, 'node22' => {} } }
+        },
+        true
+      ) do
+        with_cmd_runner_mocked([
+          [/cd .+\/platform_2 && git --no-pager diff --no-color master/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('platform_2')).to eq [
+            %w[node21 node22].sort,
+            [],
+            [],
+            true
+          ]
+        end
+      end
+    end
+
+    it 'diffs from another commit if asked' do
+      with_test_platform({}, true) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color from_branch/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform', from_commit: 'from_branch')).to eq [[], [], [], true]
+        end
+      end
+    end
+
+    it 'diffs to another commit if asked' do
+      with_test_platform({}, true) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color master to_branch/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform', to_commit: 'to_branch')).to eq [[], [], [], true]
+        end
+      end
+    end
+
+    it 'gives the platform handler the correct git diff result' do
+      with_test_platform({}, true) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color master/, proc do
+            [
+              0,
+              <<~EOS,
+                diff --git a/Gemfile b/Gemfile
+                index d65e2a6..cb9a38e 100644
+                --- a/Gemfile
+                +++ b/Gemfile
+                @@ -1,3 +1,5 @@
+                 source 'http://rubygems.org'
+                 
+                 gemspec
+                +
+                +gem 'byebug'
+                
+                diff --git a/lib/hybrid_platforms_conductor/nodes_handler.rb b/lib/stale/hybrid_platforms_conductor/nodes_handler.rb
+                index e8e1778..69a84bd 100644
+                --- a/lib/hybrid_platforms_conductor/nodes_handler.rb
+                +++ b/lib/hybrid_platforms_conductor/nodes_handler.rb
+                @@ -133,6 +133,23 @@ module HybridPlatformsConductor
+                       options_parser.on('-l', '--nodes-list LIST', 'Select nodes defined in a nodes list (can be used several times)') do |nodes_list|
+                         nodes_selectors << { list: nodes_list }
+                       end
+                +      options_parser.on(
+                +        '--nodes-git-impact GIT_IMPACT',
+                         nodes_selectors << node
+                       end
+              EOS
+              ''
+            ]
+          end]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform')).to eq [[], [], [], true]
+          expect(test_platforms_handler.platform('my_remote_platform').files_diffs).to eq(
+            'Gemfile' => {
+              diff: <<~EOS.strip
+                index d65e2a6..cb9a38e 100644
+                --- a/Gemfile
+                +++ b/Gemfile
+                @@ -1,3 +1,5 @@
+                 source 'http://rubygems.org'
+                 
+                 gemspec
+                +
+                +gem 'byebug'
+                
+              EOS
+            },
+            'lib/hybrid_platforms_conductor/nodes_handler.rb' => {
+              moved_to: 'lib/stale/hybrid_platforms_conductor/nodes_handler.rb',
+              diff: <<~EOS.strip
+                index e8e1778..69a84bd 100644
+                --- a/lib/hybrid_platforms_conductor/nodes_handler.rb
+                +++ b/lib/hybrid_platforms_conductor/nodes_handler.rb
+                @@ -133,6 +133,23 @@ module HybridPlatformsConductor
+                       options_parser.on('-l', '--nodes-list LIST', 'Select nodes defined in a nodes list (can be used several times)') do |nodes_list|
+                         nodes_selectors << { list: nodes_list }
+                       end
+                +      options_parser.on(
+                +        '--nodes-git-impact GIT_IMPACT',
+                         nodes_selectors << node
+                       end
+              EOS
+            }
+          )
+        end
+      end
+    end
+
+    it 'returns the impacted nodes given by the platform handler' do
+      with_test_platforms(
+        {
+          'other_platform' => { nodes: { 'other_node_1' => {}, 'other_node_2' => {} } },
+          'my_remote_platform' => {
+            nodes: { 'node1' => {}, 'node2' => {}, 'node3' => {} },
+            impacted_nodes: %w[node1 node3]
+          }
+        },
+        true
+      ) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color master/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform')).to eq [
+            %w[node1 node3],
+            %w[node1 node3],
+            [],
+            false
+          ]
+        end
+      end
+    end
+
+    it 'returns the impacted services given by the platform handler' do
+      with_test_platforms(
+        {
+          'other_platform' => { nodes: { 'other_node_1' => {}, 'other_node_2' => {} } },
+          'my_remote_platform' => {
+            nodes: {
+              'node1' => { services: %w[service1 service2] },
+              'node2' => { services: %w[service1 service3] },
+              'node3' => { services: %w[service2 service4] }
+            },
+            impacted_services: %w[service1 service3]
+          }
+        },
+        true
+      ) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color master/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform')).to eq [
+            %w[node1 node2],
+            [],
+            %w[service1 service3],
+            false
+          ]
+        end
+      end
+    end
+
+    it 'returns the impacted global given by the platform handler' do
+      with_test_platforms(
+        {
+          'other_platform' => { nodes: { 'other_node_1' => {}, 'other_node_2' => {} } },
+          'my_remote_platform' => {
+            nodes: {
+              'node1' => { services: %w[service1 service2] },
+              'node2' => { services: %w[service1 service3] },
+              'node3' => { services: %w[service2 service4] }
+            },
+            impacted_global: true
+          }
+        },
+        true
+      ) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color master/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform')).to eq [
+            %w[node1 node2 node3],
+            [],
+            [],
+            true
+          ]
+        end
+      end
+    end
+
+    it 'returns the impacted nodes given by the platform handler' do
+      with_test_platforms(
+        {
+          'other_platform' => { nodes: { 'other_node_1' => {}, 'other_node_2' => {} } },
+          'my_remote_platform' => {
+            nodes: { 'node1' => {}, 'node2' => {}, 'node3' => {} },
+            impacted_nodes: %w[node1 node3]
+          }
+        },
+        true
+      ) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color master/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform')).to eq [
+            %w[node1 node3],
+            %w[node1 node3],
+            [],
+            false
+          ]
+        end
+      end
+    end
+
+    it 'returns both impacted services and nodes given by the platform handler' do
+      with_test_platforms(
+        {
+          'other_platform' => { nodes: { 'other_node_1' => {}, 'other_node_2' => {} } },
+          'my_remote_platform' => {
+            nodes: {
+              'node1' => { services: %w[service1 service2] },
+              'node2' => { services: %w[service1 service3] },
+              'node3' => { services: %w[service2 service4] },
+              'node4' => { services: %w[service2 service4] }
+            },
+            impacted_nodes: %w[node4],
+            impacted_services: %w[service1 service3]
+          }
+        },
+        true
+      ) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color master/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform')).to eq [
+            %w[node1 node2 node4],
+            %w[node4],
+            %w[service1 service3],
+            false
+          ]
+        end
+      end
+    end
+
+    it 'returns all nodes of impacted services' do
+      with_test_platforms(
+        {
+          'other_platform' => { nodes: { 'other_node_1' => {}, 'other_node_2' => {} } },
+          'my_remote_platform' => {
+            nodes: {
+              'node1' => { services: %w[service1 service2] },
+              'node2' => { services: %w[service1 service3] },
+              'node3' => { services: %w[service2 service4] },
+              'node4' => { services: %w[service2 service4] },
+              'node5' => { services: %w[service3 service4] },
+              'node6' => { services: %w[service3 service4] },
+              'node7' => { services: %w[service1 service4] }
+            },
+            impacted_services: %w[service2 service3]
+          }
+        },
+        true
+      ) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color master/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform')).to eq [
+            %w[node1 node2 node3 node4 node5 node6],
+            [],
+            %w[service2 service3],
+            false
+          ]
+        end
+      end
+    end
+
+    it 'returns the minimal subset of nodes impacted by services' do
+      with_test_platforms(
+        {
+          'other_platform' => { nodes: { 'other_node_1' => {}, 'other_node_2' => {} } },
+          'my_remote_platform' => {
+            nodes: {
+              'node1' => { services: %w[service1 service2] },
+              'node2' => { services: %w[service1 service3] },
+              'node3' => { services: %w[service2 service4] },
+              'node4' => { services: %w[service2 service4] },
+              'node5' => { services: %w[service3 service4] },
+              'node6' => { services: %w[service3 service4] },
+              'node7' => { services: %w[service1 service4] }
+            },
+            impacted_services: %w[service2 service3]
+          }
+        },
+        true
+      ) do
+        with_cmd_runner_mocked([
+          [/cd .+\/my_remote_platform && git --no-pager diff --no-color master/, proc { [0, '', ''] }]
+        ]) do
+          expect(test_nodes_handler.impacted_nodes_from_git_diff('my_remote_platform', smallest_set: true)).to eq [
+            %w[node1 node2],
+            [],
+            %w[service2 service3],
+            false
+          ]
+        end
+      end
+    end
+
+  end
+
+end

data/spec/hybrid_platforms_conductor_test/api/nodes_handler/nodes_selectors_spec.rb

@@ -0,0 +1,132 @@
+describe HybridPlatformsConductor::NodesHandler do
+
+  context 'checking nodes selection capabilities' do
+
+    # Set the test environment with a given list of nodes for our tests
+    #
+    # Parameters::
+    # * Proc: Code called when environment is ready
+    def with_test_platform_for_nodes
+      with_test_platforms(
+        'platform1' => {
+          nodes: { 'node1' => {}, 'node2' => { services: ['service1'] }, 'node3' => { services: ['service2'] } },
+          nodes_lists: { 'nodeslist1' => %w[node1 node3], 'nodeslist2' => ['/node[12]/'] }
+        },
+        'platform2' => {
+          nodes: { 'node4' => {}, 'node5' => { services: ['service3', 'service1'] }, 'node6' => {} }
+        }
+      ) do
+        yield
+      end
+    end
+
+    # List all tests of nodes selectors, and the corresponding nodes list they should be resolved into
+    {
+      [] => [],
+      [{ all: true }] => %w[node1 node2 node3 node4 node5 node6],
+      'node1' => %w[node1],
+      '/node[12]/' => %w[node1 node2],
+      [{ list: 'nodeslist1' }] => %w[node1 node3],
+      [{ list: 'nodeslist2' }] => %w[node1 node2],
+      [{ platform: 'platform2' }] => %w[node4 node5 node6],
+      [{ service: 'service1' }] => %w[node2 node5],
+      ['/node[12]/', { service: 'service1' }] => %w[node1 node2 node5],
+      [{ git_diff: { platform: 'platform2' } }] => %w[node4 node5 node6]
+    }.each do |nodes_selectors, expected_nodes|
+
+      it "selects nodes correctly: #{nodes_selectors} resolves to #{expected_nodes}" do
+        with_test_platform_for_nodes do
+          expect(test_nodes_handler.select_nodes([])).to eq []
+        end
+      end
+
+    end
+
+    it 'fails when selecting unknown nodes' do
+      with_test_platform_for_nodes do
+        expect { test_nodes_handler.select_nodes('node1', 'node7') }.to raise_error(RuntimeError, 'Unknown nodes: node7')
+      end
+    end
+
+    it 'ignore unknown nodes when asked' do
+      with_test_platform_for_nodes do
+        expect(test_nodes_handler.select_nodes(['node1', 'node7'], ignore_unknowns: true).sort).to eq %w[node1 node7].sort
+      end
+    end
+
+    it 'selects the correct diff impacts' do
+      with_test_platform_for_nodes do
+        expect(test_nodes_handler).to receive(:impacted_nodes_from_git_diff).with(
+          'platform2',
+          from_commit: 'master',
+          to_commit: nil,
+          smallest_set: false
+        ) { [%w[node4 node6], [], [], false] }
+        expect(test_nodes_handler.select_nodes([{ git_diff: { platform: 'platform2' } }]).sort).to eq %w[node4 node6].sort
+      end
+    end
+
+    it 'selects the correct diff impacts with from commit' do
+      with_test_platform_for_nodes do
+        expect(test_nodes_handler).to receive(:impacted_nodes_from_git_diff).with(
+          'platform2',
+          from_commit: 'from_commit',
+          to_commit: nil,
+          smallest_set: false
+        ) { [%w[node4 node6], [], [], false] }
+        expect(test_nodes_handler.select_nodes([{ git_diff: { platform: 'platform2', from_commit: 'from_commit' } }]).sort).to eq %w[node4 node6].sort
+      end
+    end
+
+    it 'selects the correct diff impacts with to commit' do
+      with_test_platform_for_nodes do
+        expect(test_nodes_handler).to receive(:impacted_nodes_from_git_diff).with(
+          'platform2',
+          from_commit: 'master',
+          to_commit: 'to_commit',
+          smallest_set: false
+        ) { [%w[node4 node6], [], [], false] }
+        expect(test_nodes_handler.select_nodes([{ git_diff: { platform: 'platform2', to_commit: 'to_commit' } }]).sort).to eq %w[node4 node6].sort
+      end
+    end
+
+    it 'selects the correct diff impacts with smallest set' do
+      with_test_platform_for_nodes do
+        expect(test_nodes_handler).to receive(:impacted_nodes_from_git_diff).with(
+          'platform2',
+          from_commit: 'master',
+          to_commit: nil,
+          smallest_set: true
+        ) { [%w[node4 node6], [], [], false] }
+        expect(test_nodes_handler.select_nodes([{ git_diff: { platform: 'platform2', smallest_set: true } }]).sort).to eq %w[node4 node6].sort
+      end
+    end
+
+    it 'considers all nodes for en empty nodes selector stack' do
+      with_test_platform_for_nodes do
+        expect(test_nodes_handler.select_from_nodes_selector_stack([]).sort).to eq %w[node1 node2 node3 node4 node5 node6].sort
+      end
+    end
+
+    it 'considers nodes selector intersection in a nodes selector stack' do
+      with_test_platform_for_nodes do
+        expect(test_nodes_handler.select_from_nodes_selector_stack([
+          %w[node1 node2 node3],
+          %w[node2 node3 node4]
+        ]).sort).to eq %w[node2 node3].sort
+      end
+    end
+
+    it 'considers nodes selector intersection between different kind of selectors in a nodes selector stack' do
+      with_test_platform_for_nodes do
+        expect(test_nodes_handler.select_from_nodes_selector_stack([
+          '/node[1256]/',
+          [{ platform: 'platform2' }],
+          [{ service: 'service1' }]
+        ]).sort).to eq %w[node5].sort
+      end
+    end
+
+  end
+
+end