hubspot-api-ruby 0.8.1 → 0.9.0

data/spec/lib/hubspot/form_spec.rb

@@ -1,11 +1,25 @@
 describe Hubspot::Form do
-  let(:guid) { '78c2891f-ebdd-44c0-bd94-15c012bbbfbf' } # '561d9ce9-bb4c-45b4-8e32-21cdeaa3a7f0'
   let(:example_form_hash) do
     VCR.use_cassette('form_example') do
-      HTTParty.get("https://api.hubapi.com#{Hubspot::Form::FORMS_PATH}/#{guid}/?hapikey=demo").parsed_response
+      HTTParty.get("https://api.hubapi.com#{Hubspot::Form::FORMS_PATH}/038e819c-5262-4c13-8550-8cabe38c4309/?hapikey=demo").parsed_response
     end
   end
 
+  let(:create_params) do
+    {
+      name: "Demo Form #{SecureRandom.hex}",
+      action: '',
+      method: 'POST',
+      cssClass: 'hs-form stacked',
+      redirect: '',
+      submitText: 'Sign Up',
+      followUpId: '',
+      leadNurturingCampaignId: '',
+      notifyRecipients: '',
+      embeddedCode: ''
+    }
+  end
+
   describe '#initialize' do
     subject { Hubspot::Form.new(example_form_hash) }
 
@@ -14,14 +28,13 @@ describe Hubspot::Form do
     its(:properties) { should be_a(Hash) }
   end
 
-  before { Hubspot.configure(hapikey: 'demo', portal_id: '62515') }
-
   describe '.all' do
+    before { Hubspot.configure(hapikey: 'demo') }
+
     cassette 'find_all_forms'
 
     it 'returns all forms' do
       forms = Hubspot::Form.all
-      expect(forms.count).to be > 20
 
       form = forms.first
       expect(form).to be_a(Hubspot::Form)
@@ -29,8 +42,10 @@ describe Hubspot::Form do
   end
 
   describe '.find' do
+    before { Hubspot.configure(hapikey: 'demo') }
+
     cassette 'form_find'
-    subject { Hubspot::Form.find(guid) }
+    subject { Hubspot::Form.find(Hubspot::Form.all.first.guid) }
 
     context 'when the form is found' do
       it { should be_an_instance_of Hubspot::Form }
@@ -39,31 +54,17 @@ describe Hubspot::Form do
 
     context 'when the form is not found' do
       it 'raises an error' do
-        expect { Hubspot::Form.find(-1) }.to raise_error(Hubspot::RequestError)
+        expect { Hubspot::Form.find(-1) }.to raise_error(Hubspot::NotFoundError)
       end
     end
   end
 
   describe '.create' do
-    subject { Hubspot::Form.create!(params) }
+    subject { Hubspot::Form.create!(create_params) }
 
     context 'with all required parameters' do
       cassette 'create_form'
 
-      let(:params) do
-        {
-          name: "Demo Form #{Time.now.to_i}",
-          action: '',
-          method: 'POST',
-          cssClass: 'hs-form stacked',
-          redirect: '',
-          submitText: 'Sign Up',
-          followUpId: '',
-          leadNurturingCampaignId: '',
-          notifyRecipients: '',
-          embeddedCode: ''
-        }
-      end
       it { should be_an_instance_of Hubspot::Form }
       its(:guid) { should be_a(String) }
     end
@@ -78,6 +79,7 @@ describe Hubspot::Form do
   end
 
   describe '#fields' do
+    before { Hubspot.configure(hapikey: 'demo') }
     context 'returning all the fields' do
       cassette 'fields_among_form'
 
@@ -117,11 +119,11 @@ describe Hubspot::Form do
   describe '#submit' do
     cassette 'form_submit_data'
 
-    let(:form) { Hubspot::Form.find('561d9ce9-bb4c-45b4-8e32-21cdeaa3a7f0') }
+    let(:form) { Hubspot::Form.create!(create_params) }
 
     context 'with a valid portal id' do
       before do
-        Hubspot.configure(hapikey: 'demo', portal_id: '62515')
+        Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"), portal_id: ENV.fetch("HUBSPOT_PORTAL_ID"))
       end
 
       it 'returns true if the form submission is successful' do
@@ -133,7 +135,7 @@ describe Hubspot::Form do
 
     context 'with an invalid portal id' do
       before do
-        Hubspot.configure(hapikey: 'demo', portal_id: 'xxxx')
+        Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"), portal_id: "xxx")
       end
 
       it 'returns false in case of errors' do
@@ -144,13 +146,15 @@ describe Hubspot::Form do
     end
 
     context 'when initializing Hubspot::Form directly' do
-      let(:form) { Hubspot::Form.new('guid' => '561d9ce9-bb4c-45b4-8e32-21cdeaa3a7f0') }
+      let(:f) { Hubspot::Form.new('guid' => form.guid) }
 
-      before { Hubspot.configure(hapikey: 'demo', portal_id: '62515') }
+      before do
+        Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"), portal_id: ENV.fetch("HUBSPOT_PORTAL_ID"))
+      end
 
       it 'returns true if the form submission is successful' do
         params = {}
-        result = form.submit(params)
+        result = f.submit(params)
         result.should be true
       end
     end
@@ -159,16 +163,16 @@ describe Hubspot::Form do
   describe '#update!' do
     cassette 'form_update'
 
-    new_name = 'updated form name 1424709912'
+    new_name = "updated form name #{SecureRandom.hex}"
     redirect = 'http://hubspot.com'
 
-    let(:form) { Hubspot::Form.find('561d9ce9-bb4c-45b4-8e32-21cdeaa3a7f0') }
+    let(:form) { Hubspot::Form.create!(create_params) }
     let(:params) { { name: new_name, redirect: redirect } }
     subject { form.update!(params) }
 
     it { should be_an_instance_of Hubspot::Form }
     it 'updates properties' do
-      subject.properties['name'].should be == new_name
+      subject.properties['name'].should start_with('updated form name ')
       subject.properties['redirect'].should be == redirect
     end
   end
@@ -176,8 +180,7 @@ describe Hubspot::Form do
   describe '#destroy!' do
     cassette 'form_destroy'
 
-    # NOTE: form previous created via the create! method
-    let(:form) { Hubspot::Form.find('beb92950-ca65-4daf-87ae-a42c054e429f') }
+    let(:form) { Hubspot::Form.create!(create_params) }
     subject { form.destroy! }
     it { should be true }
 

data/spec/lib/hubspot/meeting_spec.rb

@@ -0,0 +1,75 @@
+RSpec.describe Hubspot::Meeting do
+
+  let(:hubspot_owner_id) { 123 }
+  let(:hs_meeting_title) { 'hs_meeting_title' }
+  let(:hs_meeting_body) { 'hs_meeting_body' }
+  let(:hs_meeting_start_time) { DateTime.strptime('2022-05-03T10:00:00+01:00', '%Y-%m-%dT%H:%M:%S%z') }
+  let(:hs_meeting_end_time) { DateTime.strptime('2022-05-03T10:15:00+01:00', '%Y-%m-%dT%H:%M:%S%z') }
+
+  describe '.create' do
+    context 'with properties' do
+
+      subject do
+        described_class.create!(hubspot_owner_id,
+                                hs_meeting_title,
+                                hs_meeting_body,
+                                hs_meeting_start_time,
+                                hs_meeting_end_time)
+      end
+
+      it 'creates a new meeting with valid properties' do
+        VCR.use_cassette 'meeting' do
+          expect(subject[:id]).not_to be_nil
+          expect(DateTime.parse(subject[:properties][:hs_meeting_start_time])).to eq(hs_meeting_start_time)
+        end
+      end
+    end
+
+    context 'with an invalid hs_meeting_start_time' do
+      subject { described_class.create!(hubspot_owner_id,
+                                        hs_meeting_title,
+                                        hs_meeting_body,
+                                        'invalid',
+                                        hs_meeting_end_time) }
+
+      it 'raises an error' do
+        VCR.use_cassette 'meeting_error' do
+          expect { subject }.to raise_error(Hubspot::RequestError)
+        end
+      end
+    end
+  end
+
+  describe '#destroy!' do
+    let(:meeting) do
+      Hubspot::Meeting.create!(hubspot_owner_id,
+                              hs_meeting_title,
+                              hs_meeting_body,
+                              hs_meeting_start_time,
+                              hs_meeting_end_time)
+    end
+
+    it "should be destroyed" do
+      VCR.use_cassette 'meeting_destroy' do
+        expect(Hubspot::Meeting.destroy!(meeting[:id])).to be_truthy
+      end
+    end
+  end
+
+  describe '#associate!' do
+    let(:contact) { create :contact }
+    let(:meeting) do
+      Hubspot::Meeting.create!(hubspot_owner_id,
+                              hs_meeting_title,
+                              hs_meeting_body,
+                              hs_meeting_start_time,
+                              hs_meeting_end_time)
+    end
+
+    it "should be success" do
+      VCR.use_cassette 'meeting_associate' do
+        expect(Hubspot::Meeting.associate!(meeting[:id], contact.id)).to be_truthy
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -10,7 +10,7 @@ SimpleCov.start do
   add_filter "/.bundle/"
 end
 
-require 'dotenv/load'
+require 'dotenv'
 require 'rspec'
 require 'rspec/its'
 require 'webmock/rspec'
@@ -19,6 +19,8 @@ require 'faker'
 require 'byebug'
 require 'hubspot-api-ruby'
 
+Dotenv.load('.env.test')
+
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
 Dir["#{RSPEC_ROOT}/support/**/*.rb"].each {|f| require f}
@@ -27,10 +29,18 @@ Dir["#{RSPEC_ROOT}/support/**/*.rb"].each {|f| require f}
 Dir["#{RSPEC_ROOT}/shared_examples/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |config|
-  config.after(:each) do
-    Hubspot::Config.reset!
+  config.before(:all) do
+    Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"))
+  end
+
+  config.before(:each) do
+    Hubspot.configure(hapikey: ENV.fetch("HUBSPOT_HAPI_KEY"))
   end
 
+  # config.after(:each) do
+  #   Hubspot::Config.reset!
+  # end
+
   config.filter_run_when_matching :focus
 
   # Setup FactoryBot
@@ -40,5 +50,4 @@ RSpec.configure do |config|
   end
 
   config.extend CassetteHelper
-  config.extend TestsHelper
 end

data/spec/support/vcr.rb

@@ -1,16 +1,13 @@
 require "vcr"
 
 def vcr_record_mode
-  if ENV["VCR_RECORD"] == "1"
-    :new_episodes
-  else
-    :none
-  end
+  ENV["VCR_RECORD_MODE"]&.to_sym || :none
 end
 
 VCR.configure do |c|
   c.cassette_library_dir = "#{RSPEC_ROOT}/fixtures/vcr_cassettes"
   c.hook_into :webmock
   c.default_cassette_options = { record: vcr_record_mode }
-  c.filter_sensitive_data("<HAPI_KEY>") { ENV.fetch("HUBSPOT_HAPI_KEY", "demo") }
+  c.filter_sensitive_data("<HAPI_KEY>") { ENV.fetch("HUBSPOT_HAPI_KEY") }
+  c.filter_sensitive_data("<PORTAL_ID>") { ENV.fetch("HUBSPOT_PORTAL_ID") }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hubspot-api-ruby
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.9.0
 platform: ruby
 authors:
 - Jonathan
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-31 00:00:00.000000000 Z
+date: 2022-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -38,20 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.10'
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: dotenv
   requirement: !ruby/object:Gem::Requirement
@@ -288,6 +274,7 @@ files:
 - lib/hubspot/contact.rb
 - lib/hubspot/contact_list.rb
 - lib/hubspot/contact_properties.rb
+- lib/hubspot/custom_event.rb
 - lib/hubspot/deal.rb
 - lib/hubspot/deal_pipeline.rb
 - lib/hubspot/deal_properties.rb
@@ -297,6 +284,7 @@ files:
 - lib/hubspot/exceptions.rb
 - lib/hubspot/file.rb
 - lib/hubspot/form.rb
+- lib/hubspot/meeting.rb
 - lib/hubspot/oauth.rb
 - lib/hubspot/owner.rb
 - lib/hubspot/paged_collection.rb
@@ -319,6 +307,7 @@ files:
 - spec/lib/hubspot/contact_list_spec.rb
 - spec/lib/hubspot/contact_properties_spec.rb
 - spec/lib/hubspot/contact_spec.rb
+- spec/lib/hubspot/custom_event_spec.rb
 - spec/lib/hubspot/deal_pipeline_spec.rb
 - spec/lib/hubspot/deal_properties_spec.rb
 - spec/lib/hubspot/deal_spec.rb
@@ -327,10 +316,10 @@ files:
 - spec/lib/hubspot/event_spec.rb
 - spec/lib/hubspot/file_spec.rb
 - spec/lib/hubspot/form_spec.rb
+- spec/lib/hubspot/meeting_spec.rb
 - spec/lib/hubspot/owner_spec.rb
 - spec/lib/hubspot/properties_spec.rb
 - spec/lib/hubspot/resource_spec.rb
-- spec/lib/hubspot/topic_spec.rb
 - spec/lib/hubspot/utils_spec.rb
 - spec/lib/tasks/hubspot_spec.rb
 - spec/shared_examples/saveable_resource.rb
@@ -340,14 +329,13 @@ files:
 - spec/support/cassette_helper.rb
 - spec/support/hubspot_api_helpers.rb
 - spec/support/rake.rb
-- spec/support/tests_helper.rb
 - spec/support/vcr.rb
-homepage: http://github.com/lounna-sas/hubspot-api-ruby
+homepage: https://github.com/captaincontrat/hubspot-api-ruby
 licenses:
 - MIT
 metadata:
-  changelog_uri: https://github.com/lounna-sas/hubspot-api-ruby/blob/master/History.md
-post_install_message: 
+  changelog_uri: https://github.com/captaincontrat/hubspot-api-ruby/blob/master/History.md
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -362,8 +350,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
-signing_key: 
+rubygems_version: 3.2.32
+signing_key:
 specification_version: 4
 summary: hubspot-api-ruby is a wrapper for the HubSpot REST API
 test_files: []

data/spec/lib/hubspot/topic_spec.rb

@@ -1,23 +0,0 @@
-describe Hubspot::Topic do
-  before do
-    Hubspot.configure(hapikey: "demo")
-  end
-
-  describe ".list" do
-    cassette "topics_list"
-    let(:topics) { Hubspot::Topic.list }
-
-    it "should have a list of topics" do
-      topics.count.should be(3)
-    end
-  end
-
-  describe ".find_by_topic_id" do
-    cassette "topics_list"
-
-    it "should find a specific topic" do
-      topic = Hubspot::Topic.find_by_topic_id(349001328)
-      topic['id'].should eq(349001328)
-    end
-  end
-end

data/spec/support/tests_helper.rb

@@ -1,17 +0,0 @@
-module TestsHelper
-  def expect_count_and_offset(&block)
-    it 'returns only the number of objects specified by count' do
-      result = block.call(count: 2)
-      expect(result.size).to eql 2
-
-      result = block.call(count: 4)
-      expect(result.size).to eql 4
-    end
-
-    it 'returns objects by a specified offset' do
-      non_offset_objects = block.call(count: 2)
-      objects_with_offset = block.call(count: 2, offset: 2)
-      expect(non_offset_objects).to_not eql objects_with_offset
-    end
-  end
-end