hubspot-api-ruby 0.8.1 → 0.9.0

data/spec/lib/hubspot/contact_properties_spec.rb

@@ -14,29 +14,8 @@ describe Hubspot::ContactProperties do
     end
   end
 
-  let(:example_groups) do
-    VCR.use_cassette('contact_properties/groups_example') do
-      HTTParty.get('https://api.hubapi.com/contacts/v2/groups?hapikey=demo').parsed_response
-    end
-  end
-
-  let(:example_properties) do
-    VCR.use_cassette('contact_properties/properties_example') do
-      HTTParty.get('https://api.hubapi.com/contacts/v2/properties?hapikey=demo').parsed_response
-    end
-  end
-
-  before { Hubspot.configure(hapikey: 'demo') }
-
   describe 'Properties' do
     describe '.all' do
-      context 'with no filter' do
-        cassette 'contact_properties/all_properties'
-
-        it 'should return all properties' do
-          expect(Hubspot::ContactProperties.all).to eql(example_properties)
-        end
-      end
 
       let(:groups) { %w(calltrackinginfo emailinformation) }
 
@@ -133,7 +112,7 @@ describe Hubspot::ContactProperties do
         cassette 'contact_properties/delete_non_property'
 
         it 'should raise an error' do
-          expect { Hubspot::ContactProperties.delete!(name) }.to raise_error(Hubspot::RequestError)
+          expect { Hubspot::ContactProperties.delete!(name) }.to raise_error(Hubspot::NotFoundError)
         end
       end
     end
@@ -141,14 +120,6 @@ describe Hubspot::ContactProperties do
 
   describe 'Groups' do
     describe '.groups' do
-      context 'with no filter' do
-        cassette 'contact_properties/all_groups'
-
-        it 'should return all groups' do
-          expect(Hubspot::ContactProperties.groups).to eql(example_groups)
-        end
-      end
-
       let(:groups) { %w(calltrackinginfo emailinformation) }
 
       context 'with included groups' do
@@ -193,10 +164,10 @@ describe Hubspot::ContactProperties do
 
         let(:sub_params) { params.select { |k, _| k != 'displayName' } }
 
-        it 'should return the valid parameters' do
-          params['name'] = 'ff_group234'
+        it 'should return the valid parameters' do |example|
+          params['name'] = "ff_group_#{SecureRandom.hex}"
           response       = Hubspot::ContactProperties.create_group!(sub_params)
-          expect(Hubspot::ContactProperties.same?(response, sub_params)).to be true
+          expect(Hubspot::ContactProperties.same?(response.except("name"), sub_params.except("name"))).to be true
         end
       end
     end
@@ -237,7 +208,7 @@ describe Hubspot::ContactProperties do
         cassette 'contact_properties/delete_non_group'
 
         it 'should raise an error' do
-          expect { Hubspot::ContactProperties.delete_group!(name) }.to raise_error(Hubspot::RequestError)
+          expect { Hubspot::ContactProperties.delete_group!(name) }.to raise_error(Hubspot::NotFoundError)
         end
       end
     end

data/spec/lib/hubspot/contact_spec.rb

@@ -1,7 +1,5 @@
 RSpec.describe Hubspot::Contact do
 
-  before{ Hubspot.configure(hapikey: 'demo') }
-
   it_behaves_like "a saveable resource", :contact do
     def set_property(contact)
       contact.firstname = "foobar"
@@ -35,7 +33,7 @@ RSpec.describe Hubspot::Contact do
       it 'raises an error' do
         expect {
           subject
-        }.to raise_error(Hubspot::RequestError, /contact does not exist/)
+        }.to raise_error(Hubspot::NotFoundError, /contact does not exist/)
       end
     end
   end

data/spec/lib/hubspot/custom_event_spec.rb

@@ -0,0 +1,27 @@
+RSpec.describe Hubspot::CustomEvent do
+  let(:portal_id) { '62515' }
+  let(:sent_portal_id) { portal_id }
+  before { Hubspot.configure(hapikey: 'demo', custom_event_prefix: 'foobar') }
+
+  describe '.trigger' do
+    let(:event_name) { 'my_awesome_event' }
+    let(:email) { 'testingapis@hubspot.com' }
+    let(:properties) { { prop_foo: 'bar' } }
+    let(:options) { {} }
+    let(:base_url) { 'https://api.hubapi.com' }
+    let(:url) { "#{base_url}/events/v3/send?hapikey=demo" }
+
+    subject { described_class.trigger(event_name, email, properties, options) }
+
+    before { stub_request(:post, url).to_return(status: 204, body: JSON.generate({})) }
+
+    it('sends a request to trigger the event') { is_expected.to be true }
+
+    context 'with headers' do
+      let(:headers) { { 'User-Agent' => 'something' } }
+      let(:options) { { headers: headers } }
+
+      it('sends headers') { is_expected.to be true }
+    end
+  end
+end

data/spec/lib/hubspot/deal_pipeline_spec.rb

@@ -1,17 +1,13 @@
 RSpec.describe Hubspot::DealPipeline do
-  before do
-    Hubspot.configure hapikey: 'demo'
-  end
 
   describe ".find" do
     it "retrieves a record by id" do
       VCR.use_cassette("find_deal_pipeline") do
-        deal_pipeline = Hubspot::DealPipeline.create!(label: "New Pipeline")
+        deal_pipeline = Hubspot::DealPipeline.create!(label: "New Pipeline #{SecureRandom.hex}")
         id = deal_pipeline.pipeline_id
 
         result = Hubspot::DealPipeline.find(deal_pipeline.pipeline_id)
 
-        assert_requested :get, hubspot_api_url("/deals/v1/pipelines/#{id}")
         expect(result).to be_a(Hubspot::DealPipeline)
 
         deal_pipeline.destroy!
@@ -22,11 +18,10 @@ RSpec.describe Hubspot::DealPipeline do
   describe ".all" do
     it "returns a list" do
       VCR.use_cassette("all_deal_pipelines") do
-        deal_pipeline = Hubspot::DealPipeline.create!(label: "New Pipeline")
+        deal_pipeline = Hubspot::DealPipeline.create!(label: "New Pipeline #{SecureRandom.hex}")
 
         results = Hubspot::DealPipeline.all
 
-        assert_requested :get, hubspot_api_url("/deals/v1/pipelines")
         expect(results).to be_kind_of(Array)
         expect(results.first).to be_a(Hubspot::DealPipeline)
 
@@ -38,9 +33,8 @@ RSpec.describe Hubspot::DealPipeline do
   describe ".create!" do
     it "creates a new record" do
       VCR.use_cassette("create_deal_pipeline") do
-        result = Hubspot::DealPipeline.create!(label: "New Pipeline")
+        result = Hubspot::DealPipeline.create!(label: "New Pipeline #{SecureRandom.hex}")
 
-        assert_requested :post, hubspot_api_url("/deals/v1/pipelines")
         expect(result).to be_a(Hubspot::DealPipeline)
 
         result.destroy!
@@ -51,12 +45,11 @@ RSpec.describe Hubspot::DealPipeline do
   describe "#destroy!" do
     it "deletes the record" do
       VCR.use_cassette("delete_deal_pipeline") do
-        deal_pipeline = Hubspot::DealPipeline.create!(label: "New Pipeline")
+        deal_pipeline = Hubspot::DealPipeline.create!(label: "New Pipeline #{SecureRandom.hex}")
         id = deal_pipeline.pipeline_id
 
         result = deal_pipeline.destroy!
 
-        assert_requested :delete, hubspot_api_url("/deals/v1/pipelines/#{id}")
         expect(result).to be_a(HTTParty::Response)
       end
     end
@@ -78,8 +71,4 @@ RSpec.describe Hubspot::DealPipeline do
       expect(result).to eq(data["stages"][0])
     end
   end
-
-  def hubspot_api_url(path)
-    URI.join(Hubspot::Config.base_url, path, "?hapikey=demo")
-  end
 end

data/spec/lib/hubspot/deal_properties_spec.rb

@@ -14,30 +14,9 @@ describe Hubspot::DealProperties do
     end
   end
 
-  let(:example_groups) do
-    VCR.use_cassette('deal_groups_example') do
-      HTTParty.get('https://api.hubapi.com/deals/v1/groups?hapikey=demo').parsed_response
-    end
-  end
-
-  let(:example_properties) do
-    VCR.use_cassette('deal_properties_example') do
-      HTTParty.get('https://api.hubapi.com/deals/v1/properties?hapikey=demo').parsed_response
-    end
-  end
-
-  before { Hubspot.configure(hapikey: 'demo') }
 
   describe 'Properties' do
     describe '.all' do
-      context 'with no filter' do
-        cassette 'deal_all_properties'
-
-        it 'should return all properties' do
-          expect(Hubspot::DealProperties.all).to eql(example_properties)
-        end
-      end
-
       let(:groups) { %w(calltrackinginfo emailinformation) }
 
       context 'with included groups' do
@@ -60,31 +39,13 @@ describe Hubspot::DealProperties do
     end
 
     let(:params) { {
-      'name'                          => 'my_new_property',
+      'name'                          => "my_new_property_#{SecureRandom.hex}",
       'label'                         => 'This is my new property',
       'description'                   => 'How much money do you have?',
       'groupName'                     => 'dealinformation',
       'type'                          => 'string',
       'fieldType'                     => 'text',
       'hidden'                        => false,
-      'options'                       => [{
-                                            'description'  => '',
-                                            'value'        => 'Over $50K',
-                                            'readOnly'     => false,
-                                            'label'        => 'Over $50K',
-                                            'displayOrder' => 0,
-                                            'hidden'       => false,
-                                            'doubleData'   => 0.0
-                                          },
-                                          {
-                                            'description'  => '',
-                                            'value'        => 'Under $50K',
-                                            'readOnly'     => false,
-                                            'label'        => 'Under $50K',
-                                            'displayOrder' => 1,
-                                            'hidden'       => false,
-                                            'doubleData'   => 0.0
-                                          }],
       'deleted'                       => false,
       'displayOrder'                  => 0,
       'formField'                     => true,
@@ -110,7 +71,7 @@ describe Hubspot::DealProperties do
 
         it 'should return the valid parameters' do
           response = Hubspot::DealProperties.create!(params)
-          expect(Hubspot::DealProperties.same?(params, response)).to be true
+          expect(Hubspot::DealProperties.same?(params.except("name"), response.compact.except("name", "options"))).to be true
         end
       end
     end
@@ -127,22 +88,22 @@ describe Hubspot::DealProperties do
         cassette 'deal_update_property'
 
         it 'should return the valid parameters' do
+          properties = Hubspot::DealProperties.create!(params)
           params['description'] = 'What is their favorite flavor?'
 
-          response = Hubspot::DealProperties.update!(params['name'], params)
-          expect(Hubspot::DealProperties.same?(response, params)).to be true
+          response = Hubspot::DealProperties.update!(properties['name'], params)
+          expect(Hubspot::DealProperties.same?(response.compact.except("name"), params.except("name"))).to be true
         end
       end
     end
 
     describe '.delete!' do
-      let(:name) { params['name'] }
-
       context 'with existing property' do
         cassette 'deal_delete_property'
 
         it 'should return nil' do
-          expect(Hubspot::DealProperties.delete!(name)).to eq(nil)
+          properties = Hubspot::DealProperties.create!(params)
+          expect(Hubspot::DealProperties.delete!(properties["name"])).to eq(nil)
         end
       end
 
@@ -150,7 +111,7 @@ describe Hubspot::DealProperties do
         cassette 'deal_delete_non_property'
 
         it 'should raise an error' do
-          expect { Hubspot::DealProperties.delete!(name) }.to raise_error(Hubspot::RequestError)
+          expect { Hubspot::DealProperties.delete!("i_do_not_exist") }.to raise_error(Hubspot::NotFoundError)
         end
       end
     end
@@ -158,14 +119,6 @@ describe Hubspot::DealProperties do
 
   describe 'Groups' do
     describe '.groups' do
-      context 'with no filter' do
-        cassette 'deal_all_groups'
-
-        it 'should return all groups' do
-          expect(Hubspot::DealProperties.groups).to eql(example_groups)
-        end
-      end
-
       let(:groups) { %w(calltrackinginfo emailinformation) }
 
       context 'with included groups' do
@@ -211,9 +164,9 @@ describe Hubspot::DealProperties do
         let(:sub_params) { params.select { |k, _| k != 'displayName' } }
 
         it 'should return the valid parameters' do
-          params['name'] = 'ff_group234'
+          params['name'] = "ff_group_#{SecureRandom.hex}"
           response       = Hubspot::DealProperties.create_group!(sub_params)
-          expect(Hubspot::DealProperties.same?(response, sub_params)).to be true
+          expect(Hubspot::DealProperties.same?(response.except("name"), sub_params.except("name"))).to be true
         end
       end
     end
@@ -254,7 +207,7 @@ describe Hubspot::DealProperties do
         cassette 'deal_delete_non_group'
 
         it 'should raise an error' do
-          expect { Hubspot::DealProperties.delete_group!(name) }.to raise_error(Hubspot::RequestError)
+          expect { Hubspot::DealProperties.delete_group!(name) }.to raise_error(Hubspot::NotFoundError)
         end
       end
     end

data/spec/lib/hubspot/deal_spec.rb

@@ -1,25 +1,12 @@
 describe Hubspot::Deal do
-  let(:portal_id) { 62515 }
-  let(:company_id) { 8954037 }
-  let(:vid) { 27136 }
+  let(:portal_id) { ENV.fetch("HUBSPOT_PORTAL_ID").to_i }
+  let(:company) { Hubspot::Company.create(name: SecureRandom.hex) }
+  let(:company_id) { company.id }
+  let(:contact) { Hubspot::Contact.create("#{SecureRandom.hex}@hubspot.com") }
+  let(:vid) { contact.id }
   let(:amount) { '30' }
   let(:deal) { Hubspot::Deal.create!(portal_id, [company_id], [vid], { amount: amount}) }
 
-  let(:example_deal_hash) do
-    VCR.use_cassette("deal_example") do
-      HTTParty.get("https://api.hubapi.com/deals/v1/deal/3?hapikey=demo&portalId=#{portal_id}").parsed_response
-    end
-  end
-
-  before { Hubspot.configure(hapikey: 'demo') }
-
-  describe "#initialize" do
-    subject{ Hubspot::Deal.new(example_deal_hash) }
-    it  { should be_an_instance_of Hubspot::Deal }
-    its (:portal_id) { should == portal_id }
-    its (:deal_id) { should == 3 }
-  end
-
   describe ".create!" do
     cassette "deal_create"
     subject { Hubspot::Deal.create!(portal_id, [company_id], [vid], {}) }
@@ -107,13 +94,10 @@ describe Hubspot::Deal do
       end
     end
   end
-  
-  
+
   describe '.associate' do
     cassette
     let(:deal) { Hubspot::Deal.create!(portal_id, [], [], {}) }
-    let(:company) { create :company }
-    let(:contact) { create :contact }
     let(:contact_id) { contact.id }
 
     subject { Hubspot::Deal.associate!(deal.deal_id, [company.id], [contact_id]) }
@@ -128,10 +112,10 @@ describe Hubspot::Deal do
     context 'when an id is invalid' do
       let(:contact_id) { 1234 }
 
-      it 'raises an error and do not changes associations' do
-        expect { subject }.to raise_error(Hubspot::RequestError)
+      it 'returns false and changes valid associations' do
+        expect(subject).to eq(false)
         find_deal = Hubspot::Deal.find(deal.deal_id)
-        find_deal.company_ids.should eql []
+        find_deal.company_ids.should eql [company.id]
         find_deal.vids.should eql []
       end
     end
@@ -149,7 +133,6 @@ describe Hubspot::Deal do
 
   describe '.find_by_company' do
     cassette
-    let(:company) { create :company }
     let!(:deal) { Hubspot::Deal.create!(portal_id, [company.id], [], { amount: amount }) }
 
     it 'returns company deals' do
@@ -161,7 +144,6 @@ describe Hubspot::Deal do
 
   describe '.find_by_contact' do
     cassette
-    let(:contact) { create :contact }
     let!(:deal) { Hubspot::Deal.create!(portal_id, [], [contact.id], { amount: amount }) }
 
     it 'returns contact deals' do
@@ -175,52 +157,28 @@ describe Hubspot::Deal do
     cassette 'find_all_recent_updated_deals'
 
     it 'must get the recents updated deals' do
+      deal
       deals = Hubspot::Deal.recent
 
       first = deals.first
-      last = deals.last
 
       expect(first).to be_a Hubspot::Deal
-      expect(first.properties['amount']).to eql '0'
-      expect(first.properties['dealname']).to eql '1420787916-gou2rzdgjzx2@u2rzdgjzx2.com'
-      expect(first.properties['dealstage']).to eql 'closedwon'
-
-      expect(last).to be_a Hubspot::Deal
-      expect(last.properties['amount']).to eql '250'
-      expect(last.properties['dealname']).to eql '1420511993-U9862RD9XR@U9862RD9XR.com'
-      expect(last.properties['dealstage']).to eql 'closedwon'
     end
 
     it 'must filter only 2 deals' do
+      3.times { Hubspot::Deal.create!(portal_id, [company_id], [vid], { amount: amount}) }
       deals = Hubspot::Deal.recent(count: 2)
       expect(deals.size).to eql 2
     end
 
-    it 'it must offset the deals' do
-      deal = Hubspot::Deal.recent(count: 1, offset: 1).first
-      expect(deal.properties['dealname']).to eql '1420704406-goy6v83a97nr@y6v83a97nr.com'  # the third deal
-    end
   end
 
   describe "#destroy!" do
     it "should remove from hubspot" do
       VCR.use_cassette("destroy_deal") do
         result = deal.destroy!
-
-        assert_requested :delete, hubspot_api_url("/deals/v1/deal/#{deal.deal_id}?hapikey=demo")
-
         expect(result).to be true
       end
     end
   end
-
-  describe '#[]' do
-    subject{ Hubspot::Deal.new(example_deal_hash) }
-
-    it 'should get a property' do
-      subject.properties.each do |property, value|
-        expect(subject[property]).to eql value
-      end
-    end
-  end
 end

data/spec/lib/hubspot/engagement_spec.rb

@@ -1,7 +1,10 @@
 describe Hubspot::Engagement do
+
+  let(:contact) { Hubspot::Contact.create("#{SecureRandom.hex}@hubspot.com") }
+  let(:engagement) { Hubspot::EngagementNote.create!(contact.id, "foo") }
   let(:example_engagement_hash) do
     VCR.use_cassette("engagement_example") do
-      HTTParty.get("https://api.hubapi.com/engagements/v1/engagements/51484873?hapikey=demo").parsed_response
+      HTTParty.get("https://api.hubapi.com/engagements/v1/engagements/3981023?hapikey=demo").parsed_response
     end
   end
   let(:example_associated_engagement_hash) do
@@ -11,12 +14,11 @@ describe Hubspot::Engagement do
   end
 
   # http://developers.hubspot.com/docs/methods/contacts/get_contact
-  before{ Hubspot.configure(hapikey: "demo") }
 
   describe "#initialize" do
     subject{ Hubspot::Engagement.new(example_engagement_hash) }
     it  { should be_an_instance_of Hubspot::Engagement }
-    its (:id) { should == 51484873 }
+    its (:id) { should == 3981023 }
   end
 
   describe 'EngagementNote' do
@@ -30,7 +32,6 @@ describe Hubspot::Engagement do
 
     describe ".find" do
       cassette "engagement_find"
-      let(:engagement) {Hubspot::EngagementNote.new(example_engagement_hash)}
 
       it 'must find by the engagement id' do
         find_engagement = Hubspot::EngagementNote.find(engagement.id)
@@ -41,10 +42,18 @@ describe Hubspot::Engagement do
 
     describe ".find_by_company" do
       cassette "engagement_find_by_country"
-      let(:engagement) {Hubspot::EngagementNote.new(example_associated_engagement_hash)}
+
+      let(:company) { Hubspot::Company.create(name: SecureRandom.hex) }
+      before do
+        engagement.class.associate!(
+          engagement.id,
+          "Company",
+          company.id
+        )
+      end
 
       it 'must find by company id' do
-        find_engagements = Hubspot::EngagementNote.find_by_company(engagement.associations["companyIds"].first)
+        find_engagements = Hubspot::EngagementNote.find_by_company(company.id)
         find_engagements.should_not be_nil
         find_engagements.any?{|engagement| engagement.id == engagement.id and engagement.body == engagement.body}.should be true
       end
@@ -52,7 +61,6 @@ describe Hubspot::Engagement do
 
     describe ".find_by_contact" do
       cassette "engagement_find_by_contact"
-      let(:engagement) {Hubspot::EngagementNote.new(example_associated_engagement_hash)}
 
       it 'must find by contact id' do
         find_engagements = Hubspot::EngagementNote.find_by_contact(engagement.associations["contactIds"].first)
@@ -75,39 +83,26 @@ describe Hubspot::Engagement do
       cassette "find_all_engagements"
 
       it 'must get the engagements list' do
+        engagement
         engagements = Hubspot::Engagement.all
 
-        expect(engagements['engagements'].size).to eql 100 # default page size
-
         first = engagements['engagements'].first
-        last = engagements['engagements'].last
 
         expect(first).to be_a Hubspot::Engagement
-        expect(first.engagement['id']).to eql 3981023
-
-        expect(last).to be_a Hubspot::Engagement
-        expect(last.engagement['id']).to eql 36579065
       end
 
       it 'must filter only 2 engagements' do
+        3.times { Hubspot::EngagementNote.create!(contact.id, "foo") }
         engagements = Hubspot::Engagement.all(limit: 2)
         expect(engagements['engagements'].size).to eql 2
       end
-
-      it 'it must offset the engagements' do
-        single_list = Hubspot::Engagement.all(limit: 5)
-        expect(single_list['engagements'].size).to eql 5
-
-        second = Hubspot::Engagement.all(count: 1, offset: single_list['offset'])['engagements'].first
-        expect(second.engagement['id']).to eql 4815722
-      end
     end
 
     describe ".associate!" do
       cassette "engagement_associate"
 
       let(:engagement) { Hubspot::EngagementNote.create!(nil, 'note') }
-      let(:contact) { Hubspot::Contact.create(email: "newcontact#{Time.now.to_i}@hsgem.com") }
+      let(:contact) { Hubspot::Contact.create("#{SecureRandom.hex}@hubspot.com") }
       subject { Hubspot::Engagement.associate!(engagement.id, 'contact', contact.id) }
 
       it 'associate an engagement to a resource' do
@@ -134,12 +129,6 @@ describe Hubspot::Engagement do
   end
 
   describe 'EngagementCall' do
-    let(:example_engagement_hash) do
-      VCR.use_cassette("engagement_call_example") do
-        HTTParty.get("https://api.hubapi.com/engagements/v1/engagements/4709059?hapikey=demo").parsed_response
-      end
-    end
-
     describe ".create!" do
       cassette "engagement_call_create"
       body = "Test call"
@@ -150,10 +139,10 @@ describe Hubspot::Engagement do
 
     describe ".find" do
       cassette "engagement_call_find"
-      let(:engagement) { Hubspot::EngagementNote.new(example_engagement_hash) }
+      let(:engagement) { Hubspot::EngagementCall.create!(contact.id, "foo", 42) }
 
       it 'must find by the engagement id' do
-        find_engagement = Hubspot::EngagementNote.find(engagement.id)
+        find_engagement = Hubspot::EngagementCall.find(engagement.id)
         find_engagement.id.should eql engagement.id
         find_engagement.body.should eql engagement.body
       end

data/spec/lib/hubspot/file_spec.rb

@@ -1,38 +1,13 @@
 describe Hubspot do
-
-  let(:example_file_hash) do
-    VCR.use_cassette("file_list", record: :none) do
-      url = Hubspot::Connection.send(:generate_url, Hubspot::File::LIST_FILE_PATH)
-      resp = HTTParty.get(url, format: :json)
-      resp.parsed_response["objects"].first
-    end
-  end
-
-  before do
-    Hubspot.configure(hapikey: "demo")
-  end
-
   describe Hubspot::File do
-
+    before { Hubspot.configure(hapikey: "demo") }
     describe ".find_by_id" do
       it "should fetch specific file" do
-	VCR.use_cassette("file_find", record: :none) do
-	  file = Hubspot::File.find_by_id(example_file_hash["id"])
-	  file.id.should eq(example_file_hash["id"])
-	end
-      end
-    end
-
-    describe '#destroy!' do
-      it 'should remove from hubspot' do
-	VCR.use_cassette("file_delete", record: :none) do
-          file = Hubspot::File.find_by_id(example_file_hash["id"])
-	  res = file.destroy!
-	  expect(res["succeeded"]).to be true
-	end
+        VCR.use_cassette("file_find") do
+          file = Hubspot::File.find_by_id(5323360053)
+          file.id.should eq(5323360053)
+        end
       end
     end
-
   end
-
 end