houston-core 0.6.0 → 0.6.1

data/lib/configuration.rb

@@ -186,8 +186,9 @@ module Houston
 
 
     def project_colors(*args)
-      @project_colors = args.first.each_with_object({}) { |(key, hex), hash| hash[key] = ColorValue.new(hex) } if args.any?
-      @project_colors ||= {}
+      new_hash = Hash.new(ColorValue.new("505050"))
+      @project_colors = args.first.each_with_object(new_hash) { |(key, hex), hash| hash[key] = ColorValue.new(hex) } if args.any?
+      @project_colors ||= new_hash
     end
 
     def environments(*args)
@@ -600,6 +601,7 @@ module Houston
 
 
   class ColorValue
+    attr_reader :hex
 
     def initialize(hex)
       @hex = hex

data/lib/core_ext/array.rb

@@ -0,0 +1,37 @@
+module CalculatePercentiles
+
+  # Returns the mean of all elements in array; nil if array is empty
+  def mean
+    return nil if self.length == 0
+    self.sum / self.length
+  end
+
+  # Returns the percentile value for percentile _p_; nil if array is empty.
+  #
+  # _p_ should be expressed as an integer; <tt>percentile(90)</tt> returns the 90th percentile of the array.
+  #
+  # Algorithm from NIST[http://www.itl.nist.gov/div898/handbook/prc/section2/prc252.htm]
+  # Implementation from https://github.com/bkoski/array_stats/pull/3
+  def percentile(p)
+    sorted_array = self.sort
+    rank = (p.to_f / 100) * (self.length + 1)
+
+    return nil if self.length == 0
+
+    if rank.truncate > 0 && rank.truncate < self.length
+      sample_0 = sorted_array[rank.truncate - 1]
+      sample_1 = sorted_array[rank.truncate]
+
+      # Returns the fractional part of a float. For example, <tt>(6.67).fractional_part == 0.67</tt>
+      fractional_part =  (rank - rank.truncate).abs
+      (fractional_part * (sample_1 - sample_0)) + sample_0
+    elsif rank.truncate == 0
+      sorted_array.first.to_f
+    elsif rank.truncate == self.length
+      sorted_array.last.to_f
+    end
+  end
+
+end
+
+Array.send :include, CalculatePercentiles

data/lib/houston/version.rb

@@ -1,3 +1,3 @@
 module Houston
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

data/test/integration/ci_integration_test.rb

@@ -4,6 +4,7 @@ require "support/houston/adapters/ci_server/mock_adapter"
 
 # Tests config/initializers/run_tests_on_post_receive.rb
 class CIIntegrationTest < ActionDispatch::IntegrationTest
+  attr_reader :project
 
 
   context "Houston" do
@@ -14,7 +15,7 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
       stub.instance_of(TestRun).validate! {}
 
       assert_difference "TestRun.count", +1 do
-        post "/projects/#{@project.slug}/hooks/post_receive"
+        post "/projects/#{project.slug}/hooks/post_receive"
         assert_response :success
       end
     end
@@ -23,7 +24,7 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
       @project = create(:project, ci_server_name: "None")
 
       assert_no_difference "TestRun.count" do
-        post "/projects/#{@project.slug}/hooks/post_receive"
+        post "/projects/#{project.slug}/hooks/post_receive"
         assert_response :success
       end
     end
@@ -31,7 +32,7 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
     should "alert maintainers when a build cannot be triggered" do
       skip "TMI: This is dependent on configured roles!"
       @project = create(:project, ci_server_name: "Mock")
-      @project.add_teammate users(:boblail)
+      project.add_teammate users(:boblail)
 
       any_instance_of(Houston::Adapters::CIServer::MockAdapter::Job) do |job|
         stub(job).build! { |commit| raise Houston::Adapters::CIServer::Error }
@@ -41,7 +42,7 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
       stub.instance_of(TestRun).validate! {}
 
       assert_no_difference "TestRun.count" do
-        post "/projects/#{@project.slug}/hooks/post_receive"
+        post "/projects/#{project.slug}/hooks/post_receive"
         assert_response :success
 
         configuration_error = ActionMailer::Base.deliveries.last
@@ -56,13 +57,13 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
       commit = "whatever"
       results_url = "http://example.com/results"
       @project = create(:project, ci_server_name: "Mock")
-      @test_run = TestRun.create!(project: @project, sha: commit)
+      @test_run = TestRun.create!(project: project, sha: commit)
 
       any_instance_of(Houston::Adapters::CIServer::MockAdapter::Job) do |job|
         mock(job).fetch_results!(results_url).returns({})
       end
 
-      post "/projects/#{@project.slug}/hooks/post_build", {commit: commit, results_url: results_url}
+      put "/projects/#{project.slug}/test_runs/#{commit}/results", {results_url: results_url}
       assert_response :success
     end
 
@@ -70,14 +71,14 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
       commit = "whatever"
       results_url = "http://example.com/results"
       @project = create(:project, ci_server_name: "Mock")
-      @project.add_teammate users(:boblail)
-      @test_run = TestRun.create!(project: @project, sha: commit)
+      project.add_teammate users(:boblail)
+      @test_run = TestRun.create!(project: project, sha: commit)
 
       any_instance_of(Houston::Adapters::CIServer::MockAdapter::Job) do |job|
         mock(job).fetch_results!(results_url) { raise Houston::Adapters::CIServer::Error }
       end
 
-      post "/projects/#{@project.slug}/hooks/post_build", {commit: commit, results_url: results_url}
+      put "/projects/#{project.slug}/test_runs/#{commit}/results", {results_url: results_url}
 
       assert_equal "error", @test_run.reload.result
     end
@@ -86,7 +87,7 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
 
     should "fire test_run:complete when the results of the test run are saved" do
       @project = create(:project, ci_server_name: "Mock")
-      test_run = TestRun.new(project: @project, sha: "whatever")
+      test_run = TestRun.new(project: project, sha: "whatever")
 
       any_instance_of(Houston::Adapters::CIServer::MockAdapter::Job) do |job|
         stub(job).fetch_results! { |results_url| {result: "pass"} }
@@ -119,7 +120,7 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
           slug: "fixture",
           version_control_name: "Git",
           extended_attributes: { "git_location" => "git@github.com:houston/fixture.git" })
-        test_run = TestRun.new(project: @project, sha: "bd3e9e2")
+        test_run = TestRun.new(project: project, sha: "bd3e9e2")
 
         expected_url = "https://api.github.com/repos/houston/fixture/statuses/bd3e9e2e4ddf89a640a4f880cbf55bb46cc7e88a?access_token=#{Houston.config.github[:access_token]}"
         mock(Faraday).post(expected_url, /"state":"pending"/) do
@@ -140,7 +141,7 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
           slug: "fixture",
           version_control_name: "Git",
           extended_attributes: { "git_location" => "git@github.com:houston/fixture.git" })
-        test_run = TestRun.new(project: @project, sha: "bd3e9e2", result: :pass, completed_at: Time.now)
+        test_run = TestRun.new(project: project, sha: "bd3e9e2", result: :pass, completed_at: Time.now)
 
         expected_url = "https://api.github.com/repos/houston/fixture/statuses/bd3e9e2e4ddf89a640a4f880cbf55bb46cc7e88a?access_token=#{Houston.config.github[:access_token]}"
         mock(Faraday).post(expected_url, /"state":"success"/) do
@@ -154,7 +155,7 @@ class CIIntegrationTest < ActionDispatch::IntegrationTest
 
     should "publish test results to CodeClimate" do
       @project = create(:project, code_climate_repo_token: "repo_token")
-      test_run = TestRun.new(project: @project, sha: "bd3e9e2", result: "pass", completed_at: Time.now, coverage: [
+      test_run = TestRun.new(project: project, sha: "bd3e9e2", result: "pass", completed_at: Time.now, coverage: [
         { filename: "lib/test1.rb", coverage: [1,nil,nil,1,1,nil,1] },
         { filename: "lib/test2.rb", coverage: [1,nil,1,0,0,0,0,1,nil,1] }
       ])

data/test/unit/models/project_test.rb

@@ -5,6 +5,7 @@ require "support/houston/adapters/ci_server/mock_adapter"
 
 
 class ProjectTest < ActiveSupport::TestCase
+  attr_reader :project
 
 
   context "Validation:" do
@@ -55,4 +56,36 @@ class ProjectTest < ActiveSupport::TestCase
   end
 
 
+  context "A project's bare repo," do
+    setup do
+      system "rm -rf #{Rails.root}/tmp/test-01.git"
+      system "cp -r #{Rails.root}/test/data/bare_repo.git #{Rails.root}/tmp/test-01.git"
+      @project = Project.create!(
+        name: "Test",
+        slug: "test-01",
+        version_control_name: "Git",
+        extended_attributes:  {"git_location" => "git@github.com:houston/fixture.git"})
+    end
+
+    teardown do
+      system "rm -rf #{Rails.root}/tmp/test-*.git"
+    end
+
+    context "when the project's slug is changed," do
+      should "be moved" do
+        project.update_attributes slug: "test-02"
+        test01_exists = File.exists?("#{Rails.root}/tmp/test-01.git")
+        test02_exists = File.exists?("#{Rails.root}/tmp/test-02.git")
+
+        problems = []
+        problems << "tmp/test-01.git still exists" if test01_exists
+        problems << "tmp/test-02.git does not exist" unless test02_exists
+
+        assert problems.none?, "Expected tmp/test-01.git to have been renamed " <<
+          "to test-02.git, but #{problems.join(" and ")}"
+      end
+    end
+  end
+
+
 end

data/test/unit/models/pull_request_test.rb

@@ -63,9 +63,11 @@ class PullRequestTest < ActiveSupport::TestCase
       end
     end
 
+
+
     context "If there is already a local copy of that pull request," do
       setup do
-        Github::PullRequest.create! { |pull|
+        @pull_request = Github::PullRequest.create! { |pull|
           pull.merge_attributes @pull_request_payload }
       end
 
@@ -80,6 +82,74 @@ class PullRequestTest < ActiveSupport::TestCase
           assert_match /has already been taken/, pull_request.errors.full_messages.join(", ")
         end
       end
+
+
+
+      context "when the pull request is synchronized," do
+        context "and base_sha changes, it" do
+          setup do
+            pull_request.merge_attributes(
+              "user" => {},
+              "title" => "Divergent Branch",
+              "body" => "This is the description of the pull request",
+              "base" => { "sha" => "a5c551d52bb0bb8a702f70879ac9caeb12a721fc" },
+              "head" => { "sha" => "baa3ef218a40f23fe542f98d8b8e60a2e8e0bff0" })
+          end
+
+          should "associate itself with all the commits again" do
+            mock(pull_request.project.commits).between(
+              "a5c551d52bb0bb8a702f70879ac9caeb12a721fc",
+              "baa3ef218a40f23fe542f98d8b8e60a2e8e0bff0").once.returns([])
+            pull_request.save!
+          end
+
+          should "fire 'github:pull:synchronize'" do
+            assert_triggered "github:pull:synchronize" do
+              pull_request.save!
+            end
+          end
+        end
+
+        context "and head_sha changes, it" do
+          setup do
+            pull_request.merge_attributes(
+              "user" => {},
+              "title" => "Divergent Branch",
+              "body" => "This is the description of the pull request",
+              "base" => { "sha" => "e0e4580f44317a084dd5142fef6b4144a4394819" },
+              "head" => { "sha" => "a5c551d52bb0bb8a702f70879ac9caeb12a721fc" })
+          end
+
+          should "associate itself with all the commits again" do
+            mock(pull_request.project.commits).between(
+              "e0e4580f44317a084dd5142fef6b4144a4394819",
+              "a5c551d52bb0bb8a702f70879ac9caeb12a721fc").once.returns([])
+            pull_request.save!
+          end
+
+          should "fire 'github:pull:synchronize'" do
+            assert_triggered "github:pull:synchronize" do
+              pull_request.save!
+            end
+          end
+        end
+
+        context "and neither base_sha nor head_sha changes, it" do
+          setup do
+            pull_request.merge_attributes(
+              "user" => {},
+              "title" => "Divergent Branch",
+              "body" => "This is the description of the pull request",
+              "base" => { "sha" => "e0e4580f44317a084dd5142fef6b4144a4394819" },
+              "head" => { "sha" => "baa3ef218a40f23fe542f98d8b8e60a2e8e0bff0" })
+          end
+
+          should "not associate itself with all the commits again" do
+            mock(pull_request.project.commits).between.never
+            pull_request.save!
+          end
+        end
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: houston-core
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Bob Lail
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-14 00:00:00.000000000 Z
+date: 2016-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.5
+        version: 4.2.5.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.5
+        version: 4.2.5.1
 - !ruby/object:Gem::Dependency
   name: sprockets
   requirement: !ruby/object:Gem::Requirement
@@ -184,14 +184,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.10
+        version: 0.9.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.10
+        version: 0.9.2
 - !ruby/object:Gem::Dependency
   name: faraday-http-cache
   requirement: !ruby/object:Gem::Requirement
@@ -280,16 +280,16 @@ dependencies:
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.6.2
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.6.2
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: houston-oauth-plugin
   requirement: !ruby/object:Gem::Requirement
@@ -775,6 +775,7 @@ files:
 - app/assets/images/bug-open-32.png
 - app/assets/images/bug-zero-128.png
 - app/assets/images/bug-zero-48.png
+- app/assets/images/drag-grip.png
 - app/assets/javascripts/app/boot.coffee
 - app/assets/javascripts/app/emoji.coffee.erb
 - app/assets/javascripts/app/infinite_scroll.coffee
@@ -787,8 +788,6 @@ files:
 - app/assets/javascripts/app/models/user.coffee
 - app/assets/javascripts/app/mousetrap-bind-scoped.js
 - app/assets/javascripts/app/releases.coffee
-- app/assets/javascripts/app/stacked_area_graph.coffee
-- app/assets/javascripts/app/stacked_bar_graph.coffee
 - app/assets/javascripts/app/table_row_expander.coffee
 - app/assets/javascripts/app/ticket_tracker_refresh.coffee
 - app/assets/javascripts/app/views/_show_sprint_view.coffee
@@ -817,6 +816,8 @@ files:
 - app/assets/javascripts/core/handlebars_helpers.coffee
 - app/assets/javascripts/core/helpers.coffee
 - app/assets/javascripts/core/jquery_extensions.coffee
+- app/assets/javascripts/core/stacked_area_graph.coffee
+- app/assets/javascripts/core/stacked_bar_graph.coffee
 - app/assets/javascripts/dashboard.js
 - app/assets/javascripts/dashboard/refresher.coffee
 - app/assets/javascripts/vendor.js
@@ -875,6 +876,7 @@ files:
 - app/assets/stylesheets/dashboard.css
 - app/assets/stylesheets/dashboard/dashboard.scss
 - app/assets/stylesheets/print.css.scss
+- app/assets/stylesheets/variables.scss
 - app/assets/stylesheets/vendor.css
 - app/assets/templates/commit.hbs
 - app/assets/templates/keyboard_shortcuts.hbs
@@ -913,6 +915,7 @@ files:
 - app/concerns/retirement.rb
 - app/concerns/ticket_synchronizer.rb
 - app/concerns/unique_add.rb
+- app/controllers/api/v1/projects_controller.rb
 - app/controllers/api/v1/sprint_tasks_controller.rb
 - app/controllers/api/v1/ticket_tasks_controller.rb
 - app/controllers/application_controller.rb
@@ -1011,7 +1014,6 @@ files:
 - app/models/github/pull_request_event.rb
 - app/models/github/unauthorized.rb
 - app/models/github_token.rb
-- app/models/historical_head.rb
 - app/models/key_dependency.rb
 - app/models/maintenance_light.rb
 - app/models/measurement.rb
@@ -1056,6 +1058,7 @@ files:
 - app/presenters/full_ticket_presenter.rb
 - app/presenters/one_or_many.rb
 - app/presenters/problem_presenter.rb
+- app/presenters/project_presenter.rb
 - app/presenters/release_presenter.rb
 - app/presenters/sprint_task_presenter.rb
 - app/presenters/task_presenter.rb
@@ -1131,7 +1134,9 @@ files:
 - app/views/releases/_changelog.html.erb
 - app/views/releases/_commits.html.erb
 - app/views/releases/_form.html.erb
+- app/views/releases/_index.html.erb
 - app/views/releases/_new_release.html.erb
+- app/views/releases/_results.html.erb
 - app/views/releases/_tickets.html.erb
 - app/views/releases/edit.html.erb
 - app/views/releases/index.html.erb
@@ -1392,10 +1397,15 @@ files:
 - db/migrate/20151205214647_add_avatar_url_to_pull_requests.rb
 - db/migrate/20151209004458_add_json_labels_to_pull_requests.rb
 - db/migrate/20151209030113_add_timestamps_to_pull_requests.rb
+- db/migrate/20151226154901_add_search_vector_to_releases.rb
+- db/migrate/20151226155305_generate_index_on_releases.rb
+- db/migrate/20151228183704_drop_unused_tables.rb
+- db/migrate/20160120145757_add_successful_to_deploys.rb
 - db/seeds.rb
 - db/structure.sql
 - houston.gemspec
 - lib/configuration.rb
+- lib/core_ext/array.rb
 - lib/core_ext/duration.rb
 - lib/core_ext/exception.rb
 - lib/core_ext/hash.rb
@@ -3449,7 +3459,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Mission Control for your projects and teams