houston-core 0.6.0 → 0.6.1

data/app/concerns/belongs_to_commit.rb

@@ -7,6 +7,20 @@ module BelongsToCommit
     validates :sha, presence: {message: "must refer to a commit"}
   end
 
+  module ClassMethods
+    def find_by_sha!(sha)
+      find_by_sha(sha) || raise(ActiveRecord::RecordNotFound)
+    end
+
+    def find_by_sha(sha)
+      with_sha_like(sha).first if sha
+    end
+
+    def with_sha_like(sha)
+      where(["sha LIKE ?", "#{sha.strip}%"])
+    end
+  end
+
 private
 
   def identify_commit

data/app/concerns/project_adapter.rb

@@ -18,6 +18,7 @@ module ProjectAdapter
       adapter.define_methods!
 
       validate adapter.validation_method
+      before_update adapter.before_update_method
     end
   end
 
@@ -41,6 +42,18 @@ module ProjectAdapter
       :"#{attribute_name}_configuration_is_valid"
     end
 
+    def before_update_method
+      :"#{attribute_name}_before_update"
+    end
+
+    def adapter_method
+      :"#{attribute_name}_adapter"
+    end
+
+    def params_method
+      :"parameters_for_#{attribute_name}_adapter"
+    end
+
     def define_methods!
       model.module_eval <<-RUBY
         def self.with_#{attribute_name}
@@ -52,24 +65,29 @@ module ProjectAdapter
         end
 
         def #{validation_method}
-          #{attribute_name}_adapter.errors_with_parameters(self, *parameters_for_#{attribute_name}_adapter.values).each do |attribute, messages|
+          #{adapter_method}.errors_with_parameters(self, *#{params_method}.values).each do |attribute, messages|
             errors.add(attribute, messages) if messages.any?
           end
         end
 
+        def #{before_update_method}
+          return true unless #{attribute_name}.respond_to?(:before_update)
+          #{attribute_name}.before_update(self)
+        end
+
         def #{attribute_name}
-          @#{attribute_name} ||= #{attribute_name}_adapter
-              .build(self, *parameters_for_#{attribute_name}_adapter.values)
+          @#{attribute_name} ||= #{adapter_method}
+              .build(self, *#{params_method}.values)
               .extend(FeatureSupport)
         end
 
-        def parameters_for_#{attribute_name}_adapter
-          #{attribute_name}_adapter.parameters.each_with_object({}) do |parameter, hash|
+        def #{params_method}
+          #{adapter_method}.parameters.each_with_object({}) do |parameter, hash|
             hash[parameter] = extended_attributes[parameter.to_s]
           end
         end
 
-        def #{attribute_name}_adapter
+        def #{adapter_method}
           #{namespace}.adapter(#{attribute_name}_name)
         end
       RUBY

data/app/controllers/api/v1/projects_controller.rb

@@ -0,0 +1,18 @@
+module Api
+  module V1
+    class ProjectsController < ApplicationController
+      before_filter :api_authenticate!
+      skip_before_filter :verify_authenticity_token
+
+      rescue_from ActiveRecord::RecordNotFound do
+        head 404
+      end
+
+      def index
+        @projects = Project.unretired
+        render json: ProjectPresenter.new(@projects)
+      end
+
+    end
+  end
+end

data/app/controllers/api/v1/sprint_tasks_controller.rb

@@ -21,7 +21,7 @@ module Api
       def mine
         render json: sprint.tasks
           .includes(:ticket => :project)
-          .checked_out_by(current_user)
+          .checked_out_by(current_user, during: sprint)
           .map { |task| present_task(task) }
       end
 

data/app/controllers/deploys_controller.rb

@@ -24,6 +24,7 @@ class DeploysController < ApplicationController
       branch: branch,
       deployer: deployer,
       duration: milliseconds,
+      successful: params.fetch(:successful, true),
       completed_at: Time.now)
 
     head 200

data/app/controllers/project_tests_controller.rb

@@ -2,31 +2,61 @@ class ProjectTestsController < ApplicationController
 
   def index
     @project = Project.find_by_slug! params[:slug]
+    @title = "#{@project.name} Tests"
 
     head = params.fetch :at, @project.head_sha
-    commits = params.fetch(:limit, 500).to_i
+    commits = params.fetch(:limit, 128).to_i
 
     @commits = Houston.benchmark("[project_tests#index] fetch commits") {
       @project.repo.ancestors(head, including_self: true, limit: commits) }
-    @runs = @project.test_runs.where(sha: @commits.map(&:sha))
+    shas = @commits.map(&:sha)
+    test_run_id_by_sha = Hash[@project.test_runs.where(sha: shas).pluck(:sha, :id)]
+    test_run_ids = test_run_id_by_sha.values
 
-    @tests = @project.tests.order(:suite, :name)
-      .joins(<<-SQL)
-        LEFT JOIN LATERAL (
-          SELECT COUNT(*) FROM test_results
-          WHERE test_results.test_run_id IN (#{@runs.pluck(:id).join(",")})
-          AND test_results.status='pass'
-          AND test_results.test_id=tests.id
-        ) "passes" ON TRUE
-        LEFT JOIN LATERAL (
-          SELECT COUNT(*) FROM test_results
-          WHERE test_results.test_run_id IN (#{@runs.pluck(:id).join(",")})
-          AND test_results.status='fail'
-          AND test_results.test_id=tests.id
-        ) "fails" ON TRUE
-      SQL
-      .where("passes.count + fails.count > 0")
-      .pluck("tests.id", "tests.suite", "tests.name", "passes.count", "fails.count")
+    # We're looking at the history of the tests that exist in the
+    # most recent commit; ignore tests that didn't exist before this
+    test_ids = Houston.benchmark("[project_tests#index] pick tests") do
+      latest_test_run_id = @project.test_runs.where(sha: shas)
+        .joins("LEFT OUTER JOIN test_results ON test_runs.id=test_results.test_run_id")
+        .where.not("test_results.test_run_id" => nil)
+        .limit(1)
+        .pluck(:id)
+        .first
+      TestResult.where(test_run_id: latest_test_run_id).pluck("DISTINCT test_id")
+    end
+
+    # Get all the results that we're going to graph
+    test_results = Houston.benchmark("[project_tests#index] load results") do
+      TestResult.where(test_run_id: test_run_ids, test_id: test_ids).pluck(:test_run_id, :test_id, :status, :duration)
+    end
+
+    # Now we need to map results to tests
+    # and make sure that they're in the same order
+    # that the last 200 commits occurred in.
+    @tests = Houston.benchmark("[project_tests#index] map results") do
+      map = Hash.new { |hash, test_id| hash[test_id] = {} }
+      durations = Hash.new { |hash, test_id| hash[test_id] = [] }
+      test_results.each do |(test_run_id, test_id, status, duration)|
+        map[test_id][test_run_id] = status
+        durations[test_id] << duration if duration
+      end
+
+      @project.tests
+        .where(id: test_ids)
+        .order(:suite, :name)
+        .pluck("tests.id", :suite, :name)
+        .map do |(id, suite, name)|
+          status_by_test_run_id = map[id]
+          d = durations[id]
+          { id: id,
+            suite: suite,
+            name: name,
+            duration_avg: d.mean,
+            duration5: d.percentile(5),
+            duration95: d.percentile(95),
+            results: shas.map { |sha| status_by_test_run_id[test_run_id_by_sha[sha]] } }
+        end
+    end
   end
 
   def show

data/app/controllers/releases_controller.rb

@@ -10,6 +10,11 @@ class ReleasesController < ApplicationController
   def index
     @title = "Releases • #{@project.name}"
     @title << " (#{@environment})" if @environment
+    @q = params[:q]
+    @q = nil if @q.blank?
+    @releases = @project.releases.preload(:deploy).search(@q) if @q
+
+    render partial: (@q ? "releases/results" : "releases/index") if request.xhr?
   end
 
   def new

data/app/controllers/test_runs_controller.rb

@@ -1,5 +1,6 @@
 class TestRunsController < ApplicationController
   before_filter :find_test_run
+  skip_before_filter :verify_authenticity_token, only: [:save_results]
 
   def show
     @title = "Test Results for #{@test_run.sha[0...8]}"
@@ -25,11 +26,25 @@ class TestRunsController < ApplicationController
     end
   end
 
+  def save_results
+    results_url = params[:results_url]
+
+    if results_url.blank?
+      message = "#{@project.ci_server_name} is not appropriately configured to build #{@project.name}."
+      additional_info = "#{@project.ci_server_name} did not supply 'results_url' when it triggered the post_build hook"
+      ProjectNotification.ci_configuration_error(@test_run, message, additional_info: additional_info).deliver!
+      return
+    end
+
+    @test_run.completed!(results_url)
+    head :ok
+  end
+
 private
 
   def find_test_run
     @project = Project.find_by_slug!(params[:slug])
-    @test_run = @project.test_runs.find_by_sha(params[:commit]) || (raise ActiveRecord::RecordNotFound)
+    @test_run = @project.test_runs.find_by_sha!(params[:commit])
   end
 
 end

data/app/helpers/test_run_helper.rb

@@ -49,4 +49,28 @@ module TestRunHelper
     end
   end
 
+  def test_results_pass_count(test)
+    test[:results].count { |result| result == "pass" }
+  end
+
+  def test_results_fail_count(test)
+    test[:results].count { |result| result == "fail" }
+  end
+
+  def test_results_count(test)
+    test[:results].count { |result| !result.nil? }
+  end
+
+  def test_results_graph(test)
+    html = "<svg class=\"dot-graph\">"
+    percent = 100 / test[:results].length.to_f
+    left = 0
+    test[:results].reverse_each do |result|
+      html << "<rect x=\"#{left}%\" y=\"0\" rx=\"2\" ry=\"2\" width=\"#{percent}%\" height=\"100%\" class=\"dot-graph-rect #{result}\" data-index=\"0\"></rect>" if result
+      left += percent
+    end
+    html << "</svg>"
+    html.html_safe
+  end
+
 end

data/app/models/deploy.rb

@@ -59,6 +59,14 @@ class Deploy < ActiveRecord::Base
     completed_at.present?
   end
 
+  def succeeded?
+    successful?
+  end
+
+  def failed?
+    !successful?
+  end
+
   def environment
     environment_name
   end
@@ -96,6 +104,11 @@ private
   def notify_if_completed
     if just_completed?
       update_column :duration, completed_at - created_at if duration.nil?
+      if successful?
+        Houston.observer.fire "deploy:succeeded", self
+      else
+        Houston.observer.fire "deploy:failed", self
+      end
       Houston.observer.fire "deploy:completed", self
     end
   end

data/app/models/github/pull_request.rb

@@ -8,10 +8,12 @@ module Github
     belongs_to :project
     belongs_to :user
     has_and_belongs_to_many :commits
+    belongs_to :base, class_name: "Commit", foreign_key: "base_sha", primary_key: "sha"
+    belongs_to :head, class_name: "Commit", foreign_key: "head_sha", primary_key: "sha"
 
     before_validation :associate_project_with_self, if: :repo_changed?
     before_save :associate_user_with_self, if: :username_changed?
-    after_commit :associate_commits_with_self, autosave: false
+    after_commit :associate_commits_with_self
 
     after_destroy { Houston.observer.fire "github:pull:closed", self }
     after_create { Houston.observer.fire "github:pull:opened", self }
@@ -139,6 +141,11 @@ module Github
       def labeled(*labels)
         where(["exists (select 1 from jsonb_array_elements(pull_requests.json_labels) as \"label\" where \"label\"->>'name' IN (?))", labels])
       end
+      alias :with_labels :labeled
+
+      def without_labels(*labels)
+        where(["not exists (select 1 from jsonb_array_elements(pull_requests.json_labels) as \"label\" where \"label\"->>'name' IN (?))", labels])
+      end
     end
 
 
@@ -147,6 +154,14 @@ module Github
       self.json_labels = value.map { |label| label.to_h.stringify_keys.pick("name", "color") }
     end
 
+    def labeled?(*values)
+      values.all? { |value| labels.any? { |label| label["name"] == value } }
+    end
+
+    def labeled_any?(*values)
+      values.any? { |value| labels.any? { |label| label["name"] == value } }
+    end
+
     def labels
       json_labels
     end
@@ -173,20 +188,32 @@ module Github
 
 
 
+    def to_s
+      "#{repo}##{number}"
+    end
+
+
+
+    def publish_commit_status!(status={})
+      project.repo.create_commit_status(head_sha, status)
+    end
+
+
+
     def merge_attributes(pr)
       self.repo = pr["base"]["repo"]["name"] unless repo
       self.number = pr["number"] unless number
       self.username = pr["user"]["login"] unless username
       self.avatar_url = pr["user"]["avatar_url"] unless avatar_url
       self.url = pr["html_url"] unless url
-      self.base_sha = pr["base"]["sha"] unless base_sha
       self.base_ref = pr["base"]["ref"] unless base_ref
+      self.head_ref = pr["head"]["ref"] unless head_ref
+      self.created_at = pr["created_at"] unless created_at
 
-      self.created_at = pr["created_at"]
       self.title = pr["title"]
       self.body = pr["body"]
+      self.base_sha = pr["base"]["sha"]
       self.head_sha = pr["head"]["sha"]
-      self.head_ref = pr["head"]["ref"]
       self.labels = pr["labels"] if pr.key?("labels")
 
       self
@@ -203,9 +230,17 @@ module Github
     end
 
     def associate_commits_with_self
+      return unless commits_changes_before_commit?
+
       Houston.try({max_tries: 2, base: 0}, ActiveRecord::RecordNotUnique) do
         self.commits = project.commits.between(base_sha, head_sha)
       end
+
+      Houston.observer.fire "github:pull:synchronize", self
+    end
+
+    def commits_changes_before_commit?
+      previous_changes.key?(:base_sha) || previous_changes.key?(:head_sha)
     end
 
   end

data/app/models/release.rb

@@ -5,6 +5,7 @@ class Release < ActiveRecord::Base
   after_create :release_each_task!
   after_create :release_each_antecedent!
   after_create { Houston.observer.fire "release:create", self }
+  after_save :update_search_vector, :if => :search_vector_should_change?
 
   belongs_to :project
   belongs_to :user
@@ -79,6 +80,30 @@ class Release < ActiveRecord::Base
         AND releases.created_at=most_recent_releases.created_at
       SQL
     end
+
+    def reindex!
+      update_all "search_vector = to_tsvector('english', release_changes)"
+    end
+
+    def search(query_string)
+      config = PgSearch::Configuration.new({against: "plain_text"}, self)
+      normalizer = PgSearch::Normalizer.new(config)
+      options = { dictionary: "english", tsvector_column: "search_vector" }
+      query = PgSearch::Features::TSearch.new(query_string, options, config.columns, self, normalizer)
+
+      excerpt = ts_headline(:release_changes, query,
+        start_sel: "<em>",
+        stop_sel: "</em>",
+
+        # Hack: show the entire value of `release_changes`
+        min_words: 65534,
+        max_words: 65535,
+        max_fragments: 0)
+
+      columns = (column_names - %w{release_changes search_vector}).map { |column| "releases.\"#{column}\"" }
+      columns.push excerpt.as("release_changes")
+      where(query.conditions).select(*columns)
+    end
   end
 
 
@@ -183,6 +208,15 @@ class Release < ActiveRecord::Base
 
 
 
+  def update_search_vector
+    self.class.where(id: id).reindex!
+  end
+
+  def search_vector_should_change?
+    (changed & %w{release_changes}).any?
+  end
+
+
 private
 
   def identify_commit(sha)
@@ -214,4 +248,12 @@ private
     end
   end
 
+  # http://www.postgresql.org/docs/9.1/static/textsearch-controls.html#TEXTSEARCH-HEADLINE
+  def self.ts_headline(column, query, options={})
+    column = arel_table[column] if column.is_a?(Symbol)
+    options = options.map { |(key, value)| "#{key.to_s.camelize}=#{value}" }.join(", ")
+    tsquery = Arel.sql(query.send(:tsquery))
+    Arel::Nodes::NamedFunction.new("ts_headline", [column, Arel::Nodes.build_quoted(tsquery), Arel::Nodes.build_quoted(options)])
+  end
+
 end