historiographer 4.4.1 → 4.4.3

data/spec/foreign_key_spec.rb

@@ -1,189 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe 'Foreign key handling for belongs_to associations' do
-  before(:all) do
-    @original_stdout = $stdout
-    $stdout = StringIO.new
-    
-    ActiveRecord::Base.connection.create_table :test_users, force: true do |t|
-      t.string :name
-      t.timestamps
-    end
-    
-    ActiveRecord::Base.connection.create_table :test_websites, force: true do |t|
-      t.string :name
-      t.integer :user_id
-      t.timestamps
-    end
-    
-    ActiveRecord::Base.connection.create_table :test_website_histories, force: true do |t|
-      t.integer :test_website_id, null: false
-      t.string :name
-      t.integer :user_id
-      t.timestamps
-      t.datetime :history_started_at, null: false
-      t.datetime :history_ended_at
-      t.integer :history_user_id
-      t.string :snapshot_id
-      
-      t.index :test_website_id
-      t.index :history_started_at
-      t.index :history_ended_at
-      t.index :snapshot_id
-    end
-    
-    ActiveRecord::Base.connection.create_table :test_user_histories, force: true do |t|
-      t.integer :test_user_id, null: false
-      t.string :name
-      t.timestamps
-      t.datetime :history_started_at, null: false
-      t.datetime :history_ended_at
-      t.integer :history_user_id
-      t.string :snapshot_id
-      
-      t.index :test_user_id
-      t.index :history_started_at
-      t.index :history_ended_at
-      t.index :snapshot_id
-    end
-    
-    class TestUser < ActiveRecord::Base
-      include Historiographer
-      has_many :test_websites, foreign_key: 'user_id'
-    end
-    
-    class TestWebsite < ActiveRecord::Base
-      include Historiographer
-      belongs_to :user, class_name: 'TestUser', foreign_key: 'user_id', optional: true
-    end
-    
-    class TestWebsiteHistory < ActiveRecord::Base
-      include Historiographer::History
-    end
-    
-    class TestUserHistory < ActiveRecord::Base
-      include Historiographer::History
-    end
-  end
-  
-  after(:all) do
-    $stdout = @original_stdout
-    ActiveRecord::Base.connection.drop_table :test_website_histories
-    ActiveRecord::Base.connection.drop_table :test_websites
-    ActiveRecord::Base.connection.drop_table :test_user_histories
-    ActiveRecord::Base.connection.drop_table :test_users
-    Object.send(:remove_const, :TestWebsite) if Object.const_defined?(:TestWebsite)
-    Object.send(:remove_const, :TestWebsiteHistory) if Object.const_defined?(:TestWebsiteHistory)
-    Object.send(:remove_const, :TestUser) if Object.const_defined?(:TestUser)
-    Object.send(:remove_const, :TestUserHistory) if Object.const_defined?(:TestUserHistory)
-  end
-  
-  describe 'belongs_to association on history models' do
-    it 'does not raise error about wrong column when accessing belongs_to associations' do
-      # This is the core issue: when a history model has a belongs_to association,
-      # it should not use the foreign key as the primary key for lookups
-      
-      # Create a user
-      user = TestUser.create!(name: 'Test User', history_user_id: 1)
-      
-      # Create a website belonging to the user
-      website = TestWebsite.create!(
-        name: 'Test Website',
-        user_id: user.id,
-        history_user_id: 1
-      )
-      
-      # Get the website history
-      website_history = TestWebsiteHistory.last
-      
-      # The history should have the correct user_id
-      expect(website_history.user_id).to eq(user.id)
-      
-      # The belongs_to association should work without errors
-      # Previously this would fail with "column users.user_id does not exist"
-      # because it was using primary_key: :user_id instead of the default :id
-      expect { website_history.user }.not_to raise_error
-    end
-    
-    it 'allows direct creation of history records with foreign keys' do
-      user = TestUser.create!(name: 'Another User', history_user_id: 1)
-      
-      # Create history attributes like in the original error case
-      attrs = {
-        "name" => "test.example",
-        "user_id" => user.id,
-        "created_at" => Time.now,
-        "updated_at" => Time.now,
-        "test_website_id" => 100,
-        "history_started_at" => Time.now,
-        "history_user_id" => 1,
-        "snapshot_id" => SecureRandom.uuid
-      }
-      
-      # This should not raise an error about test_users.user_id not existing
-      # The original bug was that it would look for test_users.user_id instead of test_users.id
-      expect { TestWebsiteHistory.create!(attrs) }.not_to raise_error
-      
-      history = TestWebsiteHistory.last
-      expect(history.user_id).to eq(user.id)
-    end
-  end
-  
-  describe 'snapshot associations with history models' do
-    it 'correctly filters associations by snapshot_id when using custom association methods' do
-      # First create regular history records
-      user = TestUser.create!(name: 'User One', history_user_id: 1)
-      website = TestWebsite.create!(
-        name: 'Website One',
-        user_id: user.id,
-        history_user_id: 1
-      )
-      
-      # Check that regular histories were created
-      expect(TestUserHistory.count).to eq(1)
-      expect(TestWebsiteHistory.count).to eq(1)
-      
-      # Now create snapshot histories directly (simulating what snapshot would do)
-      snapshot_id = SecureRandom.uuid
-      
-      # Create user history with snapshot
-      user_snapshot = TestUserHistory.create!(
-        test_user_id: user.id,
-        name: user.name,
-        created_at: user.created_at,
-        updated_at: user.updated_at,
-        history_started_at: Time.now,
-        history_user_id: 1,
-        snapshot_id: snapshot_id
-      )
-      
-      # Create website history with snapshot
-      website_snapshot = TestWebsiteHistory.create!(
-        test_website_id: website.id,
-        name: website.name,
-        user_id: user.id,
-        created_at: website.created_at,
-        updated_at: website.updated_at,
-        history_started_at: Time.now,
-        history_user_id: 1,
-        snapshot_id: snapshot_id
-      )
-      
-      # Now test that the association filtering works
-      # The website history's user association should find the user history with the same snapshot_id
-      user_from_association = website_snapshot.user
-      
-      # Since user association points to history when snapshots are involved,
-      # it should return the TestUserHistory with matching snapshot_id
-      if user_from_association.is_a?(TestUserHistory)
-        expect(user_from_association.snapshot_id).to eq(snapshot_id)
-        expect(user_from_association.name).to eq('User One')
-      else
-        # If it returns the regular TestUser (non-history), that's also acceptable
-        # as long as it doesn't error
-        expect(user_from_association).to be_a(TestUser)
-        expect(user_from_association.name).to eq('User One')
-      end
-    end
-  end
-end