historiographer 4.4.1 → 4.4.3

data/spec/integration/historiographer_safe_integration_spec.rb

@@ -0,0 +1,154 @@
+require 'spec_helper'
+
+RSpec.describe 'Historiographer::Safe Integration' do
+  # This test reproduces the exact error from a real Rails app where:
+  # 1. WebsiteHistory is defined first and includes Historiographer::History
+  # 2. Website is defined later and includes Historiographer::Safe
+  # 3. The error occurs because foreign_class.constantize fails when Website isn't loaded yet
+  
+  context 'when history class is loaded before the main model' do
+    before(:each) do
+      # Ensure clean state
+      Object.send(:remove_const, :RealAppWebsite) if defined?(RealAppWebsite)
+      Object.send(:remove_const, :RealAppWebsiteHistory) if defined?(RealAppWebsiteHistory)
+      
+      # Create the tables
+      ActiveRecord::Base.connection.create_table :real_app_websites, force: true do |t|
+        t.string :name
+        t.integer :project_id
+        t.integer :user_id
+        t.integer :template_id
+        t.timestamps
+      end
+      
+      ActiveRecord::Base.connection.create_table :real_app_website_histories, force: true do |t|
+        t.integer :real_app_website_id, null: false
+        t.string :name
+        t.integer :project_id
+        t.integer :user_id
+        t.integer :template_id
+        t.datetime :created_at, null: false
+        t.datetime :updated_at, null: false
+        t.datetime :history_started_at, null: false
+        t.datetime :history_ended_at
+        t.integer :history_user_id
+        t.string :snapshot_id
+        t.string :thread_id
+      end
+      
+      ActiveRecord::Base.connection.add_index :real_app_website_histories, :real_app_website_id
+      ActiveRecord::Base.connection.add_index :real_app_website_histories, :history_started_at
+      ActiveRecord::Base.connection.add_index :real_app_website_histories, :history_ended_at
+    end
+    
+    after(:each) do
+      # Clean up tables
+      ActiveRecord::Base.connection.drop_table :real_app_website_histories if ActiveRecord::Base.connection.table_exists?(:real_app_website_histories)
+      ActiveRecord::Base.connection.drop_table :real_app_websites if ActiveRecord::Base.connection.table_exists?(:real_app_websites)
+      
+      # Clean up constants
+      Object.send(:remove_const, :RealAppWebsiteHistory) if defined?(RealAppWebsiteHistory)
+      Object.send(:remove_const, :RealAppWebsite) if defined?(RealAppWebsite)
+    end
+    
+    it 'handles history class being defined before the main model exists' do
+      # This is the exact scenario from the error report:
+      # WebsiteHistory is loaded/required first (common in Rails autoloading)
+      
+      expect {
+        class RealAppWebsiteHistory < ApplicationRecord
+          self.table_name = 'real_app_website_histories'
+          include Historiographer::History
+        end
+      }.not_to raise_error
+      
+      # At this point, RealAppWebsite doesn't exist yet
+      # The history class should handle this gracefully
+      expect(RealAppWebsiteHistory.foreign_class).to be_nil
+      
+      # Now define the main model (simulating Rails autoloading it later)
+      class RealAppWebsite < ApplicationRecord
+        self.table_name = 'real_app_websites'
+        include Historiographer::Safe
+      end
+      
+      # After the main model is defined, foreign_class should resolve
+      expect(RealAppWebsiteHistory.foreign_class).to eq(RealAppWebsite)
+      
+      # And all functionality should work
+      website = RealAppWebsite.create!(name: 'Test Site', history_user_id: 1)
+      expect(website.histories.count).to eq(1)
+      
+      history = website.histories.first
+      expect(history).to be_a(RealAppWebsiteHistory)
+      expect(history.real_app_website_id).to eq(website.id)
+      expect(history.name).to eq('Test Site')
+    end
+    
+    it 'allows history class to define associations even when parent model is not loaded' do
+      # Define a Deploy model for association testing
+      ActiveRecord::Base.connection.create_table :deploys, force: true do |t|
+        t.integer :real_app_website_history_id
+        t.string :status
+        t.timestamps
+      end
+      
+      class Deploy < ApplicationRecord
+        self.table_name = 'deploys'
+      end
+      
+      # Define history class with associations before main model exists
+      expect {
+        class RealAppWebsiteHistory < ApplicationRecord
+          self.table_name = 'real_app_website_histories'
+          include Historiographer::History
+          
+          # This should work even though RealAppWebsite doesn't exist yet
+          has_many :deploys, foreign_key: :real_app_website_history_id, dependent: :destroy
+        end
+      }.not_to raise_error
+      
+      # Now define the main model
+      class RealAppWebsite < ApplicationRecord
+        self.table_name = 'real_app_websites'
+        include Historiographer::Safe
+      end
+      
+      # Test that associations work
+      website = RealAppWebsite.create!(name: 'Test Site', history_user_id: 1)
+      history = website.histories.first
+      
+      deploy = Deploy.create!(real_app_website_history_id: history.id, status: 'pending')
+      expect(history.deploys).to include(deploy)
+      
+      # Clean up
+      ActiveRecord::Base.connection.drop_table :deploys
+      Object.send(:remove_const, :Deploy)
+    end
+    
+    it 'supports after_initialize Rails hook when available' do
+      # Simulate Rails being available with after_initialize
+      rails_app = double('Rails App')
+      config = double('Rails Config')
+      allow(config).to receive(:after_initialize).and_yield
+      allow(rails_app).to receive(:config).and_return(config)
+      allow(Rails).to receive(:application).and_return(rails_app)
+      
+      # Define history class
+      class RealAppWebsiteHistory < ApplicationRecord
+        self.table_name = 'real_app_website_histories'
+        include Historiographer::History
+      end
+      
+      # Define main model
+      class RealAppWebsite < ApplicationRecord
+        self.table_name = 'real_app_websites'
+        include Historiographer::Safe
+      end
+      
+      # The after_initialize should have set up associations
+      expect(RealAppWebsiteHistory).to respond_to(:setup_history_associations)
+      expect { RealAppWebsiteHistory.setup_history_associations }.not_to raise_error
+    end
+  end
+end

data/spec/internal/app/models/application_record.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end

data/spec/internal/app/models/deploy.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class Deploy < ApplicationRecord
+  belongs_to :website_history
+end

data/spec/internal/app/models/user.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class User < ApplicationRecord
+end

data/spec/internal/app/models/website.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class Website < ApplicationRecord
+  include Historiographer::Safe
+end

data/spec/internal/app/models/website_history.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class WebsiteHistory < ApplicationRecord
+  include Historiographer::History
+  
+  has_many :deploys
+end

data/spec/internal/config/database.yml

@@ -0,0 +1,9 @@
+test:
+  adapter: postgresql
+  database: historiographer_combustion_test
+  username: <%= ENV['DB_USERNAME'] || 'postgres' %>
+  password: <%= ENV['DB_PASSWORD'] || '' %>
+  host: <%= ENV['DB_HOST'] || 'localhost' %>
+  port: <%= ENV['DB_PORT'] || 5432 %>
+  pool: 5
+  timeout: 5000

data/spec/internal/config/routes.rb

@@ -0,0 +1,2 @@
+Rails.application.routes.draw do
+end

data/spec/internal/db/schema.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+ActiveRecord::Schema.define(version: 1) do
+  # Website table - the main model
+  create_table :websites, force: true do |t|
+    t.string :name
+    t.integer :project_id
+    t.integer :user_id
+    t.integer :template_id
+    t.timestamps
+  end
+
+  # Website history table
+  create_table :website_histories, force: true do |t|
+    t.integer :website_id, null: false
+    t.string :name
+    t.integer :project_id  
+    t.integer :user_id
+    t.integer :template_id
+    t.datetime :created_at, null: false
+    t.datetime :updated_at, null: false
+    t.datetime :history_started_at, null: false
+    t.datetime :history_ended_at
+    t.integer :history_user_id
+    t.string :snapshot_id
+    t.string :thread_id
+  end
+
+  add_index :website_histories, :website_id
+  add_index :website_histories, :history_started_at
+  add_index :website_histories, :history_ended_at
+  add_index :website_histories, :history_user_id
+  add_index :website_histories, :snapshot_id
+  add_index :website_histories, [:thread_id], unique: true, name: 'index_website_histories_on_thread_id'
+
+  # Deploy table - to test associations on history models
+  create_table :deploys, force: true do |t|
+    t.integer :website_history_id
+    t.string :status
+    t.timestamps
+  end
+
+  # User table
+  create_table :users, force: true do |t|
+    t.string :name
+    t.timestamps
+  end
+end

data/spec/models/author.rb

@@ -2,4 +2,5 @@ class Author < ActiveRecord::Base
   include Historiographer
   has_many :comments
   has_many :posts
+  has_many :bylines  # This model doesn't have history tracking
 end

data/spec/models/byline.rb

@@ -0,0 +1,4 @@
+class Byline < ActiveRecord::Base
+  # Note: This model does NOT include Historiographer
+  belongs_to :author
+end

data/spec/models/post.rb

@@ -5,6 +5,8 @@ class Post < ApplicationRecord
   acts_as_paranoid
   has_many :comments
 
+  attr_accessor :type
+  
   validates :type, inclusion: { in: ['Post', 'PrivatePost', nil] }
   before_validation :set_defaults
   after_find :set_comment_count

data/spec/models/test_article.rb

@@ -0,0 +1,4 @@
+class TestArticle < ActiveRecord::Base
+  include Historiographer
+  # Association will be defined later to avoid circular dependency
+end

data/spec/models/test_article_history.rb

@@ -0,0 +1,3 @@
+class TestArticleHistory < ActiveRecord::Base
+  include Historiographer::History
+end

data/spec/models/test_category.rb

@@ -0,0 +1,4 @@
+class TestCategory < ActiveRecord::Base
+  include Historiographer
+  # Association will be defined later to avoid circular dependency
+end

data/spec/models/test_category_history.rb

@@ -0,0 +1,3 @@
+class TestCategoryHistory < ActiveRecord::Base
+  include Historiographer::History
+end

data/spec/models/test_user.rb

@@ -0,0 +1,4 @@
+class TestUser < ApplicationRecord
+  include Historiographer
+  has_many :test_websites, foreign_key: 'user_id'
+end

data/spec/models/test_user_history.rb

@@ -0,0 +1,3 @@
+class TestUserHistory < ApplicationRecord
+  include Historiographer::History
+end

data/spec/models/test_website.rb

@@ -0,0 +1,4 @@
+class TestWebsite < ApplicationRecord
+  include Historiographer
+  belongs_to :user, class_name: 'TestUser', foreign_key: 'user_id', optional: true
+end

data/spec/models/test_website_history.rb

@@ -0,0 +1,3 @@
+class TestWebsiteHistory < ApplicationRecord
+  include Historiographer::History
+end

data/spec/rails_integration/historiographer_rails_integration_spec.rb

@@ -0,0 +1,106 @@
+# frozen_string_literal: true
+
+require 'combustion_helper'
+
+RSpec.describe 'Historiographer Rails Integration', type: :model do
+  describe 'when WebsiteHistory is loaded before Website (Rails autoloading scenario)' do
+    it 'handles the load order gracefully' do
+      expect(defined?(WebsiteHistory)).to be_truthy
+      expect(WebsiteHistory.ancestors).to include(Historiographer::History)
+      
+      expect(defined?(Website)).to be_truthy
+      expect(Website.ancestors).to include(Historiographer::Safe)
+      
+      expect(WebsiteHistory.foreign_class).to eq(Website)
+      
+      expect(WebsiteHistory).to respond_to(:setup_history_associations)
+      expect(WebsiteHistory).to respond_to(:original_class)
+      
+      expect { WebsiteHistory.setup_history_associations }.not_to raise_error
+    end
+    
+    it 'allows creating and querying history records' do
+      user = User.create!(name: 'Test User')
+      
+      website = Website.create!(
+        name: 'Production Site',
+        project_id: 1,
+        user_id: user.id,
+        history_user_id: user.id
+      )
+      
+      expect(website.histories.count).to eq(1)
+      
+      history = website.histories.first
+      expect(history).to be_a(WebsiteHistory)
+      expect(history.website_id).to eq(website.id)
+      expect(history.name).to eq('Production Site')
+      expect(history.history_user_id).to eq(user.id)
+      expect(history.history_started_at).to be_present
+      expect(history.history_ended_at).to be_nil
+      
+      website.update!(name: 'Updated Site', history_user_id: user.id)
+      
+      expect(website.histories.count).to eq(2)
+      
+      old_history = website.histories.where.not(history_ended_at: nil).first
+      expect(old_history.name).to eq('Production Site')
+      expect(old_history.history_ended_at).to be_present
+      
+      current_history = website.histories.current.first
+      expect(current_history.name).to eq('Updated Site')
+      expect(current_history.history_ended_at).to be_nil
+    end
+    
+    it 'supports associations on history models' do
+      website = Website.create!(name: 'Deploy Test Site', history_user_id: 1)
+      history = website.histories.first
+      
+      deploy = Deploy.create!(
+        website_history_id: history.id,
+        status: 'pending'
+      )
+      
+      expect(history.deploys).to include(deploy)
+      expect(deploy.website_history).to eq(history)
+      
+      expect(history.deploys.where(status: 'pending').count).to eq(1)
+    end
+    
+    it 'handles Safe mode without requiring history_user_id after initial creation' do
+      website = Website.create!(name: 'Safe Mode Test', history_user_id: 1)
+      
+      expect { website.update!(name: 'Updated Safe Mode Test') }.not_to raise_error
+      
+      expect(website.histories.count).to eq(2)
+      
+      current_history = website.histories.current.first
+      expect(current_history.name).to eq('Updated Safe Mode Test')
+      expect(current_history.history_user_id).to eq(1)
+      
+      website.update!(name: 'Another Update', history_user_id: nil)
+      expect(website.histories.count).to eq(3)
+      newest_history = website.histories.current.first
+      expect(newest_history.history_user_id).to be_nil
+    end
+    
+    it 'properly sets up delegated methods on history instances' do
+      website = Website.create!(name: 'Method Delegation Test', history_user_id: 1)
+      history = website.histories.first
+      
+      expect(history).to respond_to(:name)
+      
+      expect(history.name).to eq('Method Delegation Test')
+    end
+  end
+  
+  describe 'Rails after_initialize hook' do
+    it 'sets up associations after Rails initialization' do
+      expect(WebsiteHistory.reflect_on_association(:website)).to be_present
+      expect(WebsiteHistory.reflect_on_association(:deploys)).to be_present
+      
+      website_association = WebsiteHistory.reflect_on_association(:website)
+      expect(website_association.class_name).to eq('Website')
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -45,10 +45,9 @@ module Rails
   end
 
   def self.application
-    OpenStruct.new(
+    @application ||= OpenStruct.new(
       config: OpenStruct.new(
-        eager_load_namespaces: [],
-        autoloader: loader
+        eager_load_namespaces: []
       )
     )
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: historiographer
 version: !ruby/object:Gem::Version
-  version: 4.4.1
+  version: 4.4.3
 platform: ruby
 authors:
 - brettshollenberger
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-21 00:00:00.000000000 Z
+date: 2025-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -208,7 +208,12 @@ dependencies:
         version: '0'
 description: Creates separate tables for each history table
 email: brett.shollenberger@gmail.com
-executables: []
+executables:
+- console
+- setup
+- test
+- test-all
+- test-rails
 extensions: []
 extra_rdoc_files:
 - LICENSE.txt
@@ -218,6 +223,7 @@ files:
 - ".rspec"
 - ".ruby-version"
 - ".standalone_migrations"
+- DEVELOPMENT.md
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -225,6 +231,11 @@ files:
 - README.md
 - Rakefile
 - VERSION
+- bin/console
+- bin/setup
+- bin/test
+- bin/test-all
+- bin/test-rails
 - historiographer-4.1.12.gem
 - historiographer-4.1.13.gem
 - historiographer-4.1.14.gem
@@ -244,6 +255,7 @@ files:
 - lib/historiographer/safe.rb
 - lib/historiographer/silent.rb
 - lib/historiographer/version.rb
+- spec/combustion_helper.rb
 - spec/db/database.yml
 - spec/db/migrate/20161121212228_create_posts.rb
 - spec/db/migrate/20161121212229_create_post_histories.rb
@@ -262,13 +274,30 @@ files:
 - spec/db/migrate/20241119000000_create_datasets.rb
 - spec/db/migrate/2025082100000_create_projects.rb
 - spec/db/migrate/2025082100001_create_project_files.rb
+- spec/db/migrate/20250823000000_create_easy_ml_columns.rb
+- spec/db/migrate/20250824000000_create_test_articles.rb
+- spec/db/migrate/20250824000001_create_test_categories.rb
+- spec/db/migrate/20250825000000_create_bylines.rb
+- spec/db/migrate/20250826000000_create_test_users.rb
+- spec/db/migrate/20250826000001_create_test_user_histories.rb
+- spec/db/migrate/20250826000002_create_test_websites.rb
+- spec/db/migrate/20250826000003_create_test_website_histories.rb
 - spec/db/schema.rb
 - spec/factories/post.rb
-- spec/foreign_key_spec.rb
 - spec/historiographer_spec.rb
+- spec/integration/historiographer_safe_integration_spec.rb
+- spec/internal/app/models/application_record.rb
+- spec/internal/app/models/deploy.rb
+- spec/internal/app/models/user.rb
+- spec/internal/app/models/website.rb
+- spec/internal/app/models/website_history.rb
+- spec/internal/config/database.yml
+- spec/internal/config/routes.rb
+- spec/internal/db/schema.rb
 - spec/models/application_record.rb
 - spec/models/author.rb
 - spec/models/author_history.rb
+- spec/models/byline.rb
 - spec/models/comment.rb
 - spec/models/comment_history.rb
 - spec/models/easy_ml/column.rb
@@ -283,10 +312,19 @@ files:
 - spec/models/safe_post_history.rb
 - spec/models/silent_post.rb
 - spec/models/silent_post_history.rb
+- spec/models/test_article.rb
+- spec/models/test_article_history.rb
+- spec/models/test_category.rb
+- spec/models/test_category_history.rb
+- spec/models/test_user.rb
+- spec/models/test_user_history.rb
+- spec/models/test_website.rb
+- spec/models/test_website_history.rb
 - spec/models/thing_with_compound_index.rb
 - spec/models/thing_with_compound_index_history.rb
 - spec/models/thing_without_history.rb
 - spec/models/user.rb
+- spec/rails_integration/historiographer_rails_integration_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/brettshollenberger/historiographer
 licenses: