hecks 3.13.0 → 4.0.0

data/lib/hecks/composer/web.rb

@@ -0,0 +1,156 @@
+require "json"
+require "rack"
+require_relative "../composer"
+require_relative "domains"
+require_relative "workbench"
+
+module Hecks
+  module Composer
+    # The Composer's driving side, on the hecksagon side: a Rack app that serves the editor page
+    # and the JSON routes it speaks to, over one workspace directory at a time. It binds no
+    # business meaning. The routes are the tables below: the page and files, the editor's own
+    # (save, remove, parse, check, ask), the domain list, and the lower panels', which {Panels}
+    # answers.
+    class Web
+      PAGE = File.expand_path("page.html", __dir__).freeze
+      PREFIX = "/composer".freeze
+
+      # @param workspace [String] the domain directory the editor opens
+      # @param agents [Runtime::Registry, nil] see {Workbench#initialize}
+      # @param root [String] the checkout whose domains the picker lists
+      # @return [Web] a Rack app
+      def self.app(workspace:, agents: nil, root: Parse::ROOT) = new(workspace: workspace, agents: agents, root: root)
+
+      # @param workspace [String] the domain directory the editor opens
+      # @param agents [Runtime::Registry, nil] see {Workbench#initialize}
+      # @param root [String] the checkout whose domains the picker lists
+      def initialize(workspace:, agents: nil, root: Parse::ROOT)
+        @agents = agents
+        @root = File.expand_path(root)
+        @bench = Workbench.new(workspace: workspace, agents: agents)
+      end
+
+      # @param env [Hash] the Rack environment
+      # @return [Array] the Rack response triple
+      def call(env)
+        request = Rack::Request.new(env)
+        route(request)
+      rescue Workspace::OutsideWorkspace, KeyError, JSON::ParserError => e
+        json(400, error: e.message)
+      rescue Domains::Unknown => e
+        json(404, error: e.message)
+      rescue Parse::ParserMissing => e
+        json(503, error: e.message)
+      end
+
+      private
+
+      # Routes that answer from the workspace alone, those that read a JSON body first, and those
+      # the lower panels ask (answered by {Panels}).
+      READS = { "GET " => :page, "GET #{PREFIX}" => :page, "GET #{PREFIX}/files" => :listing,
+                "GET #{PREFIX}/draft" => :conversation, "GET #{PREFIX}/domains" => :domains }.freeze
+      WRITES = { "PUT #{PREFIX}/file" => :save, "DELETE #{PREFIX}/file" => :remove,
+                 "POST #{PREFIX}/parse" => :parse, "POST #{PREFIX}/check" => :check,
+                 "POST #{PREFIX}/ask" => :ask, "POST #{PREFIX}/open" => :open_domain }.freeze
+      PANEL_ROUTES = { "POST #{PREFIX}/live/commands" => :commands, "POST #{PREFIX}/live/dispatch" => :dispatch,
+                       "POST #{PREFIX}/live/records" => :records, "POST #{PREFIX}/behaviors" => :behaviors,
+                       "POST #{PREFIX}/timeline" => :timeline, "POST #{PREFIX}/board/edit" => :board_edit,
+                       "GET #{PREFIX}/catalog" => :catalog,
+                       "POST #{PREFIX}/help" => :help, "POST #{PREFIX}/run" => :run,
+                       "GET #{PREFIX}/eras" => :eras, "POST #{PREFIX}/job" => :start_job,
+                       "GET #{PREFIX}/job" => :job_state, "DELETE #{PREFIX}/job" => :cancel_job }.freeze
+      private_constant :READS, :WRITES, :PANEL_ROUTES
+
+      def route(request)
+        key = "#{request.request_method} #{request.path_info.chomp("/")}"
+        answer_for(key, request) || json(404, error: "no such route")
+      end
+
+      # The response the key's table gives, or nil when no table has the key.
+      def answer_for(key, request)
+        return send(READS[key]) if READS.key?(key)
+        return send(WRITES[key], body(request)) if WRITES.key?(key)
+
+        json(200, @bench.panels.public_send(PANEL_ROUTES[key], body(request))) if PANEL_ROUTES.key?(key)
+      end
+
+      def workspace = @bench.workspace
+
+      def listing = json(200, files: files)
+
+      def conversation = json(200, draft: @bench.session.summary(@bench.slug))
+
+      # The known domains, and the directory the editor has open now.
+      def domains = json(200, domains: Domains.known(root: @root), current: File.basename(workspace))
+
+      # Opens a known domain as a scratch copy, replacing everything kept for the old workspace.
+      def open_domain(body)
+        id = body.fetch("id")
+        opened = Domains.open(root: @root, id: id)
+        @bench.close
+        @bench = Workbench.new(workspace: opened, agents: @agents)
+        json(200, opened: id, current: File.basename(opened))
+      end
+
+      def ask(body)
+        json(200, @bench.assistant.ask(body.fetch("prompt")))
+      rescue Agent::Unavailable => e
+        json(503, error: e.message)
+      rescue Agent::ValidationError => e
+        json(502, error: e.message)
+      end
+
+      def page = [200, { "content-type" => "text/html; charset=utf-8" }, [File.read(PAGE)]]
+
+      def files
+        Workspace.files(workspace).map { |path| { path: path, text: File.read(File.join(workspace, path)) } }
+      end
+
+      def save(body)
+        path = domain_path(body) or return refused(body)
+
+        target = File.join(workspace, path)
+        FileUtils.mkdir_p(File.dirname(target))
+        File.write(target, body.fetch("text"))
+        @bench.session.record(path: path, text: body.fetch("text"))
+        json(200, saved: path)
+      end
+
+      def remove(body)
+        path = domain_path(body) or return refused(body)
+
+        FileUtils.rm_f(File.join(workspace, path))
+        json(200, removed: path)
+      end
+
+      # The request's path when it names a domain file inside the workspace, else nil.
+      def domain_path(body)
+        path = body.fetch("path")
+        Workspace.refuse_escapes!([path])
+        path if Workspace::EXTENSIONS.include?(File.extname(path).delete_prefix("."))
+      end
+
+      def refused(body) = json(400, error: "#{body["path"].inspect} is not a domain file")
+
+      def parse(body)
+        refusal = Workspace.stage(dir: workspace, buffers: buffers(body)) { |stage| Parse.call(stage) }
+        json(200, diagnostic: refusal)
+      end
+
+      def check(body)
+        json(200, Check.call(dir: workspace, buffers: buffers(body), chapter_name: body["chapter_name"]))
+      end
+
+      def buffers(body) = body.fetch("buffers", {})
+
+      def body(request)
+        raw = request.body&.read.to_s
+        raw.empty? ? {} : JSON.parse(raw)
+      end
+
+      def json(status, payload)
+        [status, { "content-type" => "application/json" }, [JSON.generate(payload)]]
+      end
+    end
+  end
+end

data/lib/hecks/composer/workbench.rb

@@ -0,0 +1,51 @@
+require_relative "agent"
+require_relative "assistant"
+require_relative "panels"
+require_relative "session"
+
+module Hecks
+  module Composer
+    # Everything the editor keeps for one workspace, on the hecksagon side: the draft bookkeeping,
+    # the agent that edits it and the panels beneath the editor. Opening another domain builds a
+    # new workbench, so nothing of the old workspace carries over.
+    class Workbench
+      # @return [String] the domain directory this workbench is for
+      attr_reader :workspace
+
+      # @param workspace [String] the domain directory
+      # @param agents [Runtime::Registry, nil] a registry holding the `composer_agent` port and one
+      #   adapter; the one `HECKS_COMPOSER_AGENT` names (`claude`, the default, or `fake`) when nil
+      def initialize(workspace:, agents: nil)
+        @workspace = File.expand_path(workspace)
+        @agents = agents
+      end
+
+      # @return [String] the workspace's directory name, which names its draft
+      def slug = File.basename(workspace)
+
+      # @return [Session] the draft bookkeeping, booted on first use
+      def session = @session ||= Session.new
+
+      # @return [Assistant] the agent loop over this workspace
+      def assistant = @assistant ||= Assistant.new(workspace: workspace, agents: agents, session: session)
+
+      # @return [Panels] what answers the lower panels
+      def panels = @panels ||= Panels.new(workspace: workspace, session: session)
+
+      # Releases what the panels booted.
+      # @return [void]
+      def close = @panels&.close
+
+      private
+
+      def agents = @agents ||= default_agents
+
+      # The adapter `HECKS_COMPOSER_AGENT` names: the real `claude`, or a scripted `fake`.
+      def default_agents
+        name = ENV.fetch("HECKS_COMPOSER_AGENT", "claude") == "fake" ? "fake_agent" : "claude_composer"
+        require_relative "adapters/#{name}"
+        Agent.registry_with(File.join(Agent::ADAPTERS, "#{name}.adapter"))
+      end
+    end
+  end
+end

data/lib/hecks/composer/workspace.rb

@@ -0,0 +1,81 @@
+require "fileutils"
+require "tmpdir"
+
+module Hecks
+  module Composer
+    # A workspace is a directory of domain files; an editor holds unsaved text for some of them.
+    # Staging lays that text over a copy of the files on disk so a check sees what is on screen
+    # and the directory itself stays untouched.
+    module Workspace
+      # The files a domain is made of; anything else in the directory is data, not declaration.
+      EXTENSIONS = %w[bluebook hecksagon world adapter port behaviors].freeze
+
+      # Raised when an unsaved buffer names a path outside the workspace.
+      class OutsideWorkspace < ArgumentError; end
+
+      module_function
+
+      # Copies the workspace's declaration files into a temporary directory, lays the buffers over
+      # them, and yields that directory.
+      #
+      # @param dir [String] the workspace directory
+      # @param buffers [Hash{String => String}] unsaved text by path relative to `dir`; a path
+      #   with no file on disk yet is created
+      # @yieldparam stage [String] the temporary directory holding the staged files
+      # @return [Object] what the block returned
+      # @raise [OutsideWorkspace] if a buffer's path is absolute or climbs out of the workspace
+      def stage(dir:, buffers: {})
+        stage = materialize(dir: dir, buffers: buffers)
+        yield stage
+      ensure
+        FileUtils.rm_rf(stage) if stage
+      end
+
+      # Stages as {stage} does, but leaves the directory for the caller to remove, so a booted
+      # domain can keep reading its files after this returns.
+      #
+      # @param dir [String] the workspace directory
+      # @param buffers [Hash{String => String}] unsaved text by path relative to `dir`
+      # @return [String] the temporary directory holding the staged files
+      # @raise [OutsideWorkspace] if a buffer's path is absolute or climbs out of the workspace
+      def materialize(dir:, buffers: {})
+        refuse_escapes!(buffers.keys)
+        stage = Dir.mktmpdir("hecks-composer")
+        copy_declarations(dir, stage)
+        buffers.each { |path, text| write(File.join(stage, path), text) }
+        stage
+      rescue StandardError
+        FileUtils.rm_rf(stage) if stage
+        raise
+      end
+
+      # @param stage [String] a staged directory
+      # @return [Array<String>] the declaration files in it, relative and sorted
+      def files(stage)
+        Dir.glob("**/*.{#{EXTENSIONS.join(",")}}", base: stage).sort
+      end
+
+      # @api private
+      def copy_declarations(dir, stage)
+        files(dir).each do |relative|
+          FileUtils.mkdir_p(File.dirname(File.join(stage, relative)))
+          FileUtils.cp(File.join(dir, relative), File.join(stage, relative))
+        end
+      end
+
+      # @api private
+      def write(path, text)
+        FileUtils.mkdir_p(File.dirname(path))
+        File.write(path, text)
+      end
+
+      # @api private
+      def refuse_escapes!(paths)
+        offender = paths.find { |path| path.start_with?("/") || path.split("/").include?("..") }
+        return unless offender
+
+        raise OutsideWorkspace, "#{offender.inspect} is not inside the workspace"
+      end
+    end
+  end
+end

data/lib/hecks/composer.rb

@@ -0,0 +1,17 @@
+require_relative "composer/plain"
+require_relative "composer/workspace"
+require_relative "composer/parse"
+require_relative "composer/outline"
+require_relative "composer/layout"
+require_relative "composer/behavior_run"
+require_relative "composer/live"
+require_relative "composer/toolbox"
+require_relative "composer/jobs"
+require_relative "composer/check"
+
+module Hecks
+  # The Composer's outside, on the hecksagon side: staging a workspace, judging its text and
+  # projecting what it declares. The Composer chapter's bluebook is in `composer/bluebook/`.
+  module Composer
+  end
+end

data/lib/hecks/corpus/adapters.rb

@@ -0,0 +1,22 @@
+module Hecks
+  module Corpus
+    # Where `.adapter` files live, for the parser parity check. Extended onto `Corpus`.
+    module Adapters
+      # Directories that hold copies or build output, never a source `.adapter`.
+      EXCLUDED_DIRS = %w[vendor node_modules target tmp .git .aws-sam].freeze
+
+      ADAPTER_GLOBS = %w[lib/**/*.adapter examples/**/*.adapter spec/fixtures/**/*.adapter].freeze
+
+      # Every `.adapter` file the repo carries.
+      #
+      # @param root [String] repository root to search under
+      # @return [Array<String>] absolute paths, sorted, none under a vendored, `node_modules`,
+      #   `target` or scratch directory
+      def adapter_files(root: Corpus::ROOT)
+        ADAPTER_GLOBS.flat_map { |glob| Dir.glob(File.join(root, glob)) }.uniq.sort.reject do |path|
+          path.delete_prefix("#{root}/").split("/").intersect?(EXCLUDED_DIRS)
+        end
+      end
+    end
+  end
+end

data/lib/hecks/corpus/rust.rb

@@ -3,7 +3,7 @@ module Hecks
     # Every Rust-facing list reads `rust/Cargo.toml`'s `[features]` as its
     # one source, rather than each consumer typing it out by hand.
     GENERATED_DIR = "rust/src/generated".freeze
-    RUST_DOMAIN_KINDS = %i[example stress fixture].freeze
+    RUST_DOMAIN_KINDS = %i[example stress semantics fixture].freeze
 
     RustDomain = Struct.new(:feature, :dir, :kind)
 

data/lib/hecks/corpus/worlds.rb

@@ -0,0 +1,19 @@
+module Hecks
+  module Corpus
+    # Where `.world` files live, for the parser parity check. Extended onto `Corpus`.
+    module Worlds
+      WORLD_GLOBS = %w[lib/**/*.world examples/**/*.world qa/**/*.world spec/fixtures/**/*.world].freeze
+
+      # Every `.world` file the repo carries.
+      #
+      # @param root [String] repository root to search under
+      # @return [Array<String>] absolute paths, sorted, none under a vendored, `node_modules`,
+      #   `target` or scratch directory
+      def world_files(root: Corpus::ROOT)
+        WORLD_GLOBS.flat_map { |glob| Dir.glob(File.join(root, glob)) }.uniq.sort.reject do |path|
+          path.delete_prefix("#{root}/").split("/").intersect?(Adapters::EXCLUDED_DIRS)
+        end
+      end
+    end
+  end
+end

data/lib/hecks/corpus.rb

@@ -1,7 +1,9 @@
 require_relative "fuzzing/target_capabilities"
+require_relative "corpus/adapters"
 require_relative "corpus/routes"
 require_relative "corpus/rust"
 require_relative "corpus/sources"
+require_relative "corpus/worlds"
 
 module Hecks
   # The corpus: every place in this repo that holds a real domain, named once.
@@ -36,6 +38,7 @@ module Hecks
       deploy:    "lib/hecks/deploy/bluebook/*.bluebook",
       site:      "lib/hecks/site/bluebook/*.bluebook",
       tickets:   "lib/hecks/tickets/bluebook/*.bluebook",
+      composer:  "lib/hecks/composer/bluebook/*.bluebook",
       tenancy:   "lib/hecks/tenancy/bluebook/*.bluebook",
       sme:       "lib/hecks/sme/bluebook/*.bluebook",
       fixture:   "spec/fixtures/**/*.bluebook"
@@ -43,8 +46,10 @@ module Hecks
 
     KINDS = (DIRECTORY_KINDS.keys + FILE_KINDS.keys).freeze
 
+    extend Adapters
     extend Rust
     extend Sources
+    extend Worlds
 
     module_function
 

data/lib/hecks/deploy/bluebook/deploy.bluebook

@@ -451,7 +451,7 @@ Hecks.bluebook "Deploy" do
 
     # The domain's own directory on disk, where `environments/<slug>.world` is written.
     value_object "DirectoryPath" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
     end
 
     value_object "Report" do
@@ -581,14 +581,14 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     # A domain directory, whose `bluebook/` holds the `.world` that declares `deployed_to`.
     value_object "DomainPath" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a domain is named by its path") { !value.to_s.empty? }
     end
@@ -604,7 +604,7 @@ Hecks.bluebook "Deploy" do
 
     # Where the recipe is written, for a domain that lives in a client's repository.
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
     end
 
     # An `environments/<name>.world` overlay of the domain, which must exist.
@@ -707,14 +707,14 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     # A domain directory, whose `bluebook/` holds the `.world` that declares `deployed_to`.
     value_object "DomainPath" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a domain is named by its path") { !value.to_s.empty? }
     end
@@ -722,7 +722,7 @@ Hecks.bluebook "Deploy" do
     # A directory the cleared worlds are written to, at their paths below `bluebook/`, instead of
     # over the originals.
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
     end
 
     value_object "Report" do
@@ -813,14 +813,14 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     # Makefile paths, comma separated; three generated fixture domains when absent.
     value_object "PathList" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
     end
 
     value_object "Report" do
@@ -909,7 +909,7 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
@@ -1020,13 +1020,13 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a project or script is named by its path") { !value.to_s.empty? }
     end
@@ -1159,13 +1159,13 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a project or script is named by its path") { !value.to_s.empty? }
     end
@@ -1187,7 +1187,7 @@ Hecks.bluebook "Deploy" do
 
     # A local image reference to push, as the script's LOCAL_IMAGE takes it.
     value_object "ImageName" do
-      attribute :value, String, pattern: '^[^ \t\n\r]+$'
+      attribute :value, String, matches: :no_whitespace
     end
 
     value_object "Switch" do
@@ -1352,13 +1352,13 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a project or script is named by its path") { !value.to_s.empty? }
     end
@@ -1538,13 +1538,13 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a project or script is named by its path") { !value.to_s.empty? }
     end
@@ -1560,7 +1560,7 @@ Hecks.bluebook "Deploy" do
 
     # A Secrets Manager id or ARN; the script reads the password from it, so no value travels here.
     value_object "Secret" do
-      attribute :value, String, pattern: '^[^ \t\n\r]+$'
+      attribute :value, String, matches: :no_whitespace
     end
 
     # A database's name; empty leaves it to the generated script's own default.
@@ -1826,13 +1826,13 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a project or script is named by its path") { !value.to_s.empty? }
     end
@@ -1846,7 +1846,7 @@ Hecks.bluebook "Deploy" do
     end
 
     value_object "Secret" do
-      attribute :value, String, pattern: '^[^ \t\n\r]+$'
+      attribute :value, String, matches: :no_whitespace
     end
 
     # A database's name; empty leaves it to the generated script's own default.
@@ -1984,13 +1984,13 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a project, script or file is named by its path") { !value.to_s.empty? }
     end
@@ -2134,13 +2134,13 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a project or script is named by its path") { !value.to_s.empty? }
     end
@@ -2152,7 +2152,7 @@ Hecks.bluebook "Deploy" do
 
     # A git branch name. A preview is never of a production branch.
     value_object "Branch" do
-      attribute :value, String, pattern: '^[^ \t\n\r]+$'
+      attribute :value, String, matches: :no_whitespace
 
       invariant("a preview is never of main or master") { value != "main" && value != "master" }
     end
@@ -2510,13 +2510,13 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a project or script is named by its path") { !value.to_s.empty? }
     end
@@ -2656,13 +2656,13 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     value_object "Location" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
 
       invariant("a template is named by its path") { !value.to_s.empty? }
     end
@@ -2785,14 +2785,14 @@ Hecks.bluebook "Deploy" do
     identified_by :run
 
     value_object "RunKey" do
-      attribute :value, String, pattern: '[^ \t\n\r]'
+      attribute :value, String, matches: :present
 
       invariant("a run is named") { !value.to_s.empty? }
     end
 
     # Domain directories, comma separated; every domain of the checkout when absent.
     value_object "DomainList" do
-      attribute :value, String, pattern: '[^\t\n\r]'
+      attribute :value, String, matches: :not_empty
     end
 
     value_object "Report" do