hasoffersv3 0.4.1 → 0.5.0

data/spec/lib/offer_spec.rb

@@ -1,149 +1,145 @@
-require 'spec_helper'
-
 describe HasOffersV3::Offer do
-  subject { HasOffersV3::Offer.new }
-
   let(:url)  { api_url 'Offer' }
 
-  describe '.find_all' do
-    it 'should make a proper request call' do
+  describe '#find_all' do
+    it 'makes a proper request call' do
       stub_call
-      response = HasOffersV3::Offer.find_all
+      response = subject.find_all
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
   end
 
-  describe '.find_all_by_ids' do
-    it 'should make a proper request call' do
+  describe '#find_all_by_ids' do
+    it 'makes a proper request call' do
       stub_call
-      response = HasOffersV3::Offer.find_all_by_ids ids: [1]
+      response = subject.find_all_by_ids ids: [1]
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAllByIds'}))).to have_been_made
       validate_call response
     end
 
     context 'when there is no id' do
-      it 'should raise exception' do
-        expect { HasOffersV3::Offer.find_all_by_ids }.to raise_error ArgumentError
+      it 'raises exception' do
+        expect { subject.find_all_by_ids }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.find_all_ids_by_advertiser_id' do
-    it 'should make a proper request call' do
+  describe '#find_all_ids_by_advertiser_id' do
+    it 'makes a proper request call' do
       stub_call
-      response = HasOffersV3::Offer.find_all_ids_by_advertiser_id advertiser_id: 1
+      response = subject.find_all_ids_by_advertiser_id advertiser_id: 1
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAllIdsByAdvertiserId', 'advertiser_id' => '1'}))).to have_been_made
       validate_call response
     end
 
     context 'when there is no id' do
-      it 'should raise exception' do
-        expect { HasOffersV3::Offer.find_all_ids_by_advertiser_id }.to raise_error ArgumentError
+      it 'raises exception' do
+        expect { subject.find_all_ids_by_advertiser_id }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.find_all_ids_by_affiliate_id' do
-    it 'should make a proper request call' do
+  describe '#find_all_ids_by_affiliate_id' do
+    it 'makes a proper request call' do
       stub_call
-      response = HasOffersV3::Offer.find_all_ids_by_affiliate_id affiliate_id: 1
+      response = subject.find_all_ids_by_affiliate_id affiliate_id: 1
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAllIdsByAffiliateId', 'affiliate_id' => '1'}))).to have_been_made
     end
   end
 
-  describe '.find_by_id' do
-    it 'should make a proper request call' do
+  describe '#find_by_id' do
+    it 'makes a proper request call' do
       stub_call
-      response = HasOffersV3::Offer.find_by_id id: 1
+      response = subject.find_by_id id: 1
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findById', 'id' => '1'}))).to have_been_made
       validate_call response
     end
 
     context 'when there is no id' do
-      it 'should raise exception' do
-        expect { HasOffersV3::Offer.find_by_id }.to raise_error ArgumentError
+      it 'raises exception' do
+        expect { subject.find_by_id }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.get_groups' do
-    it 'should make a proper request call' do
+  describe '#get_groups' do
+    it 'makes a proper request call' do
       stub_call
-      response = HasOffersV3::Offer.get_groups id: 1
+      response = subject.get_groups id: 1
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'getGroups'}))).to have_been_made
       validate_call response
     end
 
     context 'when there is no id' do
-      it 'should raise exception' do
-        expect { HasOffersV3::Offer.get_groups }.to raise_error ArgumentError
+      it 'raises exception' do
+        expect { subject.get_groups }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.get_approved_affiliate_ids' do
+  describe '#get_approved_affiliate_ids' do
     it 'makes a proper API request' do
       stub_call
-      response = HasOffersV3::Offer.get_approved_affiliate_ids id: 1
+      response = subject.get_approved_affiliate_ids id: 1
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'getApprovedAffiliateIds'}))).to have_been_made
       validate_call response
     end
 
     context 'when id parameter is missed' do
       it 'raises an exception' do
-        expect {  HasOffersV3::Offer.get_approved_affiliate_ids }.to raise_error ArgumentError
+        expect { subject.get_approved_affiliate_ids }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.set_payout' do
-    it 'should make a proper request call' do
+  describe '#set_payout' do
+    it 'makes a proper request call' do
       stub_call
-      response = HasOffersV3::Offer.set_payout id: 1, affiliate_id: 321
+      response = subject.set_payout id: 1, affiliate_id: 321
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'setPayout'}))).to have_been_made
       validate_call response
     end
 
     context 'when the id and/or affiliate id parameters are missing' do
       it 'raises an exception' do
-        expect {  HasOffersV3::Offer.set_payout }.to raise_error ArgumentError
+        expect { subject.set_payout }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.set_tier_payout' do
-    it 'should make a proper request call' do
+  describe '#set_tier_payout' do
+    it 'makes a proper request call' do
       stub_call
-      response = HasOffersV3::Offer.set_tier_payout id: 1, affiliate_tier_id: 2
+      response = subject.set_tier_payout id: 1, affiliate_tier_id: 2
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'setTierPayout'}))).to have_been_made
       validate_call response
     end
 
     context 'when the id and/or affiliate tier id parameters are missing' do
       it 'raises an exception' do
-        expect {  HasOffersV3::Offer.set_tier_payout }.to raise_error ArgumentError
+        expect { subject.set_tier_payout }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.remove_payout' do
-    it 'should make a proper request call' do
+  describe '#remove_payout' do
+    it 'makes a proper request call' do
       stub_call
-      response = HasOffersV3::Offer.remove_payout id: 1, affiliate_id: 321
+      response = subject.remove_payout id: 1, affiliate_id: 321
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'removePayout'}))).to have_been_made
       validate_call response
     end
 
     context 'when the id and/or affiliate id parameters are missing' do
       it 'raises an exception' do
-        expect {  HasOffersV3::Offer.remove_payout }.to raise_error ArgumentError
+        expect { subject.remove_payout }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.generate_tracking_link' do
-    it 'should make a proper request call' do
+  describe '#generate_tracking_link' do
+    it 'makes a proper request call' do
       stub_call
       response = subject.generate_tracking_link offer_id: 1, affiliate_id: 123
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'generateTrackingLink','offer_id' => '1',
@@ -152,24 +148,24 @@ describe HasOffersV3::Offer do
     end
 
     context 'when required params are missing' do
-      it 'should fail without offer_id' do
+      it 'fails without offer_id' do
         expect { subject.generate_tracking_link affiliate_id: 1}.to raise_error ArgumentError
       end
-      it 'should fail without affiliate_id' do
+      it 'fails without affiliate_id' do
         expect { subject.generate_tracking_link offer_id: 10 }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.get_tier_payouts' do
-    it 'should make a proper request call' do
+  describe '#get_tier_payouts' do
+    it 'makes a proper request call' do
       stub_call
       response = subject.get_tier_payouts id: 1
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'getTierPayouts','id' => '1'}))).to have_been_made
       validate_call response
     end
 
-    it 'should fail without id' do
+    it 'fails without id' do
       expect { subject.get_tier_payouts }.to raise_error ArgumentError
     end
   end

data/spec/lib/raw_log_spec.rb

@@ -1,71 +1,67 @@
-require 'spec_helper'
-
 describe HasOffersV3::RawLog do
-  subject { HasOffersV3::RawLog.new }
-
   let(:url)  { Regexp.new api_url('RawLog') }
 
   before :each do
     stub_call :get
   end
 
-  describe '.get_download_link' do
-    it 'should make a proper request call' do
+  describe '#get_download_link' do
+    it 'makes a proper request call' do
       response = subject.get_download_link log_type: 'clicks', log_filename: 'xxx'
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'getDownloadLink'}))).to have_been_made
       validate_call response
     end
 
     context 'when there is no log_type' do
-      it 'it should raise an exception' do
+      it 'raises an exception' do
         expect { subject.get_download_link log_filename: 'xxx' }.to raise_error ArgumentError
       end
     end
 
     context 'when there is no log_filename' do
-      it 'it should raise an exception' do
+      it 'raises an exception' do
         expect { subject.get_download_link log_type: 'clicks' }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.get_log_expirations' do
-    it 'should make a proper request call' do
+  describe '#get_log_expirations' do
+    it 'makes a proper request call' do
       response = subject.get_log_expirations
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'getLogExpirations'}))).to have_been_made
       validate_call response
     end
   end
 
-  describe '.list_date_dirs' do
-    it 'should make a proper request call' do
+  describe '#list_date_dirs' do
+    it 'makes a proper request call' do
       response = subject.list_date_dirs log_type: 'clicks'
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'listDateDirs'}))).to have_been_made
       validate_call response
     end
 
     context 'when there is no log_type' do
-      it 'it should raise an exception' do
+      it 'raises an exception' do
         expect { subject.list_date_dirs }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.list_logs' do
-    it 'should make a proper request call' do
+  describe '#list_logs' do
+    it 'makes a proper request call' do
       response = subject.list_logs log_type: 'clicks', date_dir: '20140101'
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'listLogs'}))).to have_been_made
       validate_call response
     end
 
     context 'when there is no log_type' do
-      it 'it should raise an exception' do
+      it 'raises an exception' do
         expect { subject.list_logs date_dir: '20140101' }.to raise_error ArgumentError
       end
     end
 
     context 'when there is no date_dir' do
-      it 'it should raise an exception' do
+      it 'raises an exception' do
         expect { subject.list_logs log_type: 'clicks' }.to raise_error ArgumentError
       end
     end

data/spec/lib/report_spec.rb

@@ -1,61 +1,35 @@
-require 'spec_helper'
-
 describe HasOffersV3::Report do
-  subject { HasOffersV3::Report.new }
   let(:url)  { api_url 'Report' }
 
-  describe '.get_conversions' do
-    before(:each) { stub_call }
-
-    it 'should make a proper request call' do
-      response = subject.get_conversions
-      expect(a_request(:post, url).with(body: hash_including({'Method' => 'getConversions'}))).to have_been_made
-      validate_call response
-    end
-  end
-
-  describe '.getConversions' do
+  describe '#get_conversions' do
     before(:each) { stub_call }
 
-    it 'should make a proper request call' do
+    it 'makes a proper request call' do
       response = subject.get_conversions
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'getConversions'}))).to have_been_made
       validate_call response
     end
-
-    it 'should call find_all method' do
-      expect(subject).to receive(:get_conversions).with({test: 1})
-      subject.get_conversions test: 1
-    end
   end
 
-  describe '.get_mod_summary_logs' do
+  describe '#get_mod_summary_logs' do
     let(:url)  { Regexp.new api_url('Report') }
 
     before(:each) { stub_call :get }
 
-    it 'should make a proper request call' do
+    it 'makes a proper request call' do
       response = subject.get_mod_summary_logs
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'getModSummaryLogs'}))).to have_been_made
       validate_call response
     end
   end
 
-  describe '.getModSummaryLogs' do
-    let(:url)  { Regexp.new api_url('Report') }
-
-    before(:each) { stub_call :get }
+  describe '#get_stats' do
+    before(:each) { stub_call }
 
-    it 'should make a proper request call' do
-      response = subject.get_mod_summary_logs
-      expect(a_request(:get, url).with(query: hash_including({'Method' => 'getModSummaryLogs'}))).to have_been_made
+    it 'makes a proper request call' do
+      response = subject.get_stats
+      expect(a_request(:post, url).with(body: hash_including({'Method' => 'getStats'}))).to have_been_made
       validate_call response
     end
-
-    it 'should call find_all method' do
-      expect(subject).to receive(:get_mod_summary_logs).with({test: 1})
-      subject.get_mod_summary_logs test: 1
-    end
-
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hasoffersv3
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Maximilian Seifert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-01 00:00:00.000000000 Z
+date: 2016-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.4.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -112,6 +112,7 @@ files:
 - lib/hasoffersv3/configuration.rb
 - lib/hasoffersv3/conversion.rb
 - lib/hasoffersv3/employee.rb
+- lib/hasoffersv3/logger.rb
 - lib/hasoffersv3/offer.rb
 - lib/hasoffersv3/offer_pixel.rb
 - lib/hasoffersv3/raw_log.rb
@@ -128,9 +129,11 @@ files:
 - spec/lib/application_spec.rb
 - spec/lib/base_spec.rb
 - spec/lib/client_spec.rb
+- spec/lib/configuration_spec.rb
 - spec/lib/conversion_spec.rb
 - spec/lib/employee_spec.rb
 - spec/lib/hasoffersv3_spec.rb
+- spec/lib/logger_spec.rb
 - spec/lib/offer_pixel_spec.rb
 - spec/lib/offer_spec.rb
 - spec/lib/raw_log_spec.rb
@@ -156,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: REST Client for the HasOffers API, version 3.
@@ -170,9 +173,11 @@ test_files:
 - spec/lib/application_spec.rb
 - spec/lib/base_spec.rb
 - spec/lib/client_spec.rb
+- spec/lib/configuration_spec.rb
 - spec/lib/conversion_spec.rb
 - spec/lib/employee_spec.rb
 - spec/lib/hasoffersv3_spec.rb
+- spec/lib/logger_spec.rb
 - spec/lib/offer_pixel_spec.rb
 - spec/lib/offer_spec.rb
 - spec/lib/raw_log_spec.rb