hasoffersv3 0.4.1 → 0.5.0

data/spec/lib/affiliate_spec.rb

@@ -1,24 +1,20 @@
-require 'spec_helper'
-
 describe HasOffersV3::Affiliate do
-  subject { HasOffersV3::Affiliate.new }
-
   let(:url)  { api_url 'Affiliate' }
 
   before(:each) do |example|
     stub_call unless example.metadata[:no_stub]
   end
 
-  describe '.find_all' do
-    it 'should make a proper request call' do
+  describe '#find_all' do
+    it 'makes a proper request call' do
       response = subject.find_all
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
   end
 
-  describe '.find_by_id', :no_stub do
-    it 'should make a proper request call' do
+  describe '#find_by_id', :no_stub do
+    it 'makes a proper request call' do
       stub_call :get, nil, Regexp.new(url)
       response = subject.find_by_id id: 1
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'findById', 'id' => '1'}))).to have_been_made
@@ -26,42 +22,42 @@ describe HasOffersV3::Affiliate do
     end
 
     context 'when there is no id' do
-      it 'should raise exception' do
+      it 'raises exception' do
         expect { subject.find_by_id failed_id: 1 }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.update_payment_method_wire' do
-    it 'should make a proper request call' do
+  describe '#update_payment_method_wire' do
+    it 'makes a proper request call' do
       response = subject.update_payment_method_wire
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'updatePaymentMethodWire'}))).to have_been_made
       validate_call response
     end
   end
 
-  describe '.update_payment_method_paypal' do
-    it 'should make a proper request call' do
+  describe '#update_payment_method_paypal' do
+    it 'makes a proper request call' do
       response = subject.update_payment_method_paypal
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'updatePaymentMethodPaypal'}))).to have_been_made
       validate_call response
     end
   end
 
-  describe 'create' do
+  describe '#create' do
     context 'when required params are missing' do
-      it 'should fail without data' do
+      it 'fails without data' do
         expect { subject.create }.to raise_error ArgumentError
       end
-      it 'should fail without data["company"]' do
+      it 'fails without data["company"]' do
         expect { subject.create data: { zipcode: 1234567 }}.to raise_error ArgumentError
       end
-      it 'should fail without data["zipcode"]' do
+      it 'fails without data["zipcode"]' do
         expect { subject.create data: { company: 'xyz@applift.com' }}.to raise_error ArgumentError
       end
     end
 
-    it 'should make a successful request call' do
+    it 'makes a successful request call' do
       response = subject.create data: { company: "xyz@gmail.com", zipcode: "10178" }
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'create', 'data' => {'company' => 'xyz@gmail.com',
        'zipcode' => '10178'}}))).to have_been_made
@@ -69,15 +65,15 @@ describe HasOffersV3::Affiliate do
     end
   end
 
-  describe '.get_tier' do
-    it 'should make a proper request call' do
+  describe '#get_tier' do
+    it 'makes a proper request call' do
       stub_call
       response = subject.get_tier id: 1
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'getAffiliateTier','id' => '1'}))).to have_been_made
       validate_call response
     end
 
-    it 'should fail without id' do
+    it 'fails without id' do
       expect { subject.get_tier }.to raise_error ArgumentError
     end
   end

data/spec/lib/application_spec.rb

@@ -1,11 +1,8 @@
-require 'spec_helper'
-
 describe HasOffersV3::Application do
   let(:url)  { Regexp.new api_url('Application') }
-  
-  describe '.get_payout_tiers' do
-    subject { HasOffersV3::Application }
-    it 'should make a proper request call' do
+
+  describe '#get_payout_tiers' do
+    it 'makes a proper request call' do
       stub_call :get
       response = subject.get_payout_tiers
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'findAllAffiliateTiers'}))).to have_been_made

data/spec/lib/base_spec.rb

@@ -1,18 +1,14 @@
-require 'spec_helper'
-
 describe HasOffersV3::Base do
-  subject { HasOffersV3::Base }
-
   let(:url) { Regexp.new api_url('Base') }
 
-  describe :requires! do
-    it 'raise ArgumentError is parameters are missing' do
+  describe "#requires!" do
+    it 'raises ArgumentError is parameters are missing' do
       expect { subject.requires!({}, [:dummy]) }.to raise_error(ArgumentError)
     end
   end
 
-  describe ".get_request" do
-    it "should make a proper request" do
+  describe "#get_request" do
+    it "makes a proper request" do
       stub_call :get
       response = subject.get_request 'test'
       request = a_request(:get, url).with(query: hash_including('Method' => 'test'))
@@ -31,7 +27,7 @@ describe HasOffersV3::Base do
         HasOffersV3.configuration.protocol = @old_protocol
       end
 
-      it "should make a proper request" do
+      it "makes a proper request" do
         stub_call :get
         response = subject.get_request 'test'
         expect(a_request(:get, url).with(query: hash_including('Method' => 'test'))).to have_been_made

data/spec/lib/client_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe HasOffersV3::Client do
 
   describe '#base_uri' do
@@ -11,7 +9,7 @@ describe HasOffersV3::Client do
       result
     }
 
-    it 'should be different configs' do
+    it 'has different configs' do
       default_connection = HasOffersV3::Client.new(configuration_to_default_host)
       expect(default_connection.base_uri).to eq('https://api.hasoffers.com/v3')
 

data/spec/lib/configuration_spec.rb

@@ -0,0 +1,44 @@
+describe HasOffersV3::Configuration do
+  describe '#http_logger' do
+    it 'returns an instance of HasOffersV3::Logger' do
+      expect(subject.http_logger).to be_instance_of(HasOffersV3::Logger)
+    end
+
+    context 'when logger is default' do
+      it 'uses null HTTP logger' do
+        expect(subject.http_logger.log).to be_nil
+      end
+    end
+
+    context 'when logger is supplied' do
+      let(:logger) { double('logger') }
+      subject { described_class.new(logger: logger) }
+
+      it 'uses supplied logger' do
+        expect(subject.http_logger.log).to eq logger
+      end
+    end
+  end
+
+  describe '#base_uri' do
+    context 'when configuration is default' do
+      it 'builds default base URI' do
+        expect(subject.base_uri).to eq 'https://api.hasoffers.com/v3'
+      end
+    end
+
+    context 'when configuration is customized' do
+      subject do
+        described_class.new(
+          host: 'api2.hasoffers.com',
+          protocol: 'http',
+          base_path: '/v4'
+        )
+      end
+
+      it 'builds base URI according options' do
+        expect(subject.base_uri).to eq 'http://api2.hasoffers.com/v4'
+      end
+    end
+  end
+end

data/spec/lib/conversion_spec.rb

@@ -1,48 +1,31 @@
-require 'spec_helper'
-
 describe HasOffersV3::Conversion do
-  subject { HasOffersV3::Conversion.new }
-
   let(:url)  { Regexp.new api_url('Conversion') }
 
   before :each do
     stub_call :get
   end
 
-  describe '.find_all' do
-    it 'should make a proper request call' do
+  describe '#find_all' do
+    it 'makes a proper request call' do
       response = subject.find_all
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
   end
 
-  describe '.find_added_conversions' do
-    it 'should make a proper request call' do
+  describe '#find_added_conversions' do
+    it 'makes a proper request call' do
       response = subject.find_added_conversions
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'findAddedConversions'}))).to have_been_made
       validate_call response
     end
   end
 
-  describe '.find_updated_conversions' do
-    it 'should make a proper request call' do
+  describe '#find_updated_conversions' do
+    it 'makes a proper request call' do
       response = subject.find_updated_conversions
       expect(a_request(:get, url).with(query: hash_including({'Method' => 'findUpdatedConversions'}))).to have_been_made
       validate_call response
     end
   end
-
-  describe '.findAll' do
-    it 'should make a proper request call' do
-      response = subject.find_all
-      expect(a_request(:get, url).with(query: hash_including({'Method' => 'findAll'}))).to have_been_made
-      validate_call response
-    end
-
-    it 'should call find_all method' do
-      expect(subject).to receive(:find_all).with({test: 1})
-      subject.find_all test: 1
-    end
-  end
 end

data/spec/lib/employee_spec.rb

@@ -1,45 +1,41 @@
-require 'spec_helper'
-
 describe HasOffersV3::Employee do
-  subject { HasOffersV3::Employee.new }
-
   let(:url)  { api_url 'Employee' }
 
   before(:each) do |example|
     stub_call unless example.metadata[:no_stub]
   end
 
-  describe '.find_all' do
-    it 'should make a proper request call' do
+  describe '#find_all' do
+    it 'makes a proper request call' do
       response = subject.find_all
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
   end
 
-  describe '.find_all_by_ids' do
-    it 'should make a proper request call' do
+  describe '#find_all_by_ids' do
+    it 'makes a proper request call' do
       response = subject.find_all_by_ids ids: [1]
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAllByIds'}))).to have_been_made
       validate_call response
     end
 
     context 'when there is no id' do
-      it 'should raise exception' do
+      it 'raises exception' do
         expect { subject.find_all_by_ids }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.find_by_id' do
-    it 'should make a proper request call' do
+  describe '#find_by_id' do
+    it 'makes a proper request call' do
       response = subject.find_by_id id: 1
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findById', 'id' => '1'}))).to have_been_made
       validate_call response
     end
 
     context 'when there is no id' do
-      it 'should raise exception' do
+      it 'raises exception' do
         expect { subject.find_by_id }.to raise_error ArgumentError
       end
     end

data/spec/lib/hasoffersv3_spec.rb

@@ -1,21 +1,18 @@
-require 'spec_helper'
-
 describe HasOffersV3 do
 
   context 'singleton' do
-    it 'should use default config' do
+    it 'uses default config' do
       subject = HasOffersV3::Offer.client.configuration
       expect(subject).to eq(HasOffersV3.configuration)
     end
   end
 
   describe '#configuration' do
-    it 'should create different connections' do
-      subject = HasOffersV3.new
+    it 'creates different connections' do
       expect(subject.configuration).to_not eq(HasOffersV3.configuration)
     end
 
-    it 'should use params instead of default' do
+    it 'uses params instead of default' do
       subject = HasOffersV3.new(host: 'example.com')
       expect(subject.configuration.host).to eq('example.com')
       expect(subject.configuration.host).to_not eq(HasOffersV3::Configuration::DEFAULTS[:host])
@@ -23,10 +20,8 @@ describe HasOffersV3 do
   end
 
   context 'api' do
-    subject { HasOffersV3.new }
-
     describe '#offers' do
-      it 'should get offers for current connection' do
+      it 'gets offers for current connection' do
         offer = double('HasOffersV3::Offer')
         expect(HasOffersV3::Offer).to receive(:new).and_return(offer)
         expect(offer).to receive(:find_all)

data/spec/lib/logger_spec.rb

@@ -0,0 +1,47 @@
+describe HasOffersV3::Logger do
+  let(:log) { double('log') }
+  subject { described_class.new(log) }
+
+  describe '.new' do
+    it 'initializes properly' do
+      expect(subject.log).to eql log
+    end
+  end
+
+  describe '#log_request' do
+    let(:request) do
+      double('request',
+        method: 'POST',
+        each_capitalized: { 'Header' => 'value' },
+        body: 'Var1=value1&Var2=value2'
+      )
+    end
+    let(:uri) { double('uri', to_s: 'http://api.applift.com/path') }
+
+    it 'logs HTTP request' do
+      expected_message = "[HasOffersV3] Request: POST http://api.applift.com/path\nHeader: value\n\nVar1=value1&Var2=value2\n"
+      expect(log).to receive(:info).with(expected_message)
+
+      subject.log_request(request, uri)
+    end
+  end
+
+  describe '#log_response' do
+    let(:response) do
+      double('response',
+        http_version: '1.1',
+        code: 200,
+        message: 'OK',
+        each_capitalized: { 'Header' => 'value' },
+        body: 'Body of this response'
+      )
+    end
+
+    it 'logs HTTP response' do
+      expected_message = "[HasOffersV3] Response: HTTP/1.1 200 OK\nHeader: value\n\nBody of this response\n"
+      expect(log).to receive(:info).with(expected_message)
+
+      subject.log_response(response)
+    end
+  end
+end

data/spec/lib/offer_pixel_spec.rb

@@ -1,26 +1,22 @@
-require 'spec_helper'
-
 describe HasOffersV3::OfferPixel do
-  subject { HasOffersV3::OfferPixel.new }
-
   let(:url) { api_url 'OfferPixel' }
 
-  describe '.find_all' do
-    it 'should make a proper request call' do
+  describe '#find_all' do
+    it 'makes a proper request call' do
       stub_call
       response = subject.find_all
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll'}))).to have_been_made
       validate_call response
     end
 
-    it 'should contain filters by type and modified' do
+    it 'contains filters by type and modified' do
       stub_call
       response = subject.find_all(filters: {type: 'url', modified: {'GREATER_THAN' => '2015-01-01+00:00'}})
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll', filters: { type: 'url', modified: {'GREATER_THAN' => '2015-01-01+00:00'} }}))).to have_been_made
       validate_call response
     end
 
-    it 'should sort by modified' do
+    it 'sorts by modified' do
       stub_call
       response = subject.find_all(sort: {modified: 'asc'})
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAll', sort: {modified: 'asc'}}))).to have_been_made
@@ -28,8 +24,8 @@ describe HasOffersV3::OfferPixel do
     end
   end
 
-  describe '.find_all_by_ids' do
-    it 'should make a proper request call' do
+  describe '#find_all_by_ids' do
+    it 'makes a proper request call' do
       stub_call
       response = subject.find_all_by_ids ids: [1]
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findAllByIds'}))).to have_been_made
@@ -37,14 +33,14 @@ describe HasOffersV3::OfferPixel do
     end
 
     context 'when there is no id' do
-      it 'should raise exception' do
+      it 'raises exception' do
         expect { subject.find_all_by_ids }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.find_by_id' do
-    it 'should make a proper request call' do
+  describe '#find_by_id' do
+    it 'makes a proper request call' do
       stub_call
       response = subject.find_by_id id: [1]
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'findById'}))).to have_been_made
@@ -52,14 +48,14 @@ describe HasOffersV3::OfferPixel do
     end
 
     context 'when there is no id' do
-      it 'should raise exception' do
+      it 'raises exception' do
         expect { subject.find_by_id }.to raise_error ArgumentError
       end
     end
   end
 
-  describe '.get_allowed_types' do
-    it 'should make a proper request call' do
+  describe '#get_allowed_types' do
+    it 'makes a proper request call' do
       stub_call
       response = subject.get_allowed_types offer_id: [1]
       expect(a_request(:post, url).with(body: hash_including({'Method' => 'getAllowedTypes'}))).to have_been_made
@@ -67,7 +63,7 @@ describe HasOffersV3::OfferPixel do
     end
 
     context 'when there is no offer_id' do
-      it 'should raise exception' do
+      it 'raises exception' do
         expect { subject.get_allowed_types }.to raise_error ArgumentError
       end
     end