harvested 0.3.3 → 0.4.0

data/spec/functional/tasks_spec.rb

@@ -0,0 +1,88 @@
+require 'spec_helper'
+
+describe 'harvest tasks' do
+  it 'allows adding, updating and removing tasks' do
+    cassette('tasks') do
+      task            = harvest.tasks.create(
+        "name"        => "A crud task",
+        "billable_by_default"    => true,
+        "default_hourly_rate"    => 120
+      )
+      task.default_hourly_rate.should == "120.0"
+
+      task.default_hourly_rate = 140
+      task = harvest.tasks.update(task)
+      task.default_hourly_rate.should == "140.0"
+
+      harvest.tasks.delete(task)
+      harvest.tasks.all.select {|t| t.name == "A crud task"}.should == []
+    end
+  end
+
+  context "task assignments" do
+    it "allows adding, updating, and removing tasks from projects" do
+      cassette('tasks2') do
+        client      = harvest.clients.create(
+          "name"    => "Joe's Steam Cleaning",
+          "details" => "Building API Widgets across the country"
+        )
+
+        project       = harvest.projects.create(
+          "name"      => "Test Project2",
+          "active"    => true,
+          "notes"     => "project to test the api",
+          "client_id" => client.id
+        )
+
+        task1            = harvest.tasks.create(
+          "name"                => "A task for joe",
+          "billable_by_default" => true,
+          "default_hourly_rate" => 120
+        )
+        
+        # need to keep at least one task on the project
+        task2            = harvest.tasks.create(
+          "name"                => "A task for joe2",
+          "billable_by_default" => true,
+          "default_hourly_rate" => 100
+        )
+        
+        harvest.task_assignments.create("project" => project, "task" => task1)
+        harvest.task_assignments.create("project" => project, "task" => task2)
+        
+        all_assignments = harvest.task_assignments.all(project)
+        assignment1 = all_assignments.detect {|a| a.task_id == task1.id }
+        assignment2 = all_assignments.detect {|a| a.task_id == task2.id }
+        
+        assignment1.hourly_rate = 100
+        assignment1 = harvest.task_assignments.update(assignment1)
+        assignment1.hourly_rate.should == "100.0"
+
+        harvest.task_assignments.delete(assignment1)
+        all_assignments = harvest.task_assignments.all(project)
+        all_assignments.size.should == 1
+      end
+    end
+
+    it "allows creating and assigning the task at the same time" do
+      cassette('tasks3') do
+        client      = harvest.clients.create(
+          "name"    => "Joe's Steam Cleaning 2",
+          "details" => "Building API Widgets across the country"
+        )
+
+        project       = harvest.projects.create(
+          "name"      => "Test Project3",
+          "active"    => true,
+          "notes"     => "project to test the api",
+          "client_id" => client.id
+        )
+
+        project2 = harvest.projects.create_task(project, "A simple task")
+        project2.should == project
+
+        harvest.task_assignments.all(project).size.should == 1
+      end
+    end
+  end
+end

data/spec/functional/time_tracking_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe 'harvest time tracking' do
+  it 'allows adding, updating and removing entries' do
+    cassette("time_tracking1") do
+      client = harvest.clients.create("name" => "Jane's Car Shop")
+      project = harvest.projects.create("name" => "Tracking Project", "client_id" => client.id)
+      harvest.projects.create_task(project, "A billable task")
+      task = harvest.tasks.all.detect {|t| t.name == "A billable task"}
+      
+      entry = harvest.time.create("notes" => "Test api support", "hours" => 3, "spent_at" => "12/28/2009", "task_id" => task.id, "project_id" => project.id)
+      entry.notes.should == "Test api support"
+      
+      entry.notes = "Upgraded to JSON"
+      entry = harvest.time.update(entry)
+      entry.notes.should == "Upgraded to JSON"
+      
+      harvest.time.delete(entry)
+      harvest.time.all(Time.utc(2009, 12, 28)).should == []
+    end
+  end
+  
+  it 'allows you to save entries for a different user' do
+    cassette("time_tracking2") do
+      user = harvest.users.create(
+        "email"      => "frank@example.com", 
+        "first_name" => "Frank",
+        "last_name"  => "Doe",
+        "password"   => "secure"
+      )
+      client = harvest.clients.create("name" => "Kim's Tux Shop")
+      project = harvest.projects.create("name" => "Other User Tracking Project", "client_id" => client.id)
+      harvest.user_assignments.create("project" => project, "user" => user)
+      harvest.projects.create_task(project, "A billable task for tuxes")
+      task = harvest.tasks.all.detect {|t| t.name == "A billable task for tuxes"}
+      
+      entry = harvest.time.create("notes" => "Test api support", "hours" => 3, "spent_at" => "12/28/2009", "task_id" => task.id, "project_id" => project.id, "of_user" => user.id)
+      harvest.time.all(Time.utc(2009, 12, 28), user).should == [entry]
+      
+      entry.notes = "Updating notes"
+      entry = harvest.time.update(entry, user)
+      entry.notes.should == "Updating notes"
+      
+      entry = harvest.time.find(entry, user)
+      entry.notes.should == "Updating notes"
+      
+      harvest.time.delete(entry, user)
+      harvest.time.all(Time.utc(2009, 12, 28), user).should == []
+    end
+  end
+  
+  it 'allows toggling of timers'
+end

data/spec/functional/users_spec.rb

@@ -0,0 +1,102 @@
+require 'spec_helper'
+
+describe 'harvest users' do
+  it "allows adding, updating, and removing users" do
+    cassette("users") do
+      user = harvest.users.create(
+        "first_name"            => "Edgar",
+        "last_name"             => "Ruth",
+        "email"                 => "edgar@ruth.com",
+        "password"              => "mypassword",
+        "timezone"              => "cst",
+        "is_admin"                 => "false",
+        "telephone"             => "444-4444"
+      )
+      user.id.should_not be_blank
+    
+      user.first_name = "Joey"
+      user = harvest.users.update(user)
+      user.first_name.should == "Joey"
+    
+      id = harvest.users.delete(user)
+      harvest.users.all.map(&:id).should_not include(id)
+    end
+  end
+  
+  it "allows activating and deactivating users" do
+    cassette("users2") do
+      user = harvest.users.create(
+        "first_name"            => "John",
+        "last_name"             => "Ruth",
+        "email"                 => "john@ruth.com",
+        "password"              => "mypassword",
+        "timezone"              => "cst",
+        "is_admin"              => "false",
+        "telephone"             => "444-4444"
+      )
+      user.should be_active
+      
+      user = harvest.users.deactivate(user)
+      user.should_not be_active
+      
+      user = harvest.users.activate(user)
+      user.should be_active
+    end
+  end
+  
+  it "allows password resets" do
+    cassette("users3") do
+      user = harvest.users.create(
+        "first_name"            => "Timmy",
+        "last_name"             => "Ruth",
+        "email"                 => "timmy@ruth.com",
+        "password"              => "mypassword",
+        "timezone"              => "cst",
+        "is_admin"             => "false",
+        "telephone"             => "444-4444"
+      )
+      user.should be_active
+      
+      harvest.users.reset_password(user) # nothing else to assert
+    end
+  end
+  
+  context "assignments" do
+    it "allows adding, updating, and removing users from projects" do
+      cassette('users4') do
+        client      = harvest.clients.create(
+          "name"    => "Joe's Steam Cleaning w/Users",
+          "details" => "Building API Widgets across the country"
+        )
+
+        project       = harvest.projects.create(
+          "name"      => "Test Project w/User",
+          "active"    => true,
+          "notes"     => "project to test the api",
+          "client_id" => client.id
+        )
+
+        user = harvest.users.create(
+          "first_name"            => "Sally",
+          "last_name"             => "Ruth",
+          "email"                 => "sally@ruth.com",
+          "password"              => "mypassword",
+          "timezone"              => "cst",
+          "is_admin"              => "false",
+          "telephone"             => "444-4444"
+        )
+        
+
+        assignment = harvest.user_assignments.create("project" => project, "user" => user)
+        
+        assignment.hourly_rate = 100
+        assignment = harvest.user_assignments.update(assignment)
+        assignment.hourly_rate.should == "100.0"
+
+        harvest.user_assignments.delete(assignment)
+        all_assignments = harvest.user_assignments.all(project)
+        all_assignments.size.should == 1
+      end
+    end
+  end
+end

data/spec/harvest/base_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Harvest::Base do
   describe "username/password errors" do

data/spec/harvest/credentials_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Harvest::Credentials do
   describe "#valid?" do

data/spec/harvest/expense_category_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe Harvest::ExpenseCategory do
+  it_behaves_like 'a json sanitizer', %w(cache_version)
+end

data/spec/harvest/expense_spec.rb

@@ -1,15 +1,18 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Harvest::Expense do
+  it_behaves_like 'a json sanitizer', %w(has_receipt receipt_url)
+  
   describe "#spent_at" do
     it "should parse strings" do
-      expense = Harvest::Expense.new(:spent_at => "12/01/2009")
-      expense.spent_at.should == Time.parse("12/01/2009")
+      date = RUBY_VERSION =~ /1.8/ ? "12/01/2009" : "01/12/2009"
+      expense = Harvest::Expense.new(:spent_at => date)
+      expense.spent_at.should == Time.parse(date)
     end
     
     it "should accept times" do
-      expense = Harvest::Expense.new(:spent_at => Time.parse("12/01/2009"))
-      expense.spent_at.should == Time.parse("12/01/2009")
+      expense = Harvest::Expense.new(:spent_at => Time.utc(2009, 12, 1))
+      expense.spent_at.should == Time.utc(2009, 12, 1)
     end
   end
 end

data/spec/harvest/invoice_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe Harvest::Invoice do
+  context 'line_items' do
+    it 'parses csv into objects' do
+      invoice = Harvest::Invoice.new(:line_items => "kind,description,quantity,unit_price,amount,taxed,taxed2,project_id\nService,Abc,200,12.00,2400.0,false,false,100\nService,def,1.00,20.00,20.0,false,false,101\n")
+      invoice.line_items.count.should == 2
+      line_item = invoice.line_items.first
+      
+      line_item.kind.should == "Service"
+      line_item.project_id.should == "100"
+    end
+    
+    it 'parses csv into objects w/o projects' do
+      invoice = Harvest::Invoice.new(:line_items => "kind,description,quantity,unit_price,amount,taxed,taxed2,project_id\nService,Abc,200,12.00,2400.0,false,false,\nService,def,1.00,20.00,20.0,false,false,\n")
+      invoice.line_items.count.should == 2
+      line_item = invoice.line_items.first
+      
+      line_item.kind.should == "Service"
+      line_item.description.should == "Abc"
+    end
+    
+    it 'parses empty strings' do
+      invoice = Harvest::Invoice.new(:line_items => "")
+      invoice.line_items.should == []
+    end
+    
+    it 'accepts rich objects' do
+      Harvest::Invoice.new(:line_items => [Harvest::LineItem.new(:kind => "Service")]).line_items.count.should == 1
+      Harvest::Invoice.new(:line_items => Harvest::LineItem.new(:kind => "Service")).line_items.count.should == 1
+    end
+    
+    it 'accepts nil' do
+      Harvest::Invoice.new(:line_items => nil).line_items.should == []
+    end
+  end
+  
+  context "as_json" do
+    it 'encodes line items csv' do
+      invoice = Harvest::Invoice.new(:line_items => "kind,description,quantity,unit_price,amount,taxed,taxed2,project_id\nService,Abc,200,12.00,2400.0,false,false,\nService,def,1.00,20.00,20.0,false,false,\n")
+      invoice.line_items.count.should == 2
+      invoice.line_items.first.kind.should == "Service"
+      
+      invoice.as_json["doc"]["csv_line_items"].should == "kind,description,quantity,unit_price,amount,taxed,taxed2,project_id\nService,Abc,200,12.00,2400.0,false,false,\nService,def,1.00,20.00,20.0,false,false,\n"
+    end
+  end
+end

data/spec/harvest/project_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe Harvest::Project do
+  it_behaves_like 'a json sanitizer', %w(hint_latest_record_at hint_earliest_record_at cache_version)
+    
+  it "cleans up weird attributes" do
+    project = Harvest::Project.parse('[{"project":{"hint-earliest-record-at":10, "hint-latest-record-at":20}}]').first
+    project.hint_earliest_record_at.should == 10
+    project.hint_latest_record_at.should == 20
+  end
+end

data/spec/harvest/task_assignment_spec.rb

@@ -1,10 +1,10 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Harvest::TaskAssignment do
-  describe "#task_xml" do
-    it "should generate the xml for existing tasks" do
+  context "task_as_json" do
+    it "generates the json for existing tasks" do
       assignment = Harvest::TaskAssignment.new(:task => mock(:task, :to_i => 3))
-      assignment.task_xml.should == '<task><id>3</id></task>'
+      assignment.task_as_json.should == {"task" => {"id" => 3}}
     end
   end
 end

data/spec/harvest/task_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe Harvest::Task do
+  it_behaves_like 'a json sanitizer', %w(cache_version)
+  
+  it 'casts default_hourly_rate to float'
+end

data/spec/harvest/time_entry_spec.rb

@@ -1,22 +1,23 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Harvest::TimeEntry do
-  describe "#to_xml" do
-    it "should build a valid request xml" do
-      entry = Harvest::TimeEntry.new(:notes => 'the notes', :project_id => 'the project id', :task_id => 'the task id', :hours => 'the hours', :spent_at => '12/28/2009')
-      entry.to_xml.should == '<request><notes>the notes</notes><hours>the hours</hours><project_id>the project id</project_id><task_id>the task id</task_id><spent_at>Mon Dec 28 00:00:00 -0500 2009</spent_at></request>'
+  context '#as_json' do
+    it 'builds a specialized hash' do
+      entry = Harvest::TimeEntry.new(:notes => 'the notes', :project_id => 'the project id', :task_id => 'the task id', :hours => 'the hours', :spent_at => Time.utc(2009, 12, 28))
+      entry.as_json.should == {"notes" => "the notes", "hours" => "the hours", "project_id" => "the project id", "task_id" => "the task id", "spent_at" => "2009-12-28T00:00:00Z"}
     end
   end
   
-  describe "#spent_at" do
+  context "#spent_at" do
     it "should parse strings" do
-      entry = Harvest::TimeEntry.new(:spent_at => "12/01/2009")
-      entry.spent_at.should == Time.parse("12/01/2009")
+      date = RUBY_VERSION =~ /1.8/ ? "12/01/2009" : "01/12/2009"
+      entry = Harvest::TimeEntry.new(:spent_at => date)
+      entry.spent_at.should == Time.parse(date)
     end
     
     it "should accept times" do
-      entry = Harvest::TimeEntry.new(:spent_at => Time.parse("12/01/2009"))
-      entry.spent_at.should == Time.parse("12/01/2009")
+      entry = Harvest::TimeEntry.new(:spent_at => Time.utc(2009, 12, 1))
+      entry.spent_at.should == Time.utc(2009, 12, 1)
     end
   end
 end

data/spec/harvest/user_assignment_spec.rb

@@ -1,10 +1,10 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Harvest::UserAssignment do
-  describe "#user_xml" do
+  describe "#user_as_json" do
     it "should generate the xml for existing users" do
       assignment = Harvest::UserAssignment.new(:user => mock(:user, :to_i => 3))
-      assignment.user_xml.should == '<user><id>3</id></user>'
+      assignment.user_as_json.should == {"user" => {"id" => 3}}
     end
   end
 end

data/spec/harvest/user_spec.rb

@@ -1,6 +1,8 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Harvest::User do
+  it_behaves_like 'a json sanitizer', %w(cache_version)
+  
   describe "#timezone" do
     it "should convert friendly timezone setting" do
       p = Harvest::User.new(:timezone => :cst)

data/spec/spec_helper.rb

@@ -1,10 +1,41 @@
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-require "rubygems"
 require 'harvested'
-require 'spec'
-require 'spec/autorun'
+require 'webmock/rspec'
+require 'vcr'
 
-Spec::Runner.configure do |config|
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require File.expand_path(f) }
+
+VCR.config do |c|
+  c.cassette_library_dir = '.cassettes'
+  c.stub_with :webmock
+end
+
+RSpec.configure do |config|
+  config.include HarvestedHelpers
+  
+  config.before(:suite) do
+    WebMock.allow_net_connect!
+    cassette("clean") do
+      HarvestedHelpers.clean_remote
+    end
+  end
+  
+  config.before(:each) do
+    WebMock.allow_net_connect!
+  end
   
+  def cassette(*args)
+    if ENV['CACHE'] == "false"
+      if args.last.is_a?(Hash)
+        last = args.pop
+        last[:record] = :all
+        args << last
+      else
+        args << {:record => :all}
+      end
+    end
+    
+    VCR.use_cassette(*args) do
+      yield
+    end
+  end
 end