harvested 0.3.3 → 0.4.0

data/Gemfile

@@ -0,0 +1,15 @@
+source :rubygems
+
+gem 'httparty'
+gem 'hashie', '~> 1'
+gem 'json'
+
+group :development, :test do
+  gem  "rspec", "~> 2"
+  gem 'ruby-debug',   :platform => [:mri_18, :jruby]
+  gem 'ruby-debug19', :platform => :mri_19, :require => 'ruby-debug'
+  gem 'jruby-openssl', :platform => [:jruby], :require => false
+  gem  "webmock"
+  gem  "vcr"
+  gem 'jeweler', :require => false
+end

data/HISTORY

@@ -1,3 +1,14 @@
+0.4.0 - August 4, 2011
+  * Large rewrite of codebase
+  * Rewrite of library to use JSON instead of XML
+  * Rewrite of tests to use rspec instead of cucumber
+  * Brought in VCR to help cache test responses
+  * Implemented more reporting functionality
+  * Implemented most of the invoice functionality. Creating/Editing/Updating is disabled due to Harvest API issue
+  * Consolidated various forks (thanks Chris Ritterdorf, bricooke, Michelle Moon Lee, tkwong, Steve McKinney, and others that helped but aren't in the git log!)
+  * Tests passing against MRI 1.8, 1.9, JRuby, and Rubinius
+0.3.3 - January 27, 2010
+  * Adding fields to TaskAssignment (Quilted)
 0.3.2 - January 27, 2010
   * Add of_user support to Time Entry (Benjamin Wong - tkwong)
 0.3.1 - October 14, 2010

data/README.md

@@ -26,12 +26,15 @@ Using `Harvested#client` your code needs to handle all these situations. However
     harvest = Harvest.hardy_client('yoursubdomain', 'yourusername', 'yourpassword')
     harvest.projects() # This will wait for the Rate Limit reset if you have gone over your limit
 
+## Ruby support
+
+Harvested's tests are currently passing for 1.8.7, 1.9.2, JRuby 1.6.2, and Rubinius
+
 ## Links
 
 * [Harvested Documentation](http://rdoc.info/projects/zmoazeni/harvested)
 * [Harvest API Documentation](http://www.getharvest.com/api)
 * [Source Code for Harvested](http://github.com/zmoazeni/harvested)
-* [Pivotal Tracker for Harvested](http://www.pivotaltracker.com/projects/63260)
 * [Mailing List for Harvested](http://groups.google.com/group/harvested)
 
 ## How to Contribute
@@ -49,20 +52,25 @@ If you want to contribute an enhancement or a fix:
 3. Commit the changes without messing with the Rakefile, VERSION, or history
 4. Send me a pull request
 
-Note on running tests: most cucumber features run against a live Harvest account. To run the suite, sign up for a free trial account and fill out `/features/support/harvest_credentials.yml` *(a sample harvest_credentials.example.yml has been included)*. The tests use the hardy_client so they will wait for a rate limit reset when they detect the limit has been hit.
+Note on running tests: most specs run against a live Harvest account. To run the suite, sign up for a free trial account and fill out `/spec/support/harvest_credentials.yml` *(a sample harvest_credentials.example.yml has been included)*.
+
+The tests use [VCR](https://github.com/myronmarston/vcr) to cache the test responses. This is a great boon for running the tests offline. While uncommon, sometimes the Harvest API will send an erroneous response and VCR will cache it, then subsequent runs will use the incorrect cached response. In order to ignore VCR you can run the specs by passing CACHE=false (e.g. `CACHE=false bundle rake spec`).
+
+Using [rvm](https://rvm.beginrescueend.com/) you can run the tests against the popular ruby runtimes by running:
+  
+  ./spec/test_rubies
+
+Each runtime needs to be installed in rvm along with the bundler gem.
 
 ## TODO
 
 * Write Documentation
-* Implement Invoices
 * Allow Timer Toggling
 
-Other Roadmap items can be found on [Pivotal Tracker](http://www.pivotaltracker.com/projects/63260)
-
 ## Notes on Harvest Estimates
 
 Estimates aren't currently supported due to lack of an API. If this opens up, harvested will include them.
 
 ## Copyright
 
-Copyright (c) 2010 Zach Moazeni. See LICENSE for details.
+Copyright (c) 2010-2011 Zach Moazeni. See LICENSE for details.

data/Rakefile

@@ -1,5 +1,6 @@
 require 'rubygems'
 require 'rake'
+require "bundler/setup"
 
 begin
   require 'jeweler'
@@ -10,13 +11,6 @@ begin
     gem.email = "zach.moazeni@gmail.com"
     gem.homepage = "http://github.com/zmoazeni/harvested"
     gem.authors = ["Zach Moazeni"]
-    gem.add_development_dependency "rspec", ">= 1.2.9"
-    gem.add_development_dependency "cucumber", ">= 0"
-    gem.add_development_dependency "ruby-debug", ">= 0"
-    gem.add_development_dependency "fakeweb", ">= 0"
-    gem.add_dependency "httparty", ">= 0"
-    gem.add_dependency "happymapper", ">= 0"
-    gem.add_dependency "builder", ">= 0"
   end
   Jeweler::GemcutterTasks.new
 rescue LoadError => e
@@ -24,30 +18,8 @@ rescue LoadError => e
   puts "Jeweler (or a dependency) not available. Install it with: gem install jeweler"
 end
 
-require 'spec/rake/spectask'
-Spec::Rake::SpecTask.new(:spec) do |spec|
-  spec.libs << 'lib' << 'spec'
-  spec.spec_files = FileList['spec/**/*_spec.rb']
-end
-
-Spec::Rake::SpecTask.new(:rcov) do |spec|
-  spec.libs << 'lib' << 'spec'
-  spec.pattern = 'spec/**/*_spec.rb'
-  spec.rcov = true
-end
-
-task :spec => :check_dependencies
-
-begin
-  require 'cucumber/rake/task'
-  Cucumber::Rake::Task.new(:features)
-
-  task :features => :check_dependencies
-rescue LoadError
-  task :features do
-    abort "Cucumber is not available. In order to run features, you must: sudo gem install cucumber"
-  end
-end
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
 
 task :default => %w(spec features)
 
@@ -58,4 +30,14 @@ rescue LoadError
   task :yardoc do
     abort "YARD is not available. In order to run yardoc, you must: sudo gem install yard"
   end
+end
+
+desc 'Removes all data on harvest'
+task 'clean_remote' do
+  require 'harvested'
+  require "spec/support/harvested_helpers"
+  HarvestedHelpers.clean_remote
+end
+
+task :foo do
 end

data/TODO

@@ -0,0 +1,2 @@
+* Test w/o Rails, w/Rails2, and w/Rails3
+* Link Referral

data/VERSION

@@ -1 +1 @@
-0.3.3
+0.4.0

data/examples/user_assignments.rb

@@ -16,7 +16,7 @@ project = harvest.projects.create(project)
 
 harvest.projects.create_task(project, 'Bottling Glue')
 
-user = Harvest::User.new(:first_name => 'Jane', :last_name => 'Doe', :email => 'jane@doe.com', :timezone => :est, :password => 'secure', :password_confirmation => 'secure')
+user = Harvest::User.new(:first_name => 'Jane', :last_name => 'Doe', :email => 'jane@doe.com', :timezone => :est, :password => 'secure')
 user = harvest.users.create(user)
 
 user_assignment = Harvest::UserAssignment.new(:user_id => user.id, :project_id => project.id)

data/harvested.gemspec

@@ -1,159 +1,147 @@
 # Generated by jeweler
 # DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
+# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
   s.name = %q{harvested}
-  s.version = "0.3.3"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Zach Moazeni"]
-  s.date = %q{2011-01-27}
+  s.date = %q{2011-08-04}
   s.description = %q{Harvested wraps the Harvest API concisely without the use of Rails dependencies. More information about the Harvest API can be found on their website (http://www.getharvest.com/api). For support hit up the Mailing List (http://groups.google.com/group/harvested)}
   s.email = %q{zach.moazeni@gmail.com}
   s.extra_rdoc_files = [
-    "README.md"
+    "README.md",
+    "TODO"
   ]
   s.files = [
     ".document",
-     ".gitignore",
-     "HISTORY",
-     "MIT-LICENSE",
-     "README.md",
-     "Rakefile",
-     "VERSION",
-     "examples/basics.rb",
-     "examples/clear_account.rb",
-     "examples/task_assignments.rb",
-     "examples/user_assignments.rb",
-     "features/account.feature",
-     "features/client_contacts.feature",
-     "features/clients.feature",
-     "features/errors.feature",
-     "features/expense_categories.feature",
-     "features/expenses.feature",
-     "features/hardy_client.feature",
-     "features/projects.feature",
-     "features/reporting.feature",
-     "features/step_definitions/account_steps.rb",
-     "features/step_definitions/assignment_steps.rb",
-     "features/step_definitions/contact_steps.rb",
-     "features/step_definitions/debug_steps.rb",
-     "features/step_definitions/error_steps.rb",
-     "features/step_definitions/expenses_steps.rb",
-     "features/step_definitions/harvest_steps.rb",
-     "features/step_definitions/model_steps.rb",
-     "features/step_definitions/people_steps.rb",
-     "features/step_definitions/report_steps.rb",
-     "features/step_definitions/time_entry_steps.rb",
-     "features/support/env.rb",
-     "features/support/error_helpers.rb",
-     "features/support/fixtures/empty_clients.xml",
-     "features/support/fixtures/over_limit.xml",
-     "features/support/fixtures/receipt.png",
-     "features/support/fixtures/under_limit.xml",
-     "features/support/harvest_credentials.example.yml",
-     "features/support/harvest_helpers.rb",
-     "features/support/inflections.rb",
-     "features/task_assignment.feature",
-     "features/tasks.feature",
-     "features/time_tracking.feature",
-     "features/user_assignments.feature",
-     "features/users.feature",
-     "harvested.gemspec",
-     "lib/harvest/api/account.rb",
-     "lib/harvest/api/base.rb",
-     "lib/harvest/api/clients.rb",
-     "lib/harvest/api/contacts.rb",
-     "lib/harvest/api/expense_categories.rb",
-     "lib/harvest/api/expenses.rb",
-     "lib/harvest/api/projects.rb",
-     "lib/harvest/api/reports.rb",
-     "lib/harvest/api/task_assignments.rb",
-     "lib/harvest/api/tasks.rb",
-     "lib/harvest/api/time.rb",
-     "lib/harvest/api/user_assignments.rb",
-     "lib/harvest/api/users.rb",
-     "lib/harvest/base.rb",
-     "lib/harvest/base_model.rb",
-     "lib/harvest/behavior/activatable.rb",
-     "lib/harvest/behavior/crud.rb",
-     "lib/harvest/client.rb",
-     "lib/harvest/contact.rb",
-     "lib/harvest/credentials.rb",
-     "lib/harvest/errors.rb",
-     "lib/harvest/expense.rb",
-     "lib/harvest/expense_category.rb",
-     "lib/harvest/hardy_client.rb",
-     "lib/harvest/project.rb",
-     "lib/harvest/rate_limit_status.rb",
-     "lib/harvest/task.rb",
-     "lib/harvest/task_assignment.rb",
-     "lib/harvest/time_entry.rb",
-     "lib/harvest/timezones.rb",
-     "lib/harvest/user.rb",
-     "lib/harvest/user_assignment.rb",
-     "lib/harvested.rb",
-     "spec/harvest/base_spec.rb",
-     "spec/harvest/credentials_spec.rb",
-     "spec/harvest/expense_spec.rb",
-     "spec/harvest/task_assignment_spec.rb",
-     "spec/harvest/time_entry_spec.rb",
-     "spec/harvest/user_assignment_spec.rb",
-     "spec/harvest/user_spec.rb",
-     "spec/spec.default.opts",
-     "spec/spec_helper.rb"
+    "Gemfile",
+    "HISTORY",
+    "MIT-LICENSE",
+    "README.md",
+    "Rakefile",
+    "TODO",
+    "VERSION",
+    "examples/basics.rb",
+    "examples/clear_account.rb",
+    "examples/task_assignments.rb",
+    "examples/user_assignments.rb",
+    "harvested.gemspec",
+    "lib/ext/array.rb",
+    "lib/ext/date.rb",
+    "lib/ext/hash.rb",
+    "lib/ext/time.rb",
+    "lib/harvest/api/account.rb",
+    "lib/harvest/api/base.rb",
+    "lib/harvest/api/clients.rb",
+    "lib/harvest/api/contacts.rb",
+    "lib/harvest/api/expense_categories.rb",
+    "lib/harvest/api/expenses.rb",
+    "lib/harvest/api/invoice_categories.rb",
+    "lib/harvest/api/invoices.rb",
+    "lib/harvest/api/projects.rb",
+    "lib/harvest/api/reports.rb",
+    "lib/harvest/api/task_assignments.rb",
+    "lib/harvest/api/tasks.rb",
+    "lib/harvest/api/time.rb",
+    "lib/harvest/api/user_assignments.rb",
+    "lib/harvest/api/users.rb",
+    "lib/harvest/base.rb",
+    "lib/harvest/behavior/activatable.rb",
+    "lib/harvest/behavior/crud.rb",
+    "lib/harvest/client.rb",
+    "lib/harvest/contact.rb",
+    "lib/harvest/credentials.rb",
+    "lib/harvest/errors.rb",
+    "lib/harvest/expense.rb",
+    "lib/harvest/expense_category.rb",
+    "lib/harvest/hardy_client.rb",
+    "lib/harvest/invoice.rb",
+    "lib/harvest/invoice_category.rb",
+    "lib/harvest/line_item.rb",
+    "lib/harvest/model.rb",
+    "lib/harvest/project.rb",
+    "lib/harvest/rate_limit_status.rb",
+    "lib/harvest/task.rb",
+    "lib/harvest/task_assignment.rb",
+    "lib/harvest/time_entry.rb",
+    "lib/harvest/timezones.rb",
+    "lib/harvest/user.rb",
+    "lib/harvest/user_assignment.rb",
+    "lib/harvested.rb",
+    "spec/functional/account_spec.rb",
+    "spec/functional/clients_spec.rb",
+    "spec/functional/errors_spec.rb",
+    "spec/functional/expenses_spec.rb",
+    "spec/functional/hardy_client_spec.rb",
+    "spec/functional/invoice_spec.rb",
+    "spec/functional/project_spec.rb",
+    "spec/functional/reporting_spec.rb",
+    "spec/functional/tasks_spec.rb",
+    "spec/functional/time_tracking_spec.rb",
+    "spec/functional/users_spec.rb",
+    "spec/harvest/base_spec.rb",
+    "spec/harvest/credentials_spec.rb",
+    "spec/harvest/expense_category_spec.rb",
+    "spec/harvest/expense_spec.rb",
+    "spec/harvest/invoice_spec.rb",
+    "spec/harvest/project_spec.rb",
+    "spec/harvest/task_assignment_spec.rb",
+    "spec/harvest/task_spec.rb",
+    "spec/harvest/time_entry_spec.rb",
+    "spec/harvest/user_assignment_spec.rb",
+    "spec/harvest/user_spec.rb",
+    "spec/spec_helper.rb",
+    "spec/support/harvest_credentials.example.yml",
+    "spec/support/harvested_helpers.rb",
+    "spec/support/json_examples.rb",
+    "spec/test_rubies"
   ]
   s.homepage = %q{http://github.com/zmoazeni/harvested}
-  s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.7}
+  s.rubygems_version = %q{1.6.2}
   s.summary = %q{A Ruby Wrapper for the Harvest API http://www.getharvest.com/}
-  s.test_files = [
-    "spec/harvest/base_spec.rb",
-     "spec/harvest/credentials_spec.rb",
-     "spec/harvest/expense_spec.rb",
-     "spec/harvest/task_assignment_spec.rb",
-     "spec/harvest/time_entry_spec.rb",
-     "spec/harvest/user_assignment_spec.rb",
-     "spec/harvest/user_spec.rb",
-     "spec/spec_helper.rb",
-     "examples/basics.rb",
-     "examples/clear_account.rb",
-     "examples/task_assignments.rb",
-     "examples/user_assignments.rb"
-  ]
 
   if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<rspec>, [">= 1.2.9"])
-      s.add_development_dependency(%q<cucumber>, [">= 0"])
-      s.add_development_dependency(%q<ruby-debug>, [">= 0"])
-      s.add_development_dependency(%q<fakeweb>, [">= 0"])
       s.add_runtime_dependency(%q<httparty>, [">= 0"])
-      s.add_runtime_dependency(%q<happymapper>, [">= 0"])
-      s.add_runtime_dependency(%q<builder>, [">= 0"])
+      s.add_runtime_dependency(%q<hashie>, ["~> 1"])
+      s.add_runtime_dependency(%q<json>, [">= 0"])
+      s.add_development_dependency(%q<rspec>, ["~> 2"])
+      s.add_development_dependency(%q<ruby-debug>, [">= 0"])
+      s.add_development_dependency(%q<ruby-debug19>, [">= 0"])
+      s.add_development_dependency(%q<jruby-openssl>, [">= 0"])
+      s.add_development_dependency(%q<webmock>, [">= 0"])
+      s.add_development_dependency(%q<vcr>, [">= 0"])
+      s.add_development_dependency(%q<jeweler>, [">= 0"])
     else
-      s.add_dependency(%q<rspec>, [">= 1.2.9"])
-      s.add_dependency(%q<cucumber>, [">= 0"])
-      s.add_dependency(%q<ruby-debug>, [">= 0"])
-      s.add_dependency(%q<fakeweb>, [">= 0"])
       s.add_dependency(%q<httparty>, [">= 0"])
-      s.add_dependency(%q<happymapper>, [">= 0"])
-      s.add_dependency(%q<builder>, [">= 0"])
+      s.add_dependency(%q<hashie>, ["~> 1"])
+      s.add_dependency(%q<json>, [">= 0"])
+      s.add_dependency(%q<rspec>, ["~> 2"])
+      s.add_dependency(%q<ruby-debug>, [">= 0"])
+      s.add_dependency(%q<ruby-debug19>, [">= 0"])
+      s.add_dependency(%q<jruby-openssl>, [">= 0"])
+      s.add_dependency(%q<webmock>, [">= 0"])
+      s.add_dependency(%q<vcr>, [">= 0"])
+      s.add_dependency(%q<jeweler>, [">= 0"])
     end
   else
-    s.add_dependency(%q<rspec>, [">= 1.2.9"])
-    s.add_dependency(%q<cucumber>, [">= 0"])
-    s.add_dependency(%q<ruby-debug>, [">= 0"])
-    s.add_dependency(%q<fakeweb>, [">= 0"])
     s.add_dependency(%q<httparty>, [">= 0"])
-    s.add_dependency(%q<happymapper>, [">= 0"])
-    s.add_dependency(%q<builder>, [">= 0"])
+    s.add_dependency(%q<hashie>, ["~> 1"])
+    s.add_dependency(%q<json>, [">= 0"])
+    s.add_dependency(%q<rspec>, ["~> 2"])
+    s.add_dependency(%q<ruby-debug>, [">= 0"])
+    s.add_dependency(%q<ruby-debug19>, [">= 0"])
+    s.add_dependency(%q<jruby-openssl>, [">= 0"])
+    s.add_dependency(%q<webmock>, [">= 0"])
+    s.add_dependency(%q<vcr>, [">= 0"])
+    s.add_dependency(%q<jeweler>, [">= 0"])
   end
 end
 

data/lib/ext/array.rb

@@ -0,0 +1,52 @@
+# Shamelessly ripped from https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/array/wrap.rb
+
+unless Array.respond_to?(:wrap)
+  class Array
+    # Wraps its argument in an array unless it is already an array (or array-like).
+    #
+    # Specifically:
+    #
+    # * If the argument is +nil+ an empty list is returned.
+    # * Otherwise, if the argument responds to +to_ary+ it is invoked, and its result returned.
+    # * Otherwise, returns an array with the argument as its single element.
+    #
+    #   Array.wrap(nil)       # => []
+    #   Array.wrap([1, 2, 3]) # => [1, 2, 3]
+    #   Array.wrap(0)         # => [0]
+    #
+    # This method is similar in purpose to <tt>Kernel#Array</tt>, but there are some differences:
+    #
+    # * If the argument responds to +to_ary+ the method is invoked. <tt>Kernel#Array</tt>
+    # moves on to try +to_a+ if the returned value is +nil+, but <tt>Arraw.wrap</tt> returns
+    # such a +nil+ right away.
+    # * If the returned value from +to_ary+ is neither +nil+ nor an +Array+ object, <tt>Kernel#Array</tt>
+    # raises an exception, while <tt>Array.wrap</tt> does not, it just returns the value.
+    # * It does not call +to_a+ on the argument, though special-cases +nil+ to return an empty array.
+    #
+    # The last point is particularly worth comparing for some enumerables:
+    #
+    #   Array(:foo => :bar)      # => [[:foo, :bar]]
+    #   Array.wrap(:foo => :bar) # => [{:foo => :bar}]
+    #
+    #   Array("foo\nbar")        # => ["foo\n", "bar"], in Ruby 1.8
+    #   Array.wrap("foo\nbar")   # => ["foo\nbar"]
+    #
+    # There's also a related idiom that uses the splat operator:
+    #
+    #   [*object]
+    #
+    # which returns <tt>[nil]</tt> for +nil+, and calls to <tt>Array(object)</tt> otherwise.
+    #
+    # Thus, in this case the behavior is different for +nil+, and the differences with
+    # <tt>Kernel#Array</tt> explained above apply to the rest of +object+s.
+    def self.wrap(object)
+      if object.nil?
+        []
+      elsif object.respond_to?(:to_ary)
+        object.to_ary
+      else
+        [object]
+      end
+    end
+  end
+end