hanami 2.3.2 → 3.0.0.rc1

data/spec/integration/action/slice_configuration_spec.rb

@@ -1,284 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe "App action / Slice configuration", :app_integration do
-  before do
-    with_directory(@dir = make_tmp_directory) do
-      write "config/app.rb", <<~'RUBY'
-        require "hanami"
-
-        module TestApp
-          class App < Hanami::App
-          end
-        end
-      RUBY
-
-      write "app/action.rb", <<~'RUBY'
-        require "hanami/action"
-
-        module TestApp
-          class Action < Hanami::Action
-          end
-        end
-      RUBY
-
-      require "hanami/setup"
-    end
-  end
-
-  def prepare_app
-    with_directory(@dir) { require "hanami/prepare" }
-  end
-
-  describe "inheriting from app-level base class" do
-    describe "app-level base class" do
-      it "applies default actions config from the app", :aggregate_failures do
-        prepare_app
-
-        expect(TestApp::Action.config.formats.accepted).to eq []
-      end
-
-      it "applies actions config from the app" do
-        Hanami.app.config.actions.formats.accepted = [:json]
-
-        prepare_app
-
-        expect(TestApp::Action.config.formats.accepted).to eq [:json]
-      end
-
-      it "does not override config in the base class" do
-        Hanami.app.config.actions.formats.accepted = [:csv]
-
-        prepare_app
-
-        TestApp::Action.config.formats.accepted = [:json]
-
-        expect(TestApp::Action.config.formats.accepted).to eq [:json]
-      end
-    end
-
-    describe "subclass in app" do
-      before do
-        with_directory(@dir) do
-          write "app/actions/articles/index.rb", <<~'RUBY'
-            module TestApp
-              module Actions
-                module Articles
-                  class Index < TestApp::Action
-                  end
-                end
-              end
-            end
-          RUBY
-        end
-      end
-
-      it "applies default actions config from the app", :aggregate_failures do
-        prepare_app
-
-        expect(TestApp::Actions::Articles::Index.config.formats.accepted).to eq []
-      end
-
-      it "applies actions config from the app" do
-        Hanami.app.config.actions.formats.accepted = [:json]
-
-        prepare_app
-
-        expect(TestApp::Actions::Articles::Index.config.formats.accepted).to eq [:json]
-      end
-
-      it "applies config from the base class" do
-        prepare_app
-
-        TestApp::Action.config.formats.accepted = [:json]
-
-        expect(TestApp::Actions::Articles::Index.config.formats.accepted).to eq [:json]
-      end
-    end
-
-    describe "subclass in slice" do
-      before do
-        with_directory(@dir) do
-          write "slices/admin/actions/articles/index.rb", <<~'RUBY'
-            module Admin
-              module Actions
-                module Articles
-                  class Index < TestApp::Action
-                  end
-                end
-              end
-            end
-          RUBY
-        end
-      end
-
-      it "applies default actions config from the app", :aggregate_failures do
-        prepare_app
-
-        expect(Admin::Actions::Articles::Index.config.formats.accepted).to eq []
-      end
-
-      it "applies actions config from the app" do
-        Hanami.app.config.actions.formats.accepted = [:json]
-
-        prepare_app
-
-        expect(Admin::Actions::Articles::Index.config.formats.accepted).to eq [:json]
-      end
-
-      it "applies config from the base class" do
-        prepare_app
-
-        TestApp::Action.config.formats.accepted = [:json]
-
-        expect(Admin::Actions::Articles::Index.config.formats.accepted).to eq [:json]
-      end
-    end
-  end
-
-  describe "inheriting from a slice-level base class, in turn inheriting from an app-level base class" do
-    before do
-      with_directory(@dir) do
-        write "slices/admin/action.rb", <<~'RUBY'
-          module Admin
-            class Action < TestApp::Action
-            end
-          end
-        RUBY
-      end
-    end
-
-    describe "slice-level base class" do
-      it "applies default actions config from the app", :aggregate_failures do
-        prepare_app
-
-        expect(Admin::Action.config.formats.accepted).to eq []
-      end
-
-      it "applies actions config from the app" do
-        Hanami.app.config.actions.formats.accepted = [:json]
-
-        prepare_app
-
-        expect(Admin::Action.config.formats.accepted).to eq [:json]
-      end
-
-      it "applies config from the app base class" do
-        prepare_app
-
-        TestApp::Action.config.formats.accepted = [:json]
-
-        expect(Admin::Action.config.formats.accepted).to eq [:json]
-      end
-
-      context "slice actions config present" do
-        before do
-          with_directory(@dir) do
-            write "config/slices/admin.rb", <<~'RUBY'
-              module Admin
-                class Slice < Hanami::Slice
-                  config.actions.format :csv
-                end
-              end
-            RUBY
-          end
-        end
-
-        it "applies actions config from the slice" do
-          prepare_app
-
-          expect(Admin::Action.config.formats.accepted).to eq [:csv]
-        end
-
-        it "prefers actions config from the slice over config from the app-level base class" do
-          prepare_app
-
-          TestApp::Action.config.formats.accepted = [:json]
-
-          expect(Admin::Action.config.formats.accepted).to eq [:csv]
-        end
-
-        it "prefers config from the base class over actions config from the slice" do
-          prepare_app
-
-          TestApp::Action.config.formats.accepted = [:csv]
-          Admin::Action.config.formats.accepted = [:json]
-
-          expect(Admin::Action.config.formats.accepted).to eq [:json]
-        end
-      end
-    end
-
-    describe "subclass in slice" do
-      before do
-        with_directory(@dir) do
-          write "slices/admin/actions/articles/index.rb", <<~'RUBY'
-            module Admin
-              module Actions
-                module Articles
-                  class Index < Admin::Action
-                  end
-                end
-              end
-            end
-          RUBY
-        end
-      end
-
-      it "applies default actions config from the app", :aggregate_failures do
-        prepare_app
-
-        expect(Admin::Actions::Articles::Index.config.formats.accepted).to eq []
-      end
-
-      it "applies actions config from the app" do
-        Hanami.app.config.actions.formats.accepted = [:json]
-
-        prepare_app
-
-        expect(Admin::Actions::Articles::Index.config.formats.accepted).to eq [:json]
-      end
-
-      it "applies actions config from the slice" do
-        with_directory(@dir) do
-          write "config/slices/admin.rb", <<~'RUBY'
-            module Admin
-              class Slice < Hanami::Slice
-                config.actions.formats.accepted = [:json]
-              end
-            end
-          RUBY
-        end
-
-        prepare_app
-
-        expect(Admin::Actions::Articles::Index.config.formats.accepted).to eq [:json]
-      end
-
-      it "applies config from the slice base class" do
-        prepare_app
-
-        Admin::Action.config.formats.accepted = [:json]
-
-        expect(Admin::Actions::Articles::Index.config.formats.accepted).to eq [:json]
-      end
-
-      it "prefers config from the slice base class over actions config from the slice" do
-        with_directory(@dir) do
-          write "config/slices/admin.rb", <<~'RUBY'
-            module Admin
-              class Slice < Hanami::Slice
-                config.actions.format :csv
-              end
-            end
-          RUBY
-        end
-
-        prepare_app
-
-        Admin::Action.config.formats.accepted = [:json]
-
-        expect(Admin::Actions::Articles::Index.config.formats.accepted).to eq [:json]
-      end
-    end
-  end
-end

data/spec/integration/action/view_rendering/automatic_rendering_spec.rb

@@ -1,247 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe "App action / View rendering / Automatic rendering", :app_integration do
-  it "Renders a view automatically, passing all params and exposures" do
-    within_app do
-      write "app/actions/profile/show.rb", <<~RUBY
-        module TestApp
-          module Actions
-            module Profile
-              class Show < TestApp::Action
-                def handle(req, res)
-                  res[:favorite_number] = 123
-                end
-              end
-            end
-          end
-        end
-      RUBY
-
-      write "app/views/profile/show.rb", <<~RUBY
-        module TestApp
-          module Views
-            module Profile
-              class Show < TestApp::View
-                expose :name, :favorite_number
-              end
-            end
-          end
-        end
-      RUBY
-
-      write "app/templates/profile/show.html.slim", <<~'SLIM'
-        h1 Hello, #{name}. Your favorite number is #{favorite_number}, right?
-      SLIM
-
-      require "hanami/prepare"
-
-      action = TestApp::App["actions.profile.show"]
-      response = action.(name: "Jennifer")
-      rendered = response.body[0]
-
-      expect(rendered).to eq "<html><body><h1>Hello, Jennifer. Your favorite number is 123, right?</h1></body></html>"
-      expect(response.status).to eq 200
-    end
-  end
-
-  it "Does not render a view automatically when #render? returns false " do
-    within_app do
-      write "app/actions/profile/show.rb", <<~RUBY
-        module TestApp
-          module Actions
-            module Profile
-              class Show < TestApp::Action
-                def handle(req, res)
-                  res[:favorite_number] = 123
-                end
-
-                def auto_render?(_res)
-                  false
-                end
-              end
-            end
-          end
-        end
-      RUBY
-
-      write "app/views/profile/show.rb", <<~RUBY
-        module TestApp
-          module Views
-            module Profile
-              class Show < TestApp::View
-                expose :name, :favorite_number
-              end
-            end
-          end
-        end
-      RUBY
-
-      write "app/templates/profile/show.html.slim", <<~'SLIM'
-        h1 Hello, #{name}. Your favorite number is #{favorite_number}, right?
-      SLIM
-
-      require "hanami/prepare"
-
-      action = TestApp::App["actions.profile.show"]
-      response = action.(name: "Jennifer")
-
-      expect(response.body).to eq []
-      expect(response.status).to eq 200
-    end
-  end
-
-  it "Doesn't render view automatically when body is already assigned" do
-    within_app do
-      write "app/actions/profile/show.rb", <<~RUBY
-        module TestApp
-          module Actions
-            module Profile
-              class Show < TestApp::Action
-                def handle(req, res)
-                  res.body = "200: Okay okay okay"
-                end
-              end
-            end
-          end
-        end
-      RUBY
-
-      write "app/views/profile/show.rb", <<~RUBY
-        module TestApp
-          module Views
-            module Profile
-              class Show < TestApp::View
-                expose :name, :favorite_number
-              end
-            end
-          end
-        end
-      RUBY
-
-      write "app/templates/profile/show.html.slim", <<~'SLIM'
-        h1 Hello, #{name}. Your favorite number is #{favorite_number}, right?
-      SLIM
-
-      require "hanami/prepare"
-
-      action = TestApp::App["actions.profile.show"]
-      response = action.(name: "Jennifer")
-      rendered = response.body[0]
-
-      expect(rendered).to eq "200: Okay okay okay"
-      expect(response.status).to eq 200
-    end
-  end
-
-  it "Doesn't render view automatically when halt is called" do
-    within_app do
-      write "app/actions/profile/show.rb", <<~RUBY
-        module TestApp
-          module Actions
-            module Profile
-              class Show < TestApp::Action
-                def handle(req, res)
-                  halt 404
-                end
-              end
-            end
-          end
-        end
-      RUBY
-
-      write "app/views/profile/show.rb", <<~RUBY
-        module TestApp
-          module Views
-            module Profile
-              class Show < TestApp::View
-                expose :name
-              end
-            end
-          end
-        end
-      RUBY
-
-      # This template will crash if not rendered with a valid `name` string. The absence
-      # of a crash here tells us that the view was never rendered.
-      write "app/templates/profile/show.html.slim", <<~'SLIM'
-        h1 Hello, #{name.to_str}!
-      SLIM
-
-      require "hanami/prepare"
-
-      # Call the action without a `name` param, thereby ensuring the view will raise an
-      # error if rendered
-      action = TestApp::App["actions.profile.show"]
-      response = action.({})
-      rendered = response.body[0]
-
-      aggregate_failures do
-        expect(rendered).to eq "Not Found"
-        expect(response.status).to eq 404
-      end
-    end
-  end
-
-  it "Does not render if no view is available" do
-    within_app do
-      write "app/actions/profile/show.rb", <<~RUBY
-        module TestApp
-          module Actions
-            module Profile
-              class Show < TestApp::Action
-              end
-            end
-          end
-        end
-      RUBY
-
-      require "hanami/prepare"
-
-      action = TestApp::App["actions.profile.show"]
-      response = action.({})
-      expect(response.body).to eq []
-      expect(response.status).to eq 200
-    end
-  end
-
-  def within_app
-    with_tmp_directory(Dir.mktmpdir) do
-      write "config/app.rb", <<~RUBY
-        require "hanami"
-
-        module TestApp
-          class App < Hanami::App
-          end
-        end
-      RUBY
-
-      write "app/action.rb", <<~RUBY
-        # auto_register: false
-
-        module TestApp
-          class Action < Hanami::Action
-          end
-        end
-      RUBY
-
-      write "app/view.rb", <<~RUBY
-        # auto_register: false
-
-        require "hanami/view"
-
-        module TestApp
-          class View < Hanami::View
-          end
-        end
-      RUBY
-
-      write "app/templates/layouts/app.html.slim", <<~SLIM
-        html
-          body
-            == yield
-      SLIM
-
-      yield
-    end
-  end
-end

data/spec/integration/action/view_rendering/paired_view_inference_spec.rb

@@ -1,115 +0,0 @@
-# frozen_string_literal: true
-
-require "hanami"
-
-RSpec.describe "App action / View rendering / Paired view inference", :app_integration do
-  before do
-    module TestApp
-      class App < Hanami::App
-      end
-    end
-
-    Hanami.app.prepare
-
-    module TestApp
-      class Action < Hanami::Action
-      end
-    end
-  end
-
-  let(:action) { action_class.new }
-
-  describe "Ordinary action" do
-    before do
-      module TestApp
-        module Actions
-          module Articles
-            class Index < TestApp::Action
-            end
-          end
-        end
-      end
-    end
-
-    let(:action_class) { TestApp::Actions::Articles::Index }
-
-    context "Paired view exists" do
-      before do
-        TestApp::App.register "views.articles.index", view
-      end
-
-      let(:view) { double(:view) }
-
-      it "auto-injects a paired view from a matching container identifier" do
-        expect(action.view).to be view
-      end
-
-      context "Another view explicitly auto-injected" do
-        before do
-          module TestApp
-            module Actions
-              module Articles
-                class Index < TestApp::Action
-                  include Deps[view: "views.articles.custom"]
-                end
-              end
-            end
-          end
-
-          TestApp::App.register "views.articles.custom", explicit_view
-        end
-
-        let(:action_class) { TestApp::Actions::Articles::Index }
-        let(:explicit_view) { double(:explicit_view) }
-
-        it "respects the explicitly auto-injected view" do
-          expect(action.view).to be explicit_view
-        end
-      end
-    end
-
-    context "No paired view exists" do
-      it "does not auto-inject any view" do
-        expect(action.view).to be_nil
-      end
-    end
-  end
-
-  describe "RESTful action" do
-    before do
-      module TestApp
-        module Actions
-          module Articles
-            class Create < TestApp::Action
-            end
-          end
-        end
-      end
-    end
-
-    let(:action_class) { TestApp::Actions::Articles::Create }
-    let(:direct_paired_view) { double(:direct_paired_view) }
-    let(:alternative_paired_view) { double(:alternative_paired_view) }
-
-    context "Direct paired view exists" do
-      before do
-        TestApp::App.register "views.articles.create", direct_paired_view
-        TestApp::App.register "views.articles.new", alternative_paired_view
-      end
-
-      it "auto-injects the directly paired view" do
-        expect(action.view).to be direct_paired_view
-      end
-    end
-
-    context "Alternative paired view exists" do
-      before do
-        TestApp::App.register "views.articles.new", alternative_paired_view
-      end
-
-      it "auto-injects the alternative paired view" do
-        expect(action.view).to be alternative_paired_view
-      end
-    end
-  end
-end