hanami 2.3.2 → 3.0.0.rc1

data/spec/integration/assets/serve_static_assets_spec.rb

@@ -1,152 +0,0 @@
-# frozen_string_literal: true
-
-require "rack/test"
-require "stringio"
-
-RSpec.describe "Serve Static Assets", :app_integration do
-  include Rack::Test::Methods
-  let(:app) { Hanami.app }
-  let(:root) { make_tmp_directory }
-  let!(:env) { ENV.to_h }
-
-  before do
-    with_directory(root) do
-      write "config/app.rb", <<~RUBY
-        module TestApp
-          class App < Hanami::App
-            config.logger.stream = StringIO.new
-          end
-        end
-      RUBY
-
-      write "config/routes.rb", <<~RUBY
-        module TestApp
-          class Routes < Hanami::Routes
-            root to: ->(env) { [200, {}, ["Hello from root"]] }
-          end
-        end
-      RUBY
-
-      write "public/assets/app.js", <<~JS
-        console.log("Hello from app.js");
-      JS
-    end
-  end
-
-  after do
-    ENV.replace(env)
-  end
-
-  context "with default configuration" do
-    before do
-      with_directory(root) do
-        require "hanami/prepare"
-      end
-    end
-
-    it "serves static assets" do
-      get "/assets/app.js"
-
-      expect(last_response.status).to eq(200)
-      expect(last_response.body).to match(/Hello/)
-    end
-
-    it "returns 404 for missing asset" do
-      get "/assets/missing.js"
-
-      expect(last_response.status).to eq(404)
-      expect(last_response.body).to match(/Not Found/i)
-    end
-
-    it "doesn't escape from root directory" do
-      get "/assets/../../config/app.rb"
-
-      expect(last_response.status).to eq(404)
-      expect(last_response.body).to match("Hanami::Router::NotFoundError")
-    end
-  end
-
-  context "when configuration is set to false" do
-    before do
-      with_directory(root) do
-        write "config/app.rb", <<~RUBY
-          module TestApp
-            class App < Hanami::App
-              config.logger.stream = StringIO.new
-              config.assets.serve = false
-            end
-          end
-        RUBY
-
-        require "hanami/boot"
-      end
-    end
-
-    it "doesn't serve static assets" do
-      get "/assets/app.js"
-
-      expect(last_response.status).to eq(404)
-    end
-  end
-
-  context "when env var is set to true" do
-    before do
-      with_directory(root) do
-        ENV["HANAMI_SERVE_ASSETS"] = "true"
-        require "hanami/boot"
-      end
-    end
-
-    it "serves static assets" do
-      get "/assets/app.js"
-
-      expect(last_response.status).to eq(200)
-    end
-  end
-
-  context "when env var is set to false" do
-    before do
-      with_directory(root) do
-        ENV["HANAMI_SERVE_ASSETS"] = "false"
-        require "hanami/boot"
-      end
-    end
-
-    it "doesn't serve static assets" do
-      get "/assets/app.js"
-
-      expect(last_response.status).to eq(404)
-    end
-  end
-
-  context "when Hanami.env is not :development or :test" do
-    before do
-      with_directory(root) do
-        ENV["HANAMI_ENV"] = "production"
-        require "hanami/boot"
-      end
-    end
-
-    it "doesn't serve static assets" do
-      get "/assets/app.js"
-
-      expect(last_response.status).to eq(404)
-    end
-  end
-
-  context "when Hanami.env is not :development or :test, but env var is set to true" do
-    before do
-      with_directory(root) do
-        ENV["HANAMI_ENV"] = "production"
-        ENV["HANAMI_SERVE_ASSETS"] = "true"
-        require "hanami/boot"
-      end
-    end
-
-    it "serves static assets" do
-      get "/assets/app.js"
-
-      expect(last_response.status).to eq(200)
-    end
-  end
-end

data/spec/integration/code_loading/loading_from_app_spec.rb

@@ -1,152 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe "Code loading / Loading from app directory", :app_integration do
-  before :context do
-    with_directory(@dir = make_tmp_directory) do
-      write "config/app.rb", <<~'RUBY'
-        require "hanami"
-
-        module TestApp
-          class App < Hanami::App
-          end
-        end
-      RUBY
-
-      write "app/test_class.rb", <<~'RUBY'
-        module TestApp
-          class TestClass
-          end
-        end
-      RUBY
-
-      write "app/action.rb", <<~'RUBY'
-        # auto_register: false
-
-        module TestApp
-          class Action < Hanami::Action
-          end
-        end
-      RUBY
-
-      write "app/actions/home/show.rb", <<~'RUBY'
-        module TestApp
-          module Actions
-            module Home
-              class Show < TestApp::Action
-              end
-            end
-          end
-        end
-      RUBY
-    end
-  end
-
-  before do
-    with_directory(@dir) do
-      require "hanami/prepare"
-    end
-  end
-
-  specify "Classes in app/ directory are autoloaded with the app namespace" do
-    expect(TestApp::TestClass).to be
-    expect(TestApp::Action).to be
-    expect(TestApp::Actions::Home::Show).to be
-  end
-
-  specify "Classes in app directory are auto-registered" do
-    expect(TestApp::App["test_class"]).to be_an_instance_of TestApp::TestClass
-    expect(TestApp::App["actions.home.show"]).to be_an_instance_of TestApp::Actions::Home::Show
-
-    # Files with "auto_register: false" magic comments are not auto-registered
-    expect(TestApp::App.key?("action")).to be false
-  end
-
-  describe "app/lib/ directory" do
-    before :context do
-      with_directory(@dir = make_tmp_directory) do
-        write "config/app.rb", <<~'RUBY'
-          require "hanami"
-
-          module TestApp
-            class App < Hanami::App
-            end
-          end
-        RUBY
-
-        write "app/lib/test_class.rb", <<~'RUBY'
-          module TestApp
-            class TestClass
-            end
-          end
-        RUBY
-      end
-    end
-
-    specify "Classes in app/lib/ directory are autoloaded with the app namespace" do
-      expect(TestApp::TestClass).to be
-    end
-
-    specify "Classes in app/lib/ directory are auto-registered" do
-      expect(TestApp::App["test_class"]).to be_an_instance_of TestApp::TestClass
-    end
-
-    specify "Classes in app/lib/ directory are not redundantly auto-registered under 'lib' key namespace" do
-      expect(TestApp::App.key?("lib.test_class")).to be false
-    end
-  end
-
-  # rubocop:disable Style/GlobalVars
-  describe "same-named class defined in both app/ and app/lib/ directories" do
-    before :context do
-      with_directory(@dir = make_tmp_directory) do
-        write "config/app.rb", <<~'RUBY'
-          require "hanami"
-
-          module TestApp
-            class App < Hanami::App
-            end
-          end
-        RUBY
-
-        write "app/test_class.rb", <<~'RUBY'
-          $app_class_loaded = true
-
-          module TestApp
-            class TestClass
-              (@loaded_from ||= []) << "app"
-            end
-          end
-        RUBY
-
-        write "app/lib/test_class.rb", <<~'RUBY'
-          $app_lib_class_loaded = true
-
-          module TestApp
-            class TestClass
-              (@loaded_from ||= []) << "app/lib"
-            end
-          end
-        RUBY
-      end
-    end
-
-    after do
-      $app_class_loaded = $app_lib_class_loaded = nil
-    end
-
-    specify "Classes in app/lib/ directory are preferred for autoloading" do
-      expect(TestApp::TestClass).to be
-      expect(TestApp::TestClass.instance_variable_get(:@loaded_from)).to eq ["app/lib"]
-      expect($app_lib_class_loaded).to be true
-      expect($app_class_loaded).to be nil
-    end
-
-    specify "Classes in app/lib/ directory are preferred for auto-registration" do
-      expect(TestApp::App["test_class"]).to be
-      expect(TestApp::TestClass.instance_variable_get(:@loaded_from)).to eq ["app/lib"]
-      expect($app_lib_class_loaded).to be true
-      expect($app_class_loaded).to be nil
-    end
-  end
-  # rubocop:enable Style/GlobalVars
-end

data/spec/integration/code_loading/loading_from_lib_spec.rb

@@ -1,242 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe "Code loading / Loading from lib directory", :app_integration do
-  describe "default root" do
-    before :context do
-      with_directory(@dir = make_tmp_directory.realpath) do
-        write "config/app.rb", <<~'RUBY'
-          require "hanami"
-
-          module TestApp
-            class App < Hanami::App
-            end
-          end
-        RUBY
-
-        write "lib/external_class.rb", <<~'RUBY'
-          class ExternalClass
-          end
-        RUBY
-
-        write "lib/test_app/test_class.rb", <<~'RUBY'
-          module TestApp
-            class TestClass
-            end
-          end
-        RUBY
-      end
-    end
-
-    context "setup app" do
-      before do
-        with_directory(@dir) { require "hanami/setup" }
-      end
-
-      it "adds the lib directory to the load path" do
-        expect($LOAD_PATH).to include(@dir.join("lib").to_s)
-      end
-
-      specify "classes in lib/ can be required directly" do
-        expect(require("external_class")).to be true
-        expect(ExternalClass).to be
-      end
-
-      specify "classes in lib/[app_namespace]/ cannot yet be autoloaded" do
-        expect { TestApp::TestClass }.to raise_error(NameError)
-      end
-    end
-
-    context "prepared app" do
-      before do
-        with_directory(@dir) { require "hanami/prepare" }
-      end
-
-      it "leaves the lib directory already in the load path" do
-        expect($LOAD_PATH).to include(@dir.join("lib").to_s).exactly(1).times
-      end
-
-      specify "classes in lib/[app_namespace]/ can be autoloaded" do
-        expect(TestApp::TestClass).to be
-      end
-    end
-
-    context "lib dir missing" do
-      before do
-        with_directory(@dir = make_tmp_directory.realpath) do
-          write "config/app.rb", <<~'RUBY'
-            require "hanami"
-
-            module TestApp
-              class App < Hanami::App
-              end
-            end
-          RUBY
-
-          require "hanami/setup"
-        end
-      end
-
-      it "does not add the lib directory to the load path" do
-        expect($LOAD_PATH).not_to include(@dir.join("lib").to_s)
-      end
-    end
-  end
-
-  describe "default root with requires at top of app file" do
-    before :context do
-      with_directory(@dir = make_tmp_directory.realpath) do
-        write "config/app.rb", <<~'RUBY'
-          require "hanami"
-          require "external_class"
-
-          module TestApp
-            class App < Hanami::App
-              @class_from_lib = ExternalClass
-
-              def self.class_from_lib
-                @class_from_lib
-              end
-            end
-          end
-        RUBY
-
-        write "lib/external_class.rb", <<~'RUBY'
-          class ExternalClass
-          end
-        RUBY
-      end
-    end
-
-    before do
-      with_directory(@dir) { require "hanami/setup" }
-    end
-
-    specify "classes in lib/ can be required directly from the top of the app file" do
-      expect(Hanami.app.class_from_lib).to be ExternalClass
-    end
-  end
-
-  context "app root reconfigured" do
-    before :context do
-      with_directory(@dir = make_tmp_directory.realpath) do
-        write "config/app.rb", <<~'RUBY'
-          require "hanami"
-
-          module TestApp
-            class App < Hanami::App
-              config.root = Pathname(__dir__).join("..", "src").realpath
-            end
-          end
-        RUBY
-
-        write "src/lib/external_class.rb", <<~'RUBY'
-          class ExternalClass
-          end
-        RUBY
-
-        write "src/lib/test_app/test_class.rb", <<~'RUBY'
-          module TestApp
-            class TestClass
-            end
-          end
-        RUBY
-      end
-    end
-
-    context "setup app" do
-      before do
-        with_directory(@dir) { require "hanami/setup" }
-      end
-
-      it "does not add the lib directory to the load path (already done at time of subclassing)" do
-        expect($LOAD_PATH).not_to include(@dir.join("src", "lib").to_s)
-      end
-
-      it "adds the lib directory under the new root with `prepare_load_path`" do
-        expect { Hanami.app.prepare_load_path }
-          .to change { $LOAD_PATH }
-          .to include(@dir.join("src", "lib").to_s)
-      end
-    end
-
-    context "prepared app" do
-      before do
-        with_directory(@dir) { require "hanami/prepare" }
-      end
-
-      it "adds the lib directory to the load path" do
-        expect($LOAD_PATH).to include(@dir.join("src", "lib").to_s)
-      end
-
-      specify "classes in lib/ can be required directly" do
-        expect(require("external_class")).to be true
-        expect(ExternalClass).to be
-      end
-
-      specify "classes in lib/[app_namespace]/ can be autoloaded" do
-        expect(TestApp::TestClass).to be
-      end
-    end
-  end
-
-  context "app root reconfigured and load path immediately prepared" do
-    before :context do
-      with_directory(@dir = make_tmp_directory.realpath) do
-        write "config/app.rb", <<~'RUBY'
-          require "hanami"
-
-          module TestApp
-            class App < Hanami::App
-              config.root = Pathname(__dir__).join("..", "src").realpath and prepare_load_path
-            end
-          end
-        RUBY
-
-        write "src/lib/external_class.rb", <<~'RUBY'
-          class ExternalClass
-          end
-        RUBY
-
-        write "src/lib/test_app/test_class.rb", <<~'RUBY'
-          module TestApp
-            class TestClass
-            end
-          end
-        RUBY
-      end
-    end
-
-    context "setup app" do
-      before do
-        with_directory(@dir) { require "hanami/setup" }
-      end
-
-      it "adds the lib directory to the load path" do
-        expect($LOAD_PATH).to include(@dir.join("src", "lib").to_s)
-      end
-
-      specify "classes in lib/ can be required directly" do
-        expect(require("external_class")).to be true
-        expect(ExternalClass).to be
-      end
-
-      specify "classes in lib/[app_namespace]/ cannot yet be autoloaded" do
-        expect { TestApp::TestClass }.to raise_error(NameError)
-      end
-    end
-
-    context "prepared app" do
-      before do
-        with_directory(@dir) { require "hanami/prepare" }
-      end
-
-      it "leaves the lib directory to the load path" do
-        expect($LOAD_PATH).to include(@dir.join("src", "lib").to_s).exactly(1).times
-      end
-
-      specify "classes in lib/[app_namespace]/ can be autoloaded" do
-        expect(TestApp::TestClass).to be
-      end
-    end
-  end
-end

data/spec/integration/code_loading/loading_from_slice_spec.rb

@@ -1,165 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe "Code loading / Loading from slice directory", :app_integration do
-  before :context do
-    with_directory(@dir = make_tmp_directory) do
-      write "config/app.rb", <<~'RUBY'
-        require "hanami"
-
-        module TestApp
-          class App < Hanami::App
-          end
-        end
-      RUBY
-
-      write "slices/main/config/not_loadable.rb", <<~'RUBY'
-        raise "This file should never be loaded"
-      RUBY
-
-      write "slices/main/test_class.rb", <<~'RUBY'
-        module Main
-          class TestClass
-          end
-        end
-      RUBY
-
-      write "slices/main/action.rb", <<~'RUBY'
-        # auto_register: false
-
-        module Main
-          class Action < Hanami::Action
-          end
-        end
-      RUBY
-
-      write "slices/main/actions/home/show.rb", <<~'RUBY'
-        module Main
-          module Actions
-            module Home
-              class Show < Main::Action
-              end
-            end
-          end
-        end
-      RUBY
-    end
-  end
-
-  before do
-    with_directory(@dir) do
-      require "hanami/prepare"
-    end
-  end
-
-  specify "Classes in slice directory are autoloaded with the slice namespace" do
-    expect(Main::TestClass).to be
-    expect(Main::Action).to be
-    expect(Main::Actions::Home::Show).to be
-  end
-
-  specify "Files in slice config/ directory are not autoloaded" do
-    expect { Main::NotLoadable }.to raise_error NameError
-    expect { Main::Config::NotLoadable }.to raise_error NameError
-  end
-
-  specify "Classes in slice directory are auto-registered" do
-    expect(Main::Slice["test_class"]).to be_an_instance_of Main::TestClass
-    expect(Main::Slice["actions.home.show"]).to be_an_instance_of Main::Actions::Home::Show
-
-    # Files with "auto_register: false" magic comments are not auto-registered
-    expect(Main::Slice.key?("action")).to be false
-  end
-
-  specify "Files in slice config/ directory are not auto-registered" do
-    expect(Main::Slice.key?("config.settings")).to be false
-  end
-
-  describe "slice lib/ directory" do
-    before :context do
-      with_directory(@dir = make_tmp_directory) do
-        write "config/app.rb", <<~'RUBY'
-          require "hanami"
-
-          module TestApp
-            class App < Hanami::App
-            end
-          end
-        RUBY
-
-        write "slices/main/lib/test_class.rb", <<~'RUBY'
-          module Main
-            class TestClass
-            end
-          end
-        RUBY
-      end
-    end
-
-    specify "Classes in slice lib/ directory are autoloaded with the slice namespace" do
-      expect(Main::TestClass).to be
-    end
-
-    specify "Classes in slice lib/ directory are auto-registered" do
-      expect(Main::Slice["test_class"]).to be_an_instance_of Main::TestClass
-    end
-
-    specify "Classes in slice lib/ directory are not redundantly auto-registered under 'lib' key namespace" do
-      expect(Main::Slice.key?("lib.test_class")).to be false
-    end
-  end
-
-  # rubocop:disable Style/GlobalVars
-  describe "same-named class defined in both slice and lib/ directories" do
-    before :context do
-      with_directory(@dir = make_tmp_directory) do
-        write "config/app.rb", <<~'RUBY'
-          require "hanami"
-
-          module TestApp
-            class App < Hanami::App
-            end
-          end
-        RUBY
-
-        write "slices/main/test_class.rb", <<~'RUBY'
-          $slice_class_loaded = true
-
-          module Main
-            class TestClass
-              (@loaded_from ||= []) << "slice"
-            end
-          end
-        RUBY
-
-        write "slices/main/lib/test_class.rb", <<~'RUBY'
-          $slice_lib_class_loaded = true
-
-          module Main
-            class TestClass
-              (@loaded_from ||= []) << "slice/lib"
-            end
-          end
-        RUBY
-      end
-    end
-
-    after do
-      $slice_class_loaded = $slice_lib_class_loaded = nil
-    end
-
-    specify "Classes in slice lib/ directory are preferred for autoloading" do
-      expect(Main::TestClass).to be
-      expect(Main::TestClass.instance_variable_get(:@loaded_from)).to eq ["slice/lib"]
-      expect($slice_lib_class_loaded).to be true
-      expect($slice_class_loaded).to be nil
-    end
-
-    specify "Classes in slice lib/ directory are preferred for auto-registration" do
-      expect(Main::Slice["test_class"]).to be
-      expect(Main::TestClass.instance_variable_get(:@loaded_from)).to eq ["slice/lib"]
-      expect($slice_lib_class_loaded).to be true
-      expect($slice_class_loaded).to be nil
-    end
-  end
-  # rubocop:enable Style/GlobalVars
-end