hanami 2.0.3 → 2.1.0.beta1

data/spec/integration/view/helpers/part_helpers_spec.rb

@@ -0,0 +1,124 @@
+# frozen_string_literal: true
+
+require "ostruct"
+
+# rubocop:disable Style/OpenStructUse
+
+RSpec.describe "App view / Helpers / Part helpers", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view and parts" do
+    def before_prepare
+      write "app/views/posts/show.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Show < TestApp::View
+                expose :post
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/views/parts/post.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Parts
+              class Post < TestApp::Views::Part
+                def number
+                  format_number(value.number)
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/show.html.erb", <<~ERB
+        <h1><%= post.number %></h1>
+      ERB
+    end
+
+    it "makes default helpers available in parts" do
+      post = OpenStruct.new(number: 12_345)
+      output = TestApp::App["views.posts.show"].call(post: post).to_s.strip
+
+      expect(output).to eq "<h1>12,345</h1>"
+    end
+  end
+
+  describe "slice view and parts" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+
+      write "slices/main/views/posts/show.rb", <<~RUBY
+        module Main
+          module Views
+            module Posts
+              class Show < Main::View
+                expose :post
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/views/parts/post.rb", <<~RUBY
+        module Main
+          module Views
+            module Parts
+              class Post < Main::Views::Part
+                def number
+                  format_number(value.number)
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/templates/posts/show.html.erb", <<~ERB
+        <h1><%= post.number %></h1>
+      ERB
+    end
+
+    it "makes default helpers available in parts" do
+      post = OpenStruct.new(number: 12_345)
+      output = Main::Slice["views.posts.show"].call(post: post).to_s.strip
+
+      expect(output).to eq "<h1>12,345</h1>"
+    end
+  end
+end
+
+# rubocop:enable Style/OpenStructUse

data/spec/integration/view/helpers/scope_helpers_spec.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+RSpec.describe "App view / Helpers / Scope helpers", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view" do
+    def before_prepare
+      write "app/views/posts/show.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Show < TestApp::View
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/show.html.erb", <<~ERB
+        <h1><%= format_number(12_345) %></h1>
+      ERB
+    end
+
+    it "makes default helpers available in templates" do
+      output = TestApp::App["views.posts.show"].call.to_s.strip
+      expect(output).to eq "<h1>12,345</h1>"
+    end
+  end
+
+  describe "slice view" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+
+      write "slices/main/views/posts/show.rb", <<~RUBY
+        module Main
+          module Views
+            module Posts
+              class Show < Main::View
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/templates/posts/show.html.erb", <<~ERB
+        <h1><%= format_number(12_345) %></h1>
+      ERB
+    end
+
+    it "makes default helpers available in templates" do
+      output = Main::Slice["views.posts.show"].call.to_s.strip
+      expect(output).to eq "<h1>12,345</h1>"
+    end
+  end
+end

data/spec/integration/view/helpers/user_defined_helpers/part_helpers_spec.rb

@@ -0,0 +1,162 @@
+# frozen_string_literal: true
+
+require "ostruct"
+
+# rubocop:disable Style/OpenStructUse
+
+RSpec.describe "App view / Helpers / User-defined helpers / Scope helpers", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      write "app/views/helpers.rb", <<~'RUBY'
+        # auto_register: false
+
+        module TestApp
+          module Views
+            module Helpers
+              def exclaim_from_app(str)
+                tag.h1("#{str}! (app helper)")
+              end
+            end
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view and parts" do
+    def before_prepare
+      write "app/views/posts/show.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Show < TestApp::View
+                expose :post
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/views/parts/post.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Parts
+              class Post < TestApp::Views::Part
+                def title
+                  exclaim_from_app(value.title)
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/show.html.erb", <<~ERB
+        <%= post.title %>
+      ERB
+    end
+
+    it "makes user-defined helpers available in parts" do
+      post = OpenStruct.new(title: "Hello world")
+      output = TestApp::App["views.posts.show"].call(post: post).to_s.strip
+
+      expect(output).to eq "<h1>Hello world! (app helper)</h1>"
+    end
+  end
+
+  describe "slice view and parts" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        module Main
+          class View < TestApp::View
+            # FIXME: base slice views should override paths from the base app view
+            config.paths = [File.join(File.expand_path(__dir__), "templates")]
+          end
+        end
+      RUBY
+
+      write "slices/main/views/helpers.rb", <<~'RUBY'
+        # auto_register: false
+
+        module Main
+          module Views
+            module Helpers
+              def exclaim_from_slice(str)
+                tag.h1("#{str}! (slice helper)")
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/views/posts/show.rb", <<~RUBY
+        module Main
+          module Views
+            module Posts
+              class Show < Main::View
+                expose :post
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/views/parts/post.rb", <<~RUBY
+        module Main
+          module Views
+            module Parts
+              class Post < Main::Views::Part
+                def title
+                  exclaim_from_slice(value.title)
+                end
+
+                def title_from_app
+                  exclaim_from_app(value.title)
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/templates/posts/show.html.erb", <<~ERB
+        <%= post.title %>
+        <%= post.title_from_app %>
+      ERB
+    end
+
+    it "makes user-defined helpers (from app as well as slice) available in parts" do
+      post = OpenStruct.new(title: "Hello world")
+      output = Main::Slice["views.posts.show"].call(post: post).to_s
+
+      expect(output).to eq <<~HTML
+        <h1>Hello world! (slice helper)</h1>
+        <h1>Hello world! (app helper)</h1>
+      HTML
+    end
+  end
+end
+
+# rubocop:enable Style/OpenStructUse

data/spec/integration/view/helpers/user_defined_helpers/scope_helpers_spec.rb

@@ -0,0 +1,119 @@
+# frozen_string_literal: true
+
+RSpec.describe "App view / Helpers / User-defined helpers / Scope helpers", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      write "app/views/helpers.rb", <<~'RUBY'
+        # auto_register: false
+
+        module TestApp
+          module Views
+            module Helpers
+              def exclaim_from_app(str)
+                tag.h1("#{str}! (app helper)")
+              end
+            end
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view" do
+    def before_prepare
+      write "app/views/posts/show.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Show < TestApp::View
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/show.html.erb", <<~ERB
+        <%= exclaim_from_app("Hello world") %>
+      ERB
+    end
+
+    it "makes user-defined helpers available in templates" do
+      output = TestApp::App["views.posts.show"].call.to_s.strip
+      expect(output).to eq "<h1>Hello world! (app helper)</h1>"
+    end
+  end
+
+  describe "slice view" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        module Main
+          class View < TestApp::View
+            # FIXME: base slice views should override paths from the base app view
+            config.paths = [File.join(File.expand_path(__dir__), "templates")]
+          end
+        end
+      RUBY
+
+      write "slices/main/views/helpers.rb", <<~'RUBY'
+        # auto_register: false
+
+        module Main
+          module Views
+            module Helpers
+              def exclaim_from_slice(str)
+                tag.h1("#{str}! (slice helper)")
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/views/posts/show.rb", <<~RUBY
+        module Main
+          module Views
+            module Posts
+              class Show < Main::View
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/templates/posts/show.html.erb", <<~ERB
+        <%= exclaim_from_slice("Hello world") %>
+        <%= exclaim_from_app("Hello world") %>
+      ERB
+    end
+
+    it "makes user-defined helpers (from app as well as slice) available in templates" do
+      output = Main::Slice["views.posts.show"].call.to_s
+
+      expect(output).to eq <<~HTML
+        <h1>Hello world! (slice helper)</h1>
+        <h1>Hello world! (app helper)</h1>
+      HTML
+    end
+  end
+end

data/spec/integration/view/slice_configuration_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe "App view / Slice configuration", :app_integration do
   before do
     with_directory(@dir = make_tmp_directory) do
-      write "config/app.rb", <<~'RUBY'
+      write "config/app.rb", <<~RUBY
         require "hanami"
 
         module TestApp
@@ -12,7 +12,7 @@ RSpec.describe "App view / Slice configuration", :app_integration do
         end
       RUBY
 
-      write "app/view.rb", <<~'RUBY'
+      write "app/view.rb", <<~RUBY
         require "hanami/view"
 
         module TestApp
@@ -60,7 +60,7 @@ RSpec.describe "App view / Slice configuration", :app_integration do
     describe "subclass in app" do
       before do
         with_directory(@dir) do
-          write "app/views/articles/index.rb", <<~'RUBY'
+          write "app/views/articles/index.rb", <<~RUBY
             module TestApp
               module Views
                 module Articles
@@ -100,7 +100,7 @@ RSpec.describe "App view / Slice configuration", :app_integration do
     describe "subclass in slice" do
       before do
         with_directory(@dir) do
-          write "slices/admin/views/articles/index.rb", <<~'RUBY'
+          write "slices/admin/views/articles/index.rb", <<~RUBY
             module Admin
               module Views
                 module Articles
@@ -141,7 +141,7 @@ RSpec.describe "App view / Slice configuration", :app_integration do
   describe "inheriting from a slice-level base class, in turn inheriting from an app-level base class" do
     before do
       with_directory(@dir) do
-        write "slices/admin/view.rb", <<~'RUBY'
+        write "slices/admin/view.rb", <<~RUBY
           module Admin
             class View < TestApp::View
             end
@@ -177,7 +177,7 @@ RSpec.describe "App view / Slice configuration", :app_integration do
       context "slice views config present" do
         before do
           with_directory(@dir) do
-            write "config/slices/admin.rb", <<~'RUBY'
+            write "config/slices/admin.rb", <<~RUBY
               module Admin
                 class Slice < Hanami::Slice
                   config.views.layout = "slice_layout"
@@ -215,7 +215,7 @@ RSpec.describe "App view / Slice configuration", :app_integration do
     describe "subclass in slice" do
       before do
         with_directory(@dir) do
-          write "slices/admin/views/articles/index.rb", <<~'RUBY'
+          write "slices/admin/views/articles/index.rb", <<~RUBY
             module Admin
               module Views
                 module Articles
@@ -245,7 +245,7 @@ RSpec.describe "App view / Slice configuration", :app_integration do
 
       it "applies views config from the slice" do
         with_directory(@dir) do
-          write "config/slices/admin.rb", <<~'RUBY'
+          write "config/slices/admin.rb", <<~RUBY
             module Admin
               class Slice < Hanami::Slice
                 config.views.layout = "slice_layout"
@@ -269,7 +269,7 @@ RSpec.describe "App view / Slice configuration", :app_integration do
 
       it "prefers config from the slice base class over views config from the slice" do
         with_directory(@dir) do
-          write "config/slices/admin.rb", <<~'RUBY'
+          write "config/slices/admin.rb", <<~RUBY
             module Admin
               class Slice < Hanami::Slice
                 config.views.layout = "slice_layout"

data/spec/integration/web/render_detailed_errors_spec.rb

@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+
+require "json"
+require "rack/test"
+
+RSpec.describe "Web / Rendering detailed errors", :app_integration do
+  include Rack::Test::Methods
+
+  let(:app) { Hanami.app }
+
+  before do
+    with_directory(@dir = make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        require "hanami"
+
+        module TestApp
+          class App < Hanami::App
+            config.logger.stream = File.new("/dev/null", "w")
+            config.render_detailed_errors = true
+          end
+        end
+      RUBY
+
+      write "config/routes.rb", <<~RUBY
+        module TestApp
+          class Routes < Hanami::Routes
+            get "error", to: "error"
+          end
+        end
+      RUBY
+
+      write "app/actions/error.rb", <<~RUBY
+        module TestApp
+          module Actions
+            class Error < Hanami::Action
+              def handle(*)
+                raise "oops"
+              end
+            end
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "HTML request" do
+    it "renders a detailed HTML error page" do
+      get "/error", {}, "HTTP_ACCEPT" => "text/html"
+
+      expect(last_response.status).to eq 500
+
+      html = Capybara.string(last_response.body)
+      expect(html).to have_selector("header", text: "RuntimeError at /error")
+      expect(html).to have_selector("ul.frames li.application", text: "app/actions/error.rb")
+    end
+  end
+
+  describe "Other request types" do
+    it "renders a detailed error page in text" do
+      get "/error", {}, "HTTP_ACCEPT" => "application/json"
+
+      expect(last_response.status).to eq 500
+
+      expect(last_response.body).to include "RuntimeError at /error"
+      expect(last_response.body).to match %r{App backtrace.+app/actions/error.rb}m
+    end
+  end
+
+  describe "render_detailed_errors config disabled" do
+    def before_prepare
+      write "config/app.rb", <<~RUBY
+        require "hanami"
+
+        module TestApp
+          class App < Hanami::App
+            config.logger.stream = File.new("/dev/null", "w")
+            config.render_detailed_errors = false
+          end
+        end
+      RUBY
+    end
+
+    it "raises errors from within the app" do
+      expect { get "/error" }.to raise_error(RuntimeError, "oops")
+    end
+  end
+end