hanami 2.0.3 → 2.1.0.beta1

data/spec/integration/view/config/part_namespace_spec.rb

@@ -0,0 +1,103 @@
+# frozen_string_literal: true
+
+require "hanami"
+
+RSpec.describe "App view / Config / Part namespace", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  subject(:part_namespace) { view_class.config.part_namespace }
+
+  describe "app view" do
+    let(:view_class) { TestApp::View }
+
+    describe "no part namespace defined" do
+      it "is nil" do
+        expect(part_namespace).to be nil
+      end
+    end
+
+    describe "part namespace defined" do
+      def before_prepare
+        write "app/views/parts/post.rb", <<~RUBY
+          module TestApp
+            module Views
+              module Parts
+                class Post < Hanami::View::Part
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "is the Views::Parts namespace within the app" do
+        expect(part_namespace).to eq TestApp::Views::Parts
+      end
+    end
+  end
+
+  describe "slice view" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        # auto_register: false
+
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+    end
+
+    let(:view_class) { Main::View }
+
+    describe "no part namespace defined" do
+      it "is nil" do
+        expect(part_namespace).to be nil
+      end
+    end
+
+    describe "part namespace defined" do
+      def before_prepare
+        super
+
+        write "slices/main/views/parts/post.rb", <<~RUBY
+          module Main
+            module Views
+              module Parts
+                class Post < Hanami::View::Part
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "is the Views::Parts namespace within the slice" do
+        expect(part_namespace).to eq Main::Views::Parts
+      end
+    end
+  end
+end

data/spec/integration/view/config/paths_spec.rb

@@ -0,0 +1,119 @@
+# frozen_string_literal: true
+
+require "hanami"
+
+RSpec.describe "App view / Config / Paths", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+          end
+        end
+      RUBY
+
+      require "hanami/setup"
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  subject(:paths) { view_class.config.paths }
+
+  describe "app view" do
+    let(:view_class) { TestApp::View }
+
+    it "is 'app/templates/'" do
+      expect(paths.map(&:dir)).to eq [Hanami.app.root.join("app", "templates")]
+    end
+
+    context "custom config in app" do
+      def before_prepare
+        TestApp::App.config.views.paths = ["/custom/dir"]
+      end
+
+      it "uses the custom config" do
+        expect(paths.map(&:dir)).to eq [Pathname("/custom/dir")]
+      end
+    end
+  end
+
+  describe "slice view" do
+    subject(:view_class) { Main::View }
+
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        # auto_register: false
+
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+    end
+
+    it "is 'templates/' within the slice dir" do
+      expect(paths.map(&:dir)).to eq [Main::Slice.root.join("templates")]
+    end
+
+    context "custom config in app" do
+      def before_prepare
+        super
+        TestApp::App.config.views.paths = ["/custom/dir"]
+      end
+
+      it "uses the custom config" do
+        expect(paths.map(&:dir)).to eq [Pathname("/custom/dir")]
+      end
+    end
+
+    context "custom config in slice" do
+      def before_prepare
+        super
+
+        write "config/slices/main.rb", <<~RUBY
+          module Main
+            class Slice < Hanami::Slice
+              config.views.paths = ["/custom/slice/dir"]
+            end
+          end
+        RUBY
+      end
+
+      it "uses the custom config" do
+        expect(paths.map(&:dir)).to eq [Pathname("/custom/slice/dir")]
+      end
+    end
+
+    context "custom config in app and slice" do
+      def before_prepare
+        super
+
+        TestApp::App.config.views.paths = ["/custom/dir"]
+
+        write "config/slices/main.rb", <<~RUBY
+          module Main
+            class Slice < Hanami::Slice
+              config.views.paths = ["/custom/slice/dir"]
+            end
+          end
+        RUBY
+      end
+
+      it "uses the custom config from the slice" do
+        expect(paths.map(&:dir)).to eq [Pathname("/custom/slice/dir")]
+      end
+    end
+  end
+end

data/spec/integration/view/config/scope_class_spec.rb

@@ -0,0 +1,147 @@
+# frozen_string_literal: true
+
+RSpec.describe "App view / Config / Scope class", :app_integration do
+  before do
+    with_directory(@dir = make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view" do
+    let(:view_class) { TestApp::View }
+
+    describe "no concrete app scope class defined" do
+      it "generates an app scope class and configures it as the view's scope_class" do
+        expect(view_class.config.scope_class).to be TestApp::Views::Scope
+        expect(view_class.config.scope_class.superclass).to be Hanami::View::Scope
+      end
+    end
+
+    describe "concrete app scope class defined" do
+      def before_prepare
+        write "app/views/scope.rb", <<~RUBY
+          # auto_register: false
+
+          module TestApp
+            module Views
+              class Scope < Hanami::View::Scope
+                def self.concrete?
+                  true
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "configures the app scope class as the view's scope_class" do
+        expect(view_class.config.scope_class).to be TestApp::Views::Scope
+        expect(view_class.config.scope_class).to be_concrete
+      end
+    end
+  end
+
+  describe "slice view" do
+    let(:view_class) { Main::View }
+
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        # auto_register: false
+
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+    end
+
+    describe "no concrete slice scope class defined" do
+      it "generates a slice scope class and configures it as the view's scope_class" do
+        expect(view_class.config.scope_class).to be Main::Views::Scope
+        expect(view_class.config.scope_class.superclass).to be TestApp::Views::Scope
+      end
+    end
+
+    describe "concrete slice scope class defined" do
+      def before_prepare
+        super
+
+        write "slices/main/views/scope.rb", <<~RUBY
+          # auto_register: false
+
+          module Main
+            module Views
+              class Scope < TestApp::Views::Scope
+                def self.concrete?
+                  true
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "configures the slice scope class as the view's scope_class" do
+        expect(view_class.config.scope_class).to eq Main::Views::Scope
+        expect(view_class.config.scope_class).to be_concrete
+      end
+    end
+
+    context "view not inheriting from app view, no concrete scope class defined" do
+      def before_prepare
+        write "slices/main/view.rb", <<~RUBY
+          # auto_register: false
+
+          module Main
+            class View < Hanami::View
+            end
+          end
+        RUBY
+      end
+
+      it "generates a slice scope class, inheriting from the app scope class, and configures it as the view's scope_class" do
+        expect(view_class.config.scope_class).to be Main::Views::Scope
+        expect(view_class.config.scope_class.superclass).to be TestApp::Views::Scope
+      end
+    end
+
+    context "no app view class defined" do
+      def before_prepare
+        FileUtils.rm "app/view.rb"
+
+        write "slices/main/view.rb", <<~RUBY
+          # auto_register: false
+
+          module Main
+            class View < Hanami::View
+            end
+          end
+        RUBY
+      end
+
+      it "generates a slice scope class, inheriting from Hanami::View::Scope, and configures it as the view's scope_class" do
+        expect(view_class.config.scope_class).to be Main::Views::Scope
+        expect(view_class.config.scope_class.superclass).to be Hanami::View::Scope
+      end
+    end
+  end
+end

data/spec/integration/view/config/scope_namespace_spec.rb

@@ -0,0 +1,103 @@
+# frozen_string_literal: true
+
+require "hanami"
+
+RSpec.describe "App view / Config / Scope namespace", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  subject(:scope_namespace) { view_class.config.scope_namespace }
+
+  describe "app view" do
+    let(:view_class) { TestApp::View }
+
+    describe "no scope namespace defined" do
+      it "is nil" do
+        expect(scope_namespace).to be nil
+      end
+    end
+
+    describe "scope namespace defined" do
+      def before_prepare
+        write "app/views/scopes/player.rb", <<~RUBY
+          module TestApp
+            module Views
+              module Scopes
+                class Player < Hanami::View::Scope
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "is the Views::Scopes namespace within the app" do
+        expect(scope_namespace).to eq TestApp::Views::Scopes
+      end
+    end
+  end
+
+  describe "slice view" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        # auto_register: false
+
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+    end
+
+    let(:view_class) { Main::View }
+
+    describe "no scope namespace defined" do
+      it "is nil" do
+        expect(scope_namespace).to be nil
+      end
+    end
+
+    describe "scope namespace defined" do
+      def before_prepare
+        super
+
+        write "slices/main/views/scopes/player.rb", <<~RUBY
+          module Main
+            module Views
+              module Scopes
+                class Player < Hanami::View::Scope
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "is the Views::Scopes namespace within the slice" do
+        expect(scope_namespace).to eq Main::Views::Scopes
+      end
+    end
+  end
+end

data/spec/integration/view/config/template_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require "hanami"
+
+RSpec.describe "App view / Config / Template", :app_integration do
+  before do
+    module TestApp
+      class App < Hanami::App
+        config.root = "/test_app"
+      end
+    end
+
+    Hanami.app.instance_eval(&app_hook) if respond_to?(:app_hook)
+    Hanami.app.register_slice :main
+    Hanami.app.prepare
+
+    module TestApp
+      class View < Hanami::View
+      end
+    end
+
+    module TestApp
+      module Views
+        module Article
+          class Index < TestApp::View
+          end
+        end
+      end
+    end
+  end
+
+  subject(:template) { view_class.config.template }
+  let(:view_class) { TestApp::Views::Article::Index }
+
+  it "configures the tempalte to match the class name" do
+    expect(template).to eq "article/index"
+  end
+end

data/spec/integration/view/context/request_spec.rb

@@ -20,14 +20,10 @@ RSpec.describe "App view / Context / Request", :app_integration do
   let(:context_class) { TestApp::Views::Context }
 
   subject(:context) {
-    context_class.new(
-      request: request,
-      response: response,
-    )
+    context_class.new(request: request)
   }
 
   let(:request) { double(:request) }
-  let(:response) { double(:response) }
 
   describe "#request" do
     it "is the provided request" do
@@ -51,10 +47,10 @@ RSpec.describe "App view / Context / Request", :app_integration do
     let(:flash) { double(:flash) }
 
     before do
-      allow(response).to receive(:flash) { flash }
+      allow(request).to receive(:flash) { flash }
     end
 
-    it "is the response's flash" do
+    it "is the request's flash" do
       expect(context.flash).to be flash
     end
   end

data/spec/integration/view/helpers/form_helper_spec.rb

@@ -0,0 +1,174 @@
+# frozen_string_literal: true
+
+require "rack/test"
+require "stringio"
+
+RSpec.describe "Helpers / FormHelper", :app_integration do
+  include Rack::Test::Methods
+  let(:app) { Hanami.app }
+
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+            config.logger.stream = StringIO.new
+          end
+        end
+      RUBY
+
+      write "config/routes.rb", <<~RUBY
+        module TestApp
+          class Routes < Hanami::Routes
+            get "posts/:id/edit", to: "posts.edit"
+            put "posts/:id", to: "posts.update"
+          end
+        end
+      RUBY
+
+      write "app/action.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/action"
+
+        module TestApp
+          class Action < Hanami::Action
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      write "app/actions/posts/edit.rb", <<~RUBY
+        module TestApp
+          module Actions
+            module Posts
+              class Edit < TestApp::Action
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/actions/posts/update.rb", <<~RUBY
+        module TestApp
+          module Actions
+            module Posts
+              class Update < TestApp::Action
+                def handle(request, response)
+                  if valid?(request.params[:post])
+                    response.redirect_to "/posts/x/edit"
+                  else
+                    response.render view
+                  end
+                end
+
+                private
+
+                def valid?(post)
+                  post.to_h[:title].to_s.length > 0
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/views/posts/edit.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Edit < TestApp::View
+                expose :post do
+                  Struct.new(:title, :body).new("Hello <world>", "This is the post.")
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/edit.html.erb", <<~ERB
+        <h1>Edit post</h1>
+
+        <%= form_for("/posts") do |f| %>
+          <div>
+            Title:
+            <%= f.text_field "post.title" %>
+          </div>
+          <div>
+            Body:
+            <%= f.text_area "post.body" %>
+          </div>
+        <% end %>
+      ERB
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  it "does not have a _csrf_token field when no sessions are configured" do
+    get "/posts/123/edit"
+
+    html = Capybara.string(last_response.body)
+
+    expect(html).to have_no_selector("input[type='hidden'][name='_csrf_token']")
+  end
+
+  it "uses the value from the view's locals" do
+    get "/posts/123/edit"
+
+    html = Capybara.string(last_response.body)
+
+    title_field = html.find("input[name='post[title]']")
+    expect(title_field.value).to eq "Hello <world>"
+
+    body_field = html.find("textarea[name='post[body]']")
+    expect(body_field.value).to eq "This is the post."
+  end
+
+  it "prefers the values from the request params" do
+    put "/posts/123", post: {title: "", body: "This is the UPDATED post."}
+
+    html = Capybara.string(last_response.body)
+
+    title_field = html.find("input[name='post[title]']")
+    expect(title_field.value).to eq ""
+
+    body_field = html.find("textarea[name='post[body]']")
+    expect(body_field.value).to eq "This is the UPDATED post."
+  end
+
+  context "sessions enabled" do
+    def before_prepare
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+            config.logger.stream = StringIO.new
+            config.actions.sessions = :cookie, {secret: "xyz"}
+          end
+        end
+      RUBY
+    end
+
+    it "inserts a CSRF token field" do
+      get "/posts/123/edit"
+
+      html = Capybara.string(last_response.body)
+
+      csrf_field = html.find("input[type='hidden'][name='_csrf_token']", visible: false)
+      expect(csrf_field.value).to match(/[a-z0-9]{10,}/i)
+    end
+  end
+end