hanami 2.0.2 → 2.1.0.beta1

data/spec/integration/view/helpers/form_helper_spec.rb

@@ -0,0 +1,174 @@
+# frozen_string_literal: true
+
+require "rack/test"
+require "stringio"
+
+RSpec.describe "Helpers / FormHelper", :app_integration do
+  include Rack::Test::Methods
+  let(:app) { Hanami.app }
+
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+            config.logger.stream = StringIO.new
+          end
+        end
+      RUBY
+
+      write "config/routes.rb", <<~RUBY
+        module TestApp
+          class Routes < Hanami::Routes
+            get "posts/:id/edit", to: "posts.edit"
+            put "posts/:id", to: "posts.update"
+          end
+        end
+      RUBY
+
+      write "app/action.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/action"
+
+        module TestApp
+          class Action < Hanami::Action
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      write "app/actions/posts/edit.rb", <<~RUBY
+        module TestApp
+          module Actions
+            module Posts
+              class Edit < TestApp::Action
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/actions/posts/update.rb", <<~RUBY
+        module TestApp
+          module Actions
+            module Posts
+              class Update < TestApp::Action
+                def handle(request, response)
+                  if valid?(request.params[:post])
+                    response.redirect_to "/posts/x/edit"
+                  else
+                    response.render view
+                  end
+                end
+
+                private
+
+                def valid?(post)
+                  post.to_h[:title].to_s.length > 0
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/views/posts/edit.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Edit < TestApp::View
+                expose :post do
+                  Struct.new(:title, :body).new("Hello <world>", "This is the post.")
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/edit.html.erb", <<~ERB
+        <h1>Edit post</h1>
+
+        <%= form_for("/posts") do |f| %>
+          <div>
+            Title:
+            <%= f.text_field "post.title" %>
+          </div>
+          <div>
+            Body:
+            <%= f.text_area "post.body" %>
+          </div>
+        <% end %>
+      ERB
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  it "does not have a _csrf_token field when no sessions are configured" do
+    get "/posts/123/edit"
+
+    html = Capybara.string(last_response.body)
+
+    expect(html).to have_no_selector("input[type='hidden'][name='_csrf_token']")
+  end
+
+  it "uses the value from the view's locals" do
+    get "/posts/123/edit"
+
+    html = Capybara.string(last_response.body)
+
+    title_field = html.find("input[name='post[title]']")
+    expect(title_field.value).to eq "Hello <world>"
+
+    body_field = html.find("textarea[name='post[body]']")
+    expect(body_field.value).to eq "This is the post."
+  end
+
+  it "prefers the values from the request params" do
+    put "/posts/123", post: {title: "", body: "This is the UPDATED post."}
+
+    html = Capybara.string(last_response.body)
+
+    title_field = html.find("input[name='post[title]']")
+    expect(title_field.value).to eq ""
+
+    body_field = html.find("textarea[name='post[body]']")
+    expect(body_field.value).to eq "This is the UPDATED post."
+  end
+
+  context "sessions enabled" do
+    def before_prepare
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+            config.logger.stream = StringIO.new
+            config.actions.sessions = :cookie, {secret: "xyz"}
+          end
+        end
+      RUBY
+    end
+
+    it "inserts a CSRF token field" do
+      get "/posts/123/edit"
+
+      html = Capybara.string(last_response.body)
+
+      csrf_field = html.find("input[type='hidden'][name='_csrf_token']", visible: false)
+      expect(csrf_field.value).to match(/[a-z0-9]{10,}/i)
+    end
+  end
+end

data/spec/integration/view/helpers/part_helpers_spec.rb

@@ -0,0 +1,124 @@
+# frozen_string_literal: true
+
+require "ostruct"
+
+# rubocop:disable Style/OpenStructUse
+
+RSpec.describe "App view / Helpers / Part helpers", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view and parts" do
+    def before_prepare
+      write "app/views/posts/show.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Show < TestApp::View
+                expose :post
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/views/parts/post.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Parts
+              class Post < TestApp::Views::Part
+                def number
+                  format_number(value.number)
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/show.html.erb", <<~ERB
+        <h1><%= post.number %></h1>
+      ERB
+    end
+
+    it "makes default helpers available in parts" do
+      post = OpenStruct.new(number: 12_345)
+      output = TestApp::App["views.posts.show"].call(post: post).to_s.strip
+
+      expect(output).to eq "<h1>12,345</h1>"
+    end
+  end
+
+  describe "slice view and parts" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+
+      write "slices/main/views/posts/show.rb", <<~RUBY
+        module Main
+          module Views
+            module Posts
+              class Show < Main::View
+                expose :post
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/views/parts/post.rb", <<~RUBY
+        module Main
+          module Views
+            module Parts
+              class Post < Main::Views::Part
+                def number
+                  format_number(value.number)
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/templates/posts/show.html.erb", <<~ERB
+        <h1><%= post.number %></h1>
+      ERB
+    end
+
+    it "makes default helpers available in parts" do
+      post = OpenStruct.new(number: 12_345)
+      output = Main::Slice["views.posts.show"].call(post: post).to_s.strip
+
+      expect(output).to eq "<h1>12,345</h1>"
+    end
+  end
+end
+
+# rubocop:enable Style/OpenStructUse

data/spec/integration/view/helpers/scope_helpers_spec.rb

@@ -0,0 +1,84 @@
+# frozen_string_literal: true
+
+RSpec.describe "App view / Helpers / Scope helpers", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view" do
+    def before_prepare
+      write "app/views/posts/show.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Show < TestApp::View
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/show.html.erb", <<~ERB
+        <h1><%= format_number(12_345) %></h1>
+      ERB
+    end
+
+    it "makes default helpers available in templates" do
+      output = TestApp::App["views.posts.show"].call.to_s.strip
+      expect(output).to eq "<h1>12,345</h1>"
+    end
+  end
+
+  describe "slice view" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+
+      write "slices/main/views/posts/show.rb", <<~RUBY
+        module Main
+          module Views
+            module Posts
+              class Show < Main::View
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/templates/posts/show.html.erb", <<~ERB
+        <h1><%= format_number(12_345) %></h1>
+      ERB
+    end
+
+    it "makes default helpers available in templates" do
+      output = Main::Slice["views.posts.show"].call.to_s.strip
+      expect(output).to eq "<h1>12,345</h1>"
+    end
+  end
+end

data/spec/integration/view/helpers/user_defined_helpers/part_helpers_spec.rb

@@ -0,0 +1,162 @@
+# frozen_string_literal: true
+
+require "ostruct"
+
+# rubocop:disable Style/OpenStructUse
+
+RSpec.describe "App view / Helpers / User-defined helpers / Scope helpers", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      write "app/views/helpers.rb", <<~'RUBY'
+        # auto_register: false
+
+        module TestApp
+          module Views
+            module Helpers
+              def exclaim_from_app(str)
+                tag.h1("#{str}! (app helper)")
+              end
+            end
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view and parts" do
+    def before_prepare
+      write "app/views/posts/show.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Show < TestApp::View
+                expose :post
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/views/parts/post.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Parts
+              class Post < TestApp::Views::Part
+                def title
+                  exclaim_from_app(value.title)
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/show.html.erb", <<~ERB
+        <%= post.title %>
+      ERB
+    end
+
+    it "makes user-defined helpers available in parts" do
+      post = OpenStruct.new(title: "Hello world")
+      output = TestApp::App["views.posts.show"].call(post: post).to_s.strip
+
+      expect(output).to eq "<h1>Hello world! (app helper)</h1>"
+    end
+  end
+
+  describe "slice view and parts" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        module Main
+          class View < TestApp::View
+            # FIXME: base slice views should override paths from the base app view
+            config.paths = [File.join(File.expand_path(__dir__), "templates")]
+          end
+        end
+      RUBY
+
+      write "slices/main/views/helpers.rb", <<~'RUBY'
+        # auto_register: false
+
+        module Main
+          module Views
+            module Helpers
+              def exclaim_from_slice(str)
+                tag.h1("#{str}! (slice helper)")
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/views/posts/show.rb", <<~RUBY
+        module Main
+          module Views
+            module Posts
+              class Show < Main::View
+                expose :post
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/views/parts/post.rb", <<~RUBY
+        module Main
+          module Views
+            module Parts
+              class Post < Main::Views::Part
+                def title
+                  exclaim_from_slice(value.title)
+                end
+
+                def title_from_app
+                  exclaim_from_app(value.title)
+                end
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/templates/posts/show.html.erb", <<~ERB
+        <%= post.title %>
+        <%= post.title_from_app %>
+      ERB
+    end
+
+    it "makes user-defined helpers (from app as well as slice) available in parts" do
+      post = OpenStruct.new(title: "Hello world")
+      output = Main::Slice["views.posts.show"].call(post: post).to_s
+
+      expect(output).to eq <<~HTML
+        <h1>Hello world! (slice helper)</h1>
+        <h1>Hello world! (app helper)</h1>
+      HTML
+    end
+  end
+end
+
+# rubocop:enable Style/OpenStructUse

data/spec/integration/view/helpers/user_defined_helpers/scope_helpers_spec.rb

@@ -0,0 +1,119 @@
+# frozen_string_literal: true
+
+RSpec.describe "App view / Helpers / User-defined helpers / Scope helpers", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+            config.layout = nil
+          end
+        end
+      RUBY
+
+      write "app/views/helpers.rb", <<~'RUBY'
+        # auto_register: false
+
+        module TestApp
+          module Views
+            module Helpers
+              def exclaim_from_app(str)
+                tag.h1("#{str}! (app helper)")
+              end
+            end
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view" do
+    def before_prepare
+      write "app/views/posts/show.rb", <<~RUBY
+        module TestApp
+          module Views
+            module Posts
+              class Show < TestApp::View
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "app/templates/posts/show.html.erb", <<~ERB
+        <%= exclaim_from_app("Hello world") %>
+      ERB
+    end
+
+    it "makes user-defined helpers available in templates" do
+      output = TestApp::App["views.posts.show"].call.to_s.strip
+      expect(output).to eq "<h1>Hello world! (app helper)</h1>"
+    end
+  end
+
+  describe "slice view" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        module Main
+          class View < TestApp::View
+            # FIXME: base slice views should override paths from the base app view
+            config.paths = [File.join(File.expand_path(__dir__), "templates")]
+          end
+        end
+      RUBY
+
+      write "slices/main/views/helpers.rb", <<~'RUBY'
+        # auto_register: false
+
+        module Main
+          module Views
+            module Helpers
+              def exclaim_from_slice(str)
+                tag.h1("#{str}! (slice helper)")
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/views/posts/show.rb", <<~RUBY
+        module Main
+          module Views
+            module Posts
+              class Show < Main::View
+              end
+            end
+          end
+        end
+      RUBY
+
+      write "slices/main/templates/posts/show.html.erb", <<~ERB
+        <%= exclaim_from_slice("Hello world") %>
+        <%= exclaim_from_app("Hello world") %>
+      ERB
+    end
+
+    it "makes user-defined helpers (from app as well as slice) available in templates" do
+      output = Main::Slice["views.posts.show"].call.to_s
+
+      expect(output).to eq <<~HTML
+        <h1>Hello world! (slice helper)</h1>
+        <h1>Hello world! (app helper)</h1>
+      HTML
+    end
+  end
+end