hanami 2.0.2 → 2.1.0.beta1

data/spec/integration/view/config/part_class_spec.rb

@@ -0,0 +1,147 @@
+# frozen_string_literal: true
+
+RSpec.describe "App view / Config / Part class", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view" do
+    let(:view_class) { TestApp::View }
+
+    context "no concrete app part class defined" do
+      it "generates an app part class and configures it as the view's part_class" do
+        expect(view_class.config.part_class).to be TestApp::Views::Part
+        expect(view_class.config.part_class.superclass).to be Hanami::View::Part
+      end
+    end
+
+    context "concrete app part class defined" do
+      def before_prepare
+        write "app/views/part.rb", <<~RUBY
+          # auto_register: false
+
+          module TestApp
+            module Views
+              class Part < Hanami::View::Part
+                def self.concrete?
+                  true
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "configures the app part class as the view's part_class" do
+        expect(view_class.config.part_class).to be TestApp::Views::Part
+        expect(view_class.config.part_class).to be_concrete
+      end
+    end
+  end
+
+  describe "slice view" do
+    let(:view_class) { Main::View }
+
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        # auto_register: false
+
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+    end
+
+    context "no concrete slice part class defined" do
+      it "generates a slice part class, inheriting from the app part class, and configures it as the view's part_class" do
+        expect(view_class.config.part_class).to be Main::Views::Part
+        expect(view_class.config.part_class.superclass).to be TestApp::Views::Part
+      end
+    end
+
+    context "concrete slice part class defined" do
+      def before_prepare
+        super
+
+        write "slices/main/views/part.rb", <<~RUBY
+          # auto_register: false
+
+          module Main
+            module Views
+              class Part < TestApp::Views::Part
+                def self.concrete?
+                  true
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "configures the slice part class as the view's part_class" do
+        expect(view_class.config.part_class).to be Main::Views::Part
+        expect(view_class.config.part_class).to be_concrete
+      end
+    end
+
+    context "view not inheriting from app view, no concrete part class" do
+      def before_prepare
+        write "slices/main/view.rb", <<~RUBY
+          # auto_register: false
+
+          module Main
+            class View < Hanami::View
+            end
+          end
+        RUBY
+      end
+
+      it "generates a slice part class, inheriting from the app part class, and configures it as the view's part_class" do
+        expect(view_class.config.part_class).to be Main::Views::Part
+        expect(view_class.config.part_class.superclass).to be TestApp::Views::Part
+      end
+    end
+
+    context "no app view class defined" do
+      def before_prepare
+        FileUtils.rm "app/view.rb"
+
+        write "slices/main/view.rb", <<~RUBY
+          # auto_register: false
+
+          module Main
+            class View < Hanami::View
+            end
+          end
+        RUBY
+      end
+
+      it "generates a slice part class, inheriting from Hanami::View::Part, and configures it as the view's part_class" do
+        expect(view_class.config.part_class).to be Main::Views::Part
+        expect(view_class.config.part_class.superclass).to be Hanami::View::Part
+      end
+    end
+  end
+end

data/spec/integration/view/config/part_namespace_spec.rb

@@ -0,0 +1,103 @@
+# frozen_string_literal: true
+
+require "hanami"
+
+RSpec.describe "App view / Config / Part namespace", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  subject(:part_namespace) { view_class.config.part_namespace }
+
+  describe "app view" do
+    let(:view_class) { TestApp::View }
+
+    describe "no part namespace defined" do
+      it "is nil" do
+        expect(part_namespace).to be nil
+      end
+    end
+
+    describe "part namespace defined" do
+      def before_prepare
+        write "app/views/parts/post.rb", <<~RUBY
+          module TestApp
+            module Views
+              module Parts
+                class Post < Hanami::View::Part
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "is the Views::Parts namespace within the app" do
+        expect(part_namespace).to eq TestApp::Views::Parts
+      end
+    end
+  end
+
+  describe "slice view" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        # auto_register: false
+
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+    end
+
+    let(:view_class) { Main::View }
+
+    describe "no part namespace defined" do
+      it "is nil" do
+        expect(part_namespace).to be nil
+      end
+    end
+
+    describe "part namespace defined" do
+      def before_prepare
+        super
+
+        write "slices/main/views/parts/post.rb", <<~RUBY
+          module Main
+            module Views
+              module Parts
+                class Post < Hanami::View::Part
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "is the Views::Parts namespace within the slice" do
+        expect(part_namespace).to eq Main::Views::Parts
+      end
+    end
+  end
+end

data/spec/integration/view/config/paths_spec.rb

@@ -0,0 +1,119 @@
+# frozen_string_literal: true
+
+require "hanami"
+
+RSpec.describe "App view / Config / Paths", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+          end
+        end
+      RUBY
+
+      require "hanami/setup"
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  subject(:paths) { view_class.config.paths }
+
+  describe "app view" do
+    let(:view_class) { TestApp::View }
+
+    it "is 'app/templates/'" do
+      expect(paths.map(&:dir)).to eq [Hanami.app.root.join("app", "templates")]
+    end
+
+    context "custom config in app" do
+      def before_prepare
+        TestApp::App.config.views.paths = ["/custom/dir"]
+      end
+
+      it "uses the custom config" do
+        expect(paths.map(&:dir)).to eq [Pathname("/custom/dir")]
+      end
+    end
+  end
+
+  describe "slice view" do
+    subject(:view_class) { Main::View }
+
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        # auto_register: false
+
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+    end
+
+    it "is 'templates/' within the slice dir" do
+      expect(paths.map(&:dir)).to eq [Main::Slice.root.join("templates")]
+    end
+
+    context "custom config in app" do
+      def before_prepare
+        super
+        TestApp::App.config.views.paths = ["/custom/dir"]
+      end
+
+      it "uses the custom config" do
+        expect(paths.map(&:dir)).to eq [Pathname("/custom/dir")]
+      end
+    end
+
+    context "custom config in slice" do
+      def before_prepare
+        super
+
+        write "config/slices/main.rb", <<~RUBY
+          module Main
+            class Slice < Hanami::Slice
+              config.views.paths = ["/custom/slice/dir"]
+            end
+          end
+        RUBY
+      end
+
+      it "uses the custom config" do
+        expect(paths.map(&:dir)).to eq [Pathname("/custom/slice/dir")]
+      end
+    end
+
+    context "custom config in app and slice" do
+      def before_prepare
+        super
+
+        TestApp::App.config.views.paths = ["/custom/dir"]
+
+        write "config/slices/main.rb", <<~RUBY
+          module Main
+            class Slice < Hanami::Slice
+              config.views.paths = ["/custom/slice/dir"]
+            end
+          end
+        RUBY
+      end
+
+      it "uses the custom config from the slice" do
+        expect(paths.map(&:dir)).to eq [Pathname("/custom/slice/dir")]
+      end
+    end
+  end
+end

data/spec/integration/view/config/scope_class_spec.rb

@@ -0,0 +1,147 @@
+# frozen_string_literal: true
+
+RSpec.describe "App view / Config / Scope class", :app_integration do
+  before do
+    with_directory(@dir = make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  describe "app view" do
+    let(:view_class) { TestApp::View }
+
+    describe "no concrete app scope class defined" do
+      it "generates an app scope class and configures it as the view's scope_class" do
+        expect(view_class.config.scope_class).to be TestApp::Views::Scope
+        expect(view_class.config.scope_class.superclass).to be Hanami::View::Scope
+      end
+    end
+
+    describe "concrete app scope class defined" do
+      def before_prepare
+        write "app/views/scope.rb", <<~RUBY
+          # auto_register: false
+
+          module TestApp
+            module Views
+              class Scope < Hanami::View::Scope
+                def self.concrete?
+                  true
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "configures the app scope class as the view's scope_class" do
+        expect(view_class.config.scope_class).to be TestApp::Views::Scope
+        expect(view_class.config.scope_class).to be_concrete
+      end
+    end
+  end
+
+  describe "slice view" do
+    let(:view_class) { Main::View }
+
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        # auto_register: false
+
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+    end
+
+    describe "no concrete slice scope class defined" do
+      it "generates a slice scope class and configures it as the view's scope_class" do
+        expect(view_class.config.scope_class).to be Main::Views::Scope
+        expect(view_class.config.scope_class.superclass).to be TestApp::Views::Scope
+      end
+    end
+
+    describe "concrete slice scope class defined" do
+      def before_prepare
+        super
+
+        write "slices/main/views/scope.rb", <<~RUBY
+          # auto_register: false
+
+          module Main
+            module Views
+              class Scope < TestApp::Views::Scope
+                def self.concrete?
+                  true
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "configures the slice scope class as the view's scope_class" do
+        expect(view_class.config.scope_class).to eq Main::Views::Scope
+        expect(view_class.config.scope_class).to be_concrete
+      end
+    end
+
+    context "view not inheriting from app view, no concrete scope class defined" do
+      def before_prepare
+        write "slices/main/view.rb", <<~RUBY
+          # auto_register: false
+
+          module Main
+            class View < Hanami::View
+            end
+          end
+        RUBY
+      end
+
+      it "generates a slice scope class, inheriting from the app scope class, and configures it as the view's scope_class" do
+        expect(view_class.config.scope_class).to be Main::Views::Scope
+        expect(view_class.config.scope_class.superclass).to be TestApp::Views::Scope
+      end
+    end
+
+    context "no app view class defined" do
+      def before_prepare
+        FileUtils.rm "app/view.rb"
+
+        write "slices/main/view.rb", <<~RUBY
+          # auto_register: false
+
+          module Main
+            class View < Hanami::View
+            end
+          end
+        RUBY
+      end
+
+      it "generates a slice scope class, inheriting from Hanami::View::Scope, and configures it as the view's scope_class" do
+        expect(view_class.config.scope_class).to be Main::Views::Scope
+        expect(view_class.config.scope_class.superclass).to be Hanami::View::Scope
+      end
+    end
+  end
+end

data/spec/integration/view/config/scope_namespace_spec.rb

@@ -0,0 +1,103 @@
+# frozen_string_literal: true
+
+require "hanami"
+
+RSpec.describe "App view / Config / Scope namespace", :app_integration do
+  before do
+    with_directory(make_tmp_directory) do
+      write "config/app.rb", <<~RUBY
+        module TestApp
+          class App < Hanami::App
+          end
+        end
+      RUBY
+
+      write "app/view.rb", <<~RUBY
+        # auto_register: false
+
+        require "hanami/view"
+
+        module TestApp
+          class View < Hanami::View
+          end
+        end
+      RUBY
+
+      before_prepare if respond_to?(:before_prepare)
+      require "hanami/prepare"
+    end
+  end
+
+  subject(:scope_namespace) { view_class.config.scope_namespace }
+
+  describe "app view" do
+    let(:view_class) { TestApp::View }
+
+    describe "no scope namespace defined" do
+      it "is nil" do
+        expect(scope_namespace).to be nil
+      end
+    end
+
+    describe "scope namespace defined" do
+      def before_prepare
+        write "app/views/scopes/player.rb", <<~RUBY
+          module TestApp
+            module Views
+              module Scopes
+                class Player < Hanami::View::Scope
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "is the Views::Scopes namespace within the app" do
+        expect(scope_namespace).to eq TestApp::Views::Scopes
+      end
+    end
+  end
+
+  describe "slice view" do
+    def before_prepare
+      write "slices/main/view.rb", <<~RUBY
+        # auto_register: false
+
+        module Main
+          class View < TestApp::View
+          end
+        end
+      RUBY
+    end
+
+    let(:view_class) { Main::View }
+
+    describe "no scope namespace defined" do
+      it "is nil" do
+        expect(scope_namespace).to be nil
+      end
+    end
+
+    describe "scope namespace defined" do
+      def before_prepare
+        super
+
+        write "slices/main/views/scopes/player.rb", <<~RUBY
+          module Main
+            module Views
+              module Scopes
+                class Player < Hanami::View::Scope
+                end
+              end
+            end
+          end
+        RUBY
+      end
+
+      it "is the Views::Scopes namespace within the slice" do
+        expect(scope_namespace).to eq Main::Views::Scopes
+      end
+    end
+  end
+end

data/spec/integration/view/config/template_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require "hanami"
+
+RSpec.describe "App view / Config / Template", :app_integration do
+  before do
+    module TestApp
+      class App < Hanami::App
+        config.root = "/test_app"
+      end
+    end
+
+    Hanami.app.instance_eval(&app_hook) if respond_to?(:app_hook)
+    Hanami.app.register_slice :main
+    Hanami.app.prepare
+
+    module TestApp
+      class View < Hanami::View
+      end
+    end
+
+    module TestApp
+      module Views
+        module Article
+          class Index < TestApp::View
+          end
+        end
+      end
+    end
+  end
+
+  subject(:template) { view_class.config.template }
+  let(:view_class) { TestApp::Views::Article::Index }
+
+  it "configures the tempalte to match the class name" do
+    expect(template).to eq "article/index"
+  end
+end

data/spec/integration/view/context/request_spec.rb

@@ -20,14 +20,10 @@ RSpec.describe "App view / Context / Request", :app_integration do
   let(:context_class) { TestApp::Views::Context }
 
   subject(:context) {
-    context_class.new(
-      request: request,
-      response: response,
-    )
+    context_class.new(request: request)
   }
 
   let(:request) { double(:request) }
-  let(:response) { double(:response) }
 
   describe "#request" do
     it "is the provided request" do
@@ -51,10 +47,10 @@ RSpec.describe "App view / Context / Request", :app_integration do
     let(:flash) { double(:flash) }
 
     before do
-      allow(response).to receive(:flash) { flash }
+      allow(request).to receive(:flash) { flash }
     end
 
-    it "is the response's flash" do
+    it "is the request's flash" do
       expect(context.flash).to be flash
     end
   end