hammer_cli_foreman 2.1.2 → 2.4.0

data/test/unit/config_group_test.rb

@@ -16,6 +16,8 @@ describe HammerCLIForeman::ConfigGroup do
     context "parameters" do
       it_should_accept "no arguments"
       it_should_accept_search_params
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
     end
 
     context "output" do
@@ -31,6 +33,8 @@ describe HammerCLIForeman::ConfigGroup do
     context "parameters" do
       it_should_accept "id", ["--id=1"]
       it_should_accept "name", ["--name=group_x"]
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
     end
 
     context "output" do
@@ -48,6 +52,8 @@ describe HammerCLIForeman::ConfigGroup do
 
     context "parameters" do
       it_should_accept "name, puppetclass ids", ["--name=first_group", "--puppet-class-ids=1,2"]
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
     end
   end
 
@@ -57,6 +63,8 @@ describe HammerCLIForeman::ConfigGroup do
     context "parameters" do
       it_should_accept "name", ["--name=group_x"]
       it_should_accept "id", ["--id=1"]
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
     end
   end
 
@@ -67,6 +75,8 @@ describe HammerCLIForeman::ConfigGroup do
     context "parameters" do
       it_should_accept "name", ["--name=group_x"]
       it_should_accept "id", ["--id=1"]
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
     end
   end
 end

data/test/unit/dependency_resolver_test.rb

@@ -20,7 +20,7 @@ describe HammerCLIForeman::DependencyResolver do
 
     it "returns empty array for an independent resource" do
       resource = api.resource(:users)
-      resolver.resource_dependencies(resource).must_equal []
+      _(resolver.resource_dependencies(resource)).must_equal []
     end
 
     it "returns list of dependent resources" do
@@ -28,7 +28,7 @@ describe HammerCLIForeman::DependencyResolver do
 
       resources = resolver.resource_dependencies(resource).map(&:name).sort_by{ |sym| sym.to_s }
       expected = [:posts, :users]
-      resources.must_equal expected.sort_by{ |sym| sym.to_s }
+      _(resources).must_equal expected.sort_by{ |sym| sym.to_s }
     end
   end
 
@@ -36,14 +36,14 @@ describe HammerCLIForeman::DependencyResolver do
 
     it "returns empty array for an independent action" do
       action = HammerCLIForeman.foreman_resource!(:users).action(:index)
-      resolver.action_dependencies(action).must_equal []
+      _(resolver.action_dependencies(action)).must_equal []
     end
 
     it "returns list of dependent resources" do
       action = HammerCLIForeman.foreman_resource!(:comments).action(:create)
       resources = resolver.action_dependencies(action).map(&:name).sort_by{ |sym| sym.to_s }
       expected = [:posts, :users]
-      resources.must_equal expected.sort_by{|sym| sym.to_s}
+      _(resources).must_equal expected.sort_by{|sym| sym.to_s}
     end
   end
 end

data/test/unit/exception_handler_test.rb

@@ -15,7 +15,7 @@ describe HammerCLIForeman::ExceptionHandler do
     ex = RestClient::UnprocessableEntity.new(response)
     output.expects(:print_error).with(heading, "Network address can't be blank\nNetwork address is invalid\nName can't be blank")
     err_code = handler.handle_exception(ex, :heading => heading)
-    err_code.must_equal HammerCLI::EX_DATAERR
+    _(err_code).must_equal HammerCLI::EX_DATAERR
   end
 
   it "should print resource errors on unprocessable entity exception" do
@@ -26,21 +26,21 @@ describe HammerCLIForeman::ExceptionHandler do
     ex = RestClient::UnprocessableEntity.new(response)
     output.expects(:print_error).with(heading, "Network address can't be blank\nNetwork address is invalid\nName can't be blank")
     err_code = handler.handle_exception(ex, :heading => heading)
-    err_code.must_equal HammerCLI::EX_DATAERR
+    _(err_code).must_equal HammerCLI::EX_DATAERR
   end
 
   it "should handle argument error" do
     ex = ArgumentError.new
     output.expects(:print_error).with(heading, ex.message)
     err_code = handler.handle_exception(ex, :heading => heading)
-    err_code.must_equal HammerCLI::EX_USAGE
+    _(err_code).must_equal HammerCLI::EX_USAGE
   end
 
   it "should handle forbidden error" do
     ex = RestClient::Forbidden.new
     output.expects(:print_error).with('Forbidden - server refused to process the request.', nil)
     err_code = handler.handle_exception(ex)
-    err_code.must_equal HammerCLI::EX_NOPERM
+    _(err_code).must_equal HammerCLI::EX_NOPERM
   end
 
   it "handles forbidden error with permission details" do
@@ -57,13 +57,13 @@ describe HammerCLIForeman::ExceptionHandler do
     output.expects(:print_error).with(heading, "Error: message")
     MyException = Class.new(Exception)
     err_code = handler.handle_exception(MyException.new('message'), :heading => heading)
-    err_code.must_equal HammerCLI::EX_SOFTWARE
+    _(err_code).must_equal HammerCLI::EX_SOFTWARE
   end
 
   it "should handle unsupported operation error" do
     output.expects(:print_error).with(heading, "message")
     err_code = handler.handle_exception(HammerCLIForeman::OperationNotSupportedError.new('message'), :heading => heading)
-    err_code.must_equal HammerCLI::EX_UNAVAILABLE
+    _(err_code).must_equal HammerCLI::EX_UNAVAILABLE
   end
 
   it "should print resource errors on resource not found exception" do
@@ -75,7 +75,7 @@ describe HammerCLIForeman::ExceptionHandler do
 
     output.expects(:print_error).with(heading, "Resource architecture not found by id '1'")
     err_code = handler.handle_exception(ex, :heading => heading)
-    err_code.must_equal HammerCLI::EX_NOT_FOUND
+    _(err_code).must_equal HammerCLI::EX_NOT_FOUND
   end
 
   it "should print exception message on resource not found exception without explicit message" do
@@ -85,7 +85,7 @@ describe HammerCLIForeman::ExceptionHandler do
 
     output.expects(:print_error).with(heading, "ResourceNotFound message")
     err_code = handler.handle_exception(ex, :heading => heading)
-    err_code.must_equal HammerCLI::EX_NOT_FOUND
+    _(err_code).must_equal HammerCLI::EX_NOT_FOUND
   end
 
   it "should print resource errors on internal error exception" do
@@ -97,7 +97,7 @@ describe HammerCLIForeman::ExceptionHandler do
 
     output.expects(:print_error).with(heading, "Some internal exception")
     err_code = handler.handle_exception(ex, :heading => heading)
-    err_code.must_equal HammerCLI::EX_SOFTWARE
+    _(err_code).must_equal HammerCLI::EX_SOFTWARE
   end
 
   it "should print exception message on internal error exception without formatted message" do
@@ -110,7 +110,7 @@ describe HammerCLIForeman::ExceptionHandler do
 
     output.expects(:print_error).with(heading, "Unformatted\nlines\n")
     err_code = handler.handle_exception(ex, :heading => heading)
-    err_code.must_equal HammerCLI::EX_SOFTWARE
+    _(err_code).must_equal HammerCLI::EX_SOFTWARE
   end
 
   it "should print exception message on internal error exception with message that is not nested" do
@@ -122,7 +122,7 @@ describe HammerCLIForeman::ExceptionHandler do
 
     output.expects(:print_error).with(heading, "Some internal exception")
     err_code = handler.handle_exception(ex, :heading => heading)
-    err_code.must_equal HammerCLI::EX_SOFTWARE
+    _(err_code).must_equal HammerCLI::EX_SOFTWARE
   end
 
   context "redirects" do
@@ -133,7 +133,7 @@ describe HammerCLIForeman::ExceptionHandler do
 
       output.expects(:print_error).with(heading, "Redirection of API call detected.\nIt seems hammer is configured to use HTTP and the server prefers HTTPS.\nUpdate your server url configuration.\nYou can set 'follow_redirects' to one of :default or :always to enable redirects following.")
       err_code = handler.handle_exception(ex, :heading => heading)
-      err_code.must_equal HammerCLI::EX_CONFIG
+      _(err_code).must_equal HammerCLI::EX_CONFIG
     end
 
     it "should detect redirection error" do
@@ -142,7 +142,7 @@ describe HammerCLIForeman::ExceptionHandler do
 
       output.expects(:print_error).with(heading, "Redirection of API call detected.\nUpdate your server url configuration.\nYou can set 'follow_redirects' to one of :default or :always to enable redirects following.")
       err_code = handler.handle_exception(ex, :heading => heading)
-      err_code.must_equal HammerCLI::EX_CONFIG
+      _(err_code).must_equal HammerCLI::EX_CONFIG
     end
   end
 

data/test/unit/helpers/command.rb

@@ -97,14 +97,14 @@ module CommandTestHelper
 
     def it_should_fail_with(message, arguments=[])
       it "should fail with " + message.to_s do
-        cmd.run(arguments).must_equal HammerCLI::EX_USAGE
+        _(cmd.run(arguments)).must_equal HammerCLI::EX_USAGE
       end
     end
 
     def it_should_accept(message, arguments=[])
       it "should accept " + message.to_s do
         out, err = capture_io do
-          cmd.run(arguments).must_equal HammerCLI::EX_OK
+          _(cmd.run(arguments)).must_equal HammerCLI::EX_OK
         end
       end
     end
@@ -116,7 +116,7 @@ module CommandTestHelper
         out, err = capture_io do
           cmd.run(arguments)
         end
-        out.must_include message
+        _(out).must_include message
       end
     end
 
@@ -129,7 +129,7 @@ module CommandTestHelper
           cmd.run(arguments)
         end
 
-        out.split("\n")[0].must_match /.*##{column_name}#.*/
+        _(out.split("\n")[0]).must_match /.*##{column_name}#.*/
       end
     end
 
@@ -148,7 +148,7 @@ module CommandTestHelper
         out, err = capture_io do
           cmd.run(arguments)
         end
-        out.split(/\n/).length.must_equal count+1 # plus 1 for line with column headers
+        _(out.split(/\n/).length).must_equal count+1 # plus 1 for line with column headers
       end
     end
 

data/test/unit/helpers/resource_disabled.rb

@@ -9,7 +9,7 @@ module ResourceDisabled
       it "should return error" do
         cmd.class.resource.stubs(:call).raises(RestClient::ResourceNotFound)
         arguments = respond_to?(:with_params) ? with_params : []
-        cmd.run(arguments).must_equal HammerCLI::EX_UNAVAILABLE
+        _(cmd.run(arguments)).must_equal HammerCLI::EX_UNAVAILABLE
       end
 
       it "should print error message" do
@@ -17,7 +17,7 @@ module ResourceDisabled
         cmd.stubs(:context).returns(ctx.update(:adapter => :test))
 
         arguments = respond_to?(:with_params) ? with_params : []
-        lambda { cmd.run(arguments) }.must_output "", /.*not support.*/
+        _(lambda { cmd.run(arguments) }).must_output "", /.*not support.*/
       end
     end
   end

data/test/unit/host_test.rb

@@ -76,7 +76,7 @@ describe HammerCLIForeman::Host do
 
         it "should output status" do
           cmd.stubs(:context).returns(ctx.update(:adapter => :test))
-          proc { cmd.run(with_params) }.must_output "#Status#Power#\n#No reports#running#\n"
+          _(proc { cmd.run(with_params) }).must_output "#Status#Power#\n#No reports#running#\n"
         end
       end
     end
@@ -132,29 +132,6 @@ describe HammerCLIForeman::Host do
   end
 
 
-  context "PuppetRunCommand" do
-
-    let(:cmd) { HammerCLIForeman::Host::PuppetRunCommand.new("", ctx) }
-
-    context "parameters" do
-      it_should_accept "name", ["--name=host"]
-      it_should_accept "id", ["--id=1"]
-      # it_should_fail_with "no arguments"
-      # TODO: temporarily disabled, parameters are checked in the id resolver
-
-    end
-
-    context "output" do
-      with_params ["--id=1"] do
-        it "should inform that puppet was triggered" do
-          cmd.stubs(:context).returns(ctx.update(:adapter => :test))
-          proc { cmd.run(with_params) }.must_output "Puppet run triggered\n"
-        end
-      end
-    end
-  end
-
-
   context "ConfigReportsCommand" do
     before do
       ResourceMocks.mock_action_call(:config_reports, :index, [])

data/test/unit/id_resolver_test.rb

@@ -14,7 +14,7 @@ describe HammerCLIForeman::IdResolver do
 
   describe "scoped options" do
     it "returns empty hash when there are no options" do
-      resolver.scoped_options("scope", {}).must_equal({})
+      _(resolver.scoped_options("scope", {})).must_equal({})
     end
 
     it "unscopes options" do
@@ -29,7 +29,7 @@ describe HammerCLIForeman::IdResolver do
         "option_name" => "ACME",
         "option_a" => :value
       }
-      resolver.scoped_options("organization", scoped).must_equal(unscoped)
+      _(resolver.scoped_options("organization", scoped)).must_equal(unscoped)
     end
 
     it "clears old values" do
@@ -43,7 +43,7 @@ describe HammerCLIForeman::IdResolver do
         "option_id" => 2,
         "option_a" => :value
       }
-      resolver.scoped_options("organization", scoped).must_equal(unscoped)
+      _(resolver.scoped_options("organization", scoped)).must_equal(unscoped)
     end
 
     let(:scoped_multi) {{
@@ -63,7 +63,7 @@ describe HammerCLIForeman::IdResolver do
         "option_name" => "ACME",
         "option_a" => :value
       }
-      resolver.scoped_options("organization", scoped_multi, :single).must_equal(unscoped)
+      _(resolver.scoped_options("organization", scoped_multi, :single)).must_equal(unscoped)
     end
 
     it "unscopes the right options in multi mode" do
@@ -75,7 +75,7 @@ describe HammerCLIForeman::IdResolver do
         "option_names" => "Corp",
         "option_a" => :value
       }
-      resolver.scoped_options("organization", scoped_multi, :multi).must_equal(unscoped)
+      _(resolver.scoped_options("organization", scoped_multi, :multi)).must_equal(unscoped)
     end
 
     it "does not change the original options" do
@@ -87,7 +87,7 @@ describe HammerCLIForeman::IdResolver do
       }
       scoped_original = scoped.dup
       resolver.scoped_options("organization", scoped)
-      scoped.must_equal(scoped_original)
+      _(scoped).must_equal(scoped_original)
     end
 
   end
@@ -102,19 +102,19 @@ describe HammerCLIForeman::IdResolver do
     it "must define methods for all resources" do
       expected_method_names = api.resources.map(&:singular_name).collect{|r| "#{r}_id"}
       missing_methods = expected_method_names - resolver.methods.map(&:to_s)
-      missing_methods.must_equal []
+      _(missing_methods).must_equal []
     end
 
     describe "when no search options are found" do
       let(:resolver_run) { proc { resolver.comment_id({"option_unknown" => "value"}) } }
 
       it "raises exception" do
-        err = resolver_run.must_raise HammerCLIForeman::MissingSearchOptions
+        err = _(resolver_run).must_raise HammerCLIForeman::MissingSearchOptions
       end
 
       it "builds correct error message" do
-        err = resolver_run.must_raise HammerCLIForeman::MissingSearchOptions
-        err.message.must_equal "Missing options to search comment."
+        err = _(resolver_run).must_raise HammerCLIForeman::MissingSearchOptions
+        _(err.message).must_equal "Missing options to search comment."
       end
     end
 
@@ -124,15 +124,15 @@ describe HammerCLIForeman::IdResolver do
       it "raises exception when no resource is found" do
         ResourceMocks.mock_action_call(:users, :index, index_response([]))
 
-        err = resolver_run.must_raise HammerCLIForeman::ResolverError
-        err.message.must_equal "user not found."
+        err = _(resolver_run).must_raise HammerCLIForeman::ResolverError
+        _(err.message).must_equal "user not found."
       end
 
       it "raises exception when multiple resources are found" do
         ResourceMocks.mock_action_call(:users, :index, index_response([john, jane]))
 
-        err = resolver_run.must_raise HammerCLIForeman::ResolverError
-        err.message.must_equal "Found more than one user."
+        err = _(resolver_run).must_raise HammerCLIForeman::ResolverError
+        _(err.message).must_equal "Found more than one user."
       end
 
       it "calls index action with appropriate search params" do
@@ -148,17 +148,17 @@ describe HammerCLIForeman::IdResolver do
       it "uses option id when it's available" do
         ResourceMocks.mock_action_call(:users, :index, [])
 
-        resolver.user_id({"option_id" => 83, "option_name" => "John Doe"}).must_equal 83
+        _(resolver.user_id({"option_id" => 83, "option_name" => "John Doe"})).must_equal 83
       end
 
       it "returns NIL when the search name is NIL" do
-        resolver.user_id({"option_name" => HammerCLI::NilValue}).must_equal HammerCLI::NilValue
+        _(resolver.user_id({"option_name" => HammerCLI::NilValue})).must_equal HammerCLI::NilValue
       end
 
       it "returns id of the resource" do
         ResourceMocks.mock_action_call(:users, :index, index_response([john]))
 
-        resolver_run.call.must_equal john_id
+        _(resolver_run.call).must_equal john_id
       end
 
     end
@@ -170,16 +170,16 @@ describe HammerCLIForeman::IdResolver do
         ResourceMocks.mock_action_call(:posts, :index, index_response([]))
         ResourceMocks.mock_action_call(:users, :index, index_response([]))
 
-        err = resolver_run.must_raise HammerCLIForeman::ResolverError
-        err.message.must_equal "user not found."
+        err = _(resolver_run).must_raise HammerCLIForeman::ResolverError
+        _(err.message).must_equal "user not found."
       end
 
       it "raises exception when multiple resources are found" do
         ResourceMocks.mock_action_call(:posts, :index, index_response([]))
         ResourceMocks.mock_action_call(:users, :index, index_response([john, jane]))
 
-        err = resolver_run.must_raise HammerCLIForeman::ResolverError
-        err.message.must_equal "Found more than one user."
+        err = _(resolver_run).must_raise HammerCLIForeman::ResolverError
+        _(err.message).must_equal "Found more than one user."
       end
 
       it "calls index action with appropriate search params" do
@@ -209,7 +209,7 @@ describe HammerCLIForeman::IdResolver do
             {"id" => 22, "name" => "User 22"}
           ]
         ))
-        resolver_run.call.must_equal 11
+        _(resolver_run.call).must_equal 11
       end
     end
 
@@ -288,7 +288,7 @@ describe HammerCLIForeman::IdResolver do
       end
 
       it "returns NilValue when the search name is NilValue" do
-        resolver.user_ids({"option_names" => HammerCLI::NilValue}).must_equal HammerCLI::NilValue
+        _(resolver.user_ids({"option_names" => HammerCLI::NilValue})).must_equal HammerCLI::NilValue
       end
     end
   end

data/test/unit/mail_notification_test.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), 'test_helper')
+require File.join(File.dirname(__FILE__), 'apipie_resource_mock')
+
+require 'hammer_cli_foreman/mail_notification'
+
+describe HammerCLIForeman::MailNotification do
+  include CommandTestHelper
+
+  context 'ListCommand' do
+    before :each do
+      ResourceMocks.mail_notifications
+    end
+
+    let(:cmd) { HammerCLIForeman::MailNotification::ListCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'no arguments'
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+
+    context 'output' do
+      let(:expected_record_count) { count_records(cmd.resource.call(:index)) }
+
+      it_should_print_n_records
+      it_should_print_column 'Id'
+      it_should_print_column 'Name'
+    end
+  end
+
+  context 'InfoCommand' do
+    let(:cmd) { HammerCLIForeman::MailNotification::InfoCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=test']
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+
+    context 'output' do
+      with_params ['--id=1'] do
+        it_should_print_n_records 1
+        it_should_print_column 'Id'
+        it_should_print_column 'Name'
+        it_should_print_column 'Description'
+        it_should_print_column 'Subscription type'
+      end
+    end
+  end
+end