hammer_cli_foreman 2.1.2 → 2.4.0

data/test/unit/api/interactive_basic_auth_test.rb

@@ -44,11 +44,13 @@ describe HammerCLIForeman::Api::InteractiveBasicAuth do
 
   context "non-interactive mode" do
     it "doesn't ask for credentials when they're not provided" do
+      HammerCLI.stubs(:interactive?).returns false
       auth = HammerCLIForeman::Api::InteractiveBasicAuth.new(nil, nil)
       auth.expects(:ask_user).never
-
       request.expects(:basic_auth).with(nil, nil)
       auth.authenticate(request, args)
+      HammerCLI.unstub(:interactive?)
+
     end
   end
 

data/test/unit/api/oauth/oauth_authentication_code_grant_test.rb

@@ -23,13 +23,13 @@ describe HammerCLIForeman::Api::Oauth::AuthenticationCodeGrant do
     it 'sets token as nil when all input parameter are missing' do
       auth.stubs(:get_code).returns('code')
       auth.set_token(nil, nil, nil, nil)
-      assert_equal nil, auth.token
+      assert_nil auth.token
     end
 
     it 'sets token as nil when any input parameter is missing' do
       auth.stubs(:get_code).returns('code')
       auth.set_token(nil, params[:oidc_authorization_endpoint], params[:oidc_client_id], params[:oidc_redirect_uri])
-      assert_equal nil, auth.token
+      assert_nil auth.token
     end
   end
 

data/test/unit/api/oauth/oauth_password_grant_test.rb

@@ -22,12 +22,12 @@ describe HammerCLIForeman::Api::Oauth::PasswordGrant do
 
     it 'sets token as nil when all input parameter are missing' do
       auth.set_token(nil, nil, nil, nil)
-      assert_equal nil, auth.token
+      assert_nil auth.token
     end
 
     it 'sets token as nil when any input parameter is missing' do
       auth.set_token(nil, params[:oidc_client_id], params[:username], params[:password])
-      assert_equal nil, auth.token
+      assert_nil auth.token
     end
   end
 

data/test/unit/api_test.rb

@@ -9,17 +9,16 @@ describe HammerCLIForeman do
     let(:expected_resource) { HammerCLIForeman.foreman_resource!(:architectures) }
 
     it "finds resource for params with _id" do
-      HammerCLIForeman.param_to_resource("architecture_id").name.must_equal expected_resource.name
+      _(HammerCLIForeman.param_to_resource("architecture_id").name).must_equal expected_resource.name
     end
 
     it "finds resource for params without _id" do
-      HammerCLIForeman.param_to_resource("architecture").name.must_equal expected_resource.name
+      _(HammerCLIForeman.param_to_resource("architecture").name).must_equal expected_resource.name
     end
 
     it "returns nil for unknown resource" do
-      HammerCLIForeman.param_to_resource("unknown").must_equal nil
+      assert_nil HammerCLIForeman.param_to_resource("unknown")
     end
-
   end
 
 end

data/test/unit/apipie_resource_mock.rb

@@ -237,6 +237,27 @@ module ResourceMocks
       )
   end
 
+  def self.bookmarks
+    ResourceMocks.mock_action_calls(
+      [:bookmarks, :index, []],
+      [:bookmarks, :show, {}]
+    )
+  end
+
+  def self.mail_notifications
+    ResourceMocks.mock_action_calls(
+      [:mail_notifications, :index, []],
+      [:mail_notifications, :show, {}]
+    )
+  end
+
+  def self.compute_profiles
+    ResourceMocks.mock_action_calls(
+      [:compute_profiles, :index, []],
+      [:compute_profiles, :show, {}]
+    )
+  end
+
   def self.parameters_index
     ResourceMocks.mock_action_call(:parameters, :index, [])
   end
@@ -308,11 +329,11 @@ module ResourceMocks
     )
   end
 
-  def self.common_parameter_show
-    ResourceMocks.mock_action_call(:common_parameters, :show, {
+  def self.common_parameter_list
+    ResourceMocks.mock_action_call(:common_parameters, :index, [{
       "name" => "my param",
-      "value" => "random value"
-    })
+      "value" => "random value",
+    }])
   end
 
   def self.config_groups_index

data/test/unit/architecture_test.rb

@@ -17,6 +17,8 @@ describe HammerCLIForeman::Architecture do
     context "parameters" do
       it_should_accept "no arguments"
       it_should_accept_search_params
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
     end
 
     context "output" do
@@ -37,6 +39,8 @@ describe HammerCLIForeman::Architecture do
     context "parameters" do
       it_should_accept "id", ["--id=1"]
       it_should_accept "name", ["--name=arch"]
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
       # it_should_fail_with "no arguments" # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
@@ -57,6 +61,8 @@ describe HammerCLIForeman::Architecture do
 
     context "parameters" do
       it_should_accept "name", ["--name=arch"]
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
       # it_should_fail_with "name missing", []
       # TODO: temporarily disabled, parameters are checked in the api
     end
@@ -71,6 +77,8 @@ describe HammerCLIForeman::Architecture do
     context "parameters" do
       it_should_accept "name", ["--name=arch"]
       it_should_accept "id", ["--id=1"]
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
       # it_should_fail_with "name or id missing", [] # TODO: temporarily disabled, parameters are checked in the id resolver
     end
 
@@ -84,9 +92,10 @@ describe HammerCLIForeman::Architecture do
     context "parameters" do
       it_should_accept "name", ["--name=arch", "--new-name=arch2"]
       it_should_accept "id", ["--id=1", "--new-name=arch2"]
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
       # it_should_fail_with "no params", [] # TODO: temporarily disabled, parameters are checked in the id resolver
       # it_should_fail_with "name or id missing", ["--new-name=arch2"] # TODO: temporarily disabled, parameters are checked in the id resolver
     end
-
   end
 end

data/test/unit/bookmark_test.rb

@@ -0,0 +1,99 @@
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), 'test_helper')
+require File.join(File.dirname(__FILE__), 'apipie_resource_mock')
+
+require 'hammer_cli_foreman/bookmark'
+
+describe HammerCLIForeman::Bookmark do
+  include CommandTestHelper
+
+  context 'ListCommand' do
+    before :each do
+      ResourceMocks.bookmarks
+    end
+
+    let(:cmd) { HammerCLIForeman::Bookmark::ListCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'no arguments'
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+
+    context 'output' do
+      let(:expected_record_count) { count_records(cmd.resource.call(:index)) }
+
+      it_should_print_n_records
+      it_should_print_column 'Id'
+      it_should_print_column 'Name'
+      it_should_print_column 'Controller'
+      it_should_print_column 'Search Query'
+      it_should_print_column 'Public'
+      it_should_print_column 'Owner Id'
+      it_should_print_column 'Owner Type'
+    end
+  end
+
+  context 'InfoCommand' do
+    let(:cmd) { HammerCLIForeman::Bookmark::InfoCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=active']
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+
+    context 'output' do
+      with_params ['--id=1'] do
+        it_should_print_n_records 1
+        it_should_print_column 'Id'
+        it_should_print_column 'Name'
+        it_should_print_column 'Controller'
+        it_should_print_column 'Search Query'
+        it_should_print_column 'Public'
+        it_should_print_column 'Owner Id'
+        it_should_print_column 'Owner Type'
+      end
+    end
+  end
+
+  context 'CreateCommand' do
+    let(:cmd) { HammerCLIForeman::Bookmark::CreateCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'name, public, controller, query',
+                       ['--name=active', '--public=1', '--controller=hosts',
+                        '--query=last_report > "35 minutes ago" and (status.applied > 0 or status.restarted > 0)']
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+
+  end
+
+  context 'DeleteCommand' do
+    let(:cmd) { HammerCLIForeman::Bookmark::DeleteCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=active']
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+  end
+
+  context 'UpdateCommand' do
+    let(:cmd) { HammerCLIForeman::Bookmark::UpdateCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=active']
+      it_should_accept 'name, public, controller, query',
+                       ['--name=active', '--public=1', '--controller=hosts',
+                        '--query=last_report > "35 minutes ago" and (status.applied > 0 or status.restarted > 0)']
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+  end
+end

data/test/unit/commands_test.rb

@@ -19,16 +19,16 @@ describe HammerCLIForeman do
       ]
 
       set = HammerCLIForeman.collection_to_common_format(old_format)
-      set.must_be_kind_of HammerCLI::Output::RecordCollection
-      set.first.must_equal(kind)
+      _(set).must_be_kind_of HammerCLI::Output::RecordCollection
+      _(set.first).must_equal(kind)
     end
 
     it "should convert common API format" do
       common_format = [ kind ]
 
       set = HammerCLIForeman.collection_to_common_format(common_format)
-      set.must_be_kind_of HammerCLI::Output::RecordCollection
-      set.first.must_equal(kind)
+      _(set).must_be_kind_of HammerCLI::Output::RecordCollection
+      _(set.first).must_equal(kind)
     end
 
     it "should convert new API format" do
@@ -46,12 +46,12 @@ describe HammerCLIForeman do
       }
 
       set = HammerCLIForeman.collection_to_common_format(new_format)
-      set.must_be_kind_of HammerCLI::Output::RecordCollection
-      set.first.must_equal(kind)
+      _(set).must_be_kind_of HammerCLI::Output::RecordCollection
+      _(set.first).must_equal(kind)
     end
 
     it "should rise error on unexpected format" do
-      proc { HammerCLIForeman.collection_to_common_format('unexpected') }.must_raise RuntimeError
+      _(proc { HammerCLIForeman.collection_to_common_format('unexpected') }).must_raise RuntimeError
     end
 
   end
@@ -67,14 +67,14 @@ describe HammerCLIForeman do
       }
 
       rec = HammerCLIForeman.record_to_common_format(old_format)
-      rec.must_equal(arch)
+      _(rec).must_equal(arch)
     end
 
     it "should convert common API format" do
       common_format = arch
 
       rec = HammerCLIForeman.record_to_common_format(common_format)
-      rec.must_equal(arch)
+      _(rec).must_equal(arch)
 
     end
   end
@@ -92,7 +92,7 @@ describe HammerCLIForeman do
       })
       arch = HammerCLIForeman::Architecture::CreateCommand.new("", { :adapter => :csv, :interactive => false })
       out, err = capture_io { arch.run(["--name='i386'"]) }
-      out.must_match("Message,Id,Name\nArchitecture created.,3,i386\n")
+      _(out).must_match("Message,Id,Name\nArchitecture created.,3,i386\n")
     end
   end
 
@@ -111,7 +111,7 @@ describe HammerCLIForeman do
       res.stubs(:get_identifier).returns(1)
       res.stubs(:get_associated_identifier).returns(1)
 
-      res.get_new_ids.sort.must_equal ['1', '2']
+      _(res.get_new_ids.sort).must_equal ['1', '2']
     end
 
     it "should associate resource with new format" do
@@ -128,7 +128,7 @@ describe HammerCLIForeman do
       res.stubs(:get_identifier).returns(1)
       res.stubs(:get_associated_identifier).returns(1)
 
-      res.get_new_ids.sort.must_equal ['1', '2']
+      _(res.get_new_ids.sort).must_equal ['1', '2']
     end
   end
 
@@ -152,7 +152,7 @@ describe HammerCLIForeman do
       end
       comm = DomainOuter::HostsCommand.new("", { :adapter => :csv, :interactive => false })
       out, err = capture_io { comm.run(["--id=5"]) }
-      out.must_equal "Id,Name,Operating System,Host Group,IP,MAC\n2,random-host,,,192.168.100.112,6e:4b:3c:2c:8a:0a\n"
+      _(out).must_equal "Id,Name,Operating System,Host Group,IP,MAC\n2,random-host,,,192.168.100.112,6e:4b:3c:2c:8a:0a\n"
     end
   end
 
@@ -163,7 +163,7 @@ describe HammerCLIForeman::Command do
 
   it "uses foreman option builder" do
     builder = HammerCLIForeman::Command.option_builder
-    builder.class.must_equal HammerCLIForeman::ForemanOptionBuilder
+    _(builder.class).must_equal HammerCLIForeman::ForemanOptionBuilder
   end
 
   it "properly raises error on intentional searching of parameters that are not required" do
@@ -181,9 +181,9 @@ describe HammerCLIForeman::Command do
       )
     )
     out, err = capture_io do
-      com.run(['--location', 'loc']).wont_equal HammerCLI::EX_OK
+      _(com.run(['--location', 'loc'])).wont_equal HammerCLI::EX_OK
     end
-    err.must_equal "Error: Could not find location, please set one of options --location, --location-title, --location-id.\n"
+    _(err).must_equal "Error: Could not find location, please set one of options --location, --location-title, --location-id.\n"
 
   end
 
@@ -205,7 +205,7 @@ describe HammerCLIForeman::Command do
     ResourceMocks.mock_action_call(:domains, :index, [])
 
     out, err = capture_io do
-      com.run([]).must_equal HammerCLI::EX_OK
+      _(com.run([])).must_equal HammerCLI::EX_OK
     end
 
   end
@@ -213,7 +213,7 @@ describe HammerCLIForeman::Command do
   describe "build_options" do
     it "uses build parameters in the block" do
       HammerCLIForeman::Command.build_options do |o|
-        o.class.must_equal HammerCLIForeman::BuildParams
+        _(o.class).must_equal HammerCLIForeman::BuildParams
       end
     end
   end
@@ -228,6 +228,6 @@ describe HammerCLIForeman::ListCommand do
   it 'formats enum values in search fields help' do
     search_field = { name: 'managed', values: [true, false] }
     expected_output = 'Values: true, false'
-    OpenListCommand.new({}).search_field_help_value(search_field).must_equal(expected_output)
+    _(OpenListCommand.new({}).search_field_help_value(search_field)).must_equal(expected_output)
   end
 end

data/test/unit/common_parameter_test.rb

@@ -31,7 +31,7 @@ describe HammerCLIForeman::CommonParameter do
 
   context "SetCommand" do
     before do
-      ResourceMocks.common_parameter_show
+      ResourceMocks.common_parameter_list
     end
 
     let(:cmd) { HammerCLIForeman::CommonParameter::SetCommand.new("", ctx) }

data/test/unit/compute_profile_test.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), 'test_helper')
+require File.join(File.dirname(__FILE__), 'apipie_resource_mock')
+
+require 'hammer_cli_foreman/compute_profile'
+
+describe HammerCLIForeman::ComputeProfile do
+  include CommandTestHelper
+
+  context 'ListCommand' do
+    before :each do
+      ResourceMocks.compute_profiles
+    end
+
+    let(:cmd) { HammerCLIForeman::ComputeProfile::ListCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'no arguments'
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+
+    context 'output' do
+      let(:expected_record_count) { count_records(cmd.resource.call(:index)) }
+
+      it_should_print_n_records
+      it_should_print_column 'Id'
+      it_should_print_column 'Name'
+    end
+  end
+
+  context 'InfoCommand' do
+    let(:cmd) { HammerCLIForeman::ComputeProfile::InfoCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=test']
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+
+    context 'output' do
+      with_params ['--id=1'] do
+        it_should_print_n_records 1
+        it_should_print_column 'Id'
+        it_should_print_column 'Name'
+        it_should_print_column 'Created at'
+        it_should_print_column 'Updated at'
+        it_should_print_column 'Compute attributes'
+      end
+    end
+  end
+
+  context 'CreateCommand' do
+    let(:cmd) { HammerCLIForeman::ComputeProfile::CreateCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'name', ['--name=test']
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+
+  end
+
+  context 'DeleteCommand' do
+    let(:cmd) { HammerCLIForeman::ComputeProfile::DeleteCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=test']
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+  end
+
+  context 'UpdateCommand' do
+    let(:cmd) { HammerCLIForeman::ComputeProfile::UpdateCommand.new('', ctx) }
+
+    context 'parameters' do
+      it_should_accept 'id', ['--id=1']
+      it_should_accept 'name', ['--name=test']
+      it_should_fail_with 'organization param', ['--organization-id=1']
+      it_should_fail_with 'location param', ['--location-id=1']
+    end
+  end
+end