halyard-puppet-lint 1.2.0

data/spec/puppet-lint/plugins/check_whitespace/hard_tabs_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+describe 'hard_tabs' do
+  let(:msg) { 'tab character found' }
+
+  context 'with fix disabled' do
+    context 'hard tabs indents' do
+      let(:code) { "\tfoo => bar," }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create an error' do
+        expect(problems).to contain_error(msg).on_line(1).in_column(1)
+      end
+    end
+  end
+
+  context 'with fix enabled' do
+    before do
+      PuppetLint.configuration.fix = true
+    end
+
+    after do
+      PuppetLint.configuration.fix = false
+    end
+
+    context 'hard tabs indents' do
+      let(:code) { "\tfoo => bar," }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(1)
+      end
+
+      it 'should convert the tab characters into spaces' do
+        expect(manifest).to eq("  foo => bar,")
+      end
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_whitespace/trailing_whitespace_spec.rb

@@ -0,0 +1,101 @@
+require 'spec_helper'
+
+describe 'trailing_whitespace' do
+  let(:msg) { 'trailing whitespace found' }
+
+  context 'with fix disabled' do
+    context 'line with trailing whitespace' do
+      let(:code) { "foo " }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create an error' do
+        expect(problems).to contain_error(msg).on_line(1).in_column(4)
+      end
+    end
+
+    context 'line without code and trailing whitespace' do
+      let(:code) { "
+class {
+  
+}
+" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create an error' do
+        expect(problems).to contain_error(msg).on_line(3).in_column(1)
+      end
+    end
+  end
+
+  context 'with fix enabled' do
+    before do
+      PuppetLint.configuration.fix = true
+    end
+
+    after do
+      PuppetLint.configuration.fix = false
+    end
+
+    context 'single line with trailing whitespace' do
+      let(:code) { "foo " }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(4)
+      end
+
+      it 'should remove the trailing whitespace' do
+        expect(manifest).to eq('foo')
+      end
+    end
+
+    context 'multiple lines with trailing whitespace' do
+      let(:code) { "foo    \nbar" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(4)
+      end
+
+      it 'should remove the trailing whitespace' do
+        expect(manifest).to eq("foo\nbar")
+      end
+    end
+
+    context 'line without code and trailing whitespace' do
+      let(:code) { "
+class foo {
+  
+}
+" }
+      let(:fixed) { "
+class foo {
+
+}
+" }
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create an error' do
+        expect(problems).to contain_fixed(msg).on_line(3).in_column(1)
+      end
+
+      it 'should remove the trailing whitespace' do
+        expect(manifest).to eq(fixed)
+      end
+    end
+  end
+end

data/spec/puppet-lint_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe PuppetLint do
+  subject { PuppetLint.new }
+
+  it 'should accept manifests as a string' do
+    subject.code = "class foo { }"
+    expect(subject.code).to_not be_nil
+  end
+
+  it 'should have support for % with a hash' do
+    string = 'replace %{hash}' % {:hash => 'replaced'}
+    expect(string).to match('replace replaced')
+  end
+
+  it 'should not break regular % support' do
+    string = 'replace %s %s' % ['get','replaced']
+    expect(string).to match('replace get replaced')
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,129 @@
+require 'puppet-lint'
+require 'rspec/its'
+require 'rspec/collection_matchers'
+
+module RSpec
+  module LintExampleGroup
+    class HaveProblem
+      def initialize(method, message)
+        @expected_problem = {
+          :kind    => method.to_s.gsub(/\Acontain_/, '').to_sym,
+          :message => message,
+        }
+        @description = ["contain a #{@expected_problem[:kind]}"]
+      end
+
+      def on_line(line)
+        @expected_problem[:line] = line
+        @description << "on line #{line}"
+        self
+      end
+
+      def in_column(column)
+        @expected_problem[:column] = column
+        @description << "starting in column #{column}"
+        self
+      end
+
+      def with_reason(reason)
+        @expected_problem[:reason] = reason
+        @description << "with reason '#{reason}'"
+        self
+      end
+
+      def matches?(problems)
+        @problems = problems
+
+        problems.any? do |problem|
+          ret = true
+          @expected_problem.each do |key, value|
+            if !problem.key?(key)
+              ret = false
+              break
+            elsif problem[key] != value
+              ret = false
+              break
+            end
+          end
+          ret
+        end
+      end
+
+      def description
+        @description.join(' ')
+      end
+
+      def check_attr(attr, prefix)
+        unless @expected_problem[attr] == @problems.first[attr]
+          expected = @expected_problem[attr].inspect
+          actual = @problems.first[attr].inspect
+          "#{prefix} #{expected}, but it was #{actual}"
+        end
+      end
+
+      def failure_message
+        case @problems.length
+        when 0
+          "expected that the check would create a problem but it did not"
+        when 1
+          messages = ["expected that the problem"]
+
+          messages << check_attr(:kind, 'would be of kind')
+          messages << check_attr(:message, 'would have the message')
+          messages << check_attr(:linenumber, 'would be on line')
+          messages << check_attr(:column, 'would start on column')
+
+          messages.compact.join("\n  ")
+        else
+          [
+            "expected that the check would create",
+            PP.pp(@expected_problem, '').strip,
+            "but it instead created",
+            PP.pp(@problems, ''),
+          ].join("\n")
+        end
+      end
+
+      def failure_message_when_negated
+        "expected that the check would not create the problem, but it did"
+      end
+    end
+
+    def method_missing(method, *args, &block)
+      return HaveProblem.new(method, args.first) if method.to_s =~ /\Acontain_/
+      super
+    end
+
+    def problems
+      subject.problems
+    end
+
+    def manifest
+      subject.manifest
+    end
+
+    def subject
+      klass = PuppetLint::Checks.new
+      filepath = self.respond_to?(:path) ? path : ''
+      klass.load_data(filepath, code)
+      check_name = self.class.top_level_description.to_sym
+      check = PuppetLint.configuration.check_object[check_name].new
+      klass.problems = check.run
+      if PuppetLint.configuration.fix
+        klass.problems = check.fix_problems
+      end
+      klass
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.mock_framework = :rspec
+  config.include RSpec::LintExampleGroup, {
+    :type      => :lint,
+    :file_path => Regexp.compile(%w{spec puppet-lint plugins}.join('[\\\/]')),
+  }
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end

metadata

@@ -0,0 +1,229 @@
+--- !ruby/object:Gem::Specification
+name: halyard-puppet-lint
+version: !ruby/object:Gem::Version
+  version: 1.2.0
+platform: ruby
+authors:
+- Tim Sharpe
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2015-10-07 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-collection_matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+description: |-
+  Checks your Puppet manifests against the Puppetlabs
+    style guide and alerts you to any discrepancies.
+email: tim@sharpe.id.au
+executables:
+- puppet-lint
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- ".travis.yml"
+- Gemfile
+- LICENSE
+- README.md
+- Rakefile
+- bin/puppet-lint
+- lib/puppet-lint.rb
+- lib/puppet-lint/bin.rb
+- lib/puppet-lint/checkplugin.rb
+- lib/puppet-lint/checks.rb
+- lib/puppet-lint/configuration.rb
+- lib/puppet-lint/data.rb
+- lib/puppet-lint/lexer.rb
+- lib/puppet-lint/lexer/token.rb
+- lib/puppet-lint/monkeypatches.rb
+- lib/puppet-lint/monkeypatches/string_percent.rb
+- lib/puppet-lint/monkeypatches/string_prepend.rb
+- lib/puppet-lint/optparser.rb
+- lib/puppet-lint/plugins.rb
+- lib/puppet-lint/plugins/check_classes.rb
+- lib/puppet-lint/plugins/check_comments.rb
+- lib/puppet-lint/plugins/check_conditionals.rb
+- lib/puppet-lint/plugins/check_documentation.rb
+- lib/puppet-lint/plugins/check_nodes.rb
+- lib/puppet-lint/plugins/check_resources.rb
+- lib/puppet-lint/plugins/check_strings.rb
+- lib/puppet-lint/plugins/check_variables.rb
+- lib/puppet-lint/plugins/check_whitespace.rb
+- lib/puppet-lint/tasks/puppet-lint.rb
+- lib/puppet-lint/version.rb
+- puppet-lint.gemspec
+- spec/fixtures/test/manifests/fail.pp
+- spec/fixtures/test/manifests/ignore.pp
+- spec/fixtures/test/manifests/ignore_multiple_block.pp
+- spec/fixtures/test/manifests/ignore_multiple_line.pp
+- spec/fixtures/test/manifests/ignore_reason.pp
+- spec/fixtures/test/manifests/init.pp
+- spec/fixtures/test/manifests/malformed.pp
+- spec/fixtures/test/manifests/url_interpolation.pp
+- spec/fixtures/test/manifests/warning.pp
+- spec/puppet-lint/bin_spec.rb
+- spec/puppet-lint/configuration_spec.rb
+- spec/puppet-lint/ignore_overrides_spec.rb
+- spec/puppet-lint/lexer/token_spec.rb
+- spec/puppet-lint/lexer_spec.rb
+- spec/puppet-lint/plugins/check_classes/autoloader_layout_spec.rb
+- spec/puppet-lint/plugins/check_classes/class_inherits_from_params_class_spec.rb
+- spec/puppet-lint/plugins/check_classes/inherits_across_namespaces_spec.rb
+- spec/puppet-lint/plugins/check_classes/names_containing_dash_spec.rb
+- spec/puppet-lint/plugins/check_classes/nested_classes_or_defines_spec.rb
+- spec/puppet-lint/plugins/check_classes/parameter_order_spec.rb
+- spec/puppet-lint/plugins/check_classes/right_to_left_relationship_spec.rb
+- spec/puppet-lint/plugins/check_classes/variable_scope_spec.rb
+- spec/puppet-lint/plugins/check_comments/slash_comments_spec.rb
+- spec/puppet-lint/plugins/check_comments/star_comments_spec.rb
+- spec/puppet-lint/plugins/check_conditionals/case_without_default_spec.rb
+- spec/puppet-lint/plugins/check_conditionals/selector_inside_resource_spec.rb
+- spec/puppet-lint/plugins/check_documentation/documentation_spec.rb
+- spec/puppet-lint/plugins/check_nodes/unquoted_node_name_spec.rb
+- spec/puppet-lint/plugins/check_resources/duplicate_params_spec.rb
+- spec/puppet-lint/plugins/check_resources/ensure_first_param_spec.rb
+- spec/puppet-lint/plugins/check_resources/ensure_not_symlink_target_spec.rb
+- spec/puppet-lint/plugins/check_resources/file_mode_spec.rb
+- spec/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb
+- spec/puppet-lint/plugins/check_resources/unquoted_resource_title_spec.rb
+- spec/puppet-lint/plugins/check_strings/double_quoted_strings_spec.rb
+- spec/puppet-lint/plugins/check_strings/only_variable_string_spec.rb
+- spec/puppet-lint/plugins/check_strings/puppet_url_without_modules_spec.rb
+- spec/puppet-lint/plugins/check_strings/quoted_booleans_spec.rb
+- spec/puppet-lint/plugins/check_strings/single_quote_string_with_variables_spec.rb
+- spec/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb
+- spec/puppet-lint/plugins/check_variables/variable_contains_dash_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/2sp_soft_tabs_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/80chars_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/arrow_alignment_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/hard_tabs_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/trailing_whitespace_spec.rb
+- spec/puppet-lint_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/rodjek/puppet-lint/
+licenses: []
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.4.5.1
+signing_key: 
+specification_version: 4
+summary: Ensure your Puppet manifests conform with the Puppetlabs style guide
+test_files:
+- spec/fixtures/test/manifests/fail.pp
+- spec/fixtures/test/manifests/ignore.pp
+- spec/fixtures/test/manifests/ignore_multiple_block.pp
+- spec/fixtures/test/manifests/ignore_multiple_line.pp
+- spec/fixtures/test/manifests/ignore_reason.pp
+- spec/fixtures/test/manifests/init.pp
+- spec/fixtures/test/manifests/malformed.pp
+- spec/fixtures/test/manifests/url_interpolation.pp
+- spec/fixtures/test/manifests/warning.pp
+- spec/puppet-lint/bin_spec.rb
+- spec/puppet-lint/configuration_spec.rb
+- spec/puppet-lint/ignore_overrides_spec.rb
+- spec/puppet-lint/lexer/token_spec.rb
+- spec/puppet-lint/lexer_spec.rb
+- spec/puppet-lint/plugins/check_classes/autoloader_layout_spec.rb
+- spec/puppet-lint/plugins/check_classes/class_inherits_from_params_class_spec.rb
+- spec/puppet-lint/plugins/check_classes/inherits_across_namespaces_spec.rb
+- spec/puppet-lint/plugins/check_classes/names_containing_dash_spec.rb
+- spec/puppet-lint/plugins/check_classes/nested_classes_or_defines_spec.rb
+- spec/puppet-lint/plugins/check_classes/parameter_order_spec.rb
+- spec/puppet-lint/plugins/check_classes/right_to_left_relationship_spec.rb
+- spec/puppet-lint/plugins/check_classes/variable_scope_spec.rb
+- spec/puppet-lint/plugins/check_comments/slash_comments_spec.rb
+- spec/puppet-lint/plugins/check_comments/star_comments_spec.rb
+- spec/puppet-lint/plugins/check_conditionals/case_without_default_spec.rb
+- spec/puppet-lint/plugins/check_conditionals/selector_inside_resource_spec.rb
+- spec/puppet-lint/plugins/check_documentation/documentation_spec.rb
+- spec/puppet-lint/plugins/check_nodes/unquoted_node_name_spec.rb
+- spec/puppet-lint/plugins/check_resources/duplicate_params_spec.rb
+- spec/puppet-lint/plugins/check_resources/ensure_first_param_spec.rb
+- spec/puppet-lint/plugins/check_resources/ensure_not_symlink_target_spec.rb
+- spec/puppet-lint/plugins/check_resources/file_mode_spec.rb
+- spec/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb
+- spec/puppet-lint/plugins/check_resources/unquoted_resource_title_spec.rb
+- spec/puppet-lint/plugins/check_strings/double_quoted_strings_spec.rb
+- spec/puppet-lint/plugins/check_strings/only_variable_string_spec.rb
+- spec/puppet-lint/plugins/check_strings/puppet_url_without_modules_spec.rb
+- spec/puppet-lint/plugins/check_strings/quoted_booleans_spec.rb
+- spec/puppet-lint/plugins/check_strings/single_quote_string_with_variables_spec.rb
+- spec/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb
+- spec/puppet-lint/plugins/check_variables/variable_contains_dash_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/2sp_soft_tabs_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/80chars_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/arrow_alignment_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/hard_tabs_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/trailing_whitespace_spec.rb
+- spec/puppet-lint_spec.rb
+- spec/spec_helper.rb