halyard-puppet-lint 1.2.0

data/spec/puppet-lint/plugins/check_resources/duplicate_params_spec.rb

@@ -0,0 +1,100 @@
+require 'spec_helper'
+
+describe 'duplicate_params' do
+  let(:msg) { 'duplicate parameter found in resource' }
+
+  context 'resource with duplicate parameters' do
+    let(:code) { "
+      file { '/tmp/foo':
+        ensure => present,
+        foo => bar,
+        baz => gronk,
+        foo => meh,
+      }"
+    }
+
+    it 'should only detect a single problem' do
+      expect(problems).to have(1).problem
+    end
+
+    it 'should create an error' do
+      expect(problems).to contain_error(msg).on_line(6).in_column(9)
+    end
+  end
+
+  context 'bug #145: resource with a hash and no duplicate parameters' do
+    let(:code) { "
+      class {'fooname':
+        hashes => [
+          { foo => 'bar01',},
+          { foo => 'bar02', },
+        ],
+      }"
+    }
+
+    it 'should not detect any errors' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'bug #145: resource with a hash and duplicate parameters in subhash' do
+    let(:code) { "
+      class {'fooname':
+        hashes => [
+          { foo => 'bar01',
+            foo => 'bar02', },
+        ],
+      }"
+    }
+
+    it 'should only detect a single error' do
+      expect(problems).to have(1).problem
+    end
+
+    it 'should create an error' do
+      expect(problems).to contain_error(msg).on_line(5).in_column(13)
+    end
+  end
+
+  context 'bug #145: resource with a hash and duplicate parameters in parent type' do
+    let(:code) { "
+      class {'fooname':
+        hashes    => [
+          { foo     => 'bar01', },
+          { foo     => 'bar02', },
+        ],
+        something => { hash => 'mini', },
+        hashes    => 'dupe',
+      }"
+    }
+
+    it 'should only detect a single problem' do
+      expect(problems).to have(1).problem
+    end
+
+    it 'should create an error' do
+      expect(problems).to contain_error(msg).on_line(8).in_column(9)
+    end
+  end
+
+  describe 'bug #145: more hash tests and no duplicate parameters' do
+    let(:code) { "
+      class test {
+        $foo = { param => 'value', }
+        $bar = { param => 'bar', }
+      }"
+    }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'colon as last token in file' do
+    let(:code) { "}:" }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_resources/ensure_first_param_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe 'ensure_first_param' do
+  let(:msg) { "ensure found on line but it's not the first attribute" }
+
+  context 'ensure as only attr in a single line resource' do
+    let(:code) { "file { 'foo': ensure => present }" }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'ensure as only attr in a multi line resource' do
+    let(:code) { "
+      file { 'foo':
+        ensure => present,
+      }"
+    }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+
+  context 'ensure as second attr in a multi line resource' do
+    let(:code) { "
+      file { 'foo':
+        mode   => '0000',
+        ensure => present,
+      }"
+    }
+
+    it 'should only detect a single problem' do
+      expect(problems).to have(1).problem
+    end
+
+    it 'should create a warning' do
+      expect(problems).to contain_warning(msg).on_line(4).in_column(9)
+    end
+  end
+
+  context 'ensure as first attr in a multi line resource' do
+    let(:code) { "
+      file { 'foo':
+        ensure => present,
+        mode   => '0000',
+      }"
+    }
+
+    it 'should not detect any problems' do
+      expect(problems).to have(0).problems
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_resources/ensure_not_symlink_target_spec.rb

@@ -0,0 +1,89 @@
+require 'spec_helper'
+
+describe 'ensure_not_symlink_target' do
+  let(:msg) { 'symlink target specified in ensure attr' }
+
+  context 'with fix disabled' do
+    context 'file resource creating a symlink with seperate target attr' do
+      let(:code) { "
+        file { 'foo':
+          ensure => link,
+          target => '/foo/bar',
+        }"
+      }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'file resource creating a symlink with target specified in ensure' do
+      let(:code) { "
+        file { 'foo':
+          ensure => '/foo/bar',
+        }"
+      }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(3).in_column(21)
+      end
+    end
+  end
+
+  context 'with fix enabled' do
+    before do
+      PuppetLint.configuration.fix = true
+    end
+
+    after do
+      PuppetLint.configuration.fix = false
+    end
+
+    context 'file resource creating a symlink with seperate target attr' do
+      let(:code) { "
+        file { 'foo':
+          ensure => link,
+          target => '/foo/bar',
+        }"
+      }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+
+      it 'should not modify the manifest' do
+        expect(manifest).to eq(code)
+      end
+    end
+
+    context 'file resource creating a symlink with target specified in ensure' do
+      let(:code) { "
+        file { 'foo':
+          ensure => '/foo/bar',
+        }"
+      }
+      let(:fixed) { "
+        file { 'foo':
+          ensure => symlink,
+          target => '/foo/bar',
+        }"
+      }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the problem' do
+        expect(problems).to contain_fixed(msg).on_line(3).in_column(21)
+      end
+
+      it 'should create a new target param' do
+        expect(manifest).to eq(fixed)
+      end
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_resources/file_mode_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+
+describe 'file_mode' do
+  let(:msg) { 'mode should be represented as a 4 digit octal value or symbolic mode' }
+
+  context 'with fix disabled' do
+    context '3 digit file mode' do
+      let(:code) { "file { 'foo': mode => '777' }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(1).in_column(23)
+      end
+    end
+
+    context '4 digit file mode' do
+      let(:code) { "file { 'foo': mode => '0777' }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'file mode as a variable' do
+      let(:code) { "file { 'foo': mode => $file_mode }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'symbolic file mode' do
+      let(:code) { "file { 'foo': mode => 'u=rw,og=r' }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'file mode undef unquoted' do
+      let(:code) { "file { 'foo': mode => undef }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'file mode undef quoted' do
+      let(:code) { "file { 'foo': mode => 'undef' }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(1).in_column(23)
+      end
+    end
+
+    context 'mode as audit value' do
+      let(:code) { "file { '/etc/passwd': audit => [ owner, mode ], }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+  end
+
+  context 'with fix enabled' do
+    before do
+      PuppetLint.configuration.fix = true
+    end
+
+    after do
+      PuppetLint.configuration.fix = false
+    end
+
+    context '3 digit file mode' do
+      let(:code) { "file { 'foo': mode => '777' }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(23)
+      end
+
+      it 'should zero pad the file mode' do
+        expect(manifest).to eq("file { 'foo': mode => '0777' }")
+      end
+    end
+
+    context 'file mode undef quoted' do
+      let(:code) { "file { 'foo': mode => 'undef' }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(1).in_column(23)
+      end
+
+      it 'should not modify the original manifest' do
+        expect(manifest).to eq(code)
+      end
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+describe 'unquoted_file_mode' do
+  let(:msg) { 'unquoted file mode' }
+
+  context 'with fix disabled' do
+    context '4 digit unquoted file mode' do
+      let(:code) { "file { 'foo': mode => 0777 }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(1).in_column(23)
+      end
+    end
+  end
+
+  context 'with fix enabled' do
+    before do
+      PuppetLint.configuration.fix = true
+    end
+
+    after do
+      PuppetLint.configuration.fix = false
+    end
+
+    context '4 digit unquoted file mode w/fix' do
+      let(:code) { "file { 'foo': mode => 0777 }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(23)
+      end
+
+      it 'should single quote the file mode' do
+        expect(manifest).to eq("file { 'foo': mode => '0777' }")
+      end
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_resources/unquoted_resource_title_spec.rb

@@ -0,0 +1,216 @@
+require 'spec_helper'
+
+describe 'unquoted_resource_title' do
+  let(:msg) { 'unquoted resource title' }
+
+  context 'with fix disabled' do
+    context 'quoted resource title on single line resource' do
+      let(:code) { "file { 'foo': }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'unquoted resource title on single line resource' do
+      let(:code) { "file { foo: }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(1).in_column(8)
+      end
+    end
+
+    context 'quoted resource title on multi line resource' do
+      let(:code) { "
+        file { 'foo':
+        }"
+      }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'unquoted resource title on multi line resource' do
+      let(:code) { "
+        file { foo:
+        }"
+      }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(2).in_column(16)
+      end
+    end
+
+    context 'condensed resources with quoted titles' do
+      let(:code) { "
+        file {
+          'foo': ;
+          'bar': ;
+        }"
+      }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'condensed resources with an unquoted title' do
+      let(:code) { "
+        file {
+          'foo': ;
+          bar: ;
+        }"
+      }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should create a warning' do
+        expect(problems).to contain_warning(msg).on_line(4).in_column(11)
+      end
+    end
+
+    context 'single line resource with an array of titles (all quoted)' do
+      let(:code) { "file { ['foo', 'bar']: }" }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'resource inside a case statement' do
+      let(:code) { "
+        case $ensure {
+          'absent': {
+            file { \"some_file_${name}\":
+              ensure => absent,
+            }
+          }
+        }"
+      }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'issue #116' do
+      let(:code) { "
+        $config_file_init = $::operatingsystem ? {
+          /(?i:Debian|Ubuntu|Mint)/ => '/etc/default/foo',
+          default                   => '/etc/sysconfig/foo',
+        }"
+      }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+
+    context 'case statement' do
+      let(:code) { %{
+        case $operatingsystem {
+          centos: {
+            $version = '1.2.3'
+          }
+          solaris: {
+            $version = '3.2.1'
+          }
+          default: {
+            fail("Module ${module_name} is not supported on ${operatingsystem}")
+          }
+        }}
+      }
+
+      it 'should not detect any problems' do
+        expect(problems).to have(0).problems
+      end
+    end
+  end
+
+  context 'with fix enabled' do
+    before do
+      PuppetLint.configuration.fix = true
+    end
+
+    after do
+      PuppetLint.configuration.fix = false
+    end
+
+    context 'unquoted resource title on single line resource' do
+      let(:code) { "file { foo: }" }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(1).in_column(8)
+      end
+
+      it 'should single quote the resource title' do
+        expect(manifest).to eq("file { 'foo': }")
+      end
+    end
+
+    context 'unquoted resource title on multi line resource' do
+      let(:code) { "
+        file { foo:
+        }"
+      }
+      let(:fixed) { "
+        file { 'foo':
+        }"
+      }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(2).in_column(16)
+      end
+
+      it 'should single quote the resource title' do
+        expect(manifest).to eq(fixed)
+      end
+    end
+
+    context 'condensed resources with an unquoted title' do
+      let(:code) { "
+        file {
+          'foo': ;
+          bar: ;
+        }"
+      }
+      let(:fixed) { "
+        file {
+          'foo': ;
+          'bar': ;
+        }"
+      }
+
+      it 'should only detect a single problem' do
+        expect(problems).to have(1).problem
+      end
+
+      it 'should fix the manifest' do
+        expect(problems).to contain_fixed(msg).on_line(4).in_column(11)
+      end
+
+      it 'should single quote the resource title' do
+        expect(manifest).to eq(fixed)
+      end
+    end
+  end
+end