grpc 1.64.3 → 1.70.1

data/third_party/boringssl-with-bazel/src/ssl/extensions.cc

@@ -175,7 +175,7 @@ static bool tls1_check_duplicate_extensions(const CBS *cbs) {
   }
 
   Array<uint16_t> extension_types;
-  if (!extension_types.Init(num_extensions)) {
+  if (!extension_types.InitForOverwrite(num_extensions)) {
     return false;
   }
 
@@ -207,6 +207,7 @@ static bool tls1_check_duplicate_extensions(const CBS *cbs) {
 static bool is_post_quantum_group(uint16_t id) {
   switch (id) {
     case SSL_GROUP_X25519_KYBER768_DRAFT00:
+    case SSL_GROUP_X25519_MLKEM768:
       return true;
     default:
       return false;
@@ -242,12 +243,16 @@ bool ssl_parse_client_hello_with_trailing_data(const SSL *ssl, CBS *cbs,
   out->session_id = CBS_data(&session_id);
   out->session_id_len = CBS_len(&session_id);
 
-  // Skip past DTLS cookie
   if (SSL_is_dtls(out->ssl)) {
     CBS cookie;
     if (!CBS_get_u8_length_prefixed(cbs, &cookie)) {
       return false;
     }
+    out->dtls_cookie = CBS_data(&cookie);
+    out->dtls_cookie_len = CBS_len(&cookie);
+  } else {
+    out->dtls_cookie = nullptr;
+    out->dtls_cookie_len = 0;
   }
 
   CBS cipher_suites, compression_methods;
@@ -441,16 +446,18 @@ bool tls12_add_verify_sigalgs(const SSL_HANDSHAKE *hs, CBB *out) {
 }
 
 bool tls12_check_peer_sigalg(const SSL_HANDSHAKE *hs, uint8_t *out_alert,
-                             uint16_t sigalg) {
-  for (uint16_t verify_sigalg : tls12_get_verify_sigalgs(hs)) {
-    if (verify_sigalg == sigalg) {
-      return true;
-    }
+                             uint16_t sigalg, EVP_PKEY *pkey) {
+  // The peer must have selected an algorithm that is consistent with its public
+  // key, the TLS version, and what we advertised.
+  Span<const uint16_t> sigalgs = tls12_get_verify_sigalgs(hs);
+  if (std::find(sigalgs.begin(), sigalgs.end(), sigalg) == sigalgs.end() ||
+      !ssl_pkey_supports_algorithm(hs->ssl, pkey, sigalg, /*is_verify=*/true)) {
+    OPENSSL_PUT_ERROR(SSL, SSL_R_WRONG_SIGNATURE_TYPE);
+    *out_alert = SSL_AD_ILLEGAL_PARAMETER;
+    return false;
   }
 
-  OPENSSL_PUT_ERROR(SSL, SSL_R_WRONG_SIGNATURE_TYPE);
-  *out_alert = SSL_AD_ILLEGAL_PARAMETER;
-  return false;
+  return true;
 }
 
 // tls_extension represents a TLS extension that is handled internally.
@@ -510,9 +517,7 @@ static bool ignore_parse_clienthello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
   return true;
 }
 
-static bool dont_add_serverhello(SSL_HANDSHAKE *hs, CBB *out) {
-  return true;
-}
+static bool dont_add_serverhello(SSL_HANDSHAKE *hs, CBB *out) { return true; }
 
 // Server name indication (SNI).
 //
@@ -563,7 +568,7 @@ static bool ext_sni_parse_clienthello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
 }
 
 static bool ext_sni_add_serverhello(SSL_HANDSHAKE *hs, CBB *out) {
-  if (hs->ssl->s3->session_reused ||
+  if (hs->ssl->s3->session_reused ||  //
       !hs->should_ack_sni) {
     return true;
   }
@@ -700,20 +705,20 @@ static bool ext_ri_add_clienthello(const SSL_HANDSHAKE *hs, CBB *out,
                                    ssl_client_hello_type_t type) {
   const SSL *const ssl = hs->ssl;
   // Renegotiation indication is not necessary in TLS 1.3.
-  if (hs->min_version >= TLS1_3_VERSION ||
-     type == ssl_client_hello_inner) {
+  if (hs->min_version >= TLS1_3_VERSION ||  //
+      type == ssl_client_hello_inner) {
     return true;
   }
 
   assert(ssl->s3->initial_handshake_complete ==
-         (ssl->s3->previous_client_finished_len != 0));
+         !ssl->s3->previous_client_finished.empty());
 
   CBB contents, prev_finished;
   if (!CBB_add_u16(out, TLSEXT_TYPE_renegotiate) ||
       !CBB_add_u16_length_prefixed(out, &contents) ||
       !CBB_add_u8_length_prefixed(&contents, &prev_finished) ||
-      !CBB_add_bytes(&prev_finished, ssl->s3->previous_client_finished,
-                     ssl->s3->previous_client_finished_len) ||
+      !CBB_add_bytes(&prev_finished, ssl->s3->previous_client_finished.data(),
+                     ssl->s3->previous_client_finished.size()) ||
       !CBB_flush(out)) {
     return false;
   }
@@ -749,16 +754,11 @@ static bool ext_ri_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
     return true;
   }
 
-  const size_t expected_len = ssl->s3->previous_client_finished_len +
-                              ssl->s3->previous_server_finished_len;
-
-  // Check for logic errors
-  assert(!expected_len || ssl->s3->previous_client_finished_len);
-  assert(!expected_len || ssl->s3->previous_server_finished_len);
-  assert(ssl->s3->initial_handshake_complete ==
-         (ssl->s3->previous_client_finished_len != 0));
+  // Check for logic errors.
+  assert(ssl->s3->previous_client_finished.size() ==
+         ssl->s3->previous_server_finished.size());
   assert(ssl->s3->initial_handshake_complete ==
-         (ssl->s3->previous_server_finished_len != 0));
+         !ssl->s3->previous_client_finished.empty());
 
   // Parse out the extension contents.
   CBS renegotiated_connection;
@@ -770,15 +770,22 @@ static bool ext_ri_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
   }
 
   // Check that the extension matches.
-  if (CBS_len(&renegotiated_connection) != expected_len) {
+  CBS client_verify, server_verify;
+  if (!CBS_get_bytes(&renegotiated_connection, &client_verify,
+                     ssl->s3->previous_client_finished.size()) ||
+      !CBS_get_bytes(&renegotiated_connection, &server_verify,
+                     ssl->s3->previous_server_finished.size()) ||
+      CBS_len(&renegotiated_connection) != 0) {
     OPENSSL_PUT_ERROR(SSL, SSL_R_RENEGOTIATION_MISMATCH);
     *out_alert = SSL_AD_HANDSHAKE_FAILURE;
     return false;
   }
 
-  const uint8_t *d = CBS_data(&renegotiated_connection);
-  bool ok = CRYPTO_memcmp(d, ssl->s3->previous_client_finished,
-                          ssl->s3->previous_client_finished_len) == 0;
+  bool ok =
+      CBS_mem_equal(&client_verify, ssl->s3->previous_client_finished.data(),
+                    ssl->s3->previous_client_finished.size()) &&
+      CBS_mem_equal(&server_verify, ssl->s3->previous_server_finished.data(),
+                    ssl->s3->previous_server_finished.size());
 #if defined(BORINGSSL_UNSAFE_FUZZER_MODE)
   ok = true;
 #endif
@@ -787,20 +794,8 @@ static bool ext_ri_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
     *out_alert = SSL_AD_HANDSHAKE_FAILURE;
     return false;
   }
-  d += ssl->s3->previous_client_finished_len;
 
-  ok = CRYPTO_memcmp(d, ssl->s3->previous_server_finished,
-                     ssl->s3->previous_server_finished_len) == 0;
-#if defined(BORINGSSL_UNSAFE_FUZZER_MODE)
-  ok = true;
-#endif
-  if (!ok) {
-    OPENSSL_PUT_ERROR(SSL, SSL_R_RENEGOTIATION_MISMATCH);
-    *out_alert = SSL_AD_HANDSHAKE_FAILURE;
-    return false;
-  }
   ssl->s3->send_connection_binding = true;
-
   return true;
 }
 
@@ -884,7 +879,7 @@ static bool ext_ems_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
   SSL *const ssl = hs->ssl;
 
   if (contents != NULL) {
-    if (ssl_protocol_version(ssl) >= TLS1_3_VERSION ||
+    if (ssl_protocol_version(ssl) >= TLS1_3_VERSION ||  //
         CBS_len(contents) != 0) {
       return false;
     }
@@ -950,17 +945,14 @@ static bool ext_ticket_add_clienthello(const SSL_HANDSHAKE *hs, CBB *out,
     return true;
   }
 
-  Span<const uint8_t> ticket;
-
   // Renegotiation does not participate in session resumption. However, still
   // advertise the extension to avoid potentially breaking servers which carry
   // over the state from the previous handshake, such as OpenSSL servers
   // without upstream's 3c3f0259238594d77264a78944d409f2127642c4.
-  if (!ssl->s3->initial_handshake_complete &&
+  Span<const uint8_t> ticket;
+  if (!ssl->s3->initial_handshake_complete &&  //
       ssl->session != nullptr &&
-      !ssl->session->ticket.empty() &&
-      // Don't send TLS 1.3 session tickets in the ticket extension.
-      ssl_session_protocol_version(ssl->session.get()) < TLS1_3_VERSION) {
+      ssl_session_get_type(ssl->session.get()) == SSLSessionType::kTicket) {
     ticket = ssl->session->ticket;
   }
 
@@ -1196,7 +1188,7 @@ static bool ext_npn_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
 
   while (CBS_len(contents) != 0) {
     CBS proto;
-    if (!CBS_get_u8_length_prefixed(contents, &proto) ||
+    if (!CBS_get_u8_length_prefixed(contents, &proto) ||  //
         CBS_len(&proto) == 0) {
       return false;
     }
@@ -1230,9 +1222,9 @@ static bool ext_npn_parse_clienthello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
     return false;
   }
 
-  if (contents == NULL ||
-      ssl->s3->initial_handshake_complete ||
-      ssl->ctx->next_protos_advertised_cb == NULL ||
+  if (contents == NULL ||                             //
+      ssl->s3->initial_handshake_complete ||          //
+      ssl->ctx->next_protos_advertised_cb == NULL ||  //
       SSL_is_dtls(ssl)) {
     return true;
   }
@@ -1260,9 +1252,9 @@ static bool ext_npn_add_serverhello(SSL_HANDSHAKE *hs, CBB *out) {
   }
 
   CBB contents;
-  if (!CBB_add_u16(out, TLSEXT_TYPE_next_proto_neg) ||
-      !CBB_add_u16_length_prefixed(out, &contents) ||
-      !CBB_add_bytes(&contents, npa, npa_len) ||
+  if (!CBB_add_u16(out, TLSEXT_TYPE_next_proto_neg) ||  //
+      !CBB_add_u16_length_prefixed(out, &contents) ||   //
+      !CBB_add_bytes(&contents, npa, npa_len) ||        //
       !CBB_flush(out)) {
     return false;
   }
@@ -1373,7 +1365,7 @@ static bool ext_alpn_add_clienthello(const SSL_HANDSHAKE *hs, CBB *out,
                                      CBB *out_compressible,
                                      ssl_client_hello_type_t type) {
   const SSL *const ssl = hs->ssl;
-  if (hs->config->alpn_client_proto_list.empty() && ssl->quic_method) {
+  if (hs->config->alpn_client_proto_list.empty() && SSL_is_quic(ssl)) {
     // ALPN MUST be used with QUIC.
     OPENSSL_PUT_ERROR(SSL, SSL_R_NO_APPLICATION_PROTOCOL);
     return false;
@@ -1402,7 +1394,7 @@ static bool ext_alpn_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
                                        CBS *contents) {
   SSL *const ssl = hs->ssl;
   if (contents == NULL) {
-    if (ssl->quic_method) {
+    if (SSL_is_quic(ssl)) {
       // ALPN is required when QUIC is used.
       OPENSSL_PUT_ERROR(SSL, SSL_R_NO_APPLICATION_PROTOCOL);
       *out_alert = SSL_AD_NO_APPLICATION_PROTOCOL;
@@ -1424,11 +1416,11 @@ static bool ext_alpn_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
   // The extension data consists of a ProtocolNameList which must have
   // exactly one ProtocolName. Each of these is length-prefixed.
   CBS protocol_name_list, protocol_name;
-  if (!CBS_get_u16_length_prefixed(contents, &protocol_name_list) ||
-      CBS_len(contents) != 0 ||
-      !CBS_get_u8_length_prefixed(&protocol_name_list, &protocol_name) ||
+  if (!CBS_get_u16_length_prefixed(contents, &protocol_name_list) ||       //
+      CBS_len(contents) != 0 ||                                            //
+      !CBS_get_u8_length_prefixed(&protocol_name_list, &protocol_name) ||  //
       // Empty protocol names are forbidden.
-      CBS_len(&protocol_name) == 0 ||
+      CBS_len(&protocol_name) == 0 ||  //
       CBS_len(&protocol_name_list) != 0) {
     return false;
   }
@@ -1474,16 +1466,19 @@ bool ssl_is_alpn_protocol_allowed(const SSL_HANDSHAKE *hs,
   }
 
   // Check that the protocol name is one of the ones we advertised.
-  CBS client_protocol_name_list =
-          MakeConstSpan(hs->config->alpn_client_proto_list),
-      client_protocol_name;
-  while (CBS_len(&client_protocol_name_list) > 0) {
-    if (!CBS_get_u8_length_prefixed(&client_protocol_name_list,
-                                    &client_protocol_name)) {
+  return ssl_alpn_list_contains_protocol(hs->config->alpn_client_proto_list,
+                                         protocol);
+}
+
+bool ssl_alpn_list_contains_protocol(Span<const uint8_t> list,
+                                     Span<const uint8_t> protocol) {
+  CBS cbs = list, candidate;
+  while (CBS_len(&cbs) > 0) {
+    if (!CBS_get_u8_length_prefixed(&cbs, &candidate)) {
       return false;
     }
 
-    if (client_protocol_name == protocol) {
+    if (candidate == protocol) {
       return true;
     }
   }
@@ -1499,7 +1494,7 @@ bool ssl_negotiate_alpn(SSL_HANDSHAKE *hs, uint8_t *out_alert,
       !ssl_client_hello_get_extension(
           client_hello, &contents,
           TLSEXT_TYPE_application_layer_protocol_negotiation)) {
-    if (ssl->quic_method) {
+    if (SSL_is_quic(ssl)) {
       // ALPN is required when QUIC is used.
       OPENSSL_PUT_ERROR(SSL, SSL_R_NO_APPLICATION_PROTOCOL);
       *out_alert = SSL_AD_NO_APPLICATION_PROTOCOL;
@@ -1513,8 +1508,8 @@ bool ssl_negotiate_alpn(SSL_HANDSHAKE *hs, uint8_t *out_alert,
   hs->next_proto_neg_seen = false;
 
   CBS protocol_name_list;
-  if (!CBS_get_u16_length_prefixed(&contents, &protocol_name_list) ||
-      CBS_len(&contents) != 0 ||
+  if (!CBS_get_u16_length_prefixed(&contents, &protocol_name_list) ||  //
+      CBS_len(&contents) != 0 ||                                       //
       !ssl_is_valid_alpn_list(protocol_name_list)) {
     OPENSSL_PUT_ERROR(SSL, SSL_R_PARSE_TLSEXT);
     *out_alert = SSL_AD_DECODE_ERROR;
@@ -1530,7 +1525,7 @@ bool ssl_negotiate_alpn(SSL_HANDSHAKE *hs, uint8_t *out_alert,
       static_cast<unsigned>(CBS_len(&protocol_name_list)),
       ssl->ctx->alpn_select_cb_arg);
   // ALPN is required when QUIC is used.
-  if (ssl->quic_method &&
+  if (SSL_is_quic(ssl) &&
       (ret == SSL_TLSEXT_ERR_NOACK || ret == SSL_TLSEXT_ERR_ALERT_WARNING)) {
     ret = SSL_TLSEXT_ERR_ALERT_FATAL;
   }
@@ -1672,8 +1667,8 @@ static bool ext_srtp_add_clienthello(const SSL_HANDSHAKE *hs, CBB *out,
   const SSL *const ssl = hs->ssl;
   const STACK_OF(SRTP_PROTECTION_PROFILE) *profiles =
       SSL_get_srtp_profiles(ssl);
-  if (profiles == NULL ||
-      sk_SRTP_PROTECTION_PROFILE_num(profiles) == 0 ||
+  if (profiles == NULL ||                               //
+      sk_SRTP_PROTECTION_PROFILE_num(profiles) == 0 ||  //
       !SSL_is_dtls(ssl)) {
     return true;
   }
@@ -1713,10 +1708,10 @@ static bool ext_srtp_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
   assert(SSL_is_dtls(ssl));
   CBS profile_ids, srtp_mki;
   uint16_t profile_id;
-  if (!CBS_get_u16_length_prefixed(contents, &profile_ids) ||
-      !CBS_get_u16(&profile_ids, &profile_id) ||
-      CBS_len(&profile_ids) != 0 ||
-      !CBS_get_u8_length_prefixed(contents, &srtp_mki) ||
+  if (!CBS_get_u16_length_prefixed(contents, &profile_ids) ||  //
+      !CBS_get_u16(&profile_ids, &profile_id) ||               //
+      CBS_len(&profile_ids) != 0 ||                            //
+      !CBS_get_u8_length_prefixed(contents, &srtp_mki) ||      //
       CBS_len(contents) != 0) {
     OPENSSL_PUT_ERROR(SSL, SSL_R_BAD_SRTP_PROTECTION_PROFILE_LIST);
     return false;
@@ -1796,8 +1791,7 @@ static bool ext_srtp_add_serverhello(SSL_HANDSHAKE *hs, CBB *out) {
       !CBB_add_u16_length_prefixed(out, &contents) ||
       !CBB_add_u16_length_prefixed(&contents, &profile_ids) ||
       !CBB_add_u16(&profile_ids, ssl->s3->srtp_profile->id) ||
-      !CBB_add_u8(&contents, 0 /* empty MKI */) ||
-      !CBB_flush(out)) {
+      !CBB_add_u8(&contents, 0 /* empty MKI */) || !CBB_flush(out)) {
     return false;
   }
 
@@ -1833,8 +1827,8 @@ static bool ext_ec_point_add_clienthello(const SSL_HANDSHAKE *hs, CBB *out,
   return ext_ec_point_add_extension(hs, out);
 }
 
-static bool ext_ec_point_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
-                                           CBS *contents) {
+static bool ext_ec_point_parse_serverhello(SSL_HANDSHAKE *hs,
+                                           uint8_t *out_alert, CBS *contents) {
   if (contents == NULL) {
     return true;
   }
@@ -1861,8 +1855,8 @@ static bool ext_ec_point_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert
   return true;
 }
 
-static bool ext_ec_point_parse_clienthello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
-                                          CBS *contents) {
+static bool ext_ec_point_parse_clienthello(SSL_HANDSHAKE *hs,
+                                           uint8_t *out_alert, CBS *contents) {
   if (ssl_protocol_version(hs->ssl) >= TLS1_3_VERSION) {
     return true;
   }
@@ -1896,7 +1890,8 @@ static bool should_offer_psk(const SSL_HANDSHAKE *hs,
                              ssl_client_hello_type_t type) {
   const SSL *const ssl = hs->ssl;
   if (hs->max_version < TLS1_3_VERSION || ssl->session == nullptr ||
-      ssl_session_protocol_version(ssl->session.get()) < TLS1_3_VERSION ||
+      ssl_session_get_type(ssl->session.get()) !=
+          SSLSessionType::kPreSharedKey ||
       // TODO(https://crbug.com/boringssl/275): Should we synthesize a
       // placeholder PSK, at least when we offer early data? Otherwise
       // ClientHelloOuter will contain an early_data extension without a
@@ -1936,8 +1931,7 @@ static bool ext_pre_shared_key_add_clienthello(const SSL_HANDSHAKE *hs,
     return true;
   }
 
-  struct OPENSSL_timeval now;
-  ssl_get_current_time(ssl, &now);
+  OPENSSL_timeval now = ssl_ctx_get_current_time(ssl->ctx.get());
   uint32_t ticket_age = 1000 * (now.tv_sec - ssl->session->time);
   uint32_t obfuscated_ticket_age = ticket_age + ssl->session->ticket_age_add;
 
@@ -1967,7 +1961,7 @@ bool ssl_ext_pre_shared_key_parse_serverhello(SSL_HANDSHAKE *hs,
                                               uint8_t *out_alert,
                                               CBS *contents) {
   uint16_t psk_id;
-  if (!CBS_get_u16(contents, &psk_id) ||
+  if (!CBS_get_u16(contents, &psk_id) ||  //
       CBS_len(contents) != 0) {
     OPENSSL_PUT_ERROR(SSL, SSL_R_DECODE_ERROR);
     *out_alert = SSL_AD_DECODE_ERROR;
@@ -1999,11 +1993,11 @@ bool ssl_ext_pre_shared_key_parse_clienthello(
 
   // We only process the first PSK identity since we don't support pure PSK.
   CBS identities, binders;
-  if (!CBS_get_u16_length_prefixed(contents, &identities) ||
-      !CBS_get_u16_length_prefixed(&identities, out_ticket) ||
-      !CBS_get_u32(&identities, out_obfuscated_ticket_age) ||
-      !CBS_get_u16_length_prefixed(contents, &binders) ||
-      CBS_len(&binders) == 0 ||
+  if (!CBS_get_u16_length_prefixed(contents, &identities) ||    //
+      !CBS_get_u16_length_prefixed(&identities, out_ticket) ||  //
+      !CBS_get_u32(&identities, out_obfuscated_ticket_age) ||   //
+      !CBS_get_u16_length_prefixed(contents, &binders) ||       //
+      CBS_len(&binders) == 0 ||                                 //
       CBS_len(contents) != 0) {
     OPENSSL_PUT_ERROR(SSL, SSL_R_DECODE_ERROR);
     *out_alert = SSL_AD_DECODE_ERROR;
@@ -2056,10 +2050,10 @@ bool ssl_ext_pre_shared_key_add_serverhello(SSL_HANDSHAKE *hs, CBB *out) {
   }
 
   CBB contents;
-  if (!CBB_add_u16(out, TLSEXT_TYPE_pre_shared_key) ||
-      !CBB_add_u16_length_prefixed(out, &contents) ||
+  if (!CBB_add_u16(out, TLSEXT_TYPE_pre_shared_key) ||  //
+      !CBB_add_u16_length_prefixed(out, &contents) ||   //
       // We only consider the first identity for resumption
-      !CBB_add_u16(&contents, 0) ||
+      !CBB_add_u16(&contents, 0) ||  //
       !CBB_flush(out)) {
     return false;
   }
@@ -2098,8 +2092,8 @@ static bool ext_psk_key_exchange_modes_parse_clienthello(SSL_HANDSHAKE *hs,
   }
 
   CBS ke_modes;
-  if (!CBS_get_u8_length_prefixed(contents, &ke_modes) ||
-      CBS_len(&ke_modes) == 0 ||
+  if (!CBS_get_u8_length_prefixed(contents, &ke_modes) ||  //
+      CBS_len(&ke_modes) == 0 ||                           //
       CBS_len(contents) != 0) {
     *out_alert = SSL_AD_DECODE_ERROR;
     return false;
@@ -2136,8 +2130,8 @@ static bool ext_early_data_add_clienthello(const SSL_HANDSHAKE *hs, CBB *out,
   // send the extension in both ClientHellos. This ensures that, if the server
   // handshakes with ClientHelloOuter, it can skip past early data. See
   // draft-ietf-tls-esni-13, section 6.1.
-  if (!CBB_add_u16(out_compressible, TLSEXT_TYPE_early_data) ||
-      !CBB_add_u16(out_compressible, 0) ||
+  if (!CBB_add_u16(out_compressible, TLSEXT_TYPE_early_data) ||  //
+      !CBB_add_u16(out_compressible, 0) ||                       //
       !CBB_flush(out_compressible)) {
     return false;
   }
@@ -2184,10 +2178,10 @@ static bool ext_early_data_parse_serverhello(SSL_HANDSHAKE *hs,
 }
 
 static bool ext_early_data_parse_clienthello(SSL_HANDSHAKE *hs,
-                                             uint8_t *out_alert, CBS *contents) {
+                                             uint8_t *out_alert,
+                                             CBS *contents) {
   SSL *const ssl = hs->ssl;
-  if (contents == NULL ||
-      ssl_protocol_version(ssl) < TLS1_3_VERSION) {
+  if (contents == NULL || ssl_protocol_version(ssl) < TLS1_3_VERSION) {
     return true;
   }
 
@@ -2205,8 +2199,8 @@ static bool ext_early_data_add_serverhello(SSL_HANDSHAKE *hs, CBB *out) {
     return true;
   }
 
-  if (!CBB_add_u16(out, TLSEXT_TYPE_early_data) ||
-      !CBB_add_u16(out, 0) ||
+  if (!CBB_add_u16(out, TLSEXT_TYPE_early_data) ||  //
+      !CBB_add_u16(out, 0) ||                       //
       !CBB_flush(out)) {
     return false;
   }
@@ -2496,14 +2490,12 @@ static bool ext_supported_groups_add_clienthello(const SSL_HANDSHAKE *hs,
 
   // Add a fake group. See RFC 8701.
   if (ssl->ctx->grease_enabled &&
-      !CBB_add_u16(&groups_bytes,
-                   ssl_get_grease_value(hs, ssl_grease_group))) {
+      !CBB_add_u16(&groups_bytes, ssl_get_grease_value(hs, ssl_grease_group))) {
     return false;
   }
 
   for (uint16_t group : tls1_get_grouplist(hs)) {
-    if (is_post_quantum_group(group) &&
-        hs->max_version < TLS1_3_VERSION) {
+    if (is_post_quantum_group(group) && hs->max_version < TLS1_3_VERSION) {
       continue;
     }
     if (!CBB_add_u16(&groups_bytes, group)) {
@@ -2530,7 +2522,7 @@ static bool parse_u16_array(const CBS *cbs, Array<uint16_t> *out) {
   }
 
   Array<uint16_t> ret;
-  if (!ret.Init(CBS_len(&copy) / 2)) {
+  if (!ret.InitForOverwrite(CBS_len(&copy) / 2)) {
     return false;
   }
   for (size_t i = 0; i < ret.size(); i++) {
@@ -2546,16 +2538,16 @@ static bool parse_u16_array(const CBS *cbs, Array<uint16_t> *out) {
 }
 
 static bool ext_supported_groups_parse_clienthello(SSL_HANDSHAKE *hs,
-                                                  uint8_t *out_alert,
+                                                   uint8_t *out_alert,
                                                    CBS *contents) {
   if (contents == NULL) {
     return true;
   }
 
   CBS supported_group_list;
-  if (!CBS_get_u16_length_prefixed(contents, &supported_group_list) ||
-      CBS_len(&supported_group_list) == 0 ||
-      CBS_len(contents) != 0 ||
+  if (!CBS_get_u16_length_prefixed(contents, &supported_group_list) ||  //
+      CBS_len(&supported_group_list) == 0 ||                            //
+      CBS_len(contents) != 0 ||                                         //
       !parse_u16_array(&supported_group_list, &hs->peer_supported_group_list)) {
     return false;
   }
@@ -2564,14 +2556,53 @@ static bool ext_supported_groups_parse_clienthello(SSL_HANDSHAKE *hs,
 }
 
 
+// Certificate Authorities.
+//
+// https://tools.ietf.org/html/rfc8446#section-4.2.4
+
+static bool ext_certificate_authorities_add_clienthello(
+    const SSL_HANDSHAKE *hs, CBB *out, CBB *out_compressible,
+    ssl_client_hello_type_t type) {
+  if (ssl_has_CA_names(hs->config)) {
+    CBB ca_contents;
+    if (!CBB_add_u16(out, TLSEXT_TYPE_certificate_authorities) ||  //
+        !CBB_add_u16_length_prefixed(out, &ca_contents) ||         //
+        !ssl_add_CA_names(hs, &ca_contents) ||                     //
+        !CBB_flush(out)) {
+      return false;
+    }
+  }
+  return true;
+}
+
+static bool ext_certificate_authorities_parse_clienthello(SSL_HANDSHAKE *hs,
+                                                          uint8_t *out_alert,
+                                                          CBS *contents) {
+  if (contents == NULL) {
+    return true;
+  }
+
+  if (CBS_len(contents) == 0) {
+    return false;
+  }
+
+  hs->ca_names = SSL_parse_CA_list(hs->ssl, out_alert, contents);
+  if (!hs->ca_names) {
+    return false;
+  }
+
+  return true;
+}
+
+
 // QUIC Transport Parameters
 
 static bool ext_quic_transport_params_add_clienthello_impl(
     const SSL_HANDSHAKE *hs, CBB *out, bool use_legacy_codepoint) {
-  if (hs->config->quic_transport_params.empty() && !hs->ssl->quic_method) {
+  if (hs->config->quic_transport_params.empty() && !SSL_is_quic(hs->ssl)) {
     return true;
   }
-  if (hs->config->quic_transport_params.empty() || !hs->ssl->quic_method) {
+  if (hs->config->quic_transport_params.empty() || !SSL_is_quic(hs->ssl)) {
     // QUIC Transport Parameters must be sent over QUIC, and they must not be
     // sent over non-QUIC transports. If transport params are set, then
     // SSL(_CTX)_set_quic_method must also be called.
@@ -2623,7 +2654,7 @@ static bool ext_quic_transport_params_parse_serverhello_impl(
       // Silently ignore because we expect the other QUIC codepoint.
       return true;
     }
-    if (!ssl->quic_method) {
+    if (!SSL_is_quic(ssl)) {
       return true;
     }
     *out_alert = SSL_AD_MISSING_EXTENSION;
@@ -2631,7 +2662,7 @@ static bool ext_quic_transport_params_parse_serverhello_impl(
   }
   // The extensions parser will check for unsolicited extensions before
   // calling the callback.
-  assert(ssl->quic_method != nullptr);
+  assert(SSL_is_quic(ssl));
   assert(ssl_protocol_version(ssl) == TLS1_3_VERSION);
   assert(used_legacy_codepoint == hs->config->quic_use_legacy_codepoint);
   return ssl->s3->peer_quic_transport_params.CopyFrom(*contents);
@@ -2655,7 +2686,7 @@ static bool ext_quic_transport_params_parse_clienthello_impl(
     bool used_legacy_codepoint) {
   SSL *const ssl = hs->ssl;
   if (!contents) {
-    if (!ssl->quic_method) {
+    if (!SSL_is_quic(ssl)) {
       if (hs->config->quic_transport_params.empty()) {
         return true;
       }
@@ -2672,7 +2703,7 @@ static bool ext_quic_transport_params_parse_clienthello_impl(
     *out_alert = SSL_AD_MISSING_EXTENSION;
     return false;
   }
-  if (!ssl->quic_method) {
+  if (!SSL_is_quic(ssl)) {
     if (used_legacy_codepoint) {
       // Ignore the legacy private-use codepoint because that could be sent
       // to mean something else than QUIC transport parameters.
@@ -2706,12 +2737,12 @@ static bool ext_quic_transport_params_parse_clienthello_legacy(
 
 static bool ext_quic_transport_params_add_serverhello_impl(
     SSL_HANDSHAKE *hs, CBB *out, bool use_legacy_codepoint) {
-  if (hs->ssl->quic_method == nullptr && use_legacy_codepoint) {
+  if (!SSL_is_quic(hs->ssl) && use_legacy_codepoint) {
     // Ignore the legacy private-use codepoint because that could be sent
     // to mean something else than QUIC transport parameters.
     return true;
   }
-  assert(hs->ssl->quic_method != nullptr);
+  assert(SSL_is_quic(hs->ssl));
   if (hs->config->quic_transport_params.empty()) {
     // Transport parameters must be set when using QUIC.
     OPENSSL_PUT_ERROR(SSL, SSL_R_QUIC_TRANSPORT_PARAMETERS_MISCONFIGURED);
@@ -2773,9 +2804,9 @@ static bool ext_delegated_credential_parse_clienthello(SSL_HANDSHAKE *hs,
   // The contents of the extension are the signature algorithms the client will
   // accept for a delegated credential.
   CBS sigalg_list;
-  if (!CBS_get_u16_length_prefixed(contents, &sigalg_list) ||
-      CBS_len(&sigalg_list) == 0 ||
-      CBS_len(contents) != 0 ||
+  if (!CBS_get_u16_length_prefixed(contents, &sigalg_list) ||  //
+      CBS_len(&sigalg_list) == 0 ||                            //
+      CBS_len(contents) != 0 ||                                //
       !parse_u16_array(&sigalg_list, &hs->peer_delegated_credential_sigalgs)) {
     return false;
   }
@@ -2834,16 +2865,16 @@ static bool cert_compression_parse_clienthello(SSL_HANDSHAKE *hs,
   const size_t num_algs = ctx->cert_compression_algs.size();
 
   CBS alg_ids;
-  if (!CBS_get_u8_length_prefixed(contents, &alg_ids) ||
-      CBS_len(contents) != 0 ||
-      CBS_len(&alg_ids) == 0 ||
+  if (!CBS_get_u8_length_prefixed(contents, &alg_ids) ||  //
+      CBS_len(contents) != 0 ||                           //
+      CBS_len(&alg_ids) == 0 ||                           //
       CBS_len(&alg_ids) % 2 == 1) {
     return false;
   }
 
   const size_t num_given_alg_ids = CBS_len(&alg_ids) / 2;
   Array<uint16_t> given_alg_ids;
-  if (!given_alg_ids.Init(num_given_alg_ids)) {
+  if (!given_alg_ids.InitForOverwrite(num_given_alg_ids)) {
     return false;
   }
 
@@ -2911,7 +2942,7 @@ static bool ext_alps_add_clienthello_impl(const SSL_HANDSHAKE *hs, CBB *out,
                                           ssl_client_hello_type_t type,
                                           bool use_new_codepoint) {
   const SSL *const ssl = hs->ssl;
-  if (// ALPS requires TLS 1.3.
+  if (  // ALPS requires TLS 1.3.
       hs->max_version < TLS1_3_VERSION ||
       // Do not offer ALPS without ALPN.
       hs->config->alpn_client_proto_list.empty() ||
@@ -2965,8 +2996,7 @@ static bool ext_alps_add_clienthello_old(const SSL_HANDSHAKE *hs, CBB *out,
 }
 
 static bool ext_alps_parse_serverhello_impl(SSL_HANDSHAKE *hs,
-                                            uint8_t *out_alert,
-                                            CBS *contents,
+                                            uint8_t *out_alert, CBS *contents,
                                             bool use_new_codepoint) {
   SSL *const ssl = hs->ssl;
   if (contents == nullptr) {
@@ -2996,16 +3026,14 @@ static bool ext_alps_parse_serverhello_impl(SSL_HANDSHAKE *hs,
   return true;
 }
 
-static bool ext_alps_parse_serverhello(SSL_HANDSHAKE *hs,
-                                       uint8_t *out_alert,
+static bool ext_alps_parse_serverhello(SSL_HANDSHAKE *hs, uint8_t *out_alert,
                                        CBS *contents) {
   return ext_alps_parse_serverhello_impl(hs, out_alert, contents,
                                          /*use_new_codepoint=*/true);
 }
 
 static bool ext_alps_parse_serverhello_old(SSL_HANDSHAKE *hs,
-                                           uint8_t *out_alert,
-                                           CBS *contents) {
+                                           uint8_t *out_alert, CBS *contents) {
   return ext_alps_parse_serverhello_impl(hs, out_alert, contents,
                                          /*use_new_codepoint=*/false);
 }
@@ -3021,7 +3049,7 @@ static bool ext_alps_add_serverhello_impl(SSL_HANDSHAKE *hs, CBB *out,
     return true;
   }
 
-   if (use_new_codepoint != hs->config->alps_use_new_codepoint) {
+  if (use_new_codepoint != hs->config->alps_use_new_codepoint) {
     // Do nothing, we'll send the other codepoint.
     return true;
   }
@@ -3074,8 +3102,8 @@ bool ssl_negotiate_alps(SSL_HANDSHAKE *hs, uint8_t *out_alert,
     // Check if the client supports ALPS with the selected ALPN.
     bool found = false;
     CBS alps_list;
-    if (!CBS_get_u16_length_prefixed(&alps_contents, &alps_list) ||
-        CBS_len(&alps_contents) != 0 ||
+    if (!CBS_get_u16_length_prefixed(&alps_contents, &alps_list) ||  //
+        CBS_len(&alps_contents) != 0 ||                              //
         CBS_len(&alps_list) == 0) {
       OPENSSL_PUT_ERROR(SSL, SSL_R_DECODE_ERROR);
       *out_alert = SSL_AD_DECODE_ERROR;
@@ -3110,185 +3138,192 @@ bool ssl_negotiate_alps(SSL_HANDSHAKE *hs, uint8_t *out_alert,
 
 // kExtensions contains all the supported extensions.
 static const struct tls_extension kExtensions[] = {
-  {
-    TLSEXT_TYPE_server_name,
-    ext_sni_add_clienthello,
-    ext_sni_parse_serverhello,
-    ext_sni_parse_clienthello,
-    ext_sni_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_encrypted_client_hello,
-    ext_ech_add_clienthello,
-    ext_ech_parse_serverhello,
-    ext_ech_parse_clienthello,
-    ext_ech_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_extended_master_secret,
-    ext_ems_add_clienthello,
-    ext_ems_parse_serverhello,
-    ext_ems_parse_clienthello,
-    ext_ems_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_renegotiate,
-    ext_ri_add_clienthello,
-    ext_ri_parse_serverhello,
-    ext_ri_parse_clienthello,
-    ext_ri_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_supported_groups,
-    ext_supported_groups_add_clienthello,
-    ext_supported_groups_parse_serverhello,
-    ext_supported_groups_parse_clienthello,
-    dont_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_ec_point_formats,
-    ext_ec_point_add_clienthello,
-    ext_ec_point_parse_serverhello,
-    ext_ec_point_parse_clienthello,
-    ext_ec_point_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_session_ticket,
-    ext_ticket_add_clienthello,
-    ext_ticket_parse_serverhello,
-    // Ticket extension client parsing is handled in ssl_session.c
-    ignore_parse_clienthello,
-    ext_ticket_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_application_layer_protocol_negotiation,
-    ext_alpn_add_clienthello,
-    ext_alpn_parse_serverhello,
-    // ALPN is negotiated late in |ssl_negotiate_alpn|.
-    ignore_parse_clienthello,
-    ext_alpn_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_status_request,
-    ext_ocsp_add_clienthello,
-    ext_ocsp_parse_serverhello,
-    ext_ocsp_parse_clienthello,
-    ext_ocsp_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_signature_algorithms,
-    ext_sigalgs_add_clienthello,
-    forbid_parse_serverhello,
-    ext_sigalgs_parse_clienthello,
-    dont_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_next_proto_neg,
-    ext_npn_add_clienthello,
-    ext_npn_parse_serverhello,
-    ext_npn_parse_clienthello,
-    ext_npn_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_certificate_timestamp,
-    ext_sct_add_clienthello,
-    ext_sct_parse_serverhello,
-    ext_sct_parse_clienthello,
-    ext_sct_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_channel_id,
-    ext_channel_id_add_clienthello,
-    ext_channel_id_parse_serverhello,
-    ext_channel_id_parse_clienthello,
-    ext_channel_id_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_srtp,
-    ext_srtp_add_clienthello,
-    ext_srtp_parse_serverhello,
-    ext_srtp_parse_clienthello,
-    ext_srtp_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_key_share,
-    ext_key_share_add_clienthello,
-    forbid_parse_serverhello,
-    ignore_parse_clienthello,
-    dont_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_psk_key_exchange_modes,
-    ext_psk_key_exchange_modes_add_clienthello,
-    forbid_parse_serverhello,
-    ext_psk_key_exchange_modes_parse_clienthello,
-    dont_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_early_data,
-    ext_early_data_add_clienthello,
-    ext_early_data_parse_serverhello,
-    ext_early_data_parse_clienthello,
-    ext_early_data_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_supported_versions,
-    ext_supported_versions_add_clienthello,
-    forbid_parse_serverhello,
-    ignore_parse_clienthello,
-    dont_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_cookie,
-    ext_cookie_add_clienthello,
-    forbid_parse_serverhello,
-    ignore_parse_clienthello,
-    dont_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_quic_transport_parameters,
-    ext_quic_transport_params_add_clienthello,
-    ext_quic_transport_params_parse_serverhello,
-    ext_quic_transport_params_parse_clienthello,
-    ext_quic_transport_params_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_quic_transport_parameters_legacy,
-    ext_quic_transport_params_add_clienthello_legacy,
-    ext_quic_transport_params_parse_serverhello_legacy,
-    ext_quic_transport_params_parse_clienthello_legacy,
-    ext_quic_transport_params_add_serverhello_legacy,
-  },
-  {
-    TLSEXT_TYPE_cert_compression,
-    cert_compression_add_clienthello,
-    cert_compression_parse_serverhello,
-    cert_compression_parse_clienthello,
-    cert_compression_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_delegated_credential,
-    ext_delegated_credential_add_clienthello,
-    forbid_parse_serverhello,
-    ext_delegated_credential_parse_clienthello,
-    dont_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_application_settings,
-    ext_alps_add_clienthello,
-    ext_alps_parse_serverhello,
-    // ALPS is negotiated late in |ssl_negotiate_alpn|.
-    ignore_parse_clienthello,
-    ext_alps_add_serverhello,
-  },
-  {
-    TLSEXT_TYPE_application_settings_old,
-    ext_alps_add_clienthello_old,
-    ext_alps_parse_serverhello_old,
-    // ALPS is negotiated late in |ssl_negotiate_alpn|.
-    ignore_parse_clienthello,
-    ext_alps_add_serverhello_old,
-  },
+    {
+        TLSEXT_TYPE_server_name,
+        ext_sni_add_clienthello,
+        ext_sni_parse_serverhello,
+        ext_sni_parse_clienthello,
+        ext_sni_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_encrypted_client_hello,
+        ext_ech_add_clienthello,
+        ext_ech_parse_serverhello,
+        ext_ech_parse_clienthello,
+        ext_ech_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_extended_master_secret,
+        ext_ems_add_clienthello,
+        ext_ems_parse_serverhello,
+        ext_ems_parse_clienthello,
+        ext_ems_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_renegotiate,
+        ext_ri_add_clienthello,
+        ext_ri_parse_serverhello,
+        ext_ri_parse_clienthello,
+        ext_ri_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_supported_groups,
+        ext_supported_groups_add_clienthello,
+        ext_supported_groups_parse_serverhello,
+        ext_supported_groups_parse_clienthello,
+        dont_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_ec_point_formats,
+        ext_ec_point_add_clienthello,
+        ext_ec_point_parse_serverhello,
+        ext_ec_point_parse_clienthello,
+        ext_ec_point_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_session_ticket,
+        ext_ticket_add_clienthello,
+        ext_ticket_parse_serverhello,
+        // Ticket extension client parsing is handled in ssl_session.c
+        ignore_parse_clienthello,
+        ext_ticket_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_application_layer_protocol_negotiation,
+        ext_alpn_add_clienthello,
+        ext_alpn_parse_serverhello,
+        // ALPN is negotiated late in |ssl_negotiate_alpn|.
+        ignore_parse_clienthello,
+        ext_alpn_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_status_request,
+        ext_ocsp_add_clienthello,
+        ext_ocsp_parse_serverhello,
+        ext_ocsp_parse_clienthello,
+        ext_ocsp_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_signature_algorithms,
+        ext_sigalgs_add_clienthello,
+        forbid_parse_serverhello,
+        ext_sigalgs_parse_clienthello,
+        dont_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_next_proto_neg,
+        ext_npn_add_clienthello,
+        ext_npn_parse_serverhello,
+        ext_npn_parse_clienthello,
+        ext_npn_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_certificate_timestamp,
+        ext_sct_add_clienthello,
+        ext_sct_parse_serverhello,
+        ext_sct_parse_clienthello,
+        ext_sct_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_channel_id,
+        ext_channel_id_add_clienthello,
+        ext_channel_id_parse_serverhello,
+        ext_channel_id_parse_clienthello,
+        ext_channel_id_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_srtp,
+        ext_srtp_add_clienthello,
+        ext_srtp_parse_serverhello,
+        ext_srtp_parse_clienthello,
+        ext_srtp_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_key_share,
+        ext_key_share_add_clienthello,
+        forbid_parse_serverhello,
+        ignore_parse_clienthello,
+        dont_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_psk_key_exchange_modes,
+        ext_psk_key_exchange_modes_add_clienthello,
+        forbid_parse_serverhello,
+        ext_psk_key_exchange_modes_parse_clienthello,
+        dont_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_early_data,
+        ext_early_data_add_clienthello,
+        ext_early_data_parse_serverhello,
+        ext_early_data_parse_clienthello,
+        ext_early_data_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_supported_versions,
+        ext_supported_versions_add_clienthello,
+        forbid_parse_serverhello,
+        ignore_parse_clienthello,
+        dont_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_cookie,
+        ext_cookie_add_clienthello,
+        forbid_parse_serverhello,
+        ignore_parse_clienthello,
+        dont_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_quic_transport_parameters,
+        ext_quic_transport_params_add_clienthello,
+        ext_quic_transport_params_parse_serverhello,
+        ext_quic_transport_params_parse_clienthello,
+        ext_quic_transport_params_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_quic_transport_parameters_legacy,
+        ext_quic_transport_params_add_clienthello_legacy,
+        ext_quic_transport_params_parse_serverhello_legacy,
+        ext_quic_transport_params_parse_clienthello_legacy,
+        ext_quic_transport_params_add_serverhello_legacy,
+    },
+    {
+        TLSEXT_TYPE_cert_compression,
+        cert_compression_add_clienthello,
+        cert_compression_parse_serverhello,
+        cert_compression_parse_clienthello,
+        cert_compression_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_delegated_credential,
+        ext_delegated_credential_add_clienthello,
+        forbid_parse_serverhello,
+        ext_delegated_credential_parse_clienthello,
+        dont_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_application_settings,
+        ext_alps_add_clienthello,
+        ext_alps_parse_serverhello,
+        // ALPS is negotiated late in |ssl_negotiate_alpn|.
+        ignore_parse_clienthello,
+        ext_alps_add_serverhello,
+    },
+    {
+        TLSEXT_TYPE_application_settings_old,
+        ext_alps_add_clienthello_old,
+        ext_alps_parse_serverhello_old,
+        // ALPS is negotiated late in |ssl_negotiate_alpn|.
+        ignore_parse_clienthello,
+        ext_alps_add_serverhello_old,
+    },
+    {
+        TLSEXT_TYPE_certificate_authorities,
+        ext_certificate_authorities_add_clienthello,
+        forbid_parse_serverhello,
+        ext_certificate_authorities_parse_clienthello,
+        dont_add_serverhello,
+    },
 };
 
 #define kNumExtensions (sizeof(kExtensions) / sizeof(struct tls_extension))
@@ -3310,7 +3345,7 @@ bool ssl_setup_extension_permutation(SSL_HANDSHAKE *hs) {
   uint32_t seeds[kNumExtensions - 1];
   Array<uint8_t> permutation;
   if (!RAND_bytes(reinterpret_cast<uint8_t *>(seeds), sizeof(seeds)) ||
-      !permutation.Init(kNumExtensions)) {
+      !permutation.InitForOverwrite(kNumExtensions)) {
     return false;
   }
   for (size_t i = 0; i < kNumExtensions; i++) {
@@ -3521,7 +3556,7 @@ bool ssl_add_clienthello_tlsext(SSL_HANDSHAKE *hs, CBB *out, CBB *out_encoded,
   // bugs. We also apply this padding to ClientHelloOuter, to keep the wire
   // images aligned.
   size_t psk_extension_len = ext_pre_shared_key_clienthello_length(hs, type);
-  if (!SSL_is_dtls(ssl) && !ssl->quic_method &&
+  if (!SSL_is_dtls(ssl) && !SSL_is_quic(ssl) &&
       !ssl->s3->used_hello_retry_request) {
     header_len +=
         SSL3_HM_HEADER_LENGTH + 2 + CBB_len(&extensions) + psk_extension_len;
@@ -3603,7 +3638,7 @@ bool ssl_add_serverhello_tlsext(SSL_HANDSHAKE *hs, CBB *out) {
   }
 
   // Discard empty extensions blocks before TLS 1.3.
-  if (ssl_protocol_version(ssl) < TLS1_3_VERSION &&
+  if (ssl_protocol_version(ssl) < TLS1_3_VERSION &&  //
       CBB_len(&extensions) == 0) {
     CBB_discard_child(out);
   }
@@ -3789,6 +3824,7 @@ static bool ssl_check_clienthello_tlsext(SSL_HANDSHAKE *hs) {
       return true;
 
     default:
+      hs->should_ack_sni = ssl->s3->hostname != nullptr;
       return true;
   }
 }
@@ -3875,7 +3911,7 @@ static enum ssl_ticket_aead_result_t decrypt_ticket_with_cipher_ctx(
   if (ciphertext.size() >= INT_MAX) {
     return ssl_ticket_aead_ignore_ticket;
   }
-  if (!plaintext.Init(ciphertext.size())) {
+  if (!plaintext.InitForOverwrite(ciphertext.size())) {
     return ssl_ticket_aead_error;
   }
   int len1, len2;
@@ -3950,8 +3986,8 @@ static enum ssl_ticket_aead_result_t ssl_decrypt_ticket_with_ticket_keys(
     }
     if (!HMAC_Init_ex(hmac_ctx.get(), key->hmac_key, sizeof(key->hmac_key),
                       tlsext_tick_md(), NULL) ||
-        !EVP_DecryptInit_ex(cipher_ctx.get(), cipher, NULL,
-                            key->aes_key, iv.data())) {
+        !EVP_DecryptInit_ex(cipher_ctx.get(), cipher, NULL, key->aes_key,
+                            iv.data())) {
       return ssl_ticket_aead_error;
     }
   }
@@ -3963,7 +3999,7 @@ static enum ssl_ticket_aead_result_t ssl_decrypt_ticket_with_method(
     SSL_HANDSHAKE *hs, Array<uint8_t> *out, bool *out_renew_ticket,
     Span<const uint8_t> ticket) {
   Array<uint8_t> plaintext;
-  if (!plaintext.Init(ticket.size())) {
+  if (!plaintext.InitForOverwrite(ticket.size())) {
     return ssl_ticket_aead_error;
   }
 
@@ -4072,9 +4108,8 @@ enum ssl_ticket_aead_result_t ssl_process_ticket(
   // Envoy's tests expect the session to have a session ID that matches the
   // placeholder used by the client. It's unclear whether this is a good idea,
   // but we maintain it for now.
-  SHA256(ticket.data(), ticket.size(), session->session_id);
-  // Other consumers may expect a non-empty session ID to indicate resumption.
-  session->session_id_length = SHA256_DIGEST_LENGTH;
+  session->session_id.ResizeForOverwrite(SHA256_DIGEST_LENGTH);
+  SHA256(ticket.data(), ticket.size(), session->session_id.data());
 
   *out_session = std::move(session);
   return ssl_ticket_aead_success;
@@ -4144,7 +4179,8 @@ bool tls1_choose_signature_algorithm(SSL_HANDSHAKE *hs,
                                      ? MakeConstSpan(kSignSignatureAlgorithms)
                                      : cred->sigalgs;
   for (uint16_t sigalg : sigalgs) {
-    if (!ssl_pkey_supports_algorithm(ssl, cred->pubkey.get(), sigalg)) {
+    if (!ssl_pkey_supports_algorithm(ssl, cred->pubkey.get(), sigalg,
+                                     /*is_verify=*/false)) {
       continue;
     }
 
@@ -4165,10 +4201,10 @@ bool tls1_verify_channel_id(SSL_HANDSHAKE *hs, const SSLMessage &msg) {
   // extensions, but the only one that can be present is Channel ID.
   uint16_t extension_type;
   CBS channel_id = msg.body, extension;
-  if (!CBS_get_u16(&channel_id, &extension_type) ||
-      !CBS_get_u16_length_prefixed(&channel_id, &extension) ||
-      CBS_len(&channel_id) != 0 ||
-      extension_type != TLSEXT_TYPE_channel_id ||
+  if (!CBS_get_u16(&channel_id, &extension_type) ||             //
+      !CBS_get_u16_length_prefixed(&channel_id, &extension) ||  //
+      CBS_len(&channel_id) != 0 ||                              //
+      extension_type != TLSEXT_TYPE_channel_id ||               //
       CBS_len(&extension) != TLSEXT_CHANNEL_ID_SIZE) {
     OPENSSL_PUT_ERROR(SSL, SSL_R_DECODE_ERROR);
     ssl_send_alert(ssl, SSL3_AL_FATAL, SSL_AD_DECODE_ERROR);
@@ -4249,12 +4285,12 @@ bool tls1_write_channel_id(SSL_HANDSHAKE *hs, CBB *cbb) {
   }
 
   CBB child;
-  if (!CBB_add_u16(cbb, TLSEXT_TYPE_channel_id) ||
-      !CBB_add_u16_length_prefixed(cbb, &child) ||
-      !BN_bn2cbb_padded(&child, 32, x.get()) ||
-      !BN_bn2cbb_padded(&child, 32, y.get()) ||
-      !BN_bn2cbb_padded(&child, 32, sig->r) ||
-      !BN_bn2cbb_padded(&child, 32, sig->s) ||
+  if (!CBB_add_u16(cbb, TLSEXT_TYPE_channel_id) ||  //
+      !CBB_add_u16_length_prefixed(cbb, &child) ||  //
+      !BN_bn2cbb_padded(&child, 32, x.get()) ||     //
+      !BN_bn2cbb_padded(&child, 32, y.get()) ||     //
+      !BN_bn2cbb_padded(&child, 32, sig->r) ||      //
+      !BN_bn2cbb_padded(&child, 32, sig->s) ||      //
       !CBB_flush(cbb)) {
     return false;
   }
@@ -4284,12 +4320,12 @@ bool tls1_channel_id_hash(SSL_HANDSHAKE *hs, uint8_t *out, size_t *out_len) {
   if (ssl->session != NULL) {
     static const char kResumptionMagic[] = "Resumption";
     SHA256_Update(&ctx, kResumptionMagic, sizeof(kResumptionMagic));
-    if (ssl->session->original_handshake_hash_len == 0) {
+    if (ssl->session->original_handshake_hash.empty()) {
       OPENSSL_PUT_ERROR(SSL, ERR_R_INTERNAL_ERROR);
       return false;
     }
-    SHA256_Update(&ctx, ssl->session->original_handshake_hash,
-                  ssl->session->original_handshake_hash_len);
+    SHA256_Update(&ctx, ssl->session->original_handshake_hash.data(),
+                  ssl->session->original_handshake_hash.size());
   }
 
   uint8_t hs_hash[EVP_MAX_MD_SIZE];
@@ -4312,20 +4348,14 @@ bool tls1_record_handshake_hashes_for_channel_id(SSL_HANDSHAKE *hs) {
     return false;
   }
 
-  static_assert(
-      sizeof(hs->new_session->original_handshake_hash) == EVP_MAX_MD_SIZE,
-      "original_handshake_hash is too small");
-
   size_t digest_len;
-  if (!hs->transcript.GetHash(hs->new_session->original_handshake_hash,
+  hs->new_session->original_handshake_hash.ResizeForOverwrite(
+      hs->transcript.DigestLen());
+  if (!hs->transcript.GetHash(hs->new_session->original_handshake_hash.data(),
                               &digest_len)) {
     return false;
   }
-
-  static_assert(EVP_MAX_MD_SIZE <= 0xff,
-                "EVP_MAX_MD_SIZE does not fit in uint8_t");
-  hs->new_session->original_handshake_hash_len = (uint8_t)digest_len;
-
+  assert(digest_len == hs->new_session->original_handshake_hash.size());
   return true;
 }
 
@@ -4335,16 +4365,14 @@ bool ssl_is_sct_list_valid(const CBS *contents) {
   // of the SCTs may be empty.
   CBS copy = *contents;
   CBS sct_list;
-  if (!CBS_get_u16_length_prefixed(&copy, &sct_list) ||
-      CBS_len(&copy) != 0 ||
+  if (!CBS_get_u16_length_prefixed(&copy, &sct_list) || CBS_len(&copy) != 0 ||
       CBS_len(&sct_list) == 0) {
     return false;
   }
 
   while (CBS_len(&sct_list) > 0) {
     CBS sct;
-    if (!CBS_get_u16_length_prefixed(&sct_list, &sct) ||
-        CBS_len(&sct) == 0) {
+    if (!CBS_get_u16_length_prefixed(&sct_list, &sct) || CBS_len(&sct) == 0) {
       return false;
     }
   }