grpc 1.50.0.pre1 → 1.51.0

data/src/core/lib/channel/connected_channel.cc

@@ -20,19 +20,57 @@
 
 #include "src/core/lib/channel/connected_channel.h"
 
+#include <inttypes.h>
+#include <string.h>
+
+#include <algorithm>
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
+#include "absl/base/thread_annotations.h"
+#include "absl/status/status.h"
+#include "absl/strings/str_cat.h"
+#include "absl/strings/str_join.h"
+#include "absl/types/optional.h"
+#include "absl/types/variant.h"
+
 #include <grpc/impl/codegen/grpc_types.h>
 #include <grpc/support/alloc.h>
 #include <grpc/support/log.h>
 
 #include "src/core/lib/channel/channel_args.h"
+#include "src/core/lib/channel/channel_fwd.h"
 #include "src/core/lib/channel/channel_stack.h"
+#include "src/core/lib/channel/context.h"
+#include "src/core/lib/debug/trace.h"
 #include "src/core/lib/gpr/alloc.h"
+#include "src/core/lib/gprpp/debug_location.h"
+#include "src/core/lib/gprpp/match.h"
+#include "src/core/lib/gprpp/orphanable.h"
+#include "src/core/lib/gprpp/status_helper.h"
+#include "src/core/lib/gprpp/sync.h"
 #include "src/core/lib/iomgr/call_combiner.h"
 #include "src/core/lib/iomgr/closure.h"
 #include "src/core/lib/iomgr/error.h"
+#include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/iomgr/polling_entity.h"
+#include "src/core/lib/promise/activity.h"
+#include "src/core/lib/promise/arena_promise.h"
+#include "src/core/lib/promise/context.h"
+#include "src/core/lib/promise/latch.h"
+#include "src/core/lib/promise/pipe.h"
+#include "src/core/lib/promise/poll.h"
+#include "src/core/lib/resource_quota/arena.h"
+#include "src/core/lib/slice/slice_buffer.h"
+#include "src/core/lib/surface/call.h"
+#include "src/core/lib/surface/call_trace.h"
+#include "src/core/lib/surface/channel_stack_type.h"
+#include "src/core/lib/transport/metadata_batch.h"
 #include "src/core/lib/transport/transport.h"
 #include "src/core/lib/transport/transport_fwd.h"
+#include "src/core/lib/transport/transport_impl.h"
 
 #define MAX_BUFFER_LENGTH 8192
 
@@ -57,8 +95,8 @@ typedef struct connected_channel_call_data {
 
 static void run_in_call_combiner(void* arg, grpc_error_handle error) {
   callback_state* state = static_cast<callback_state*>(arg);
-  GRPC_CALL_COMBINER_START(state->call_combiner, state->original_closure,
-                           GRPC_ERROR_REF(error), state->reason);
+  GRPC_CALL_COMBINER_START(state->call_combiner, state->original_closure, error,
+                           state->reason);
 }
 
 static void run_cancel_in_call_combiner(void* arg, grpc_error_handle error) {
@@ -156,9 +194,8 @@ static grpc_error_handle connected_channel_init_call_elem(
   int r = grpc_transport_init_stream(
       chand->transport, TRANSPORT_STREAM_FROM_CALL_DATA(calld),
       &args->call_stack->refcount, args->server_transport_data, args->arena);
-  return r == 0 ? GRPC_ERROR_NONE
-                : GRPC_ERROR_CREATE_FROM_STATIC_STRING(
-                      "transport stream initialization failed");
+  return r == 0 ? absl::OkStatus()
+                : GRPC_ERROR_CREATE("transport stream initialization failed");
 }
 
 static void set_pollset_or_pollset_set(grpc_call_element* elem,
@@ -187,7 +224,7 @@ static grpc_error_handle connected_channel_init_channel_elem(
   GPR_ASSERT(args->is_last);
   cd->transport = grpc_channel_args_find_pointer<grpc_transport>(
       args->channel_args, GRPC_ARG_TRANSPORT);
-  return GRPC_ERROR_NONE;
+  return absl::OkStatus();
 }
 
 /* Destructor for channel_data */
@@ -203,39 +240,662 @@ static void connected_channel_get_channel_info(
     grpc_channel_element* /*elem*/, const grpc_channel_info* /*channel_info*/) {
 }
 
-const grpc_channel_filter grpc_connected_filter = {
-    connected_channel_start_transport_stream_op_batch,
-    nullptr,
-    connected_channel_start_transport_op,
-    sizeof(call_data),
-    connected_channel_init_call_elem,
-    set_pollset_or_pollset_set,
-    connected_channel_destroy_call_elem,
-    sizeof(channel_data),
-    connected_channel_init_channel_elem,
-    [](grpc_channel_stack* channel_stack, grpc_channel_element* elem) {
-      /* HACK(ctiller): increase call stack size for the channel to make space
-         for channel data. We need a cleaner (but performant) way to do this,
-         and I'm not sure what that is yet.
-         This is only "safe" because call stacks place no additional data after
-         the last call element, and the last call element MUST be the connected
-         channel. */
-      channel_stack->call_stack_size += grpc_transport_stream_size(
-          static_cast<channel_data*>(elem->channel_data)->transport);
-    },
-    connected_channel_destroy_channel_elem,
-    connected_channel_get_channel_info,
-    "connected",
+namespace grpc_core {
+namespace {
+
+class ClientStream : public Orphanable {
+ public:
+  ClientStream(grpc_transport* transport, CallArgs call_args)
+      : transport_(transport),
+        stream_(nullptr, StreamDeleter(this)),
+        server_initial_metadata_latch_(call_args.server_initial_metadata),
+        client_to_server_messages_(call_args.outgoing_messages),
+        server_to_client_messages_(call_args.incoming_messages),
+        client_initial_metadata_(std::move(call_args.client_initial_metadata)) {
+    call_context_->IncrementRefCount("client_stream");
+    GRPC_STREAM_REF_INIT(
+        &stream_refcount_, 1,
+        [](void* p, grpc_error_handle) {
+          static_cast<ClientStream*>(p)->BeginDestroy();
+        },
+        this, "client_stream");
+    if (grpc_call_trace.enabled()) {
+      gpr_log(GPR_INFO, "%sInitImpl: intitial_metadata=%s",
+              Activity::current()->DebugTag().c_str(),
+              client_initial_metadata_->DebugString().c_str());
+    }
+  }
+
+  void Orphan() override {
+    bool finished;
+    {
+      MutexLock lock(&mu_);
+      if (grpc_call_trace.enabled()) {
+        gpr_log(GPR_INFO, "%sDropStream: %s",
+                Activity::current()->DebugTag().c_str(),
+                ActiveOpsString().c_str());
+      }
+      finished = finished_;
+    }
+    // If we hadn't already observed the stream to be finished, we need to
+    // cancel it at the transport.
+    if (!finished) {
+      IncrementRefCount("shutdown client stream");
+      auto* cancel_op =
+          GetContext<Arena>()->New<grpc_transport_stream_op_batch>();
+      cancel_op->cancel_stream = true;
+      cancel_op->payload = &batch_payload_;
+      auto* stream = stream_.get();
+      cancel_op->on_complete = NewClosure(
+          [this](grpc_error_handle) { Unref("shutdown client stream"); });
+      batch_payload_.cancel_stream.cancel_error = absl::CancelledError();
+      grpc_transport_perform_stream_op(transport_, stream, cancel_op);
+    }
+    Unref("orphan client stream");
+  }
+
+  void IncrementRefCount(const char* reason) {
+#ifndef NDEBUG
+    grpc_stream_ref(&stream_refcount_, reason);
+#else
+    (void)reason;
+    grpc_stream_ref(&stream_refcount_);
+#endif
+  }
+
+  void Unref(const char* reason) {
+#ifndef NDEBUG
+    grpc_stream_unref(&stream_refcount_, reason);
+#else
+    (void)reason;
+    grpc_stream_unref(&stream_refcount_);
+#endif
+  }
+
+  void BeginDestroy() {
+    if (stream_ != nullptr) {
+      stream_.reset();
+    } else {
+      StreamDestroyed();
+    }
+  }
+
+  Poll<ServerMetadataHandle> PollOnce() {
+    MutexLock lock(&mu_);
+    GPR_ASSERT(!finished_);
+
+    if (grpc_call_trace.enabled()) {
+      gpr_log(GPR_INFO, "%sPollConnectedChannel: %s",
+              Activity::current()->DebugTag().c_str(),
+              ActiveOpsString().c_str());
+    }
+
+    auto push_recv_message = [this]() ABSL_EXCLUSIVE_LOCKS_REQUIRED(mu_) {
+      recv_message_state_ = PendingReceiveMessage{};
+      auto& pending_recv_message =
+          absl::get<PendingReceiveMessage>(recv_message_state_);
+      memset(&recv_message_, 0, sizeof(recv_message_));
+      recv_message_.payload = &batch_payload_;
+      recv_message_.on_complete = nullptr;
+      recv_message_.recv_message = true;
+      batch_payload_.recv_message.recv_message = &pending_recv_message.payload;
+      batch_payload_.recv_message.flags = &pending_recv_message.flags;
+      batch_payload_.recv_message.call_failed_before_recv_message = nullptr;
+      batch_payload_.recv_message.recv_message_ready =
+          &recv_message_batch_done_;
+      IncrementRefCount("recv_message");
+      recv_message_waker_ = Activity::current()->MakeOwningWaker();
+      push_recv_message_ = true;
+      SchedulePush();
+    };
+
+    if (!std::exchange(requested_metadata_, true)) {
+      if (grpc_call_trace.enabled()) {
+        gpr_log(GPR_INFO, "%sPollConnectedChannel: requesting metadata",
+                Activity::current()->DebugTag().c_str());
+      }
+      stream_.reset(static_cast<grpc_stream*>(
+          GetContext<Arena>()->Alloc(transport_->vtable->sizeof_stream)));
+      grpc_transport_init_stream(transport_, stream_.get(), &stream_refcount_,
+                                 nullptr, GetContext<Arena>());
+      grpc_transport_set_pops(transport_, stream_.get(),
+                              GetContext<CallContext>()->polling_entity());
+      memset(&metadata_, 0, sizeof(metadata_));
+      metadata_.send_initial_metadata = true;
+      metadata_.recv_initial_metadata = true;
+      metadata_.recv_trailing_metadata = true;
+      metadata_.payload = &batch_payload_;
+      metadata_.on_complete = &metadata_batch_done_;
+      batch_payload_.send_initial_metadata.send_initial_metadata =
+          client_initial_metadata_.get();
+      batch_payload_.send_initial_metadata.peer_string =
+          GetContext<CallContext>()->peer_string_atm_ptr();
+      server_initial_metadata_ =
+          GetContext<Arena>()->MakePooled<ServerMetadata>(GetContext<Arena>());
+      batch_payload_.recv_initial_metadata.recv_initial_metadata =
+          server_initial_metadata_.get();
+      batch_payload_.recv_initial_metadata.recv_initial_metadata_ready =
+          &recv_initial_metadata_ready_;
+      batch_payload_.recv_initial_metadata.trailing_metadata_available =
+          nullptr;
+      batch_payload_.recv_initial_metadata.peer_string = nullptr;
+      server_trailing_metadata_ =
+          GetContext<Arena>()->MakePooled<ServerMetadata>(GetContext<Arena>());
+      batch_payload_.recv_trailing_metadata.recv_trailing_metadata =
+          server_trailing_metadata_.get();
+      batch_payload_.recv_trailing_metadata.collect_stats =
+          &GetContext<CallContext>()->call_stats()->transport_stream_stats;
+      batch_payload_.recv_trailing_metadata.recv_trailing_metadata_ready =
+          &recv_trailing_metadata_ready_;
+      push_metadata_ = true;
+      IncrementRefCount("metadata_batch_done");
+      IncrementRefCount("initial_metadata_ready");
+      IncrementRefCount("trailing_metadata_ready");
+      initial_metadata_waker_ = Activity::current()->MakeOwningWaker();
+      trailing_metadata_waker_ = Activity::current()->MakeOwningWaker();
+      SchedulePush();
+    }
+    if (absl::holds_alternative<Closed>(send_message_state_)) {
+      message_to_send_.reset();
+    }
+    if (absl::holds_alternative<Idle>(send_message_state_)) {
+      message_to_send_.reset();
+      send_message_state_ = client_to_server_messages_->Next();
+    }
+    if (auto* next = absl::get_if<PipeReceiver<MessageHandle>::NextType>(
+            &send_message_state_)) {
+      auto r = (*next)();
+      if (auto* p = absl::get_if<NextResult<MessageHandle>>(&r)) {
+        memset(&send_message_, 0, sizeof(send_message_));
+        send_message_.payload = &batch_payload_;
+        send_message_.on_complete = &send_message_batch_done_;
+        // No value => half close from above.
+        if (p->has_value()) {
+          message_to_send_ = std::move(**p);
+          send_message_state_ = SendMessageToTransport{};
+          send_message_.send_message = true;
+          batch_payload_.send_message.send_message =
+              message_to_send_->payload();
+          batch_payload_.send_message.flags = message_to_send_->flags();
+        } else {
+          GPR_ASSERT(!absl::holds_alternative<Closed>(send_message_state_));
+          client_trailing_metadata_ =
+              GetContext<Arena>()->MakePooled<ClientMetadata>(
+                  GetContext<Arena>());
+          send_message_state_ = Closed{};
+          send_message_.send_trailing_metadata = true;
+          batch_payload_.send_trailing_metadata.send_trailing_metadata =
+              client_trailing_metadata_.get();
+          batch_payload_.send_trailing_metadata.sent = nullptr;
+        }
+        IncrementRefCount("send_message");
+        send_message_waker_ = Activity::current()->MakeOwningWaker();
+        push_send_message_ = true;
+        SchedulePush();
+      }
+    }
+    if (auto* pending =
+            absl::get_if<PendingReceiveMessage>(&recv_message_state_)) {
+      if (pending->received) {
+        if (pending->payload.has_value()) {
+          if (grpc_call_trace.enabled()) {
+            gpr_log(GPR_INFO,
+                    "%sRecvMessageBatchDone: received payload of %" PRIdPTR
+                    " bytes",
+                    recv_message_waker_.ActivityDebugTag().c_str(),
+                    pending->payload->Length());
+          }
+          recv_message_state_ = server_to_client_messages_->Push(
+              GetContext<Arena>()->MakePooled<Message>(
+                  std::move(*pending->payload), pending->flags));
+        } else {
+          if (grpc_call_trace.enabled()) {
+            gpr_log(GPR_INFO, "%sRecvMessageBatchDone: received no payload",
+                    recv_message_waker_.ActivityDebugTag().c_str());
+          }
+          recv_message_state_ = Closed{};
+          std::exchange(server_to_client_messages_, nullptr)->Close();
+        }
+      }
+    }
+    if (server_initial_metadata_state_ ==
+        ServerInitialMetadataState::kReceivedButNotSet) {
+      server_initial_metadata_state_ = ServerInitialMetadataState::kSet;
+      server_initial_metadata_latch_->Set(server_initial_metadata_.get());
+    }
+    if (absl::holds_alternative<Idle>(recv_message_state_)) {
+      if (grpc_call_trace.enabled()) {
+        gpr_log(GPR_INFO, "%sPollConnectedChannel: requesting message",
+                Activity::current()->DebugTag().c_str());
+      }
+      push_recv_message();
+    }
+    if (server_initial_metadata_state_ == ServerInitialMetadataState::kSet &&
+        !absl::holds_alternative<PipeSender<MessageHandle>::PushType>(
+            recv_message_state_) &&
+        std::exchange(queued_trailing_metadata_, false)) {
+      if (grpc_call_trace.enabled()) {
+        gpr_log(GPR_INFO,
+                "%sPollConnectedChannel: finished request, returning: {%s}; "
+                "active_ops: %s",
+                Activity::current()->DebugTag().c_str(),
+                server_trailing_metadata_->DebugString().c_str(),
+                ActiveOpsString().c_str());
+      }
+      finished_ = true;
+      return ServerMetadataHandle(std::move(server_trailing_metadata_));
+    }
+    if (auto* push = absl::get_if<PipeSender<MessageHandle>::PushType>(
+            &recv_message_state_)) {
+      auto r = (*push)();
+      if (bool* result = absl::get_if<bool>(&r)) {
+        if (*result) {
+          if (!finished_) {
+            if (grpc_call_trace.enabled()) {
+              gpr_log(GPR_INFO,
+                      "%sPollConnectedChannel: pushed message; requesting next",
+                      Activity::current()->DebugTag().c_str());
+            }
+            push_recv_message();
+          } else {
+            if (grpc_call_trace.enabled()) {
+              gpr_log(GPR_INFO,
+                      "%sPollConnectedChannel: pushed message and finished; "
+                      "marking closed",
+                      Activity::current()->DebugTag().c_str());
+            }
+            recv_message_state_ = Closed{};
+          }
+        } else {
+          if (grpc_call_trace.enabled()) {
+            gpr_log(GPR_INFO,
+                    "%sPollConnectedChannel: failed to push message; marking "
+                    "closed",
+                    Activity::current()->DebugTag().c_str());
+          }
+          recv_message_state_ = Closed{};
+        }
+      }
+    }
+    return Pending{};
+  }
+
+  void RecvInitialMetadataReady(grpc_error_handle error) {
+    GPR_ASSERT(error == absl::OkStatus());
+    {
+      MutexLock lock(&mu_);
+      server_initial_metadata_state_ =
+          ServerInitialMetadataState::kReceivedButNotSet;
+      initial_metadata_waker_.Wakeup();
+    }
+    Unref("initial_metadata_ready");
+  }
+
+  void RecvTrailingMetadataReady(grpc_error_handle error) {
+    GPR_ASSERT(error == absl::OkStatus());
+    {
+      MutexLock lock(&mu_);
+      queued_trailing_metadata_ = true;
+      trailing_metadata_waker_.Wakeup();
+    }
+    Unref("trailing_metadata_ready");
+  }
+
+  void MetadataBatchDone(grpc_error_handle error) {
+    GPR_ASSERT(error == absl::OkStatus());
+    Unref("metadata_batch_done");
+  }
+
+  void SendMessageBatchDone(grpc_error_handle error) {
+    {
+      MutexLock lock(&mu_);
+      if (error != absl::OkStatus()) {
+        // Note that we're in error here, the call will be closed by the
+        // transport in a moment, and we'll return from the promise with an
+        // error - so we don't need to do any extra work to close out pipes or
+        // the like.
+        send_message_state_ = Closed{};
+      }
+      if (!absl::holds_alternative<Closed>(send_message_state_)) {
+        send_message_state_ = Idle{};
+      }
+      send_message_waker_.Wakeup();
+    }
+    Unref("send_message");
+  }
+
+  void RecvMessageBatchDone(grpc_error_handle error) {
+    {
+      MutexLock lock(&mu_);
+      if (error != absl::OkStatus()) {
+        if (grpc_call_trace.enabled()) {
+          gpr_log(GPR_INFO, "%sRecvMessageBatchDone: error=%s",
+                  recv_message_waker_.ActivityDebugTag().c_str(),
+                  StatusToString(error).c_str());
+        }
+      } else if (absl::holds_alternative<Closed>(recv_message_state_)) {
+        if (grpc_call_trace.enabled()) {
+          gpr_log(GPR_INFO, "%sRecvMessageBatchDone: already closed, ignoring",
+                  recv_message_waker_.ActivityDebugTag().c_str());
+        }
+      } else {
+        auto pending =
+            absl::get_if<PendingReceiveMessage>(&recv_message_state_);
+        GPR_ASSERT(pending != nullptr);
+        GPR_ASSERT(pending->received == false);
+        pending->received = true;
+      }
+      recv_message_waker_.Wakeup();
+    }
+    Unref("recv_message");
+  }
+
+  // Called from outside the activity to push work down to the transport.
+  void Push() {
+    auto do_push = [this](grpc_transport_stream_op_batch* batch) {
+      if (stream_ != nullptr) {
+        grpc_transport_perform_stream_op(transport_, stream_.get(), batch);
+      } else {
+        grpc_transport_stream_op_batch_finish_with_failure_from_transport(
+            batch, absl::CancelledError());
+      }
+    };
+    bool push_metadata;
+    bool push_send_message;
+    bool push_recv_message;
+    {
+      MutexLock lock(&mu_);
+      push_metadata = std::exchange(push_metadata_, false);
+      push_send_message = std::exchange(push_send_message_, false);
+      push_recv_message = std::exchange(push_recv_message_, false);
+      scheduled_push_ = false;
+    }
+    if (push_metadata) do_push(&metadata_);
+    if (push_send_message) do_push(&send_message_);
+    if (push_recv_message) do_push(&recv_message_);
+    Unref("push");
+  }
+
+  void StreamDestroyed() {
+    call_context_->RunInContext([this] {
+      auto* cc = call_context_;
+      this->~ClientStream();
+      cc->Unref("child_stream");
+    });
+  }
+
+ private:
+  struct Idle {};
+  struct Closed {};
+  struct SendMessageToTransport {};
+
+  enum class ServerInitialMetadataState : uint8_t {
+    // Initial metadata has not been received from the server.
+    kNotReceived,
+    // Initial metadata has been received from the server via the transport, but
+    // has not yet been set on the latch to publish it up the call stack.
+    kReceivedButNotSet,
+    // Initial metadata has been received from the server via the transport and
+    // has been set on the latch to publish it up the call stack.
+    kSet,
+  };
+
+  class StreamDeleter {
+   public:
+    explicit StreamDeleter(ClientStream* impl) : impl_(impl) {}
+    void operator()(grpc_stream* stream) const {
+      if (stream == nullptr) return;
+      grpc_transport_destroy_stream(impl_->transport_, stream,
+                                    &impl_->stream_destroyed_);
+    }
+
+   private:
+    ClientStream* impl_;
+  };
+  using StreamPtr = std::unique_ptr<grpc_stream, StreamDeleter>;
+
+  void SchedulePush() ABSL_EXCLUSIVE_LOCKS_REQUIRED(mu_) {
+    if (std::exchange(scheduled_push_, true)) return;
+    IncrementRefCount("push");
+    ExecCtx::Run(DEBUG_LOCATION, &push_, absl::OkStatus());
+  }
+
+  std::string ActiveOpsString() const ABSL_EXCLUSIVE_LOCKS_REQUIRED(mu_) {
+    std::vector<std::string> ops;
+    if (finished_) ops.push_back("FINISHED");
+    // Pushes
+    std::vector<std::string> pushes;
+    if (push_metadata_) pushes.push_back("metadata");
+    if (push_send_message_) pushes.push_back("send_message");
+    if (push_recv_message_) pushes.push_back("recv_message");
+    if (!pushes.empty()) {
+      ops.push_back(
+          absl::StrCat(scheduled_push_ ? "push:" : "unscheduled-push:",
+                       absl::StrJoin(pushes, ",")));
+    } else if (scheduled_push_) {
+      ops.push_back("push:nothing");
+    }
+    // Results from transport
+    std::vector<std::string> queued;
+    if (server_initial_metadata_state_ ==
+        ServerInitialMetadataState::kReceivedButNotSet) {
+      queued.push_back("initial_metadata");
+    }
+    if (queued_trailing_metadata_) queued.push_back("trailing_metadata");
+    if (!queued.empty()) {
+      ops.push_back(absl::StrCat("queued:", absl::StrJoin(queued, ",")));
+    }
+    // Send message
+    std::string send_message_state = SendMessageString();
+    if (send_message_state != "WAITING") {
+      ops.push_back(absl::StrCat("send_message:", send_message_state));
+    }
+    // Receive message
+    std::string recv_message_state = RecvMessageString();
+    if (recv_message_state != "IDLE") {
+      ops.push_back(absl::StrCat("recv_message:", recv_message_state));
+    }
+    return absl::StrJoin(ops, " ");
+  }
+
+  std::string SendMessageString() const ABSL_EXCLUSIVE_LOCKS_REQUIRED(mu_) {
+    return Match(
+        send_message_state_, [](Idle) -> std::string { return "IDLE"; },
+        [](Closed) -> std::string { return "CLOSED"; },
+        [](const PipeReceiver<MessageHandle>::NextType&) -> std::string {
+          return "WAITING";
+        },
+        [](SendMessageToTransport) -> std::string { return "SENDING"; });
+  }
+
+  std::string RecvMessageString() const ABSL_EXCLUSIVE_LOCKS_REQUIRED(mu_) {
+    return Match(
+        recv_message_state_, [](Idle) -> std::string { return "IDLE"; },
+        [](Closed) -> std::string { return "CLOSED"; },
+        [](const PendingReceiveMessage&) -> std::string { return "WAITING"; },
+        [](const absl::optional<MessageHandle>& message) -> std::string {
+          return absl::StrCat(
+              "READY:", message.has_value()
+                            ? absl::StrCat((*message)->payload()->Length(), "b")
+                            : "EOS");
+        },
+        [](const PipeSender<MessageHandle>::PushType&) -> std::string {
+          return "PUSHING";
+        });
+  }
+
+  Mutex mu_;
+  bool requested_metadata_ = false;
+  bool push_metadata_ ABSL_GUARDED_BY(mu_) = false;
+  bool push_send_message_ ABSL_GUARDED_BY(mu_) = false;
+  bool push_recv_message_ ABSL_GUARDED_BY(mu_) = false;
+  bool scheduled_push_ ABSL_GUARDED_BY(mu_) = false;
+  ServerInitialMetadataState server_initial_metadata_state_
+      ABSL_GUARDED_BY(mu_) = ServerInitialMetadataState::kNotReceived;
+  bool queued_trailing_metadata_ ABSL_GUARDED_BY(mu_) = false;
+  bool finished_ ABSL_GUARDED_BY(mu_) = false;
+  CallContext* const call_context_{GetContext<CallContext>()};
+  Waker initial_metadata_waker_ ABSL_GUARDED_BY(mu_);
+  Waker trailing_metadata_waker_ ABSL_GUARDED_BY(mu_);
+  Waker send_message_waker_ ABSL_GUARDED_BY(mu_);
+  Waker recv_message_waker_ ABSL_GUARDED_BY(mu_);
+  grpc_transport* const transport_;
+  grpc_stream_refcount stream_refcount_;
+  StreamPtr stream_;
+  Latch<ServerMetadata*>* server_initial_metadata_latch_;
+  PipeReceiver<MessageHandle>* client_to_server_messages_;
+  PipeSender<MessageHandle>* server_to_client_messages_;
+  MessageHandle message_to_send_ ABSL_GUARDED_BY(mu_);
+  absl::variant<Idle, Closed, PipeReceiver<MessageHandle>::NextType,
+                SendMessageToTransport>
+      send_message_state_ ABSL_GUARDED_BY(mu_);
+  struct PendingReceiveMessage {
+    absl::optional<SliceBuffer> payload;
+    uint32_t flags;
+    bool received = false;
+  };
+  absl::variant<Idle, PendingReceiveMessage, Closed,
+                PipeSender<MessageHandle>::PushType>
+      recv_message_state_ ABSL_GUARDED_BY(mu_);
+  grpc_closure recv_initial_metadata_ready_ =
+      MakeMemberClosure<ClientStream, &ClientStream::RecvInitialMetadataReady>(
+          this, DEBUG_LOCATION);
+  grpc_closure recv_trailing_metadata_ready_ =
+      MakeMemberClosure<ClientStream, &ClientStream::RecvTrailingMetadataReady>(
+          this, DEBUG_LOCATION);
+  grpc_closure push_ = MakeMemberClosure<ClientStream, &ClientStream::Push>(
+      this, DEBUG_LOCATION);
+  ClientMetadataHandle client_initial_metadata_;
+  ClientMetadataHandle client_trailing_metadata_;
+  ServerMetadataHandle server_initial_metadata_;
+  ServerMetadataHandle server_trailing_metadata_;
+  grpc_transport_stream_op_batch metadata_;
+  grpc_closure metadata_batch_done_ =
+      MakeMemberClosure<ClientStream, &ClientStream::MetadataBatchDone>(
+          this, DEBUG_LOCATION);
+  grpc_transport_stream_op_batch send_message_;
+  grpc_closure send_message_batch_done_ =
+      MakeMemberClosure<ClientStream, &ClientStream::SendMessageBatchDone>(
+          this, DEBUG_LOCATION);
+  grpc_closure recv_message_batch_done_ =
+      MakeMemberClosure<ClientStream, &ClientStream::RecvMessageBatchDone>(
+          this, DEBUG_LOCATION);
+  grpc_transport_stream_op_batch recv_message_;
+  grpc_transport_stream_op_batch_payload batch_payload_{
+      GetContext<grpc_call_context_element>()};
+  grpc_closure stream_destroyed_ =
+      MakeMemberClosure<ClientStream, &ClientStream::StreamDestroyed>(
+          this, DEBUG_LOCATION);
 };
 
+class ClientConnectedCallPromise {
+ public:
+  ClientConnectedCallPromise(grpc_transport* transport, CallArgs call_args)
+      : impl_(GetContext<Arena>()->New<ClientStream>(transport,
+                                                     std::move(call_args))) {}
+
+  ClientConnectedCallPromise(const ClientConnectedCallPromise&) = delete;
+  ClientConnectedCallPromise& operator=(const ClientConnectedCallPromise&) =
+      delete;
+  ClientConnectedCallPromise(ClientConnectedCallPromise&& other) noexcept
+      : impl_(std::exchange(other.impl_, nullptr)) {}
+  ClientConnectedCallPromise& operator=(
+      ClientConnectedCallPromise&& other) noexcept {
+    impl_ = std::move(other.impl_);
+    return *this;
+  }
+
+  static ArenaPromise<ServerMetadataHandle> Make(grpc_transport* transport,
+                                                 CallArgs call_args) {
+    return ClientConnectedCallPromise(transport, std::move(call_args));
+  }
+
+  Poll<ServerMetadataHandle> operator()() { return impl_->PollOnce(); }
+
+ private:
+  OrphanablePtr<ClientStream> impl_;
+};
+
+template <ArenaPromise<ServerMetadataHandle> (*make_call_promise)(
+    grpc_transport*, CallArgs)>
+grpc_channel_filter MakeConnectedFilter() {
+  // Create a vtable that contains both the legacy call methods (for filter
+  // stack based calls) and the new promise based method for creating promise
+  // based calls (the latter iff make_call_promise != nullptr).
+  // In this way the filter can be inserted into either kind of channel stack,
+  // and only if all the filters in the stack are promise based will the call
+  // be promise based.
+  return {
+    connected_channel_start_transport_stream_op_batch,
+        make_call_promise == nullptr
+            ? nullptr
+            : +[](grpc_channel_element* elem, CallArgs call_args,
+                 NextPromiseFactory) {
+                grpc_transport* transport =
+                    static_cast<channel_data*>(elem->channel_data)->transport;
+                return make_call_promise(transport, std::move(call_args));
+              },
+      connected_channel_start_transport_op,
+      sizeof(call_data),
+      connected_channel_init_call_elem,
+      set_pollset_or_pollset_set,
+      connected_channel_destroy_call_elem,
+      sizeof(channel_data),
+      connected_channel_init_channel_elem,
+      +[](grpc_channel_stack* channel_stack, grpc_channel_element* elem) {
+        /* HACK(ctiller): increase call stack size for the channel to make space
+           for channel data. We need a cleaner (but performant) way to do this,
+           and I'm not sure what that is yet.
+           This is only "safe" because call stacks place no additional data
+           after the last call element, and the last call element MUST be the
+           connected channel. */
+        channel_stack->call_stack_size += grpc_transport_stream_size(
+            static_cast<channel_data*>(elem->channel_data)->transport);
+      },
+      connected_channel_destroy_channel_elem,
+      connected_channel_get_channel_info,
+      "connected",
+  };
+}
+
+ArenaPromise<ServerMetadataHandle> MakeTransportCallPromise(
+    grpc_transport* transport, CallArgs call_args) {
+  return transport->vtable->make_call_promise(transport, std::move(call_args));
+}
+
+const grpc_channel_filter kPromiseBasedTransportFilter =
+    MakeConnectedFilter<MakeTransportCallPromise>();
+
+const grpc_channel_filter kClientEmulatedFilter =
+    MakeConnectedFilter<ClientConnectedCallPromise::Make>();
+
+const grpc_channel_filter kNoPromiseFilter = MakeConnectedFilter<nullptr>();
+
+}  // namespace
+}  // namespace grpc_core
+
 bool grpc_add_connected_filter(grpc_core::ChannelStackBuilder* builder) {
   grpc_transport* t = builder->transport();
   GPR_ASSERT(t != nullptr);
-  builder->AppendFilter(&grpc_connected_filter);
+  // Choose the right vtable for the connected filter.
+  // We can't know promise based call or not here (that decision needs the
+  // collaboration of all of the filters on the channel, and we don't want
+  // ordering constraints on when we add filters).
+  // We can know if this results in a promise based call how we'll create our
+  // promise (if indeed we can), and so that is the choice made here.
+  if (t->vtable->make_call_promise != nullptr) {
+    // Option 1, and our ideal: the transport supports promise based calls, and
+    // so we simply use the transport directly.
+    builder->AppendFilter(&grpc_core::kPromiseBasedTransportFilter);
+  } else if (grpc_channel_stack_type_is_client(builder->channel_stack_type())) {
+    // Option 2: the transport does not support promise based calls, but we're
+    // on the client and so we have an implementation that we can use to convert
+    // to batches.
+    builder->AppendFilter(&grpc_core::kClientEmulatedFilter);
+  } else {
+    // Option 3: the transport does not support promise based calls, and we're
+    // on the server so we can't construct promise based calls just yet.
+    builder->AppendFilter(&grpc_core::kNoPromiseFilter);
+  }
   return true;
 }
-
-grpc_stream* grpc_connected_channel_get_stream(grpc_call_element* elem) {
-  call_data* calld = static_cast<call_data*>(elem->call_data);
-  return TRANSPORT_STREAM_FROM_CALL_DATA(calld);
-}