grpc 1.45.0 → 1.53.0

data/src/core/lib/transport/metadata_batch.h

@@ -1,52 +1,64 @@
-/*
- *
- * Copyright 2015 gRPC authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-#ifndef GRPC_CORE_LIB_TRANSPORT_METADATA_BATCH_H
-#define GRPC_CORE_LIB_TRANSPORT_METADATA_BATCH_H
+//
+//
+// Copyright 2015 gRPC authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+//
+
+#ifndef GRPC_SRC_CORE_LIB_TRANSPORT_METADATA_BATCH_H
+#define GRPC_SRC_CORE_LIB_TRANSPORT_METADATA_BATCH_H
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
+#include <stdlib.h>
 
 #include <cstdint>
-#include <limits>
-
-#include "absl/strings/escaping.h"
-#include "absl/strings/match.h"
-#include "absl/strings/str_join.h"
+#include <string>
+#include <type_traits>
+#include <utility>
+
+#include "absl/container/inlined_vector.h"
+#include "absl/functional/function_ref.h"
+#include "absl/meta/type_traits.h"
+#include "absl/strings/numbers.h"
+#include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
 
-#include <grpc/grpc.h>
-#include <grpc/slice.h>
+#include <grpc/impl/compression_types.h>
 #include <grpc/status.h>
-#include <grpc/support/time.h>
+#include <grpc/support/log.h>
 
 #include "src/core/lib/compression/compression_internal.h"
 #include "src/core/lib/gprpp/chunked_vector.h"
-#include "src/core/lib/gprpp/table.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
+#include "src/core/lib/gprpp/packed_table.h"
+#include "src/core/lib/gprpp/time.h"
+#include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/slice/slice.h"
-#include "src/core/lib/surface/validate_metadata.h"
 #include "src/core/lib/transport/parsed_metadata.h"
-#include "src/core/lib/transport/timeout_encoding.h"
 
 namespace grpc_core {
 
+// Given a metadata key and a value, return the encoded size.
+// Defaults to calling the key's Encode() method and then calculating the size
+// of that, but can be overridden for specific keys if there's a better way of
+// doing this.
+// May return 0 if the size is unknown/unknowable.
+template <typename Key>
+size_t EncodedSizeOfKey(Key, const typename Key::ValueType& value) {
+  return Key::Encode(value).size();
+}
+
 // grpc-timeout metadata trait.
 // ValueType is defined as Timestamp - an absolute timestamp (i.e. a
 // deadline!), that is converted to a duration by transports before being
@@ -59,23 +71,9 @@ struct GrpcTimeoutMetadata {
   using ValueType = Timestamp;
   using MementoType = Duration;
   static absl::string_view key() { return "grpc-timeout"; }
-  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error) {
-    auto timeout = ParseTimeout(value);
-    if (!timeout.has_value()) {
-      on_error("invalid value", value);
-      return Duration::Infinity();
-    }
-    return *timeout;
-  }
-  static ValueType MementoToValue(MementoType timeout) {
-    if (timeout == Duration::Infinity()) {
-      return Timestamp::InfFuture();
-    }
-    return ExecCtx::Get()->Now() + timeout;
-  }
-  static Slice Encode(ValueType x) {
-    return Timeout::FromDuration(x - ExecCtx::Get()->Now()).Encode();
-  }
+  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error);
+  static ValueType MementoToValue(MementoType timeout);
+  static Slice Encode(ValueType x);
   static std::string DisplayValue(MementoType x) { return x.ToString(); }
 };
 
@@ -91,90 +89,45 @@ struct TeMetadata {
   };
   using MementoType = ValueType;
   static absl::string_view key() { return "te"; }
-  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error) {
-    auto out = kInvalid;
-    if (value == "trailers") {
-      out = kTrailers;
-    } else {
-      on_error("invalid value", value);
-    }
-    return out;
-  }
+  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error);
   static ValueType MementoToValue(MementoType te) { return te; }
   static StaticSlice Encode(ValueType x) {
     GPR_ASSERT(x == kTrailers);
     return StaticSlice::FromStaticString("trailers");
   }
-  static const char* DisplayValue(MementoType te) {
-    switch (te) {
-      case ValueType::kTrailers:
-        return "trailers";
-      default:
-        return "<discarded-invalid-value>";
-    }
-  }
+  static const char* DisplayValue(MementoType te);
 };
 
+inline size_t EncodedSizeOfKey(TeMetadata, TeMetadata::ValueType x) {
+  return x == TeMetadata::kTrailers ? 8 : 0;
+}
+
 // content-type metadata trait.
 struct ContentTypeMetadata {
   static constexpr bool kRepeatable = false;
   // gRPC says that content-type can be application/grpc[;something]
   // Core has only ever verified the prefix.
   // IF we want to start verifying more, we can expand this type.
-  enum ValueType {
+  enum ValueType : uint8_t {
     kApplicationGrpc,
     kEmpty,
     kInvalid,
   };
   using MementoType = ValueType;
   static absl::string_view key() { return "content-type"; }
-  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error) {
-    auto out = kInvalid;
-    auto value_string = value.as_string_view();
-    if (value_string == "application/grpc") {
-      out = kApplicationGrpc;
-    } else if (absl::StartsWith(value_string, "application/grpc;")) {
-      out = kApplicationGrpc;
-    } else if (absl::StartsWith(value_string, "application/grpc+")) {
-      out = kApplicationGrpc;
-    } else if (value_string.empty()) {
-      out = kEmpty;
-    } else {
-      on_error("invalid value", value);
-    }
-    return out;
-  }
+  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error);
   static ValueType MementoToValue(MementoType content_type) {
     return content_type;
   }
-  static StaticSlice Encode(ValueType x) {
-    switch (x) {
-      case kEmpty:
-        return StaticSlice::FromStaticString("");
-      case kApplicationGrpc:
-        return StaticSlice::FromStaticString("application/grpc");
-      case kInvalid:
-        return StaticSlice::FromStaticString("application/grpc+unknown");
-    }
-    GPR_UNREACHABLE_CODE(
-        return StaticSlice::FromStaticString("unrepresentable value"));
-  }
-  static const char* DisplayValue(MementoType content_type) {
-    switch (content_type) {
-      case ValueType::kApplicationGrpc:
-        return "application/grpc";
-      case ValueType::kEmpty:
-        return "";
-      default:
-        return "<discarded-invalid-value>";
-    }
-  }
+
+  static StaticSlice Encode(ValueType x);
+  static const char* DisplayValue(MementoType content_type);
 };
 
 // scheme metadata trait.
 struct HttpSchemeMetadata {
   static constexpr bool kRepeatable = false;
-  enum ValueType {
+  enum ValueType : uint8_t {
     kHttp,
     kHttps,
     kInvalid,
@@ -185,92 +138,33 @@ struct HttpSchemeMetadata {
     return Parse(value.as_string_view(), on_error);
   }
   static ValueType Parse(absl::string_view value,
-                         MetadataParseErrorFn on_error) {
-    if (value == "http") {
-      return kHttp;
-    } else if (value == "https") {
-      return kHttps;
-    }
-    on_error("invalid value", Slice::FromCopiedBuffer(value));
-    return kInvalid;
-  }
+                         MetadataParseErrorFn on_error);
   static ValueType MementoToValue(MementoType content_type) {
     return content_type;
   }
-  static StaticSlice Encode(ValueType x) {
-    switch (x) {
-      case kHttp:
-        return StaticSlice::FromStaticString("http");
-      case kHttps:
-        return StaticSlice::FromStaticString("https");
-      default:
-        abort();
-    }
-  }
-  static const char* DisplayValue(MementoType content_type) {
-    switch (content_type) {
-      case kHttp:
-        return "http";
-      case kHttps:
-        return "https";
-      default:
-        return "<discarded-invalid-value>";
-    }
-  }
+  static StaticSlice Encode(ValueType x);
+  static const char* DisplayValue(MementoType content_type);
 };
 
+size_t EncodedSizeOfKey(HttpSchemeMetadata, HttpSchemeMetadata::ValueType x);
+
 // method metadata trait.
 struct HttpMethodMetadata {
   static constexpr bool kRepeatable = false;
-  enum ValueType {
+  enum ValueType : uint8_t {
     kPost,
-    kPut,
     kGet,
+    kPut,
     kInvalid,
   };
   using MementoType = ValueType;
   static absl::string_view key() { return ":method"; }
-  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error) {
-    auto out = kInvalid;
-    auto value_string = value.as_string_view();
-    if (value_string == "POST") {
-      out = kPost;
-    } else if (value_string == "PUT") {
-      out = kPut;
-    } else if (value_string == "GET") {
-      out = kGet;
-    } else {
-      on_error("invalid value", value);
-    }
-    return out;
-  }
+  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error);
   static ValueType MementoToValue(MementoType content_type) {
     return content_type;
   }
-  static StaticSlice Encode(ValueType x) {
-    switch (x) {
-      case kPost:
-        return StaticSlice::FromStaticString("POST");
-      case kPut:
-        return StaticSlice::FromStaticString("PUT");
-      case kGet:
-        return StaticSlice::FromStaticString("GET");
-      default:
-        abort();
-    }
-  }
-  static const char* DisplayValue(MementoType content_type) {
-    switch (content_type) {
-      case kPost:
-        return "POST";
-      case kPut:
-        return "PUT";
-      case kGet:
-        return "GET";
-      default:
-        return "<discarded-invalid-value>";
-    }
-  }
+  static StaticSlice Encode(ValueType x);
+  static const char* DisplayValue(MementoType content_type);
 };
 
 // Base type for metadata pertaining to a single compression algorithm
@@ -278,14 +172,7 @@ struct HttpMethodMetadata {
 struct CompressionAlgorithmBasedMetadata {
   using ValueType = grpc_compression_algorithm;
   using MementoType = ValueType;
-  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error) {
-    auto algorithm = ParseCompressionAlgorithm(value.as_string_view());
-    if (!algorithm.has_value()) {
-      on_error("invalid value", value);
-      return GRPC_COMPRESS_NONE;
-    }
-    return *algorithm;
-  }
+  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error);
   static ValueType MementoToValue(MementoType x) { return x; }
   static Slice Encode(ValueType x) {
     GPR_ASSERT(x != GRPC_COMPRESS_ALGORITHMS_COUNT);
@@ -323,7 +210,7 @@ struct GrpcAcceptEncodingMetadata {
   }
   static ValueType MementoToValue(MementoType x) { return x; }
   static Slice Encode(ValueType x) { return x.ToSlice(); }
-  static std::string DisplayValue(MementoType x) { return x.ToString(); }
+  static absl::string_view DisplayValue(MementoType x) { return x.ToString(); }
 };
 
 struct SimpleSliceBasedMetadata {
@@ -357,10 +244,10 @@ struct HostMetadata : public SimpleSliceBasedMetadata {
   static absl::string_view key() { return "host"; }
 };
 
-// x-endpoint-load-metrics-bin metadata trait.
-struct XEndpointLoadMetricsBinMetadata : public SimpleSliceBasedMetadata {
+// endpoint-load-metrics-bin metadata trait.
+struct EndpointLoadMetricsBinMetadata : public SimpleSliceBasedMetadata {
   static constexpr bool kRepeatable = false;
-  static absl::string_view key() { return "x-endpoint-load-metrics-bin"; }
+  static absl::string_view key() { return "endpoint-load-metrics-bin"; }
 };
 
 // grpc-server-stats-bin metadata trait.
@@ -393,9 +280,9 @@ struct HttpPathMetadata : public SimpleSliceBasedMetadata {
   static absl::string_view key() { return ":path"; }
 };
 
-// We separate SimpleIntBasedMetadata into two pieces: one that does not depend
-// on the invalid value, and one that does. This allows the compiler to easily
-// see the functions that are shared, and helps reduce code bloat here.
+// We separate SimpleIntBasedMetadata into two pieces: one that does not
+// depend on the invalid value, and one that does. This allows the compiler to
+// easily see the functions that are shared, and helps reduce code bloat here.
 template <typename Int>
 struct SimpleIntBasedMetadataBase {
   using ValueType = Int;
@@ -441,14 +328,7 @@ struct GrpcRetryPushbackMsMetadata {
   static ValueType MementoToValue(MementoType x) { return x; }
   static Slice Encode(Duration x) { return Slice::FromInt64(x.millis()); }
   static int64_t DisplayValue(Duration x) { return x.millis(); }
-  static Duration ParseMemento(Slice value, MetadataParseErrorFn on_error) {
-    int64_t out;
-    if (!absl::SimpleAtoi(value.as_string_view(), &out)) {
-      on_error("not an integer", value);
-      return Duration::NegativeInfinity();
-    }
-    return Duration::Milliseconds(out);
-  }
+  static Duration ParseMemento(Slice value, MetadataParseErrorFn on_error);
 };
 
 // :status metadata trait.
@@ -461,6 +341,7 @@ struct HttpStatusMetadata : public SimpleIntBasedMetadata<uint32_t, 0> {
 // "secret" metadata trait used to pass load balancing token between filters.
 // This should not be exposed outside of gRPC core.
 class GrpcLbClientStats;
+
 struct GrpcLbClientStatsMetadata {
   static constexpr bool kRepeatable = false;
   static absl::string_view key() { return "grpclb_client_stats"; }
@@ -474,6 +355,11 @@ struct GrpcLbClientStatsMetadata {
   }
 };
 
+inline size_t EncodedSizeOfKey(GrpcLbClientStatsMetadata,
+                               GrpcLbClientStatsMetadata::ValueType) {
+  return 0;
+}
+
 // lb-token metadata
 struct LbTokenMetadata : public SimpleSliceBasedMetadata {
   static constexpr bool kRepeatable = false;
@@ -490,28 +376,9 @@ struct LbCostBinMetadata {
   };
   using MementoType = ValueType;
   static ValueType MementoToValue(MementoType value) { return value; }
-  static Slice Encode(const ValueType& x) {
-    auto slice =
-        MutableSlice::CreateUninitialized(sizeof(double) + x.name.length());
-    memcpy(slice.data(), &x.cost, sizeof(double));
-    memcpy(slice.data() + sizeof(double), x.name.data(), x.name.length());
-    return Slice(std::move(slice));
-  }
-  static std::string DisplayValue(MementoType x) {
-    return absl::StrCat(x.name, ":", x.cost);
-  }
-  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error) {
-    if (value.length() < sizeof(double)) {
-      on_error("too short", value);
-      return {0, ""};
-    }
-    MementoType out;
-    memcpy(&out.cost, value.data(), sizeof(double));
-    out.name = std::string(
-        reinterpret_cast<const char*>(value.data()) + sizeof(double),
-        value.length() - sizeof(double));
-    return out;
-  }
+  static Slice Encode(const ValueType& x);
+  static std::string DisplayValue(MementoType x);
+  static MementoType ParseMemento(Slice value, MetadataParseErrorFn on_error);
 };
 
 // Annotation added by a transport to note whether a failed request was never
@@ -523,14 +390,15 @@ struct GrpcStreamNetworkState {
     kNotSentOnWire,
     kNotSeenByServer,
   };
-  static std::string DisplayValue(ValueType x) {
-    switch (x) {
-      case kNotSentOnWire:
-        return "not sent on wire";
-      case kNotSeenByServer:
-        return "not seen by server";
-    }
-  }
+  static std::string DisplayValue(ValueType x);
+};
+
+// Annotation added by a server transport to note the peer making a request.
+struct PeerString {
+  static absl::string_view DebugKey() { return "PeerString"; }
+  static constexpr bool kRepeatable = false;
+  using ValueType = absl::string_view;
+  static std::string DisplayValue(ValueType x);
 };
 
 // Annotation added by various systems to describe the reason for a failure.
@@ -538,16 +406,59 @@ struct GrpcStatusContext {
   static absl::string_view DebugKey() { return "GrpcStatusContext"; }
   static constexpr bool kRepeatable = true;
   using ValueType = std::string;
-  static const std::string& DisplayValue(const std::string& x) { return x; }
+  static const std::string& DisplayValue(const std::string& x);
+};
+
+// Annotation added by a transport to note that the status came from the wire.
+struct GrpcStatusFromWire {
+  static absl::string_view DebugKey() { return "GrpcStatusFromWire"; }
+  static constexpr bool kRepeatable = false;
+  using ValueType = bool;
+  static absl::string_view DisplayValue(bool x) { return x ? "true" : "false"; }
+};
+
+// Annotation added by client surface code to denote wait-for-ready state
+struct WaitForReady {
+  struct ValueType {
+    bool value = false;
+    bool explicitly_set = false;
+  };
+  static absl::string_view DebugKey() { return "WaitForReady"; }
+  static constexpr bool kRepeatable = false;
+  static std::string DisplayValue(ValueType x);
+};
+
+// Annotation added by a transport to note that server trailing metadata
+// is a Trailers-Only response.
+struct GrpcTrailersOnly {
+  static absl::string_view DebugKey() { return "GrpcTrailersOnly"; }
+  static constexpr bool kRepeatable = false;
+  using ValueType = bool;
+  static absl::string_view DisplayValue(bool x) { return x ? "true" : "false"; }
 };
 
 namespace metadata_detail {
 
-// IsEncodable: Given a trait, determine if that trait is encodable, or is just
-// a value attached to a MetadataMap.
-// We use the presence of the key() static method to determine if a trait is
-// encodable or not - encodable traits have string names, and non-encodable
-// traits do not.
+// Build a key/value formatted debug string.
+// Output looks like 'key1: value1, key2: value2'
+// The string is expected to be readable, but not necessarily parsable.
+class DebugStringBuilder {
+ public:
+  // Add one key/value pair to the output.
+  void Add(absl::string_view key, absl::string_view value);
+
+  // Finalize the output and return the string.
+  // Subsequent Add calls are UB.
+  std::string TakeOutput() { return std::move(out_); }
+
+ private:
+  std::string out_;
+};
+
+// IsEncodable: Given a trait, determine if that trait is encodable, or is
+// just a value attached to a MetadataMap. We use the presence of the key()
+// static method to determine if a trait is encodable or not - encodable
+// traits have string names, and non-encodable traits do not.
 template <typename Trait, typename Ignored = void>
 struct IsEncodableTrait {
   static const bool value = false;
@@ -597,8 +508,8 @@ struct NameLookup<void> {
 };
 
 // Helper to take a slice to a memento to a value.
-// By splitting this part out we can scale code size as the number of (memento,
-// value) types, rather than as the number of traits.
+// By splitting this part out we can scale code size as the number of
+// (memento, value) types, rather than as the number of traits.
 template <typename ParseMementoFn, typename MementoToValueFn>
 struct ParseValue {
   template <ParseMementoFn parse_memento, MementoToValueFn memento_to_value>
@@ -626,7 +537,7 @@ class ParseHelper {
     return ParsedMetadata<Container>(
         trait,
         ParseValueToMemento<typename Trait::MementoType, Trait::ParseMemento>(),
-        transport_size_);
+        static_cast<uint32_t>(transport_size_));
   }
 
   GPR_ATTRIBUTE_NOINLINE ParsedMetadata<Container> NotFound(
@@ -647,8 +558,8 @@ class ParseHelper {
 };
 
 // This is an "Op" type for NameLookup.
-// Used for MetadataMap::Append, its Found/NotFound methods turn a slice into a
-// value and add it to a container.
+// Used for MetadataMap::Append, its Found/NotFound methods turn a slice into
+// a value and add it to a container.
 template <typename Container>
 class AppendHelper {
  public:
@@ -665,7 +576,7 @@ class AppendHelper {
   }
 
   GPR_ATTRIBUTE_NOINLINE void NotFound(absl::string_view key) {
-    container_->AppendUnknown(key, std::move(value_));
+    container_->unknown_.Append(key, std::move(value_));
   }
 
  private:
@@ -688,7 +599,7 @@ class RemoveHelper {
   }
 
   GPR_ATTRIBUTE_NOINLINE void NotFound(absl::string_view key) {
-    container_->RemoveUnknown(key);
+    container_->unknown_.Remove(key);
   }
 
  private:
@@ -696,8 +607,8 @@ class RemoveHelper {
 };
 
 // This is an "Op" type for NameLookup.
-// Used for MetadataMap::GetStringValue, its Found/NotFound methods generated a
-// string value from the container.
+// Used for MetadataMap::GetStringValue, its Found/NotFound methods generated
+// a string value from the container.
 template <typename Container>
 class GetStringValueHelper {
  public:
@@ -747,7 +658,7 @@ class GetStringValueHelper {
 
   GPR_ATTRIBUTE_NOINLINE absl::optional<absl::string_view> NotFound(
       absl::string_view key) {
-    return container_->GetStringValueUnknown(key, backing_);
+    return container_->unknown_.GetStringValue(key, backing_);
   }
 
  private:
@@ -760,7 +671,24 @@ using LogFn = absl::FunctionRef<void(absl::string_view, absl::string_view)>;
 
 template <typename T>
 struct AdaptDisplayValueToLog {
-  static std::string ToString(const T& value) { return absl::StrCat(value); }
+  static std::string ToString(const T& value) { return std::to_string(value); }
+};
+
+template <>
+struct AdaptDisplayValueToLog<std::string> {
+  static std::string ToString(const std::string& value) { return value; }
+};
+
+template <>
+struct AdaptDisplayValueToLog<const std::string&> {
+  static std::string ToString(const std::string& value) { return value; }
+};
+
+template <>
+struct AdaptDisplayValueToLog<absl::string_view> {
+  static std::string ToString(absl::string_view value) {
+    return std::string(value);
+  }
 };
 
 template <>
@@ -806,6 +734,10 @@ struct Value<Which, absl::enable_if_t<Which::kRepeatable == false &&
   void EncodeTo(Encoder* encoder) const {
     encoder->Encode(Which(), value);
   }
+  template <typename Encoder>
+  void VisitWith(Encoder* encoder) const {
+    return EncodeTo(encoder);
+  }
   void LogTo(LogFn log_fn) const {
     LogKeyValueTo(Which::key(), value, Which::Encode, log_fn);
   }
@@ -830,6 +762,10 @@ struct Value<Which, absl::enable_if_t<Which::kRepeatable == false &&
   }
   template <typename Encoder>
   void EncodeTo(Encoder*) const {}
+  template <typename Encoder>
+  void VisitWith(Encoder* encoder) const {
+    encoder->Encode(Which(), value);
+  }
   void LogTo(LogFn log_fn) const {
     LogKeyValueTo(Which::DebugKey(), value, Which::DisplayValue, log_fn);
   }
@@ -861,6 +797,10 @@ struct Value<Which, absl::enable_if_t<Which::kRepeatable == true &&
       encoder->Encode(Which(), v);
     }
   }
+  template <typename Encoder>
+  void VisitWith(Encoder* encoder) const {
+    return EncodeTo(encoder);
+  }
   void LogTo(LogFn log_fn) const {
     for (const auto& v : value) {
       LogKeyValueTo(Which::key(), v, Which::Encode, log_fn);
@@ -890,6 +830,12 @@ struct Value<Which, absl::enable_if_t<Which::kRepeatable == true &&
   }
   template <typename Encoder>
   void EncodeTo(Encoder*) const {}
+  template <typename Encoder>
+  void VisitWith(Encoder* encoder) const {
+    for (const auto& v : value) {
+      encoder->Encode(Which(), v);
+    }
+  }
   void LogTo(LogFn log_fn) const {
     for (const auto& v : value) {
       LogKeyValueTo(Which::DebugKey(), v, Which::DisplayValue, log_fn);
@@ -916,7 +862,7 @@ class CopySink {
   }
 
   void Encode(const Slice& key, const Slice& value) {
-    dst_->AppendUnknown(key.as_string_view(), value.Ref());
+    dst_->unknown_.Append(key.as_string_view(), value.Ref());
   }
 
  private:
@@ -934,6 +880,17 @@ struct EncodeWrapper {
   }
 };
 
+// Callable for the table ForEach in ForEach() -- for each value, call the
+// appropriate visitor method.
+template <typename Encoder>
+struct ForEachWrapper {
+  Encoder* encoder;
+  template <typename Which>
+  void operator()(const Value<Which>& which) {
+    which.VisitWith(encoder);
+  }
+};
+
 // Callable for the ForEach in Log()
 struct LogWrapper {
   LogFn log_fn;
@@ -972,6 +929,31 @@ class TransportSizeEncoder {
   uint32_t size_ = 0;
 };
 
+// Handle unknown (non-trait-based) fields in the metadata map.
+class UnknownMap {
+ public:
+  explicit UnknownMap(Arena* arena) : unknown_(arena) {}
+
+  using BackingType = ChunkedVector<std::pair<Slice, Slice>, 10>;
+
+  void Append(absl::string_view key, Slice value);
+  void Remove(absl::string_view key);
+  absl::optional<absl::string_view> GetStringValue(absl::string_view key,
+                                                   std::string* backing) const;
+
+  BackingType::ConstForwardIterator begin() const { return unknown_.cbegin(); }
+  BackingType::ConstForwardIterator end() const { return unknown_.cend(); }
+
+  bool empty() const { return unknown_.empty(); }
+  size_t size() const { return unknown_.size(); }
+  void Clear() { unknown_.Clear(); }
+  Arena* arena() const { return unknown_.arena(); }
+
+ private:
+  // Backing store for added metadata.
+  ChunkedVector<std::pair<Slice, Slice>, 10> unknown_;
+};
+
 }  // namespace metadata_detail
 
 // Helper function for encoders
@@ -1032,21 +1014,23 @@ MetadataValueAsSlice(typename Which::ValueType value) {
 //   // Parse a memento from a slice
 //   // Takes ownership of value
 //   // Calls fn in the case of an error that should be reported to the user
-//   static MementoType ParseMemento(Slice value, MementoParseErrorFn fn) { ...
+//   static MementoType ParseMemento(Slice value, MementoParseErrorFn fn) {
+//   ...
 //   }
 //   // Convert a memento to a value
 //   static ValueType MementoToValue(MementoType memento) { ... }
 //   // Convert a value to its canonical text wire format (the format that
 //   // ParseMemento will accept!)
 //   static Slice Encode(const ValueType& value);
-//   // Convert a value to something that can be passed to StrCat and displayed
+//   // Convert a value to something that can be passed to StrCat and
+//   displayed
 //   // for debugging
 //   static SomeStrCatableType DisplayValue(MementoType value) { ... }
 // };
 //
-// Non-encodable traits are determined by missing the key() method, and have the
-// following signature (and by convention omit the Metadata part of the type
-// name):
+// Non-encodable traits are determined by missing the key() method, and have
+// the following signature (and by convention omit the Metadata part of the
+// type name):
 // // Traits for the GrpcXyz field:
 // struct GrpcXyz {
 //   // The string key that should be used for debug dumps - should not be a
@@ -1056,7 +1040,8 @@ MetadataValueAsSlice(typename Which::ValueType value) {
 //   static constexpr bool kRepeatable = ...;
 //   // The type that's stored on MetadataBatch
 //   using ValueType = ...;
-//   // Convert a value to something that can be passed to StrCat and displayed
+//   // Convert a value to something that can be passed to StrCat and
+//   displayed
 //   // for debugging
 //   static SomeStrCatableType DisplayValue(ValueType value) { ... }
 // };
@@ -1069,10 +1054,10 @@ MetadataValueAsSlice(typename Which::ValueType value) {
 // in the compression table. This is what mementos are used for.
 //
 // A trait offers the capability to turn a slice into a memento via
-// ParseMemento. This is exposed to users of MetadataMap via the Parse() method,
-// that returns a ParsedMetadata object. That ParsedMetadata object can in turn
-// be used to set the same value on many different MetadataMaps without having
-// to reparse.
+// ParseMemento. This is exposed to users of MetadataMap via the Parse()
+// method, that returns a ParsedMetadata object. That ParsedMetadata object
+// can in turn be used to set the same value on many different MetadataMaps
+// without having to reparse.
 //
 // Implementation wise, ParsedMetadata is a type erased wrapper around
 // MementoType. When we set a value on MetadataMap, we first turn that memento
@@ -1103,13 +1088,21 @@ class MetadataMap {
   //    void Encode(TraitsType, typename TraitsType::ValueType value);
   // For fields for which we do not have traits, this will be a method
   // with the signature:
-  //    void Encode(grpc_mdelem md);
-  // TODO(ctiller): It's expected that the latter Encode method will
-  // become Encode(Slice, Slice) by the end of the current metadata API
-  // transitions.
+  //    void Encode(string_view key, Slice value);
   template <typename Encoder>
   void Encode(Encoder* encoder) const {
-    table_.ForEach(metadata_detail::EncodeWrapper<Encoder>{encoder});
+    table_.template ForEachIn<metadata_detail::EncodeWrapper<Encoder>,
+                              Value<Traits>...>(
+        metadata_detail::EncodeWrapper<Encoder>{encoder});
+    for (const auto& unk : unknown_) {
+      encoder->Encode(unk.first, unk.second);
+    }
+  }
+
+  // Like Encode, but also visit the non-encodable fields.
+  template <typename Encoder>
+  void ForEach(Encoder* encoder) const {
+    table_.ForEach(metadata_detail::ForEachWrapper<Encoder>{encoder});
     for (const auto& unk : unknown_) {
       encoder->Encode(unk.first, unk.second);
     }
@@ -1125,12 +1118,11 @@ class MetadataMap {
   }
 
   std::string DebugString() const {
-    std::string out;
-    Log([&out](absl::string_view key, absl::string_view value) {
-      if (!out.empty()) out.append(", ");
-      absl::StrAppend(&out, absl::CEscape(key), ": ", absl::CEscape(value));
+    metadata_detail::DebugStringBuilder builder;
+    Log([&builder](absl::string_view key, absl::string_view value) {
+      builder.Add(key, value);
     });
-    return out;
+    return builder.TakeOutput();
   }
 
   // Get the pointer to the value of some known metadata.
@@ -1277,36 +1269,9 @@ class MetadataMap {
   template <typename Which>
   using Value = metadata_detail::Value<Which>;
 
-  void AppendUnknown(absl::string_view key, Slice value) {
-    unknown_.EmplaceBack(Slice::FromCopiedString(key), value.Ref());
-  }
-
-  void RemoveUnknown(absl::string_view key) {
-    unknown_.SetEnd(std::remove_if(unknown_.begin(), unknown_.end(),
-                                   [key](const std::pair<Slice, Slice>& p) {
-                                     return p.first.as_string_view() == key;
-                                   }));
-  }
-
-  absl::optional<absl::string_view> GetStringValueUnknown(
-      absl::string_view key, std::string* backing) const {
-    absl::optional<absl::string_view> out;
-    for (const auto& p : unknown_) {
-      if (p.first.as_string_view() == key) {
-        if (!out.has_value()) {
-          out = p.second.as_string_view();
-        } else {
-          out = *backing = absl::StrCat(*out, ",", p.second.as_string_view());
-        }
-      }
-    }
-    return out;
-  }
-
   // Table of known metadata types.
-  Table<Value<Traits>...> table_;
-  // Backing store for added metadata.
-  ChunkedVector<std::pair<Slice, Slice>, 10> unknown_;
+  PackedTable<Value<Traits>...> table_;
+  metadata_detail::UnknownMap unknown_;
 };
 
 // Ok/not-ok check for metadata maps that contain GrpcStatusMetadata, so that
@@ -1324,8 +1289,8 @@ template <typename Derived, typename... Traits>
 MetadataMap<Derived, Traits...>::MetadataMap(MetadataMap&& other) noexcept
     : table_(std::move(other.table_)), unknown_(std::move(other.unknown_)) {}
 
-// We never create MetadataMap directly, instead we create Derived, but we want
-// to be able to move it without redeclaring this.
+// We never create MetadataMap directly, instead we create Derived, but we
+// want to be able to move it without redeclaring this.
 // NOLINTNEXTLINE(misc-unconventional-assign-operator)
 template <typename Derived, typename... Traits>
 Derived& MetadataMap<Derived, Traits...>::operator=(
@@ -1355,7 +1320,7 @@ template <typename Derived, typename... Traits>
 Derived MetadataMap<Derived, Traits...>::Copy() const {
   Derived out(unknown_.arena());
   metadata_detail::CopySink<Derived> sink(&out);
-  Encode(&sink);
+  ForEach(&sink);
   return out;
 }
 
@@ -1376,15 +1341,17 @@ using grpc_metadata_batch_base = grpc_core::MetadataMap<
     grpc_core::GrpcTimeoutMetadata, grpc_core::GrpcPreviousRpcAttemptsMetadata,
     grpc_core::GrpcRetryPushbackMsMetadata, grpc_core::UserAgentMetadata,
     grpc_core::GrpcMessageMetadata, grpc_core::HostMetadata,
-    grpc_core::XEndpointLoadMetricsBinMetadata,
+    grpc_core::EndpointLoadMetricsBinMetadata,
     grpc_core::GrpcServerStatsBinMetadata, grpc_core::GrpcTraceBinMetadata,
     grpc_core::GrpcTagsBinMetadata, grpc_core::GrpcLbClientStatsMetadata,
     grpc_core::LbCostBinMetadata, grpc_core::LbTokenMetadata,
     // Non-encodable things
-    grpc_core::GrpcStreamNetworkState, grpc_core::GrpcStatusContext>;
+    grpc_core::GrpcStreamNetworkState, grpc_core::PeerString,
+    grpc_core::GrpcStatusContext, grpc_core::GrpcStatusFromWire,
+    grpc_core::WaitForReady, grpc_core::GrpcTrailersOnly>;
 
 struct grpc_metadata_batch : public grpc_metadata_batch_base {
   using grpc_metadata_batch_base::grpc_metadata_batch_base;
 };
 
-#endif /* GRPC_CORE_LIB_TRANSPORT_METADATA_BATCH_H */
+#endif  // GRPC_SRC_CORE_LIB_TRANSPORT_METADATA_BATCH_H