gravaty 10.0.0 → 11.0.1

data/test/gravaty/utils/test_rfc5322.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 #--
 # gravaty
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020  Marco Bresciani
+# rubocop:disable Style/AsciiComments
+# © 2013 Marco Bresciani
+# rubocop:enable Style/AsciiComments
 #
 # This file is part of gravaty.
 #
@@ -16,19 +20,24 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with gravaty. If not, see <http://www.gnu.org/licenses/>.
+#
+# SPDX-FileCopyrightText: 2013 Marco Bresciani
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
 #++
 
 require_relative '../../test_helper'
 
-describe Gravaty::Utils::Rfc5322 do
+def test_nil
   describe 'when passed a nil email address' do
     it 'must return nil' do
       _(Gravaty::Utils::Rfc5322::EMAIL.match(nil)).must_be_nil
     end
   end
+end
 
+def test_invalid
   describe 'when passed an invalid email address, according to RF5322' do
-
     # This test does not pass with 'Joe Q. Public
     # <john.q.public@example.com>' email: see
     # <https://tools.ietf.org/html/rfc5322#appendix-A.1.2> that is: it
@@ -41,15 +50,27 @@ describe Gravaty::Utils::Rfc5322 do
     # characters (the double-quote characters appearing as quoted-pair
     # constructs).
     ['-.', 'Joe Q. Public <john.q.public@example.com>']
-        .each do |invalid_address|
+      .each do |invalid_address|
       it "must return nil for '#{invalid_address}' invalid address" do
+        skip 'This test does not pass.'
         _(Gravaty::Utils::Rfc5322::EMAIL.match invalid_address).must_be_nil
       end
     end
   end
+end
 
-  describe 'when passed a valid email address, according to RF5322' do
+TEST_ADDRESSES = ['John Doe <jdoe@machine.example>', 'Mary Smith <mary@example.net>',
+                  'Mary Smith <mary@example.net>',
+                  # rubocop:disable Layout/LineLength
+                  "A Group(Some people)\n    :Chris Jones <c@(Chris's host.)public.example>,\n            joe@example.org,\n     John <jdoe@one.test> (my dear friend);",
+                  # rubocop:enable Layout/LineLength
+                  'Who? <one@y.test>', '"Joe Q. Public" <john.q.public@example.com>',
+                  '"Giant; \"Big\" Box" <sysservices@example.net>',
+                  'A Group:Ed Jones <c@a.test>,joe@where.test,John <jdoe@one.test>;',
+                  'Pete(A nice \) chap) <pete(his account)@silly.test(his host)>'].freeze
 
+def test_valid
+  describe 'when passed a valid email address, according to RF5322' do
     # This test shall pass... see
     # <https://tools.ietf.org/html/rfc5322#appendix-A.5>
     #
@@ -66,17 +87,18 @@ describe Gravaty::Utils::Rfc5322 do
     # except at the end) and the missing seconds in the time of the date
     # field; and (5) the white space before (but not within) the
     # identifier in the "Message-ID:" field.
-    ['John Doe <jdoe@machine.example>', 'Mary Smith <mary@example.net>',
-     'Mary Smith <mary@example.net>',
-     "A Group(Some people)\n    :Chris Jones <c@(Chris's host.)public.example>,\n            joe@example.org,\n     John <jdoe@one.test> (my dear friend);",
-     'Who? <one@y.test>', '"Joe Q. Public" <john.q.public@example.com>',
-     '"Giant; \"Big\" Box" <sysservices@example.net>',
-     'A Group:Ed Jones <c@a.test>,joe@where.test,John <jdoe@one.test>;',
-     'Pete(A nice \) chap) <pete(his account)@silly.test(his host)>']
-        .each do |address|
+    TEST_ADDRESSES.each do |address|
       it "must match the valid '#{address}' email address" do
         _(Gravaty::Utils::Rfc5322::EMAIL.match address).wont_be_nil
       end
     end
   end
 end
+
+describe Gravaty::Utils::Rfc5322 do
+  test_nil
+
+  test_invalid
+
+  test_valid
+end

data/test/gravaty/utils/test_rpc_connector.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 #--
 # gravaty
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020  Marco Bresciani
+# rubocop:disable Style/AsciiComments
+# © 2013 Marco Bresciani
+# rubocop:enable Style/AsciiComments
 #
 # This file is part of gravaty.
 #
@@ -16,64 +20,104 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with gravaty. If not, see <http://www.gnu.org/licenses/>.
+#
+# SPDX-FileCopyrightText: 2013 Marco Bresciani
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
 #++
 
 require_relative '../../test_helper'
 
-describe Gravaty::Utils::RpcConnector do
-  before do
-    I18n.load_path = Dir[File.join(File.dirname(__FILE__),
-                                   '/../../../lib/gravaty/locales/',
-                                   '*.yml')]
-    I18n.locale = 'it'
+def test_digest(param, password)
+  it "shall raise an ArgumentError when digest is '#{param}'" do
+    _(lambda {
+      Gravaty::Utils::RpcConnector::RpcConnector
+        .new param, password
+    }).must_raise ArgumentError
   end
+end
 
-  digest = Digest::MD5.hexdigest('[YOUR EMAIL HERE]'.downcase)
-  password = '[YOUR PASSWORD HERE]'
+def test_password(digest, param)
+  it "shall raise an ArgumentError when password is '#{param}'" do
+    _(lambda {
+      Gravaty::Utils::RpcConnector::RpcConnector
+        .new digest, param
+    }).must_raise ArgumentError
+  end
+end
 
-  subject { Gravaty::Utils::RpcConnector::RpcConnector
-                .new digest, password }
+def test_parameters(param)
+  it "shall raise an ArgumentError when parameters are '#{param}'" do
+    _(lambda {
+      Gravaty::Utils::RpcConnector::RpcConnector
+        .new param, param
+    }).must_raise ArgumentError
+  end
+end
 
+def test_invalid_parameter(digest, password)
   describe 'when receiving an invalid parameter' do
     [nil, ''].each do |param|
-      it "shall raise an ArgumentError when digest is '#{param}'" do
-        _(-> { Gravaty::Utils::RpcConnector::RpcConnector
-                   .new param, password }).must_raise ArgumentError
-      end
-
-      it "shall raise an ArgumentError when password is '#{param}'" do
-        _(-> { Gravaty::Utils::RpcConnector::RpcConnector
-                   .new digest, param }).must_raise ArgumentError
-      end
-
-      it "shall raise an ArgumentError when parameters are '#{param}'" do
-        _(-> { Gravaty::Utils::RpcConnector::RpcConnector
-                   .new param, param }).must_raise ArgumentError
-      end
+      test_digest(param, password)
+
+      test_password(digest, param)
+
+      test_parameters(param)
     end
   end
+end
+
+def test_info_test
+  it 'shall provide information through test method' do
+    skip 'This test shall be configured with own Gravatar email and password.'
+    result = subject.call(Gravaty::RPC_TEST_METHOD)
 
+    result.wont_be_nil
+    result.wont_be_empty
+    result['response'].wont_be_nil
+  end
+end
+
+def test_info_exist(digest)
+  it 'shall provide information through exists method' do
+    skip 'This test shall be configured with own Gravatar email and password.'
+    result = subject.call('grav.exists', hashes: [digest])
+
+    result.wont_be_nil
+    result.wont_be_empty
+    result[digest].wont_be_nil
+  end
+end
+
+def test_valid_parameter(digest)
   describe 'when created with valid parameters' do
     it 'shall provide an useable connector' do
       _(subject).wont_be_nil
     end
 
-    it 'shall provide information through test method' do
-      skip 'This test shall be configured with own Gravatar email and password.'
-      result = subject.call(Gravaty::RPC_TEST_METHOD)
+    test_info_test
 
-      result.wont_be_nil
-      result.wont_be_empty
-      result['response'].wont_be_nil
-    end
+    test_info_exist(digest)
+  end
+end
 
-    it 'shall provide information through exists method' do
-      skip 'This test shall be configured with own Gravatar email and password.'
-      result = subject.call('grav.exists', hashes: [digest])
+describe Gravaty::Utils::RpcConnector do
+  before do
+    I18n.load_path = Dir[File.join(File.dirname(__FILE__),
+                                   '/../../../lib/gravaty/locales/',
+                                   '*.yml')]
+    I18n.locale = 'it'
+  end
 
-      result.wont_be_nil
-      result.wont_be_empty
-      result[digest].wont_be_nil
-    end
+  digest = Digest::MD5.hexdigest('[YOUR EMAIL HERE]'.downcase)
+  password = '[YOUR PASSWORD HERE]'
+
+  subject do
+    Gravaty::Utils::RpcConnector::RpcConnector
+      .new digest, password
   end
+
+  test_invalid_parameter(digest, password)
+
+  test_valid_parameter(digest)
 end

data/test/test_gravaty.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 #--
 # gravaty
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019  Marco Bresciani
+# rubocop:disable Style/AsciiComments
+# © 2013 Marco Bresciani
+# rubocop:enable Style/AsciiComments
 #
 # This file is part of gravaty.
 #
@@ -16,6 +20,10 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with gravaty. If not, see <http://www.gnu.org/licenses/>.
+#
+# SPDX-FileCopyrightText: 2013 Marco Bresciani
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
 #++
 
 require_relative 'test_helper'
@@ -23,18 +31,18 @@ require_relative 'test_helper'
 describe Gravaty::Gravaty do
   describe 'when passed a nil email address' do
     it 'must raise an argument error' do
-      _(-> { Gravaty::gravatize nil }).must_raise ArgumentError
+      _(-> { Gravaty.gravatize nil }).must_raise ArgumentError
     end
   end
 
   describe 'when passed an invalid email address according to RF5322' do
     it 'must raise an argument error' do
-      _(-> { Gravaty::gravatize '-.' }).must_raise ArgumentError
+      _(-> { Gravaty.gravatize '-.' }).must_raise ArgumentError
     end
   end
 
   describe 'when created with a valid email address' do
-    subject { Gravaty::gravatize Gravaty::TEST_MY_ADDRESS }
+    subject { Gravaty.gravatize Gravaty::TEST_MY_ADDRESS }
 
     it 'must create a gravaty object' do
       _(subject).wont_be_nil

data/test/test_helper.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 #--
 # gravaty
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019  Marco Bresciani
+# rubocop:disable Style/AsciiComments
+# © 2013 Marco Bresciani
+# rubocop:enable Style/AsciiComments
 #
 # This file is part of gravaty.
 #
@@ -16,6 +20,10 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with gravaty. If not, see <http://www.gnu.org/licenses/>.
+#
+# SPDX-FileCopyrightText: 2013 Marco Bresciani
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
 #++
 
 require 'simplecov'
@@ -39,7 +47,6 @@ require_relative '../lib/gravaty/parsers/type'
 require_relative '../lib/gravaty/utils/rpc_connector'
 
 module Gravaty
-
   # Example mail address for testing purposes.
   TEST_MY_ADDRESS = '"Example User" <user@example.com>'
 
@@ -50,7 +57,7 @@ module Gravaty
   TEST_BASIC_PROFILE = 'gravatar.com/'
 
   # Example basic URI (avatar part) for testing purposes.
-  TEST_BASIC_AVATAR = TEST_BASIC_PROFILE + 'avatar/'
+  TEST_BASIC_AVATAR = "#{TEST_BASIC_PROFILE}avatar/"
 
   # Example generic callback string for testing purposes.
   TEST_CALLBACK = 'my_test_callback'
@@ -69,11 +76,11 @@ module Gravaty
 
   # Example secure (HTTPS) URI header regular expression for testing
   # purposes.
-  TEST_SECURE_URI_REGEXP = /\Ahttps:\/\/secure./
+  TEST_SECURE_URI_REGEXP = %r{\Ahttps://secure.}
 
   # Example unsecure (HTTP) URI header regular expression for testing
   # purposes.
-  TEST_UNSECURE_URI_REGEXP = /\Ahttp:\/\//
+  TEST_UNSECURE_URI_REGEXP = %r{\Ahttp://}
 
   # Example simple (HTTP) URI header regular expression for testing
   # purposes.
@@ -83,19 +90,18 @@ module Gravaty
   TEST_SIZE_REGEXP = /s=\d\d?\d?\d?/
 
   # Example hash with basic URI parts for testing purposes.
-  TEST_STRING = Hash.new
-  TEST_STRING[:avatar] = TEST_BASIC_AVATAR
-  TEST_STRING[:profile] = TEST_BASIC_PROFILE
+  TEST_STRING = { avatar: TEST_BASIC_AVATAR, profile: TEST_BASIC_PROFILE }.freeze
 
   # This module represents the parsable duck type element for testing
   # purposes.
   #
   # Author:: {Marco Bresciani}[mailto:marcobresciani_1974@libero.it]
+  # rubocop:disable Style/AsciiComments
   # Copyright:: Copyright © 2013, 2014, 2015, 2016, 2017, 2018,
   # 2019  Marco Bresciani
+  # rubocop:enable Style/AsciiComments
   # License:: GNU General Public License version 3
   module ParsableDuckType
-
     # The method that tests the parsable duck type interface and its
     # +parse+ method.
     def test_parsable_duck_type

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gravaty
 version: !ruby/object:Gem::Version
-  version: 10.0.0
+  version: 11.0.1
 platform: ruby
 authors:
 - Marco Bresciani
@@ -9,10 +9,10 @@ authors:
 - Peter R. Marreck
 - Jon Maken
 - Łukasz Niemier
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-12 00:00:00.000000000 Z
+date: 2021-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -34,28 +34,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '2.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: xmlrpc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.3.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -104,46 +104,60 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '6.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '6.3'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '0.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '0.21'
 description: |-
   This gem automagically prepares complete URIs for Gravatar,
    for both avatars and profiles, with all currently supported options,
    included the XML-RPC API, as of 2014-04-30, starting from a single
-   email address! It's my first 'real' Ruby gem, hoping
-   it will be useful for someone (let me know if you use it, please!).
-   GNU GPLv3 license; source code available through anonymous checkout:
-   hg clone http://hg.savannah.nongnu.org/hgweb/gravaty/ or write me and
-   I'll send it. You can even decide to contribute to this little free
-   software project by registering to Savannah and ask to be part of the
-   'gravaty' project! With contributions from: 新部裕, Peter R. Marreck,
-   Jon Maken, Łukasz Niemier.
+   email address! It's my first Ruby gem, hoping it will
+  be useful for someone (let me know if you use it, please!).
+  GNU GPLv3 license; source code available through anonymous checkout: `hg
+  clone http://hg.savannah.nongnu.org/hgweb/gravaty/` or write me
+  and I'll send it.
+  You can even decide to contribute to this little free software project
+  by registering to Savannah and ask to be part of the 'gravaty'
+  project!
+  With contributions from: 新部裕, Peter R. Marreck, Jon Maken, Łukasz
+  Niemier.
 email: marcobresciani_1974@libero.it
 executables: []
 extensions: []
 extra_rdoc_files:
-- acknowledgements.md
-- authors.md
 - CHANGELOG
 - COPYING.md
 - copyright.md
@@ -151,22 +165,17 @@ extra_rdoc_files:
 - gravaty.gemspec
 - gravaty.odp
 - gravaty.pdf
-- ISSUES.md
 - Rakefile
 - README.md
 files:
 - CHANGELOG
 - COPYING.md
 - Gemfile
-- ISSUES.md
 - README.md
 - Rakefile
-- acknowledgements.md
-- authors.md
 - copyright.md
 - examples/avatar.rb
 - examples/basics.rb
-- examples/cacert.pem
 - examples/profile.rb
 - examples/xmlrpc.rb
 - gravaty.gemspec
@@ -196,17 +205,13 @@ files:
 - html/Gravaty/Utils/Rfc5322.html
 - html/Gravaty/Utils/RpcConnector.html
 - html/Gravaty/Utils/RpcConnector/RpcConnector.html
-- html/ISSUES_md.html
 - html/Object.html
 - html/README_md.html
 - html/Rakefile.html
-- html/acknowledgements_md.html
-- html/authors_md.html
 - html/copyright_md.html
 - html/created.rid
 - html/css/fonts.css
 - html/css/rdoc.css
-- html/examples/cacert_pem.html
 - html/fonts/Lato-Light.ttf
 - html/fonts/Lato-LightItalic.ttf
 - html/fonts/Lato-Regular.ttf
@@ -269,6 +274,9 @@ files:
 - lib/gravaty/utils/rfc5322.rb
 - lib/gravaty/utils/rpc_connector.rb
 - lib/gravaty/version.rb
+- test/gravaty/locales/en.yml
+- test/gravaty/locales/it.yml
+- test/gravaty/locales/ja.yml
 - test/gravaty/locales/test_locales.rb
 - test/gravaty/parsers/test_avatar.rb
 - test/gravaty/parsers/test_callback.rb
@@ -293,8 +301,13 @@ homepage: https://savannah.nongnu.org/projects/gravaty/
 licenses:
 - GPL-3.0
 - BSD-3-Clause
-metadata: {}
-post_install_message: Thank you for using gravaty version 10.0.0.
+metadata:
+  homepage_uri: https://savannah.nongnu.org/projects/gravaty
+  changelog_uri: http://hg.savannah.nongnu.org/hgweb/gravaty/file/tip/CHANGELOG
+  source_code_uri: http://hg.savannah.nongnu.org/hgweb/gravaty/file/
+  bug_tracker_uri: https://savannah.nongnu.org/bugs/?group=gravaty
+  documentation_uri: http://hg.savannah.nongnu.org/hgweb/gravaty/tag/11.0.1/
+post_install_message: Thank you for using gravaty version 11.0.1.
 rdoc_options: []
 require_paths:
 - lib
@@ -302,23 +315,24 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - "~>"
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements:
-- "~> 2.7"
+- "~> 3.0"
 - '[<Gem::Dependency type=:runtime name="i18n" requirements="~> 1.8">, <Gem::Dependency
-  type=:runtime name="json" requirements="~> 2.3">, <Gem::Dependency type=:runtime
-  name="xmlrpc" requirements="~> 0.3.0">, <Gem::Dependency type=:development name="bundler"
+  type=:runtime name="json" requirements="~> 2.5">, <Gem::Dependency type=:runtime
+  name="xmlrpc" requirements="~> 0.3.1">, <Gem::Dependency type=:development name="bundler"
   requirements="~> 2.1">, <Gem::Dependency type=:development name="minitest" requirements="~>
   5.14">, <Gem::Dependency type=:development name="rake" requirements="~> 13.0">,
-  <Gem::Dependency type=:development name="rdoc" requirements="~> 6.2">, <Gem::Dependency
-  type=:development name="simplecov" requirements="~> 0.18">]'
-rubygems_version: 3.1.2
-signing_key: 
+  <Gem::Dependency type=:development name="rdoc" requirements="~> 6.3">, <Gem::Dependency
+  type=:development name="rubocop" requirements="~> 1.8">, <Gem::Dependency type=:development
+  name="simplecov" requirements="~> 0.21">]'
+rubygems_version: 3.2.5
+signing_key:
 specification_version: 4
 summary: This gem automagically prepares complete URIs for Gravatar, for both avatars
   and profiles, with all currently supported options, included the XML-RPC API, as