gravaty 10.0.0 → 11.0.1

data/test/gravaty/test_avatar.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 #--
 # gravaty
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020  Marco Bresciani
+# rubocop:disable Style/AsciiComments
+# © 2013 Marco Bresciani
+# rubocop:enable Style/AsciiComments
 #
 # This file is part of gravaty.
 #
@@ -16,93 +20,124 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with gravaty. If not, see <http://www.gnu.org/licenses/>.
+#
+# SPDX-FileCopyrightText: 2013 Marco Bresciani
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
 #++
 
 require_relative '../test_helper'
 
-describe Gravaty::Gravaty do
-  describe 'when created with a valid email address ' do
-
-    subject { Gravaty::Gravaty.new(Gravaty::TEST_MY_ADDRESS,
-                                   Gravaty::parser) }
-
-    Gravaty::AVATAR_FORMATS.each do |avatar|
-      describe "when asked for '#{avatar}' image" do
-        it "shall provide an URI with specified '#{avatar}' image" do
-          _(subject.avatar(type: avatar)).must_include(".#{avatar}")
-        end
+def test_avatar_formats
+  Gravaty::AVATAR_FORMATS.each do |avatar|
+    describe "when asked for '#{avatar}' image" do
+      it "shall provide an URI with specified '#{avatar}' image" do
+        _(subject.avatar(type: avatar)).must_include(".#{avatar}")
       end
     end
+  end
+end
 
-    describe 'when asked for unknown image' do
-      it 'must raise an ArgumentError' do
-        _(-> { subject.avatar type: 'unknown' }).must_raise ArgumentError
+def test_allowed_sizes
+  Gravaty::ALLOWED_SIZES.each do |size|
+    describe "when asked for a size of '#{size}' pixels" do
+      it "shall provide an URI with specified '#{size}' image" do
+        _(subject.avatar(pixelsize: size)).must_match(/#{Gravaty::TEST_SIZE_REGEXP}$/)
       end
     end
+  end
+end
 
-    Gravaty::ALLOWED_SIZES.each do |size|
-      describe "when asked for a size of '#{size}' pixels" do
-        it "shall provide an URI with specified '#{size}' image" do
-          _(subject.avatar(pixelsize: size)).must_match(/#{Gravaty::TEST_SIZE_REGEXP}$/)
-        end
+def test_unallowed_sizes
+  [-1, 0, Gravaty::ALLOWED_SIZES.max + 1].each do |size|
+    describe "when asked for an invalid size of '#{size}' pixels" do
+      it 'must raise an argument error' do
+        _(-> { subject.avatar(pixelsize: size) }).must_raise ArgumentError
       end
     end
+  end
+end
 
-    [-1, 0, Gravaty::ALLOWED_SIZES.max + 1].each do |size|
-      describe "when asked for an invalid size of '#{size}' pixels" do
-        it 'must raise an argument error' do
-          _(-> { subject.avatar(pixelsize: size) }).must_raise ArgumentError
-        end
+def test_rating_options
+  Gravaty::RATING_OPTIONS.each do |rating|
+    describe "when asked for a specific image rating '#{rating}'" do
+      it "shall provide an URI with specified '#{rating}'" do
+        _(subject.avatar(rating: rating)).must_include("rating=#{rating}")
       end
     end
+  end
+end
 
-    Gravaty::RATING_OPTIONS.each do |rating|
-      describe "when asked for a specific image rating '#{rating}'" do
-        it "shall provide an URI with specified '#{rating}'" do
-          _(subject.avatar(rating: rating)).must_include("rating=#{rating}")
-        end
+def test_default_options
+  Gravaty::DEFAULT_OPTIONS.each do |options|
+    describe "when asked for a specific image options '#{options}'" do
+      it "shall provide an URI with option '#{options}'" do
+        _(subject.avatar(default: options)).must_include("d=#{options}")
       end
     end
+  end
+end
 
-    describe 'when asked for unknown rating' do
-      it 'must raise an ArgumentError' do
-        _(-> { subject.avatar rating: 'unknown' }).must_raise ArgumentError
-      end
+def test_own_https_image
+  it 'shall provide a HTTP(S) URI' do
+    ['', 's'].each do |type|
+      an_uri = "http#{type}://www.example.com/example.jpg"
+      _(subject.avatar(default: an_uri)).must_include CGI.escape(an_uri)
     end
+  end
+end
 
-    describe 'when asked for forcing default image' do
-      it 'shall provide a forced URI' do
-        _(subject.avatar(force: true)).must_include Gravaty::TEST_FORCED
-      end
+def test_own_default_image
+  describe 'when provided with a own default image' do
+    test_own_https_image
+
+    it 'must raise an ArgumentError when default parameter is not correct' do
+      _(-> { subject.avatar default: 'ftp://www.example.com/example.jpg' }).must_raise ArgumentError
+      _(-> { subject.avatar default: 'http://www.example.com/example.svg' }).must_raise ArgumentError
+      _(-> { subject.avatar default: 'http://www.example.com?image=example.jpg' }).must_raise ArgumentError
     end
+  end
+end
 
-    Gravaty::DEFAULT_OPTIONS.each do |options|
-      describe "when asked for a specific image options '#{options}'" do
-        it "shall provide an URI with option '#{options}'" do
-          _(subject.avatar(default: options)).must_include("d=#{options}")
-        end
-      end
+def test_unknown_parameters
+  describe 'when asked for unknown image' do
+    it 'must raise an ArgumentError' do
+      _(-> { subject.avatar type: 'unknown' }).must_raise ArgumentError
     end
+  end
 
-    describe 'when provided with a own default image' do
-      it 'shall provide a HTTP(S) URI' do
-        ['', 's'].each do |type|
-          an_uri = "http#{type}://www.example.com/example.jpg"
-          _(subject.avatar(default: an_uri)).must_include CGI::escape(an_uri)
-        end
-      end
+  describe 'when asked for unknown rating' do
+    it 'must raise an ArgumentError' do
+      _(-> { subject.avatar rating: 'unknown' }).must_raise ArgumentError
+    end
+  end
+end
 
-      it 'must raise an ArgumentError when URI is not HTTP(S)' do
-        _(-> { subject.avatar default: 'ftp://www.example.com/example.jpg' }).must_raise ArgumentError
-      end
+describe Gravaty::Gravaty do
+  describe 'when created with a valid email address ' do
+    subject do
+      Gravaty::Gravaty.new(Gravaty::TEST_MY_ADDRESS,
+                           Gravaty.parser)
+    end
 
-      it 'must raise an ArgumentError when image format is not supported' do
-        _(-> { subject.avatar default: 'http://www.example.com/example.svg' }).must_raise ArgumentError
-      end
+    test_avatar_formats
+
+    test_allowed_sizes
+
+    test_unallowed_sizes
+
+    test_rating_options
+
+    test_unknown_parameters
 
-      it 'must raise an ArgumentError when URI contains a query string' do
-        _(-> { subject.avatar default: 'http://www.example.com?image=example.jpg' }).must_raise ArgumentError
+    describe 'when asked for forcing default image' do
+      it 'shall provide a forced URI' do
+        _(subject.avatar(force: true)).must_include Gravaty::TEST_FORCED
       end
     end
+
+    test_default_options
+
+    test_own_default_image
   end
 end

data/test/gravaty/test_parser.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 #--
 # gravaty
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020  Marco Bresciani
+# rubocop:disable Style/AsciiComments
+# © 2013 Marco Bresciani
+# rubocop:enable Style/AsciiComments
 #
 # This file is part of gravaty.
 #
@@ -16,14 +20,17 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with gravaty. If not, see <http://www.gnu.org/licenses/>.
+#
+# SPDX-FileCopyrightText: 2013 Marco Bresciani
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
 #++
 
 require_relative '../test_helper'
 
 describe Gravaty::Gravaty do
   describe 'when using a parser ' do
-
-    subject { Gravaty::parser }
+    subject { Gravaty.parser }
 
     it 'shall provide a list of parsers' do
       _(subject.parsers).wont_be_empty
@@ -40,13 +47,12 @@ describe Gravaty::Gravaty do
       Gravaty::ALLOWED_PARAMS.each do |param|
         parsable_mocks[param] = MiniTest::Mock.new
         parsable_mocks[param].expect(:parse, false, [nil])
-        parsable_mocks[param].expect(:nil?, false)
       end
 
       my_parser = Gravaty::Parser.new(parsable_mocks)
 
       Gravaty::ALLOWED_PARAMS.each do |param|
-        my_parser.parse(param, nil)
+        my_parser.parse param
         parsable_mocks[param].verify
       end
     end

data/test/gravaty/test_profile.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 #--
 # gravaty
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020  Marco Bresciani
+# rubocop:disable Style/AsciiComments
+# © 2013 Marco Bresciani
+# rubocop:enable Style/AsciiComments
 #
 # This file is part of gravaty.
 #
@@ -16,14 +20,52 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with gravaty. If not, see <http://www.gnu.org/licenses/>.
+#
+# SPDX-FileCopyrightText: 2013 Marco Bresciani
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
 #++
 
 require_relative '../test_helper'
 
+def test_qrcode_sizes
+  Gravaty::ALLOWED_SIZES.each do |size|
+    it "shall provide a '#{size}' pixels URI, when size '#{size}'" do
+      _(subject.qrcode).must_match Gravaty::TEST_QR_REGEXP
+      _(subject.qrcode(pixelsize: size)).must_match(/#{Gravaty::TEST_SIZE_REGEXP}$/)
+    end
+  end
+end
+
+def test_qrcode
+  describe 'when asked for QR code format ' do
+    it 'shall provide an URI in QR code format' do
+      _(subject.qrcode).must_match Gravaty::TEST_QR_REGEXP
+    end
+
+    test_qrcode_sizes
+  end
+end
+
+def test_json
+  describe 'when asked for JSON format ' do
+    it 'shall provide an URI in JSON format' do
+      _(subject.json).must_match Gravaty::TEST_JSON_REGEXP
+    end
+
+    it 'shall provide a JSON URI when callback is provided' do
+      _(subject.json).must_match Gravaty::TEST_JSON_REGEXP
+      _(subject.json(callback: Gravaty::TEST_CALLBACK)).must_match(/#{Gravaty::TEST_CALLBACK}$/)
+    end
+  end
+end
+
 describe Gravaty::Gravaty do
   describe 'when created with a valid email address ' do
-    subject { Gravaty::Gravaty.new(Gravaty::TEST_MY_ADDRESS,
-                                   Gravaty::parser) }
+    subject do
+      Gravaty::Gravaty.new(Gravaty::TEST_MY_ADDRESS,
+                           Gravaty.parser)
+    end
 
     Gravaty::PROFILE_FORMATS.each do |format|
       describe "when asked for '#{format}' profile" do
@@ -39,28 +81,8 @@ describe Gravaty::Gravaty do
       end
     end
 
-    describe 'when asked for JSON format ' do
-      it 'shall provide an URI in JSON format' do
-        _(subject.json).must_match Gravaty::TEST_JSON_REGEXP
-      end
-
-      it 'shall provide a JSON URI when callback is provided' do
-        _(subject.json).must_match Gravaty::TEST_JSON_REGEXP
-        _(subject.json(callback: Gravaty::TEST_CALLBACK)).must_match(/#{Gravaty::TEST_CALLBACK}$/)
-      end
-    end
-
-    describe 'when asked for QR code format ' do
-      it 'shall provide an URI in QR code format' do
-        _(subject.qrcode).must_match Gravaty::TEST_QR_REGEXP
-      end
+    test_json
 
-      Gravaty::ALLOWED_SIZES.each do |size|
-        it "shall provide a '#{size}' pixels URI, when size '#{size}'" do
-          _(subject.qrcode).must_match Gravaty::TEST_QR_REGEXP
-          _(subject.qrcode(pixelsize: size)).must_match(/#{Gravaty::TEST_SIZE_REGEXP}$/)
-        end
-      end
-    end
+    test_qrcode
   end
 end

data/test/gravaty/utils/test_downloader.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 #--
 # gravaty
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020  Marco Bresciani
+# rubocop:disable Style/AsciiComments
+# © 2013 Marco Bresciani
+# rubocop:enable Style/AsciiComments
 #
 # This file is part of gravaty.
 #
@@ -16,6 +20,10 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with gravaty. If not, see <http://www.gnu.org/licenses/>.
+#
+# SPDX-FileCopyrightText: 2013 Marco Bresciani
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
 #++
 
 require_relative '../../test_helper'
@@ -23,53 +31,60 @@ require_relative '../../test_helper'
 describe Gravaty::Utils::Downloader do
   describe 'when passed a nil uri' do
     it 'must raise a RuntimeError' do
-      _(-> { Gravaty::Utils::Downloader::Downloader
-                 .download_file nil, 'filename' })
-          .must_raise RuntimeError
+      _(lambda {
+        Gravaty::Utils::Downloader::Downloader
+          .download_file nil, 'filename'
+      })
+        .must_raise RuntimeError
     end
   end
 
   describe 'when passed an invalid uri' do
     it 'must raise a InvalidURIError' do
-      _(-> { Gravaty::Utils::Downloader::Downloader
-                 .download_file 'http://example.com/%uABCD',
-                                'filename' })
-          .must_raise URI::InvalidURIError
+      _(lambda {
+        Gravaty::Utils::Downloader::Downloader
+          .download_file 'http://example.com/%uABCD',
+                         'filename'
+      })
+        .must_raise URI::InvalidURIError
     end
   end
 
   describe 'when passed a nil filename' do
     it 'must raise a TypeError' do
-      _(-> { Gravaty::Utils::Downloader::Downloader
-                 .download_file 'http://www.example.com',
-                                nil }).must_raise TypeError
+      _(lambda {
+        Gravaty::Utils::Downloader::Downloader
+          .download_file 'http://www.example.com',
+                         nil
+      }).must_raise TypeError
     end
   end
 
+  http_file = 'wget-latest.tar.gz'
+  download_url = 'ftp.jaist.ac.jp/pub/GNU/wget/'
+
   describe 'when passed a valid HTTP filename' do
     it 'must download a proper file' do
-      DESTINATION_FILE = 'wget-latest.tar.gz'
       Gravaty::Utils::Downloader::Downloader
-          .download_file 'http://ftp.jaist.ac.jp/pub/GNU/wget/wget-latest.tar.gz',
-                         DESTINATION_FILE
-      _(File.exist?(DESTINATION_FILE)).must_equal(true)
-      File.delete DESTINATION_FILE
-      _(File.exist?(DESTINATION_FILE)).must_equal(false)
+        .download_file "http://#{download_url}",
+                       http_file
+      _(File.exist?(http_file)).must_equal(true)
+      File.delete http_file
+      _(File.exist?(http_file)).must_equal(false)
     end
   end
 
   describe 'when passed a valid HTTPS filename' do
-    it 'must download a proper file' do
-      DESTINATION_FILE = 'wget-latest.tar.gz'
-      OLD_CERT = ENV['SSL_CERT_FILE']
-      ENV['SSL_CERT_FILE'] = 'examples/cacert.pem'
-      Gravaty::Utils::Downloader::Downloader
-          .download_file 'https://ftp.jaist.ac.jp/pub/GNU/wget/wget-latest.tar.gz',
-                         DESTINATION_FILE
-      _(File.exist?(DESTINATION_FILE)).must_equal(true)
-      File.delete DESTINATION_FILE
-      _(File.exist?(DESTINATION_FILE)).must_equal(false)
-      ENV['SSL_CERT_FILE'] = OLD_CERT
+    if ENV['SSL_CERT_FILE']
+      it 'must download a proper file' do
+        # https_file = 'wget-latest.tar.gz'
+        Gravaty::Utils::Downloader::Downloader
+          .download_file "https://#{download_url}",
+                         https_file
+        _(File.exist?(https_file)).must_equal(true)
+        File.delete https_file
+        _(File.exist?(https_file)).must_equal(false)
+      end
     end
   end
 end

data/test/gravaty/utils/test_raisers.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 #--
 # gravaty
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020  Marco Bresciani
+# rubocop:disable Style/AsciiComments
+# © 2013 Marco Bresciani
+# rubocop:enable Style/AsciiComments
 #
 # This file is part of gravaty.
 #
@@ -16,10 +20,45 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with gravaty. If not, see <http://www.gnu.org/licenses/>.
+#
+# SPDX-FileCopyrightText: 2013 Marco Bresciani
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
 #++
 
 require_relative '../../test_helper'
 
+def test_arg_error
+  it 'raises ArgumentError when value is not nil and not in array' do
+    all_methods = { raiser_downcase: ['value', ['no value']],
+                    raiser_to_i: ['42', [47]] }
+
+    all_methods.each_key do |method_name|
+      a_method = method method_name
+      _(lambda {
+        a_method.call 'error.value',
+                      all_methods[method_name.to_sym][0],
+                      all_methods[method_name.to_sym][1]
+      })
+        .must_raise ArgumentError
+    end
+  end
+end
+
+def test_no_arg_error
+  it 'do not raise an ArgumentError when value is nil or in array' do
+    all_methods = { raiser_downcase: [[nil, nil], ['value', ['value']]],
+                    raiser_to_i: [[nil, nil], ['42', [42]]] }
+
+    all_methods.each_key do |method_name|
+      a_method = method method_name
+      all_methods[method_name.to_sym].each do |params|
+        a_method.call 'error.value', params[0], params[1]
+      end
+    end
+  end
+end
+
 describe Gravaty::Utils::Raisers do
   include Gravaty::Utils::Raisers
 
@@ -31,31 +70,8 @@ describe Gravaty::Utils::Raisers do
   end
 
   describe 'when running any raiser method' do
-    it 'do not raise an ArgumentError when value is nil or in array' do
-      all_methods = Hash.new
-      all_methods[:raiser_downcase] = [[nil, nil], ['value', ['value']]]
-      all_methods[:raiser_to_i] = [[nil, nil], ['42', [42]]]
-
-      all_methods.each_key do |method_name|
-        a_method = self.method method_name
-        all_methods[method_name.to_sym].each do |params|
-          a_method.call 'error.value', params[0], params[1]
-        end
-      end
-    end
+    test_no_arg_error
 
-    it 'raises ArgumentError when value is not nil and not in array' do
-      all_methods = Hash.new
-      all_methods[:raiser_downcase] = ['value', ['no value']]
-      all_methods[:raiser_to_i] = ['42', [47]]
-
-      all_methods.each_key do |method_name|
-        a_method = self.method method_name
-        _(-> { a_method.call 'error.value',
-                             all_methods[method_name.to_sym][0],
-                             all_methods[method_name.to_sym][1] })
-            .must_raise ArgumentError
-      end
-    end
+    test_arg_error
   end
 end