granite-form 0.5.0 → 0.6.1

data/spec/support/shared/nested_attribute_examples.rb

@@ -23,18 +23,34 @@ shared_examples 'nested attributes' do
     let(:user) { User.new }
 
     specify { expect { user.profile_attributes = {} }.to change { user.profile }.to(an_instance_of(Profile)) }
-    specify { expect { user.profile_attributes = {first_name: 'User'} }.to change { user.profile.try(:first_name) }.to('User') }
-    specify { expect { user.profile_attributes = {identifier: 42, first_name: 'User'} }.to raise_error Granite::Form::ObjectNotFound }
+
+    specify do
+      expect { user.profile_attributes = { first_name: 'User' } }
+        .to change { user.profile.try(:first_name) }
+        .to('User')
+    end
+
+    specify do
+      expect do
+        user.profile_attributes = { identifier: 42, first_name: 'User' }
+      end.to raise_error Granite::Form::ObjectNotFound
+    end
 
     context ':reject_if' do
       context do
         before { User.accepts_nested_attributes_for :profile, reject_if: :all_blank }
-        specify { expect { user.profile_attributes = {first_name: ''} }.not_to change { user.profile } }
+
+        specify { expect { user.profile_attributes = { first_name: '' } }.not_to(change { user.profile }) }
       end
 
       context do
-        before { User.accepts_nested_attributes_for :profile, reject_if: ->(attributes) { attributes['first_name'].blank? } }
-        specify { expect { user.profile_attributes = {first_name: ''} }.not_to change { user.profile } }
+        before do
+          User.accepts_nested_attributes_for :profile, reject_if: lambda { |attributes|
+                                                                    attributes['first_name'].blank?
+                                                                  }
+        end
+
+        specify { expect { user.profile_attributes = { first_name: '' } }.not_to(change { user.profile }) }
       end
     end
 
@@ -42,35 +58,50 @@ shared_examples 'nested attributes' do
       let(:profile) { Profile.new(first_name: 'User') }
       let(:user) { User.new profile: profile }
 
-      specify { expect { user.profile_attributes = {identifier: 42, first_name: 'User'} }.to raise_error Granite::Form::ObjectNotFound }
-      specify { expect { user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1'} }.to change { user.profile.first_name }.to('User 1') }
-      specify { expect { user.profile_attributes = {first_name: 'User 1'} }.to change { user.profile.first_name }.to('User 1') }
-      specify { expect { user.profile_attributes = {first_name: 'User 1', _destroy: '1'} }.not_to change { user.profile.first_name } }
       specify do
         expect do
-          user.profile_attributes = {first_name: 'User 1', _destroy: '1'}
-        end.not_to change { user.profile.first_name }
+          user.profile_attributes = { identifier: 42, first_name: 'User' }
+        end.to raise_error Granite::Form::ObjectNotFound
+      end
+
+      specify do
+        expect { user.profile_attributes = { identifier: profile.identifier.to_s, first_name: 'User 1' } }
+          .to change { user.profile.first_name }.to('User 1')
+      end
+
+      specify do
+        expect { user.profile_attributes = { first_name: 'User 1' } }
+          .to change { user.profile.first_name }.to('User 1')
       end
-      specify { expect { user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'} }.to change { user.profile.first_name }.to('User 1') }
+
+      specify do
+        expect { user.profile_attributes = { first_name: 'User 1', _destroy: '1' } }
+          .not_to(change { user.profile.first_name })
+      end
+
       specify do
         expect do
-          user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'}
+          user.profile_attributes = { first_name: 'User 1', _destroy: '1' }
+        end.not_to(change { user.profile.first_name })
+      end
+
+      specify do
+        expect do
+          user.profile_attributes = { identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1' }
         end.to change { user.profile.first_name }.to('User 1')
       end
 
       context ':allow_destroy' do
         before { User.accepts_nested_attributes_for :profile, allow_destroy: true }
 
-        specify { expect { user.profile_attributes = {first_name: 'User 1', _destroy: '1'} }.not_to change { user.profile.first_name } }
         specify do
-          expect do
-            user.profile_attributes = {first_name: 'User 1', _destroy: '1'}
-          end.not_to change { user.profile.first_name }
+          expect { user.profile_attributes = { first_name: 'User 1', _destroy: '1' } }
+            .not_to(change { user.profile.first_name })
         end
-        specify { expect { user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'} }.to change { user.profile }.to(nil) }
+
         specify do
           expect do
-            user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'}
+            user.profile_attributes = { identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1' }
           end.to change { user.profile }.to(nil)
         end
       end
@@ -79,7 +110,7 @@ shared_examples 'nested attributes' do
         before { User.accepts_nested_attributes_for :profile, update_only: true }
 
         specify do
-          expect { user.profile_attributes = {identifier: 42, first_name: 'User 1'} }
+          expect { user.profile_attributes = { identifier: 42, first_name: 'User 1' } }
             .to change { user.profile.first_name }.to('User 1')
         end
       end
@@ -94,14 +125,18 @@ shared_examples 'nested attributes' do
       end
 
       specify { expect { user.profile_attributes = {} }.to change { user.profile }.to(an_instance_of(Profile)) }
-      specify { expect { user.profile_attributes = {first_name: 'User'} }.to change { user.profile.try(:first_name) }.to('User') }
+
+      specify do
+        expect { user.profile_attributes = { first_name: 'User' } }
+          .to change { user.profile.try(:first_name) }.to('User')
+      end
 
       context do
         let(:profile) { Profile.new(first_name: 'User') }
         let(:user) { User.new profile: profile }
 
         specify do
-          expect { user.profile_attributes = {identifier: 42, first_name: 'User 1'} }
+          expect { user.profile_attributes = { identifier: 42, first_name: 'User 1' } }
             .to change { user.profile.first_name }.to('User 1')
         end
       end
@@ -127,21 +162,25 @@ shared_examples 'nested attributes' do
   context 'embeds_many' do
     let(:user) { User.new }
 
-    specify { expect { user.projects_attributes = {} }.not_to change { user.projects } }
+    specify { expect { user.projects_attributes = {} }.not_to(change { user.projects }) }
+
     specify do
-      expect { user.projects_attributes = [{title: 'Project 1'}, {title: 'Project 2'}] }
+      expect { user.projects_attributes = [{ title: 'Project 1' }, { title: 'Project 2' }] }
         .to change { user.projects.map(&:title) }.to(['Project 1', 'Project 2'])
     end
+
     specify do
-      expect { user.projects_attributes = {1 => {title: 'Project 1'}, 2 => {title: 'Project 2'}} }
+      expect { user.projects_attributes = { 1 => { title: 'Project 1' }, 2 => { title: 'Project 2' } } }
         .to change { user.projects.map(&:title) }.to(['Project 1', 'Project 2'])
     end
+
     specify do
-      expect { user.projects_attributes = [{slug: 42, title: 'Project 1'}, {title: 'Project 2'}] }
+      expect { user.projects_attributes = [{ slug: 42, title: 'Project 1' }, { title: 'Project 2' }] }
         .to change { user.projects.map(&:title) }.to(['Project 1', 'Project 2'])
     end
+
     specify do
-      expect { user.projects_attributes = [{title: ''}, {title: 'Project 2'}] }
+      expect { user.projects_attributes = [{ title: '' }, { title: 'Project 2' }] }
         .to change { user.projects.map(&:title) }.to(['', 'Project 2'])
     end
 
@@ -149,11 +188,12 @@ shared_examples 'nested attributes' do
       before { User.accepts_nested_attributes_for :projects, limit: 1 }
 
       specify do
-        expect { user.projects_attributes = [{title: 'Project 1'}] }
+        expect { user.projects_attributes = [{ title: 'Project 1' }] }
           .to change { user.projects.map(&:title) }.to(['Project 1'])
       end
+
       specify do
-        expect { user.projects_attributes = [{title: 'Project 1'}, {title: 'Project 2'}] }
+        expect { user.projects_attributes = [{ title: 'Project 1' }, { title: 'Project 2' }] }
           .to raise_error Granite::Form::TooManyObjects
       end
     end
@@ -161,25 +201,36 @@ shared_examples 'nested attributes' do
     context ':reject_if' do
       context do
         before { User.accepts_nested_attributes_for :projects, reject_if: :all_blank }
+
         specify do
-          expect { user.projects_attributes = [{title: ''}, {title: 'Project 2'}] }
+          expect { user.projects_attributes = [{ title: '' }, { title: 'Project 2' }] }
             .to change { user.projects.map(&:title) }.to(['Project 2'])
         end
       end
 
       context do
-        before { User.accepts_nested_attributes_for :projects, reject_if: ->(attributes) { attributes['title'].blank? } }
+        before do
+          User.accepts_nested_attributes_for :projects, reject_if: lambda { |attributes|
+                                                                     attributes['title'].blank?
+                                                                   }
+        end
+
         specify do
-          expect { user.projects_attributes = [{title: ''}, {title: 'Project 2'}] }
+          expect { user.projects_attributes = [{ title: '' }, { title: 'Project 2' }] }
             .to change { user.projects.map(&:title) }.to(['Project 2'])
         end
       end
 
       context do
-        before { User.accepts_nested_attributes_for :projects, reject_if: ->(attributes) { attributes['foobar'].blank? } }
+        before do
+          User.accepts_nested_attributes_for :projects, reject_if: lambda { |attributes|
+                                                                     attributes['foobar'].blank?
+                                                                   }
+        end
+
         specify do
-          expect { user.projects_attributes = [{title: ''}, {title: 'Project 2'}] }
-            .not_to change { user.projects }
+          expect { user.projects_attributes = [{ title: '' }, { title: 'Project 2' }] }
+            .not_to(change { user.projects })
         end
       end
     end
@@ -191,53 +242,58 @@ shared_examples 'nested attributes' do
       specify do
         expect do
           user.projects_attributes = [
-            {slug: projects.first.slug.to_i, title: 'Project 3'},
-            {title: 'Project 4'}
+            { slug: projects.first.slug.to_i, title: 'Project 3' },
+            { title: 'Project 4' }
           ]
         end
           .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2', 'Project 4'])
       end
+
       specify do
         expect do
           user.projects_attributes = [
-            {slug: projects.first.slug.to_i, title: 'Project 3'},
-            {slug: 33, title: 'Project 4'}
+            { slug: projects.first.slug.to_i, title: 'Project 3' },
+            { slug: 33, title: 'Project 4' }
           ]
         end
           .to change { user.projects.map(&:slug) }.to(%w[42 43 33])
       end
+
       specify do
         expect do
           user.projects_attributes = [
-            {slug: projects.first.slug.to_i, title: 'Project 3'},
-            {slug: 33, title: 'Project 4', _destroy: 1}
+            { slug: projects.first.slug.to_i, title: 'Project 3' },
+            { slug: 33, title: 'Project 4', _destroy: 1 }
           ]
         end
-          .not_to change { user.projects.map(&:slug) }
+          .not_to(change { user.projects.map(&:slug) })
       end
+
       specify do
         expect do
           user.projects_attributes = {
-            1 => {slug: projects.first.slug.to_i, title: 'Project 3'},
-            2 => {title: 'Project 4'}
+            1 => { slug: projects.first.slug.to_i, title: 'Project 3' },
+            2 => { title: 'Project 4' }
           }
         end
           .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2', 'Project 4'])
       end
+
       specify do
         expect do
           user.projects_attributes = [
-            {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
-            {title: 'Project 4', _destroy: '1'}
+            { slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1' },
+            { title: 'Project 4', _destroy: '1' }
           ]
         end
           .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2'])
       end
+
       specify do
         expect do
           user.projects_attributes = [
-            {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
-            {title: 'Project 4', _destroy: '1'}
+            { slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1' },
+            { title: 'Project 4', _destroy: '1' }
           ]
         end
           .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2'])
@@ -249,8 +305,8 @@ shared_examples 'nested attributes' do
         specify do
           expect do
             user.projects_attributes = [
-              {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
-              {title: 'Project 4', _destroy: '1'}
+              { slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1' },
+              { title: 'Project 4', _destroy: '1' }
             ]
           end
             .to change { user.projects.map(&:title) }.to(['Project 2'])
@@ -263,8 +319,8 @@ shared_examples 'nested attributes' do
         specify do
           expect do
             user.projects_attributes = [
-              {slug: projects.first.slug.to_i, title: 'Project 3'},
-              {title: 'Project 4'}
+              { slug: projects.first.slug.to_i, title: 'Project 3' },
+              { title: 'Project 4' }
             ]
           end
             .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2'])
@@ -273,8 +329,8 @@ shared_examples 'nested attributes' do
         specify do
           expect do
             user.projects_attributes = [
-              {slug: projects.last.slug.to_i, title: 'Project 3'},
-              {slug: projects.first.slug.to_i.pred, title: 'Project 0'}
+              { slug: projects.last.slug.to_i, title: 'Project 3' },
+              { slug: projects.first.slug.to_i.pred, title: 'Project 0' }
             ]
           end
             .to change { user.projects.map(&:title) }.to(['Project 1', 'Project 3'])

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: granite-form
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Toptal Engineering
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-09 00:00:00.000000000 Z
+date: 2024-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -142,14 +142,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 1.63.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 1.63.5
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.29.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.29.2
 - !ruby/object:Gem::Dependency
   name: uuidtools
   requirement: !ruby/object:Gem::Requirement
@@ -213,7 +227,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
-- ".github/CODEOWNERS"
 - ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
@@ -393,7 +406,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.6
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: Working with hashes in AR style

data/.github/CODEOWNERS

@@ -1 +0,0 @@
-* @toptal/devx