granite-form 0.5.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5519b4c103eaec0a823f7869c496af428a11d4bab6652822add9e826a64a86c0
-  data.tar.gz: ac3048e88443939c4bae29e5eac6d177ff58a782501f2ee03b57cc5c27697d9c
+  metadata.gz: 62a7935cb1b74f15d4599c3118e4b60728bcf8b27dac232a3893ef84d2b5f127
+  data.tar.gz: 2c6e8d0aeca6ca09aae7a364d2966a26c1ad1a4ab7f9986d348deeaab7688bdb
 SHA512:
-  metadata.gz: a25adecefad4bd54870c96884c388ad4528ad03269b348422725a73bfe366204bfd530f58c8ac5ee92264891abcf34f824a4b4067620b9b118dba3e3e8da69d7
-  data.tar.gz: b48f66dedbe424b642337f76468ddfc0809589e8d6e13c448ebe80b5cfe804e4bbf87e7107b14b24634af477f5cf9add77596f8c425757a75683867e2fe1320e
+  metadata.gz: 1545d76b21d34005b22708aa3670f7c893d322b388f217f70d21180d0dfa65621f694d87025e1b8c0fd243f97139b5f2e1a0c101a536c01750f3eba741ad0327
+  data.tar.gz: 0dbf480f6d6d8ebc4401ad698d3adfe8b894a2f07f6b32b9fdff0f3bc60605d7a97da1c305877db248f4a6005aebb836fa8000f22fb3c5096231e044d0491144

data/.rubocop.yml

@@ -1,64 +1,42 @@
 inherit_from: .rubocop_todo.yml
 
+require:
+  - rubocop-rspec
+
 AllCops:
+  Include:
+    - '**/*.rb'
+    - '**/Gemfile'
+    - '**/Rakefile'
+  Exclude:
+    - 'vendor/bundle/**/*'
+    - 'log/**/*'
+    - 'spec/fixtures/**/*'
+    - 'lib/granite/form/model/dirty.rb'
   DisplayCopNames: true
-  TargetRubyVersion: 2.4.0
+  TargetRubyVersion: 2.6
+  NewCops: enable
 
-Lint/AmbiguousBlockAssociation:
+RSpec/MultipleExpectations:
   Enabled: false
 
-Lint/EndAlignment:
-  EnforcedStyleAlignWith: variable
-
-Layout/AccessModifierIndentation:
-  EnforcedStyle: outdent
-
-Layout/AlignHash:
-  EnforcedLastArgumentHashStyle: always_ignore
-
-Layout/AlignParameters:
-  EnforcedStyle: with_fixed_indentation
-
-Layout/CaseIndentation:
-  EnforcedStyle: end
-
-Layout/IndentArray:
-  EnforcedStyle: consistent
-
-Layout/IndentHash:
-  EnforcedStyle: consistent
-
-Layout/IndentHeredoc:
+RSpec/NestedGroups:
   Enabled: false
 
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-
-Layout/MultilineOperationIndentation:
-  EnforcedStyle: indented
-
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-
-Metrics/BlockLength:
-  Exclude:
-    - '**/*_spec.rb'
-    - '**/*_examples.rb'
-    - '**/*.rake'
+RSpec/MessageSpies:
+  Enabled: false
 
-Metrics/ModuleLength:
-  Exclude:
-    - '**/*_spec.rb'
-    - 'lib/granite/form.rb'
+Gemspec/DevelopmentDependencies:
+  Enabled: false
 
-Style/Alias:
-  EnforcedStyle: prefer_alias_method
+Style/FrozenStringLiteralComment:
+  Enabled: false
 
-Style/AndOr:
-  EnforcedStyle: conditionals
+RSpec/DescribedClass:
+  Enabled: false
 
-Style/DoubleNegation:
+Style/OptionalBooleanParameter:
   Enabled: false
 
-Style/FrozenStringLiteralComment:
+Style/MissingRespondToMissing:
   Enabled: false

data/.rubocop_todo.yml

@@ -1,48 +1,325 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-10-14 10:15:31 +0700 using RuboCop version 0.44.1.
+# on 2024-05-13 08:55:48 UTC using RuboCop version 1.63.5.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 19
+# Offense count: 10
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'spec/granite/form/config_spec.rb'
+    - 'spec/granite/form/model/associations/reflections/embeds_any_spec.rb'
+    - 'spec/granite/form/model/attributes/reflections/attribute_spec.rb'
+    - 'spec/granite/form/model/attributes_spec.rb'
+    - 'spec/granite/form/model/dirty_spec.rb'
+    - 'spec/granite/form/model/validations_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowComments.
+Lint/EmptyClass:
+  Exclude:
+    - 'lib/granite/form/extensions.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedParentClasses.
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/granite/form/model/associations/reflections/references_any.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/NonDeterministicRequireOrder:
+  Exclude:
+    - 'lib/granite/form/model/validations.rb'
+
+# Offense count: 8
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 59
+  Max: 60
+
+# Offense count: 5
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/CyclomaticComplexity:
+  Max: 17
+
+# Offense count: 14
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
+Metrics/MethodLength:
+  Max: 46
+
+# Offense count: 5
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/PerceivedComplexity:
+  Max: 20
 
 # Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 128
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'lib/granite/form/model/associations/embeds_many.rb'
+    - 'lib/granite/form/model/associations/references_many.rb'
 
-# Offense count: 4
-Metrics/CyclomaticComplexity:
-  Max: 15
+# Offense count: 2
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
+Naming/MethodParameterName:
+  Exclude:
+    - 'spec/granite/form/model/attributes_spec.rb'
 
-# Offense count: 904
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 187
+# Offense count: 2
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/granite/form/model/attributes/attribute_spec.rb'
 
-# Offense count: 21
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 43
+# Offense count: 77
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/BeEq:
+  Exclude:
+    - 'spec/granite/form/active_record/associations_spec.rb'
+    - 'spec/granite/form/config_spec.rb'
+    - 'spec/granite/form/model/associations/embeds_many_spec.rb'
+    - 'spec/granite/form/model/associations/embeds_one_spec.rb'
+    - 'spec/granite/form/model/associations/references_many_spec.rb'
+    - 'spec/granite/form/model/associations/references_one_spec.rb'
+    - 'spec/granite/form/model/associations/validations_spec.rb'
+    - 'spec/granite/form/model/attributes/attribute_spec.rb'
+    - 'spec/granite/form/model/attributes/base_spec.rb'
+    - 'spec/granite/form/model/attributes_spec.rb'
+    - 'spec/granite/form/model/primary_spec.rb'
+    - 'spec/granite/form/model/representation_spec.rb'
+    - 'spec/granite/form/model/validations_spec.rb'
+    - 'spec/granite/form/types/boolean_spec.rb'
+    - 'spec/granite/form/types/object_spec.rb'
+
+# Offense count: 1
+RSpec/BeforeAfterAll:
+  Exclude:
+    - '**/spec/spec_helper.rb'
+    - '**/spec/rails_helper.rb'
+    - '**/spec/support/**/*.rb'
+    - 'spec/granite/form/types/hash_with_action_controller_parameters_spec.rb'
+
+# Offense count: 74
+# Configuration parameters: Prefixes, AllowedPatterns.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Enabled: false
+
+# Offense count: 42
+# Configuration parameters: CountAsOne.
+RSpec/ExampleLength:
+  Max: 10
+
+# Offense count: 220
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: method_call, block
+RSpec/ExpectChange:
+  Exclude:
+    - 'spec/granite/form/active_record/associations_spec.rb'
+    - 'spec/granite/form/config_spec.rb'
+    - 'spec/granite/form/model/associations/embeds_many_spec.rb'
+    - 'spec/granite/form/model/associations/embeds_one_spec.rb'
+    - 'spec/granite/form/model/associations/references_many_spec.rb'
+    - 'spec/granite/form/model/associations/references_one_spec.rb'
+    - 'spec/granite/form/model/associations/reflections/embeds_many_spec.rb'
+    - 'spec/granite/form/model/associations/reflections/embeds_one_spec.rb'
+    - 'spec/granite/form/model/associations/reflections/references_many_spec.rb'
+    - 'spec/granite/form/model/associations/reflections/references_one_spec.rb'
+    - 'spec/granite/form/model/attributes_spec.rb'
+    - 'spec/granite/form/model/representation_spec.rb'
+    - 'spec/support/shared/nested_attribute_examples.rb'
+
+# Offense count: 3
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/FilePath:
+  Exclude:
+    - 'spec/granite/form/extensions_spec.rb'
+    - 'spec/granite/form/model/validations/associated_spec.rb'
+    - 'spec/granite/form/model/validations/nested_spec.rb'
+
+# Offense count: 6
+RSpec/IdenticalEqualityAssertion:
+  Exclude:
+    - 'spec/granite/form/model/associations_spec.rb'
+    - 'spec/granite/form/model/primary_spec.rb'
+
+# Offense count: 23
+# Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
+RSpec/IndexedLet:
+  Exclude:
+    - 'spec/granite/form/model/associations/embeds_many_spec.rb'
+    - 'spec/granite/form/model/associations/embeds_one_spec.rb'
+    - 'spec/granite/form/model/associations/references_many_spec.rb'
+    - 'spec/granite/form/model/associations/reflections/embeds_many_spec.rb'
+    - 'spec/granite/form/model/associations/reflections/references_many_spec.rb'
+    - 'spec/granite/form/model/associations/reflections/references_one_spec.rb'
+    - 'spec/granite/form/model/attributes_spec.rb'
+    - 'spec/granite/form/model/scopes_spec.rb'
+
+# Offense count: 8
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/granite/form/model/attributes/reflections/base/build_type_definition_spec.rb'
+    - 'spec/granite/form/model/attributes/reflections/collection/build_type_definition_spec.rb'
+    - 'spec/granite/form/model/attributes/reflections/dictionary/build_type_definition_spec.rb'
+    - 'spec/granite/form/model/attributes/reflections/represents/build_type_definition_spec.rb'
+
+# Offense count: 81
+RSpec/MissingExampleGroupArgument:
+  Enabled: false
+
+# Offense count: 39
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 9
+
+# Offense count: 95
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/granite/form/config_spec.rb'
+    - 'spec/granite/form/model/attributes/base_spec.rb'
+    - 'spec/granite/form/model/attributes_spec.rb'
+    - 'spec/granite/form/model/persistence_spec.rb'
+    - 'spec/granite/form/model/validations/nested_spec.rb'
+    - 'spec/granite/form/types/collection_spec.rb'
+    - 'spec/granite/form/types/dictionary_spec.rb'
+    - 'spec/granite/form/types/has_subtype_spec.rb'
+    - 'spec/granite/form/util_spec.rb'
+    - 'spec/granite/form_spec.rb'
+
+# Offense count: 14
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'spec/granite/form/model/attributes_spec.rb'
+
+# Offense count: 1
+RSpec/PendingWithoutReason:
+  Exclude:
+    - 'spec/granite/form/model/associations/reflections/references_many_spec.rb'
+
+# Offense count: 10
+RSpec/RepeatedExample:
+  Exclude:
+    - 'spec/support/shared/nested_attribute_examples.rb'
+
+# Offense count: 2
+RSpec/RepeatedExampleGroupDescription:
+  Exclude:
+    - 'spec/granite/form/model/primary_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
+# Include: **/*_spec.rb
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - '**/spec/routing/**/*'
+    - 'spec/granite/form/extensions_spec.rb'
+    - 'spec/granite/form/model/validations/associated_spec.rb'
+    - 'spec/granite/form/model/validations/nested_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: constant, string
+RSpec/VerifiedDoubleReference:
+  Exclude:
+    - 'spec/granite/form/model/representation_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
+RSpec/VerifiedDoubles:
+  Exclude:
+    - 'spec/granite/form/types/has_subtype_spec.rb'
+    - 'spec/granite/form/types/object_spec.rb'
 
 # Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/ModuleLength:
-  Max: 114
+RSpec/VoidExpect:
+  Exclude:
+    - 'spec/granite/form/model/attributes_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: not_to, be_invalid
+RSpecRails/NegationBeValid:
+  Exclude:
+    - 'spec/granite/form/model/validations_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
+# SupportedStyles: inline, group
+Style/AccessModifierDeclarations:
+  Exclude:
+    - 'lib/granite/form/model/associations/reflections/embeds_any.rb'
 
 # Offense count: 2
-Metrics/BlockLength:
-  Max: 27
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+# AllowedMethods: ==, equal?, eql?
+Style/ClassEqualityComparison:
+  Exclude:
+    - 'lib/granite/form/model/attributes.rb'
 
-# Offense count: 4
-Metrics/PerceivedComplexity:
-  Max: 18
+# Offense count: 7
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/ConcatArrayLiterals:
+  Exclude:
+    - 'spec/granite/form/model/associations/embeds_many_spec.rb'
+    - 'spec/granite/form/model/associations/references_many_spec.rb'
+
+# Offense count: 8
+Style/DocumentDynamicEvalDefinition:
+  Exclude:
+    - 'lib/granite/form/active_record/associations.rb'
+    - 'lib/granite/form/model/associations/nested_attributes.rb'
+    - 'lib/granite/form/model/associations/reflections/base.rb'
+    - 'lib/granite/form/model/associations/reflections/embeds_one.rb'
+    - 'lib/granite/form/model/attributes/reflections/attribute.rb'
+    - 'lib/granite/form/model/attributes/reflections/reference_one.rb'
+    - 'lib/granite/form/model/dirty.rb'
 
-# Offense count: 75
+# Offense count: 96
+# Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/GlobalStdStream:
+  Exclude:
+    - 'lib/granite/form/config.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
+Style/GuardClause:
+  Exclude:
+    - 'lib/granite/form/config.rb'
+
+# Offense count: 3
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowSplatArgument.
+Style/HashConversion:
+  Exclude:
+    - 'lib/granite/form/model/attributes.rb'
+    - 'lib/granite/form/types/dictionary.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/granite/form/model/associations/nested_attributes.rb'
+    - 'spec/granite/form/model/representation_spec.rb'

data/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 ## Next
 
+## v0.6.1
+
+* Introduces `mass_assignment_strict_mode` configuration option to control the behavior of mass assignment.
+  * The setting is per class and configures strict handling of unknown attributes by raising an exception.
+  * By default it is disabled, and you need to opt-in.
+  * https://github.com/toptal/granite-form/pull/32
+
+## v0.6.0
+
+* Fix crash when mapping PostgreSQL enum to ruby variable in https://github.com/toptal/granite-form/pull/28
+* Lower severity of the log message during mass assignment https://github.com/toptal/granite-form/pull/26
+
 ## v0.5.0
 
 * Support for ruby 3.2 by @konalegi in https://github.com/toptal/granite-form/pull/22
@@ -15,7 +27,7 @@
 * Add support for evaluating `Symbol` for readonly/enum/normalize. If symbol is passed in one of those options, method with that name will be called when evaluating the value.
 * [BREAKING] Remove `localized` attribute type.
 * [BREAKING] Change the behavior of `default` and `normalize` for `collection` & `dictionary`. Instead of acting per element they will now act on the attribute as a whole.
-  * E.g. `collection :numbers, default: [1, 2, 3]` will not set the default for the whole collection of `numbers` rather than each element in `numbers`. 
+  * E.g. `collection :numbers, default: [1, 2, 3]` will not set the default for the whole collection of `numbers` rather than each element in `numbers`.
 
 ## v0.3.0
 
@@ -32,7 +44,7 @@
 
 ## v0.1.1
 
-- Fixed represented error message copying when represented model uses symbols for `message`. 
+- Fixed represented error message copying when represented model uses symbols for `message`.
 
 ## v0.1.0
 

data/granite-form.gemspec

@@ -23,7 +23,8 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec', '~> 3.7.0'
   gem.add_development_dependency 'rspec-its'
-  gem.add_development_dependency 'rubocop', '0.52.1'
+  gem.add_development_dependency 'rubocop', '1.63.5'
+  gem.add_development_dependency 'rubocop-rspec', '2.29.2'
   gem.add_development_dependency 'uuidtools'
 
   gem.add_runtime_dependency 'activemodel', '>= 6.0'

data/lib/granite/form/active_record/associations.rb

@@ -30,11 +30,12 @@ module Granite
         extend ActiveSupport::Concern
 
         included do
-          {embeds_many: Reflections::EmbedsMany, embeds_one: Reflections::EmbedsOne}.each do |(method, reflection_class)|
+          { embeds_many: Reflections::EmbedsMany,
+            embeds_one: Reflections::EmbedsOne }.each do |(method, reflection_class)|
             define_singleton_method method do |name, options = {}, &block|
               reflection = reflection_class.build(self, self, name,
-                options.reverse_merge(read: READER, write: WRITER),
-                &block)
+                                                  options.reverse_merge(read: READER, write: WRITER),
+                                                  &block)
               if ::ActiveRecord::Reflection.respond_to? :add_reflection
                 ::ActiveRecord::Reflection.add_reflection self, reflection.name, reflection
               else

data/lib/granite/form/config.rb

@@ -4,7 +4,7 @@ module Granite
       include Singleton
 
       attr_accessor :include_root_in_json, :i18n_scope, :logger, :primary_attribute, :base_class, :base_concern,
-        :_normalizers, :types
+                    :_normalizers, :types
 
       def self.delegated
         public_instance_methods - superclass.public_instance_methods - Singleton.public_instance_methods

data/lib/granite/form/errors.rb

@@ -13,53 +13,55 @@ module Granite
       def initialize(model)
         @model = model
         errors = @model.errors.full_messages.join(', ')
-        super(I18n.t(:"#{@model.class.i18n_scope}.errors.messages.model_invalid", errors: errors, default: :'errors.messages.model_invalid'))
+        super(I18n.t(:"#{@model.class.i18n_scope}.errors.messages.model_invalid",
+                     errors: errors, default: :'errors.messages.model_invalid'))
       end
     end
 
     class AssociationTypeMismatch < Error
       def initialize(expected, got)
-        super "Expected `#{expected}` (##{expected.object_id}), but got `#{got}` (##{got.object_id})"
+        super("Expected `#{expected}` (##{expected.object_id}), but got `#{got}` (##{got.object_id})")
       end
     end
 
     class ObjectNotFound < Error
       def initialize(object, association_name, record_id)
+        primary_name = object.respond_to?(:_primary_name) ? object._primary_name : 'id'
         message = "Couldn't find #{object.class.reflect_on_association(association_name).klass.name}" \
-        "with #{object.respond_to?(:_primary_name) ? object._primary_name : 'id'} = #{record_id} for #{object.inspect}"
-        super message
+                  "with #{primary_name} = #{record_id} for #{object.inspect}"
+        super(message)
       end
     end
 
     class TooManyObjects < Error
       def initialize(limit, actual_size)
-        super "Maximum #{limit} objects are allowed. Got #{actual_size} objects instead."
+        super("Maximum #{limit} objects are allowed. Got #{actual_size} objects instead.")
       end
     end
 
     class UndefinedPrimaryAttribute < Error
       def initialize(klass, association_name)
-        super <<-MESSAGE
-Undefined primary attribute for `#{association_name}` in #{klass}.
-It is required for embeds_many nested attributes proper operation.
-You can define this association as:
+        super(<<~MESSAGE)
+          Undefined primary attribute for `#{association_name}` in #{klass}.
+          It is required for embeds_many nested attributes proper operation.
+          You can define this association as:
 
-  embeds_many :#{association_name} do
-    primary :attribute_name
-  end
+            embeds_many :#{association_name} do
+              primary :attribute_name
+            end
         MESSAGE
       end
     end
 
     class NormalizerMissing < NoMethodError
       def initialize(name)
-        super <<-MESSAGE
-Could not find normalizer `:#{name}`
-You can define it with:
+        super(<<~MESSAGE)
+          Could not find normalizer `:#{name}`
+          You can define it with:
 
-  Granite::Form.normalizer(:#{name}) do |value, options|
-    # do some staff with value and options
-  end
+            Granite::Form.normalizer(:#{name}) do |value, options|
+              # do some staff with value and options
+            end
         MESSAGE
       end
     end
@@ -67,28 +69,28 @@ You can define it with:
     class TypecasterMissing < NoMethodError
       def initialize(*classes)
         classes = classes.flatten
-        super <<-MESSAGE
-Could not find typecaster for #{classes}
-You can define it with:
+        super(<<~MESSAGE)
+          Could not find typecaster for #{classes}
+          You can define it with:
 
-  Granite::Form.typecaster('#{classes.first}') do |value|
-    # do some staff with value and options
-  end
+            Granite::Form.typecaster('#{classes.first}') do |value|
+              # do some staff with value and options
+            end
         MESSAGE
       end
     end
 
     class PersistenceAdapterMissing < NoMethodError
       def initialize(data_source)
-        super <<-MESSAGE
-Could not find persistence adapter for #{data_source}
-You can define it with:
+        super(<<~MESSAGE)
+          Could not find persistence adapter for #{data_source}
+          You can define it with:
 
-  class #{data_source}
-    def self.granite_persistence_adapter
-      #{data_source}GraniteFormPersistenceAdapter
-    end
-  end
+            class #{data_source}
+              def self.granite_persistence_adapter
+                #{data_source}GraniteFormPersistenceAdapter
+              end
+            end
         MESSAGE
       end
     end

data/lib/granite/form/extensions.rb

@@ -17,7 +17,8 @@ else
         end
 
         def self.parse_string(value)
-          return nil if value.length.zero?
+          return nil if value.empty?
+
           if value.length == 36
             parse value
           elsif value.length == 32