gradesfirst 0.2.1 → 0.3.0

data/test/task_delete_command_test.rb

@@ -0,0 +1,57 @@
+require 'test_helper'
+require 'gradesfirst/task_delete_command'
+
+describe GradesFirst::TaskDeleteCommand do
+  before do
+    @task_position = '2'
+    @invalid_position = '8'
+    @task_id = 6
+    @command = GradesFirst::TaskDeleteCommand.new
+  end
+
+  def stub_bar_story_task_delete_request(task_id, response)
+    stub_pivotal_request(
+      :delete,
+      urn_for_bar_story_task(task_id),
+      response: response
+    )
+  end
+
+  def stub_failing_bar_story_task_delete_request(task_id)
+    stub_bar_story_task_delete_request(task_id, status: 500)
+  end
+
+  def stub_working_bar_story_task_delete_request(task_id)
+    stub_bar_story_task_delete_request(task_id, status: 204)
+  end
+
+  specify '#execute deletes the task' do
+    stubbed_requests = [
+      stub_bar_story_request,
+      stub_bar_story_tasks_request.times(2),
+      stub_working_bar_story_task_delete_request(@task_id)
+    ]
+
+    response = nil
+    expect_requests stubbed_requests do
+      @command.stub :current_branch, bar_story_id do
+        @command.execute(@task_position)
+      end
+      response = @command.response
+    end
+    assert_equal fixture_file('task_deleted.txt'), response
+  end
+
+  specify '#response when deleting the task fails' do
+    stub_bar_story_request
+    stub_bar_story_tasks_request
+    stub_failing_bar_story_task_delete_request(@task_id)
+    @command.stub :current_branch, bar_story_id do
+      @command.execute(@task_position)
+    end
+    assert_equal @command.send(:task_error_message), @command.response
+  end
+
+  specify_response_for_invalid_task_position :delete, @invalid_position
+  specify_response_for_invalid_story @task_position
+end

data/test/task_list_command_test.rb

@@ -0,0 +1,18 @@
+require 'test_helper'
+require 'pivotal_tracker'
+require 'gradesfirst/task_list_command'
+
+describe GradesFirst::TaskListCommand do
+  before do
+    @command = GradesFirst::TaskListCommand.new
+  end
+
+  specify '#response responds with a task list with a valid story ' do
+    expect_requests stub_bar_story_request, stub_bar_story_tasks_request do
+      @command.stub :current_branch, bar_story_id, &call_execute
+    end
+    assert_equal fixture_file('tasks.txt'), @command.response
+  end
+
+  specify_response_for_invalid_story
+end

data/test/task_move_command_test.rb

@@ -0,0 +1,66 @@
+require 'test_helper'
+require 'gradesfirst/task_move_command'
+
+describe GradesFirst::TaskMoveCommand do
+  before do
+    @task_id = 6
+    @from_position = '2'
+    @to_position = '1'
+    @command = GradesFirst::TaskMoveCommand.new
+  end
+
+  def stub_bar_story_task_move_request(task_id, to_position, response)
+    stub_pivotal_request(
+      :put,
+      urn_for_bar_story_task(task_id),
+      request: { body: "{\"position\":#{to_position}}" },
+      response: response
+    )
+  end
+
+  def stub_failing_bar_story_task_move_request(task_id, to_position)
+    stub_bar_story_task_move_request(
+      task_id,
+      to_position,
+      status: 500
+    )
+  end
+
+  def stub_working_bar_story_task_move_request(task_id, to_position)
+    stub_bar_story_task_move_request(
+      task_id,
+      to_position,
+      body: fixture_file('task.json')
+    )
+  end
+
+  specify '#execute moves the task to a new position' do
+    stubbed_requests = [
+      stub_bar_story_request,
+      stub_bar_story_tasks_request.times(2),
+      stub_working_bar_story_task_move_request(@task_id, @to_position)
+    ]
+
+    response = nil
+    expect_requests stubbed_requests do
+      @command.stub :current_branch, bar_story_id do
+        @command.execute(@from_position, @to_position)
+      end
+      response = @command.response
+    end
+    assert_equal fixture_file('task_moved.txt'), response
+  end
+
+  specify '#response when moving the task fails' do
+    stub_bar_story_request
+    stub_bar_story_tasks_request
+    stub_failing_bar_story_task_move_request(@task_id, @to_position)
+    @command.stub :current_branch, bar_story_id do
+      @command.execute(@from_position, @to_position)
+    end
+    assert_equal @command.send(:task_error_message), @command.response
+  end
+
+  specify_response_for_invalid_task_position :put, @from_position, @to_position
+  specify_response_for_invalid_story @from_position, @to_position
+end

data/test/task_toggle_command_test.rb

@@ -0,0 +1,58 @@
+require 'test_helper'
+require 'gradesfirst/task_toggle_command'
+
+describe GradesFirst::TaskToggleCommand do
+  before do
+    @task_position = '2'
+    @invalid_position = '8'
+    @task_id = 6
+    @command = GradesFirst::TaskToggleCommand.new
+  end
+
+  def stub_bar_story_task_toggle_request(task_id, response)
+    stub_pivotal_request(
+      :put,
+      urn_for_bar_story_task(task_id),
+      request: { body: "{\"complete\":true}" },
+      response: response
+    )
+  end
+
+  def stub_failing_bar_story_task_toggle_request(task_id)
+    stub_bar_story_task_toggle_request(task_id, status: 500)
+  end
+
+  def stub_working_bar_story_task_toggle_request(task_id)
+    stub_bar_story_task_toggle_request(task_id, body: fixture_file('task.json'))
+  end
+
+  specify '#execute toggles completion status of the task' do
+    stubbed_requests = [
+      stub_bar_story_request,
+      stub_bar_story_tasks_request.times(2),
+      stub_working_bar_story_task_toggle_request(@task_id)
+    ]
+
+    response = nil
+    expect_requests stubbed_requests do
+      @command.stub :current_branch, bar_story_id do
+        @command.execute(@task_position)
+      end
+      response = @command.response
+    end
+    assert_equal fixture_file('task_toggled.txt'), response
+  end
+
+  specify '#response when toggling the task fails' do
+    stub_bar_story_request
+    stub_bar_story_tasks_request
+    stub_failing_bar_story_task_toggle_request(@task_id)
+    @command.stub :current_branch, bar_story_id do
+      @command.execute(@task_position)
+    end
+    assert_equal @command.send(:task_error_message), @command.response
+  end
+
+  specify_response_for_invalid_task_position :put, @invalid_position
+  specify_response_for_invalid_story @task_position
+end

data/test/test_helper.rb

@@ -4,26 +4,42 @@ require 'rubygems'
 gem 'minitest' if RUBY_VERSION > '1.9'
 require 'minitest/autorun'
 require 'webmock/minitest'
-require 'mocha/setup'
 require 'pry'
 
-# Retreive the contents of fixture files to be used in tests.  It is easier
-# to view, modify and visualize text used in tests when it is stored in files.
-# Also, it is much easier to reuse that text.
-def fixture_file(file_name)
-  File.open(File.dirname(__FILE__) + '/fixtures/' + file_name, 'rb').read
-end
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+class MiniTest::Unit::TestCase
+  include GradesFirst::PivotalTestHelper
+  extend GradesFirst::PivotalTestHelper::ClassMethods
+
+  def setup
+    pivotal_tracker_setup
+  end
+
+  # Retreive the contents of fixture files to be used in tests.  It is easier
+  # to view, modify and visualize text used in tests when it is stored in files.
+  # Also, it is much easier to reuse that text.
+  def fixture_file(file_name)
+    File.open(fixture_file_path(file_name), 'rb').read
+  end
+
+  def fixture_file_path(file_name)
+    File.join(File.dirname(__FILE__), 'fixtures', file_name)
+  end
+
+  # This returns a lambda for use as the block argument of #stub. The lambda
+  # returned calls #execute on the object being stubbed.
+  def call_execute
+    ->(stubbed_object) { stubbed_object.execute }
+  end
 
-# Simplify and DRY up stubbing out of PivotalTracker requests.
-def stub_pivotal_request(method, urn, options)
-  default_options = {
-    headers: { 'Content-Type' => 'application/json' },
-    body: '',
-    status: 200
-  }
-
-  uri = "https://www.pivotaltracker.com:443/services/v5/#{urn}"
-  stub_request(method,  uri).
-    with(headers: { 'X-TrackerToken' => 'test_token' }).
-    to_return(default_options.merge(options))
+  # Verifies that stubbed out requests have actually been requested.
+  #
+  # expectations - A variable number of RequestExpectation objects.
+  def expect_requests(*expectations)
+    yield
+    expectations.
+      flatten.
+      each { |expectation| assert_requested(*expectation.to_args) }
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gradesfirst
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-18 00:00:00.000000000 Z
+date: 2014-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.14.6
+        version: 0.18.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.14.6
+        version: 0.18.1
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -62,10 +62,20 @@ files:
 - lib/gradesfirst.rb
 - lib/gradesfirst/branch_command.rb
 - lib/gradesfirst/cli.rb
+- lib/gradesfirst/cli_helper.rb
 - lib/gradesfirst/command.rb
 - lib/gradesfirst/commit_message_command.rb
+- lib/gradesfirst/task_add_command.rb
+- lib/gradesfirst/task_cli.rb
 - lib/gradesfirst/task_command.rb
+- lib/gradesfirst/task_delete_command.rb
+- lib/gradesfirst/task_list_command.rb
+- lib/gradesfirst/task_move_command.rb
+- lib/gradesfirst/task_toggle_command.rb
 - lib/http_magic.rb
+- lib/http_magic/api.rb
+- lib/http_magic/request.rb
+- lib/http_magic/uri.rb
 - lib/pivotal_tracker.rb
 - test/branch_command_test.rb
 - test/cli_test.rb
@@ -77,12 +87,24 @@ files:
 - test/fixtures/projects.json
 - test/fixtures/story_bar.json
 - test/fixtures/story_foo.json
+- test/fixtures/task.json
+- test/fixtures/task_added.txt
+- test/fixtures/task_deleted.txt
+- test/fixtures/task_moved.txt
+- test/fixtures/task_toggled.txt
 - test/fixtures/tasks.json
 - test/fixtures/tasks.txt
-- test/http_magic/get_test.rb
+- test/http_magic/api/get_test.rb
+- test/http_magic/api/post_test.rb
+- test/http_magic/request_test.rb
 - test/http_magic/uri_test.rb
-- test/pivotal_tracker_test.rb
-- test/task_command_test.rb
+- test/support/pivotal_test_helper.rb
+- test/support/request_expectation.rb
+- test/task_add_command_test.rb
+- test/task_delete_command_test.rb
+- test/task_list_command_test.rb
+- test/task_move_command_test.rb
+- test/task_toggle_command_test.rb
 - test/test_helper.rb
 homepage: http://www.gradesfirst.com
 licenses:

data/test/pivotal_tracker_test.rb

@@ -1,46 +0,0 @@
-require 'test_helper'
-require 'pivotal_tracker'
-
-describe 'PivotalTracker' do
-  it 'should make a good root uri' do
-    assert_equal(
-      'www.pivotaltracker.com/services/v5',
-      PivotalTracker.uri
-    )
-  end
-
-  it 'should make a good project list uri' do
-    assert_equal(
-      'www.pivotaltracker.com/services/v5/projects',
-      PivotalTracker.projects.uri
-    )
-  end
-
-  it 'should make a good project uri' do
-    assert_equal(
-      'www.pivotaltracker.com/services/v5/projects/99',
-      PivotalTracker.projects[99].uri
-    )
-  end
-
-  it 'should make a good iterations uri' do
-    assert_equal(
-      'www.pivotaltracker.com/services/v5/projects/99/iterations',
-      PivotalTracker.projects[99].iterations.uri
-    )
-  end
-
-  it 'should return a pivotal project' do
-    stub_pivotal_request(
-      :get,
-      'projects/99',
-      body: fixture_file('projects.json')
-    )
-
-    PivotalTracker.api_token = 'test_token'
-    assert_equal(
-      'GradesFirst',
-      PivotalTracker.projects[99].get.first['name']
-    )
-  end
-end

data/test/task_command_test.rb

@@ -1,52 +0,0 @@
-require 'test_helper'
-require 'gradesfirst/task_command'
-
-describe GradesFirst::TaskCommand do
-  before do
-    stub_pivotal_request(
-      :get,
-      'stories/29384799',
-      status: 404
-    )
-
-    stub_pivotal_request(
-      :get,
-      'stories/29384793',
-      body: fixture_file('story_bar.json')
-    )
-
-    stub_pivotal_request(
-      :get,
-      'projects/10687/stories/29384793/tasks',
-      body: fixture_file('tasks.json')
-    )
-
-    PivotalTracker.api_token = 'test_token'
-  end
-
-  describe '#response with a valid story' do
-    before do
-      @command = GradesFirst::TaskCommand.new
-      @command.stub :current_branch, '29384793' do
-        @command.execute
-      end
-    end
-
-    it 'should respond with a task list' do
-      assert_equal fixture_file('tasks.txt'), @command.response
-    end
-  end
-
-  describe '#response with an invalid story' do
-    before do
-      @command = GradesFirst::TaskCommand.new
-      @command.stub :current_branch, '29384799' do
-        @command.execute
-      end
-    end
-
-    it 'should respond with error message' do
-      assert_equal @command.send(:error_message), @command.response
-    end
-  end
-end