gradesfirst 0.2.1 → 0.3.0

data/test/fixtures/task_added.txt

@@ -0,0 +1,6 @@
+  Task was successfully added.
+
+  Bring me the passengers (http://www.pivotaltracker.com/story/show/29384793)
+
+   1. [X] Port 0
+   2. [ ] Port 90

data/test/fixtures/task_deleted.txt

@@ -0,0 +1,6 @@
+  Task was successfully deleted.
+
+  Bring me the passengers (http://www.pivotaltracker.com/story/show/29384793)
+
+   1. [X] Port 0
+   2. [ ] Port 90

data/test/fixtures/task_moved.txt

@@ -0,0 +1,6 @@
+  Task was successfully moved.
+
+  Bring me the passengers (http://www.pivotaltracker.com/story/show/29384793)
+
+   1. [X] Port 0
+   2. [ ] Port 90

data/test/fixtures/task_toggled.txt

@@ -0,0 +1,6 @@
+  Task completion status was successfully toggled.
+
+  Bring me the passengers (http://www.pivotaltracker.com/story/show/29384793)
+
+   1. [X] Port 0
+   2. [ ] Port 90

data/test/fixtures/tasks.txt

@@ -1,4 +1,4 @@
   Bring me the passengers (http://www.pivotaltracker.com/story/show/29384793)
 
-  [X] Port 0
-  [ ] Port 90
+   1. [X] Port 0
+   2. [ ] Port 90

data/test/http_magic/{get_test.rb → api/get_test.rb}

@@ -1,7 +1,7 @@
 require 'test_helper'
 require 'http_magic'
 
-class HttpMagicTest < HttpMagic
+class HttpMagicTest < HttpMagic::Api
 end
 
 describe 'HttpMagic#get' do

data/test/http_magic/api/post_test.rb

@@ -0,0 +1,34 @@
+require 'test_helper'
+require 'http_magic'
+
+class HttpMagicTest < HttpMagic::Api
+end
+
+describe 'HttpMagic#post' do
+  before do
+    @url = HttpMagicTest.url 'www.example.com'
+    HttpMagicTest.namespace nil
+    HttpMagicTest.headers nil
+  end
+
+  it 'should send POST request' do
+    stub_post = stub_request(:post, "https://#{@url}")
+
+    HttpMagicTest.post
+    assert_requested stub_post
+  end
+
+  it 'should send data with POST request' do
+    expected_data = {
+      apple: 'sauce',
+      banana: 'bread'
+    }
+    stub_post = stub_request(:post, "https://#{@url}/foo").with(
+      body: expected_data
+    )
+
+    HttpMagicTest.foo.post(expected_data)
+
+    assert_requested stub_post
+  end
+end

data/test/http_magic/request_test.rb

@@ -0,0 +1,63 @@
+require 'test_helper'
+require 'http_magic/uri'
+require 'http_magic/request'
+
+describe 'HttpMagic::Request' do
+  before do
+    @domain = 'example.com'
+    @uri = HttpMagic::Uri.new(@domain)
+  end
+
+  it 'should make a request' do
+    stub_request = stub_request(
+      :get,
+      "https://#{@domain}/api/v2/path/to/something"
+    )
+
+    @uri.namespace = 'api/v2'
+    @uri.parts = ['path', 'to', 'something']
+    request = HttpMagic::Request.new(@uri)
+    request.get
+
+    assert_requested stub_request
+  end
+
+  it 'should return content on request' do
+    content = 'This is SPARTA!'
+    stub_request(:get, "https://#{@domain}").
+      to_return(body: content)
+
+    request = HttpMagic::Request.new(@uri)
+
+    assert_equal content, request.get
+  end
+
+  it 'should be able to post data as hash' do
+    expected_data = {
+      apple: 'crispy',
+      banana: 'soft'
+    }
+    stub_request = stub_request(:post, "https://#{@domain}").with(
+      body: expected_data.to_json,
+      headers: { 'content-type' => 'application/json' }
+    )
+
+    request = HttpMagic::Request.new(@uri, data: expected_data)
+    request.post
+
+    assert_requested stub_request
+  end
+
+  it 'should set correct headers' do
+    stub_request = stub_request(:get,  "https://#{@domain}").
+      with(headers: { 'X-AuthToken' => 'test_token' })
+
+    request = HttpMagic::Request.new(
+      @uri,
+      headers: { 'X-AuthToken' => 'test_token' }
+    )
+    request.get
+
+    assert_requested stub_request
+  end
+end

data/test/http_magic/uri_test.rb

@@ -1,76 +1,49 @@
 require 'test_helper'
-require 'http_magic'
+require 'http_magic/uri'
 
-class HttpMagicTest < HttpMagic
-end
-
-describe 'HttpMagic#uri' do
+describe 'HttpMagic::Uri' do
   before do
-    @url = HttpMagicTest.url 'www.example.com'
-    HttpMagicTest.namespace nil
-  end
-
-  it 'should make a good root uri' do
-    assert_equal(
-      "#{@url}/",
-      HttpMagicTest.uri
-    )
+    @domain = 'example.com'
+    @uri = uri = HttpMagic::Uri.new(@domain)
   end
 
-  it 'should make a uri that begins with new' do
-    assert_equal(
-      "#{@url}/new",
-      HttpMagicTest.new.uri
-    )
+  it 'must have a domain param' do
+    assert_raises ArgumentError do
+      HttpMagic::Uri.new
+    end
   end
 
-  it 'should make a good single part uri' do
-    assert_equal(
-      "#{@url}/foos",
-      HttpMagicTest.foos.uri
-    )
+  it 'should return the domain' do
+    assert_equal @domain, @uri.domain
   end
 
-  it 'should make a good uri with an index' do
-    assert_equal(
-      "#{@url}/foos/99",
-      HttpMagicTest.foos[99].uri
-    )
+  it 'can build a simple uri' do
+    assert_equal "https://#{@domain}/", @uri.build
   end
 
-  it 'should make a good nested uri' do
-    assert_equal(
-      "#{@url}/foos/99/bars",
-      HttpMagicTest.foos[99].bars.uri
-    )
+  it 'should have url' do
+    assert_equal "https://#{@domain}", @uri.url
   end
 
-  it 'should make a uri including a keyword at the beginning' do
-    assert_equal(
-      "#{@url}/get",
-      HttpMagicTest[:get].uri
-    )
+  it 'should create urn with parts' do
+    @uri.parts = ['path', 'to', 'something']
+    assert_equal '/path/to/something', @uri.urn
   end
 
-  it 'should make a uri including a keyword in the middle' do
-    assert_equal(
-      "#{@url}/foo/get/bar",
-      HttpMagicTest.foo[:get].bar.uri
-    )
+  it 'should create urn with namespace' do
+    @uri.namespace = 'api/v2'
+    assert_equal '/api/v2', @uri.urn
   end
 
-  it 'should make a uri including a keyword at the end' do
-    assert_equal(
-      "#{@url}/foo/bar/get",
-      HttpMagicTest.foo.bar[:get].uri
-    )
+  it 'should create urn with namespace and parts combined' do
+    @uri.parts = ['path', 'to', 'something']
+    @uri.namespace = 'api/v2'
+    assert_equal '/api/v2/path/to/something', @uri.urn
   end
 
-  it 'should make a namespaced uri' do
-    HttpMagicTest.namespace 'api/v5'
-    assert_equal(
-      "#{@url}/api/v5/foo/bar/get",
-      HttpMagicTest.foo.bar[:get].uri
-    )
+  it 'should create the full uri with urn included' do
+    @uri.parts = ['path', 'to', 'something']
+    @uri.namespace = 'api/v2'
+    assert_equal "https://#{@domain}/api/v2/path/to/something", @uri.build
   end
 end

data/test/support/pivotal_test_helper.rb

@@ -0,0 +1,110 @@
+module GradesFirst
+  module PivotalTestHelper
+
+    def bar_story_id
+      '29384793'
+    end
+
+    def foo_story_id
+      '57348714'
+    end
+
+    def missing_story_id
+      '29384799'
+    end
+
+    def pivotal_tracker_setup
+      PivotalTracker.api_token = 'test_token'
+    end
+
+    def stub_bar_story_request
+      stub_pivotal_request(
+        :get,
+        'stories/' + bar_story_id,
+        response: { body: fixture_file('story_bar.json') }
+      )
+    end
+
+    def stub_bar_story_tasks_request
+      stub_pivotal_request(
+        :get,
+        urn_for_bar_story_tasks,
+        response: { body: fixture_file('tasks.json') }
+      )
+    end
+
+    def stub_foo_story_request
+      stub_pivotal_request(
+        :get,
+        'stories/' + foo_story_id,
+        response: { body: fixture_file('story_foo.json') }
+      )
+    end
+
+    def stub_missing_story_request
+      stub_pivotal_request(
+        :get,
+        'stories/' + missing_story_id,
+        response: { status: 404 }
+      )
+    end
+
+    # Simplify and DRY up stubbing out of PivotalTracker requests.
+    def stub_pivotal_request(method, urn, options = {})
+      default_request = {
+        headers: { 'X-TrackerToken' => 'test_token' }
+      }
+      if method == :post
+        default_request[:headers]['Content-Type'] = 'application/json'
+      end
+      default_response = {
+        headers: { 'Content-Type' => 'application/json' },
+        body: '',
+        status: 200
+      }
+
+      uri = "https://www.pivotaltracker.com:443/services/v5/#{urn}"
+      stub_request(method, uri).
+        with(default_request.merge(options[:request] || {})).
+        to_return(default_response.merge(options[:response] || {}))
+
+      RequestExpectation.new(method, uri)
+    end
+
+    def urn_for_bar_story_tasks
+      "projects/10687/stories/#{bar_story_id}/tasks"
+    end
+
+    def urn_for_bar_story_task(task_id)
+      urn_for_bar_story_tasks + "/#{task_id}"
+    end
+
+    module ClassMethods
+
+      def specify_response_for_invalid_story(*args)
+        specify '#response responds with error message with an invalid story' do
+          expect_requests stub_missing_story_request do
+            @command.stub :current_branch, missing_story_id do
+              @command.execute(*args)
+            end
+          end
+          assert_equal @command.send(:story_error_message), @command.response
+        end
+      end
+
+      def specify_response_for_invalid_task_position(method, *args)
+        specify '#response when position does not exist' do
+          stub_bar_story_request
+          stub_bar_story_tasks_request
+          @command.stub :current_branch, bar_story_id do
+            @command.execute(*args)
+          end
+          assert_equal @command.send(:position_invalid_message), @command.response
+          assert_not_requested method, /.*/
+        end
+      end
+
+    end
+
+  end
+end

data/test/support/request_expectation.rb

@@ -0,0 +1,33 @@
+# This class encapsulates creating http request expectations with the webmock
+# assert_requested assertion.
+#
+# Example:
+#   expectation = RequestExpectation(:get, 'http://example.com').times(2)
+#   assert_requested(*expectation.to_args)
+class RequestExpectation
+  # Store the HTTP request method and uri that are expected and specifies the
+  # default number of times that the request is expected to made.
+  def initialize(method, uri)
+    @method = method
+    @uri = uri
+    @times = 1
+  end
+
+  # Specifies the number of times that a request is expected to be made.
+  #
+  # Example:
+  #   RequestExpectation.new(:get, 'http://example.com').times(2).to_args
+  #
+  # Retuns an instance of itself to allow for method chaining.
+  def times(value)
+    @times = value
+    self
+  end
+
+  # Creates a set of method arguments for the Webmock assert_requested method.
+  #
+  # Returns an array of Webmock assert_request method arguments.
+  def to_args
+    [@method, @uri, { times: @times }]
+  end
+end

data/test/task_add_command_test.rb

@@ -0,0 +1,54 @@
+require 'test_helper'
+require 'gradesfirst/task_add_command'
+
+describe GradesFirst::TaskAddCommand do
+  before do
+    @task_description = 'New task.'
+    @command = GradesFirst::TaskAddCommand.new
+  end
+
+  def stub_bar_story_task_add_request(response)
+    stub_pivotal_request(
+      :post,
+      urn_for_bar_story_tasks,
+      request: { body: "{\"description\":\"#{@task_description}\"}" },
+      response: response
+    )
+  end
+
+  def stub_failing_bar_story_task_add_request
+    stub_bar_story_task_add_request status: 500
+  end
+
+  def stub_working_bar_story_task_add_request
+    stub_bar_story_task_add_request body: fixture_file('task.json')
+  end
+
+  specify '#response responds with confirmation and task list' do
+    stubbed_requests = [
+      stub_bar_story_request,
+      stub_bar_story_tasks_request,
+      stub_working_bar_story_task_add_request
+    ]
+
+    response = nil
+    expect_requests stubbed_requests do
+      @command.stub :current_branch, bar_story_id do
+        @command.execute(@task_description)
+      end
+      response = @command.response
+    end
+    assert_equal fixture_file('task_added.txt'), response
+  end
+
+  specify '#response when adding the task fails' do
+    stub_bar_story_request
+    stub_failing_bar_story_task_add_request
+    @command.stub :current_branch, bar_story_id do
+      @command.execute(@task_description)
+    end
+    assert_equal @command.send(:task_error_message), @command.response
+  end
+
+  specify_response_for_invalid_story @task_description
+end