govuk_frontend_toolkit 4.18.3 → 4.18.4

data/app/assets/spec/unit/modules.spec.js

@@ -1,89 +1,93 @@
-describe('GOVUK Modules', function() {
-  "use strict";
-  var GOVUK = window.GOVUK;
-
-  it('finds modules', function() {
-    var module = $('<div data-module="a-module"></div>');
-    $('body').append(module);
-
-    expect(GOVUK.modules.find().length).toBe(1);
-    expect(GOVUK.modules.find().eq(0).is('[data-module="a-module"]')).toBe(true);
-    module.remove();
-  });
-
-  it('finds modules in a container', function() {
-    var module = $('<div data-module="a-module"></div>'),
-        container = $('<div></div>').append(module);
-
-    expect(GOVUK.modules.find(container).length).toBe(1);
-    expect(GOVUK.modules.find(container).eq(0).data('module')).toBe('a-module');
-  });
-
-  it('finds modules that are a container', function() {
-    var module = $('<div data-module="a-module"></div>'),
-        container = $('<div data-module="container-module"></div>').append(module);
-
-    expect(GOVUK.modules.find(container).length).toBe(2);
-    expect(GOVUK.modules.find(container).eq(0).data('module')).toBe('container-module');
-    expect(GOVUK.modules.find(container).eq(1).data('module')).toBe('a-module');
-  });
-
-  describe('when a module exists', function() {
-    var callback;
-
-    beforeEach(function() {
-      callback = jasmine.createSpy();
-      GOVUK.Modules.TestAlertModule = function() {
-        var that = this;
-        that.start = function(element) {
-          callback(element);
+/* global describe it expect beforeEach afterEach jasmine */
+
+var $ = window.jQuery
+
+describe('GOVUK Modules', function () {
+  'use strict'
+  var GOVUK = window.GOVUK
+
+  it('finds modules', function () {
+    var module = $('<div data-module="a-module"></div>')
+    $('body').append(module)
+
+    expect(GOVUK.modules.find().length).toBe(1)
+    expect(GOVUK.modules.find().eq(0).is('[data-module="a-module"]')).toBe(true)
+    module.remove()
+  })
+
+  it('finds modules in a container', function () {
+    var module = $('<div data-module="a-module"></div>')
+    var container = $('<div></div>').append(module)
+
+    expect(GOVUK.modules.find(container).length).toBe(1)
+    expect(GOVUK.modules.find(container).eq(0).data('module')).toBe('a-module')
+  })
+
+  it('finds modules that are a container', function () {
+    var module = $('<div data-module="a-module"></div>')
+    var container = $('<div data-module="container-module"></div>').append(module)
+
+    expect(GOVUK.modules.find(container).length).toBe(2)
+    expect(GOVUK.modules.find(container).eq(0).data('module')).toBe('container-module')
+    expect(GOVUK.modules.find(container).eq(1).data('module')).toBe('a-module')
+  })
+
+  describe('when a module exists', function () {
+    var callback
+
+    beforeEach(function () {
+      callback = jasmine.createSpy()
+      GOVUK.Modules.TestAlertModule = function () {
+        var that = this
+        that.start = function (element) {
+          callback(element)
         }
-      };
-    });
+      }
+    })
 
-    afterEach(function() {
-      delete GOVUK.Modules.TestAlertModule;
-    });
+    afterEach(function () {
+      delete GOVUK.Modules.TestAlertModule
+    })
 
-    it('starts modules within a container', function() {
-      var module = $('<div data-module="test-alert-module"></div>'),
-          container = $('<div></div>').append(module);
+    it('starts modules within a container', function () {
+      var module = $('<div data-module="test-alert-module"></div>')
+      var container = $('<div></div>').append(module)
 
-      GOVUK.modules.start(container);
-      expect(callback).toHaveBeenCalled();
-    });
+      GOVUK.modules.start(container)
+      expect(callback).toHaveBeenCalled()
+    })
 
-    it('does not start modules that are already started', function() {
-      var module = $('<div data-module="test-alert-module"></div>'),
-          container = $('<div></div>').append(module);
+    it('does not start modules that are already started', function () {
+      var module = $('<div data-module="test-alert-module"></div>')
+      $('<div></div>').append(module)
 
-      GOVUK.modules.start(module);
-      GOVUK.modules.start(module);
-      expect(callback.calls.count()).toBe(1);
-    });
+      GOVUK.modules.start(module)
+      GOVUK.modules.start(module)
+      expect(callback.calls.count()).toBe(1)
+    })
 
-    it('passes the HTML element to the module\'s start method', function() {
-      var module = $('<div data-module="test-alert-module"></div>'),
-          container = $('<h1></h1>').append(module);
+    it('passes the HTML element to the module\'s start method', function () {
+      var module = $('<div data-module="test-alert-module"></div>')
+      var container = $('<h1></h1>').append(module)
 
-      GOVUK.modules.start(container);
+      GOVUK.modules.start(container)
 
-      var args = callback.calls.argsFor(0);
-      expect(args[0].is('div[data-module="test-alert-module"]')).toBe(true);
-    });
+      var args = callback.calls.argsFor(0)
+      expect(args[0].is('div[data-module="test-alert-module"]')).toBe(true)
+    })
 
-    it('starts all modules that are on the page', function() {
+    it('starts all modules that are on the page', function () {
       var modules = $(
-            '<div data-module="test-alert-module"></div>\
-             <strong data-module="test-alert-module"></strong>\
-             <span data-module="test-alert-module"></span>'
-          );
-
-      $('body').append(modules);
-      GOVUK.modules.start();
-      expect(callback.calls.count()).toBe(3);
-
-      modules.remove();
-    });
-  });
-});
+        '<div data-module="test-alert-module"></div>' +
+        '<strong data-module="test-alert-module"></strong>' +
+        '<span data-module="test-alert-module"></span>'
+      )
+
+      $('body').append(modules)
+      GOVUK.modules.start()
+      expect(callback.calls.count()).toBe(3)
+
+      modules.remove()
+    })
+  })
+})

data/app/assets/spec/unit/modules/auto-track-event.spec.js

@@ -1,49 +1,54 @@
-describe('An auto event tracker', function() {
-  "use strict";
+/* global describe it expect beforeEach afterEach spyOn */
+
+var $ = window.jQuery
+
+describe('An auto event tracker', function () {
+  'use strict'
+  var GOVUK = window.GOVUK
 
   var tracker,
-      element;
+    element
 
-  beforeEach(function() {
-    GOVUK.analytics = {trackEvent: function() {}};
-    tracker = new GOVUK.Modules.AutoTrackEvent();
-  });
+  beforeEach(function () {
+    GOVUK.analytics = {trackEvent: function () {}}
+    tracker = new GOVUK.Modules.AutoTrackEvent()
+  })
 
-  afterEach(function() {
-    delete GOVUK.analytics;
-  });
+  afterEach(function () {
+    delete GOVUK.analytics
+  })
 
-  it('tracks non-interactive events on start', function() {
-    spyOn(GOVUK.analytics, 'trackEvent');
+  it('tracks non-interactive events on start', function () {
+    spyOn(GOVUK.analytics, 'trackEvent')
 
-    element = $('\
-      <div \
-        data-track-category="category"\
-        data-track-action="action">\
-        Some content\
-      </div>\
-    ');
+    element = $(
+      '<div ' +
+        'data-track-category="category"' +
+        'data-track-action="action">' +
+        'Some content' +
+      '</div>'
+    )
 
-    tracker.start(element);
+    tracker.start(element)
     expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
-      'category', 'action', {nonInteraction: 1});
-  });
-
-  it('can track non-interactive events with optional label and value', function() {
-    spyOn(GOVUK.analytics, 'trackEvent');
-
-    element = $('\
-      <div \
-        data-track-category="category"\
-        data-track-action="action"\
-        data-track-label="label"\
-        data-track-value="10">\
-        Some content\
-      </div>\
-    ');
-
-    tracker.start(element);
+      'category', 'action', {nonInteraction: 1})
+  })
+
+  it('can track non-interactive events with optional label and value', function () {
+    spyOn(GOVUK.analytics, 'trackEvent')
+
+    element = $(
+      '<div ' +
+        'data-track-category="category"' +
+        'data-track-action="action"' +
+        'data-track-label="label"' +
+        'data-track-value="10">' +
+        'Some content' +
+      '</div>'
+    )
+
+    tracker.start(element)
     expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
-      'category', 'action', {label: 'label', value: 10, nonInteraction: 1});
-  });
-});
+      'category', 'action', {label: 'label', value: 10, nonInteraction: 1})
+  })
+})

data/app/assets/spec/unit/multivariate-test.spec.js

@@ -1,136 +1,142 @@
-describe("MultivariateTest", function() {
-  beforeEach(function() {
-    GOVUK.cookie = jasmine.createSpy('GOVUK.cookie');
-    GOVUK.analytics = {setDimension:function(){}, trackEvent:function(){}};
-    spyOn(GOVUK.analytics, "setDimension");
-    spyOn(GOVUK.analytics, "trackEvent");
-  });
+/* global describe it expect beforeEach afterEach jasmine spyOn */
 
-  afterEach(function() {
-    delete GOVUK.analytics;
-  });
+var $ = window.jQuery
 
-  describe("#run", function() {
-    it("should pick a random cohort on first run", function() {
-      GOVUK.cookie.and.returnValue(null);
-      var fooSpy = jasmine.createSpy('fooSpy');
-      var barSpy = jasmine.createSpy('barSpy');
-      var test = new GOVUK.MultivariateTest({
+describe('MultivariateTest', function () {
+  'use strict'
+  var GOVUK = window.GOVUK
+
+  beforeEach(function () {
+    GOVUK.cookie = jasmine.createSpy('GOVUK.cookie')
+    GOVUK.analytics = {setDimension: function () {}, trackEvent: function () {}}
+    spyOn(GOVUK.analytics, 'setDimension')
+    spyOn(GOVUK.analytics, 'trackEvent')
+  })
+
+  afterEach(function () {
+    delete GOVUK.analytics
+  })
+
+  describe('#run', function () {
+    it('should pick a random cohort on first run', function () {
+      GOVUK.cookie.and.returnValue(null)
+      var fooSpy = jasmine.createSpy('fooSpy')
+      var barSpy = jasmine.createSpy('barSpy')
+      new GOVUK.MultivariateTest({ // eslint-disable-line no-new
         name: 'stuff',
         cohorts: {
           foo: {callback: fooSpy},
           bar: {callback: barSpy}
         }
-      });
+      })
 
-      expect(GOVUK.cookie.calls.count()).toEqual(2);
-      expect(GOVUK.cookie.calls.argsFor(1)[0]).toEqual('multivariatetest_cohort_stuff');
-      if (GOVUK.cookie.calls.argsFor(1)[1] == 'foo') {
-        expect(fooSpy).toHaveBeenCalled();
-      }
-      else {
-        expect(barSpy).toHaveBeenCalled();
+      expect(GOVUK.cookie.calls.count()).toEqual(2)
+      expect(GOVUK.cookie.calls.argsFor(1)[0]).toEqual('multivariatetest_cohort_stuff')
+      if (GOVUK.cookie.calls.argsFor(1)[1] === 'foo') {
+        expect(fooSpy).toHaveBeenCalled()
+      } else {
+        expect(barSpy).toHaveBeenCalled()
       }
-    });
+    })
 
-    it("should use an existing cohort choice on subsequent runs", function() {
-      GOVUK.cookie.and.returnValue('foo');
-      var fooSpy = jasmine.createSpy('fooSpy');
-      var barSpy = jasmine.createSpy('barSpy');
-      var test = new GOVUK.MultivariateTest({
+    it('should use an existing cohort choice on subsequent runs', function () {
+      GOVUK.cookie.and.returnValue('foo')
+      var fooSpy = jasmine.createSpy('fooSpy')
+      var barSpy = jasmine.createSpy('barSpy')
+      new GOVUK.MultivariateTest({ // eslint-disable-line no-new
         name: 'stuff',
         cohorts: {
           foo: {callback: fooSpy},
           bar: {callback: barSpy}
         }
-      });
-      expect(fooSpy).toHaveBeenCalled();
-    });
+      })
+      expect(fooSpy).toHaveBeenCalled()
+    })
 
-    it("should set a custom var with the name and cohort if one is defined", function() {
-      GOVUK.cookie.and.returnValue('foo');
-      var test = new GOVUK.MultivariateTest({
+    it('should set a custom var with the name and cohort if one is defined', function () {
+      GOVUK.cookie.and.returnValue('foo')
+      new GOVUK.MultivariateTest({ // eslint-disable-line no-new
         name: 'stuff',
         cohorts: {
           foo: {},
           bar: {}
         },
         customDimensionIndex: 2
-      });
+      })
       expect(GOVUK.analytics.setDimension).toHaveBeenCalledWith(
         2,
         'multivariatetest_cohort_stuff__foo'
-      );
-    });
+      )
+    })
 
-    it("should be able to set multiple custom vars with the name and cohort if one is defined as an array", function() {
-      GOVUK.cookie.and.returnValue('foo');
-      var test = new GOVUK.MultivariateTest({
+    it('should be able to set multiple custom vars with the name and cohort if one is defined as an array', function () {
+      GOVUK.cookie.and.returnValue('foo')
+      new GOVUK.MultivariateTest({ // eslint-disable-line no-new
         name: 'stuff',
         cohorts: {
           foo: {},
           bar: {}
         },
-        customDimensionIndex: [2,3]
-      });
+        customDimensionIndex: [2, 3]
+      })
       expect(GOVUK.analytics.setDimension).toHaveBeenCalledWith(
         2,
         'multivariatetest_cohort_stuff__foo'
-      );
+      )
       expect(GOVUK.analytics.setDimension).toHaveBeenCalledWith(
         3,
         'multivariatetest_cohort_stuff__foo'
-      );
-    });
+      )
+    })
 
-    it("should trigger an event to track that the test has been run", function() {
-      GOVUK.cookie.and.returnValue('foo');
-      var test = new GOVUK.MultivariateTest({
+    it('should trigger an event to track that the test has been run', function () {
+      GOVUK.cookie.and.returnValue('foo')
+      new GOVUK.MultivariateTest({ // eslint-disable-line no-new
         name: 'stuff',
         cohorts: {
           foo: {},
           bar: {}
-        },
-      });
+        }
+      })
       expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
         'multivariatetest_cohort_stuff',
         'run',
-        {nonInteraction:true}
-      );
-    });
+        {nonInteraction: true}
+      )
+    })
 
-    it("should set html for a cohort", function() {
-      GOVUK.cookie.and.returnValue('foo');
-      var $el = $('<div>');
-      var test = new GOVUK.MultivariateTest({
+    it('should set html for a cohort', function () {
+      GOVUK.cookie.and.returnValue('foo')
+      var $el = $('<div>')
+      new GOVUK.MultivariateTest({ // eslint-disable-line no-new
         name: 'stuff',
         el: $el,
         cohorts: {
-          foo: {html: "foo"},
-          bar: {html: "bar"}
+          foo: {html: 'foo'},
+          bar: {html: 'bar'}
         }
-      });
-      expect($el.html()).toEqual('foo');
-    });
+      })
+      expect($el.html()).toEqual('foo')
+    })
 
-    it("should call the callback for a cohort", function() {
-      var fooSpy = jasmine.createSpy('fooSpy');
-      var barSpy = jasmine.createSpy('barSpy');
-      GOVUK.cookie.and.returnValue('bar');
-      var $el = $('<div>');
-      var test = new GOVUK.MultivariateTest({
+    it('should call the callback for a cohort', function () {
+      var fooSpy = jasmine.createSpy('fooSpy')
+      var barSpy = jasmine.createSpy('barSpy')
+      GOVUK.cookie.and.returnValue('bar')
+      var $el = $('<div>')
+      new GOVUK.MultivariateTest({ // eslint-disable-line no-new
         name: 'stuff',
         el: $el,
         cohorts: {
           foo: {callback: fooSpy},
           bar: {callback: barSpy}
         }
-      });
-      expect(barSpy).toHaveBeenCalled();
-    });
+      })
+      expect(barSpy).toHaveBeenCalled()
+    })
 
-    it("should call the callback for a cohort if it is a string", function() {
-      GOVUK.cookie.and.returnValue('foo');
+    it('should call the callback for a cohort if it is a string', function () {
+      GOVUK.cookie.and.returnValue('foo')
       var test = new GOVUK.MultivariateTest({
         name: 'stuff',
         cohorts: {
@@ -138,120 +144,119 @@ describe("MultivariateTest", function() {
           bar: {}
         },
         runImmediately: false
-      });
-      test.fooCallback = jasmine.createSpy('fooCallback');
-      test.run();
-      expect(test.fooCallback).toHaveBeenCalled();
-    });
+      })
+      test.fooCallback = jasmine.createSpy('fooCallback')
+      test.run()
+      expect(test.fooCallback).toHaveBeenCalled()
+    })
 
-    it("should assign 30 if cookieDuration isn't defined", function() {
-      GOVUK.cookie.and.returnValue('foo');
+    it("should assign 30 if cookieDuration isn't defined", function () {
+      GOVUK.cookie.and.returnValue('foo')
       var test = new GOVUK.MultivariateTest({
         name: 'cookie_duration_test',
         cohorts: {
-          foo: {callback: function(){}}
+          foo: {callback: function () {}}
         }
-      });
-      expect(test.cookieDuration).toEqual(30);
-    });
+      })
+      expect(test.cookieDuration).toEqual(30)
+    })
 
-    it("should assign the user's cookie duration, when cookieDuration is defined", function() {
-      GOVUK.cookie.and.returnValue('foo');
+    it("should assign the user's cookie duration, when cookieDuration is defined", function () {
+      GOVUK.cookie.and.returnValue('foo')
       var test = new GOVUK.MultivariateTest({
         name: 'cookie_duration_test',
         cookieDuration: 14,
         cohorts: {
-          foo: {callback: function(){}}
+          foo: {callback: function () {}}
         }
-      });
-      expect(test.cookieDuration).toEqual(14);
-    });
+      })
+      expect(test.cookieDuration).toEqual(14)
+    })
 
-    it("should assign a new random cohort if the assigned cohort does not exist", function() {
-      var fooSpy = jasmine.createSpy('fooSpy');
-      var barSpy = jasmine.createSpy('barSpy');
-      GOVUK.cookie.and.returnValue('baz');
-      var test = new GOVUK.MultivariateTest({
+    it('should assign a new random cohort if the assigned cohort does not exist', function () {
+      var fooSpy = jasmine.createSpy('fooSpy')
+      var barSpy = jasmine.createSpy('barSpy')
+      GOVUK.cookie.and.returnValue('baz')
+      new GOVUK.MultivariateTest({ // eslint-disable-line no-new
         name: 'stuff',
         cohorts: {
           foo: {callback: fooSpy},
           bar: {callback: barSpy}
         }
-      });
-      if (GOVUK.cookie.calls.argsFor(1)[1] == 'foo') {
-        expect(fooSpy).toHaveBeenCalled();
-      }
-      else {
-        expect(barSpy).toHaveBeenCalled();
+      })
+      if (GOVUK.cookie.calls.argsFor(1)[1] === 'foo') {
+        expect(fooSpy).toHaveBeenCalled()
+      } else {
+        expect(barSpy).toHaveBeenCalled()
       }
-    });
-  });
+    })
+  })
 
-  describe("#weightedCohortNames", function() {
-    it("should return the weighted names of the cohorts when no weights are defined", function() {
+  describe('#weightedCohortNames', function () {
+    it('should return the weighted names of the cohorts when no weights are defined', function () {
       var test = new GOVUK.MultivariateTest({
         name: 'stuff',
         cohorts: {foo: {}, bar: {}, baz: {}}
-      });
-      expect(test.weightedCohortNames()).toEqual(['foo', 'bar', 'baz']);
-    });
+      })
+      expect(test.weightedCohortNames()).toEqual(['foo', 'bar', 'baz'])
+    })
 
-    it("should return the weighted names of the cohorts when weights are defined", function() {
+    it('should return the weighted names of the cohorts when weights are defined', function () {
       var test = new GOVUK.MultivariateTest({
         name: 'stuff',
         cohorts: {foo: { weight: 2 }, bar: { weight: 1 }, baz: { weight: 3 }}
-      });
-      expect(test.weightedCohortNames()).toEqual(['foo', 'foo', 'bar', 'baz', 'baz', 'baz']);
-    });
+      })
+      expect(test.weightedCohortNames()).toEqual(['foo', 'foo', 'bar', 'baz', 'baz', 'baz'])
+    })
 
-    it("should return the weighted names of the cohorts using default weighting", function() {
+    it('should return the weighted names of the cohorts using default weighting', function () {
       var test = new GOVUK.MultivariateTest({
         name: 'stuff',
         defaultWeight: 2,
         cohorts: {foo: {}, bar: {}, baz: {}}
-      });
-      expect(test.weightedCohortNames()).toEqual(['foo', 'foo', 'bar', 'bar', 'baz', 'baz']);
-    });
+      })
+      expect(test.weightedCohortNames()).toEqual(['foo', 'foo', 'bar', 'bar', 'baz', 'baz'])
+    })
 
-    it("should return the weighted names of the cohorts using default weighting or defined weighting", function() {
+    it('should return the weighted names of the cohorts using default weighting or defined weighting', function () {
       var test = new GOVUK.MultivariateTest({
         name: 'stuff',
         defaultWeight: 2,
         cohorts: {foo: {}, bar: { weight: 1 }, baz: {}}
-      });
-      expect(test.weightedCohortNames()).toEqual(['foo', 'foo', 'bar', 'baz', 'baz']);
-    });
-  });
+      })
+      expect(test.weightedCohortNames()).toEqual(['foo', 'foo', 'bar', 'baz', 'baz'])
+    })
+  })
 
-  describe("#chooseRandomCohort", function() {
-    it("should choose a random cohort", function() {
+  describe('#chooseRandomCohort', function () {
+    it('should choose a random cohort', function () {
       var test = new GOVUK.MultivariateTest({
         name: 'stuff',
         cohorts: {foo: {}, bar: {}}
-      });
-      expect(['foo', 'bar']).toContain(test.chooseRandomCohort());
+      })
+      expect(['foo', 'bar']).toContain(test.chooseRandomCohort())
     })
-  });
+  })
 
-  describe("Google Content Experiment Integration", function() {
-    beforeEach(function() {
-      window.ga = function() {};
-      spyOn(window, 'ga');
-    });
+  describe('Google Content Experiment Integration', function () {
+    beforeEach(function () {
+      window.ga = function () {}
+      spyOn(window, 'ga')
+    })
 
-    it("should report the experiment data to Google", function() {
-      var test = new GOVUK.MultivariateTest({
+    it('should report the experiment data to Google', function () {
+      new GOVUK.MultivariateTest({ // eslint-disable-line no-new
         name: 'stuff',
-        contentExperimentId: "asdfsadasdfa",
-        cohorts: {foo: {variantId: 0, weight: 1},  bar: {variantId: 1, weight: 0}}
-      });
-      expect(window.ga.calls.first().args).toEqual(['set', 'expId', 'asdfsadasdfa']);
-      expect(window.ga.calls.mostRecent().args).toEqual(['set', 'expVar', 0]);
+        contentExperimentId: 'asdfsadasdfa',
+        cohorts: {foo: {variantId: 0, weight: 1}, bar: {variantId: 1, weight: 0}}
+      })
+      expect(window.ga.calls.first().args).toEqual(['set', 'expId', 'asdfsadasdfa'])
+      expect(window.ga.calls.mostRecent().args).toEqual(['set', 'expVar', 0])
       expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
         'multivariatetest_cohort_stuff',
         'run',
-        {nonInteraction:true}
-      );
-    });
-  });
-});
+        {nonInteraction: true}
+      )
+    })
+  })
+})