govuk_frontend_toolkit 4.18.3 → 4.18.4

data/app/assets/spec/unit/analytics/external-link-tracker.spec.js

@@ -1,69 +1,77 @@
-describe("GOVUK.analyticsPlugins.externalLinkTracker", function() {
-  var $links;
-
-  beforeEach(function() {
-    $links = $('\
-      <div class="external-links">\
-        <a href="http://www.nationalarchives.gov.uk"> National Archives </a>\
-        <a href="https://www.nationalarchives.gov.uk"></a>\
-        <a href="https://www.nationalarchives.gov.uk/one.pdf">National Archives PDF</a>\
-        <a href="https://www.nationalarchives.gov.uk/an/image/link.png"><img src="/img" /></a>\
-      </div>\
-      <div class="internal-links">\
-        <a href="/some-path">Local link</a>\
-        <a href="http://fake-hostname.com/some-path">Another local link</a>\
-      </div>');
-
-    $('html').on('click', function(evt) { evt.preventDefault(); });
-    $('body').append($links);
-    GOVUK.analytics = {trackEvent:function(){}};
-
-    spyOn(GOVUK.analyticsPlugins.externalLinkTracker, 'getHostname').and.returnValue('fake-hostname.com');
-    GOVUK.analyticsPlugins.externalLinkTracker();
-  });
-
-  afterEach(function() {
-    $('html').off();
-    $('body').off();
-    $links.remove();
-    delete GOVUK.analytics;
-  });
-
-  it('listens to click events on only external links', function() {
-    spyOn(GOVUK.analytics, 'trackEvent');
-
-    $('.external-links a').each(function() {
-      $(this).trigger('click');
-      expect(GOVUK.analytics.trackEvent).toHaveBeenCalled();
-      GOVUK.analytics.trackEvent.calls.reset();
-    });
-
-    $('.internal-links a').each(function() {
-      $(this).trigger('click');
-      expect(GOVUK.analytics.trackEvent).not.toHaveBeenCalled();
-      GOVUK.analytics.trackEvent.calls.reset();
-    });
-  });
-
-  it('listens to click events on elements within external links', function() {
-    spyOn(GOVUK.analytics, 'trackEvent');
-
-    $('.external-links a img').trigger('click');
+/* global describe it expect beforeEach afterEach spyOn */
+
+var $ = window.jQuery
+
+describe('GOVUK.analyticsPlugins.externalLinkTracker', function () {
+  'use strict'
+  var GOVUK = window.GOVUK
+
+  var $links
+
+  beforeEach(function () {
+    $links = $(
+      '<div class="external-links">' +
+        '<a href="http://www.nationalarchives.gov.uk"> National Archives </a>' +
+        '<a href="https://www.nationalarchives.gov.uk"></a>' +
+        '<a href="https://www.nationalarchives.gov.uk/one.pdf">National Archives PDF</a>' +
+        '<a href="https://www.nationalarchives.gov.uk/an/image/link.png"><img src="/img" /></a>' +
+      '</div>' +
+      '<div class="internal-links">' +
+        '<a href="/some-path">Local link</a>' +
+        '<a href="http://fake-hostname.com/some-path">Another local link</a>' +
+      '</div>'
+    )
+
+    $('html').on('click', function (evt) { evt.preventDefault() })
+    $('body').append($links)
+    GOVUK.analytics = {trackEvent: function () {}}
+
+    spyOn(GOVUK.analyticsPlugins.externalLinkTracker, 'getHostname').and.returnValue('fake-hostname.com')
+    GOVUK.analyticsPlugins.externalLinkTracker()
+  })
+
+  afterEach(function () {
+    $('html').off()
+    $('body').off()
+    $links.remove()
+    delete GOVUK.analytics
+  })
+
+  it('listens to click events on only external links', function () {
+    spyOn(GOVUK.analytics, 'trackEvent')
+
+    $('.external-links a').each(function () {
+      $(this).trigger('click')
+      expect(GOVUK.analytics.trackEvent).toHaveBeenCalled()
+      GOVUK.analytics.trackEvent.calls.reset()
+    })
+
+    $('.internal-links a').each(function () {
+      $(this).trigger('click')
+      expect(GOVUK.analytics.trackEvent).not.toHaveBeenCalled()
+      GOVUK.analytics.trackEvent.calls.reset()
+    })
+  })
+
+  it('listens to click events on elements within external links', function () {
+    spyOn(GOVUK.analytics, 'trackEvent')
+
+    $('.external-links a img').trigger('click')
     expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
-      'External Link Clicked', 'https://www.nationalarchives.gov.uk/an/image/link.png', {transport: 'beacon'});
-  });
+      'External Link Clicked', 'https://www.nationalarchives.gov.uk/an/image/link.png', {transport: 'beacon'})
+  })
 
-  it('tracks an external link\'s href and link text', function() {
-    spyOn(GOVUK.analytics, 'trackEvent');
-    $('.external-links a').trigger('click');
+  it('tracks an external link\'s href and link text', function () {
+    spyOn(GOVUK.analytics, 'trackEvent')
+    $('.external-links a').trigger('click')
 
     expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
-      'External Link Clicked', 'http://www.nationalarchives.gov.uk', {transport: 'beacon', label: 'National Archives'});
+      'External Link Clicked', 'http://www.nationalarchives.gov.uk', {transport: 'beacon', label: 'National Archives'})
 
     expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
-      'External Link Clicked', 'https://www.nationalarchives.gov.uk', {transport: 'beacon'});
+      'External Link Clicked', 'https://www.nationalarchives.gov.uk', {transport: 'beacon'})
 
     expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
-      'External Link Clicked', 'https://www.nationalarchives.gov.uk/one.pdf', {transport: 'beacon', label: 'National Archives PDF'});
-  });
-});
+      'External Link Clicked', 'https://www.nationalarchives.gov.uk/one.pdf', {transport: 'beacon', label: 'National Archives PDF'})
+  })
+})

data/app/assets/spec/unit/analytics/google-analytics-universal-tracker.spec.js

@@ -1,113 +1,120 @@
-describe("GOVUK.GoogleAnalyticsUniversalTracker", function() {
-  function addGoogleAnalyticsSpy() {
-    window.ga = function() {};
-    spyOn(window, 'ga');
+/* global describe it expect beforeEach spyOn jasmine */
+
+var $ = window.jQuery
+
+describe('GOVUK.GoogleAnalyticsUniversalTracker', function () {
+  'use strict'
+  var GOVUK = window.GOVUK
+
+  function addGoogleAnalyticsSpy () {
+    window.ga = function () {}
+    spyOn(window, 'ga')
   }
 
-  var universal;
-  var setupArguments;
+  var universal
+  var setupArguments
 
-  beforeEach(function() {
-    addGoogleAnalyticsSpy();
+  beforeEach(function () {
+    addGoogleAnalyticsSpy()
 
     universal = new GOVUK.GoogleAnalyticsUniversalTracker('id', {
       cookieDomain: 'cookie-domain.com',
       siteSpeedSampleRate: 100
-    });
-  });
-
-  it('can load the libraries needed to run universal Google Analytics', function() {
-    delete window.ga;
-    $('[src="https://www.google-analytics.com/analytics.js"]').remove();
-    GOVUK.GoogleAnalyticsUniversalTracker.load();
-    expect($('script[async][src="https://www.google-analytics.com/analytics.js"]').length).toBe(1);
-    expect(typeof window.ga).toBe('function');
-
-    window.ga('send message');
-    expect(window.ga.q[0]).toEqual(jasmine.any(Object));
-  });
-
-  describe('when created', function() {
-    beforeEach(function() {
-      setupArguments = window.ga.calls.allArgs();
-    });
-
-    it('configures a Google tracker using the provided profile ID and config', function() {
-      expect(setupArguments[0]).toEqual(['create', 'id', {cookieDomain: 'cookie-domain.com', siteSpeedSampleRate: 100}]);
-    });
-
-    it('anonymises the IP', function() {
-      expect(setupArguments[1]).toEqual(['set', 'anonymizeIp', true]);
-    });
-  });
-
-  describe('when created (with legacy non-object syntax)', function() {
-    beforeEach(function() {
-      addGoogleAnalyticsSpy();
-
-      universal = new GOVUK.GoogleAnalyticsUniversalTracker('id', 'cookie-domain.com');
-      setupArguments = window.ga.calls.allArgs();
-    });
-
-    it('configures a Google tracker using the provided profile ID and cookie domain', function() {
-      expect(setupArguments[0]).toEqual(['create', 'id', {cookieDomain: 'cookie-domain.com'}]);
-    });
-  });
-
-  describe('when pageviews are tracked', function() {
-    it('sends them to Google Analytics', function() {
-      universal.trackPageview();
-      expect(window.ga.calls.mostRecent().args).toEqual(['send', 'pageview']);
-    });
-
-    it('can track a virtual pageview', function() {
-      universal.trackPageview('/nicholas-page');
-      expect(window.ga.calls.mostRecent().args).toEqual(['send', 'pageview', {page: '/nicholas-page'}]);
-    });
-
-    it('can track a virtual pageview with a custom title', function() {
-      universal.trackPageview('/nicholas-page', 'Nicholas Page');
-      expect(window.ga.calls.mostRecent().args).toEqual(['send', 'pageview', {page: '/nicholas-page', title: 'Nicholas Page'}]);
-    });
-
-    it('can set the transport method on a pageview', function() {
-      universal.trackPageview('/t', 'T', {transport: 'beacon'});
-      expect(window.ga.calls.mostRecent().args).toEqual(['send', 'pageview', {page: '/t', title: 'T', transport: 'beacon'}]);
-    });
-  });
-
-  describe('when events are tracked', function() {
-    function eventObjectFromSpy() {
-      return window.ga.calls.mostRecent().args[1];
+    })
+  })
+
+  it('can load the libraries needed to run universal Google Analytics', function () {
+    delete window.ga
+    $('[src="https://www.google-analytics.com/analytics.js"]').remove()
+    GOVUK.GoogleAnalyticsUniversalTracker.load()
+    expect($('script[async][src="https://www.google-analytics.com/analytics.js"]').length).toBe(1)
+    expect(typeof window.ga).toBe('function')
+
+    window.ga('send message')
+    expect(window.ga.q[0]).toEqual(jasmine.any(Object))
+  })
+
+  describe('when created', function () {
+    beforeEach(function () {
+      setupArguments = window.ga.calls.allArgs()
+    })
+
+    it('configures a Google tracker using the provided profile ID and config', function () {
+      expect(setupArguments[0]).toEqual(['create', 'id', {cookieDomain: 'cookie-domain.com', siteSpeedSampleRate: 100}])
+    })
+
+    it('anonymises the IP', function () {
+      expect(setupArguments[1]).toEqual(['set', 'anonymizeIp', true])
+    })
+  })
+
+  describe('when created (with legacy non-object syntax)', function () {
+    beforeEach(function () {
+      addGoogleAnalyticsSpy()
+
+      universal = new GOVUK.GoogleAnalyticsUniversalTracker('id', 'cookie-domain.com')
+      setupArguments = window.ga.calls.allArgs()
+    })
+
+    it('configures a Google tracker using the provided profile ID and cookie domain', function () {
+      expect(setupArguments[0]).toEqual(['create', 'id', {cookieDomain: 'cookie-domain.com'}])
+    })
+  })
+
+  describe('when pageviews are tracked', function () {
+    it('sends them to Google Analytics', function () {
+      universal.trackPageview()
+      expect(window.ga.calls.mostRecent().args).toEqual(['send', 'pageview'])
+    })
+
+    it('can track a virtual pageview', function () {
+      universal.trackPageview('/nicholas-page')
+      expect(window.ga.calls.mostRecent().args).toEqual(['send', 'pageview', {page: '/nicholas-page'}])
+    })
+
+    it('can track a virtual pageview with a custom title', function () {
+      universal.trackPageview('/nicholas-page', 'Nicholas Page')
+      expect(window.ga.calls.mostRecent().args).toEqual(['send', 'pageview', {page: '/nicholas-page', title: 'Nicholas Page'}])
+    })
+
+    it('can set the transport method on a pageview', function () {
+      universal.trackPageview('/t', 'T', {transport: 'beacon'})
+      expect(window.ga.calls.mostRecent().args).toEqual(['send', 'pageview', {page: '/t', title: 'T', transport: 'beacon'}])
+    })
+  })
+
+  describe('when events are tracked', function () {
+    function eventObjectFromSpy () {
+      return window.ga.calls.mostRecent().args[1]
     }
 
-    it('sends them to Google Analytics', function() {
-      universal.trackEvent('category', 'action', {label: 'label'});
+    it('sends them to Google Analytics', function () {
+      universal.trackEvent('category', 'action', {label: 'label'})
       expect(window.ga.calls.mostRecent().args).toEqual(
         ['send', {hitType: 'event', eventCategory: 'category', eventAction: 'action', eventLabel: 'label'}]
-      );
-    });
+      )
+    })
 
-    it('the label is optional', function() {
-      universal.trackEvent('category', 'action');
+    it('the label is optional', function () {
+      universal.trackEvent('category', 'action')
       expect(window.ga.calls.mostRecent().args).toEqual(
         ['send', {hitType: 'event', eventCategory: 'category', eventAction: 'action'}]
-      );
-    });
+      )
+    })
 
-    it('only sends values if they are parseable as numbers', function() {
-      universal.trackEvent('category', 'action', {label: 'label', value: '10'});
-      expect(eventObjectFromSpy()['eventValue']).toEqual(10);
+    it('only sends values if they are parseable as numbers', function () {
+      universal.trackEvent('category', 'action', {label: 'label', value: '10'})
+      expect(eventObjectFromSpy()['eventValue']).toEqual(10)
 
-      universal.trackEvent('category', 'action', {label: 'label', value: 10});
-      expect(eventObjectFromSpy()['eventValue']).toEqual(10);
+      universal.trackEvent('category', 'action', {label: 'label', value: 10})
+      expect(eventObjectFromSpy()['eventValue']).toEqual(10)
 
-      universal.trackEvent('category', 'action', {label: 'label', value: 'not a number'});
-      expect(eventObjectFromSpy()['eventValue']).toEqual(undefined);
-    });
+      universal.trackEvent('category', 'action', {label: 'label', value: 'not a number'})
+      expect(eventObjectFromSpy()['eventValue']).toEqual(undefined)
+    })
 
-    it('can mark an event as non interactive', function() {
-      universal.trackEvent('category', 'action', {label: 'label', value: 0, nonInteraction: true});
+    it('can mark an event as non interactive', function () {
+      universal.trackEvent('category', 'action', {label: 'label', value: 0, nonInteraction: true})
       expect(window.ga.calls.mostRecent().args).toEqual(
         ['send', {
           hitType: 'event',
@@ -117,45 +124,45 @@ describe("GOVUK.GoogleAnalyticsUniversalTracker", function() {
           eventValue: 0,
           nonInteraction: 1
         }]
-      );
-    });
+      )
+    })
 
-    it('sends the page if supplied', function() {
-      universal.trackEvent('category', 'action', {page: '/path/to/page'});
+    it('sends the page if supplied', function () {
+      universal.trackEvent('category', 'action', {page: '/path/to/page'})
       expect(window.ga.calls.mostRecent().args).toEqual(
         ['send', {hitType: 'event', eventCategory: 'category', eventAction: 'action', page: '/path/to/page'}]
-      );
-    });
+      )
+    })
 
-    it('can set the transport method on an event', function() {
-      universal.trackEvent('category', 'action', {transport: 'beacon'});
+    it('can set the transport method on an event', function () {
+      universal.trackEvent('category', 'action', {transport: 'beacon'})
       expect(window.ga.calls.mostRecent().args).toEqual(
         ['send', {hitType: 'event', eventCategory: 'category', eventAction: 'action', transport: 'beacon'}]
-      );
-    });
-  });
+      )
+    })
+  })
 
-  describe('when social events are tracked', function() {
-    it('sends them to Google Analytics', function() {
-      universal.trackSocial('network', 'action', 'target');
+  describe('when social events are tracked', function () {
+    it('sends them to Google Analytics', function () {
+      universal.trackSocial('network', 'action', 'target')
       expect(window.ga.calls.mostRecent().args).toEqual(['send', {
         'hitType': 'social',
         'socialNetwork': 'network',
         'socialAction': 'action',
         'socialTarget': 'target'
-      }]);
-    });
-  });
-
-  describe('when setting a custom dimension', function() {
-    it('sends the dimension to Google Analytics with the specified index and value', function() {
-      universal.setDimension(1, 'value');
-      expect(window.ga.calls.mostRecent().args).toEqual(['set', 'dimension1', 'value']);
-    });
-
-    it('coerces the value to a string', function() {
-      universal.setDimension(1, 10);
-      expect(window.ga.calls.mostRecent().args).toEqual(['set', 'dimension1', '10']);
-    });
-  });
-});
+      }])
+    })
+  })
+
+  describe('when setting a custom dimension', function () {
+    it('sends the dimension to Google Analytics with the specified index and value', function () {
+      universal.setDimension(1, 'value')
+      expect(window.ga.calls.mostRecent().args).toEqual(['set', 'dimension1', 'value'])
+    })
+
+    it('coerces the value to a string', function () {
+      universal.setDimension(1, 10)
+      expect(window.ga.calls.mostRecent().args).toEqual(['set', 'dimension1', '10'])
+    })
+  })
+})

data/app/assets/spec/unit/analytics/mailto-link-tracker.spec.js

@@ -1,54 +1,62 @@
-describe("GOVUK.analyticsPlugins.mailtoLinkTracker", function() {
-  var $links;
-
-  beforeEach(function() {
-    $links = $('\
-      <div class="mailto-links">\
-        <a href="mailto:name1@email.com"></a>\
-        <a href="mailto:name2@email.com">The link for a mailto</a>\
-        <a href="mailto:name3@email.com"><img src="/img" /></a>\
-      </div>');
-
-    $('html').on('click', function(evt) { evt.preventDefault(); });
-    $('body').append($links);
-    GOVUK.analytics = {trackEvent:function(){}};
-
-    GOVUK.analyticsPlugins.mailtoLinkTracker();
-  });
-
-  afterEach(function() {
-    $('html').off();
-    $('body').off();
-    $links.remove();
-    delete GOVUK.analytics;
-  });
-
-  it('listens to click events on mailto links', function() {
-    spyOn(GOVUK.analytics, 'trackEvent');
-
-    $('.mailto-links a').each(function() {
-      $(this).trigger('click');
-      expect(GOVUK.analytics.trackEvent).toHaveBeenCalled();
-      GOVUK.analytics.trackEvent.calls.reset();
-    });
-  });
-
-  it('tracks mailto addresses and link text', function() {
-    spyOn(GOVUK.analytics, 'trackEvent');
-    $('.mailto-links a').trigger('click');
+/* global describe it expect afterEach beforeEach spyOn */
+
+var $ = window.jQuery
+
+describe('GOVUK.analyticsPlugins.mailtoLinkTracker', function () {
+  'use strict'
+  var GOVUK = window.GOVUK
+
+  var $links
+
+  beforeEach(function () {
+    $links = $(
+      '<div class="mailto-links">' +
+        '<a href="mailto:name1@email.com"></a>' +
+        '<a href="mailto:name2@email.com">The link for a mailto</a>' +
+        '<a href="mailto:name3@email.com"><img src="/img" /></a>' +
+      '</div>'
+    )
+
+    $('html').on('click', function (evt) { evt.preventDefault() })
+    $('body').append($links)
+    GOVUK.analytics = {trackEvent: function () {}}
+
+    GOVUK.analyticsPlugins.mailtoLinkTracker()
+  })
+
+  afterEach(function () {
+    $('html').off()
+    $('body').off()
+    $links.remove()
+    delete GOVUK.analytics
+  })
+
+  it('listens to click events on mailto links', function () {
+    spyOn(GOVUK.analytics, 'trackEvent')
+
+    $('.mailto-links a').each(function () {
+      $(this).trigger('click')
+      expect(GOVUK.analytics.trackEvent).toHaveBeenCalled()
+      GOVUK.analytics.trackEvent.calls.reset()
+    })
+  })
+
+  it('tracks mailto addresses and link text', function () {
+    spyOn(GOVUK.analytics, 'trackEvent')
+    $('.mailto-links a').trigger('click')
 
     expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
-      'Mailto Link Clicked', 'mailto:name1@email.com', {transport: 'beacon'});
+      'Mailto Link Clicked', 'mailto:name1@email.com', {transport: 'beacon'})
 
     expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
-      'Mailto Link Clicked', 'mailto:name2@email.com', {transport: 'beacon', label: 'The link for a mailto'});
-  });
+      'Mailto Link Clicked', 'mailto:name2@email.com', {transport: 'beacon', label: 'The link for a mailto'})
+  })
 
-  it('listens to click events on elements within mailto links', function() {
-    spyOn(GOVUK.analytics, 'trackEvent');
+  it('listens to click events on elements within mailto links', function () {
+    spyOn(GOVUK.analytics, 'trackEvent')
 
-    $('.mailto-links a img').trigger('click');
+    $('.mailto-links a img').trigger('click')
     expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
-      'Mailto Link Clicked', 'mailto:name3@email.com', {transport: 'beacon'});
-  });
-});
+      'Mailto Link Clicked', 'mailto:name3@email.com', {transport: 'beacon'})
+  })
+})