govspeak 10.6.5 → 10.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b55c7097bba63f4d11e694c6cd683e13dddb4e4e444b61c3035e313c7836b4e5
-  data.tar.gz: 1aa8619222200af1e482598ffc53573cd862ac406369f4e15fbd954d7c85d34a
+  metadata.gz: 4b1efcb5cc3a8435cb52e7eb9a87539a1cf9a8fc3a000adfe75e0321b2f37a98
+  data.tar.gz: 9360c67b0ff42e408f30a7613e9b6388dc2cff57d3e9eef41022ad85daf265ca
 SHA512:
-  metadata.gz: 8c0718694838de516cbb9583e599883422b0605ff150022e670c31fbe9896a376abaa92174053ab49ecff4e3a3c71da49a18a5ef3151eb24868282a4e2acf754
-  data.tar.gz: cb7f5f0b6a29154d4d9d0675ca72fa29d9c30f4b42f989365c33df81e76d0577b9d2d96577c72fdb626a543763c82d16e09ff459b37fd9801062d172f563b9e1
+  metadata.gz: d2e4582880a1156af68977a09bb84a1f6b7846fa13b8b01501ae79f6fc6fbe1a3ca4f9284395801b4fc29899d04b3ebf7b2a12b91b2588e295d6ec60979503fe
+  data.tar.gz: 7a13a22a339c51c3847a43a4468ede4201ddb537bd0edabe8cd8641de025dfaa62e20a3bdfb92827ad9509ea5356950c3434c59d41168510b9a2c22ea95188cf

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 10.7.0
+
+* feature: Add auto-numbered headers option [PR #449](https://github.com/alphagov/govspeak/pull/449)
+* fix: When finding/returning headers, filter links from header titles [PR #439](https://github.com/alphagov/govspeak/pull/439)
+
 ## 10.6.5
 
 * Update dependencies

data/lib/govspeak/header_extractor.rb

@@ -20,11 +20,15 @@ module Govspeak
   private
 
     def id(element)
-      element.attr.fetch("id", generate_id(element.options[:raw_text]))
+      element.attr.fetch("id", generate_id(text_with_links(element)))
     end
 
     def build_header(element)
-      Header.new(element.options[:raw_text], element.options[:level], id(element))
+      Header.new(text_with_links(element), element.options[:level], id(element))
+    end
+
+    def text_with_links(element)
+      element.options[:raw_text].gsub(/\[(.+)\]\((.*)\)/, '\1')
     end
 
     def find_headers(parent)

data/lib/govspeak/post_processor.rb

@@ -160,6 +160,42 @@ module Govspeak
       end
     end
 
+    extension("use auto-numbered headers") do |document|
+      if govspeak_document.auto_numbered_headers
+        h2, h3, h4, h5, h6 = 0, 0, 0, 0, 0, 0
+
+        document.css("h2,h3,h4,h5,h6").map do |el|
+          case el.name
+          when "h2"
+            h2 += 1
+            h3 = 0
+            h4 = 0
+            h5 = 0
+            h6 = 0
+            el.inner_html = "#{h2}. #{el.inner_html}"
+          when "h3"
+            h3 += 1
+            h4 = 0
+            h5 = 0
+            h6 = 0
+            el.inner_html = "#{h2}.#{h3} #{el.inner_html}"
+          when "h4"
+            h4 += 1
+            h5 = 0
+            h6 = 0
+            el.inner_html = "#{h2}.#{h3}.#{h4} #{el.inner_html}"
+          when "h5"
+            h5 += 1
+            h6 = 0
+            el.inner_html = "#{h2}.#{h3}.#{h4}.#{h5} #{el.inner_html}"
+          when "h6"
+            h6 += 1
+            el.inner_html = "#{h2}.#{h3}.#{h4}.#{h5}.#{h6} #{el.inner_html}"
+          end
+        end
+      end
+    end
+
     attr_reader :input, :govspeak_document
 
     def initialize(html, govspeak_document)

data/lib/govspeak/structured_header_extractor.rb

@@ -41,6 +41,8 @@ module Govspeak
         stack.push(header)
       end
 
+      add_auto_numbering(structured_headers) if doc.auto_numbered_headers
+
       structured_headers
     end
 
@@ -96,6 +98,13 @@ module Govspeak
       @stack = []
     end
 
+    def add_auto_numbering(structured_headers, prefix: "")
+      structured_headers.each.with_index(1) do |header, index|
+        header[:text] = "#{prefix}#{index}#{'.' if prefix == ''} #{header[:text]}"
+        add_auto_numbering(header[:headers], prefix: "#{prefix}#{index}.")
+      end
+    end
+
   private
 
     attr_reader :doc, :stack, :structured_headers

data/lib/govspeak/version.rb

@@ -1,3 +1,3 @@
 module Govspeak
-  VERSION = "10.6.5".freeze
+  VERSION = "10.7.0".freeze
 end

data/lib/govspeak.rb

@@ -38,7 +38,7 @@ module Govspeak
     @extensions = []
 
     attr_accessor :images
-    attr_reader :attachments, :contacts, :links, :locale, :log_snapshots
+    attr_reader :attachments, :auto_numbered_headers, :contacts, :links, :locale, :log_snapshots
 
     def self.to_html(source, options = {})
       new(source, options).to_html
@@ -60,6 +60,7 @@ module Govspeak
       @allowed_elements = options.delete(:allowed_elements) || []
       @allowed_image_hosts = options.delete(:allowed_image_hosts) || []
       @attachments = Array.wrap(options.delete(:attachments))
+      @auto_numbered_headers = options.fetch(:auto_numbered_headers, false)
       @links = Array.wrap(options.delete(:links))
       @contacts = Array.wrap(options.delete(:contacts))
       @locale = options.fetch(:locale, "en")

data/test/govspeak_structured_headers_test.rb

@@ -21,14 +21,16 @@ class GovspeakStructuredHeadersTest < Minitest::Test
 
 ### Sub heading 4.1
 
-#### Sub heading 4.1.1
+#### Sub sub heading 4.1.1
 
-##### Sub heading 4.1.1.1
+##### Sub sub sub heading 4.1.1.1
 
 ### Sub heading 4.2
 
 ## Heading 5
 
+### [Sub heading 5.1](https://www.example.com)
+
     )
   end
 
@@ -67,6 +69,11 @@ class GovspeakStructuredHeadersTest < Minitest::Test
     assert_equal "Sub heading 4.2", structured_headers[3].headers[1].text
   end
 
+  test "headers that are links are based on the link text not the link" do
+    assert_equal "Sub heading 5.1", structured_headers[4].headers[0].text
+    assert_equal "sub-heading-51", structured_headers[4].headers[0].id
+  end
+
   test "structured headers serialize to hashes recursively serializing sub headers" do
     serialized_headers = structured_headers[1].to_h
 
@@ -138,4 +145,25 @@ class GovspeakStructuredHeadersTest < Minitest::Test
   test "document with single h1 produces no headers" do
     assert_equal [], Govspeak::Document.new("# Heading\n").structured_headers
   end
+
+  test "auto-numbered headers are generated when the option is set on the document" do
+    doc = Govspeak::Document.new(document_body, auto_numbered_headers: true)
+
+    headers = doc.structured_headers
+
+    assert_equal "1. Heading 1", headers[0][:text]
+    assert_equal "2. Heading 2", headers[1][:text]
+    assert_equal "2.1 Sub heading 2.1", headers[1][:headers][0][:text]
+    assert_equal "2.2 Sub heading 2.2", headers[1][:headers][1][:text]
+    assert_equal "2.2.1 Sub sub heading 2.2.1", headers[1][:headers][1][:headers][0][:text]
+    assert_equal "2.3 Sub heading 2.3", headers[1][:headers][2][:text]
+    assert_equal "3. Heading 3", headers[2][:text]
+    assert_equal "4. Heading 4", headers[3][:text]
+    assert_equal "4.1 Sub heading 4.1", headers[3][:headers][0][:text]
+    assert_equal "4.1.1 Sub sub heading 4.1.1", headers[3][:headers][0][:headers][0][:text]
+    assert_equal "4.1.1.1 Sub sub sub heading 4.1.1.1", headers[3][:headers][0][:headers][0][:headers][0][:text]
+    assert_equal "4.2 Sub heading 4.2", headers[3][:headers][1][:text]
+    assert_equal "5. Heading 5", headers[4][:text]
+    assert_equal "5.1 Sub heading 5.1", headers[4][:headers][0][:text]
+  end
 end

data/test/govspeak_test.rb

@@ -99,6 +99,28 @@ class GovspeakTest < Minitest::Test
     assert_equal "foo bar baz", doc.to_text
   end
 
+  test "adds auto-numbered headings when the auto_numbered_headings option is on" do
+    input = %(
+## H2 One
+
+### H3 One
+
+### H3 Two
+
+## H2 Two
+
+### H3 Three
+
+#### H4 One
+
+##### H5 One
+
+###### H6 One
+)
+    doc = Govspeak::Document.new(input, auto_numbered_headers: true)
+    assert_equal %(\n<h2 id="h2-one">1. H2 One</h2>\n\n<h3 id="h3-one">1.1 H3 One</h3>\n\n<h3 id="h3-two">1.2 H3 Two</h3>\n\n<h2 id="h2-two">2. H2 Two</h2>\n\n<h3 id="h3-three">2.1 H3 Three</h3>\n\n<h4 id="h4-one">2.1.1 H4 One</h4>\n\n<h5 id="h5-one">2.1.1.1 H5 One</h5>\n\n<h6 id="h6-one">2.1.1.1.1 H6 One</h6>\n), doc.to_html
+  end
+
   test "trailing space after the address should not prevent parsing" do
     input = %($A
 123 Test Street

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govspeak
 version: !ruby/object:Gem::Version
-  version: 10.6.5
+  version: 10.7.0
 platform: ruby
 authors:
 - GOV.UK Dev
@@ -18,7 +18,7 @@ dependencies:
         version: '6'
     - - "<"
       - !ruby/object:Gem::Version
-        version: 8.0.4
+        version: 8.1.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -28,7 +28,7 @@ dependencies:
         version: '6'
     - - "<"
       - !ruby/object:Gem::Version
-        version: 8.0.4
+        version: 8.1.2
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement