google-finance-ruby-client 0.1.0 → 0.2.0

data/spec/fixtures/google-finance/get_prices_invalid.yml

@@ -0,0 +1,60 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://finance.google.com/finance/getprices?q=INVALID
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.13.1
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - text/plain; charset=ISO-8859-1
+      Cache-Control:
+      - private,max-age=60
+      Vary:
+      - Accept-Encoding
+      X-Content-Type-Options:
+      - nosniff
+      P3p:
+      - CP="This is not a P3P policy! See g.co/p3phelp for more info."
+      Date:
+      - Thu, 28 Dec 2017 19:06:05 GMT
+      X-Frame-Options:
+      - SAMEORIGIN
+      X-Xss-Protection:
+      - 1; mode=block
+      Server:
+      - GSE
+      Set-Cookie:
+      - NID=120=NQ2JSPX88dHGwyNpeclQrvh65rb71_CXKqoa-gwNVXleRJ-vorthDIB9vFZR0Xe1pd6HnVKDKY2dTl4xD49VJnC4zue3JOTiA4jPUp8FEMwXrseIigk0qrbg2EbGzEiZ;Domain=.google.com;Path=/;Expires=Fri,
+        29-Jun-2018 19:06:05 GMT;HttpOnly
+      Alt-Svc:
+      - hq=":443"; ma=2592000; quic=51303431; quic=51303339; quic=51303338; quic=51303337;
+        quic=51303335,quic=":443"; ma=2592000; v="41,39,38,37,35"
+      Expires:
+      - Thu, 28 Dec 2017 19:06:05 GMT
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: ASCII-8BIT
+      string: |
+        EXCHANGE%3DUNKNOWN+EXCHANGE
+        MARKET_OPEN_MINUTE=570
+        MARKET_CLOSE_MINUTE=960
+        INTERVAL=86400
+        COLUMNS=DATE,CLOSE,HIGH,LOW,OPEN,VOLUME
+        DATA=
+    http_version: 
+  recorded_at: Thu, 28 Dec 2017 19:06:05 GMT
+recorded_with: VCR 3.0.3

data/spec/fixtures/google-finance/get_prices_msft.yml

@@ -0,0 +1,82 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://finance.google.com/finance/getprices?q=MSFT
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.13.1
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - text/plain; charset=ISO-8859-1
+      Cache-Control:
+      - private,max-age=60
+      Vary:
+      - Accept-Encoding
+      X-Content-Type-Options:
+      - nosniff
+      P3p:
+      - CP="This is not a P3P policy! See g.co/p3phelp for more info."
+      Date:
+      - Thu, 28 Dec 2017 17:36:02 GMT
+      X-Frame-Options:
+      - SAMEORIGIN
+      X-Xss-Protection:
+      - 1; mode=block
+      Server:
+      - GSE
+      Set-Cookie:
+      - NID=120=rQwDiRAJ6enXL1rj3-FNIB1RCMkB-Ed3cKNKyBqoscW2M_0MfHmwtDaiOjCj3Rn8Fj0-V6uzybRtIA8XkUCgM0RWGi2x1jetNMWvw4xopJaGjvoKs1ZI6V1ZwLM-DAGv;Domain=.google.com;Path=/;Expires=Fri,
+        29-Jun-2018 17:36:02 GMT;HttpOnly
+      Alt-Svc:
+      - hq=":443"; ma=2592000; quic=51303431; quic=51303339; quic=51303338; quic=51303337;
+        quic=51303335,quic=":443"; ma=2592000; v="41,39,38,37,35"
+      Expires:
+      - Thu, 28 Dec 2017 17:36:02 GMT
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: ASCII-8BIT
+      string: |
+        EXCHANGE%3DNASDAQ
+        MARKET_OPEN_MINUTE=570
+        MARKET_CLOSE_MINUTE=960
+        INTERVAL=86400
+        COLUMNS=DATE,CLOSE,HIGH,LOW,OPEN,VOLUME
+        DATA=
+        TIMEZONE_OFFSET=-300
+        a1511902800,84.88,85.06,84.02,84.07,21925959
+        1,83.34,84.9172,83.175,84.71,27381109
+        2,84.17,84.52,83.34,83.51,33054647
+        3,84.26,84.81,83.22,83.6,29532132
+        6,81.08,84.4299,80.7,84.42,39094880
+        7,81.59,82.68,80.9801,81.34,26152261
+        8,82.78,83.14,81.43,81.55,26162054
+        9,82.49,82.8,82,82.54,23184547
+        10,84.16,84.58,83.33,83.63,24489106
+        13,85.23,85.37,84.12,84.29,22857854
+        14,85.58,86.05,85.08,85.31,23924105
+        15,85.35,86,85.17,85.74,22062679
+        16,84.69,85.8739,84.53,85.43,19305961
+        17,86.85,87.09,84.88,85.26,53936687
+        20,86.38,87.4999,86.23,87.12,22283752
+        21,85.83,86.35,85.27,86.35,23524787
+        22,85.52,86.3,84.71,86.2,23674931
+        23,85.5,86.1,85.4,86.05,17990745
+        24,85.51,85.63,84.92,85.4,14145841
+        28,85.4,85.5346,85.03,85.31,9891237
+        29,85.71,85.98,85.215,85.65,14678025
+    http_version: 
+  recorded_at: Thu, 28 Dec 2017 17:36:02 GMT
+recorded_with: VCR 3.0.3

data/spec/google-finance/prices_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+
+describe GoogleFinance::Prices do
+  context 'known symbol', vcr: { cassette_name: 'get_prices_msft' } do
+    subject do
+      GoogleFinance::Prices.get('MSFT')
+    end
+    it 'retrieves price history' do
+      expect(subject.exchange).to eq 'NASDAQ'
+      expect(subject.market_open_minute).to eq 570
+      expect(subject.market_close_minute).to eq 960
+      expect(subject.interval).to eq 86_400
+      expect(subject.columns).to eq(%w[date close high low open volume])
+      expect(subject.count).to eq 21
+    end
+    context 'row' do
+      let(:price) { subject.first }
+      it 'includes a price' do
+        expect(price).to be_a GoogleFinance::Price
+        expect(price.timezone_offset).to eq -300
+        expect(price.close).to eq 84.88
+        expect(price.high).to eq 85.06
+        expect(price.low).to eq 84.02
+        expect(price.open).to eq 84.07
+        expect(price.volume).to eq 21_925_959
+        expect(price.date).to eq Time.parse('2017-11-28 16:00 -0500')
+      end
+    end
+  end
+  context 'with custom fields', vcr: { cassette_name: 'get_prices_goog_with_options' } do
+    subject do
+      GoogleFinance::Prices.get('GOOG', i: 60 * 60, p: '1Y', f: 'd,c,v,k,o,h,l', df: 'cpct', auto: 0)
+    end
+    it 'retrieves price history' do
+      expect(subject.exchange).to eq 'NASDAQ'
+      expect(subject.interval).to eq 3600
+      expect(subject.columns).to eq(%w[date close high low open volume cdays])
+      expect(subject.count).to eq 1755
+    end
+    it 'knows timezone_offset' do
+      expect(subject.first.timezone_offset).to eq -300
+      expect(subject[1024].timezone_offset).to eq -240
+      expect(subject.last.timezone_offset).to eq -300
+    end
+  end
+  context 'with custom named fields', vcr: { cassette_name: 'get_prices_goog_with_options' } do
+    subject do
+      GoogleFinance::Prices.get('GOOG', interval: 60 * 60, period: '1Y', fields: %i[date close volume k open high low], df: 'cpct', auto: 0)
+    end
+    it 'retrieves price history' do
+      expect(subject.exchange).to eq 'NASDAQ'
+      expect(subject.interval).to eq 3600
+      expect(subject.columns).to eq(%w[date close high low open volume cdays])
+      expect(subject.count).to eq 1755
+    end
+    it 'knows timezone_offset' do
+      expect(subject.first.timezone_offset).to eq -300
+      expect(subject[1024].timezone_offset).to eq -240
+      expect(subject.last.timezone_offset).to eq -300
+    end
+  end
+  context 'with few fields', vcr: { cassette_name: 'get_prices_goog_with_few_fields' } do
+    subject do
+      GoogleFinance::Prices.get('GOOG', fields: %i[date close])
+    end
+    it 'retrieves price history' do
+      expect(subject.exchange).to eq 'NASDAQ'
+      expect(subject.columns).to eq(%w[date close])
+      expect(subject.count).to eq 21
+    end
+    it 'retrieves some fields' do
+      price = subject.first
+      expect(price.close).to eq 1047.41
+      expect(price.date).to eq Time.parse('2017-11-28 16:00:00 -0500')
+      expect(price.timezone_offset).to eq -300
+      expect(price.high).to be nil
+    end
+  end
+  context 'unknown symbol', vcr: { cassette_name: 'get_prices_invalid' } do
+    subject do
+      GoogleFinance::Prices.get('INVALID')
+    end
+    it 'fails with SymbolNotFoundError' do
+      expect { subject }.to raise_error GoogleFinance::Errors::SymbolNotFoundError, 'Symbol INVALID Not Found'
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google-finance-ruby-client
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Daniel Doubrovkine
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-03 00:00:00.000000000 Z
+date: 2017-12-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -143,21 +143,30 @@ files:
 - google-finance-ruby-client.gemspec
 - google-finance.png
 - lib/google-finance-ruby-client.rb
+- lib/google-finance/api.rb
+- lib/google-finance/api/get_prices.rb
+- lib/google-finance/api/index.rb
 - lib/google-finance/errors.rb
 - lib/google-finance/errors/symbol_not_found_error.rb
 - lib/google-finance/errors/symbols_not_found_error.rb
 - lib/google-finance/faraday_middleware/preprocessor.rb
+- lib/google-finance/price.rb
+- lib/google-finance/prices.rb
 - lib/google-finance/quote.rb
 - lib/google-finance/quotes.rb
 - lib/google-finance/resource.rb
-- lib/google-finance/resources.rb
 - lib/google-finance/version.rb
+- spec/fixtures/google-finance/get_prices_goog_with_few_fields.yml
+- spec/fixtures/google-finance/get_prices_goog_with_options.yml
+- spec/fixtures/google-finance/get_prices_invalid.yml
+- spec/fixtures/google-finance/get_prices_msft.yml
 - spec/fixtures/google-finance/invalid.yml
 - spec/fixtures/google-finance/msft.yml
 - spec/fixtures/google-finance/msft_ab.yml
 - spec/fixtures/google-finance/msft_ab_invalid.yml
 - spec/fixtures/google-finance/search_invalid.yml
 - spec/fixtures/google-finance/search_msft.yml
+- spec/google-finance/prices_spec.rb
 - spec/google-finance/quote_spec.rb
 - spec/google-finance/quotes_spec.rb
 - spec/google-finance/version_spec.rb
@@ -188,12 +197,17 @@ signing_key:
 specification_version: 4
 summary: Google Finance web API ruby client.
 test_files:
+- spec/fixtures/google-finance/get_prices_goog_with_few_fields.yml
+- spec/fixtures/google-finance/get_prices_goog_with_options.yml
+- spec/fixtures/google-finance/get_prices_invalid.yml
+- spec/fixtures/google-finance/get_prices_msft.yml
 - spec/fixtures/google-finance/invalid.yml
 - spec/fixtures/google-finance/msft.yml
 - spec/fixtures/google-finance/msft_ab.yml
 - spec/fixtures/google-finance/msft_ab_invalid.yml
 - spec/fixtures/google-finance/search_invalid.yml
 - spec/fixtures/google-finance/search_msft.yml
+- spec/google-finance/prices_spec.rb
 - spec/google-finance/quote_spec.rb
 - spec/google-finance/quotes_spec.rb
 - spec/google-finance/version_spec.rb

data/lib/google-finance/resources.rb

@@ -1,28 +0,0 @@
-module GoogleFinance
-  module Resources
-    def self.fetch(params = {})
-      get(params)
-    end
-
-    def self.get(params)
-      connection.get do |c|
-        c.params[:output] = :json
-        c.params.merge!(params)
-      end.body
-    end
-
-    def self.connection
-      Faraday.new(
-        url: 'https://finance.google.com/finance',
-        request: {
-          params_encoder: Faraday::FlatParamsEncoder
-        }
-      ) do |c|
-        c.use ::FaradayMiddleware::ParseJson
-        c.use GoogleFinance::FaradayMiddleware::Preprocessor
-        c.use Faraday::Response::RaiseError
-        c.use Faraday::Adapter::NetHttp
-      end
-    end
-  end
-end