gooddata 0.6.53 → 0.6.54

data/spec/{unit → integration}/models/domain_spec.rb

@@ -144,7 +144,7 @@ describe GoodData::Domain do
   describe '#clients' do
     subject { GoodData::Domain.new('my_domain') }
     let(:client) { double('client') }
-    let(:clients_response) { { 'client' => { 'id' => '123' } } }
+    let(:clients_response) { { 'client' => { 'id' => '123' }, 'domain' => subject } }
 
     before do
       allow(client).to receive(:get).and_return(clients_response)
@@ -156,7 +156,7 @@ describe GoodData::Domain do
         GoodData::Client,
         clients_response
       )
-      subject.clients(123)
+      subject.clients('123')
     end
   end
 end

data/spec/integration/models/project_spec.rb

@@ -0,0 +1,225 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require 'gooddata'
+
+describe GoodData::Project, :constraint => 'slow' do
+  before(:all) do
+    @client = ConnectionHelper.create_default_connection
+    @project = ProjectHelper.get_default_project(:client => @client)
+    @domain = @client.domain(ConnectionHelper::DEFAULT_DOMAIN)
+  end
+
+  after(:all) do
+    @client.disconnect
+  end
+
+  describe 'projects' do
+    it 'Can get all projects' do
+      projects = @client.projects
+      expect(projects).to_not be_nil
+      expect(projects).to be_a_kind_of(Array)
+      projects.pmap do |project|
+        expect(project).to be_an_instance_of(GoodData::Project)
+      end
+    end
+
+    it 'Returns project if ID passed' do
+      expect(@project).to_not be_nil
+      expect(@project).to be_a_kind_of(GoodData::Project)
+      expect(@project.pid).to eq @project.pid
+    end
+
+    it 'Returns project if URL passed' do
+      expect(@project).to_not be_nil
+      expect(@project).to be_a_kind_of(GoodData::Project)
+      expect(@project.pid).to eq @project.pid
+    end
+
+    it 'Throws an exception when invalid format of URL passed' do
+      invalid_url = '/gdc/invalid_url'
+      expect { GoodData::Project[invalid_url] }.to raise_error
+    end
+  end
+
+  describe '#all' do
+    it 'Returns all projects' do
+      projects = GoodData::Project.all(:client => @client)
+      expect(projects).to_not be_nil
+      expect(projects).to be_a_kind_of(Array)
+    end
+  end
+
+  describe '#get_role_by_identifier' do
+    it 'Looks up for role by identifier' do
+      role = @project.get_role_by_identifier('readOnlyUserRole')
+      expect(role).to_not be_nil
+      expect(role).to be_a_kind_of(GoodData::ProjectRole)
+    end
+  end
+
+  describe '#get_role_by_summary' do
+    it 'Looks up for role by summary' do
+      role = @project.get_role_by_summary('read only user role')
+      expect(role).to_not be_nil
+      expect(role).to be_a_kind_of(GoodData::ProjectRole)
+    end
+  end
+
+  describe '#get_role_by_title' do
+    it 'Looks up for role by title' do
+      role = @project.get_role_by_title('Viewer')
+      expect(role).to_not be_nil
+      expect(role).to be_a_kind_of(GoodData::ProjectRole)
+    end
+  end
+
+  describe "#member" do
+    it 'Returns GoodData::Membership when looking for existing user using login' do
+      res = @project.get_user(ConnectionHelper::DEFAULT_USERNAME)
+      expect(res).to be_instance_of(GoodData::Membership)
+    end
+
+    it 'Returns GoodData::Membership when looking for existing user using URL' do
+      res = @project.get_user(ConnectionHelper::DEFAULT_USER_URL)
+      expect(res).to be_instance_of(GoodData::Membership)
+    end
+
+    it 'Returns GoodData::Membership when looking for existing user using GoodData::Profile' do
+      user = @project.members.first
+      res = @project.get_user(user)
+      expect(res).to be_instance_of(GoodData::Membership)
+    end
+
+    it 'Returns null for non-existing user' do
+      res = @project.get_user(ConnectionHelper::TEST_USERNAME)
+      expect(res).to be_nil
+    end
+  end
+
+  describe "#member?" do
+    it 'Returns true when looking for existing user using login' do
+      res = @project.member?(ConnectionHelper::DEFAULT_USERNAME)
+      expect(res).to be_truthy
+    end
+
+    it 'Returns true when looking for existing user using URL' do
+      res = @project.member?(ConnectionHelper::DEFAULT_USER_URL)
+      expect(res).to be_truthy
+    end
+
+    it 'Returns true when looking for existing user using GoodData::Profile' do
+      user = @project.members.first
+      res = @project.member?(user)
+      expect(res).to be_truthy
+    end
+
+    it 'Returns false for non-existing user' do
+      res = @project.member?(ConnectionHelper::TEST_USERNAME)
+      expect(res).to be_falsey
+    end
+
+    it 'Returns true for existing user when using optional list' do
+      list = @project.members
+      res = @project.member?(ConnectionHelper::DEFAULT_USERNAME, list)
+      expect(res).to be_truthy
+    end
+
+    it 'Returns false for non-existing user when using optional list' do
+      list = []
+      res = @project.member?(ConnectionHelper::DEFAULT_USERNAME, list)
+      expect(res).to be_falsey
+    end
+  end
+
+  describe '#members?' do
+    it 'Returns array of bools when looking for existing users using GoodData::Profile' do
+      users = @project.members.take(10)
+      res = @project.members?(users)
+      expect(res.all?).to be_truthy
+    end
+
+    it 'Support variety of inputs' do
+      users = @project.members.take(1)
+      res = @project.members?(users + [ConnectionHelper::TEST_USERNAME])
+      expect(res).to eq [true, false]
+    end
+  end
+
+  describe '#roles' do
+    it 'Returns array of GoodData::ProjectRole' do
+      roles = @project.roles
+      expect(roles).to be_instance_of(Array)
+
+      roles.each do |role|
+        expect(role).to be_instance_of(GoodData::ProjectRole)
+      end
+    end
+  end
+
+  describe '#export_clone' do
+    context 'when exclude_schedule is true' do
+      let(:options) { { exclude_schedules: true } }
+      let(:clone) { GoodData::Project.create(title: 'project clone', client: @client, auth_token: ConnectionHelper::GD_PROJECT_TOKEN) }
+
+      after do
+        clone.delete if clone
+      end
+
+      it 'excludes scheduled emails' do
+        @project.schedule_mail.save
+        export_token = @project.export_clone(options)
+        clone.import_clone(export_token)
+        expect(@project.scheduled_mails.to_a).not_to be_empty
+        expect(clone.scheduled_mails.to_a).to be_empty
+      end
+    end
+
+    context 'when cross_data_center_export is true' do
+      it 'is ok' do
+        # there are no staging environments on other datacenters
+        # so just checking if the parameter gets accepted
+        @project.export_clone(cross_data_center_export: true)
+      end
+    end
+
+    context 'when export task fails' do
+      let(:fail_response) do
+        response = { taskState: { status: 'ERROR' } }
+        GoodData::Helpers.stringify_keys(response)
+      end
+
+      before do
+        allow(@client)
+          .to receive(:poll_on_response).and_return(fail_response)
+      end
+
+      it 'raises ExportCloneError' do
+        expect { @project.export_clone }.to raise_error(GoodData::ExportCloneError)
+      end
+    end
+  end
+
+  describe '#import_clone' do
+    let(:clone) { GoodData::Project.create(title: 'import clone test', client: @client, auth_token: ConnectionHelper::GD_PROJECT_TOKEN) }
+    let(:fail_response) do
+      response = { taskState: { status: 'ERROR' } }
+      GoodData::Helpers.stringify_keys(response)
+    end
+
+    after do
+      clone.delete if clone
+    end
+
+    context 'when import task fails' do
+      it 'raises ImportCloneError' do
+        export_token = @project.export_clone
+        allow(@client).to receive(:poll_on_response).and_return(fail_response)
+        expect { clone.import_clone(export_token) }.to raise_error(GoodData::ImportCloneError)
+      end
+    end
+  end
+end

data/spec/integration/project_spec.rb

@@ -325,22 +325,57 @@ describe GoodData::Project, :constraint => 'slow' do
     end
 
     it 'should be able to set custom color' do
-      colors = [{ r: 155, g: 255, b: 0 }]
+      colors = [
+        {
+          guid: 'first',
+          fill: {
+            r: 155,
+            g: 255,
+            b: 0
+          }
+        }
+      ]
       @project.create_custom_color_palette(colors)
-      expect(@project.current_color_palette.colors).to eq colors
+      expect(@project.current_color_palette.colors).to eq colors.map { |color| GoodData::Helpers.stringify_keys(color) }
     end
 
     it 'should be able to reset custom color' do
-      colors = [{ r: 155, g: 255, b: 0 }]
+      colors = [
+        {
+          guid: 'first',
+          fill: {
+            r: 155,
+            g: 255,
+            b: 0
+          }
+        }
+      ]
       @project.create_custom_color_palette(colors)
       @project.reset_color_palette
       expect(@project.current_color_palette.colors).to eq []
     end
 
     it 'should not contains duplicate color' do
-      colors = [{ r: 155, g: 255, b: 0 }, { r: 155, g: 255, b: 0 }]
+      colors = [
+        {
+          guid: 'first',
+          fill: {
+            r: 155,
+            g: 255,
+            b: 0
+          }
+        },
+        {
+          guid: 'first',
+          fill: {
+            r: 155,
+            g: 255,
+            b: 0
+          }
+        }
+      ]
       @project.create_custom_color_palette(colors)
-      expect(@project.current_color_palette.colors).to eq [{ r: 155, g: 255, b: 0 }]
+      expect(@project.current_color_palette.colors).to eq [{ "guid" => "first", "fill" => { "r" => 155, "g" => 255, "b" => 0 } }]
     end
   end
 end

data/spec/integration/segments_spec.rb

@@ -11,13 +11,6 @@ describe GoodData::Segment do
   before(:all) do
     @client = ConnectionHelper.create_default_connection
     @domain = @client.domain(ConnectionHelper::DEFAULT_DOMAIN)
-    GoodData::Segment.all(domain: @domain).each do |segment|
-      begin
-        segment.delete(force: true)
-      rescue StandardError => e
-        GoodData.logger.warn "Failed to delete segment: #{e}"
-      end
-    end
   end
 
   before(:each) do
@@ -62,17 +55,18 @@ describe GoodData::Segment do
   end
 
   describe '#save' do
+    after do
+      @different_master.delete if @different_master
+      @different_data_product.delete if @different_data_product
+    end
+
     it 'can update a segment master project' do
-      begin
-        different_master = @client.create_project(title: 'Test project', auth_token: ConnectionHelper::GD_PROJECT_TOKEN)
-        @segment.master_project = different_master
-        @segment.save
-        @segment = @domain.segments(@segment_name)
-        expect(@segment.master_project_uri).not_to eq @master_project.uri
-        expect(@segment.master_project_uri).to eq different_master.uri
-      ensure
-        different_master.delete if different_master
-      end
+      @different_master = @client.create_project(title: 'Test project', auth_token: ConnectionHelper::GD_PROJECT_TOKEN)
+      @segment.master_project = @different_master
+      @segment.save
+      @segment = @domain.segments(@segment_name)
+      expect(@segment.master_project_uri).not_to eq @master_project.uri
+      expect(@segment.master_project_uri).to eq @different_master.uri
     end
 
     it 'cannot update a segment id' do
@@ -84,16 +78,23 @@ describe GoodData::Segment do
   end
 
   describe '#create_client' do
+    after do
+      @client_project && @client_project.delete
+      @segment_client && @segment_client.delete
+    end
+
     it 'can create a new client in a segment' do
-      begin
-        client_project = @client.create_project(title: 'client_1 project', auth_token: ConnectionHelper::GD_PROJECT_TOKEN)
-        segment_client = @segment.create_client(id: 'tenant_1', project: client_project)
-        expect(segment_client).to be_an_instance_of(GoodData::Client)
-        expect(@segment.clients.count).to eq 1
-      ensure
-        client_project.delete if client_project
-        segment_client && segment_client.delete
-      end
+      @client_project = @client.create_project(title: 'client_1 project', auth_token: ConnectionHelper::GD_PROJECT_TOKEN)
+      @segment_client = @segment.create_client(id: 'tenant_1', project: @client_project)
+      expect(@segment_client).to be_an_instance_of(GoodData::Client)
+      expect(@segment.clients.count).to eq 1
+    end
+  end
+
+  describe '#provision_client_projects' do
+    it 'returns an enumerable result' do
+      result = @segment.provision_client_projects
+      expect(result).to be_an_instance_of(Enumerator)
     end
   end
 end

data/spec/integration/user_filters_spec.rb

@@ -259,7 +259,7 @@ describe "User filters implementation", :constraint => 'slow' do
 
     # we want to compute stuff on different user than we are setting it on
     u = @domain.users.find { |user| user.login != ConnectionHelper::DEFAULT_USERNAME }
-    password = 'abcd1234'
+    password = 'si@gFG593fo'
     u.json['accountSetting']['password'] = password
     @domain.update_user(u)
     @project.add_user(u, 'admin')

data/spec/spec_helper.rb

@@ -5,6 +5,21 @@
 # LICENSE file in the root directory of this source tree.
 
 require 'simplecov'
+# for simplecov to work correctly, it has to be started before any other code
+SimpleCov.start do
+  add_filter 'spec/'
+
+  add_group 'Middleware', 'lib/gooddata/bricks/middleware'
+  add_group 'CLI', 'lib/gooddata/cli'
+  add_group 'Commands', 'lib/gooddata/commands'
+  add_group 'Core', 'lib/gooddata/core'
+  add_group 'Exceptions', 'lib/gooddata/exceptions'
+  add_group 'Extensions', 'lib/gooddata/extensions'
+  add_group 'Goodzilla', 'lib/gooddata/goodzilla'
+  add_group 'Models', 'lib/gooddata/models'
+  add_group 'LCM', 'lib/gooddata/lcm'
+end
+
 require 'pmap'
 require 'rspec'
 require 'pathname'
@@ -49,22 +64,3 @@ RSpec.configure do |config|
 
   config.fail_fast = false
 end
-
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
-  SimpleCov::Formatter::HTMLFormatter
-)
-
-SimpleCov.start do
-  add_filter 'spec/'
-  add_filter 'test/'
-
-  add_group 'Bricks', 'lib/gooddata/bricks'
-  add_group 'Middleware', 'lib/gooddata/bricks/middleware'
-  add_group 'CLI', 'lib/gooddata/cli'
-  add_group 'Commands', 'lib/gooddata/commands'
-  add_group 'Core', 'lib/gooddata/core'
-  add_group 'Exceptions', 'lib/gooddata/exceptions'
-  add_group 'Extensions', 'lib/gooddata/extensions'
-  add_group 'Goodzilla', 'lib/gooddata/goodzilla'
-  add_group 'Models', 'lib/gooddata/models'
-end