gooddata 0.6.53 → 0.6.54

data/lib/gooddata/models/style_setting.rb

@@ -35,14 +35,7 @@ module GoodData
         end
         uri = STYLE_SETTING_PATH % project.pid
         data_to_send = GoodData::Helpers.deep_dup(EMPTY_OBJECT).tap do |d|
-          d['styleSettings']['chartPalette'] = colors
-                                                .each_with_index
-                                                .map do |color, index|
-                                                  {
-                                                    'guid' => "guid#{index + 1}",
-                                                    'fill' => GoodData::Helpers.stringify_keys(color)
-                                                  }
-                                                end
+          d['styleSettings']['chartPalette'] = colors.map { |color| GoodData::Helpers.stringify_keys(color) }
         end
         style = client.create(StyleSetting, data_to_send)
         client.put(uri, data_to_send)
@@ -59,13 +52,7 @@ module GoodData
     def initialize(json)
       super
       @json = json
-      @colors = (json ? data['chartPalette'] : []).map do |color|
-        {
-          r: color['fill']['r'],
-          g: color['fill']['g'],
-          b: color['fill']['b']
-        }
-      end
+      @colors = json ? data['chartPalette'] : []
     end
 
     def empty?

data/lib/gooddata/models/user_group.rb

@@ -67,6 +67,8 @@ module GoodData
           d['userGroup']['content']['project'] = data[:project].uri
         end
 
+        client = data[:project].client
+
         group = client.create(GoodData::UserGroup, GoodData::Helpers.stringify_keys(new_data))
         group.project = data[:project]
         group

data/lib/gooddata/rest/connection.rb

@@ -505,7 +505,13 @@ module GoodData
                                           :verify_ssl => verify_ssl,
                                           :headers => @webdav_headers.merge(:x_gdc_authtt => headers[:x_gdc_authtt]),
                                           :payload => File.new(filename, 'rb'))
-        request.execute
+
+        begin
+          request.execute
+        rescue => e
+          GoodData.logger.error("Error when uploading file #{filename}", e)
+          raise e
+        end
       end
 
       def format_error(e, params = {})
@@ -575,7 +581,6 @@ ERR
         merge_headers! response.headers
         content_type = response.headers[:content_type]
         return response if process == false
-
         if content_type == 'application/json' || content_type == 'application/json;charset=UTF-8'
           result = response.to_str == '""' ? {} : MultiJson.load(response.to_str)
           GoodData.rest_logger.debug "Request ID: #{response.headers[:x_gdc_request]} - Response: #{result.inspect}"
@@ -591,6 +596,10 @@ ERR
         elsif response.code == 204
           result = nil
           GoodData.rest_logger.debug 'Response: 204 no content'
+        elsif response.code == 200 && content_type.nil? && response.body.empty?
+          result = nil
+          # TMA-696
+          GoodData.rest_logger.warn 'Got response status 200 but no content-type and body.'
         else
           fail "Unsupported response content type '%s':\n%s" % [content_type, response.to_str[0..127]]
         end
@@ -633,21 +642,35 @@ ERR
         ['/gdc/account/domains/{id}/users?login={login}', %r{/gdc/account/domains/[\w\d-]+/users\?login=[^&$]+}],
         ['/gdc/account/domains/{id}', %r{/gdc/account/domains/[\w\d-]+}],
 
-        ['/gdc/app/projects/{id}/execute', %r{/gdc/app/projects/[\w]+/execute}],
+        ['/gdc/projects/{id}/execute', %r{/gdc/projects/[\w]+/execute}],
 
         ['/gdc/datawarehouse/instances/{id}', %r{/gdc/datawarehouse/instances/[\w]+}],
         ['/gdc/datawarehouse/executions/{id}', %r{/gdc/datawarehouse/executions/[\w]+}],
 
         ['/gdc/domains/{id}/segments/{segment}/synchronizeClients/results/{result}/details?offset={offset}&limit={limit}',
-         %r{/gdc/domains/[\w]+/segments/[\w-]+/synchronizeClients/results/[\w]+/details/\?offset=[\d]+&limit=[\d]+}],
-        ['/gdc/domains/{id}/segments/{segment}/synchronizeClients/results/{result}', %r{/gdc/domains/[\w]+/segments/[\w-]+/synchronizeClients/results/[\w]+}],
-        ['/gdc/domains/{id}/segments/{segment}/', %r{/gdc/domains/[\w]+/segments/[\w-]+/}],
-        ['/gdc/domains/{id}/segments/{segment}', %r{/gdc/domains/[\w]+/segments/[\w-]+}],
-        ['/gdc/domains/{id}/clients?segment={segment}', %r{/gdc/domains/[\w]+/clients\?segment=[\w-]+}],
-        ['/gdc/domains/{id}/', %r{/gdc/domains/[\w]+/}],
+         %r{/gdc/domains/[\w-]+/segments/[\w-]+/synchronizeClients/results/[\w]+/details/\?offset=[\d]+&limit=[\d]+}],
+        ['/gdc/domains/{id}/segments/{segment}/synchronizeClients/results/{result}',
+         %r{/gdc/domains/[\w-]+/segments/[\w-]+/synchronizeClients/results/[\w]+}],
+        ['/gdc/domains/{id}/segments/{segment}/', %r{/gdc/domains/[\w-]+/segments/[\w-]+/}],
+        ['/gdc/domains/{id}/segments/{segment}', %r{/gdc/domains/[\w-]+/segments/[\w-]+}],
+        ['/gdc/domains/{id}/clients?segment={segment}', %r{/gdc/domains/[\w-]+/clients\?segment=[\w-]+}],
+        ['/gdc/domains/{id}/clients/{client_id}/settings/lcm.title', %r{/gdc/domains/[\w-]+/clients/[\w-]+/settings/lcm.title}],
+        ['/gdc/domains/{id}/clients/{client_id}/settings/lcm.token', %r{/gdc/domains/[\w-]+/clients/[\w-]+/settings/lcm.token}],
+        ['/gdc/domains/{id}/clients/{client_id}', %r{/gdc/domains/[\w-]+/clients/[\w-]+}],
+        ['/gdc/domains/{id}/provisionClientProjects/results/{result}/details?offset={offset}&limit={limit}',
+         %r{/gdc/domains/[\w-]+/provisionClientProjects/results/[\w]+/details/\?offset=[\d]+&limit=[\d]+}],
+        ['/gdc/domains/{id}/provisionClientProjects/results/{result}', %r{/gdc/domains/[\w-]+/provisionClientProjects/results/[\w]+}],
+        ['/gdc/domains/{id}/provisionClientProjects', %r{/gdc/domains/[\w-]+/provisionClientProjects}],
+        ['/gdc/domains/{id}/updateClients', %r{/gdc/domains/[\w-]+/updateClients}],
+        ['/gdc/domains/{id}/', %r{/gdc/domains/[\w-]+/}],
 
         ['/gdc/exporter/result/{id}/{id}', %r{/gdc/exporter/result/[\w]+/[\w]+}],
 
+        ['/gdc/internal/lcm/domains/{id}/dataproducts/{data_product}/segments/{segment}/syncProcesses/{process}',
+         %r{/gdc/internal/lcm/domains/[\w-]+/dataproducts/[\w-]+/segments/[\w-]+/syncProcesses/[\w]+}],
+        ['/gdc/internal/lcm/domains/{id}/dataproducts/{data_product}/segments/{segment}/syncProcesses',
+         %r{/gdc/internal/lcm/domains/[\w-]+/dataproducts/[\w-]+/segments/[\w-]+/syncProcesses}],
+
         ['/gdc/internal/projects/{id}/objects/setPermissions', %r{/gdc/internal/projects/[\w]+/objects/setPermissions}],
 
         ['/gdc/md/{id}/variables/item/{id}', %r{/gdc/md/[\w]+/variables/item/[\d]+}],

data/lib/gooddata/rest/object_factory.rb

@@ -18,25 +18,6 @@ module GoodData
       attr_accessor :objects
       attr_accessor :resources
 
-      #################################
-      # Class methods
-      #################################
-      class << self
-        # Gets list of all GoodData::Rest::Object subclasses
-        #
-        # @return [Array<GoodData::Rest::Object>] Subclasses of GoodData::Rest::Object
-        def objects
-          ObjectSpace.each_object(Class).select { |klass| klass < GoodData::Rest::Object }
-        end
-
-        # Gets list of all GoodData::Rest::Resource subclasses
-        #
-        # @return [Array<GoodData::Rest::Resource>] Subclasses of GoodData::Rest::Resource
-        def resources
-          ObjectSpace.each_object(Class).select { |klass| klass < GoodData::Rest::Resource }
-        end
-      end
-
       # Initializes instance of factory
       #
       # @param connection [GoodData::Rest::Connection] Connection used by factory
@@ -48,12 +29,6 @@ module GoodData
 
         # Set connection used by factory
         @connection = @client.connection
-
-        # Initialize internal factory map of GoodData::Rest::Object instances
-        @objects = ObjectFactory.objects
-
-        # Initialize internal factory map of GoodData::Rest::Resource instances
-        @resources = ObjectFactory.resources
       end
 
       def create(type, data = {}, opts = {})

data/lib/gooddata/version.rb

@@ -6,7 +6,7 @@
 
 # GoodData Module
 module GoodData
-  VERSION = '0.6.53'
+  VERSION = '0.6.54'
 
   class << self
     # Version

data/spec/data/blueprints/invalid_blueprint.json

@@ -22,11 +22,11 @@
         },
         {
           "type": "attribute",
-          "id" : "some_attr_id"
+          "id" : "some_attr_id(hello)"
         },
         {
           "type": "label",
-          "id" : "some_attr_label_id",
+          "id" : "some_label_id",
           "reference": "some_attr_id",
           "name": "email",
           "gd_data_type": "VARCHAR(128)",

data/spec/data/blueprints/test_project_model_spec.json

@@ -30,7 +30,7 @@
           "id" : "some_attr_label_id",
           "reference": "some_attr_id",
           "column_name": "repo_name",
-          "gd_data_type": "VARCHAR(128)",
+          "gd_data_type": "VARCHAR(10000)",
           "title": "Repository Name"
         }
       ]

data/spec/data/dynamic_schedule_params_table.csv

@@ -0,0 +1,7 @@
+client_id,param_name,param_value,schedule_title
+client_1,MODE,mode_a,rollout
+client_1,MODE,mode_e,
+client_2,MODE,mode_b,provisioning
+client_1,MODE,mode_c,release
+client_1,MODE,mode_x,
+,MODE,mode_all,

data/spec/data/workspace_table.csv

@@ -1,3 +1,3 @@
-client_id,segment_id,project_title
-client_foo,segment_foo,project_foo
-client_bar,segment_bar,project_bar
+client_id,segment_id,project_title,project_id
+client_foo,segment_foo,project_foo,123456
+client_bar,segment_bar,project_bar,

data/spec/environment/staging.rb

@@ -7,15 +7,15 @@
 module GoodData
   module Environment
     module ConnectionHelper
-      encrypted_token = 'YC+foKO2M8rIfB5gxF/sVvop5dRA7d/zLO/zzUlBr9ZimnoYe' \
-                           'LFyAqU20U4k\ncRYb\n'
+      encrypted_token = "YC+foKO2M8rIfB5gxF/sVvop5dRA7d/zLO/zzUlBr9ZimnoYe" \
+                        "LFyAqU20U4k\ncRYb\n"
       key = ENV['GD_SPEC_PASSWORD'] || ENV['BIA_ENCRYPTION_KEY']
       token = GoodData::Helpers.decrypt(encrypted_token, key)
       set_const :GD_PROJECT_TOKEN, token
       set_const :DEFAULT_DOMAIN, 'staging-lcm-prod'
       set_const :DEFAULT_SERVER, 'https://staging-lcm-prod.intgdc.com'
       set_const :DEFAULT_USER_URL, '/gdc/account/profile/e306b64fb4178785c9cf29c29b5e498a'
-      set_const :STAGING_URI, 'https://ea-di.staging.intgdc.com/uploads/'
+      set_const :STAGING_URI, 'https://staging-lcm-prod.intgdc.com/gdc/uploads/'
     end
 
     module ProcessHelper

data/spec/integration/ads_output_stage_spec.rb

@@ -9,16 +9,6 @@ require 'gooddata'
 describe GoodData::AdsOutputStage, :constraint => 'slow' do
   before(:all) do
     @client = ConnectionHelper.create_default_connection
-
-    # try to delete all posible ads
-    GoodData::DataWarehouse.all.map do |ads|
-      begin
-        ads.delete
-      rescue => e
-        puts "Cannot delete ads #{ads.id}. Reason: #{e.message}"
-      end
-    end
-
     @ads = GoodData::DataWarehouse.create(client: @client, title: 'Test ADS', auth_token: ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
     @project = @client.create_project(title: 'Test project', auth_token: ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
   end

data/spec/integration/clients_spec.rb

@@ -38,7 +38,7 @@ describe GoodData::Client do
     it 'Returns specific tenant when schedule ID passed' do
       client = @segment.clients(@segment_client)
       expect(client).to be_an_instance_of(GoodData::Client)
-      expect(client.uri).to eq @segment_client.uri
+      expect(client.client_id).to eq @segment_client.client_id
     end
 
     after(:all) do

data/spec/integration/date_dim_switch_spec.rb

@@ -40,6 +40,19 @@ describe "Swapping a date dimension and exchanging all attributes/elements", :co
     @client.disconnect
   end
 
+  it 'should not get error when execute report with timestamp' do
+    metric = @project.attributes('created_on.date').create_metric(title: 'test_metric')
+    metric.save
+
+    report = @project.create_report(
+      left: metric,
+      top: ['created_on.quarter'],
+      filters: [['created_on.year', 2015, 2016]],
+      title: 'test_report'
+    )
+    report.execute(time: Time.now)
+  end
+
   it "should swap the dimension, exchange all stuffs and not break anything" do
     # WE have 2 date dims
     expect(@blueprint.date_dimensions.map(&:id)).to eq %w(created_on created_on_2)

data/spec/integration/full_process_schedule_spec.rb

@@ -272,10 +272,10 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
 
   it 'should be able to deploy from app_store' do
     begin
-      process = @project.deploy_process('https://github.com/gooddata/app_store/tree/sfdc_downloader_brick-v0.0.4/apps/ads_integrator_brick')
+      process = @project.deploy_process('${PRODUCTION_APPSTORE}:branch/master:/apps/hello_world_brick', name: 'hello_world_brick')
       expect(process.class).to eq GoodData::Process
     ensure
-      process.delete
+      process.delete if process
     end
   end
 

data/spec/integration/helpers_spec.rb

@@ -0,0 +1,16 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require 'gooddata/client'
+require 'gooddata/models/model'
+
+describe GoodData::Helpers do
+  describe '#find_goodfile' do
+    it 'works' do
+      GoodData::Helpers.find_goodfile.should_not be_nil
+    end
+  end
+end

data/spec/integration/lcm_spec.rb

@@ -37,8 +37,18 @@ describe GoodData::LCM, :constraint => 'slow' do
   end
 
   it 'should be able to transfer color palette' do
-    @source_project.create_custom_color_palette([{ r: 155, g: 255, b: 0 }])
+    color_palettes = [
+      {
+        guid: 'hello',
+        fill: {
+          r: 155,
+          g: 255,
+          b: 0
+        }
+      }
+    ]
+    @source_project.create_custom_color_palette(color_palettes)
     GoodData::Project.transfer_color_palette(@source_project, @target_project)
-    expect(@target_project.current_color_palette.colors).to eq [{ r: 155, g: 255, b: 0 }]
+    expect(@target_project.current_color_palette.colors).to eq color_palettes.map { |color| GoodData::Helpers.stringify_keys(color) }
   end
 end

data/spec/integration/mixins/id_to_uri_spec.rb

@@ -0,0 +1,44 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require 'gooddata/mixins/md_id_to_uri'
+
+describe GoodData::Mixin::MdIdToUri do
+  before :each do
+    @client = ConnectionHelper.create_default_connection
+    project = ProjectHelper.get_default_project(client: @client)
+
+    class SomeTestClass
+      extend GoodData::Mixin::MdIdToUri
+    end
+
+    @opts = { client: @client, project: project }
+  end
+
+  after(:each) do
+    @client.disconnect
+  end
+
+  it 'should throw BadRequest for -1' do
+    expect do
+      SomeTestClass.identifier_to_uri(@opts, '-1')
+    end.to raise_error(RestClient::BadRequest) { |error|
+      error.response.should match(/does not match with value '-1'/)
+    }
+  end
+
+  it 'should return nil for unknown id' do
+    expect(SomeTestClass.identifier_to_uri(@opts, '0')).to be_nil
+  end
+
+  it 'should get json containing correct id' do
+    facts = GoodData::Fact.all(@opts)
+    fact  = facts.to_a.first
+    uri = SomeTestClass.identifier_to_uri(@opts, fact.identifier)
+    res = @client.get(uri)
+    expect(res['fact']['meta']['identifier']).to eq fact.identifier
+  end
+end

data/spec/integration/models/data_product_spec.rb

@@ -0,0 +1,71 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require 'gooddata/models/segment'
+require 'securerandom'
+
+describe GoodData::DataProduct do
+  before(:all) do
+    @client = ConnectionHelper.create_default_connection
+    @domain = @client.domain(ConnectionHelper::DEFAULT_DOMAIN)
+  end
+
+  before(:each) do
+    @uuid = SecureRandom.uuid
+    @data_product_id = "data-product-#{@uuid}"
+    @data_product = @domain.create_data_product(id: @data_product_id)
+  end
+
+  after(:each) do
+    @data_product && @data_product.delete(force: true)
+  end
+
+  after(:all) do
+    @client.disconnect
+  end
+
+  describe '#[]' do
+    it 'Returns all data products when :all passed' do
+      res = @domain.data_products
+      expect(res).to be_an_instance_of(Array)
+    end
+
+    it 'Returns specific data product when data product ID passed' do
+      data_product = @domain.data_products(@data_product_id)
+      expect(data_product.uri).to eq @data_product.uri
+      expect(data_product).to be_an_instance_of(GoodData::DataProduct)
+    end
+  end
+
+  describe '#delete' do
+    it 'Deletes particular data product' do
+      old_count = @domain.data_products.count
+      @data_product.delete
+      expect(@domain.data_products.length).to eq(old_count - 1)
+      # prevent delete attempt in the after hook
+      @data_product = nil
+    end
+  end
+
+  describe '#save' do
+    it 'can update a data product id' do
+      @data_product.data_product_id = 'different_id'
+      @data_product.save
+    end
+  end
+
+  describe '#create_segment' do
+    before do
+      @master_project = @client.create_project(title: "Test MASTER project for #{@uuid}", auth_token: ConnectionHelper::GD_PROJECT_TOKEN)
+    end
+
+    it 'creates a segment' do
+      segment = @data_product.create_segment(segment_id: "test-segment-#{@uuid}", master_project: @master_project)
+      expect(segment).to be_instance_of GoodData::Segment
+      expect(segment.data_product.data_product_id).to eq(@data_product_id)
+    end
+  end
+end